Re: Commit 957b615b (Fix another crash with Grid pasting) breaks compilation with Visual C++ 2019

2020-08-16 Thread Jürgen Spitzmüller
Am Sonntag, den 16.08.2020, 21:26 +0100 schrieb José Abílio Matos: > What is wrong with > > pos_type ipos = min(cur.pos(), cell(i).size()); > > it expresses intent better than the other code, no? :-) This was my first choice, too. However, it triggers: mathed/InsetMathGrid.cpp:1637:51:

de User Guide compilation error from Makeindex

2020-08-16 Thread Scott Kostyshak
I get the following when compiling the German User Guide with pdflatex on master: !! Input index error (file = UserGuide.nlo, line = 6): -- Extra `!' at position 11 of first argument. done (7 entries accepted, 1 rejected). I think the problem was there before but on master we just

Re: de User Guide compilation error from Makeindex

2020-08-16 Thread Scott Kostyshak
On Mon, Aug 17, 2020 at 07:44:38AM +0200, Jürgen Spitzmüller wrote: > Am Montag, den 17.08.2020, 01:35 -0400 schrieb Scott Kostyshak: > > I get the following when compiling the German User Guide with > > pdflatex > > on master: > > > > !! Input index error (file = UserGuide.nlo, line = 6): > >

Re: Commit 957b615b (Fix another crash with Grid pasting) breaks compilation with Visual C++ 2019

2020-08-16 Thread Jürgen Spitzmüller
Am Sonntag, den 16.08.2020, 21:29 +0200 schrieb Stephan Witt: > This patch works with clang and avoids a type mismatch warning for > signed vs unsigned typed values comparison. This works for me, too. Please commit. Jürgen signature.asc Description: This is a digitally signed message part --

Re: de User Guide compilation error from Makeindex

2020-08-16 Thread Jürgen Spitzmüller
Am Montag, den 17.08.2020, 01:35 -0400 schrieb Scott Kostyshak: > I get the following when compiling the German User Guide with > pdflatex > on master: > > !! Input index error (file = UserGuide.nlo, line = 6): > -- Extra `!' at position 11 of first argument. > done (7 entries accepted,

Re: Crash in export of American_Psychological_Association_%28APA%29,_v._7_

2020-08-16 Thread Jürgen Spitzmüller
Am Sonntag, den 16.08.2020, 10:12 +0200 schrieb Enrico Forestieri: > I don't think they are specifically do to math macros. Some failures > can > > be avoided by declaring, for example, InsetInclude as an > allowMultipar() > > inset. Some seems to be due to the fact that InsetMathMacroTemplate >

Re: Crash in export of American_Psychological_Association_%28APA%29,_v._7_

2020-08-16 Thread Kornel Benko
Am Sun, 16 Aug 2020 11:20:09 +0200 schrieb Jürgen Spitzmüller : > These are fixed as well. > Now all files listed by you seem to compile here. What does the test > machinery say? > > Jürgen Looks good. Tested 410 (out of 3845), until now all successful. Next message in 1 hour. Kornel

Re: Allow empty line ... I know

2020-08-16 Thread Daniel
On 2020-08-15 16:58, Jean-Marc Lasgouttes wrote: There is a problem reported about space above formula. I have not looked at it yet. I found a report but it is specifically about preview: https://www.lyx.org/trac/ticket/11772. I don't think this one is related at all. -- Daniel --

Re: Crash in export of American_Psychological_Association_%28APA%29,_v._7_

2020-08-16 Thread Kornel Benko
Am Sun, 16 Aug 2020 13:24:25 +0200 schrieb Jürgen Spitzmüller : > Am Sonntag, den 16.08.2020, 13:14 +0200 schrieb Kornel Benko: > > Attached a summary. Good work! > > Thanks. I found a broken case, though: >

Re: [LyX/master] Correctly set font decorations for multipar insets

2020-08-16 Thread Enrico Forestieri
On Sat, Aug 15, 2020 at 07:10:33AM +0200, Jürgen Spitzmüller wrote: > Am Freitag, den 14.08.2020, 18:04 +0200 schrieb Enrico Forestieri: > > I reverted the commit, so it's all yours again. You also have a hint > > of how about solving the bug addressed by it. Let me know if you need > > help. > >

Re: Crash in export of American_Psychological_Association_%28APA%29,_v._7_

2020-08-16 Thread Jürgen Spitzmüller
Am Samstag, den 15.08.2020, 20:58 +0200 schrieb Kornel Benko: > Hm, you was right. Sort of. These are not broken by the last commit. > 422:DEFAULTOUTPUT_export/export/latex/languages/cyrillic-languages- > conflict_pdf2 Fixed. > 2613:export/doc/fr/Intro_dvi > 2614:export/doc/fr/Intro_dvi3_texF

Re: Crash in export of American_Psychological_Association_%28APA%29,_v._7_

2020-08-16 Thread Kornel Benko
Am Sun, 16 Aug 2020 12:44:10 +0200 schrieb Kornel Benko : > Am Sun, 16 Aug 2020 11:20:09 +0200 > schrieb Jürgen Spitzmüller : > > > These are fixed as well. > > Now all files listed by you seem to compile here. What does the test > > machinery say? > > > > Jürgen > > Looks good. Tested 410

Re: Layout list WYSIWYM

2020-08-16 Thread Daniel
On 2020-08-03 15:49, Pavel Sanda wrote: On Sun, Aug 02, 2020 at 12:04:46PM +0200, Jean-Marc Lasgouttes wrote: Le 2 ao??t 2020 10:18:50 GMT+02:00, "Jürgen Spitzmüller" a écrit : Am Sonntag, den 02.08.2020, 09:44 +0200 schrieb Daniel: Do you prefer a ui or non-ui switch? A pref entry would

Re: Crash in export of American_Psychological_Association_%28APA%29,_v._7_

2020-08-16 Thread Enrico Forestieri
On Sat, Aug 15, 2020 at 05:09:17PM +0200, Jürgen Spitzmüller wrote: > Am Samstag, den 15.08.2020, 16:49 +0200 schrieb Jürgen Spitzmüller: > > Am Samstag, den 15.08.2020, 15:49 +0200 schrieb Kornel Benko: > > > 7509:export/mathmacros/masterOfSpace_dvi > > >

Re: Crash in export of American_Psychological_Association_%28APA%29,_v._7_

2020-08-16 Thread Jürgen Spitzmüller
Am Samstag, den 15.08.2020, 17:09 +0200 schrieb Jürgen Spitzmüller: > Am Samstag, den 15.08.2020, 16:49 +0200 schrieb Jürgen Spitzmüller: > > Am Samstag, den 15.08.2020, 15:49 +0200 schrieb Kornel Benko: > > > 7509:export/mathmacros/masterOfSpace_dvi > > >

Re: Crash in export of American_Psychological_Association_%28APA%29,_v._7_

2020-08-16 Thread Jürgen Spitzmüller
Am Sonntag, den 16.08.2020, 13:14 +0200 schrieb Kornel Benko: > Attached a summary. Good work! Thanks. I found a broken case, though: https://www.lyx.org/trac/raw-attachment/ticket/10110/Mixed%20LTR-RTL_Arabi-stadard-font.lyx Currently investigating. Maybe this should be added to the set of

Re: Commit 957b615b (Fix another crash with Grid pasting) breaks compilation with Visual C++ 2019

2020-08-16 Thread Stephan Witt
Am 16.08.2020 um 21:00 schrieb Stephan Witt : > > Am 16.08.2020 um 19:23 schrieb Thibaut Cuvelier : >> >> Hi, >> >> I just tried to compile the latest version of the code with Visual C++. >> However, it chokes on line 1637 of InsetMathGrid.cpp: >> >> error C3861: 'uint': identifier not found

Re: [LyX/master] New attempt on #9906: allow following hyperlinks via context menu.

2020-08-16 Thread Pavel Sanda
On Sun, Aug 16, 2020 at 02:21:35PM -0400, Scott Kostyshak wrote: > On Sun, Aug 16, 2020 at 04:34:36PM +0200, Pavel Sanda wrote: > > On Sun, Aug 16, 2020 at 10:01:22AM -0400, Scott Kostyshak wrote: > > > > I like that idea a lot and would personally find it helpful. Here is a > > > related

Re: Layout list WYSIWYM

2020-08-16 Thread Jean-Marc Lasgouttes
Le 16 août 2020 21:27:44 GMT+02:00, racoon a écrit : >>In general, ever thought about a further switch called "Advanced >Preferences"? Adding an "advanced preference" section is a good sign that there is a preference issue ;) Here is some interesting reading from Gnome hacker Havoc Pennington

Re: [LyX/master] New attempt on #9906: allow following hyperlinks via context menu.

2020-08-16 Thread Scott Kostyshak
On Mon, Aug 17, 2020 at 12:10:24AM +0200, Pavel Sanda wrote: > Attached is updated patch. > For a given citation it does: > 1. check for existence of file= field in bib file, if found launch pdf viewer. > 2. else check for existence of DOI/URL in bib file. If found launch browser > with DOI/URL

Re: Layout list WYSIWYM

2020-08-16 Thread Pavel Sanda
On Sun, Aug 16, 2020 at 09:16:05PM +0200, Jean-Marc Lasgouttes wrote: > Le 16 ao??t 2020 16:08:25 GMT+02:00, racoon a écrit : > > > >On 2020-08-16 16:06, Richard Kimberly Heck wrote: > >> Pavel was joking. > > Was he? I was actually serious. It's absurd to introduce new GUI switch for the sake

Re: [LyX/master] New attempt on #9906: allow following hyperlinks via context menu.

2020-08-16 Thread Scott Kostyshak
On Sun, Aug 16, 2020 at 04:34:36PM +0200, Pavel Sanda wrote: > On Sun, Aug 16, 2020 at 10:01:22AM -0400, Scott Kostyshak wrote: > > I like that idea a lot and would personally find it helpful. Here is a > > related request, although not many extra details: > > > > > >

Commit 957b615b (Fix another crash with Grid pasting) breaks compilation with Visual C++ 2019

2020-08-16 Thread Thibaut Cuvelier
Hi, I just tried to compile the latest version of the code with Visual C++. However, it chokes on line 1637 of InsetMathGrid.cpp : error C3861: 'uint': identifier not found

Re: Commit 957b615b (Fix another crash with Grid pasting) breaks compilation with Visual C++ 2019

2020-08-16 Thread Stephan Witt
Am 16.08.2020 um 19:23 schrieb Thibaut Cuvelier : > > Hi, > > I just tried to compile the latest version of the code with Visual C++. > However, it chokes on line 1637 of InsetMathGrid.cpp: > > error C3861: 'uint': identifier not found > > Here is my (simple) fix, in bold (formal patch

Re: Layout list WYSIWYM

2020-08-16 Thread Jean-Marc Lasgouttes
Le 16 août 2020 16:08:25 GMT+02:00, racoon a écrit : > >On 2020-08-16 16:06, Richard Kimberly Heck wrote: >> Pavel was joking. Was he? >I see. I am still not sure about JMarc though. Anyway, I'll add a gui >switch as Jürgen asked for. In general, I am against a new switch, but I would have to

Re: Layout list WYSIWYM

2020-08-16 Thread racoon
On 2020-08-16 16:06, Richard Kimberly Heck wrote: On 8/16/20 3:24 AM, Daniel wrote: On 2020-08-03 15:49, Pavel Sanda wrote: On Sun, Aug 02, 2020 at 12:04:46PM +0200, Jean-Marc Lasgouttes wrote: Le 2 ao??t 2020 10:18:50 GMT+02:00, "Jürgen Spitzmüller" a écrit : Am Sonntag, den 02.08.2020,

Re: Layout list WYSIWYM

2020-08-16 Thread Richard Kimberly Heck
On 8/16/20 3:24 AM, Daniel wrote: > On 2020-08-03 15:49, Pavel Sanda wrote: >> On Sun, Aug 02, 2020 at 12:04:46PM +0200, Jean-Marc Lasgouttes wrote: >>> Le 2 ao??t 2020 10:18:50 GMT+02:00, "Jürgen Spitzmüller" >>> a écrit : Am Sonntag, den 02.08.2020, 09:44 +0200 schrieb Daniel: > Do you

Re: Allow empty line ... I know

2020-08-16 Thread Yu Jin
Am So., 16. Aug. 2020 um 13:12 Uhr schrieb Daniel : > On 2020-08-15 16:58, Jean-Marc Lasgouttes wrote: > > There is a problem reported about space above formula. I have not looked > at it yet. > > I found a report but it is specifically about preview: > https://www.lyx.org/trac/ticket/11772. > >

Re: [LyX/master] New attempt on #9906: allow following hyperlinks via context menu.

2020-08-16 Thread Scott Kostyshak
On Sat, Aug 15, 2020 at 08:01:04PM +0200, Pavel Sanda wrote: > On Fri, Aug 14, 2020 at 07:23:09PM +0200, Pavel Sanda wrote: > > commit 48b1e8a0aca2f3f3faa8f1f800568e47792ba9a0 > > Author: Pavel Sanda > > Date: Fri Aug 14 19:46:13 2020 +0200 > > > > New attempt on #9906: allow following

Re: [LyX/master] New attempt on #9906: allow following hyperlinks via context menu.

2020-08-16 Thread Pavel Sanda
On Sun, Aug 16, 2020 at 10:01:22AM -0400, Scott Kostyshak wrote: > > As a somewhat related issue I have very rough code (i.e. intended for my > > private patchset) which allows viewing papers cited in the document via > > the context menu of citation inset. > > > > ATM it is really shaped for my

Re: [LyX/master] New attempt on #9906: allow following hyperlinks via context menu.

2020-08-16 Thread Pavel Sanda
On Fri, Aug 14, 2020 at 07:23:09PM +0200, Pavel Sanda wrote: > commit 48b1e8a0aca2f3f3faa8f1f800568e47792ba9a0 > Author: Pavel Sanda > Date: Fri Aug 14 19:46:13 2020 +0200 > > New attempt on #9906: allow following hyperlinks via context menu. > > Now safer version with the help of

Re: [LyX/master] Does not compile on older gcc.

2020-08-16 Thread Thibaut Cuvelier
> > On Tue, Aug 04, 2020 at 02:30:10PM +0200, Pavel Sanda wrote: > commit bd5f6097fc33d24f39660c38267793f6776f6cd7 >> > Author: Pavel Sanda >> > Date: Tue Aug 4 14:54:15 2020 +0200 >> > >> > Does not compile on older gcc. >> >> Thibaut, you might want to check whether this still works as

Re: Layout list WYSIWYM

2020-08-16 Thread racoon
On 2020-08-16 21:16, Jean-Marc Lasgouttes wrote: Le 16 août 2020 16:08:25 GMT+02:00, racoon a écrit : On 2020-08-16 16:06, Richard Kimberly Heck wrote: Pavel was joking. Was he? I see. I am still not sure about JMarc though. Anyway, I'll add a gui switch as Jürgen asked for. In

Re: Crash in export of American_Psychological_Association_%28APA%29,_v._7_

2020-08-16 Thread Jürgen Spitzmüller
Am Sonntag, den 16.08.2020, 13:38 +0200 schrieb Kornel Benko: > Yes please. Add it to 'autotests/export/latex/languages' dir. Done. I let you handle the rest. The bug itself turns out to be pretty resilient :-/ Jürgen signature.asc Description: This is a digitally signed message part --

Re: Crash in export of American_Psychological_Association_%28APA%29,_v._7_

2020-08-16 Thread Kornel Benko
Am Sun, 16 Aug 2020 17:31:54 +0200 schrieb Jürgen Spitzmüller : > Am Sonntag, den 16.08.2020, 13:38 +0200 schrieb Kornel Benko: > > Yes please. Add it to 'autotests/export/latex/languages' dir. > > Done. I let you handle the rest. > > The bug itself turns out to be pretty resilient :-/ > >

Re: Allow empty line ... I know

2020-08-16 Thread Richard Kimberly Heck
On 8/16/20 10:07 AM, Yu Jin wrote: > Am So., 16. Aug. 2020 um 13:12 Uhr schrieb Daniel >: > > On 2020-08-15 16:58, Jean-Marc Lasgouttes wrote: > > There is a problem reported about space above formula. I have > not looked at it yet. > > I found a report but

Re: Commit 957b615b (Fix another crash with Grid pasting) breaks compilation with Visual C++ 2019

2020-08-16 Thread José Abílio Matos
On Sunday, 16 August 2020 20.29.50 WEST Stephan Witt wrote: > This patch works with clang and avoids a type mismatch warning for signed vs > unsigned typed values comparison. > > Stephan What is wrong with pos_type ipos = min(cur.pos(), cell(i).size()); it expresses intent better than the