Re: Bug #11484

2021-04-24 Thread Scott Kostyshak
On Sat, Apr 24, 2021 at 08:21:27AM +0200, Jürgen Spitzmüller wrote: > Am Freitag, dem 23.04.2021 um 15:21 -0400 schrieb Scott Kostyshak: > > I do not think the new GUI behavior is good > > Proceed as you see fit. Fine with me. It would be nice to hear from Jürgen Womser-Schütz on their thoughts.

Re: Bug #11484

2021-04-24 Thread Jürgen Spitzmüller
Am Freitag, dem 23.04.2021 um 15:21 -0400 schrieb Scott Kostyshak: > I do not think the new GUI behavior is good Proceed as you see fit. Fine with me. Jürgen signature.asc Description: This is a digitally signed message part -- lyx-devel mailing list lyx-devel@lists.lyx.org

Re: Bug #11484

2021-04-23 Thread Scott Kostyshak
On Fri, Apr 23, 2021 at 06:58:16AM +0200, Jürgen Spitzmüller wrote: > Am Donnerstag, dem 22.04.2021 um 13:18 -0400 schrieb Scott Kostyshak: > > I wonder if using branches would be a better way to achieve the > > desired workflow above. I believe we should preserve the previous > > default behavior

Re: Bug #11484

2021-04-23 Thread Jürgen Spitzmüller
Am Freitag, dem 23.04.2021 um 06:58 +0200 schrieb Jürgen Spitzmüller: > Note that I mean this as an option for warning which we think require > attention (but are not errors). We could add an option > "cl_confirmation" to alert::warning, defaulting to false and enabled > for this particular

Re: Bug #11484

2021-04-22 Thread Jürgen Spitzmüller
Am Donnerstag, dem 22.04.2021 um 13:18 -0400 schrieb Scott Kostyshak: > I wonder if using branches would be a better way to achieve the > desired workflow above. I believe we should preserve the previous > default behavior of giving an error in the GUI when there is a > missing included file. But

Re: Bug #11484

2021-04-22 Thread Scott Kostyshak
On Sun, Apr 18, 2021 at 09:14:17AM +0200, Jürgen Spitzmüller wrote: > Am Freitag, dem 16.04.2021 um 12:43 -0400 schrieb Scott Kostyshak: > > Thanks to the Jürgens for your work on this. On master branch, if I > > export a file on the command-line with a child document that is not > > found, I no

Re: Bug #11484

2021-04-18 Thread Jürgen Spitzmüller
Am Freitag, dem 16.04.2021 um 12:43 -0400 schrieb Scott Kostyshak: > Thanks to the Jürgens for your work on this. On master branch, if I > export a file on the command-line with a child document that is not > found, I no longer get an error and the command exits "successfully" > (i.e., 0 exit

Re: Bug #11484

2021-04-16 Thread Scott Kostyshak
On Tue, Mar 12, 2019 at 09:02:22AM +0100, Jürgen Spitzmüller wrote: > Am Montag, den 11.03.2019, 18:59 +0100 schrieb Jürgen Womser-Schütz: > > Hello Jürgen, > > > > I think it is now much better than I could do it without your help. Thanks to the Jürgens for your work on this. On master branch,

Re: Bug #11484

2019-03-12 Thread Jürgen Spitzmüller
Am Montag, den 11.03.2019, 18:59 +0100 schrieb Jürgen Womser-Schütz: > Hello Jürgen, > > I think it is now much better than I could do it without your help. We are a collaborative project, after all. > But > I am still learning :-) So am I. > Another thing: > In the case of include type

Re: Bug #11484

2019-03-11 Thread Jürgen Womser-Schütz
Hello Jürgen, I think it is now much better than I could do it without your help. But I am still learning :-) Another thing: In the case of include type "Input" or "Include" only LyX or LaTeX-files are meaningful. I wasn't aware this fact during my tests and so I got conversion errors because I

Re: Bug #11484

2019-03-11 Thread Jürgen Spitzmüller
Am Mo., 11. März 2019 um 08:40 Uhr schrieb Jürgen Spitzmüller > Some more comments: > The attached patch includes my suggestions (incl. the ltrimming of the file name). What do you think, Jürgen? Jürgen (not talking to himself) diff --git a/src/insets/InsetInclude.cpp

Re: Bug #11484

2019-03-11 Thread Jürgen Spitzmüller
Am Mo., 11. März 2019 um 08:40 Uhr schrieb Jürgen Spitzmüller: > BTW I see that the file name is not trimmed (hence " " is not treated as > empty filename); we should probably do that: > > if (trim(params()["filename"]).empty()) > temp += "???"; > It turns out we need to ltrim the file

Re: Bug #11484

2019-03-11 Thread Jürgen Spitzmüller
Am So., 10. März 2019 um 21:56 Uhr schrieb Jürgen Womser-Schütz < jws1...@gmx.de>: > Jürgen's improvements for "GNU Gettext" are now includet. > I looked into the documentation (chapter "Child Documents" in the > "Embedded Objects" helpfile ): a change seems to me not really necessary. > Maybe

Re: Bug #11484

2019-03-10 Thread Jürgen Womser-Schütz
Hi, Jürgen's  improvements for "GNU Gettext" are now includet. I looked into the documentation (chapter "Child Documents" in the "Embedded Objects" helpfile ): a change seems to me not really necessary. Maybe it is self explanatory enough. Jürgen Am 10.03.2019 um 19:17 schrieb Jürgen

Re: Bug #11484

2019-03-10 Thread Jürgen Spitzmüller
Am Sonntag, den 10.03.2019, 19:08 +0100 schrieb Jürgen Womser-Schütz: > Ahh, I see: _() is the C++ user defined flag for enabling the > translation machinery! I couldn't find the definition :-( src/support/getttext.h Jürgen signature.asc Description: This is a digitally signed message part

Re: Bug #11484

2019-03-10 Thread Jürgen Womser-Schütz
Am 10.03.2019 um 18:26 schrieb Jürgen Spitzmüller: > Am Sonntag, den 10.03.2019, 17:38 +0100 schrieb Jürgen Womser-Schütz: >> PS: If the small change is worth to merge in LyX: what is about the >> translation of the new introduced string into all supported languages > Our l7n machinery will

Re: Bug #11484

2019-03-10 Thread Jürgen Spitzmüller
Am Sonntag, den 10.03.2019, 17:38 +0100 schrieb Jürgen Womser-Schütz: > PS: If the small change is worth to merge in LyX: what is about the > translation of the new introduced string into all supported languages Our l7n machinery will catch this string and add it to the po files for translation.

Re: Bug #11484

2019-03-10 Thread Jürgen Womser-Schütz
Hi, I have a revised patch for the little problem of an possibly non existing user-provided listing file in LyX child-document dialog. Following JMarc's suggestion I am now altering the label-text of the Include-inset by an additional string "FILE MISSING: " (of course only if the file is

Re: Bug #11484

2019-02-26 Thread Jürgen Womser-Schütz
Am 25.02.2019 um 18:33 schrieb Jean-Marc Lasgouttes: > Le 22/02/2019 à 21:29, Jürgen Womser-Schütz a écrit : >> Hi alltogether, >> >> I have a revised patch for the little problem of possibly non existing >> user-provided listing file in LyX child-document dialog. >> If the listing file don't

Re: Bug #11484

2019-02-25 Thread Jean-Marc Lasgouttes
Le 22/02/2019 à 21:29, Jürgen Womser-Schütz a écrit : Hi alltogether, I have a revised patch for the little problem of possibly non existing user-provided listing file in LyX child-document dialog. If the listing file don't exist, a warning QMessageBox is displayed:     "The listing file "

Re: Bug #11484

2019-02-22 Thread Jürgen Womser-Schütz
Hi alltogether, I have a revised patch for the little problem of possibly non existing user-provided listing file in LyX child-document dialog. If the listing file don't exist, a warning QMessageBox is displayed:     "The listing file " FILENAME " does not exist. You will not be able to export

Re: Bug #11484

2019-02-11 Thread Jürgen Womser-Schütz
Hi alltogether, I hereby grant permission to use my work for LyX under the license GPL version 2 or later. Best regards Jürgen Am 06.02.2019 um 16:25 schrieb Jürgen Womser-Schütz: > Hi, > > in the surrounding field of bug #11484 I tried to improve the "user > experiance" by checking the

Re: Bug #11484

2019-02-11 Thread Jürgen Womser-Schütz
Am 10 Feb 2019 um 09:23:53 schrieb Jean-Marc Lasgouttes: > Dear Jürgen, > > I have a question: is the effect of your patch to disable the OK button when > the file does not exist? If it is the case, I am not sure that it will > considered as an improvement by everyone. I am not a heavy

Re: Bug #11484

2019-02-10 Thread Jean-Marc Lasgouttes
Le 06/02/2019 à 16:25, Jürgen Womser-Schütz a écrit : Hi, in the surrounding field of bug #11484 I tried to improve the "user experiance" by checking the existence of the user-specified listing file. I changed two files:     src/frontends/qt4/GuiInclude.cpp     src/frontends/qt4/GuiInclude.h

Re: Bug #11484

2019-02-10 Thread Kornel Benko
Am Mittwoch, 6. Februar 2019 17:57:55 CET schrieb Jürgen Womser-Schütz : > ... and a patch to git-master for convenience. > > Jürgen > Jürgen, if we would apply your patches, we would need your explicit permission. Like a short message on this list containing: "I hereby grant

Re: Bug #11484

2019-02-10 Thread Jürgen Womser-Schütz
Hi, you are right - maybe I am a bit "over-enthusiastic" :-) Jürgen Am 09.02.2019 um 22:48 schrieb Richard Kimberly Heck: > On 2/8/19 8:53 PM, Scott Kostyshak wrote: >> On Fri, Feb 08, 2019 at 10:40:48PM +0100, Kornel Benko wrote: >>> Am Freitag, 8. Februar 2019 22:14:55 CET schrieb Jürgen

Re: Bug #11484

2019-02-09 Thread Richard Kimberly Heck
On 2/8/19 8:53 PM, Scott Kostyshak wrote: > On Fri, Feb 08, 2019 at 10:40:48PM +0100, Kornel Benko wrote: >> Am Freitag, 8. Februar 2019 22:14:55 CET schrieb Jürgen Womser-Schütz >> : >>> Hi alltogether, as I can see: no volunteers desired. >>> Best regards Jürgen >>> >>> >>> Am 06.02.2019 um

Re: Bug #11484

2019-02-08 Thread Scott Kostyshak
On Fri, Feb 08, 2019 at 10:40:48PM +0100, Kornel Benko wrote: > Am Freitag, 8. Februar 2019 22:14:55 CET schrieb Jürgen Womser-Schütz > : > > Hi alltogether, as I can see: no volunteers desired. > > Best regards Jürgen > > > > > > Am 06.02.2019 um 16:25 schrieb Jürgen Womser-Schütz: > > > Hi, >

Re: Bug #11484

2019-02-08 Thread Kornel Benko
Am Freitag, 8. Februar 2019 22:14:55 CET schrieb Jürgen Womser-Schütz : > Hi alltogether, as I can see: no volunteers desired. > Best regards Jürgen > > > Am 06.02.2019 um 16:25 schrieb Jürgen Womser-Schütz: > > Hi, > > > > in the surrounding field of bug #11484 I tried to improve the "user > >

Re: Bug #11484

2019-02-08 Thread Jürgen Womser-Schütz
Hi alltogether, as I can see: no volunteers desired. Best regards Jürgen Am 06.02.2019 um 16:25 schrieb Jürgen Womser-Schütz: > Hi, > > in the surrounding field of bug #11484 I tried to improve the "user > experiance" by checking the existence of the user-specified listing file. > I changed two

Re: Bug #11484

2019-02-06 Thread Jürgen Womser-Schütz
... and a patch to git-master for convenience. Jürgen Am 06.02.2019 um 16:25 schrieb Jürgen Womser-Schütz: > Hi, > > in the surrounding field of bug #11484 I tried to improve the "user > experiance" by checking the existence of the user-specified listing file. > I changed two files: >