Re: LyX very slow to end (master)

On Wed, Oct 18, 2017 at 08:55:35PM +, Richard Heck wrote: > > I have backported it at 054b7c68. > > Thank you! Thank you for the patch, tested and works well. Scott signature.asc Description: PGP signature

Re: LyX very slow to end (master)

On 10/18/2017 04:14 PM, Enrico Forestieri wrote: > On Wed, Oct 18, 2017 at 11:30:43AM -0400, Richard Heck wrote: >> On 10/18/2017 08:20 AM, Guenter Milde wrote: >>> On 2017-10-18, Enrico Forestieri wrote: On Wed, Oct 18, 2017 at 11:39:30AM +0200, Jean-Marc Lasgouttes wrote: > Le

Re: LyX very slow to end (master)

On Wed, Oct 18, 2017 at 11:30:43AM -0400, Richard Heck wrote: > On 10/18/2017 08:20 AM, Guenter Milde wrote: > > On 2017-10-18, Enrico Forestieri wrote: > >> On Wed, Oct 18, 2017 at 11:39:30AM +0200, Jean-Marc Lasgouttes wrote: > >>> Le 18/10/2017 à 11:07, Enrico Forestieri a écrit : > > You

Re: LyX very slow to end (master)

On 10/18/2017 08:20 AM, Guenter Milde wrote: > On 2017-10-18, Enrico Forestieri wrote: >> On Wed, Oct 18, 2017 at 11:39:30AM +0200, Jean-Marc Lasgouttes wrote: >>> Le 18/10/2017 à 11:07, Enrico Forestieri a écrit : > You have to declare it outside of the lyx:: namespace, like in the >

Re: LyX very slow to end (master)

On 2017-10-18, Enrico Forestieri wrote: > On Wed, Oct 18, 2017 at 11:39:30AM +0200, Jean-Marc Lasgouttes wrote: >> Le 18/10/2017 à 11:07, Enrico Forestieri a écrit : >> > > You have to declare it outside of the lyx:: namespace, like in the >> > > attached >> > > version. >> > >> > Doh! Please,

Re: LyX very slow to end (master)

On Wed, Oct 18, 2017 at 01:32:09PM +0200, Pavel Sanda wrote: > Enrico Forestieri wrote: > > On Wed, Oct 18, 2017 at 11:39:30AM +0200, Jean-Marc Lasgouttes wrote: > > > Le 18/10/2017 ? 11:07, Enrico Forestieri a écrit : > > > > > You have to declare it outside of the lyx:: namespace, like in the >

Re: LyX very slow to end (master)

Enrico Forestieri wrote: > On Wed, Oct 18, 2017 at 11:39:30AM +0200, Jean-Marc Lasgouttes wrote: > > Le 18/10/2017 ? 11:07, Enrico Forestieri a écrit : > > > > You have to declare it outside of the lyx:: namespace, like in the > > > > attached > > > > version. > > > > > > Doh! Please, go ahead

Re: LyX very slow to end (master)

On Wed, Oct 18, 2017 at 11:39:30AM +0200, Jean-Marc Lasgouttes wrote: > Le 18/10/2017 à 11:07, Enrico Forestieri a écrit : > > > You have to declare it outside of the lyx:: namespace, like in the > > > attached > > > version. > > > > Doh! Please, go ahead and commit your version. > > My master

Re: LyX very slow to end (master)

Le 18/10/2017 à 11:07, Enrico Forestieri a écrit : You have to declare it outside of the lyx:: namespace, like in the attached version. Doh! Please, go ahead and commit your version. My master repo is in flux at this time (I did the patch against 2.3 actually). Can you commit? JMarc

Re: LyX very slow to end (master)

On Wed, Oct 18, 2017 at 10:57:54AM +0200, Pavel Sanda wrote: > Enrico Forestieri wrote: > > > The compiler doesn't like it: > > > > ../../../../src/frontends/qt4/GuiToolbar.cpp: In member function ???void > > lyx::frontend::GuiToolbar::saveSession(lyx::QSettings&) const???: > >

Re: LyX very slow to end (master)

On Wed, Oct 18, 2017 at 10:54:57AM +0200, Jean-Marc Lasgouttes wrote: > Le 18/10/2017 à 10:29, Enrico Forestieri a écrit : > > On Wed, Oct 18, 2017 at 10:18:42AM +0200, Jean-Marc Lasgouttes wrote: > > > Le 18/10/2017 à 10:13, Enrico Forestieri a écrit : > > > > > It should be rather safe: > > > >

Re: LyX very slow to end (master)

Enrico Forestieri wrote: > On Wed, Oct 18, 2017 at 10:18:42AM +0200, Jean-Marc Lasgouttes wrote: > > Le 18/10/2017 ?? 10:13, Enrico Forestieri a écrit : > > > > It should be rather safe: > > > >

Re: LyX very slow to end (master)

Le 18/10/2017 à 10:29, Enrico Forestieri a écrit : On Wed, Oct 18, 2017 at 10:18:42AM +0200, Jean-Marc Lasgouttes wrote: Le 18/10/2017 à 10:13, Enrico Forestieri a écrit : It should be rather safe:

Re: LyX very slow to end (master)

On Wed, Oct 18, 2017 at 10:18:42AM +0200, Jean-Marc Lasgouttes wrote: > Le 18/10/2017 à 10:13, Enrico Forestieri a écrit : > > > It should be rather safe: > > > http://doc.qt.io/qt-4.8/qsettings.html#accessing-settings-from-multiple-threads-or-processes-simultaneously > > > > This would be the

Re: LyX very slow to end (master)

Le 18/10/2017 à 10:13, Enrico Forestieri a écrit : It should be rather safe: http://doc.qt.io/qt-4.8/qsettings.html#accessing-settings-from-multiple-threads-or-processes-simultaneously This would be the attached patch. Now I don't experience any delay on quit. Thanks for doing it Enrico.

Re: LyX very slow to end (master)

On Tue, Oct 17, 2017 at 12:08:20PM +0200, Jürgen Spitzmüller wrote: > 2017-10-17 9:36 GMT+02:00 Pavel Sanda : > > > Jean-Marc Lasgouttes wrote: > > > Good catch. A solution is porbably to instantiate a QSettings in > > > saveUISettings and pass it as parameter of the various

Re: LyX very slow to end (master)

On 2017-10-16, Jean-Marc Lasgouttes wrote: > Le 16/10/2017 à 14:49, Pavel Sanda a écrit : >> Hi, >> when I quit lyx 2.0 the app terminates instantaneously, >> with current master I have to wait ~3s before the window >> disappears (emarasingly slower than launching it - 0.5s). >> The time is

Re: LyX very slow to end (master)

2017-10-17 9:36 GMT+02:00 Pavel Sanda : > Jean-Marc Lasgouttes wrote: > > Good catch. A solution is porbably to instantiate a QSettings in > > saveUISettings and pass it as parameter of the various saveSession() > > methods. > > If there is no other user of saveSession that sounds

Re: LyX very slow to end (master)

Jean-Marc Lasgouttes wrote: > Good catch. A solution is porbably to instantiate a QSettings in > saveUISettings and pass it as parameter of the various saveSession() > methods. If there is no other user of saveSession that sounds like best option. Scott Kostyshak wrote: > I wonoder if this is

Re: LyX very slow to end (master)

On Mon, Oct 16, 2017 at 03:07:28PM +, Jean-Marc Lasgouttes wrote: > Le 16/10/2017 à 16:08, Pavel Sanda a écrit : > > Just trying dirty patch for caching settings inside GuiToolbar::saveSession > > instead of creating new local var for each fun entry shows that I get quit > > time around 1s. >

Re: LyX very slow to end (master)

Le 16/10/2017 à 16:08, Pavel Sanda a écrit : Just trying dirty patch for caching settings inside GuiToolbar::saveSession instead of creating new local var for each fun entry shows that I get quit time around 1s. Quick check shows that most of remaining time is spent in DialogPtr saveSession loop

Re: LyX very slow to end (master)

Pavel Sanda wrote: > Single instance of QSettings in pimp might help this. Just trying dirty patch for caching settings inside GuiToolbar::saveSession instead of creating new local var for each fun entry shows that I get quit time around 1s. Quick check shows that most of remaining time is spent

Re: LyX very slow to end (master)

Pavel Sanda wrote: > with current master I have to wait ~3s before the window And the winner for almost all of 3s goes to saveUISettings and its ToolbarMap saveSession loop. Each GuiToolbar::saveSession() takes ~80ms, guess what happens when we call it 40x... This is qt5 so it might be that lyx

Re: LyX very slow to end (master)

Le 16/10/2017 à 14:49, Pavel Sanda a écrit : Hi, when I quit lyx 2.0 the app terminates instantaneously, with current master I have to wait ~3s before the window disappears (emarasingly slower than launching it - 0.5s). The time is spent on I/O, not cpu. Anyone can confirm? Qt4 or Qt5?

LyX very slow to end (master)

Hi, when I quit lyx 2.0 the app terminates instantaneously, with current master I have to wait ~3s before the window disappears (emarasingly slower than launching it - 0.5s). The time is spent on I/O, not cpu. Anyone can confirm? Pavel