Re: test of math previews

On Fri, Jun 26, 2015 at 02:00:33AM +0100, Guillaume M-M wrote: Le 25/06/2015 23:45, Richard Heck a écrit : On 06/25/2015 02:58 PM, Enrico Forestieri wrote: On Thu, Jun 25, 2015 at 02:16:19PM -0400, Richard Heck wrote: This more or less completes this work? I think so. The most important

Re: test of math previews

On Fri, Jun 26, 2015 at 02:00:33AM +0100, Guillaume M-M wrote: > Le 25/06/2015 23:45, Richard Heck a écrit : > >On 06/25/2015 02:58 PM, Enrico Forestieri wrote: > >>On Thu, Jun 25, 2015 at 02:16:19PM -0400, Richard Heck wrote: > >>>This more or less completes this work? > >>I think so. The most

Re: test of math previews

On Thu, Jun 25, 2015 at 10:16:21AM +0200, Enrico Forestieri wrote: The third patch is the simpler one proposed by Guillaume. I have already applied the better patch to master but there is a glitch with it. Namely, if a preview snippet produces a blank image, its metrics are not invalidated

Re: test of math previews

On Thu, Jun 25, 2015 at 01:44:15PM +0200, Enrico Forestieri wrote: On Thu, Jun 25, 2015 at 10:16:21AM +0200, Enrico Forestieri wrote: The third patch is the simpler one proposed by Guillaume. I have already applied the better patch to master but there is a glitch with it. Namely, if a

Re: test of math previews

On 06/25/2015 02:13 PM, Enrico Forestieri wrote: On Thu, Jun 25, 2015 at 01:44:15PM +0200, Enrico Forestieri wrote: On Thu, Jun 25, 2015 at 10:16:21AM +0200, Enrico Forestieri wrote: The third patch is the simpler one proposed by Guillaume. I have already applied the better patch to master but

Re: test of math previews

On Thu, Jun 25, 2015 at 02:16:19PM -0400, Richard Heck wrote: On 06/25/2015 02:13 PM, Enrico Forestieri wrote: On Thu, Jun 25, 2015 at 01:44:15PM +0200, Enrico Forestieri wrote: On Thu, Jun 25, 2015 at 10:16:21AM +0200, Enrico Forestieri wrote: The third patch is the simpler one proposed by

Re: test of math previews

On 06/25/2015 02:58 PM, Enrico Forestieri wrote: On Thu, Jun 25, 2015 at 02:16:19PM -0400, Richard Heck wrote: This more or less completes this work? I think so. The most important glitches were identified and solved. (For which thanks very much, to you and Guillaume.) The credit goes

Re: test of math previews

Le 25/06/2015 23:45, Richard Heck a écrit : On 06/25/2015 02:58 PM, Enrico Forestieri wrote: On Thu, Jun 25, 2015 at 02:16:19PM -0400, Richard Heck wrote: This more or less completes this work? I think so. The most important glitches were identified and solved. (For which thanks very much,

Re: test of math previews

On Wed, Jun 24, 2015 at 09:36:50PM -0400, Richard Heck wrote: On 06/24/2015 08:49 PM, Guillaume M-M wrote: Le 25/06/2015 00:44, Enrico Forestieri a écrit : On Mon, Jun 22, 2015 at 11:32:17PM +0100, Guillaume M-M wrote: 3) Previews have the incorrect size with layouts that offer font sizes

Re: test of math previews

On Wed, Jun 24, 2015 at 09:36:50PM -0400, Richard Heck wrote: > On 06/24/2015 08:49 PM, Guillaume M-M wrote: > >Le 25/06/2015 00:44, Enrico Forestieri a écrit : > >>On Mon, Jun 22, 2015 at 11:32:17PM +0100, Guillaume M-M wrote: > >>> > >>>3) Previews have the incorrect size with layouts that offer

Re: test of math previews

On Thu, Jun 25, 2015 at 10:16:21AM +0200, Enrico Forestieri wrote: > > The third patch is the simpler one proposed by Guillaume. I have already > applied the better patch to master but there is a glitch with it. > Namely, if a preview snippet produces a blank image, its metrics are > not

Re: test of math previews

On Thu, Jun 25, 2015 at 01:44:15PM +0200, Enrico Forestieri wrote: > On Thu, Jun 25, 2015 at 10:16:21AM +0200, Enrico Forestieri wrote: > > > > The third patch is the simpler one proposed by Guillaume. I have already > > applied the better patch to master but there is a glitch with it. > >

Re: test of math previews

On 06/25/2015 02:13 PM, Enrico Forestieri wrote: On Thu, Jun 25, 2015 at 01:44:15PM +0200, Enrico Forestieri wrote: On Thu, Jun 25, 2015 at 10:16:21AM +0200, Enrico Forestieri wrote: The third patch is the simpler one proposed by Guillaume. I have already applied the better patch to master but

Re: test of math previews

On Thu, Jun 25, 2015 at 02:16:19PM -0400, Richard Heck wrote: > On 06/25/2015 02:13 PM, Enrico Forestieri wrote: > >On Thu, Jun 25, 2015 at 01:44:15PM +0200, Enrico Forestieri wrote: > >>On Thu, Jun 25, 2015 at 10:16:21AM +0200, Enrico Forestieri wrote: > >>>The third patch is the simpler one

Re: test of math previews

On 06/25/2015 02:58 PM, Enrico Forestieri wrote: On Thu, Jun 25, 2015 at 02:16:19PM -0400, Richard Heck wrote: This more or less completes this work? I think so. The most important glitches were identified and solved. (For which thanks very much, to you and Guillaume.) The credit goes

Re: test of math previews

Le 25/06/2015 23:45, Richard Heck a écrit : On 06/25/2015 02:58 PM, Enrico Forestieri wrote: On Thu, Jun 25, 2015 at 02:16:19PM -0400, Richard Heck wrote: This more or less completes this work? I think so. The most important glitches were identified and solved. (For which thanks very much,

Re: test of math previews

On Tue, Jun 23, 2015 at 11:14:29AM -0400, Richard Heck wrote: On 06/22/2015 06:59 PM, Enrico Forestieri wrote: On Sat, Jun 20, 2015 at 02:11:53AM +0200, Enrico Forestieri wrote: On Fri, Jun 19, 2015 at 04:50:43PM +0100, Guillaume M-M wrote: Also, lyx-preview-macros-2-lassert.lyx no longer

Re: test of math previews

On Tue, Jun 23, 2015 at 10:20:21PM +0200, Georg Baum wrote: Enrico Forestieri wrote: I don't know, maybe this is a case of a race condition. Most probably, with preview on, updateMacros() is not called (or is called later) and the MacroData:sym_ pointer is not updated at the time

Re: test of math previews

On Mon, Jun 22, 2015 at 11:32:17PM +0100, Guillaume M-M wrote: 3) Previews have the incorrect size with layouts that offer font sizes other than 1[0-2]pt (lyx-preview-fontsize.lyx). The legacy method offers a function that retrieves the actual font size and calculates the actual dpi.

Re: test of math previews

On 06/24/2015 08:49 PM, Guillaume M-M wrote: Le 25/06/2015 00:44, Enrico Forestieri a écrit : On Mon, Jun 22, 2015 at 11:32:17PM +0100, Guillaume M-M wrote: 3) Previews have the incorrect size with layouts that offer font sizes other than 1[0-2]pt (lyx-preview-fontsize.lyx). The legacy

Re: test of math previews

Le 25/06/2015 00:44, Enrico Forestieri a écrit : On Mon, Jun 22, 2015 at 11:32:17PM +0100, Guillaume M-M wrote: 3) Previews have the incorrect size with layouts that offer font sizes other than 1[0-2]pt (lyx-preview-fontsize.lyx). The legacy method offers a function that retrieves the actual

Re: test of math previews

On Tue, Jun 23, 2015 at 10:20:21PM +0200, Georg Baum wrote: > Enrico Forestieri wrote: > > > I don't know, maybe this is a case of a race condition. Most probably, > > with preview on, updateMacros() is not called (or is called later) and > > the MacroData:sym_ pointer is not updated at the time

Re: test of math previews

On Tue, Jun 23, 2015 at 11:14:29AM -0400, Richard Heck wrote: > On 06/22/2015 06:59 PM, Enrico Forestieri wrote: > >On Sat, Jun 20, 2015 at 02:11:53AM +0200, Enrico Forestieri wrote: > >>On Fri, Jun 19, 2015 at 04:50:43PM +0100, Guillaume M-M wrote: > >> > >>>Also, lyx-preview-macros-2-lassert.lyx

Re: test of math previews

On Mon, Jun 22, 2015 at 11:32:17PM +0100, Guillaume M-M wrote: > > 3) Previews have the incorrect size with layouts that offer font sizes other > than 1[0-2]pt (lyx-preview-fontsize.lyx). The legacy method offers a > function that retrieves the actual font size and calculates the actual dpi. >

Re: test of math previews

Le 25/06/2015 00:44, Enrico Forestieri a écrit : On Mon, Jun 22, 2015 at 11:32:17PM +0100, Guillaume M-M wrote: 3) Previews have the incorrect size with layouts that offer font sizes other than 1[0-2]pt (lyx-preview-fontsize.lyx). The legacy method offers a function that retrieves the actual

Re: test of math previews

On 06/24/2015 08:49 PM, Guillaume M-M wrote: Le 25/06/2015 00:44, Enrico Forestieri a écrit : On Mon, Jun 22, 2015 at 11:32:17PM +0100, Guillaume M-M wrote: 3) Previews have the incorrect size with layouts that offer font sizes other than 1[0-2]pt (lyx-preview-fontsize.lyx). The legacy

Re: test of math previews

On 06/22/2015 06:59 PM, Enrico Forestieri wrote: On Sat, Jun 20, 2015 at 02:11:53AM +0200, Enrico Forestieri wrote: On Fri, Jun 19, 2015 at 04:50:43PM +0100, Guillaume M-M wrote: Also, lyx-preview-macros-2-lassert.lyx no longer lasserts but on opening the preview is not generated because

Re: test of math previews

Le 23/06/2015 10:46, Enrico Forestieri a écrit : On Tue, Jun 23, 2015 at 11:18:56AM +0200, Enrico Forestieri wrote: On Tue, Jun 23, 2015 at 02:44:00AM +0100, Guillaume M-M wrote: Still there at cd046f0e (master). But here's the trace I get when it crashes right at the first Ctrl+C: I doubt

Re: test of math previews

On Tue, Jun 23, 2015 at 02:23:18PM +0100, Guillaume M-M wrote: Le 23/06/2015 10:46, Enrico Forestieri a écrit : Indeed, this has to do with the general problem of copying macros and how the various structures are carried on when copying. OK for the fact that this is not a regression, but

Re: test of math previews

On Tue, Jun 23, 2015 at 02:23:18PM +0100, Guillaume M-M wrote: Le 23/06/2015 10:46, Enrico Forestieri a écrit : Indeed, this has to do with the general problem of copying macros and how the various structures are carried on when copying. OK for the fact that this is not a regression, but

Re: test of math previews

Enrico Forestieri wrote: I don't know, maybe this is a case of a race condition. Most probably, with preview on, updateMacros() is not called (or is called later) and the MacroData:sym_ pointer is not updated at the time MacroData::xlmname() is called so that it contains bogus values. This

Re: test of math previews

On Tue, Jun 23, 2015 at 10:20:21PM +0200, Georg Baum wrote: Enrico Forestieri wrote: I don't know, maybe this is a case of a race condition. Most probably, with preview on, updateMacros() is not called (or is called later) and the MacroData:sym_ pointer is not updated at the time

Re: test of math previews

On Tue, Jun 23, 2015 at 11:18:56AM +0200, Enrico Forestieri wrote: On Tue, Jun 23, 2015 at 02:44:00AM +0100, Guillaume M-M wrote: Still there at cd046f0e (master). But here's the trace I get when it crashes right at the first Ctrl+C: I doubt this has anything to do with the recent

Re: test of math previews

On Tue, Jun 23, 2015 at 02:44:00AM +0100, Guillaume M-M wrote: Le 23/06/2015 02:36, Guillaume M-M a écrit : Le 23/06/2015 02:34, Guillaume M-M a écrit : Another segfault in the stable branch involving previews (and master as well). When Instant preview is on and one copies a formula, it

Re: test of math previews

On Tue, Jun 23, 2015 at 02:44:00AM +0100, Guillaume M-M wrote: > Le 23/06/2015 02:36, Guillaume M-M a écrit : > >Le 23/06/2015 02:34, Guillaume M-M a écrit : > >>Another segfault in the stable branch involving previews (and master as > >>well). When Instant preview is on and one copies a formula,

Re: test of math previews

On Tue, Jun 23, 2015 at 11:18:56AM +0200, Enrico Forestieri wrote: > On Tue, Jun 23, 2015 at 02:44:00AM +0100, Guillaume M-M wrote: > > > > Still there at cd046f0e (master). But here's the trace I get when it crashes > > right at the first Ctrl+C: > > I doubt this has anything to do with the

Re: test of math previews

Le 23/06/2015 10:46, Enrico Forestieri a écrit : On Tue, Jun 23, 2015 at 11:18:56AM +0200, Enrico Forestieri wrote: On Tue, Jun 23, 2015 at 02:44:00AM +0100, Guillaume M-M wrote: Still there at cd046f0e (master). But here's the trace I get when it crashes right at the first Ctrl+C: I doubt

Re: test of math previews

On 06/22/2015 06:59 PM, Enrico Forestieri wrote: On Sat, Jun 20, 2015 at 02:11:53AM +0200, Enrico Forestieri wrote: On Fri, Jun 19, 2015 at 04:50:43PM +0100, Guillaume M-M wrote: Also, lyx-preview-macros-2-lassert.lyx no longer lasserts but on opening the preview is not generated because

Re: test of math previews

On Tue, Jun 23, 2015 at 02:23:18PM +0100, Guillaume M-M wrote: > Le 23/06/2015 10:46, Enrico Forestieri a écrit : > > > >Indeed, this has to do with the general problem of copying macros and > >how the various structures are carried on when copying. > > OK for the fact that this is not a

Re: test of math previews

On Tue, Jun 23, 2015 at 02:23:18PM +0100, Guillaume M-M wrote: > Le 23/06/2015 10:46, Enrico Forestieri a écrit : > > > >Indeed, this has to do with the general problem of copying macros and > >how the various structures are carried on when copying. > > OK for the fact that this is not a

Re: test of math previews

Enrico Forestieri wrote: > I don't know, maybe this is a case of a race condition. Most probably, > with preview on, updateMacros() is not called (or is called later) and > the MacroData:sym_ pointer is not updated at the time MacroData::xlmname() > is called so that it contains bogus values.

Re: test of math previews

On Tue, Jun 23, 2015 at 10:20:21PM +0200, Georg Baum wrote: > Enrico Forestieri wrote: > > > I don't know, maybe this is a case of a race condition. Most probably, > > with preview on, updateMacros() is not called (or is called later) and > > the MacroData:sym_ pointer is not updated at the time

Re: test of math previews

On Mon, Jun 22, 2015 at 11:32:17PM +0100, Guillaume M-M wrote: 1) SIGSEGV with previews (no math macros involved). I believe this is the one I mentioned in a previous message. See the attached lyx-preview-sigsegv.lyx for instructions. Thanks for catching this. I fixed this issue at cd046f0e.

Re: test of math previews

Three bugs in the current stable (93c0512b). The third one has an easy fix (and also a very trivial partial fix if you want to move forward with the release). The first two could be postponed after the release, or maybe they are trivial as well to Enrico. Found the first two while testing my

Re: test of math previews

On Sat, Jun 20, 2015 at 02:11:53AM +0200, Enrico Forestieri wrote: On Fri, Jun 19, 2015 at 04:50:43PM +0100, Guillaume M-M wrote: Also, lyx-preview-macros-2-lassert.lyx no longer lasserts but on opening the preview is not generated because \Coloneqq is not defined. This looks like the bug

Re: test of math previews

Le 23/06/2015 02:34, Guillaume M-M a écrit : Another segfault in the stable branch involving previews (and master as well). When Instant preview is on and one copies a formula, it randomly crashes. In the attached, select the math inset and hold Ctrl+C until it segfaults. Sometimes it happens on

Re: test of math previews

Another segfault in the stable branch involving previews (and master as well). When Instant preview is on and one copies a formula, it randomly crashes. In the attached, select the math inset and hold Ctrl+C until it segfaults. Sometimes it happens on the first press. This is pretty annoying

Re: test of math previews

Le 23/06/2015 02:36, Guillaume M-M a écrit : Le 23/06/2015 02:34, Guillaume M-M a écrit : Another segfault in the stable branch involving previews (and master as well). When Instant preview is on and one copies a formula, it randomly crashes. In the attached, select the math inset and hold

Re: test of math previews

Three bugs in the current stable (93c0512b). The third one has an easy fix (and also a very trivial partial fix if you want to move forward with the release). The first two could be postponed after the release, or maybe they are trivial as well to Enrico. Found the first two while testing my

Re: test of math previews

On Sat, Jun 20, 2015 at 02:11:53AM +0200, Enrico Forestieri wrote: > On Fri, Jun 19, 2015 at 04:50:43PM +0100, Guillaume M-M wrote: > > > Also, lyx-preview-macros-2-lassert.lyx no longer lasserts but on opening the > > preview is not generated because \Coloneqq is not defined. This looks like > >

Re: test of math previews

On Mon, Jun 22, 2015 at 11:32:17PM +0100, Guillaume M-M wrote: > > 1) SIGSEGV with previews (no math macros involved). I believe this is the > one I mentioned in a previous message. See the attached > lyx-preview-sigsegv.lyx for instructions. Thanks for catching this. I fixed this issue at

Re: test of math previews

Another segfault in the stable branch involving previews (and master as well). When Instant preview is on and one copies a formula, it randomly crashes. In the attached, select the math inset and hold Ctrl+C until it segfaults. Sometimes it happens on the first press. This is pretty annoying

Re: test of math previews

Le 23/06/2015 02:34, Guillaume M-M a écrit : Another segfault in the stable branch involving previews (and master as well). When Instant preview is on and one copies a formula, it randomly crashes. In the attached, select the math inset and hold Ctrl+C until it segfaults. Sometimes it happens on

Re: test of math previews

Le 23/06/2015 02:36, Guillaume M-M a écrit : Le 23/06/2015 02:34, Guillaume M-M a écrit : Another segfault in the stable branch involving previews (and master as well). When Instant preview is on and one copies a formula, it randomly crashes. In the attached, select the math inset and hold

Re: test of math previews

On Sat, Jun 20, 2015 at 09:13:40PM -0400, Richard Heck wrote: On 06/20/2015 08:45 PM, Scott Kostyshak wrote: On Sun, Jun 21, 2015 at 01:38:55AM +0100, Guillaume M-M wrote: Thank you for the convenience. I have no other issue to report for stable, Enrico wins :) LyX users across the globe

Re: test of math previews

Guillaume M-M wrote: Thank you very much, this is really quick now. Thanks also for the timer for generating previews. Also I only had 1 segmentation error, which I could not reproduce unfortunately. It happened after changing from Instant preview: On to No maths and zooming. But probably

Re: test of math previews

On Sat, Jun 20, 2015 at 09:13:40PM -0400, Richard Heck wrote: > On 06/20/2015 08:45 PM, Scott Kostyshak wrote: > >On Sun, Jun 21, 2015 at 01:38:55AM +0100, Guillaume M-M wrote: > > > >>Thank you for the convenience. > >> > >>I have no other issue to report for stable, Enrico wins :) > >LyX users

Re: test of math previews

Guillaume M-M wrote: > Thank you very much, this is really quick now. Thanks also for the timer > for generating previews. Also I only had 1 segmentation error, which I > could not reproduce unfortunately. It happened after changing from > "Instant preview: On" to "No maths" and zooming. But

Re: test of math previews

Le 20/06/2015 01:11, Enrico Forestieri a écrit : On Fri, Jun 19, 2015 at 04:50:43PM +0100, Guillaume M-M wrote: Le 07/06/2015 12:49, Enrico Forestieri a écrit : On Sat, Jun 06, 2015 at 08:07:12PM +0100, Guillaume M-M wrote: lyx-preview-macros2-failure.lyx shows two cases where a macro is

Re: test of math previews

On Sat, Jun 20, 2015 at 08:14:03AM +0100, Guillaume M-M wrote: Le 20/06/2015 01:11, Enrico Forestieri a écrit : On Fri, Jun 19, 2015 at 04:50:43PM +0100, Guillaume M-M wrote: Lastly I see that you prevent loading the microtype package by redefining \usepackage as you described earlier in the

Re: test of math previews

On Sat, Jun 20, 2015 at 04:58:35PM +0200, Enrico Forestieri wrote: On Sat, Jun 20, 2015 at 08:14:03AM +0100, Guillaume M-M wrote: Le 20/06/2015 01:11, Enrico Forestieri a écrit : On Fri, Jun 19, 2015 at 04:50:43PM +0100, Guillaume M-M wrote: Lastly I see that you prevent loading the

Re: test of math previews

Le 20/06/2015 15:58, Enrico Forestieri a écrit : On Sat, Jun 20, 2015 at 08:14:03AM +0100, Guillaume M-M wrote: Le 20/06/2015 01:11, Enrico Forestieri a écrit : On Fri, Jun 19, 2015 at 04:50:43PM +0100, Guillaume M-M wrote: Lastly I see that you prevent loading the microtype package by

Re: test of math previews

On Sun, Jun 21, 2015 at 01:38:55AM +0100, Guillaume M-M wrote: Thank you for the convenience. I have no other issue to report for stable, Enrico wins :) LyX users across the globe win now :) Thanks to both of you! Scott

Re: test of math previews

On 06/20/2015 08:45 PM, Scott Kostyshak wrote: On Sun, Jun 21, 2015 at 01:38:55AM +0100, Guillaume M-M wrote: Thank you for the convenience. I have no other issue to report for stable, Enrico wins :) LyX users across the globe win now :) Thanks to both of you! For stable, this is again

Re: test of math previews

Le 20/06/2015 01:11, Enrico Forestieri a écrit : On Fri, Jun 19, 2015 at 04:50:43PM +0100, Guillaume M-M wrote: Le 07/06/2015 12:49, Enrico Forestieri a écrit : On Sat, Jun 06, 2015 at 08:07:12PM +0100, Guillaume M-M wrote: lyx-preview-macros2-failure.lyx shows two cases where a macro is

Re: test of math previews

On Sat, Jun 20, 2015 at 08:14:03AM +0100, Guillaume M-M wrote: > Le 20/06/2015 01:11, Enrico Forestieri a écrit : > >On Fri, Jun 19, 2015 at 04:50:43PM +0100, Guillaume M-M wrote: > > > >>Lastly I see that you prevent loading the microtype package by redefining > >>\usepackage as you described

Re: test of math previews

On Sat, Jun 20, 2015 at 04:58:35PM +0200, Enrico Forestieri wrote: > On Sat, Jun 20, 2015 at 08:14:03AM +0100, Guillaume M-M wrote: > > Le 20/06/2015 01:11, Enrico Forestieri a écrit : > > >On Fri, Jun 19, 2015 at 04:50:43PM +0100, Guillaume M-M wrote: > > > > > >>Lastly I see that you prevent

Re: test of math previews

Le 20/06/2015 15:58, Enrico Forestieri a écrit : On Sat, Jun 20, 2015 at 08:14:03AM +0100, Guillaume M-M wrote: Le 20/06/2015 01:11, Enrico Forestieri a écrit : On Fri, Jun 19, 2015 at 04:50:43PM +0100, Guillaume M-M wrote: Lastly I see that you prevent loading the microtype package by

Re: test of math previews

On Sun, Jun 21, 2015 at 01:38:55AM +0100, Guillaume M-M wrote: > Thank you for the convenience. > > I have no other issue to report for stable, Enrico wins :) LyX users across the globe win now :) Thanks to both of you! Scott

Re: test of math previews

On 06/20/2015 08:45 PM, Scott Kostyshak wrote: On Sun, Jun 21, 2015 at 01:38:55AM +0100, Guillaume M-M wrote: Thank you for the convenience. I have no other issue to report for stable, Enrico wins :) LyX users across the globe win now :) Thanks to both of you! For stable, this is again

Re: test of math previews

On Fri, Jun 19, 2015 at 04:50:43PM +0100, Guillaume M-M wrote: Le 07/06/2015 12:49, Enrico Forestieri a écrit : On Sat, Jun 06, 2015 at 08:07:12PM +0100, Guillaume M-M wrote: lyx-preview-macros2-failure.lyx shows two cases where a macro is forgotten from the list. The third inset works and

Re: test of math previews

Le 07/06/2015 12:49, Enrico Forestieri a écrit : On Sat, Jun 06, 2015 at 08:07:12PM +0100, Guillaume M-M wrote: lyx-preview-macros2-failure.lyx shows two cases where a macro is forgotten from the list. The third inset works and is meant as a control. All 3 work without the patch. Here I was

Re: test of math previews

Le 07/06/2015 12:49, Enrico Forestieri a écrit : On Sat, Jun 06, 2015 at 08:07:12PM +0100, Guillaume M-M wrote: lyx-preview-macros2-failure.lyx shows two cases where a macro is forgotten from the list. The third inset works and is meant as a control. All 3 work without the patch. Here I was

Re: test of math previews

On Fri, Jun 19, 2015 at 04:50:43PM +0100, Guillaume M-M wrote: > Le 07/06/2015 12:49, Enrico Forestieri a écrit : > >On Sat, Jun 06, 2015 at 08:07:12PM +0100, Guillaume M-M wrote: > >> > >>lyx-preview-macros2-failure.lyx shows two cases where a macro is forgotten > >>from the list. The third

Re: test of math previews

2015-06-14 13:31 GMT+02:00 Enrico Forestieri for...@lyx.org: Jürgen, this is going to become complicated and fragile. What about following the same strategy used in stable? This implies reverting bc47054b. Since I do not have time to investigate further, please do whatever you see fit. I

Re: test of math previews

2015-06-14 16:04 GMT+02:00 Enrico Forestieri for...@lyx.org: I agree that this would have been better but, unfortunately, it doesn't fit the instant preview infrastructure. You wold have to output different definitions depending on whether you compile the whole set of snippets or only some of

Re: test of math previews

On Thu, Jun 04, 2015 at 07:25:25PM +0200, Enrico Forestieri wrote: On Thu, Jun 04, 2015 at 06:56:46PM +0200, Jürgen Spitzmüller wrote: 2015-06-04 18:39 GMT+02:00 Enrico Forestieri for...@lyx.org: Yes, I can reproduce in master. It does not occur in stable, where a different strategy

Re: test of math previews

On Sun, Jun 14, 2015 at 01:34:40PM +0200, Jürgen Spitzmüller wrote: 2015-06-14 13:31 GMT+02:00 Enrico Forestieri for...@lyx.org: Jürgen, this is going to become complicated and fragile. What about following the same strategy used in stable? This implies reverting bc47054b. Since I

Re: test of math previews

On Thu, Jun 04, 2015 at 07:25:25PM +0200, Enrico Forestieri wrote: > On Thu, Jun 04, 2015 at 06:56:46PM +0200, Jürgen Spitzmüller wrote: > > 2015-06-04 18:39 GMT+02:00 Enrico Forestieri : > > > > > Yes, I can reproduce in master. It does not occur in stable, where a > > >

Re: test of math previews

2015-06-14 13:31 GMT+02:00 Enrico Forestieri : > Jürgen, this is going to become complicated and fragile. What about > following the same strategy used in stable? > This implies reverting bc47054b. > Since I do not have time to investigate further, please do whatever you see fit.

Re: test of math previews

On Sun, Jun 14, 2015 at 01:34:40PM +0200, Jürgen Spitzmüller wrote: > 2015-06-14 13:31 GMT+02:00 Enrico Forestieri : > > > Jürgen, this is going to become complicated and fragile. What about > > following the same strategy used in stable? > > This implies reverting bc47054b. > >

Re: test of math previews

2015-06-14 16:04 GMT+02:00 Enrico Forestieri : > I agree that this would have been better but, unfortunately, it doesn't > fit the instant preview infrastructure. You wold have to output different > definitions depending on whether you compile the whole set of snippets > or only

Re: test of math previews

On 06/07/2015 07:49 AM, Enrico Forestieri wrote: The attached patch solves all of the above problems (and also the segfault you report separately) for me. I am also attaching the patch for #9354 accordingly updated. Please test both and report the issues you find. If your paper pass the tests,

Re: test of math previews

On 06/07/2015 07:49 AM, Enrico Forestieri wrote: The attached patch solves all of the above problems (and also the segfault you report separately) for me. I am also attaching the patch for #9354 accordingly updated. Please test both and report the issues you find. If your paper pass the tests,

Re: test of math previews

On Sat, Jun 06, 2015 at 08:07:12PM +0100, Guillaume M-M wrote: lyx-preview-macros2-failure.lyx shows two cases where a macro is forgotten from the list. The third inset works and is meant as a control. All 3 work without the patch. Here I was forgetting to also scan nested insets.

Re: test of math previews

On Fri, Jun 05, 2015 at 05:11:45PM -0400, Scott Kostyshak wrote: On Fri, Jun 5, 2015 at 3:40 AM, Jean-Marc Lasgouttes lasgout...@lyx.org wrote: Le 05/06/2015 09:14, Enrico Forestieri a écrit : A possible way out would be outputting all the macros once at the beginning of the file, such

Re: test of math previews

On Sat, Jun 06, 2015 at 08:20:43PM +0100, Guillaume M-M wrote: Obvious one to test for Thanks for spotting this. It is due to the recursion in the macro definitions. The patch I sent takes this into account and lyx does not segfaults anymore, but latex will be caught in an endless loop and

Re: test of math previews

On Sat, Jun 06, 2015 at 08:18:12PM +0200, Kornel Benko wrote: But I wonder why there are preview entries in the lyxpreview*.tex ... \begin{document} \begin{preview} ${\displaystyle {#1}}$ \end{preview} \begin{preview} $#1$ \end{preview} \begin{preview} ${\scriptstyle {#1}}$

Re: test of math previews

On Sat, Jun 06, 2015 at 08:07:12PM +0100, Guillaume M-M wrote: > > lyx-preview-macros2-failure.lyx shows two cases where a macro is forgotten > from the list. The third inset works and is meant as a control. All 3 work > without the patch. Here I was forgetting to also scan nested insets. >

Re: test of math previews

On Sat, Jun 06, 2015 at 08:20:43PM +0100, Guillaume M-M wrote: > > Obvious one to test for Thanks for spotting this. It is due to the recursion in the macro definitions. The patch I sent takes this into account and lyx does not segfaults anymore, but latex will be caught in an endless loop and

Re: test of math previews

On Sat, Jun 06, 2015 at 08:18:12PM +0200, Kornel Benko wrote: > > But I wonder why there are preview entries in the lyxpreview*.tex > ... > \begin{document} > \begin{preview} > ${\displaystyle {#1}}$ > \end{preview} > > \begin{preview} > $#1$ > \end{preview} > > \begin{preview} > ${\scriptstyle

Re: test of math previews

On Fri, Jun 05, 2015 at 05:11:45PM -0400, Scott Kostyshak wrote: > On Fri, Jun 5, 2015 at 3:40 AM, Jean-Marc Lasgouttes > wrote: > > Le 05/06/2015 09:14, Enrico Forestieri a écrit : > >> > >> A possible way out would be outputting all the macros once at the > >> beginning of

Re: test of math previews

On Fri, Jun 05, 2015 at 09:40:39AM +0200, Jean-Marc Lasgouttes wrote: Le 05/06/2015 09:14, Enrico Forestieri a écrit : A possible way out would be outputting all the macros once at the beginning of the file, such that they are seen by all snippets, and then the specific one appearing in a

Re: test of math previews

On Fri, Jun 05, 2015 at 11:03:48PM +0100, Guillaume M-M wrote: Le 05/06/2015 08:14, Enrico Forestieri a écrit : On Thu, Jun 04, 2015 at 07:32:03PM -0400, Richard Heck wrote: On 06/04/2015 07:13 PM, Guillaume M-M wrote: Bad news, it seems to forget that macros can use macros. With the

Re: test of math previews

Am Samstag, 6. Juni 2015 um 13:13:22, schrieb Enrico Forestieri for...@lyx.org +void InsetMathHull::usedMacros(MathData const md, MacroNameSet macros) const +{ + for (size_t i = 0; i md.size(); ++i) { + MathMacro * mi = const_castMathMacro

Re: test of math previews

On Sat, Jun 06, 2015 at 03:23:48PM +0200, Kornel Benko wrote: Am Samstag, 6. Juni 2015 um 13:13:22, schrieb Enrico Forestieri for...@lyx.org +void InsetMathHull::usedMacros(MathData const md, MacroNameSet macros) const +{ + for (size_t i = 0; i md.size(); ++i) { +

Re: test of math previews

Le 06/06/2015 18:12, Enrico Forestieri a écrit : On Sat, Jun 06, 2015 at 03:23:48PM +0200, Kornel Benko wrote: Am Samstag, 6. Juni 2015 um 13:13:22, schrieb Enrico Forestieri for...@lyx.org +void InsetMathHull::usedMacros(MathData const md, MacroNameSet macros) const +{ + for (size_t

Re: test of math previews

Le 06/06/2015 18:12, Enrico Forestieri a écrit : On Sat, Jun 06, 2015 at 03:23:48PM +0200, Kornel Benko wrote: Am Samstag, 6. Juni 2015 um 13:13:22, schrieb Enrico Forestieri for...@lyx.org +void InsetMathHull::usedMacros(MathData const md, MacroNameSet macros) const +{ + for (size_t

Re: test of math previews

Am Samstag, 6. Juni 2015 um 19:12:45, schrieb Enrico Forestieri for...@lyx.org On Sat, Jun 06, 2015 at 03:23:48PM +0200, Kornel Benko wrote: Am Samstag, 6. Juni 2015 um 13:13:22, schrieb Enrico Forestieri for...@lyx.org +void InsetMathHull::usedMacros(MathData const md, MacroNameSet

Re: test of math previews

On Fri, Jun 05, 2015 at 11:03:48PM +0100, Guillaume M-M wrote: > Le 05/06/2015 08:14, Enrico Forestieri a écrit : > >On Thu, Jun 04, 2015 at 07:32:03PM -0400, Richard Heck wrote: > >>On 06/04/2015 07:13 PM, Guillaume M-M wrote: > >>> > >>>Bad news, it seems to forget that macros can use macros.

  1   2   >