Re: Removing "$Id$" lines

2016-11-03 Thread Mojca Miklavec
On 2 November 2016 at 05:07, David Evans wrote: > > Another reason for not canceling such a build would be to generate a record > of how many ports and which ones are > currently broken. I suspect there are a number that never get reported > because they are old or obscure or just not used >

Re: Removing "$Id$" lines

2016-11-01 Thread David Evans
On 11/1/16 4:06 PM, Ryan Schmidt wrote: > Off list, Larry likened removing $Id$ lines to adding modelines, which we > also haven't globally done to all Portfiles yet. But it's not really the same > thing. Adding modelines needs to be done on a case by case basis. For > example, i

Re: Removing "$Id$" lines

2016-11-01 Thread Ryan Schmidt
Off list, Larry likened removing $Id$ lines to adding modelines, which we also haven't globally done to all Portfiles yet. But it's not really the same thing. Adding modelines needs to be done on a case by case basis. For example, if a Portfile currently uses tabs, then just adding the modeline

Re: Removing "$Id$" lines

2016-11-01 Thread Lawrence Velázquez
> On Nov 1, 2016, at 3:55 PM, Daniel J. Luke wrote: > >> On Nov 1, 2016, at 3:36 PM, Lawrence Velázquez wrote: >> >> While I agree in principle that our committing should not be >> hampered by the buildbot and would welcome another solution, I'm not >>

Re: Removing "$Id$" lines

2016-11-01 Thread Lawrence Velázquez
> On Nov 1, 2016, at 3:45 PM, Rainer Müller wrote: > > On 2016-11-01 19:43, Lawrence Velázquez wrote: >> In any case, the proposed set of commits is utterly unnecessary and is >> not worth any of this fuss. > > I do not want to keep commenting on every single submission

Re: Removing "$Id$" lines

2016-11-01 Thread Daniel J. Luke
On Nov 1, 2016, at 3:36 PM, Lawrence Velázquez wrote: > While I agree in principle that our committing should not be hampered by > the buildbot and would welcome another solution, I'm not crazy about the > idea of polluting our (permanent!) commit history with transient >

Re: Removing "$Id$" lines

2016-11-01 Thread Rainer Müller
On 2016-11-01 19:43, Lawrence Velázquez wrote: > In any case, the proposed set of commits is utterly unnecessary and is > not worth any of this fuss. I do not want to keep commenting on every single submission that it needs to remove the $Id$ line. This should be done as one commit and we would

Re: Removing "$Id$" lines

2016-11-01 Thread Lawrence Velázquez
> On Nov 1, 2016, at 4:59 AM, Marko Käning wrote: > >> On 01 Nov 2016, at 02:02 , Rainer Müller wrote: >> >> buildbot: ignore > > +1 > > I’d also suggest to use this also to specify which buildbots should be used > for a commit: > > buildbot:

Re: Removing "$Id$" lines

2016-11-01 Thread Lawrence Velázquez
> On Nov 1, 2016, at 2:22 PM, Mojca Miklavec wrote: > >> On 1 November 2016 at 18:07, Lawrence Velázquez wrote: >> >>> On Nov 1, 2016, at 7:00 AM, Mojca Miklavec wrote: >>> >>> Why not: >>> - wait until all the slaves have something non-trivial to do (make >>> sure the

Re: Removing "$Id$" lines

2016-11-01 Thread Mojca Miklavec
On 1 November 2016 at 18:07, Lawrence Velázquez wrote: >> On Nov 1, 2016, at 7:00 AM, Mojca Miklavec wrote: >> >> On 1 November 2016 at 01:03, Ryan Schmidt wrote: >>> On Oct 31, 2016, at 17:17, Dan Ports wrote: Any reason not to just bulk-remove them all at once? >>> >>> That would

Re: Removing "$Id$" lines

2016-11-01 Thread Ryan Schmidt
On Nov 1, 2016, at 12:38, Bradley Giesbrecht wrote: > > Would it work as well to have the buildbots ignore commits with unchanged > epoch_version_revision. No: imagine that a port fails to build because pkgconfig wasn't there. To fix that, you'll add a build dependency on pkgconfig; you won't

Re: Removing "$Id$" lines

2016-11-01 Thread Clemens Lang
Hi, On Tue, Nov 01, 2016 at 10:38:42AM -0700, Bradley Giesbrecht wrote: > Would it work as well to have the buildbots ignore commits with > unchanged epoch_version_revision. That's https://trac.macports.org/ticket/52765. It would still take the time to process the change and figure out that a

Re: Removing "$Id$" lines

2016-11-01 Thread Bradley Giesbrecht
> On Oct 31, 2016, at 6:02 PM, Rainer Müller wrote: > > On 2016-11-01 01:03, Ryan Schmidt wrote: >> On Oct 31, 2016, at 17:17, Dan Ports wrote: >>> >>> Any reason not to just bulk-remove them all at once? >> >> That would probably tie up the buildbot

Re: Removing "$Id$" lines

2016-11-01 Thread Lawrence Velázquez
> On Nov 1, 2016, at 7:00 AM, Mojca Miklavec wrote: > > On 1 November 2016 at 01:03, Ryan Schmidt wrote: >> On Oct 31, 2016, at 17:17, Dan Ports wrote: >>> >>> Any reason not to just bulk-remove them all at once? >> >> That would probably tie up the buildbot for weeks or

Re: Removing "$Id$" lines

2016-11-01 Thread Mojca Miklavec
On 1 November 2016 at 01:03, Ryan Schmidt wrote: > On Oct 31, 2016, at 17:17, Dan Ports wrote: >> >> Any reason not to just bulk-remove them all at once? > > That would probably tie up the buildbot for weeks or months. We could cancel > those builds, but even the act of scheduling 20,000 builds

Re: Removing "$Id$" lines

2016-11-01 Thread Marko Käning
On 01 Nov 2016, at 02:02 , Rainer Müller wrote: > buildbot: ignore +1 I’d also suggest to use this also to specify which buildbots should be used for a commit: buildbot: Mavericks Sierra I think that can be very helpful in some cases. Opened a ticket for this:

Re: Removing "$Id$" lines

2016-10-31 Thread Rainer Müller
On 2016-11-01 01:03, Ryan Schmidt wrote: > On Oct 31, 2016, at 17:17, Dan Ports wrote: >> >> Any reason not to just bulk-remove them all at once? > > That would probably tie up the buildbot for weeks or months. We could > cancel those builds, but even the act of scheduling

Re: Removing "$Id$" lines

2016-10-31 Thread Dan Ports
On Mon, Oct 31, 2016 at 07:03:24PM -0500, Ryan Schmidt wrote: > On Oct 31, 2016, at 17:17, Dan Ports wrote: > > > > Any reason not to just bulk-remove them all at once? > > That would probably tie up the buildbot for weeks or months. We could cancel > those builds, but

Re: Removing "$Id$" lines

2016-10-31 Thread Ryan Schmidt
On Oct 31, 2016, at 17:17, Dan Ports wrote: > > Any reason not to just bulk-remove them all at once? That would probably tie up the buildbot for weeks or months. We could cancel those builds, but even the act of scheduling 20,000 builds per builder is much more than we've

Re: Removing "$Id$" lines

2016-10-31 Thread Lawrence Velázquez
> On Oct 31, 2016, at 6:17 PM, Dan Ports wrote: > > Any reason not to just bulk-remove them all at once? No reason other than time and effort. vq ___ macports-dev mailing list macports-dev@lists.macosforge.org

Re: Removing "$Id$" lines

2016-10-31 Thread Dan Ports
Any reason not to just bulk-remove them all at once? Dan On Mon, Oct 31, 2016 at 05:30:07PM -0400, Lawrence Velázquez wrote: > Hi, > > We no longer have use for "$Id" lines, so committers should remove them at > their convenience. > > vq > > > On Oct 31, 2016, at 5:20 PM, Schamschula > >

Re: Removing "$Id$" lines

2016-10-31 Thread Marius Schamschula
Larry, OK. Will do. On Oct 31, 2016, at 4:30 PM, Lawrence Velázquez wrote: > Hi, > > We no longer have use for "$Id" lines, so committers should remove them at > their convenience. > > vq > >> On Oct 31, 2016, at 5:20 PM, Schamschula >>

Removing "$Id$" lines

2016-10-31 Thread Lawrence Velázquez
Hi, We no longer have use for "$Id" lines, so committers should remove them at their convenience. vq > On Oct 31, 2016, at 5:20 PM, Schamschula > wrote: > > Schamschula pushed a commit to branch master > in repository macports-ports. > >