Re: New guide section on Git and GitHub

2018-04-14 Thread Andrew Moore
On Apr 14, 2018, at 4:01 PM, Jonathan Stickel wrote: > > Sure, it makes perfect sense to encourage PRs while continue to consider > patches. I'm not against that at all, and I'm willing to figure it out. But > care should be taken about the tone of the message, especially

Re: New guide section on Git and GitHub

2018-04-14 Thread Jonathan Stickel
On 4/14/18 08:29 , Perry E. Metzger wrote: On Fri, 13 Apr 2018 07:31:45 -0600 Jonathan Stickel wrote: As a long time contributor of patches using the ticket interface (Trac), I think it would be a mistake to discourage submission of patches there. While it is fine to

Re: New guide section on Git and GitHub

2018-04-14 Thread Perry E. Metzger
On Fri, 13 Apr 2018 07:31:45 -0600 Jonathan Stickel wrote: > As a long time contributor of patches using the ticket interface > (Trac), I think it would be a mistake to discourage submission of > patches there. While it is fine to encourage use of git pull > requests, the

Re: New guide section on Git and GitHub

2018-04-14 Thread Rainer Müller
On 2018-04-13 15:31, Jonathan Stickel wrote: > As a long time contributor of patches using the ticket interface (Trac), > I think it would be a mistake to discourage submission of patches there. > While it is fine to encourage use of git pull requests, the barrier of > entry is much higher. In

Re: New guide section on Git and GitHub

2018-04-13 Thread Jonathan Stickel
On 4/11/18 17:31, macports-dev-requ...@lists.macports.org wrote: Date: Wed, 11 Apr 2018 18:33:19 -0400 From: "Perry E. Metzger" <pmetz...@macports.org> To: Andrew Moore <slew...@gmail.com> Cc: MacPorts Development <macports-dev@lists.macports.org> Subject: R

Re: New guide section on Git and GitHub

2018-04-12 Thread Dave Horsfall
On Thu, 12 Apr 2018, Mojca Miklavec wrote: p5-tkx has recently beed added to ports and that one supports native look and feel :) Now you really have me interested - thanks! I've just spent a few hours tracking down an obscure (and intermittent!) bug in a script that controls a serial device

Re: New guide section on Git and GitHub

2018-04-12 Thread Mojca Miklavec
On 12 April 2018 at 04:39, Mark Anderson wrote: > Have we thought about moving entirely to github. Using issues and projects? > I remember there being a reason we didn't, but I don't remember what it was. Yes, we did. Ryan even had all trac tickets imported into GitHub and some redirection from

Re: New guide section on Git and GitHub

2018-04-11 Thread Mark Anderson
Have we thought about moving entirely to github. Using issues and projects? I remember there being a reason we didn't, but I don't remember what it was. —Mark ___ Mark E. Anderson On Wed, Apr 11, 2018 at 10:17 PM, Andrew Moore wrote: > > >

Re: New guide section on Git and GitHub

2018-04-11 Thread Andrew Moore
> On Apr 11, 2018, at 7:52 PM, Dave Horsfall wrote: > > On Wed, 11 Apr 2018, Andrew Moore wrote: > >> Okay, so when all is said and done, am I actually prepared to make an actual >> contribution? Perhaps it merits a topic of discussion for the online >> meeting how

Re: New guide section on Git and GitHub

2018-04-11 Thread Dave Horsfall
On Wed, 11 Apr 2018, Andrew Moore wrote: Okay, so when all is said and done, am I actually prepared to make an actual contribution?  Perhaps it merits a topic of discussion for the online meeting how MacPorts wants to present itself.  I’d like to see one of MacPorts’s goals be towards

Re: New guide section on Git and GitHub

2018-04-11 Thread Andrew Moore
As someone who only reads the manual as last resort, I think Section 7 of the MacPorts Guide could be retitled from “MacPorts Project” to “Contributing to MacPorts”. And then steps for creating pull requests via GitHub spelled out tutorial-wise. Perhaps steal an existing tutorial

Re: New guide section on Git and GitHub

2018-04-11 Thread Perry E. Metzger
On Wed, 11 Apr 2018 18:19:50 -0400 Andrew Moore wrote: > My impression from the mailing list is that going forward Trac > would be used exclusively for bug reports. Any code submissions > would ideally be submitted as pull requests to GitHub. That's both true and not quite

Re: New guide section on Git and GitHub

2018-04-11 Thread Perry E. Metzger
On Wed, 11 Apr 2018 17:54:23 -0400 Andrew Moore wrote: > > On Apr 11, 2018, at 5:31 PM, Perry E. Metzger > > wrote: > > > > I just committed a new section of the guide called "Using Git > > and GitHub". Please read, comment, and improve. > > Um, submit

Re: New guide section on Git and GitHub

2018-04-11 Thread Andrew Moore
My impression from the mailing list is that going forward Trac would be used exclusively for bug reports. Any code submissions would ideally be submitted as pull requests to GitHub. If so, this change needs to put front and center, in large display type. Section 7 “MacPorts Projects” should

Re: New guide section on Git and GitHub

2018-04-11 Thread Andrew Moore
Um, submit pull requests, no? > On Apr 11, 2018, at 5:31 PM, Perry E. Metzger wrote: > > I just committed a new section of the guide called "Using Git > and GitHub". Please read, comment, and improve. > > Perry > -- > Perry E. Metzger pmetz...@macports.org