[Mahara-contributors] [Bug 1620416] A change has been merged

2016-09-22 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/6945
Committed: 
https://git.mahara.org/mahara/mahara/commit/058a00ea784980dc5a148eb4c082785a4485300c
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:master

commit 058a00ea784980dc5a148eb4c082785a4485300c
Author: Cecilia Vela Gurovic 
Date:   Thu Sep 8 10:00:09 2016 +1200

Bug 1620416: replace all $smarty->assign_by_ref()
with $smarty->assign()
behatnotneeded

Change-Id: I667463b7732bd3f1dd2619b2836cf4b8c560d264

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1620416

Title:
  Use of assign_by_ref() is not clear as to what is required

Status in Mahara:
  Fix Committed

Bug description:
  In Mahara we have a bunch of $smarty->assign_by_ref('item',
  $variable);

  It was originally added to smarty/dwoo due to the following

  "The assign_by_ref() original intention in Smarty 2 was to work around
  the object-by-copy behavior of PHP4."

  "The _by_ref methods have been introduced in Smarty2 mainly to be able
  to pass objects to the templates in PHP4. In PHP5 these are passed
  alway as a reference."

  But it doesn't look like we use them in a true reference sort of way

  What I mean is, this example shows referenced vs not referenced
  'title' variable:

  $smarty = smarty();
  $title = 'cats';
  $smarty->assign('title', $title);
  $smarty->assign_by_ref('titleref', $title);
  $title = 'dogs';
  $smarty->display('template.tpl'); 

  In the template it will display 'cat' as title and 'dogs' as titleref
  rather than 'cat'.

  We don't support PHP4 and so should clean up the code and make the
  assign_by_ref() calls simply assign() where appropriate to make the
  code clear as to what we are wanting.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1620416/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1620416] A patch has been submitted for review

2016-09-22 Thread Mahara Bot
Patch for "16.10_STABLE" branch: https://reviews.mahara.org/7015

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1620416

Title:
  Use of assign_by_ref() is not clear as to what is required

Status in Mahara:
  Fix Committed

Bug description:
  In Mahara we have a bunch of $smarty->assign_by_ref('item',
  $variable);

  It was originally added to smarty/dwoo due to the following

  "The assign_by_ref() original intention in Smarty 2 was to work around
  the object-by-copy behavior of PHP4."

  "The _by_ref methods have been introduced in Smarty2 mainly to be able
  to pass objects to the templates in PHP4. In PHP5 these are passed
  alway as a reference."

  But it doesn't look like we use them in a true reference sort of way

  What I mean is, this example shows referenced vs not referenced
  'title' variable:

  $smarty = smarty();
  $title = 'cats';
  $smarty->assign('title', $title);
  $smarty->assign_by_ref('titleref', $title);
  $title = 'dogs';
  $smarty->display('template.tpl'); 

  In the template it will display 'cat' as title and 'dogs' as titleref
  rather than 'cat'.

  We don't support PHP4 and so should clean up the code and make the
  assign_by_ref() calls simply assign() where appropriate to make the
  code clear as to what we are wanting.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1620416/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1620416] A change has been merged

2016-09-22 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/7015
Committed: 
https://git.mahara.org/mahara/mahara/commit/a53ed4ad580dbf4938115db08ca16690107a83b8
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:16.10_STABLE

commit a53ed4ad580dbf4938115db08ca16690107a83b8
Author: Cecilia Vela Gurovic 
Date:   Thu Sep 8 10:00:09 2016 +1200

Bug 1620416: replace all $smarty->assign_by_ref()
with $smarty->assign()
behatnotneeded

Change-Id: I667463b7732bd3f1dd2619b2836cf4b8c560d264
(cherry picked from commit 058a00ea784980dc5a148eb4c082785a4485300c)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1620416

Title:
  Use of assign_by_ref() is not clear as to what is required

Status in Mahara:
  Fix Committed

Bug description:
  In Mahara we have a bunch of $smarty->assign_by_ref('item',
  $variable);

  It was originally added to smarty/dwoo due to the following

  "The assign_by_ref() original intention in Smarty 2 was to work around
  the object-by-copy behavior of PHP4."

  "The _by_ref methods have been introduced in Smarty2 mainly to be able
  to pass objects to the templates in PHP4. In PHP5 these are passed
  alway as a reference."

  But it doesn't look like we use them in a true reference sort of way

  What I mean is, this example shows referenced vs not referenced
  'title' variable:

  $smarty = smarty();
  $title = 'cats';
  $smarty->assign('title', $title);
  $smarty->assign_by_ref('titleref', $title);
  $title = 'dogs';
  $smarty->display('template.tpl'); 

  In the template it will display 'cat' as title and 'dogs' as titleref
  rather than 'cat'.

  We don't support PHP4 and so should clean up the code and make the
  assign_by_ref() calls simply assign() where appropriate to make the
  code clear as to what we are wanting.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1620416/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1620416] Re: Use of assign_by_ref() is not clear as to what is required

2016-09-22 Thread Robert Lyon
** Changed in: mahara
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1620416

Title:
  Use of assign_by_ref() is not clear as to what is required

Status in Mahara:
  Fix Committed

Bug description:
  In Mahara we have a bunch of $smarty->assign_by_ref('item',
  $variable);

  It was originally added to smarty/dwoo due to the following

  "The assign_by_ref() original intention in Smarty 2 was to work around
  the object-by-copy behavior of PHP4."

  "The _by_ref methods have been introduced in Smarty2 mainly to be able
  to pass objects to the templates in PHP4. In PHP5 these are passed
  alway as a reference."

  But it doesn't look like we use them in a true reference sort of way

  What I mean is, this example shows referenced vs not referenced
  'title' variable:

  $smarty = smarty();
  $title = 'cats';
  $smarty->assign('title', $title);
  $smarty->assign_by_ref('titleref', $title);
  $title = 'dogs';
  $smarty->display('template.tpl'); 

  In the template it will display 'cat' as title and 'dogs' as titleref
  rather than 'cat'.

  We don't support PHP4 and so should clean up the code and make the
  assign_by_ref() calls simply assign() where appropriate to make the
  code clear as to what we are wanting.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1620416/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1626818] [NEW] Annotation feedback should be optional when block opened on page

2016-09-22 Thread Kristina Hoeppner
Public bug reported:

Mahara 16.10dev

When you do an assessment of a SmartEvidence standard from the SE
overview page, you do not need to provide feedback. However, when you go
to the portfolio page and click the "Place feedback" link, you have to
provide feedback even if you just want to do an assessment.

It would be better to make the feedback optional to reflect the behavior
of the block on the SmartEvidence overview page.

** Affects: mahara
 Importance: High
 Status: Confirmed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1626818

Title:
  Annotation feedback should be optional when block opened on page

Status in Mahara:
  Confirmed

Bug description:
  Mahara 16.10dev

  When you do an assessment of a SmartEvidence standard from the SE
  overview page, you do not need to provide feedback. However, when you
  go to the portfolio page and click the "Place feedback" link, you have
  to provide feedback even if you just want to do an assessment.

  It would be better to make the feedback optional to reflect the
  behavior of the block on the SmartEvidence overview page.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1626818/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1626462] Re: image blocks disappearing from mahara page

2016-09-22 Thread Robert Lyon
Hi Andrew:

Can I get you to check a couple of things:

1) Is the site using MySQL or Postgres?
2) Is the page that is missing blocks also missing rows in the database table 
view_rows_columns ?
3) Does putting the fix in this patch https://reviews.mahara.org/#/c/7014/ and 
refreshing (in a browser) the broken page fix the problem?

Cheers

Robert

** Changed in: mahara
   Status: New => Incomplete

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1626462

Title:
  image blocks disappearing from mahara page

Status in Mahara:
  Incomplete

Bug description:
  Hi,

  I'd like to report a bug with images image blocks disappearing from
  Mahara pages - this problem has occurred more than once and is
  becoming increasingly concerning. The problem arises when a user (in
  this case, a learner) uploads links images to image blocks on one of
  their personal pages. The images appear as expected however at some
  point they then seem to disappear and there is no longer any images
  displaying. This seems to be purely affecting images content blocks
  (in this case image blocks) as the comments section remains present.
  It appears that no files are actually deleted, just the blocks from
  the page are missing. It may be a problem with other types of blocks,
  but in this case, only image blocks were present on the page. I
  thought it also best to mention that I noticed this issue when logging
  in as the user (masquerading) to check something on their behalf,
  however I think this may be pure coincidental.

  The Mahara version here is 16.04.3 (2016033117) running on Linux. I
  have been able to identify this problem using Google Chrome (version
  53.0.2785.116 m). I should also report that we have been made aware of
  the same issue from another client who is also running the exact same
  version (16.04.3) and this would further suggest that this is a bug
  needing addressed.

  Thanks
  Andy

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1626462/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1626805] Re: Page becomes blank after a while

2016-09-22 Thread Robert Lyon
This is due to e52be8a3135c19b2ed306a5e16fdc0101d756f6d where we changed
the

** Also affects: mahara/15.10
   Importance: Undecided
   Status: New

** Changed in: mahara/15.10
   Importance: Undecided => High

** Description changed:

- There is an issue with race conditions and copying pages in Maharra when
+ There is an issue with race conditions and copying pages in Mahara when
  using a MySQL database.
  
  What happens is the values in view_rows_columns for the view get deleted
  somehow and this ends up making the page look empty/page blocks 'look'
  deleted.
  
  They still exist but the system doesn't know how to display the page.
  
  Luckily we can work out what the rows were by looking at data from a
  number of other tables and repopulate the table.
  
  I'll add a fix for this.
  
- To test: 
+ To test:
  before patch:
  1) Create a page and add some blocks to it
  2) create another page and set the layout to multiple rows and add some 
blocks on each row
  3) View the pages to make sure they look ok, open each in a new tab for ease 
of checking
- 4) Go to the db and then run: 
-   SELECT FROM view_rows_columns WHERE view = [viewid];
+ 4) Go to the db and then run:
+   SELECT FROM view_rows_columns WHERE view = [viewid];
  to see what rows it has
-   DELETE FROM view_rows_columns WHERE view = [viewid]; 
+   DELETE FROM view_rows_columns WHERE view = [viewid];
  and get the [viewid] from the urls off the pages
  
  5) Refresh the pages they should be blank (and you will get a bunch of
  errors in debugging on)
  
  6) Checkout patch and refresh the pages again you should see the pages
  looking correct again
  
  7) Check the db again and see the rows have returned and should be the
  same as before

** Changed in: mahara/16.10
Milestone: None => 16.10.0

** Changed in: mahara/16.04
Milestone: None => 16.04.4

** Changed in: mahara/15.10
Milestone: None => 15.10.6

** No longer affects: mahara/15.10

** Changed in: mahara/16.10
   Status: New => In Progress

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1626805

Title:
  Page becomes blank after a while

Status in Mahara:
  In Progress
Status in Mahara 16.04 series:
  New
Status in Mahara 16.10 series:
  In Progress

Bug description:
  There is an issue with race conditions and copying pages in Mahara
  when using a MySQL database.

  What happens is the values in view_rows_columns for the view get
  deleted somehow and this ends up making the page look empty/page
  blocks 'look' deleted.

  They still exist but the system doesn't know how to display the page.

  Luckily we can work out what the rows were by looking at data from a
  number of other tables and repopulate the table.

  I'll add a fix for this.

  To test:
  before patch:
  1) Create a page and add some blocks to it
  2) create another page and set the layout to multiple rows and add some 
blocks on each row
  3) View the pages to make sure they look ok, open each in a new tab for ease 
of checking
  4) Go to the db and then run:
    SELECT FROM view_rows_columns WHERE view = [viewid];
  to see what rows it has
    DELETE FROM view_rows_columns WHERE view = [viewid];
  and get the [viewid] from the urls off the pages

  5) Refresh the pages they should be blank (and you will get a bunch of
  errors in debugging on)

  6) Checkout patch and refresh the pages again you should see the pages
  looking correct again

  7) Check the db again and see the rows have returned and should be the
  same as before

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1626805/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1626805] Re: Page becomes blank after a while

2016-09-22 Thread Robert Lyon
https://reviews.mahara.org/#/c/7014/

** Changed in: mahara
   Importance: Undecided => High

** Also affects: mahara/16.04
   Importance: Undecided
   Status: New

** Also affects: mahara/16.10
   Importance: High
   Status: New

** Changed in: mahara/16.04
   Importance: Undecided => High

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1626805

Title:
  Page becomes blank after a while

Status in Mahara:
  In Progress
Status in Mahara 16.04 series:
  New
Status in Mahara 16.10 series:
  In Progress

Bug description:
  There is an issue with race conditions and copying pages in Mahara
  when using a MySQL database.

  What happens is the values in view_rows_columns for the view get
  deleted somehow and this ends up making the page look empty/page
  blocks 'look' deleted.

  They still exist but the system doesn't know how to display the page.

  Luckily we can work out what the rows were by looking at data from a
  number of other tables and repopulate the table.

  I'll add a fix for this.

  To test:
  before patch:
  1) Create a page and add some blocks to it
  2) create another page and set the layout to multiple rows and add some 
blocks on each row
  3) View the pages to make sure they look ok, open each in a new tab for ease 
of checking
  4) Go to the db and then run:
    SELECT FROM view_rows_columns WHERE view = [viewid];
  to see what rows it has
    DELETE FROM view_rows_columns WHERE view = [viewid];
  and get the [viewid] from the urls off the pages

  5) Refresh the pages they should be blank (and you will get a bunch of
  errors in debugging on)

  6) Checkout patch and refresh the pages again you should see the pages
  looking correct again

  7) Check the db again and see the rows have returned and should be the
  same as before

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1626805/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1626805] A patch has been submitted for review

2016-09-22 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/7014

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1626805

Title:
  Page becomes blank after a while

Status in Mahara:
  In Progress
Status in Mahara 16.04 series:
  New
Status in Mahara 16.10 series:
  In Progress

Bug description:
  There is an issue with race conditions and copying pages in Mahara
  when using a MySQL database.

  What happens is the values in view_rows_columns for the view get
  deleted somehow and this ends up making the page look empty/page
  blocks 'look' deleted.

  They still exist but the system doesn't know how to display the page.

  Luckily we can work out what the rows were by looking at data from a
  number of other tables and repopulate the table.

  I'll add a fix for this.

  To test:
  before patch:
  1) Create a page and add some blocks to it
  2) create another page and set the layout to multiple rows and add some 
blocks on each row
  3) View the pages to make sure they look ok, open each in a new tab for ease 
of checking
  4) Go to the db and then run:
    SELECT FROM view_rows_columns WHERE view = [viewid];
  to see what rows it has
    DELETE FROM view_rows_columns WHERE view = [viewid];
  and get the [viewid] from the urls off the pages

  5) Refresh the pages they should be blank (and you will get a bunch of
  errors in debugging on)

  6) Checkout patch and refresh the pages again you should see the pages
  looking correct again

  7) Check the db again and see the rows have returned and should be the
  same as before

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1626805/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1626805] [NEW] Page becomes blank after a while

2016-09-22 Thread Robert Lyon
Public bug reported:

There is an issue with race conditions and copying pages in Mahara when
using a MySQL database.

What happens is the values in view_rows_columns for the view get deleted
somehow and this ends up making the page look empty/page blocks 'look'
deleted.

They still exist but the system doesn't know how to display the page.

Luckily we can work out what the rows were by looking at data from a
number of other tables and repopulate the table.

I'll add a fix for this.

To test:
before patch:
1) Create a page and add some blocks to it
2) create another page and set the layout to multiple rows and add some blocks 
on each row
3) View the pages to make sure they look ok, open each in a new tab for ease of 
checking
4) Go to the db and then run:
  SELECT FROM view_rows_columns WHERE view = [viewid];
to see what rows it has
  DELETE FROM view_rows_columns WHERE view = [viewid];
and get the [viewid] from the urls off the pages

5) Refresh the pages they should be blank (and you will get a bunch of
errors in debugging on)

6) Checkout patch and refresh the pages again you should see the pages
looking correct again

7) Check the db again and see the rows have returned and should be the
same as before

** Affects: mahara
 Importance: High
 Status: In Progress

** Affects: mahara/16.04
 Importance: High
 Status: New

** Affects: mahara/16.10
 Importance: High
 Status: In Progress

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1626805

Title:
  Page becomes blank after a while

Status in Mahara:
  In Progress
Status in Mahara 16.04 series:
  New
Status in Mahara 16.10 series:
  In Progress

Bug description:
  There is an issue with race conditions and copying pages in Mahara
  when using a MySQL database.

  What happens is the values in view_rows_columns for the view get
  deleted somehow and this ends up making the page look empty/page
  blocks 'look' deleted.

  They still exist but the system doesn't know how to display the page.

  Luckily we can work out what the rows were by looking at data from a
  number of other tables and repopulate the table.

  I'll add a fix for this.

  To test:
  before patch:
  1) Create a page and add some blocks to it
  2) create another page and set the layout to multiple rows and add some 
blocks on each row
  3) View the pages to make sure they look ok, open each in a new tab for ease 
of checking
  4) Go to the db and then run:
    SELECT FROM view_rows_columns WHERE view = [viewid];
  to see what rows it has
    DELETE FROM view_rows_columns WHERE view = [viewid];
  and get the [viewid] from the urls off the pages

  5) Refresh the pages they should be blank (and you will get a bunch of
  errors in debugging on)

  6) Checkout patch and refresh the pages again you should see the pages
  looking correct again

  7) Check the db again and see the rows have returned and should be the
  same as before

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1626805/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1620394] A patch has been submitted for review

2016-09-22 Thread Mahara Bot
Patch for "16.04_STABLE" branch: https://reviews.mahara.org/7013

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1620394

Title:
  The institution static pages form is confusing

Status in Mahara:
  Fix Committed
Status in Mahara 15.10 series:
  In Progress
Status in Mahara 16.04 series:
  In Progress
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  In 15.04 the textarea/TinyMCE field was disabled if the 'Use site
  default' switch was set to 'Yes'

  This functionality was lost in later versions.

  It needs to be put back for UX experience.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1620394/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1620394] A patch has been submitted for review

2016-09-22 Thread Mahara Bot
Patch for "15.10_STABLE" branch: https://reviews.mahara.org/7012

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1620394

Title:
  The institution static pages form is confusing

Status in Mahara:
  Fix Committed
Status in Mahara 15.10 series:
  In Progress
Status in Mahara 16.04 series:
  In Progress
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  In 15.04 the textarea/TinyMCE field was disabled if the 'Use site
  default' switch was set to 'Yes'

  This functionality was lost in later versions.

  It needs to be put back for UX experience.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1620394/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1620394] Re: The institution static pages form is confusing

2016-09-22 Thread Robert Lyon
** Changed in: mahara/16.10
   Status: In Progress => Fix Committed

** Changed in: mahara/16.04
   Status: New => In Progress

** Changed in: mahara/15.10
   Status: New => In Progress

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1620394

Title:
  The institution static pages form is confusing

Status in Mahara:
  Fix Committed
Status in Mahara 15.10 series:
  In Progress
Status in Mahara 16.04 series:
  In Progress
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  In 15.04 the textarea/TinyMCE field was disabled if the 'Use site
  default' switch was set to 'Yes'

  This functionality was lost in later versions.

  It needs to be put back for UX experience.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1620394/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1620394] A change has been merged

2016-09-22 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/7011
Committed: 
https://git.mahara.org/mahara/mahara/commit/d15725925d0e105ec9d59b50ab5e9522a58739e0
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:16.10_STABLE

commit d15725925d0e105ec9d59b50ab5e9522a58739e0
Author: Robert Lyon 
Date:   Tue Sep 6 09:10:13 2016 +1200

Bug 1620394: Getting the correct offset for the overlay

When we have 'use site default' ticked - this was broken in 15.10

We need to stop old messages from fading out on this page or the
overlay is not positioned correctly if we do multiple savings of the
form

behatnotneeded

Change-Id: I23df925ff2cfee168371f3f8e823f1dd3ffef592
Signed-off-by: Robert Lyon 
(cherry picked from commit 2da3dffb4c03e50a56888615968eaa1f6758b502)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1620394

Title:
  The institution static pages form is confusing

Status in Mahara:
  Fix Committed
Status in Mahara 15.10 series:
  In Progress
Status in Mahara 16.04 series:
  In Progress
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  In 15.04 the textarea/TinyMCE field was disabled if the 'Use site
  default' switch was set to 'Yes'

  This functionality was lost in later versions.

  It needs to be put back for UX experience.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1620394/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1620394] A patch has been submitted for review

2016-09-22 Thread Mahara Bot
Patch for "16.10_STABLE" branch: https://reviews.mahara.org/7011

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1620394

Title:
  The institution static pages form is confusing

Status in Mahara:
  Fix Committed
Status in Mahara 15.10 series:
  In Progress
Status in Mahara 16.04 series:
  In Progress
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  In 15.04 the textarea/TinyMCE field was disabled if the 'Use site
  default' switch was set to 'Yes'

  This functionality was lost in later versions.

  It needs to be put back for UX experience.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1620394/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1620394] A change has been merged

2016-09-22 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/6925
Committed: 
https://git.mahara.org/mahara/mahara/commit/2da3dffb4c03e50a56888615968eaa1f6758b502
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:master

commit 2da3dffb4c03e50a56888615968eaa1f6758b502
Author: Robert Lyon 
Date:   Tue Sep 6 09:10:13 2016 +1200

Bug 1620394: Getting the correct offset for the overlay

When we have 'use site default' ticked - this was broken in 15.10

We need to stop old messages from fading out on this page or the
overlay is not positioned correctly if we do multiple savings of the
form

behatnotneeded

Change-Id: I23df925ff2cfee168371f3f8e823f1dd3ffef592
Signed-off-by: Robert Lyon 

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1620394

Title:
  The institution static pages form is confusing

Status in Mahara:
  Fix Committed
Status in Mahara 15.10 series:
  In Progress
Status in Mahara 16.04 series:
  In Progress
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  In 15.04 the textarea/TinyMCE field was disabled if the 'Use site
  default' switch was set to 'Yes'

  This functionality was lost in later versions.

  It needs to be put back for UX experience.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1620394/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1568611] Re: Comment ratings are not accessible

2016-09-22 Thread Robert Lyon
** Changed in: mahara/16.04
   Status: Confirmed => In Progress

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1568611

Title:
  Comment ratings are not accessible

Status in Mahara:
  Fix Committed
Status in Mahara 16.04 series:
  In Progress
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  Mahara 16.04dev

  The new star ratings are not accessible and would need screen-reader
  only text.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1568611/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1568611] A change has been merged

2016-09-22 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/6994
Committed: 
https://git.mahara.org/mahara/mahara/commit/eb4e7e31bad6c91f5a9c20c8462542ad02baa74a
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:master

commit eb4e7e31bad6c91f5a9c20c8462542ad02baa74a
Author: Robert Lyon 
Date:   Thu Sep 22 09:23:36 2016 +1200

Bug 1568611: Adding accessibility to rating stars

behatnotneeded

Change-Id: Ife78860e6ba4a88fb57c6de0517caa955eb1a52e
Signed-off-by: Robert Lyon 

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1568611

Title:
  Comment ratings are not accessible

Status in Mahara:
  Fix Committed
Status in Mahara 16.04 series:
  In Progress
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  Mahara 16.04dev

  The new star ratings are not accessible and would need screen-reader
  only text.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1568611/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1568611] A patch has been submitted for review

2016-09-22 Thread Mahara Bot
Patch for "16.10_STABLE" branch: https://reviews.mahara.org/7009

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1568611

Title:
  Comment ratings are not accessible

Status in Mahara:
  Fix Committed
Status in Mahara 16.04 series:
  In Progress
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  Mahara 16.04dev

  The new star ratings are not accessible and would need screen-reader
  only text.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1568611/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1568611] A change has been merged

2016-09-22 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/7009
Committed: 
https://git.mahara.org/mahara/mahara/commit/377aa5fb064535fa835ebb010b8c7d904989f663
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:16.10_STABLE

commit 377aa5fb064535fa835ebb010b8c7d904989f663
Author: Robert Lyon 
Date:   Thu Sep 22 09:23:36 2016 +1200

Bug 1568611: Adding accessibility to rating stars

behatnotneeded

Change-Id: Ife78860e6ba4a88fb57c6de0517caa955eb1a52e
Signed-off-by: Robert Lyon 
(cherry picked from commit eb4e7e31bad6c91f5a9c20c8462542ad02baa74a)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1568611

Title:
  Comment ratings are not accessible

Status in Mahara:
  Fix Committed
Status in Mahara 16.04 series:
  In Progress
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  Mahara 16.04dev

  The new star ratings are not accessible and would need screen-reader
  only text.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1568611/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1626281] A change has been merged

2016-09-22 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/7008
Committed: 
https://git.mahara.org/mahara/mahara/commit/b91f4f67594e22f2007eb64cacbeee475a482584
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:16.10_STABLE

commit b91f4f67594e22f2007eb64cacbeee475a482584
Author: Robert Lyon 
Date:   Thu Sep 22 09:16:20 2016 +1200

Bug 1626281: Pass the 'section' for js lang strings for better
debugging.

@TODO: Allow the js lang strings be picked based on on the section
supplied so that name/section make them unique rather than just name

behatnotneeded - existing test will be sufficient

Change-Id: Ie64725702527b7fd9a08749816ea1fd084e95a2d
Signed-off-by: Robert Lyon 
(cherry picked from commit 75316569320985ece0d5df5d6840e7fda3762a45)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1626281

Title:
  Allow the js lang strings to have their section set when doing
  variable replacement

Status in Mahara:
  Fix Committed

Bug description:
  Currently when we have a js string, say string.nrrows='%s rows' and we
  call it with get_string('nrrows', 4) - but we should call it with
  get_string('nrrows', 'view', 4) to indicate that this string is from
  the 'view' lang file.

  I'll make the change so that the 'section' can be passed in as well so
  that in the future we can decide which section's lang string to use
  rather than currently having them be all unique.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1626281/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1568611] Re: Comment ratings are not accessible

2016-09-22 Thread Robert Lyon
** Changed in: mahara/16.10
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1568611

Title:
  Comment ratings are not accessible

Status in Mahara:
  Fix Committed
Status in Mahara 16.04 series:
  In Progress
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  Mahara 16.04dev

  The new star ratings are not accessible and would need screen-reader
  only text.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1568611/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1568611] A patch has been submitted for review

2016-09-22 Thread Mahara Bot
Patch for "16.04_STABLE" branch: https://reviews.mahara.org/7010

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1568611

Title:
  Comment ratings are not accessible

Status in Mahara:
  Fix Committed
Status in Mahara 16.04 series:
  In Progress
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  Mahara 16.04dev

  The new star ratings are not accessible and would need screen-reader
  only text.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1568611/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1626281] Re: Allow the js lang strings to have their section set when doing variable replacement

2016-09-22 Thread Robert Lyon
** Changed in: mahara
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1626281

Title:
  Allow the js lang strings to have their section set when doing
  variable replacement

Status in Mahara:
  Fix Committed

Bug description:
  Currently when we have a js string, say string.nrrows='%s rows' and we
  call it with get_string('nrrows', 4) - but we should call it with
  get_string('nrrows', 'view', 4) to indicate that this string is from
  the 'view' lang file.

  I'll make the change so that the 'section' can be passed in as well so
  that in the future we can decide which section's lang string to use
  rather than currently having them be all unique.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1626281/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1626281] A change has been merged

2016-09-22 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/6995
Committed: 
https://git.mahara.org/mahara/mahara/commit/75316569320985ece0d5df5d6840e7fda3762a45
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:master

commit 75316569320985ece0d5df5d6840e7fda3762a45
Author: Robert Lyon 
Date:   Thu Sep 22 09:16:20 2016 +1200

Bug 1626281: Pass the 'section' for js lang strings for better
debugging.

@TODO: Allow the js lang strings be picked based on on the section
supplied so that name/section make them unique rather than just name

behatnotneeded - existing test will be sufficient

Change-Id: Ie64725702527b7fd9a08749816ea1fd084e95a2d
Signed-off-by: Robert Lyon 

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1626281

Title:
  Allow the js lang strings to have their section set when doing
  variable replacement

Status in Mahara:
  Fix Committed

Bug description:
  Currently when we have a js string, say string.nrrows='%s rows' and we
  call it with get_string('nrrows', 4) - but we should call it with
  get_string('nrrows', 'view', 4) to indicate that this string is from
  the 'view' lang file.

  I'll make the change so that the 'section' can be passed in as well so
  that in the future we can decide which section's lang string to use
  rather than currently having them be all unique.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1626281/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1626705] A patch has been submitted for review

2016-09-22 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/7007

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1626705

Title:
  Copying of group throws ADODB error

Status in Mahara:
  In Progress

Bug description:
  Mahara 16.10dev, upgraded site from Mahara 16.04

  I upgraded my site from 16.04 and when attempting to copy a group, it
  throws the following error:

  [WAR] d3 (lib/adodb/adodb-exceptions.inc.php:45) Array to string conversion
  Call stack (most recent first):

  log_message("Array to string conversion", 8, true, true, 
"/home/kristina/code/1610stable/htdocs/lib/adodb/ad...", 45) at 
/home/kristina/code/1610stable/htdocs/lib/errors.php:513
  error(8, "Array to string conversion", 
"/home/kristina/code/1610stable/htdocs/lib/adodb/ad...", 45, array(size 7)) at 
/home/kristina/code/1610stable/htdocs/lib/adodb/adodb-exceptions.inc.php:45
  ADODB_Exception->__construct("postgres8", "adodb_throw", -1, "ERROR: 
value too long for type character varying(...", "INSERT INTO "group" ("id", 
"name", "description", ...", array(size 28), object(ADODB_postgres8)) at 
/home/kristina/code/1610stable/htdocs/lib/adodb/adodb-exceptions.inc.php:80
  adodb_throw("postgres8", "adodb_throw", -1, "ERROR: value too long for 
type character varying(...", "INSERT INTO "group" ("id", "name", "description", 
...", array(size 28), object(ADODB_postgres8)) at 
/home/kristina/code/1610stable/htdocs/lib/adodb/adodb.inc.php:298
  ADODB_TransMonitor("postgres8", "EXECUTE", -1, "ERROR: value too long for 
type character varying(...", "INSERT INTO "group" ("id", "name", "description", 
...", array(size 28), object(ADODB_postgres8)) at 
/home/kristina/code/1610stable/htdocs/lib/adodb/adodb.inc.php:1249
  ADOConnection->_Execute("INSERT INTO "group" ("id", "name", 
"description", ...", array(size 28)) at 
/home/kristina/code/1610stable/htdocs/lib/adodb/adodb.inc.php:1209
  ADOConnection->Execute("INSERT INTO "group" ("id", "name", "description", 
...", array(size 28)) at /home/kristina/code/1610stable/htdocs/lib/dml.php:1085
  insert_record("group", object(stdClass), "id", true) at 
/home/kristina/code/1610stable/htdocs/lib/group.php:451
  group_create(array(size 31)) at 
/home/kristina/code/1610stable/htdocs/lib/group.php:2808
  group_copy(2, "adminlist") at 
/home/kristina/code/1610stable/htdocs/group/copy.php:37

  [WAR] d3 (lib/errors.php:819) Failed to get a recordset: postgres8 error: 
[-1: ERROR:  value too long for type character varying(30)] in 
adodb_throw(INSERT INTO "group" ("id", "name", "description", "grouptype", 
"jointype", "ctime", "mtime", "public", "usersautoadded", "category", 
"viewnotify", "quota", "institution", "shortname", "request", "submittableto", 
"editroles", "hidden", "hidemembers", "hidemembersfrommembers", 
"groupparticipationreports", "invitefriends", "suggestfriends", "urlid", 
"editwindowend", "sendnow", "feedbacknotify", "allowarchives") VALUES (?, ?, ?, 
?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?), 
Array)
  Command was: INSERT INTO "group" ("id", "name", "description", "grouptype", 
"jointype", "ctime", "mtime", "public", "usersautoadded", "category", 
"viewnotify", "quota", "institution", "shortname", "request", "submittableto", 
"editroles", "hidden", "hidemembers", "hidemembersfrommembers", 
"groupparticipationreports", "invitefriends", "suggestfriends", "urlid", 
"editwindowend", "sendnow", "feedbacknotify", "allowarchives") VALUES (?, ?, ?, 
?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?) and 
values was 
(id:10,name:HumanComputerInteraction101v.2,description:Foundationcourseforbeginners,grouptype:course,jointype:approve,ctime:2016-09-2307:15:43,mtime:2016-09-2307:15:43,public:0,usersautoadded:0,category:1,viewnotify:1,quota:52428800,institution:mahara,shortname:humancomputerinteraction101a,request:1,submittableto:1,editroles:notmember,hidden:0,hidemembers:0,hidemembersfrommembers:0,groupparticipationreports:0,invitefriends:1,suggestfriends:0,urlid:human
 
-computer-interaction-101-v-2,editwindowend:2016-11-0700:00:00,sendnow:0,feedbacknotify:1,allowarchives:0)
  Call stack (most recent first):

  log_message("Failed to get a recordset: postgres8 error: [-1: E...", 8, 
true, true) at /home/kristina/code/1610stable/htdocs/lib/errors.php:95
  log_warn("Failed to get a recordset: postgres8 error: [-1: E...") at 
/home/kristina/code/1610stable/htdocs/lib/errors.php:819
  SQLException->__construct("Failed to get a recordset: postgres8 error: 
[-1: E...") at /home/kristina/code/1610stable/htdocs/lib/dml.php:1088
  insert_record("group", object(stdClass), "id", true) at 
/home/kristina/code/1610stable/htdocs/lib/group.php:451
  

[Mahara-contributors] [Bug 1626705] Re: Copying of group throws ADODB error

2016-09-22 Thread Son Nguyen
The problem is the value of group urlid is longer than 30.
This value is generated by the function generate_urlid()
at line 2799, htdocs/lib/group.php

 $group->urlid = generate_urlid($group->name,
get_config('cleanurlviewdefault'), 3, 100);

The max length should set to 30

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1626705

Title:
  Copying of group throws ADODB error

Status in Mahara:
  In Progress

Bug description:
  Mahara 16.10dev, upgraded site from Mahara 16.04

  I upgraded my site from 16.04 and when attempting to copy a group, it
  throws the following error:

  [WAR] d3 (lib/adodb/adodb-exceptions.inc.php:45) Array to string conversion
  Call stack (most recent first):

  log_message("Array to string conversion", 8, true, true, 
"/home/kristina/code/1610stable/htdocs/lib/adodb/ad...", 45) at 
/home/kristina/code/1610stable/htdocs/lib/errors.php:513
  error(8, "Array to string conversion", 
"/home/kristina/code/1610stable/htdocs/lib/adodb/ad...", 45, array(size 7)) at 
/home/kristina/code/1610stable/htdocs/lib/adodb/adodb-exceptions.inc.php:45
  ADODB_Exception->__construct("postgres8", "adodb_throw", -1, "ERROR: 
value too long for type character varying(...", "INSERT INTO "group" ("id", 
"name", "description", ...", array(size 28), object(ADODB_postgres8)) at 
/home/kristina/code/1610stable/htdocs/lib/adodb/adodb-exceptions.inc.php:80
  adodb_throw("postgres8", "adodb_throw", -1, "ERROR: value too long for 
type character varying(...", "INSERT INTO "group" ("id", "name", "description", 
...", array(size 28), object(ADODB_postgres8)) at 
/home/kristina/code/1610stable/htdocs/lib/adodb/adodb.inc.php:298
  ADODB_TransMonitor("postgres8", "EXECUTE", -1, "ERROR: value too long for 
type character varying(...", "INSERT INTO "group" ("id", "name", "description", 
...", array(size 28), object(ADODB_postgres8)) at 
/home/kristina/code/1610stable/htdocs/lib/adodb/adodb.inc.php:1249
  ADOConnection->_Execute("INSERT INTO "group" ("id", "name", 
"description", ...", array(size 28)) at 
/home/kristina/code/1610stable/htdocs/lib/adodb/adodb.inc.php:1209
  ADOConnection->Execute("INSERT INTO "group" ("id", "name", "description", 
...", array(size 28)) at /home/kristina/code/1610stable/htdocs/lib/dml.php:1085
  insert_record("group", object(stdClass), "id", true) at 
/home/kristina/code/1610stable/htdocs/lib/group.php:451
  group_create(array(size 31)) at 
/home/kristina/code/1610stable/htdocs/lib/group.php:2808
  group_copy(2, "adminlist") at 
/home/kristina/code/1610stable/htdocs/group/copy.php:37

  [WAR] d3 (lib/errors.php:819) Failed to get a recordset: postgres8 error: 
[-1: ERROR:  value too long for type character varying(30)] in 
adodb_throw(INSERT INTO "group" ("id", "name", "description", "grouptype", 
"jointype", "ctime", "mtime", "public", "usersautoadded", "category", 
"viewnotify", "quota", "institution", "shortname", "request", "submittableto", 
"editroles", "hidden", "hidemembers", "hidemembersfrommembers", 
"groupparticipationreports", "invitefriends", "suggestfriends", "urlid", 
"editwindowend", "sendnow", "feedbacknotify", "allowarchives") VALUES (?, ?, ?, 
?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?), 
Array)
  Command was: INSERT INTO "group" ("id", "name", "description", "grouptype", 
"jointype", "ctime", "mtime", "public", "usersautoadded", "category", 
"viewnotify", "quota", "institution", "shortname", "request", "submittableto", 
"editroles", "hidden", "hidemembers", "hidemembersfrommembers", 
"groupparticipationreports", "invitefriends", "suggestfriends", "urlid", 
"editwindowend", "sendnow", "feedbacknotify", "allowarchives") VALUES (?, ?, ?, 
?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?) and 
values was 
(id:10,name:HumanComputerInteraction101v.2,description:Foundationcourseforbeginners,grouptype:course,jointype:approve,ctime:2016-09-2307:15:43,mtime:2016-09-2307:15:43,public:0,usersautoadded:0,category:1,viewnotify:1,quota:52428800,institution:mahara,shortname:humancomputerinteraction101a,request:1,submittableto:1,editroles:notmember,hidden:0,hidemembers:0,hidemembersfrommembers:0,groupparticipationreports:0,invitefriends:1,suggestfriends:0,urlid:human
 
-computer-interaction-101-v-2,editwindowend:2016-11-0700:00:00,sendnow:0,feedbacknotify:1,allowarchives:0)
  Call stack (most recent first):

  log_message("Failed to get a recordset: postgres8 error: [-1: E...", 8, 
true, true) at /home/kristina/code/1610stable/htdocs/lib/errors.php:95
  log_warn("Failed to get a recordset: postgres8 error: [-1: E...") at 
/home/kristina/code/1610stable/htdocs/lib/errors.php:819
  SQLException->__construct("Failed to get a 

[Mahara-contributors] [Bug 1622788] A patch has been submitted for review

2016-09-22 Thread Mahara Bot
Patch for "16.10_STABLE" branch: https://reviews.mahara.org/7006

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1622788

Title:
  Update the dependencies error for ssphp

Status in Mahara:
  Fix Committed

Bug description:
  Here are some more things that need to be installed before 'make
  ssphp' will run.

  php5-gmp and php-sqlite

  so we need to update our error messages to suit

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1622788/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1622788] A change has been merged

2016-09-22 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/6968
Committed: 
https://git.mahara.org/mahara/mahara/commit/25e8324dade37e42af23986744d8655c8a8b3f53
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:master

commit 25e8324dade37e42af23986744d8655c8a8b3f53
Author: Aaron Wells 
Date:   Tue Sep 13 12:51:18 2016 +1200

Bug 1622788: Composer step not needed for simplesamlphp

behatnotneeded: Covered by existing tests

Change-Id: I665a434470db4b2ecaf5db0f29b92380f49fe28c

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1622788

Title:
  Update the dependencies error for ssphp

Status in Mahara:
  Fix Committed

Bug description:
  Here are some more things that need to be installed before 'make
  ssphp' will run.

  php5-gmp and php-sqlite

  so we need to update our error messages to suit

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1622788/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1622788] A change has been merged

2016-09-22 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/7006
Committed: 
https://git.mahara.org/mahara/mahara/commit/ea36d14f5763621fbae43de1095169a3823567a3
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:16.10_STABLE

commit ea36d14f5763621fbae43de1095169a3823567a3
Author: Aaron Wells 
Date:   Tue Sep 13 12:51:18 2016 +1200

Bug 1622788: Composer step not needed for simplesamlphp

behatnotneeded: Covered by existing tests

Change-Id: I665a434470db4b2ecaf5db0f29b92380f49fe28c
(cherry picked from commit 25e8324dade37e42af23986744d8655c8a8b3f53)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1622788

Title:
  Update the dependencies error for ssphp

Status in Mahara:
  Fix Committed

Bug description:
  Here are some more things that need to be installed before 'make
  ssphp' will run.

  php5-gmp and php-sqlite

  so we need to update our error messages to suit

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1622788/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1622788] Re: Update the dependencies error for ssphp

2016-09-22 Thread Robert Lyon
** Changed in: mahara
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1622788

Title:
  Update the dependencies error for ssphp

Status in Mahara:
  Fix Committed

Bug description:
  Here are some more things that need to be installed before 'make
  ssphp' will run.

  php5-gmp and php-sqlite

  so we need to update our error messages to suit

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1622788/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1625861] A change has been merged

2016-09-22 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/6991
Committed: 
https://git.mahara.org/mahara/mahara/commit/805752b541cc16fbd172e24bc38abf1607319a17
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:master

commit 805752b541cc16fbd172e24bc38abf1607319a17
Author: Robert Lyon 
Date:   Wed Sep 21 13:17:50 2016 +1200

Bug 1625861: Moving the upload form off the plugin config system

And moving it to the Admin -> Exntension -> SmartEvidence page

Change-Id: I897d45398e34b456640001392ce143d8c6865c58
Signed-off-by: Robert Lyon 

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1625861

Title:
  Consolidate SmartEvidence administration

Status in Mahara:
  Fix Committed

Bug description:
  Mahara 16.10dev

  Currently, there is a cog on the plugin administration page and also a
  sub navigation item that display two different things. It will be
  better - now that we have the sub menu - to remove the admin cog
  altogether and have the "Add matrix" button go to a form in that area
  rather than the plugin administration.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1625861/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1625861] A patch has been submitted for review

2016-09-22 Thread Mahara Bot
Patch for "16.10_STABLE" branch: https://reviews.mahara.org/7005

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1625861

Title:
  Consolidate SmartEvidence administration

Status in Mahara:
  Fix Committed

Bug description:
  Mahara 16.10dev

  Currently, there is a cog on the plugin administration page and also a
  sub navigation item that display two different things. It will be
  better - now that we have the sub menu - to remove the admin cog
  altogether and have the "Add matrix" button go to a form in that area
  rather than the plugin administration.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1625861/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1626329] A patch has been submitted for review

2016-09-22 Thread Mahara Bot
Patch for "16.10_STABLE" branch: https://reviews.mahara.org/7004

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1626329

Title:
  A sql call in auth/saml missing curly brackets

Status in Mahara:
  Fix Committed

Bug description:
  The usr table call name not in brackets so sql error if one is using
  table prefix in config

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1626329/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1625861] Re: Consolidate SmartEvidence administration

2016-09-22 Thread Robert Lyon
** Changed in: mahara
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1625861

Title:
  Consolidate SmartEvidence administration

Status in Mahara:
  Fix Committed

Bug description:
  Mahara 16.10dev

  Currently, there is a cog on the plugin administration page and also a
  sub navigation item that display two different things. It will be
  better - now that we have the sub menu - to remove the admin cog
  altogether and have the "Add matrix" button go to a form in that area
  rather than the plugin administration.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1625861/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1626329] A change has been merged

2016-09-22 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/7004
Committed: 
https://git.mahara.org/mahara/mahara/commit/d355e86da158c7862bcfb55abcbc7794e8dc8934
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:16.10_STABLE

commit d355e86da158c7862bcfb55abcbc7794e8dc8934
Author: Robert Lyon 
Date:   Thu Sep 22 11:57:56 2016 +1200

Bug 1626329: Wrapping table name in curly brackets

fixing sql call table not in {}

behatnotneeded

Change-Id: I97c110bbbf68e51d8a3337ce213840869c3dbe77
Signed-off-by: Robert Lyon 
(cherry picked from commit 58abb86f7c4ac3aaa6352f4a68f90353ad1b9b3a)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1626329

Title:
  A sql call in auth/saml missing curly brackets

Status in Mahara:
  Fix Committed

Bug description:
  The usr table call name not in brackets so sql error if one is using
  table prefix in config

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1626329/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1626329] Re: A sql call in auth/saml missing curly brackets

2016-09-22 Thread Robert Lyon
** Changed in: mahara
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1626329

Title:
  A sql call in auth/saml missing curly brackets

Status in Mahara:
  Fix Committed

Bug description:
  The usr table call name not in brackets so sql error if one is using
  table prefix in config

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1626329/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1625861] A change has been merged

2016-09-22 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/7005
Committed: 
https://git.mahara.org/mahara/mahara/commit/d68b153773eb29c233e13cd64e70891a26f397fc
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:16.10_STABLE

commit d68b153773eb29c233e13cd64e70891a26f397fc
Author: Robert Lyon 
Date:   Wed Sep 21 13:17:50 2016 +1200

Bug 1625861: Moving the upload form off the plugin config system

And moving it to the Admin -> Exntension -> SmartEvidence page

Change-Id: I897d45398e34b456640001392ce143d8c6865c58
Signed-off-by: Robert Lyon 
(cherry picked from commit 805752b541cc16fbd172e24bc38abf1607319a17)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1625861

Title:
  Consolidate SmartEvidence administration

Status in Mahara:
  Fix Committed

Bug description:
  Mahara 16.10dev

  Currently, there is a cog on the plugin administration page and also a
  sub navigation item that display two different things. It will be
  better - now that we have the sub menu - to remove the admin cog
  altogether and have the "Add matrix" button go to a form in that area
  rather than the plugin administration.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1625861/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1626705] Re: Copying of group throws ADODB error

2016-09-22 Thread Son Nguyen
** Changed in: mahara
 Assignee: (unassigned) => Son Nguyen (ngson2000)

** Changed in: mahara
   Status: Confirmed => In Progress

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1626705

Title:
  Copying of group throws ADODB error

Status in Mahara:
  In Progress

Bug description:
  Mahara 16.10dev, upgraded site from Mahara 16.04

  I upgraded my site from 16.04 and when attempting to copy a group, it
  throws the following error:

  [WAR] d3 (lib/adodb/adodb-exceptions.inc.php:45) Array to string conversion
  Call stack (most recent first):

  log_message("Array to string conversion", 8, true, true, 
"/home/kristina/code/1610stable/htdocs/lib/adodb/ad...", 45) at 
/home/kristina/code/1610stable/htdocs/lib/errors.php:513
  error(8, "Array to string conversion", 
"/home/kristina/code/1610stable/htdocs/lib/adodb/ad...", 45, array(size 7)) at 
/home/kristina/code/1610stable/htdocs/lib/adodb/adodb-exceptions.inc.php:45
  ADODB_Exception->__construct("postgres8", "adodb_throw", -1, "ERROR: 
value too long for type character varying(...", "INSERT INTO "group" ("id", 
"name", "description", ...", array(size 28), object(ADODB_postgres8)) at 
/home/kristina/code/1610stable/htdocs/lib/adodb/adodb-exceptions.inc.php:80
  adodb_throw("postgres8", "adodb_throw", -1, "ERROR: value too long for 
type character varying(...", "INSERT INTO "group" ("id", "name", "description", 
...", array(size 28), object(ADODB_postgres8)) at 
/home/kristina/code/1610stable/htdocs/lib/adodb/adodb.inc.php:298
  ADODB_TransMonitor("postgres8", "EXECUTE", -1, "ERROR: value too long for 
type character varying(...", "INSERT INTO "group" ("id", "name", "description", 
...", array(size 28), object(ADODB_postgres8)) at 
/home/kristina/code/1610stable/htdocs/lib/adodb/adodb.inc.php:1249
  ADOConnection->_Execute("INSERT INTO "group" ("id", "name", 
"description", ...", array(size 28)) at 
/home/kristina/code/1610stable/htdocs/lib/adodb/adodb.inc.php:1209
  ADOConnection->Execute("INSERT INTO "group" ("id", "name", "description", 
...", array(size 28)) at /home/kristina/code/1610stable/htdocs/lib/dml.php:1085
  insert_record("group", object(stdClass), "id", true) at 
/home/kristina/code/1610stable/htdocs/lib/group.php:451
  group_create(array(size 31)) at 
/home/kristina/code/1610stable/htdocs/lib/group.php:2808
  group_copy(2, "adminlist") at 
/home/kristina/code/1610stable/htdocs/group/copy.php:37

  [WAR] d3 (lib/errors.php:819) Failed to get a recordset: postgres8 error: 
[-1: ERROR:  value too long for type character varying(30)] in 
adodb_throw(INSERT INTO "group" ("id", "name", "description", "grouptype", 
"jointype", "ctime", "mtime", "public", "usersautoadded", "category", 
"viewnotify", "quota", "institution", "shortname", "request", "submittableto", 
"editroles", "hidden", "hidemembers", "hidemembersfrommembers", 
"groupparticipationreports", "invitefriends", "suggestfriends", "urlid", 
"editwindowend", "sendnow", "feedbacknotify", "allowarchives") VALUES (?, ?, ?, 
?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?), 
Array)
  Command was: INSERT INTO "group" ("id", "name", "description", "grouptype", 
"jointype", "ctime", "mtime", "public", "usersautoadded", "category", 
"viewnotify", "quota", "institution", "shortname", "request", "submittableto", 
"editroles", "hidden", "hidemembers", "hidemembersfrommembers", 
"groupparticipationreports", "invitefriends", "suggestfriends", "urlid", 
"editwindowend", "sendnow", "feedbacknotify", "allowarchives") VALUES (?, ?, ?, 
?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?) and 
values was 
(id:10,name:HumanComputerInteraction101v.2,description:Foundationcourseforbeginners,grouptype:course,jointype:approve,ctime:2016-09-2307:15:43,mtime:2016-09-2307:15:43,public:0,usersautoadded:0,category:1,viewnotify:1,quota:52428800,institution:mahara,shortname:humancomputerinteraction101a,request:1,submittableto:1,editroles:notmember,hidden:0,hidemembers:0,hidemembersfrommembers:0,groupparticipationreports:0,invitefriends:1,suggestfriends:0,urlid:human
 
-computer-interaction-101-v-2,editwindowend:2016-11-0700:00:00,sendnow:0,feedbacknotify:1,allowarchives:0)
  Call stack (most recent first):

  log_message("Failed to get a recordset: postgres8 error: [-1: E...", 8, 
true, true) at /home/kristina/code/1610stable/htdocs/lib/errors.php:95
  log_warn("Failed to get a recordset: postgres8 error: [-1: E...") at 
/home/kristina/code/1610stable/htdocs/lib/errors.php:819
  SQLException->__construct("Failed to get a recordset: postgres8 error: 
[-1: E...") at /home/kristina/code/1610stable/htdocs/lib/dml.php:1088
  insert_record("group", 

[Mahara-contributors] [Bug 1626329] A change has been merged

2016-09-22 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/7002
Committed: 
https://git.mahara.org/mahara/mahara/commit/58abb86f7c4ac3aaa6352f4a68f90353ad1b9b3a
Submitter: Son Nguyen (son.ngu...@catalyst.net.nz)
Branch:master

commit 58abb86f7c4ac3aaa6352f4a68f90353ad1b9b3a
Author: Robert Lyon 
Date:   Thu Sep 22 11:57:56 2016 +1200

Bug 1626329: Wrapping table name in curly brackets

fixing sql call table not in {}

behatnotneeded

Change-Id: I97c110bbbf68e51d8a3337ce213840869c3dbe77
Signed-off-by: Robert Lyon 

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1626329

Title:
  A sql call in auth/saml missing curly brackets

Status in Mahara:
  In Progress

Bug description:
  The usr table call name not in brackets so sql error if one is using
  table prefix in config

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1626329/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1587950] Re: Warning message not in a warning color

2016-09-22 Thread Kristina Hoeppner
** Tags added: usermanualupdate

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1587950

Title:
  Warning message not in a warning color

Status in Mahara:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Committed
Status in Mahara 16.10 series:
  Fix Committed

Bug description:
  The warning message, that is intended to prevent users from
  accidentally editing/deleting a note in more than one place uses a
  color that does not convey the intent of a warning. This may lead to
  unintentional consequences, that might be prevented by a more suitable
  color[1].

  Mahara Version: 15.10.3

  [1]:https://infinum.co/the-capsized-eight/articles/ux-quick-tip-the-
  proper-way-of-handling-notifications

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1587950/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1626705] [NEW] Copying of group throws ADODB error

2016-09-22 Thread Kristina Hoeppner
Public bug reported:

Mahara 16.10dev, upgraded site from Mahara 16.04

I upgraded my site from 16.04 and when attempting to copy a group, it
throws the following error:

[WAR] d3 (lib/adodb/adodb-exceptions.inc.php:45) Array to string conversion
Call stack (most recent first):

log_message("Array to string conversion", 8, true, true, 
"/home/kristina/code/1610stable/htdocs/lib/adodb/ad...", 45) at 
/home/kristina/code/1610stable/htdocs/lib/errors.php:513
error(8, "Array to string conversion", 
"/home/kristina/code/1610stable/htdocs/lib/adodb/ad...", 45, array(size 7)) at 
/home/kristina/code/1610stable/htdocs/lib/adodb/adodb-exceptions.inc.php:45
ADODB_Exception->__construct("postgres8", "adodb_throw", -1, "ERROR: value 
too long for type character varying(...", "INSERT INTO "group" ("id", "name", 
"description", ...", array(size 28), object(ADODB_postgres8)) at 
/home/kristina/code/1610stable/htdocs/lib/adodb/adodb-exceptions.inc.php:80
adodb_throw("postgres8", "adodb_throw", -1, "ERROR: value too long for type 
character varying(...", "INSERT INTO "group" ("id", "name", "description", 
...", array(size 28), object(ADODB_postgres8)) at 
/home/kristina/code/1610stable/htdocs/lib/adodb/adodb.inc.php:298
ADODB_TransMonitor("postgres8", "EXECUTE", -1, "ERROR: value too long for 
type character varying(...", "INSERT INTO "group" ("id", "name", "description", 
...", array(size 28), object(ADODB_postgres8)) at 
/home/kristina/code/1610stable/htdocs/lib/adodb/adodb.inc.php:1249
ADOConnection->_Execute("INSERT INTO "group" ("id", "name", "description", 
...", array(size 28)) at 
/home/kristina/code/1610stable/htdocs/lib/adodb/adodb.inc.php:1209
ADOConnection->Execute("INSERT INTO "group" ("id", "name", "description", 
...", array(size 28)) at /home/kristina/code/1610stable/htdocs/lib/dml.php:1085
insert_record("group", object(stdClass), "id", true) at 
/home/kristina/code/1610stable/htdocs/lib/group.php:451
group_create(array(size 31)) at 
/home/kristina/code/1610stable/htdocs/lib/group.php:2808
group_copy(2, "adminlist") at 
/home/kristina/code/1610stable/htdocs/group/copy.php:37

[WAR] d3 (lib/errors.php:819) Failed to get a recordset: postgres8 error: [-1: 
ERROR:  value too long for type character varying(30)] in adodb_throw(INSERT 
INTO "group" ("id", "name", "description", "grouptype", "jointype", "ctime", 
"mtime", "public", "usersautoadded", "category", "viewnotify", "quota", 
"institution", "shortname", "request", "submittableto", "editroles", "hidden", 
"hidemembers", "hidemembersfrommembers", "groupparticipationreports", 
"invitefriends", "suggestfriends", "urlid", "editwindowend", "sendnow", 
"feedbacknotify", "allowarchives") VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, 
?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?), Array)
Command was: INSERT INTO "group" ("id", "name", "description", "grouptype", 
"jointype", "ctime", "mtime", "public", "usersautoadded", "category", 
"viewnotify", "quota", "institution", "shortname", "request", "submittableto", 
"editroles", "hidden", "hidemembers", "hidemembersfrommembers", 
"groupparticipationreports", "invitefriends", "suggestfriends", "urlid", 
"editwindowend", "sendnow", "feedbacknotify", "allowarchives") VALUES (?, ?, ?, 
?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?) and 
values was 
(id:10,name:HumanComputerInteraction101v.2,description:Foundationcourseforbeginners,grouptype:course,jointype:approve,ctime:2016-09-2307:15:43,mtime:2016-09-2307:15:43,public:0,usersautoadded:0,category:1,viewnotify:1,quota:52428800,institution:mahara,shortname:humancomputerinteraction101a,request:1,submittableto:1,editroles:notmember,hidden:0,hidemembers:0,hidemembersfrommembers:0,groupparticipationreports:0,invitefriends:1,suggestfriends:0,urlid:human-c
 
omputer-interaction-101-v-2,editwindowend:2016-11-0700:00:00,sendnow:0,feedbacknotify:1,allowarchives:0)
Call stack (most recent first):

log_message("Failed to get a recordset: postgres8 error: [-1: E...", 8, 
true, true) at /home/kristina/code/1610stable/htdocs/lib/errors.php:95
log_warn("Failed to get a recordset: postgres8 error: [-1: E...") at 
/home/kristina/code/1610stable/htdocs/lib/errors.php:819
SQLException->__construct("Failed to get a recordset: postgres8 error: [-1: 
E...") at /home/kristina/code/1610stable/htdocs/lib/dml.php:1088
insert_record("group", object(stdClass), "id", true) at 
/home/kristina/code/1610stable/htdocs/lib/group.php:451
group_create(array(size 31)) at 
/home/kristina/code/1610stable/htdocs/lib/group.php:2808
group_copy(2, "adminlist") at 
/home/kristina/code/1610stable/htdocs/group/copy.php:37

[WAR] d3 (lib/dml.php:1088) Failed to get a recordset: postgres8 error: [-1: 
ERROR:  value too long for type character varying(30)] in adodb_throw(INSERT 
INTO "group" ("id", "name", "description", "grouptype", "jointype", "ctime", 
"mtime", "public", "usersautoadded", "category", "viewnotify", "quota", 

Re: [Mahara-contributors] [Bug 1620690] Re: Notifications of changes on locked pages

2016-09-22 Thread Pete Potter
Thanks Kristina,

I agree this is low as it does not happen frequently. The confusion arose
when the user received a notification from a page which should have been
locked.

Pete

On Wed, Sep 21, 2016 at 12:59 AM, Kristina Hoeppner <
1620...@bugs.launchpad.net> wrote:

> I would say that a notification can be useful because a file being moved
> into a folder on a page should result in a notification so that the
> watcher knows that there is new evidence available in a folder / image
> gallery on a page they are watching.
>
> A file that is submitted can only be moved if the folder in which it
> resides has not been submitted to a portfolio. In order to not have a
> notification, I guess, we'd have to check the conditions of the file and
> its submission status and then check if the submitted page is on
> anyone's watchlist and if all that matches, not send a notification of
> the move to the watchers of that page, but still send notifications to
> all the other watchers who have the same file on a different page in
> case that affects that page as well.
>
> Does this scenario happen frequently? I'd class it as low here in
> Launchpad, i.e. to fix when it's convenient, since it doesn't impact the
> behavior of Mahara or breaks the submission.
>
> ** Changed in: mahara
>Status: Incomplete => Triaged
>
> ** Changed in: mahara
>Importance: Undecided => Low
>
> ** Summary changed:
>
> - Notifications of changes on locked pages
> + Notification sent to watcher upon moving file on submitted page (when
> not in submitted folder)
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1620690
>
> Title:
>   Notification sent to watcher upon moving file on submitted page (when
>   not in submitted folder)
>
> Status in Mahara:
>   Triaged
>
> Bug description:
>   If I submit a page to a group it becomes locked. The locked page can
>   also be on another users watchlist. I've had an instance when users
>   who have the locked page on their watchlist receive notifications of
>   changes. This happens if artefacts are moved around into folders in
>   the content area.
>
>
>   16.04
>   Linux
>   MySQL
>
>
>   Thanks
>
>   Pete
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/mahara/+bug/1620690/+subscriptions
>

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1620690

Title:
  Notification sent to watcher upon moving file on submitted page (when
  not in submitted folder)

Status in Mahara:
  Triaged

Bug description:
  If I submit a page to a group it becomes locked. The locked page can
  also be on another users watchlist. I've had an instance when users
  who have the locked page on their watchlist receive notifications of
  changes. This happens if artefacts are moved around into folders in
  the content area.

  
  16.04
  Linux
  MySQL

  
  Thanks

  Pete

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1620690/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1626462] [NEW] image blocks disappearing from mahara page

2016-09-22 Thread Andrew
Public bug reported:

Hi,

I'd like to report a bug with images image blocks disappearing from
Mahara pages - this problem has occurred more than once and is becoming
increasingly concerning. The problem arises when a user (in this case, a
learner) uploads links images to image blocks on one of their personal
pages. The images appear as expected however at some point they then
seem to disappear and there is no longer any images displaying. This
seems to be purely affecting images content blocks (in this case image
blocks) as the comments section remains present. It appears that no
files are actually deleted, just the blocks from the page are missing.
It may be a problem with other types of blocks, but in this case, only
image blocks were present on the page. I thought it also best to mention
that I noticed this issue when logging in as the user (masquerading) to
check something on their behalf, however I think this may be pure
coincidental.

The Mahara version here is 16.04.3 (2016033117) running on Linux. I have
been able to identify this problem using Google Chrome (version
53.0.2785.116 m). I should also report that we have been made aware of
the same issue from another client who is also running the exact same
version (16.04.3) and this would further suggest that this is a bug
needing addressed.

Thanks
Andy

** Affects: mahara
 Importance: Undecided
 Status: New

** Summary changed:

- images disappearing from mahara page
+ image blocks disappearing from mahara page

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1626462

Title:
  image blocks disappearing from mahara page

Status in Mahara:
  New

Bug description:
  Hi,

  I'd like to report a bug with images image blocks disappearing from
  Mahara pages - this problem has occurred more than once and is
  becoming increasingly concerning. The problem arises when a user (in
  this case, a learner) uploads links images to image blocks on one of
  their personal pages. The images appear as expected however at some
  point they then seem to disappear and there is no longer any images
  displaying. This seems to be purely affecting images content blocks
  (in this case image blocks) as the comments section remains present.
  It appears that no files are actually deleted, just the blocks from
  the page are missing. It may be a problem with other types of blocks,
  but in this case, only image blocks were present on the page. I
  thought it also best to mention that I noticed this issue when logging
  in as the user (masquerading) to check something on their behalf,
  however I think this may be pure coincidental.

  The Mahara version here is 16.04.3 (2016033117) running on Linux. I
  have been able to identify this problem using Google Chrome (version
  53.0.2785.116 m). I should also report that we have been made aware of
  the same issue from another client who is also running the exact same
  version (16.04.3) and this would further suggest that this is a bug
  needing addressed.

  Thanks
  Andy

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1626462/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1626287] A change has been merged

2016-09-22 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/6998
Committed: 
https://git.mahara.org/mahara/mahara/commit/c9c151cb93998478872ff0abdae8370ecff2b2aa
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:16.04_STABLE

commit c9c151cb93998478872ff0abdae8370ecff2b2aa
Author: Robert Lyon 
Date:   Thu Sep 22 09:52:38 2016 +1200

Bug 1626287: activitytypemutlirecip: fix function exists

behatnotneeded

Change-Id: I4fa9481ae0de06ef0255b6d523474fbd17c643b3
Signed-off-by: Robert Lyon 

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1626287

Title:
  default_notification_method function is missing in Multirecipient
  message system

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Committed

Bug description:
  The 'default_notification_method' function doesn't exist - so it is
  not callable by call_static_method() in
  ActivityTypeMultirecipientmessage.php

  
  There was a fix for this https://reviews.mahara.org/#/c/6520/2 as part of a 
bigger patch but this part needs to be backported to fix earlier branches

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1626287/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1626287] Re: default_notification_method function is missing in Multirecipient message system

2016-09-22 Thread Robert Lyon
** Changed in: mahara/16.04
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1626287

Title:
  default_notification_method function is missing in Multirecipient
  message system

Status in Mahara:
  Fix Committed
Status in Mahara 15.04 series:
  Fix Committed
Status in Mahara 15.10 series:
  Fix Committed
Status in Mahara 16.04 series:
  Fix Committed

Bug description:
  The 'default_notification_method' function doesn't exist - so it is
  not callable by call_static_method() in
  ActivityTypeMultirecipientmessage.php

  
  There was a fix for this https://reviews.mahara.org/#/c/6520/2 as part of a 
bigger patch but this part needs to be backported to fix earlier branches

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1626287/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp