[Mahara-contributors] [Bug 1749339] Re: Add pre_loginpage_hooks

2018-02-13 Thread Daniel Thee Roperto
I am adding a patch,

Please let me know if you prefer a pull request.

** Patch added: 
"0001-Add-a-pre-login-hook-to-check-if-user-is-already-log.patch"
   
https://bugs.launchpad.net/mahara/+bug/1749339/+attachment/5054743/+files/0001-Add-a-pre-login-hook-to-check-if-user-is-already-log.patch

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1749339

Title:
  Add pre_loginpage_hooks

Status in Mahara:
  New

Bug description:
  Give a chance for auth plugins to authenticate the user or perform
  other tasks before showing the login page.

  This is similar to https://tracker.moodle.org/browse/MDL-48887

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1749339/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1749339] [NEW] Add pre_loginpage_hooks

2018-02-13 Thread Daniel Thee Roperto
Public bug reported:

Give a chance for auth plugins to authenticate the user or perform other
tasks before showing the login page.

This is similar to https://tracker.moodle.org/browse/MDL-48887

** Affects: mahara
 Importance: Undecided
 Status: New

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1749339

Title:
  Add pre_loginpage_hooks

Status in Mahara:
  New

Bug description:
  Give a chance for auth plugins to authenticate the user or perform
  other tasks before showing the login page.

  This is similar to https://tracker.moodle.org/browse/MDL-48887

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1749339/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1698257] Re: Ensure that the header displays correctly with or without site message

2018-02-13 Thread Sarah Kirby
Some insight about the patch ..

I have investigated two different solutions:

The first was to use a Javascript function. This function would find the
height of the navigation element and use this value to add additional
padding-top to the body element. This approach is similar to what the
current code does, however the value is able to change depending on the
variable header height.

The issue with this approach is that the Javacript loads too slowly and
the content and styles load before the JS. Unfortunately this delay
causes the content to 'jump' when the padding-top is applied through JS.

The second approach and the solution I've submitted, relies on a
'spacer' div. Adding additional html markup is not ideal, however after
researching this issue it's the best solution I could come up with.

The spacer div is a clone of the header element and it's purpose is to
push content down. It uses the same classnames as the header and nav
elements to ensure it inherits the new height and necessary positions
when site messages are added.

All child elements of the nav inherit it's height, therefore you only
need to change the .navbar-main's height property. This is also enforced
as a max-height has been set on the .navbar-main element. The image
height is set with a percentage value, and allows the image's size to
increase relative to the navbar's height.

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1698257

Title:
  Ensure that the header displays correctly with or without site message

Status in Mahara:
  In Progress

Bug description:
  When the custom theme has taller logo it causes the header to be
  larger, sometimes this makes the secondary menu appear to be hidden or
  cutoff when there is no site message.

  Ensure that Raw and Old raw theme header display correctly with or
  without site message(s)

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1698257/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1539322] Re: Do we still need device detection?

2018-02-13 Thread Kristina Hoeppner
Currently, when device detection is turned off, swiping will be
disabled. See bug #1749308 A better solution would be the one described
there so that we can still remove device detection.

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1539322

Title:
  Do we still need device detection?

Status in Mahara:
  Triaged

Bug description:
  Mahara 15.10 introduced Bootstrap. All themes are now responsive. When
  I tested the "Deactivate device detection" functionality, I couldn't
  see much of a difference when using the site. I did notice the content
  chooser was displayed the start of the words instead of only showing
  the icon on the "Edit page" screen.

  I wonder if we can remove the custom device detection. You can enable
  the user turning off device detection in Admin -> Config site -> User
  settings -> Users can disable device detection. That then happens on
  the account settings page.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1539322/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1749308] Re: Collection navigation triggering swiperight event on mouse click

2018-02-13 Thread Kristina Hoeppner
** Changed in: mahara
   Status: New => Confirmed

** Changed in: mahara
   Importance: Undecided => Medium

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1749308

Title:
  Collection navigation triggering swiperight event on mouse click

Status in Mahara:
  Confirmed

Bug description:
  Mahara: 17.10.3
  OS: Linux 16.04
  DB: Postgres (not relevant)
  Browser: Firefox and Chrome

  
  In a collection on a view with the 'Previous page' displayed, the swiperight 
event is getting triggered on a mouse click. 

  When a user tries to select some text (i.e. click mouse, hold it down,
  and select text), this action is interpreted as a swipe action. And,
  the swiperight event is triggered.

  I've come across this stackoverflow discussion:

  https://stackoverflow.com/questions/36317660/jquery-mobile-swipe-
  gesture-for-touch-screen-only-and-not-for-mouse

  Bascially, the swiperight and swipeleft events should be disabled on
  the mousedown event and enabled on the touchstart event.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1749308/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1748782] Re: "Inactive user" highlight disappeared

2018-02-13 Thread Liam
** Changed in: mahara/18.04
   Status: Confirmed => In Progress

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1748782

Title:
  "Inactive user" highlight disappeared

Status in Mahara:
  In Progress
Status in Mahara 17.04 series:
  Confirmed
Status in Mahara 17.10 series:
  Confirmed
Status in Mahara 18.04 series:
  In Progress

Bug description:
  In Mahara 16.10 we added the functionality to show inactive users in
  Admin -> Users -> User search. See the user manual at
  http://manual.mahara.org/en/16.10/administration/users.html#index-4
  (#16 in the screenshot).

  This disappeared in Mahara 17.04. It needs to be put back in.

  The functionality was added in https://reviews.mahara.org/#/c/6631

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1748782/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1703751] A change has been merged

2018-02-13 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/8486
Committed: 
https://git.mahara.org/mahara/mahara/commit/afaf0bd872f98d5fd2153df57e31e4207f55f2e9
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:master

commit afaf0bd872f98d5fd2153df57e31e4207f55f2e9
Author: Niranjan Bandi 
Date:   Wed Jan 31 16:01:16 2018 +1300

Bug 1703751- Check notification options

- combined notification_choices.feature into this test
- Changed feature text
- Removed And I should see steps from notification_setting_order.feature
- Deleted notification_setting_order.feature
- Added steps after saving the settings
- Renamed the file to notification_settings.feature

Change-Id: Id20a2c3407e44b35c16932d570ba7f597365f6b4

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1703751

Title:
  behat change_account_settings.feature doesn't test functionality

Status in Mahara:
  Fix Committed

Bug description:
  This test is currently not testing actual functionality. It should be
  changed to check notification options are available and to check one
  or two actually work.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1703751/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1703751] Re: behat change_account_settings.feature doesn't test functionality

2018-02-13 Thread Robert Lyon
** Changed in: mahara
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1703751

Title:
  behat change_account_settings.feature doesn't test functionality

Status in Mahara:
  Fix Committed

Bug description:
  This test is currently not testing actual functionality. It should be
  changed to check notification options are available and to check one
  or two actually work.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1703751/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1749269] A change has been merged

2018-02-13 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/8522
Committed: 
https://git.mahara.org/mahara/mahara/commit/be2c6e063974a2169f1dd29d180d8cd321aa0d75
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:16.10_STABLE

commit be2c6e063974a2169f1dd29d180d8cd321aa0d75
Author: Robert Lyon 
Date:   Wed Feb 14 08:15:05 2018 +1300

Bug 1749269: Fixing for update user via webservices for 16.10

behatnotneeded

Change-Id: Ieced2e34e4079781c300c4e5f50c5c13bfb12cf8
Signed-off-by: Robert Lyon 

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1749269

Title:
  Fixing for update user via webservices for 16.10

Status in Mahara:
  Fix Committed

Bug description:
  Originally we had a fix for this in Bug 1630764 - but the version that
  was merged for 17.04.0+ was different to the one merged in 16.10.

  The 17.04 version updated the profile info for 'firstname',
  'lastname', 'email', 'studentid', 'preferredname'

  Whereas the 16.10 version only updated the profile info for
  'studentid', 'preferredname'

  This bug is to fix up the 16.10 branch so it saves the profile info
  like 17.04+

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1749269/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1749269] Re: Fixing for update user via webservices for 16.10

2018-02-13 Thread Robert Lyon
** Changed in: mahara
   Status: In Progress => Fix Committed

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1749269

Title:
  Fixing for update user via webservices for 16.10

Status in Mahara:
  Fix Committed

Bug description:
  Originally we had a fix for this in Bug 1630764 - but the version that
  was merged for 17.04.0+ was different to the one merged in 16.10.

  The 17.04 version updated the profile info for 'firstname',
  'lastname', 'email', 'studentid', 'preferredname'

  Whereas the 16.10 version only updated the profile info for
  'studentid', 'preferredname'

  This bug is to fix up the 16.10 branch so it saves the profile info
  like 17.04+

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1749269/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1692756] Re: Note that menu has been expanded

2018-02-13 Thread Rebecca Blundell
** Changed in: mahara
   Status: In Progress => Confirmed

** Changed in: mahara
 Assignee: Rebecca Blundell (rjb-dev) => (unassigned)

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1692756

Title:
  Note that menu has been expanded

Status in Mahara:
  Confirmed

Bug description:
  Mahara 17.04+

  The "collapsed" state of the Show Main Menu / User Menu / Admin Menu
  button should become "Expanded" as the main menu has been expanded.

  When a screen reader focuses on the "Show main menu" button for the
  first time, the screen reader speaks "Show main menu, collapsed" as it
  is collapsed. But when the user presses Enter and the menu expands,
  the screen reader still says "Show main menu, collapsed", instead of
  saying "Show main menu, expanded".

  It is important to note that on the menu items e.g. Show menu for
  content, show menu for portfolio, show menu for groups, the screen
  reader is correctly able to speak the collapsed or expanded state of
  the menu items. The issue is present only in the main menu,
  administration menu, and user menu buttons.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1692756/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1749308] [NEW] Collection navigation triggering swiperight event on mouse click

2018-02-13 Thread Ghada El-Zoghbi
Public bug reported:

Mahara: 17.10.3
OS: Linux 16.04
DB: Postgres (not relevant)
Browser: Firefox and Chrome


In a collection on a view with the 'Previous page' displayed, the swiperight 
event is getting triggered on a mouse click. 

When a user tries to select some text (i.e. click mouse, hold it down,
and select text), this action is interpreted as a swipe action. And, the
swiperight event is triggered.

I've come across this stackoverflow discussion:

https://stackoverflow.com/questions/36317660/jquery-mobile-swipe-
gesture-for-touch-screen-only-and-not-for-mouse

Bascially, the swiperight and swipeleft events should be disabled on the
mousedown event and enabled on the touchstart event.

** Affects: mahara
 Importance: Undecided
 Status: New

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1749308

Title:
  Collection navigation triggering swiperight event on mouse click

Status in Mahara:
  New

Bug description:
  Mahara: 17.10.3
  OS: Linux 16.04
  DB: Postgres (not relevant)
  Browser: Firefox and Chrome

  
  In a collection on a view with the 'Previous page' displayed, the swiperight 
event is getting triggered on a mouse click. 

  When a user tries to select some text (i.e. click mouse, hold it down,
  and select text), this action is interpreted as a swipe action. And,
  the swiperight event is triggered.

  I've come across this stackoverflow discussion:

  https://stackoverflow.com/questions/36317660/jquery-mobile-swipe-
  gesture-for-touch-screen-only-and-not-for-mouse

  Bascially, the swiperight and swipeleft events should be disabled on
  the mousedown event and enabled on the touchstart event.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1749308/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1749305] [NEW] Behat step "And I wait x seconds" should allow second as well

2018-02-13 Thread Rebecca Blundell
Public bug reported:

I want to make it so that "And I wait "1" second" is a valid step as well as 
"And I wait "1" seconds"
Also to refactor any tests that currently use "And I wait "1" seconds"

I am tempted to also get the step to error if someone tries to submit
"And I wait "10" second" or "And I wait "1" seconds" because I am the
grammar police. Maybe I'm too mean.

** Affects: mahara
 Importance: Undecided
 Status: New


** Tags: behat

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1749305

Title:
  Behat step "And I wait x seconds" should allow second as well

Status in Mahara:
  New

Bug description:
  I want to make it so that "And I wait "1" second" is a valid step as well as 
"And I wait "1" seconds"
  Also to refactor any tests that currently use "And I wait "1" seconds"

  I am tempted to also get the step to error if someone tries to submit
  "And I wait "10" second" or "And I wait "1" seconds" because I am the
  grammar police. Maybe I'm too mean.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1749305/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1749269] A patch has been submitted for review

2018-02-13 Thread Mahara Bot
Patch for "16.10_STABLE" branch: https://reviews.mahara.org/8522

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1749269

Title:
  Fixing for update user via webservices for 16.10

Status in Mahara:
  In Progress

Bug description:
  Originally we had a fix for this in Bug 1630764 - but the version that
  was merged for 17.04.0+ was different to the one merged in 16.10.

  The 17.04 version updated the profile info for 'firstname',
  'lastname', 'email', 'studentid', 'preferredname'

  Whereas the 16.10 version only updated the profile info for
  'studentid', 'preferredname'

  This bug is to fix up the 16.10 branch so it saves the profile info
  like 17.04+

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1749269/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1692757] Re: Collapse main menu by pressing Esc key

2018-02-13 Thread Jaque
** Changed in: mahara
   Status: Confirmed => In Progress

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1692757

Title:
  Collapse main menu by pressing Esc key

Status in Mahara:
  In Progress

Bug description:
  Mahara 17.04+

  User should be able to collapse the main navigation menus (user menu,
  admin menu, main menu) by pressing the Escape key.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1692757/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1749269] A patch has been submitted for review

2018-02-13 Thread Mahara Bot
Patch for "17.10_STABLE" branch: https://reviews.mahara.org/8521

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1749269

Title:
  Fixing for update user via webservices for 16.10

Status in Mahara:
  In Progress

Bug description:
  Originally we had a fix for this in Bug 1630764 - but the version that
  was merged for 17.04.0+ was different to the one merged in 16.10.

  The 17.04 version updated the profile info for 'firstname',
  'lastname', 'email', 'studentid', 'preferredname'

  Whereas the 16.10 version only updated the profile info for
  'studentid', 'preferredname'

  This bug is to fix up the 16.10 branch so it saves the profile info
  like 17.04+

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1749269/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1749269] [NEW] Fixing for update user via webservices for 16.10

2018-02-13 Thread Robert Lyon
Public bug reported:

Originally we had a fix for this in Bug 1630764 - but the version that
was merged for 17.04.0+ was different to the one merged in 16.10.

The 17.04 version updated the profile info for 'firstname', 'lastname',
'email', 'studentid', 'preferredname'

Whereas the 16.10 version only updated the profile info for 'studentid',
'preferredname'

This bug is to fix up the 16.10 branch so it saves the profile info like
17.04+

** Affects: mahara
 Importance: High
 Assignee: Robert Lyon (robertl-9)
 Status: In Progress

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1749269

Title:
  Fixing for update user via webservices for 16.10

Status in Mahara:
  In Progress

Bug description:
  Originally we had a fix for this in Bug 1630764 - but the version that
  was merged for 17.04.0+ was different to the one merged in 16.10.

  The 17.04 version updated the profile info for 'firstname',
  'lastname', 'email', 'studentid', 'preferredname'

  Whereas the 16.10 version only updated the profile info for
  'studentid', 'preferredname'

  This bug is to fix up the 16.10 branch so it saves the profile info
  like 17.04+

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1749269/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1746259] A change has been merged

2018-02-13 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/8484
Committed: 
https://git.mahara.org/mahara/mahara/commit/6392aa5608066677272b0bed3895c68341b2c0fa
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:master

commit 6392aa5608066677272b0bed3895c68341b2c0fa
Author: Maria Sorica 
Date:   Tue Jan 30 15:25:28 2018 +

Bug 1746259: Move the T&C to the site_content_version table

1. On site update, delete all T&C from the 'site_content'
table and add it to the 'site_content_version' table.

2. Auto accept the site terms and conditions for
the site admins.

behatnotneeded

Change-Id: I07e7da0bd8bbdb3a1e36c3321e0a2b5bb3e89522

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1746259

Title:
  Make the T&C have the same behaviour as the privacy statement

Status in Mahara:
  In Progress

Bug description:
  We need to make a series of changes in Mahara to comply with the GDPR.
  More info is available on the wiki at
  
https://wiki.mahara.org/wiki/Developer_Area/Specifications_in_Development/GDPR_compliance.

  We will need to make the following changes:

  1. Add the T&C to the site_content_version table.

  2. Display the T&C under the 'Legal' navigation link.

  3. Allow the site/institution admins to create new T&C versions.

  4. Ask user to agree to the site and institution T&C.

  5. Show the user the current T&C version they have consented to.

  6. Allow the user to withdraw their consent to the current T&C
  version.

  7. Add T&C to the registration form

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1746259/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1746259] A change has been merged

2018-02-13 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/8487
Committed: 
https://git.mahara.org/mahara/mahara/commit/03a3b227b1dd4fcb2d882b020445b8e9c7183cc5
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:master

commit 03a3b227b1dd4fcb2d882b020445b8e9c7183cc5
Author: Maria Sorica 
Date:   Wed Jan 31 17:04:40 2018 +

Bug 1746259: Display the T&C on 'Configure site'->'Legal' page

behatnotneeded

Change-Id: I70237140502aad0296a793343b37a8aab2d3691e

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1746259

Title:
  Make the T&C have the same behaviour as the privacy statement

Status in Mahara:
  In Progress

Bug description:
  We need to make a series of changes in Mahara to comply with the GDPR.
  More info is available on the wiki at
  
https://wiki.mahara.org/wiki/Developer_Area/Specifications_in_Development/GDPR_compliance.

  We will need to make the following changes:

  1. Add the T&C to the site_content_version table.

  2. Display the T&C under the 'Legal' navigation link.

  3. Allow the site/institution admins to create new T&C versions.

  4. Ask user to agree to the site and institution T&C.

  5. Show the user the current T&C version they have consented to.

  6. Allow the user to withdraw their consent to the current T&C
  version.

  7. Add T&C to the registration form

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1746259/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1746259] A change has been merged

2018-02-13 Thread Mahara Bot
Reviewed:  https://reviews.mahara.org/8483
Committed: 
https://git.mahara.org/mahara/mahara/commit/f1c0934d1083e0624b262656fdf74b729be9ce91
Submitter: Robert Lyon (robe...@catalyst.net.nz)
Branch:master

commit f1c0934d1083e0624b262656fdf74b729be9ce91
Author: Maria Sorica 
Date:   Tue Jan 30 14:34:12 2018 +

Bug 1746259: Add the T&C to the site_content_version table

1. Add the site T&C to the 'site_content_version' table during
installation

2. Display just the privacy statement on the privacy pages for now.
The logic to display the T&C will be added in a future patch.

behatnotneeded

Change-Id: I70c1477c974b5790762a371d37107819d3c685b6

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1746259

Title:
  Make the T&C have the same behaviour as the privacy statement

Status in Mahara:
  In Progress

Bug description:
  We need to make a series of changes in Mahara to comply with the GDPR.
  More info is available on the wiki at
  
https://wiki.mahara.org/wiki/Developer_Area/Specifications_in_Development/GDPR_compliance.

  We will need to make the following changes:

  1. Add the T&C to the site_content_version table.

  2. Display the T&C under the 'Legal' navigation link.

  3. Allow the site/institution admins to create new T&C versions.

  4. Ask user to agree to the site and institution T&C.

  5. Show the user the current T&C version they have consented to.

  6. Allow the user to withdraw their consent to the current T&C
  version.

  7. Add T&C to the registration form

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1746259/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1749185] Re: Artefact linked in text blocktype breaks on the copied page

2018-02-13 Thread Maria Sorica
** Description changed:

  User story:
  
  1. User A is adding a file to a page as a link in a text blocktype.
- 
- 2. User B copies the page, but the artefact (file) is not actually
- copied, only the blocktype (text content).
- 
- 3. When user B views the copied page, the viewid in the link is changed
- from the original page ID to the ID of the copied page. But user B
- doesn't own that file itself so he gets an "Access denied" error.
- 
+ 2. User B copies the page, but the artefact (file) is not actually copied, 
only the blocktype (text content).
+ 3. When user B views the copied page, the viewid in the link is changed from 
the original page ID to the ID of the copied page. But user B doesn't own that 
file itself so he gets an "Access denied" error.
  
  Possible solutions:
  
  1. Copy the artefact.
- 
  2. Keep the original viewid in the link.
- 
  
  Related links: https://wrms.catalyst.net.nz/wr.php?request_id=285955
  The bug was found on Mahara 16.10.2

** Description changed:

  User story:
  
  1. User A is adding a file to a page as a link in a text blocktype.
  2. User B copies the page, but the artefact (file) is not actually copied, 
only the blocktype (text content).
- 3. When user B views the copied page, the viewid in the link is changed from 
the original page ID to the ID of the copied page. But user B doesn't own that 
file itself so he gets an "Access denied" error.
+ 3. When user B views the copied page, the viewid in the link is changed from 
the original page ID to the ID of the copied page. But user B doesn't own that 
file itself so user B gets an "Access denied" error.
  
  Possible solutions:
  
  1. Copy the artefact.
  2. Keep the original viewid in the link.
  
  Related links: https://wrms.catalyst.net.nz/wr.php?request_id=285955
  The bug was found on Mahara 16.10.2

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1749185

Title:
  Artefact linked in text blocktype breaks on the copied page

Status in Mahara:
  New

Bug description:
  User story:

  1. User A is adding a file to a page as a link in a text blocktype.
  2. User B copies the page, but the artefact (file) is not actually copied, 
only the blocktype (text content).
  3. When user B views the copied page, the viewid in the link is changed from 
the original page ID to the ID of the copied page. But user B doesn't own that 
file itself so user B gets an "Access denied" error.

  Possible solutions:

  1. Copy the artefact.
  2. Keep the original viewid in the link.

  Related links: https://wrms.catalyst.net.nz/wr.php?request_id=285955
  The bug was found on Mahara 16.10.2

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1749185/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1749185] [NEW] Artefact linked in text blocktype breaks on the copied page

2018-02-13 Thread Maria Sorica
Public bug reported:

User story:

1. User A is adding a file to a page as a link in a text blocktype.

2. User B copies the page, but the artefact (file) is not actually
copied, only the blocktype (text content).

3. When user B views the copied page, the viewid in the link is changed
from the original page ID to the ID of the copied page. But user B
doesn't own that file itself so he gets an "Access denied" error.


Possible solutions:

1. Copy the artefact.

2. Keep the original viewid in the link.


Related links: https://wrms.catalyst.net.nz/wr.php?request_id=285955
The bug was found on Mahara 16.10.2

** Affects: mahara
 Importance: Undecided
 Status: New

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1749185

Title:
  Artefact linked in text blocktype breaks on the copied page

Status in Mahara:
  New

Bug description:
  User story:

  1. User A is adding a file to a page as a link in a text blocktype.

  2. User B copies the page, but the artefact (file) is not actually
  copied, only the blocktype (text content).

  3. When user B views the copied page, the viewid in the link is
  changed from the original page ID to the ID of the copied page. But
  user B doesn't own that file itself so he gets an "Access denied"
  error.

  
  Possible solutions:

  1. Copy the artefact.

  2. Keep the original viewid in the link.

  
  Related links: https://wrms.catalyst.net.nz/wr.php?request_id=285955
  The bug was found on Mahara 16.10.2

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1749185/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1749132] [NEW] update fail (vers la 17)

2018-02-13 Thread stitou
Public bug reported:

Yesterday i have the bug 1748947, so you said to make update, i go in 
softaculous and it made it (prposing to update to version 17).
But it fail now i have this error : 

WAR] f7 Undefined property: stdClass::$log_backtrace_print_args
Call stack (most recent first):
log_message(string(size 55), integer, true, true, string(size 51), integer) at 
/home/sio57/mahara.sio57.info/mahara/lib/errors.php:521
error(integer, string(size 55), string(size 51), integer, array(size 5)) at 
/home/sio57/mahara.sio57.info/mahara/lib/errors.php:314
log_build_backtrace(array(size 1)) at 
/home/sio57/mahara.sio57.info/mahara/lib/errors.php:160
log_message(string(size 42), integer, true, true, string(size 51), integer, 
array(size 1)) at /home/sio57/mahara.sio57.info/mahara/lib/errors.php:648
MaharaException->handle_exception() at 
/home/sio57/mahara.sio57.info/mahara/lib/errors.php:547
exception(object(SystemException)) at Unknown:0
[WAR] f7 [ParseError]: syntax error, unexpected '/'
Call stack (most recent first):
exception(object(ParseError)) at Unknown:0

What can i do ?
Thanks for help

** Affects: mahara
 Importance: Undecided
 Status: New

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1749132

Title:
  update fail (vers la 17)

Status in Mahara:
  New

Bug description:
  Yesterday i have the bug 1748947, so you said to make update, i go in 
softaculous and it made it (prposing to update to version 17).
  But it fail now i have this error : 

  WAR] f7 Undefined property: stdClass::$log_backtrace_print_args
  Call stack (most recent first):
  log_message(string(size 55), integer, true, true, string(size 51), integer) 
at /home/sio57/mahara.sio57.info/mahara/lib/errors.php:521
  error(integer, string(size 55), string(size 51), integer, array(size 5)) at 
/home/sio57/mahara.sio57.info/mahara/lib/errors.php:314
  log_build_backtrace(array(size 1)) at 
/home/sio57/mahara.sio57.info/mahara/lib/errors.php:160
  log_message(string(size 42), integer, true, true, string(size 51), integer, 
array(size 1)) at /home/sio57/mahara.sio57.info/mahara/lib/errors.php:648
  MaharaException->handle_exception() at 
/home/sio57/mahara.sio57.info/mahara/lib/errors.php:547
  exception(object(SystemException)) at Unknown:0
  [WAR] f7 [ParseError]: syntax error, unexpected '/'
  Call stack (most recent first):
  exception(object(ParseError)) at Unknown:0

  What can i do ?
  Thanks for help

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1749132/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp