[Mahara-contributors] [Bug 1898643] Re: remove references to class used in old layout

2020-10-21 Thread Lisa Seeto
** Changed in: mahara/19.10
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1898643

Title:
  remove references to class used in old layout

Status in Mahara:
  Fix Released
Status in Mahara 19.10 series:
  Fix Released
Status in Mahara 20.04 series:
  Fix Released
Status in Mahara 20.10 series:
  Fix Released

Bug description:
  Before gridstack layout, every time a block was moved in a page's edit
  mode, the background changed color to reflect that the block was being
  moved. This can be tested in 19.04 or older versions of Mahara.

  We don't do this anymore, so any reference to the css class "block-
  drop-on" needs to be removed from the code. Removing this class should
  not affect the styling of a block when it's being moved.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1898643/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1891237] Re: Language string broken in institution stats overview page

2020-10-21 Thread Lisa Seeto
** Changed in: mahara/19.10
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1891237

Title:
  Language string broken in institution stats overview page

Status in Mahara:
  Fix Released
Status in Mahara 19.04 series:
  Fix Released
Status in Mahara 19.10 series:
  Fix Released
Status in Mahara 20.04 series:
  Fix Released
Status in Mahara 20.10 series:
  Fix Released

Bug description:
  There is an issue with [[profile/view]] broken string on a View type
  graph.

  Part of the problem is the graph's data is cached in the database and
  so the broken string is stored there.

  The fix for this both replaces the missing string and adds a bit to
  the data fetching so that any cached graph data that has a broken
  string recorded gets it to be translated as expected.

  To test:

  Have a site that contains institutions that has some members that have
  logged in and have made some pages (this will work best if the
  database has had some time to run crons for a week or so)

  1) Login as admin
  2) Go to the Admin -> Reports page
  3) Click configure report
  4) Choose an institution and keep 'report type' as 'overview'
  5) See 'Pages overview' graph with the broken language string

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1891237/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1885982] Re: behat headless doesn't work with chrome 80

2020-10-21 Thread Lisa Seeto
** Changed in: mahara/19.10
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1885982

Title:
  behat headless doesn't work with chrome 80

Status in Mahara:
  Fix Released
Status in Mahara 19.04 series:
  Fix Released
Status in Mahara 19.10 series:
  Fix Released
Status in Mahara 20.04 series:
  Fix Released
Status in Mahara 20.10 series:
  Fix Released

Bug description:
  patch for this here https://reviews.mahara.org/#/c/10785/5

  add -screen pixel depth and related xvfb params for bionic and chrome 80
fixes issue with chrome 80 and xvfb where default parameters (prob pixel 
depth)
makes chrome fail to connect to xvfb/selenium.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1885982/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1883803] Re: Missing Help Text Icon: admin/site/menu.php

2020-10-21 Thread Lisa Seeto
** Changed in: mahara/19.10
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1883803

Title:
  Missing Help Text Icon: admin/site/menu.php

Status in Mahara:
  Fix Released
Status in Mahara 19.04 series:
  Fix Released
Status in Mahara 19.10 series:
  Fix Released
Status in Mahara 20.04 series:
  Fix Released
Status in Mahara 20.10 series:
  Fix Released

Bug description:
  The Help icons are missing for "External link" and "Site file" on the
  "Menus" page (admin/site/menu.php) Admin menu -> Configure site ->
  Menus.

  To replicate:
  1. Log into Mahara as a site admin
  2. Navigate to the Menus page: Admin menu -> Configure Site -> Menus
  3. Set the Keyboard focus to the the radio button for "External link"
  4. Navigate the keyboard focus (tab once) and press enter
  5. Observe that the pop-up for the help text for "External link" will appear 
but does not have a help icon to distinguish it
  This happens with "Site file" as well.

  Another issue, is that when the cursor is hovered over the "External
  link" and "Site files" it changes to the cursor associated with
  mousing over links.

  Versions: Mahara 20.04, 19.10 19.04

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1883803/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1891939] Re: Instituion static page edit not disabled

2020-10-21 Thread Lisa Seeto
** Changed in: mahara/19.10
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1891939

Title:
  Instituion static page edit not disabled

Status in Mahara:
  Fix Released
Status in Mahara 19.10 series:
  Fix Released
Status in Mahara 20.04 series:
  Fix Released
Status in Mahara 20.10 series:
  Fix Released

Bug description:
  Should not allow to edit an institution static page while the 'Use
  site default' is set to yes

  To test
  - Have an institution
  - Go to Admin menu -> Institutions -> static pages
  - Set 'Use site default' to yes

  expected result: the tinyMCE editor is greyed out and you are not allowed to 
make changes
  actual result: the tinyMCE editor is enabled

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1891939/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1891949] Re: sign off block height on gridstack

2020-10-21 Thread Lisa Seeto
** Changed in: mahara/19.10
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1891949

Title:
  sign off block height on gridstack

Status in Mahara:
  Fix Released
Status in Mahara 19.10 series:
  Fix Released
Status in Mahara 20.04 series:
  Fix Released
Status in Mahara 20.10 series:
  Fix Released

Bug description:
  The sign off block content is very different when editing the page from when 
viewing the page. This makes the block have a lot of extra space when viewing 
the page. We can make the height be predefined for viewsing since it will 
always have the same content, it can only have
  Sign off / Verify lines
  or
  Sign off alone

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1891949/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1898762] Re: Regression memcached servers

2020-10-21 Thread Lisa Seeto
** Changed in: mahara/19.10
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1898762

Title:
  Regression memcached servers

Status in Mahara:
  Fix Released
Status in Mahara 19.10 series:
  Fix Released
Status in Mahara 20.04 series:
  Fix Released
Status in Mahara 20.10 series:
  Fix Released

Bug description:
  Analising mahara 20.04.1 I see and regression on here :
  
https://github.com/MaharaProject/mahara/blob/20.04_STABLE/htdocs/auth/lib.php#L681

  
  Instead of this

  if (empty($server_version[$host . ':' . $port])) {
  $is_configured = false;
  }

  It should be this : 
  if (!empty($server_version[$host . ':' . $port])) {
  $is_configured = true;
  }

  
  I tried to configured a memcached server and had an erreur as settings 
memcacheservers weren't set.

  In the code since $is_configured is already false, we have to invert
  the logic to see if a server is configured or not.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1898762/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1898478] Re: Retractable option not available any more in 'Edit' mode

2020-10-21 Thread Lisa Seeto
** Changed in: mahara/19.10
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1898478

Title:
  Retractable option not available any more in 'Edit' mode

Status in Mahara:
  Fix Released
Status in Mahara 19.10 series:
  Fix Released
Status in Mahara 20.04 series:
  Fix Released
Status in Mahara 20.10 series:
  Fix Released

Bug description:
  This is a regression.

  The retractable option in 'Edit' mode is not available any more, thus
  making it more difficult for people to deal with long blocks or see
  what the end result is in display mode.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1898478/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1883987] Re: Help Icon for authentication plugin not aligned properly

2020-10-21 Thread Lisa Seeto
** Changed in: mahara/19.10
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1883987

Title:
  Help Icon for authentication plugin not aligned properly

Status in Mahara:
  Fix Released
Status in Mahara 19.04 series:
  Fix Released
Status in Mahara 19.10 series:
  Fix Released
Status in Mahara 20.04 series:
  Fix Released
Status in Mahara 20.10 series:
  Fix Released

Bug description:
  The Help icon for Admin Menu -> Institution settings -> Authentication
  plugin is not aligned properly with the content but is sitting below
  where it should be.

  To test:
  1. Log into Mahara as a site admin
  2. Navigate to Admin Menu -> Institution settings, select institution, view 
area for Authentication plugin
  Expected results:
  All visual content is aligned and consistent
  Actual results:
  The help icon for Authentication plugin is sitting below the area and is 
intersected by a horizontal line.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1883987/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1893159] Re: Dashboard widgets are not receiving customisable theme styling

2020-10-21 Thread Lisa Seeto
** Changed in: mahara/19.10
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1893159

Title:
  Dashboard widgets are not receiving customisable theme styling

Status in Mahara:
  Fix Released
Status in Mahara 19.04 series:
  Fix Released
Status in Mahara 19.10 series:
  Fix Released
Status in Mahara 20.04 series:
  Fix Released
Status in Mahara 20.10 series:
  Fix Released

Bug description:
  Currently the Dashboard widgets for "Create", "Share" and "Engage" do
  not receive the styling carried over from an institution's
  customisable theme (see attached screen shot)

  To replicate:
  Have an institution and at least one member who has dashboard info showing 
(to see the widgets)
  1. Log in to site as administrator, in the Institution settings, select 
'Customisable theme' for Theme and select custom colours (default config theme 
colours are fine).
  2. Save the institution
  3. Log in as institution member and navigate to dashboard, hover over the 
dashboard widgets
  Expected results:
  The Dashboard widgets display in customised colours matching the header
  Actual results:
  The Dashboard widgets display in the Raw theme colours.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1893159/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1888743] Re: clean up references to old menu structure

2020-10-21 Thread Lisa Seeto
** Changed in: mahara/19.10
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1888743

Title:
  clean up references to old menu structure

Status in Mahara:
  Fix Released
Status in Mahara 19.04 series:
  Fix Released
Status in Mahara 19.10 series:
  Fix Released
Status in Mahara 20.04 series:
  Fix Released
Status in Mahara 20.10 series:
  Fix Released

Bug description:
  Currently we still have some references to the old menu structure within 
Mahara.
  'myportfolio' and 'content' should both be updated to 'create'.

  Change: define(MENUITEM', 'myportfolio');
  To: define('MENUITEM', 'create');

  In the following files:
  relatedtags.php
  artefact/annotation/edit.php
  artefact/comment/edit.php
  artefact/peerassessment/edit.php

  In artefact/internal/socialprofile.php:
  Change: define('MENUITEM', 'content/profile');
  To: define('MENUITEM', 'create/files');

  In htdocs/lib/web.php:
  Change (ln 1476 in a comment): in_array(MENUITEM, array('myportfolio/view'))),
  To: in_array(MENUITEM, array('create/view'))),

  The old code was discovered when upgrading a site from 18.10 to 20.04.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1888743/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1887450] Re: Block header buttons need better labels when Editing Pages

2020-10-21 Thread Lisa Seeto
** Changed in: mahara/19.10
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1887450

Title:
  Block header buttons need better labels when Editing Pages

Status in Mahara:
  Fix Released
Status in Mahara 19.04 series:
  Fix Released
Status in Mahara 19.10 series:
  Fix Released
Status in Mahara 20.04 series:
  Fix Released
Status in Mahara 20.10 series:
  Fix Released

Bug description:
  It was found that the labels for the buttons that appear when editing
  a block on a page are not accurately described by a screen reader.
  The buttons are "Configure block" and "Remove block".  The "Remove
  block" button was entirely missing its label for screen readers, while
  the "Configure block" reads "Move block" instead of configure block.

  It looks like the 'sr-only' class needs to be applied correctly to the
  configure block button so that it misses the move button text and
  addresses its own purposes and for it to be applied to the remove
  block button in blocktypecontainerediting.tpl

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1887450/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1891939] Re: Instituion static page edit not disabled

2020-10-21 Thread Robert Lyon
** Changed in: mahara/20.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1891939

Title:
  Instituion static page edit not disabled

Status in Mahara:
  Fix Released
Status in Mahara 19.10 series:
  Fix Released
Status in Mahara 20.04 series:
  Fix Released
Status in Mahara 20.10 series:
  Fix Released

Bug description:
  Should not allow to edit an institution static page while the 'Use
  site default' is set to yes

  To test
  - Have an institution
  - Go to Admin menu -> Institutions -> static pages
  - Set 'Use site default' to yes

  expected result: the tinyMCE editor is greyed out and you are not allowed to 
make changes
  actual result: the tinyMCE editor is enabled

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1891939/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1898478] Re: Retractable option not available any more in 'Edit' mode

2020-10-21 Thread Robert Lyon
** Changed in: mahara/20.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1898478

Title:
  Retractable option not available any more in 'Edit' mode

Status in Mahara:
  Fix Released
Status in Mahara 19.10 series:
  Fix Released
Status in Mahara 20.04 series:
  Fix Released
Status in Mahara 20.10 series:
  Fix Released

Bug description:
  This is a regression.

  The retractable option in 'Edit' mode is not available any more, thus
  making it more difficult for people to deal with long blocks or see
  what the end result is in display mode.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1898478/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1889340] Re: Adding indexes to tag table to speed things up

2020-10-21 Thread Lisa Seeto
** Changed in: mahara/19.10
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1889340

Title:
  Adding indexes to tag table to speed things up

Status in Mahara:
  Fix Released
Status in Mahara 19.04 series:
  Fix Released
Status in Mahara 19.10 series:
  Fix Released
Status in Mahara 20.04 series:
  Fix Released
Status in Mahara 20.10 series:
  Fix Released

Bug description:
  To make requests to tags table faster

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1889340/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1891844] Re: ajax loaded blocks not resizing properly

2020-10-21 Thread Lisa Seeto
** Changed in: mahara/19.10
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1891844

Title:
  ajax loaded blocks not resizing properly

Status in Mahara:
  Fix Released
Status in Mahara 19.10 series:
  Fix Released
Status in Mahara 20.04 series:
  Fix Released
Status in Mahara 20.10 series:
  Fix Released

Bug description:
  need to wait until ajax loaded blocks have finish loading, to trigger
  gridstack load resize

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1891844/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1891949] Re: sign off block height on gridstack

2020-10-21 Thread Robert Lyon
** Changed in: mahara/20.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1891949

Title:
  sign off block height on gridstack

Status in Mahara:
  Fix Released
Status in Mahara 19.10 series:
  Fix Released
Status in Mahara 20.04 series:
  Fix Released
Status in Mahara 20.10 series:
  Fix Released

Bug description:
  The sign off block content is very different when editing the page from when 
viewing the page. This makes the block have a lot of extra space when viewing 
the page. We can make the height be predefined for viewsing since it will 
always have the same content, it can only have
  Sign off / Verify lines
  or
  Sign off alone

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1891949/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1888743] Re: clean up references to old menu structure

2020-10-21 Thread Robert Lyon
** Changed in: mahara/20.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1888743

Title:
  clean up references to old menu structure

Status in Mahara:
  Fix Released
Status in Mahara 19.04 series:
  Fix Released
Status in Mahara 19.10 series:
  Fix Released
Status in Mahara 20.04 series:
  Fix Released
Status in Mahara 20.10 series:
  Fix Released

Bug description:
  Currently we still have some references to the old menu structure within 
Mahara.
  'myportfolio' and 'content' should both be updated to 'create'.

  Change: define(MENUITEM', 'myportfolio');
  To: define('MENUITEM', 'create');

  In the following files:
  relatedtags.php
  artefact/annotation/edit.php
  artefact/comment/edit.php
  artefact/peerassessment/edit.php

  In artefact/internal/socialprofile.php:
  Change: define('MENUITEM', 'content/profile');
  To: define('MENUITEM', 'create/files');

  In htdocs/lib/web.php:
  Change (ln 1476 in a comment): in_array(MENUITEM, array('myportfolio/view'))),
  To: in_array(MENUITEM, array('create/view'))),

  The old code was discovered when upgrading a site from 18.10 to 20.04.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1888743/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1898762] Re: Regression memcached servers

2020-10-21 Thread Robert Lyon
** Changed in: mahara/20.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1898762

Title:
  Regression memcached servers

Status in Mahara:
  Fix Released
Status in Mahara 19.10 series:
  Fix Released
Status in Mahara 20.04 series:
  Fix Released
Status in Mahara 20.10 series:
  Fix Released

Bug description:
  Analising mahara 20.04.1 I see and regression on here :
  
https://github.com/MaharaProject/mahara/blob/20.04_STABLE/htdocs/auth/lib.php#L681

  
  Instead of this

  if (empty($server_version[$host . ':' . $port])) {
  $is_configured = false;
  }

  It should be this : 
  if (!empty($server_version[$host . ':' . $port])) {
  $is_configured = true;
  }

  
  I tried to configured a memcached server and had an erreur as settings 
memcacheservers weren't set.

  In the code since $is_configured is already false, we have to invert
  the logic to see if a server is configured or not.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1898762/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1887450] Re: Block header buttons need better labels when Editing Pages

2020-10-21 Thread Robert Lyon
** Changed in: mahara/20.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1887450

Title:
  Block header buttons need better labels when Editing Pages

Status in Mahara:
  Fix Released
Status in Mahara 19.04 series:
  Fix Released
Status in Mahara 19.10 series:
  Fix Released
Status in Mahara 20.04 series:
  Fix Released
Status in Mahara 20.10 series:
  Fix Released

Bug description:
  It was found that the labels for the buttons that appear when editing
  a block on a page are not accurately described by a screen reader.
  The buttons are "Configure block" and "Remove block".  The "Remove
  block" button was entirely missing its label for screen readers, while
  the "Configure block" reads "Move block" instead of configure block.

  It looks like the 'sr-only' class needs to be applied correctly to the
  configure block button so that it misses the move button text and
  addresses its own purposes and for it to be applied to the remove
  block button in blocktypecontainerediting.tpl

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1887450/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1889341] Re: upgrade jquery 3.4.1 to 3.5.1

2020-10-21 Thread Lisa Seeto
** Changed in: mahara/19.10
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1889341

Title:
  upgrade jquery 3.4.1 to 3.5.1

Status in Mahara:
  Fix Released
Status in Mahara 19.04 series:
  Fix Released
Status in Mahara 19.10 series:
  Fix Released
Status in Mahara 20.04 series:
  Fix Released
Status in Mahara 20.10 series:
  Fix Released

Bug description:
  Related to https://bugs.launchpad.net/mahara/+bug/1865115

  jquery is now at 3.5.1 and we are on 3.4.1.  Version 3.5.0 contained
  security fixes as described below:

  https://blog.jquery.com/2020/04/10/jquery-3-5-0-released/

  Change log:
  https://github.com/jquery/jquery/compare/3.4.1...3.5.1

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1889341/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1892790] Re: Google Apps Block unable to parse URL to google drive folder

2020-10-21 Thread Lisa Seeto
** Changed in: mahara/19.10
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1892790

Title:
  Google Apps Block unable to parse URL to google drive folder

Status in Mahara:
  Fix Released
Status in Mahara 19.04 series:
  Fix Released
Status in Mahara 19.10 series:
  Fix Released
Status in Mahara 20.04 series:
  Fix Released
Status in Mahara 20.10 series:
  Fix Released

Bug description:
  Google Drive URLs aren't parsed correctly any more and don't display
  the Google Drive folder icon (or whatever needs to be displayed).

  For example, the folder https://drive.google.com/drive/folders/0B-V_s
  ... 00Y2JmLTkwNjUtZGM0ODJiZGNjYWEy has been shared publicly but on
  MyPortfolio (and also master) it only displays:

  "Unable to parse embedded code or URL:
  https://drive.google.com/drive/folders/0B-V_s ...
  0Y2JmLTkwNjUtZGM0ODJiZGNjYWEy"

  To replicate:
  1. Log in and create a page and select to create a "Google Apps" block
  2. In the "Embed code or URL" put the above url and save the block.
  Expected results:
  The block displays with icon etc... correctly
  Actual results:
  The block displays with "Unable to parse embedded code or URL: 
https://drive.google.com/drive/folders/0B-V_s9Ys157uZmFkY2RlOWMtNGY4Yy00Y2JmLTkwNjUtZGM0ODJiZGNjYWEy
 "

  Our regex is failing to parse this pattern and we'll need to add to it
  while keeping any necessary previous patterns for backwards
  compatibility.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1892790/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1893159] Re: Dashboard widgets are not receiving customisable theme styling

2020-10-21 Thread Robert Lyon
** Changed in: mahara/20.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1893159

Title:
  Dashboard widgets are not receiving customisable theme styling

Status in Mahara:
  Fix Released
Status in Mahara 19.04 series:
  Fix Released
Status in Mahara 19.10 series:
  Fix Released
Status in Mahara 20.04 series:
  Fix Released
Status in Mahara 20.10 series:
  Fix Released

Bug description:
  Currently the Dashboard widgets for "Create", "Share" and "Engage" do
  not receive the styling carried over from an institution's
  customisable theme (see attached screen shot)

  To replicate:
  Have an institution and at least one member who has dashboard info showing 
(to see the widgets)
  1. Log in to site as administrator, in the Institution settings, select 
'Customisable theme' for Theme and select custom colours (default config theme 
colours are fine).
  2. Save the institution
  3. Log in as institution member and navigate to dashboard, hover over the 
dashboard widgets
  Expected results:
  The Dashboard widgets display in customised colours matching the header
  Actual results:
  The Dashboard widgets display in the Raw theme colours.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1893159/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1898643] Re: remove references to class used in old layout

2020-10-21 Thread Robert Lyon
** Changed in: mahara/20.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1898643

Title:
  remove references to class used in old layout

Status in Mahara:
  Fix Released
Status in Mahara 19.10 series:
  Fix Released
Status in Mahara 20.04 series:
  Fix Released
Status in Mahara 20.10 series:
  Fix Released

Bug description:
  Before gridstack layout, every time a block was moved in a page's edit
  mode, the background changed color to reflect that the block was being
  moved. This can be tested in 19.04 or older versions of Mahara.

  We don't do this anymore, so any reference to the css class "block-
  drop-on" needs to be removed from the code. Removing this class should
  not affect the styling of a block when it's being moved.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1898643/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1892660] Re: lti error when upgrading from 19.04 to 20.04

2020-10-21 Thread Lisa Seeto
** Changed in: mahara/19.10
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1892660

Title:
  lti error when upgrading from 19.04 to 20.04

Status in Mahara 19.04 series:
  Fix Released
Status in Mahara 19.10 series:
  Fix Released
Status in Mahara 20.04 series:
  Fix Released

Bug description:
  If we're upgrading from an 19.04 install to a 20.04 version, there
  will be an error message in the upgrade page like the one copied
  below.

  This happens because we forgot to bump the lti plugin version number in the 
patch for the following bug
  https://bugs.launchpad.net/mahara/+bug/1795597

  As a result, any site upgrade that tries to also upgrade the lti
  plugin will try to run the postintall from the previous patch a second
  time, getting the error messages.

  Error messages during site upgrade:

  [DBG] 1b (module/lti/lib.php:30) Add indexes to lti_assessment table
  [DBG] 1b (lib/dml.php:180) mysqli error: [1061: Duplicate key name 
'mh2_ltiasse_res_ix'] in EXECUTE("CREATE INDEX mh2_ltiasse_res_ix ON 
mh2_lti_assessment (resourcelinkid(255))")Command was: CREATE INDEX 
mh2_ltiasse_res_ix ON mh2_lti_assessment (resourcelinkid(255))
  [WAR] 1b (lib/errors.php:859) Could not execute command: CREATE INDEX 
mh2_ltiasse_res_ix ON mh2_lti_assessment (resourcelinkid(255))
  Call stack (most recent first):

  log_message("Could not execute command: CREATE INDEX mh2_ltiass...", 8, 
true, true) at /home/ceciliavg/maharacode/mahara/htdocs/lib/errors.php:95
  log_warn("Could not execute command: CREATE INDEX mh2_ltiass...") at 
/home/ceciliavg/maharacode/mahara/htdocs/lib/errors.php:859
  SQLException->__construct("Could not execute command: CREATE INDEX 
mh2_ltiass...") at /home/ceciliavg/maharacode/mahara/htdocs/lib/dml.php:181
  execute_sql("CREATE INDEX mh2_ltiasse_res_ix ON mh2_lti_assessm...") at 
/home/ceciliavg/maharacode/mahara/htdocs/lib/dml.php:1661
  execute_sql_arr(array(size 1), true, true) at 
/home/ceciliavg/maharacode/mahara/htdocs/lib/ddl.php:1331
  add_index(object(XMLDBTable), object(XMLDBIndex)) at 
/home/ceciliavg/maharacode/mahara/htdocs/module/lti/lib.php:37
  PluginModuleLti::postinst("2018071009") at 
/home/ceciliavg/maharacode/mahara/htdocs/lib/mahara.php:1818
  call_static_method("PluginModuleLti", "postinst", "2018071009") at 
/home/ceciliavg/maharacode/mahara/htdocs/lib/upgrade.php:621
  upgrade_plugin(object(stdClass)) at 
/home/ceciliavg/maharacode/mahara/htdocs/admin/upgrade.json.php:84

  [DBG] 1b (lib/dml.php:180) mysqli error: [1061: Duplicate key name 
'mh2_ltiasse_con_ix'] in EXECUTE("CREATE INDEX mh2_ltiasse_con_ix ON 
mh2_lti_assessment (contextid(255))")Command was: CREATE INDEX 
mh2_ltiasse_con_ix ON mh2_lti_assessment (contextid(255))
  [WAR] 1b (lib/errors.php:859) Could not execute command: CREATE INDEX 
mh2_ltiasse_con_ix ON mh2_lti_assessment (contextid(255))
  Call stack (most recent first):

  log_message("Could not execute command: CREATE INDEX mh2_ltiass...", 8, 
true, true) at /home/ceciliavg/maharacode/mahara/htdocs/lib/errors.php:95
  log_warn("Could not execute command: CREATE INDEX mh2_ltiass...") at 
/home/ceciliavg/maharacode/mahara/htdocs/lib/errors.php:859
  SQLException->__construct("Could not execute command: CREATE INDEX 
mh2_ltiass...") at /home/ceciliavg/maharacode/mahara/htdocs/lib/dml.php:181
  execute_sql("CREATE INDEX mh2_ltiasse_con_ix ON mh2_lti_assessm...") at 
/home/ceciliavg/maharacode/mahara/htdocs/lib/dml.php:1661
  execute_sql_arr(array(size 1), true, true) at 
/home/ceciliavg/maharacode/mahara/htdocs/lib/ddl.php:1331
  add_index(object(XMLDBTable), object(XMLDBIndex)) at 
/home/ceciliavg/maharacode/mahara/htdocs/module/lti/lib.php:43
  PluginModuleLti::postinst("2018071009") at 
/home/ceciliavg/maharacode/mahara/htdocs/lib/mahara.php:1818
  call_static_method("PluginModuleLti", "postinst", "2018071009") at 
/home/ceciliavg/maharacode/mahara/htdocs/lib/upgrade.php:621
  upgrade_plugin(object(stdClass)) at 
/home/ceciliavg/maharacode/mahara/htdocs/admin/upgrade.json.php:84

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/19.04/+bug/1892660/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1895476] Re: Changing some SAML functions calls to be namespaced

2020-10-21 Thread Lisa Seeto
** Changed in: mahara/19.10
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1895476

Title:
  Changing some SAML functions calls to be namespaced

Status in Mahara:
  Fix Released
Status in Mahara 19.10 series:
  Fix Released
Status in Mahara 20.04 series:
  Fix Released
Status in Mahara 20.10 series:
  Fix Released

Bug description:
  Fixing up places where the following error occurs 
   
  error: call the class or interface 'SimpleSAML_*' correctly

  As SAML now is using namespaces, so should the local calls to the
  methods, so

   'SimpleSAML_Configuration' becomes 'SimpleSAML\Configuration'
   'SimpleSAML_Metadata_MetaDataStorageSource' becomes 
'SimpleSAML\Metadata\MetaDataStorageSource'

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1895476/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1883803] Re: Missing Help Text Icon: admin/site/menu.php

2020-10-21 Thread Robert Lyon
** Changed in: mahara/20.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1883803

Title:
  Missing Help Text Icon: admin/site/menu.php

Status in Mahara:
  Fix Released
Status in Mahara 19.04 series:
  Fix Released
Status in Mahara 19.10 series:
  Fix Released
Status in Mahara 20.04 series:
  Fix Released
Status in Mahara 20.10 series:
  Fix Released

Bug description:
  The Help icons are missing for "External link" and "Site file" on the
  "Menus" page (admin/site/menu.php) Admin menu -> Configure site ->
  Menus.

  To replicate:
  1. Log into Mahara as a site admin
  2. Navigate to the Menus page: Admin menu -> Configure Site -> Menus
  3. Set the Keyboard focus to the the radio button for "External link"
  4. Navigate the keyboard focus (tab once) and press enter
  5. Observe that the pop-up for the help text for "External link" will appear 
but does not have a help icon to distinguish it
  This happens with "Site file" as well.

  Another issue, is that when the cursor is hovered over the "External
  link" and "Site files" it changes to the cursor associated with
  mousing over links.

  Versions: Mahara 20.04, 19.10 19.04

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1883803/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1886593] Re: usr.active not changed when unexpiring a user from admin/user/edit.php screen

2020-10-21 Thread Lisa Seeto
** Changed in: mahara/19.10
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1886593

Title:
  usr.active not changed when unexpiring a user from admin/user/edit.php
  screen

Status in Mahara:
  Fix Released
Status in Mahara 19.04 series:
  Fix Released
Status in Mahara 19.10 series:
  Fix Released
Status in Mahara 20.04 series:
  Fix Released
Status in Mahara 20.10 series:
  Fix Released

Bug description:
  When we expire a user their 'active' field in database usr table goes
  from 1 to 0 and if we un-expire them from the expired users list it
  sets it back to active correctly

  But if we try updating the user from admin/users/edit.php screen by
  adding / removing the expiry date in the form field it doesn't set the
  active value correctly

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1886593/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1892256] Re: Undefined variable: duplicates error when updating SAML metadata in SAML instance

2020-10-21 Thread Lisa Seeto
** Changed in: mahara/19.10
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1892256

Title:
  Undefined variable: duplicates error when updating SAML metadata in
  SAML instance

Status in Mahara:
  Fix Released
Status in Mahara 19.04 series:
  Fix Released
Status in Mahara 19.10 series:
  Fix Released
Status in Mahara 20.04 series:
  Fix Released
Status in Mahara 20.10 series:
  Fix Released

Bug description:
  This is because we can't chain the db query result and finding the
  resultant object value in the same "if" statement

  We need to break this down into testable parts

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1892256/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1886593] Re: usr.active not changed when unexpiring a user from admin/user/edit.php screen

2020-10-21 Thread Robert Lyon
** Changed in: mahara/20.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1886593

Title:
  usr.active not changed when unexpiring a user from admin/user/edit.php
  screen

Status in Mahara:
  Fix Released
Status in Mahara 19.04 series:
  Fix Released
Status in Mahara 19.10 series:
  Fix Released
Status in Mahara 20.04 series:
  Fix Released
Status in Mahara 20.10 series:
  Fix Released

Bug description:
  When we expire a user their 'active' field in database usr table goes
  from 1 to 0 and if we un-expire them from the expired users list it
  sets it back to active correctly

  But if we try updating the user from admin/users/edit.php screen by
  adding / removing the expiry date in the form field it doesn't set the
  active value correctly

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1886593/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1895901] Re: Getting PHP Fatal error: Cannot redeclare serve_file() when using sync_langpacks

2020-10-21 Thread Lisa Seeto
** Changed in: mahara/19.10
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1895901

Title:
  Getting PHP Fatal error:  Cannot redeclare serve_file() when using
  sync_langpacks

Status in Mahara:
  Fix Released
Status in Mahara 19.04 series:
  Fix Released
Status in Mahara 19.10 series:
  Fix Released
Status in Mahara 20.04 series:
  Fix Released
Status in Mahara 20.10 series:
  Fix Released

Bug description:
  This is because we are using require() instead of require_once() in
  sync_langpacks.php

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1895901/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1888769] Re: Correct link to Badrg in 'Open Badges' block

2020-10-21 Thread Robert Lyon
** Changed in: mahara/20.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1888769

Title:
  Correct link to Badrg in 'Open Badges' block

Status in Mahara:
  Fix Released
Status in Mahara 19.04 series:
  Fix Released
Status in Mahara 19.10 series:
  Fix Released
Status in Mahara 20.04 series:
  Fix Released
Status in Mahara 20.10 series:
  Fix Released

Bug description:
  The link to Badgr in the 'Open Badges' configuration screen is wrong
  and points to the API, which is not going to be helpful for setting up
  an account. It should link to https://badgr.com instead.

  To replicate:

  1. Create a page with the 'Open Badges' block in it.
  2. In the block configuration check the link to Badgr.
  Expected result: Goes to https://badgr.com
  Actual result: Goes to https://api.badgr.io

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1888769/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1888769] Re: Correct link to Badrg in 'Open Badges' block

2020-10-21 Thread Lisa Seeto
** Changed in: mahara/19.10
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1888769

Title:
  Correct link to Badrg in 'Open Badges' block

Status in Mahara:
  Fix Released
Status in Mahara 19.04 series:
  Fix Released
Status in Mahara 19.10 series:
  Fix Released
Status in Mahara 20.04 series:
  Fix Released
Status in Mahara 20.10 series:
  Fix Released

Bug description:
  The link to Badgr in the 'Open Badges' configuration screen is wrong
  and points to the API, which is not going to be helpful for setting up
  an account. It should link to https://badgr.com instead.

  To replicate:

  1. Create a page with the 'Open Badges' block in it.
  2. In the block configuration check the link to Badgr.
  Expected result: Goes to https://badgr.com
  Actual result: Goes to https://api.badgr.io

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1888769/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1891237] Re: Language string broken in institution stats overview page

2020-10-21 Thread Robert Lyon
** Changed in: mahara/20.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1891237

Title:
  Language string broken in institution stats overview page

Status in Mahara:
  Fix Released
Status in Mahara 19.04 series:
  Fix Released
Status in Mahara 19.10 series:
  Fix Released
Status in Mahara 20.04 series:
  Fix Released
Status in Mahara 20.10 series:
  Fix Released

Bug description:
  There is an issue with [[profile/view]] broken string on a View type
  graph.

  Part of the problem is the graph's data is cached in the database and
  so the broken string is stored there.

  The fix for this both replaces the missing string and adds a bit to
  the data fetching so that any cached graph data that has a broken
  string recorded gets it to be translated as expected.

  To test:

  Have a site that contains institutions that has some members that have
  logged in and have made some pages (this will work best if the
  database has had some time to run crons for a week or so)

  1) Login as admin
  2) Go to the Admin -> Reports page
  3) Click configure report
  4) Choose an institution and keep 'report type' as 'overview'
  5) See 'Pages overview' graph with the broken language string

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1891237/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1892655] Re: need to escape mysql keyword 'row' in gridstacklayout.js

2020-10-21 Thread Lisa Seeto
** Changed in: mahara/19.10
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1892655

Title:
  need to escape mysql keyword 'row' in gridstacklayout.js

Status in Mahara:
  Fix Released
Status in Mahara 19.10 series:
  Fix Released
Status in Mahara 20.04 series:
  Fix Released
Status in Mahara 20.10 series:
  Fix Released

Bug description:
  or it will fail the translation process from old layout pages to new
  grisdtack layout

  the words 'row' and 'rows' became reserved words in MySQL 8.0.2

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1892655/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1893142] Re: block header dissapearing when block is collapsed

2020-10-21 Thread Lisa Seeto
** Changed in: mahara/19.10
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1893142

Title:
  block header dissapearing when block is collapsed

Status in Mahara 19.10 series:
  Fix Released
Status in Mahara 20.04 series:
  Fix Released

Bug description:
  This is happening due to the fixes we added on view layouts for extra
  spacing (Bug 1883471)

  On branches 20.04, 19.10
  It doesn't affect master (20.10) since it was fixed as part of another patch

  To replicate
  - Add a text block to a page
  - Set title: 'A block title', content: 'Some text' and set retractable = 'Yes'
  - Display the page
  - Collapse the block

  Expected result: The content text 'Some text' is hidden and the header with 
text 'A block title' is visible
  Actual result: both content and header is gone, the page needs to be 
refreshed to see the block again

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/19.10/+bug/1893142/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1889340] Re: Adding indexes to tag table to speed things up

2020-10-21 Thread Robert Lyon
** Changed in: mahara/20.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1889340

Title:
  Adding indexes to tag table to speed things up

Status in Mahara:
  Fix Released
Status in Mahara 19.04 series:
  Fix Released
Status in Mahara 19.10 series:
  Fix Released
Status in Mahara 20.04 series:
  Fix Released
Status in Mahara 20.10 series:
  Fix Released

Bug description:
  To make requests to tags table faster

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1889340/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1893291] Re: Undefined property: stdClass::$constraint_name error for MySql 8

2020-10-21 Thread Lisa Seeto
** Changed in: mahara/19.10
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1893291

Title:
  Undefined property: stdClass::$constraint_name error for MySql 8

Status in Mahara:
  Fix Released
Status in Mahara 19.04 series:
  Fix Released
Status in Mahara 19.10 series:
  Fix Released
Status in Mahara 20.04 series:
  Fix Released
Status in Mahara 20.10 series:
  Fix Released

Bug description:
  The returned SQL result for checking find_key_name() for
  constraint_name has the column name in uppercase but we try to use it
  as $c->constraint_name (in lowercase)

  We need to check if property $c->CONSTRAINT_NAME exists and use that
  otherwise use $c->constraint_name

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1893291/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1885982] Re: behat headless doesn't work with chrome 80

2020-10-21 Thread Robert Lyon
** Changed in: mahara/20.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1885982

Title:
  behat headless doesn't work with chrome 80

Status in Mahara:
  Fix Released
Status in Mahara 19.04 series:
  Fix Released
Status in Mahara 19.10 series:
  Fix Released
Status in Mahara 20.04 series:
  Fix Released
Status in Mahara 20.10 series:
  Fix Released

Bug description:
  patch for this here https://reviews.mahara.org/#/c/10785/5

  add -screen pixel depth and related xvfb params for bionic and chrome 80
fixes issue with chrome 80 and xvfb where default parameters (prob pixel 
depth)
makes chrome fail to connect to xvfb/selenium.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1885982/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1883987] Re: Help Icon for authentication plugin not aligned properly

2020-10-21 Thread Robert Lyon
** Changed in: mahara/20.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1883987

Title:
  Help Icon for authentication plugin not aligned properly

Status in Mahara:
  Fix Released
Status in Mahara 19.04 series:
  Fix Released
Status in Mahara 19.10 series:
  Fix Released
Status in Mahara 20.04 series:
  Fix Released
Status in Mahara 20.10 series:
  Fix Released

Bug description:
  The Help icon for Admin Menu -> Institution settings -> Authentication
  plugin is not aligned properly with the content but is sitting below
  where it should be.

  To test:
  1. Log into Mahara as a site admin
  2. Navigate to Admin Menu -> Institution settings, select institution, view 
area for Authentication plugin
  Expected results:
  All visual content is aligned and consistent
  Actual results:
  The help icon for Authentication plugin is sitting below the area and is 
intersected by a horizontal line.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1883987/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1899120] Re: Incorrect button classes on submitcancel buttons 20.04

2020-10-21 Thread Robert Lyon
** Changed in: mahara/20.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1899120

Title:
  Incorrect button classes on submitcancel buttons 20.04

Status in Mahara:
  Fix Released
Status in Mahara 20.04 series:
  Fix Released
Status in Mahara 20.10 series:
  Fix Released

Bug description:
  Related to: https://bugs.launchpad.net/mahara/+bug/1898955

  While testing the above fix I looked for "submitcancel" in .tpl files
  to see whether there were other cases with "btn-primary" and without
  "btn" class. I found the following:

  /htdocs/theme/raw/plugintype/artefact/file/templates/form/editfile.tpl
  /htdocs/theme/raw/plugintype/module/framework/templates/jsoneditor.tpl
  
/htdocs/theme/raw/plugintype/module/multirecipientnotification/templates/indexsearch.tpl
  /htdocs/theme/raw/templates/privacy_modal.tpl

  I confirmed the first three do display incorrect styling for the submitcancel 
button group.
  Screenshots below.

  Limitations
  Note: This affects 20.04, but not 20.10+
  Only buttons using the "submitcancel" class have been searched for. It is 
possible there are other similar issues with other button classes.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1899120/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1889341] Re: upgrade jquery 3.4.1 to 3.5.1

2020-10-21 Thread Robert Lyon
** Changed in: mahara/20.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1889341

Title:
  upgrade jquery 3.4.1 to 3.5.1

Status in Mahara:
  Fix Released
Status in Mahara 19.04 series:
  Fix Released
Status in Mahara 19.10 series:
  Fix Released
Status in Mahara 20.04 series:
  Fix Released
Status in Mahara 20.10 series:
  Fix Released

Bug description:
  Related to https://bugs.launchpad.net/mahara/+bug/1865115

  jquery is now at 3.5.1 and we are on 3.4.1.  Version 3.5.0 contained
  security fixes as described below:

  https://blog.jquery.com/2020/04/10/jquery-3-5-0-released/

  Change log:
  https://github.com/jquery/jquery/compare/3.4.1...3.5.1

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1889341/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1895901] Re: Getting PHP Fatal error: Cannot redeclare serve_file() when using sync_langpacks

2020-10-21 Thread Robert Lyon
** Changed in: mahara/20.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1895901

Title:
  Getting PHP Fatal error:  Cannot redeclare serve_file() when using
  sync_langpacks

Status in Mahara:
  Fix Released
Status in Mahara 19.04 series:
  Fix Released
Status in Mahara 19.10 series:
  Fix Committed
Status in Mahara 20.04 series:
  Fix Released
Status in Mahara 20.10 series:
  Fix Released

Bug description:
  This is because we are using require() instead of require_once() in
  sync_langpacks.php

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1895901/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1890349] Re: SAML auth update user issues

2020-10-21 Thread Robert Lyon
** Changed in: mahara/20.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1890349

Title:
  SAML auth update user issues

Status in Mahara:
  Fix Released
Status in Mahara 20.04 series:
  Fix Released
Status in Mahara 20.10 series:
  Fix Released

Bug description:
  Currently if you have a user in Mahara that logs in via SAML and has
  update user option set then their admin/staff status is updated. If
  this info is not being passed in via SAML from IdP it means they are
  updated to be normal members.

  We should only do this updating if any of the SAML instance settings are set 
for:
  - rolesiteadmin
  - rolesitestaff
  - roleinstadmin
  - roleinststaff

  And if the particular one is not set to ignore updating this part of
  the user's profile

  Also we need to check that the following is correct
   if ($institutionrole == 'admin') {
   $institution->addUserAsStaff($user);
   }

  Should it be  $institution->addUserAsAdmin($user);

  
  Thanks go to SWITCH for sponsoring this fix.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1890349/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1891844] Re: ajax loaded blocks not resizing properly

2020-10-21 Thread Robert Lyon
** Changed in: mahara/20.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1891844

Title:
  ajax loaded blocks not resizing properly

Status in Mahara:
  Fix Released
Status in Mahara 19.10 series:
  Fix Committed
Status in Mahara 20.04 series:
  Fix Released
Status in Mahara 20.10 series:
  Fix Released

Bug description:
  need to wait until ajax loaded blocks have finish loading, to trigger
  gridstack load resize

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1891844/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1850749] Re: Stripping prefix from table name should only happen at start of string

2020-10-21 Thread Robert Lyon
** Changed in: mahara/20.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1850749

Title:
  Stripping prefix from table name should only happen at start of string

Status in Mahara:
  Fix Released
Status in Mahara 20.04 series:
  Fix Released
Status in Mahara 20.10 series:
  Fix Released

Bug description:
  In case the prefix also matches another part of table name we should
  explicitly indicate removing it from the beginning of the string - as
  a prefix can only be at the beginning

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1850749/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1895617] Re: export html check for directory readability needs to match directory used

2020-10-21 Thread Robert Lyon
** Changed in: mahara/20.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1895617

Title:
  export html check for directory readability needs to match directory
  used

Status in Mahara:
  Fix Released
Status in Mahara 20.04 series:
  Fix Released
Status in Mahara 20.10 series:
  Fix Released

Bug description:
  In export/html/lib in the copy_static_files() we have the lines:

  if (is_readable($dir . $static)) {...etc...}

  but when we later populate the directories we want to copy we use:
  $directoriestocopy[$dir . '/' . $static] which uses a different path.
  This also adds an extra unneccesary directory level '/'.
  We need to make these paths consistent.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1895617/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1892256] Re: Undefined variable: duplicates error when updating SAML metadata in SAML instance

2020-10-21 Thread Robert Lyon
** Changed in: mahara/20.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1892256

Title:
  Undefined variable: duplicates error when updating SAML metadata in
  SAML instance

Status in Mahara:
  Fix Released
Status in Mahara 19.04 series:
  Fix Released
Status in Mahara 19.10 series:
  Fix Committed
Status in Mahara 20.04 series:
  Fix Released
Status in Mahara 20.10 series:
  Fix Released

Bug description:
  This is because we can't chain the db query result and finding the
  resultant object value in the same "if" statement

  We need to break this down into testable parts

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1892256/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1892655] Re: need to escape mysql keyword 'row' in gridstacklayout.js

2020-10-21 Thread Robert Lyon
** Changed in: mahara/20.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1892655

Title:
  need to escape mysql keyword 'row' in gridstacklayout.js

Status in Mahara:
  Fix Released
Status in Mahara 19.10 series:
  Fix Committed
Status in Mahara 20.04 series:
  Fix Released
Status in Mahara 20.10 series:
  Fix Released

Bug description:
  or it will fail the translation process from old layout pages to new
  grisdtack layout

  the words 'row' and 'rows' became reserved words in MySQL 8.0.2

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1892655/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1892660] Re: lti error when upgrading from 19.04 to 20.04

2020-10-21 Thread Robert Lyon
** Changed in: mahara/20.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1892660

Title:
  lti error when upgrading from 19.04 to 20.04

Status in Mahara 19.04 series:
  Fix Released
Status in Mahara 19.10 series:
  Fix Committed
Status in Mahara 20.04 series:
  Fix Released

Bug description:
  If we're upgrading from an 19.04 install to a 20.04 version, there
  will be an error message in the upgrade page like the one copied
  below.

  This happens because we forgot to bump the lti plugin version number in the 
patch for the following bug
  https://bugs.launchpad.net/mahara/+bug/1795597

  As a result, any site upgrade that tries to also upgrade the lti
  plugin will try to run the postintall from the previous patch a second
  time, getting the error messages.

  Error messages during site upgrade:

  [DBG] 1b (module/lti/lib.php:30) Add indexes to lti_assessment table
  [DBG] 1b (lib/dml.php:180) mysqli error: [1061: Duplicate key name 
'mh2_ltiasse_res_ix'] in EXECUTE("CREATE INDEX mh2_ltiasse_res_ix ON 
mh2_lti_assessment (resourcelinkid(255))")Command was: CREATE INDEX 
mh2_ltiasse_res_ix ON mh2_lti_assessment (resourcelinkid(255))
  [WAR] 1b (lib/errors.php:859) Could not execute command: CREATE INDEX 
mh2_ltiasse_res_ix ON mh2_lti_assessment (resourcelinkid(255))
  Call stack (most recent first):

  log_message("Could not execute command: CREATE INDEX mh2_ltiass...", 8, 
true, true) at /home/ceciliavg/maharacode/mahara/htdocs/lib/errors.php:95
  log_warn("Could not execute command: CREATE INDEX mh2_ltiass...") at 
/home/ceciliavg/maharacode/mahara/htdocs/lib/errors.php:859
  SQLException->__construct("Could not execute command: CREATE INDEX 
mh2_ltiass...") at /home/ceciliavg/maharacode/mahara/htdocs/lib/dml.php:181
  execute_sql("CREATE INDEX mh2_ltiasse_res_ix ON mh2_lti_assessm...") at 
/home/ceciliavg/maharacode/mahara/htdocs/lib/dml.php:1661
  execute_sql_arr(array(size 1), true, true) at 
/home/ceciliavg/maharacode/mahara/htdocs/lib/ddl.php:1331
  add_index(object(XMLDBTable), object(XMLDBIndex)) at 
/home/ceciliavg/maharacode/mahara/htdocs/module/lti/lib.php:37
  PluginModuleLti::postinst("2018071009") at 
/home/ceciliavg/maharacode/mahara/htdocs/lib/mahara.php:1818
  call_static_method("PluginModuleLti", "postinst", "2018071009") at 
/home/ceciliavg/maharacode/mahara/htdocs/lib/upgrade.php:621
  upgrade_plugin(object(stdClass)) at 
/home/ceciliavg/maharacode/mahara/htdocs/admin/upgrade.json.php:84

  [DBG] 1b (lib/dml.php:180) mysqli error: [1061: Duplicate key name 
'mh2_ltiasse_con_ix'] in EXECUTE("CREATE INDEX mh2_ltiasse_con_ix ON 
mh2_lti_assessment (contextid(255))")Command was: CREATE INDEX 
mh2_ltiasse_con_ix ON mh2_lti_assessment (contextid(255))
  [WAR] 1b (lib/errors.php:859) Could not execute command: CREATE INDEX 
mh2_ltiasse_con_ix ON mh2_lti_assessment (contextid(255))
  Call stack (most recent first):

  log_message("Could not execute command: CREATE INDEX mh2_ltiass...", 8, 
true, true) at /home/ceciliavg/maharacode/mahara/htdocs/lib/errors.php:95
  log_warn("Could not execute command: CREATE INDEX mh2_ltiass...") at 
/home/ceciliavg/maharacode/mahara/htdocs/lib/errors.php:859
  SQLException->__construct("Could not execute command: CREATE INDEX 
mh2_ltiass...") at /home/ceciliavg/maharacode/mahara/htdocs/lib/dml.php:181
  execute_sql("CREATE INDEX mh2_ltiasse_con_ix ON mh2_lti_assessm...") at 
/home/ceciliavg/maharacode/mahara/htdocs/lib/dml.php:1661
  execute_sql_arr(array(size 1), true, true) at 
/home/ceciliavg/maharacode/mahara/htdocs/lib/ddl.php:1331
  add_index(object(XMLDBTable), object(XMLDBIndex)) at 
/home/ceciliavg/maharacode/mahara/htdocs/module/lti/lib.php:43
  PluginModuleLti::postinst("2018071009") at 
/home/ceciliavg/maharacode/mahara/htdocs/lib/mahara.php:1818
  call_static_method("PluginModuleLti", "postinst", "2018071009") at 
/home/ceciliavg/maharacode/mahara/htdocs/lib/upgrade.php:621
  upgrade_plugin(object(stdClass)) at 
/home/ceciliavg/maharacode/mahara/htdocs/admin/upgrade.json.php:84

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/19.04/+bug/1892660/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1892664] Re: Share access with account holders outside of institution is producing a warning

2020-10-21 Thread Robert Lyon
** Changed in: mahara/20.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1892664

Title:
  Share access with account holders outside of institution is producing
  a warning

Status in Mahara:
  Fix Released
Status in Mahara 20.04 series:
  Fix Released
Status in Mahara 20.10 series:
  Fix Released

Bug description:
  A warning is produced when a user who is the only member of an
  institution tries to share view access with a user outside of their
  institution.

  To reproduce:
  Have an institution with one member, and members outside of institution on a 
site
  1. log in as institution member, create a page
  2. Share the page with a person on the site who isn't in an institution 
(anyone from "Other people") and save
  Expected results:
  The page is updated with new access rules
  Actual results:
  A warning is being produced (see attached screen shot for more):
  [WAR] 52 (view/access.json.php:70) array_keys() expects parameter 1 to be 
array, boolean given
  Call stack (most recent first):

  log_message("array_keys() expects parameter 1 to be array, bool...", 8, 
true, true, "/home/lisaseeto/code/mahara-test/htdocs/view/acces...", 70) at 
/home/lisaseeto/code/mahara-test/htdocs/lib/errors.php:521
  error(2, "array_keys() expects parameter 1 to be array, bool...", 
"/home/lisaseeto/code/mahara-test/htdocs/view/acces...", 70, array(size 73)) at 
Unknown:0
  array_keys(false) at 
/home/lisaseeto/code/mahara-test/htdocs/view/access.json.php:70

  [WAR] 52 (view/access.json.php:74) in_array() expects parameter 2 to be 
array, null given
  Call stack (most recent first):

  log_message("in_array() expects parameter 2 to be array, null g...", 8, 
true, true, "/home/lisaseeto/code/mahara-test/htdocs/view/acces...", 74) at 
/home/lisaseeto/code/mahara-test/htdocs/lib/errors.php:521
  error(2, "in_array() expects parameter 2 to be array, null g...", 
"/home/lisaseeto/code/mahara-test/htdocs/view/acces...", 74, array(size 75)) at 
Unknown:0
  in_array("20", null) at 
/home/lisaseeto/code/mahara-test/htdocs/view/access.json.php:74

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1892664/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1892790] Re: Google Apps Block unable to parse URL to google drive folder

2020-10-21 Thread Robert Lyon
** Changed in: mahara/20.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1892790

Title:
  Google Apps Block unable to parse URL to google drive folder

Status in Mahara:
  Fix Released
Status in Mahara 19.04 series:
  Fix Released
Status in Mahara 19.10 series:
  Fix Committed
Status in Mahara 20.04 series:
  Fix Released
Status in Mahara 20.10 series:
  Fix Released

Bug description:
  Google Drive URLs aren't parsed correctly any more and don't display
  the Google Drive folder icon (or whatever needs to be displayed).

  For example, the folder https://drive.google.com/drive/folders/0B-V_s
  ... 00Y2JmLTkwNjUtZGM0ODJiZGNjYWEy has been shared publicly but on
  MyPortfolio (and also master) it only displays:

  "Unable to parse embedded code or URL:
  https://drive.google.com/drive/folders/0B-V_s ...
  0Y2JmLTkwNjUtZGM0ODJiZGNjYWEy"

  To replicate:
  1. Log in and create a page and select to create a "Google Apps" block
  2. In the "Embed code or URL" put the above url and save the block.
  Expected results:
  The block displays with icon etc... correctly
  Actual results:
  The block displays with "Unable to parse embedded code or URL: 
https://drive.google.com/drive/folders/0B-V_s9Ys157uZmFkY2RlOWMtNGY4Yy00Y2JmLTkwNjUtZGM0ODJiZGNjYWEy
 "

  Our regex is failing to parse this pattern and we'll need to add to it
  while keeping any necessary previous patterns for backwards
  compatibility.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1892790/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1893291] Re: Undefined property: stdClass::$constraint_name error for MySql 8

2020-10-21 Thread Robert Lyon
** Changed in: mahara/20.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1893291

Title:
  Undefined property: stdClass::$constraint_name error for MySql 8

Status in Mahara:
  Fix Released
Status in Mahara 19.04 series:
  Fix Released
Status in Mahara 19.10 series:
  Fix Committed
Status in Mahara 20.04 series:
  Fix Released
Status in Mahara 20.10 series:
  Fix Released

Bug description:
  The returned SQL result for checking find_key_name() for
  constraint_name has the column name in uppercase but we try to use it
  as $c->constraint_name (in lowercase)

  We need to check if property $c->CONSTRAINT_NAME exists and use that
  otherwise use $c->constraint_name

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1893291/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1895476] Re: Changing some SAML functions calls to be namespaced

2020-10-21 Thread Robert Lyon
** Changed in: mahara/20.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1895476

Title:
  Changing some SAML functions calls to be namespaced

Status in Mahara:
  Fix Released
Status in Mahara 19.10 series:
  Fix Committed
Status in Mahara 20.04 series:
  Fix Released
Status in Mahara 20.10 series:
  Fix Released

Bug description:
  Fixing up places where the following error occurs 
   
  error: call the class or interface 'SimpleSAML_*' correctly

  As SAML now is using namespaces, so should the local calls to the
  methods, so

   'SimpleSAML_Configuration' becomes 'SimpleSAML\Configuration'
   'SimpleSAML_Metadata_MetaDataStorageSource' becomes 
'SimpleSAML\Metadata\MetaDataStorageSource'

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1895476/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1893142] Re: block header dissapearing when block is collapsed

2020-10-21 Thread Robert Lyon
** Changed in: mahara/20.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1893142

Title:
  block header dissapearing when block is collapsed

Status in Mahara 19.10 series:
  Fix Committed
Status in Mahara 20.04 series:
  Fix Released

Bug description:
  This is happening due to the fixes we added on view layouts for extra
  spacing (Bug 1883471)

  On branches 20.04, 19.10
  It doesn't affect master (20.10) since it was fixed as part of another patch

  To replicate
  - Add a text block to a page
  - Set title: 'A block title', content: 'Some text' and set retractable = 'Yes'
  - Display the page
  - Collapse the block

  Expected result: The content text 'Some text' is hidden and the header with 
text 'A block title' is visible
  Actual result: both content and header is gone, the page needs to be 
refreshed to see the block again

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/19.10/+bug/1893142/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1892105] Re: Cover image file not copied for institution collection

2020-10-21 Thread Robert Lyon
** Changed in: mahara/20.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1892105

Title:
  Cover image file not copied for institution collection

Status in Mahara:
  Fix Released
Status in Mahara 20.04 series:
  Fix Released
Status in Mahara 20.10 series:
  Fix Released

Bug description:
  When you have a collection on the institution level and add a cover
  image, the file is not associated when you copy it into your personal
  account. The file still comes along, but is not placed into the 'Cover
  images' folder.

  It nearly works fine for pages (see note below).

  This also needs to be tested for copying of collections on all other
  levels (personal, site, group).

  To replicate for institution collection:

  1. As site or institution admin, create a collection with 1 page.
  2. Upload a cover image to the collection.
  3. Share the page and make it copyable.
  4. Log in as another account holder.
  5. Copy the collection.
  6. View the collection on 'Pages and collections'.
  Expected result: The collection's cover image is displayed.
  Actual result: There is not cover image displayed.

  **Please note: When the above steps are 'repeated' for a page, the
  page cover image does display on the 'Pages and collections' page,
  however, the file is NOT present in the 'Files' > 'Cover images'
  folder.  It is instead placed in a sub-folder of the 'viewfiles'
  folder, this sub-sub-folder also contains any other files that were
  present for the copied page.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1892105/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1898955] Re: Add collection process missing button styles

2020-10-21 Thread Robert Lyon
** Changed in: mahara
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1898955

Title:
  Add collection process missing button styles

Status in Mahara:
  Fix Released

Bug description:
  This not a problem in 20.10+

  But is a problem in 20.04
  See attached image

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1898955/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1897190] A patch has been submitted for review

2020-10-21 Thread Mahara Bot
Patch for "master" branch: https://reviews.mahara.org/11400

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1897190

Title:
  Behat: Tidy up and improve behat properties file

Status in Mahara:
  New

Bug description:
  Background:

  A while ago we set up a behat 'properties' file to hold css/xpath
  locators so they wouldn't need to be included directly in steps. When
  that was implemented, all the steps that included css/xpath references
  were taken out and replaced with the steps that call the properties
  file.

  The original idea was that as new things needed to be found by the
  test suite, they would be added to the properties file and it would
  gradually grow to cover more of the site.

  
  Now:

  Steps that call the css/xpaths directly have been appearing back in
  the tests, rather than being added to the properties file as they are
  needed. This is probably just because it is faster to not add the
  locator to the properties file and just call it directly in the test.

  
  Issues:

  1. Adding the locators directly to tests means they are harder to read.
  2. Currently the properties file is hard to read. It has different locators 
from anywhere in the site put into one array, so you can't easily see whether a 
locator for the item you want already exists.
  3. The properties file could use a refactor. We were supporting an old PHP 
without constant arrays and constant multi-dimensional arrays when it was 
written.
  4. It is faster to write a test with the locators directly than adding the 
locator to the properties file, so test writers may still not use it.

  
  Suggested solutions to issues:

  
  1. Refactor existing tests with css/xpath locators to use the properties file.
  2,3. Update the properties file so that it has different arrays or a single 
multi-dimensional array with sections related to components of the site, 
something like: 
  define ("HEADER", array (
'Search'  =>'#usf_query',
//more things
  ));

  define ("DASHBOARD", array (
'Static pages' => "//a[contains(@href, 'site/pages')]/b",
//more things
  ));

  define ("FOOTER", array(
//more things
  ));

  define ("SIDEBLOCKS", array(
//more things
  ));

  define ("BLOCKS", array (
//more things
  ));


  4. Spend some time adding some more locators so they are covered and don't 
need to be added by the tester, as finding how to interact with an element is 
the slowest part of test writing.
  Consider the way the properties file is called. 
  - Is there an easier way than calling the properties steps? 
  - Could there be an underlying function that replaced passed in variables 
with locators called from all existing relevant steps? (Maybe that would create 
unnecessary overhead).
  - If there is a way that would make it easier to use the properties file from 
a dev/tester perspective, it will be used.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1897190/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1893591] Re: improve block dimension saving on DB

2020-10-21 Thread Rangi Daymond
Catalyst QA Testing - FAILED
Gerrit: https://reviews.mahara.org/#/c/11391/ patch set 3
Platforms: 
  ✘ Ubuntu-Firefox Theme: Raw
  ✘ Win10-Chrome Theme: Primary school
  ✘ Win10-Edge Theme: Default
  ✘ iOS14-Safari Theme: Default
  n/a Android10-Chrome Theme: Default

In all cases test scenario 1 test case 1.4 failed.  When the updated
page with two new blocks (first added after the existing one and the
second added before the existing one) was displayed, the newly added
blocks were automatically re-positioned incorrectly (in various ways -
please see comments on the patch).

When test scenario 4 was executed (new page, populate first block with
several paragraphs of text then resize it to use entire width of the
page, add block 2 to the bottom of the page and add block 3 to the top
of the page --> display the page) the same problems occurred.

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1893591

Title:
  improve block dimension saving on DB

Status in Mahara:
  In Progress

Bug description:
  When editing a page, the way we save the block dimensions is not efficient 
and can be improved.
  For example if we add a block in the page, we will have an ajax call for 
every block that is moved, when we could have only one call for all the grid.
  When resizing a block there are multiple ajax calls even before the resizing 
stops.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1893591/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1857936] Re: Lock page and artefact instructions

2020-10-21 Thread Robert Lyon
** Changed in: mahara
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1857936

Title:
  Lock page and artefact instructions

Status in Mahara:
  Fix Released

Bug description:
  At the moment, instructions can be added to a page and peer
  assessments. As per bug #1857931 it will also be possible to add
  instructions to other generic text blocks. Since instructions are
  written for assessment purposes, it shall not be possible for people
  to change these instructions once they copied a template to their
  personal portfolio area (or a group portfolio).

  • A new page setting “Template” is added to the “Advanced” panel on all 
portfolio page areas of Mahara (personal, group, institution, site) with a 
Yes/No switch.
  • When “Template” is set to “Yes”, people copying the page into their 
personal account will not be able to change any page or artefact instructions, 
no matter their role in Mahara.
  • A group administrator can remove the template lock also of copied pages, 
change instructions, and re-lock the instructions.
  • An institution and site administrator can also remove the template lock on 
pages on the institution level (institution administrator and site 
administrator) and site level (site administrator only) at any time.
  • When a portfolio author views the settings of a copied page, they do not 
see a greyed out “Yes” switch but a link to the original template instead with 
the title of that template linked. [Check with developer:] If the associated 
template is deleted, the text “Page deleted” is displayed. If the author does 
not have access to the template page any more even though it still exists, the 
link is still displayed but they see the normal “Access denied” message.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1857936/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1892794] Re: Allow local custom profile fields also be accessible via webservices

2020-10-21 Thread Robert Lyon
** Changed in: mahara
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1892794

Title:
  Allow local custom profile fields  also be accessible via webservices

Status in Mahara:
  Fix Released

Bug description:
  What is wanted:

  Have the mahara_user_external.php webservice function be able to set /
  fetch the information for local custom fields.

  Currently we have to hardcode in the extra fields in the _parameters()
  or _returns() functions

  It would be better if the local/lib/artefact_internal.php had a
  function to call to fetch webservice info for the local profile fields

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1892794/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1876177] Re: Allow mahara cli interface to accept multiple values for same flag

2020-10-21 Thread Robert Lyon
** Changed in: mahara
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1876177

Title:
  Allow mahara cli interface to accept multiple values for same flag

Status in Mahara:
  Fix Released

Bug description:
  This bug report is to allow the extending of the cli interface to
  accept multiple values from the same flag

  For example, currently if I were to go:

  sudo -u www-data php htdocs/admin/cli/sync_langpacks.php -l=de -l=fr
  -l=es

  It would only update the Spanish (es) language pack

  With this change it will allow three options to be read and treated as
  an array of de,fr,es

  and so update all three language packs

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1876177/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1857931] Re: Turn text block into "Quick edit" block

2020-10-21 Thread Robert Lyon
** Changed in: mahara
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1857931

Title:
  Turn text block into "Quick edit" block

Status in Mahara:
  Fix Released

Bug description:
  When learners work with templates that contain pre-defined text boxes,
  it will be beneficial when they don't have to enter edit mode to make
  their text additions. Instead, we are going to create a "Quick
  editing" functionality in the "Details" mode as a trial to see whether
  that functionality would be beneficial to the community.

  The origin of the idea stems from templated portfolios where nurses
  need to provide a self assessment and peers provide a peer assessment.
  Peers can simply enter their text on the page whereas a nurse needs to
  go into edit mode and click the configure icon before they can make
  changes. That makes it impossible for them to see any instructions on
  the page once they are in the configuration modal and thus they need
  to go in and out of them editing text.

  Instead of creating a new block type, the “Text” block type is
  revamped to support these new requirements and make it a versatile
  block to be used for other text purposes in the portfolio as well.

  Characteristics of the block:
  - The block can have instructions. When editing the block, the instructions 
are not immediately visible but hidden in a collapsible so that the content 
area is not too overwhelmed;
  - Portfolio owner can add text directly on the page in details mode rather 
than needing to enter edit mode;
  - When details mode is entered, portfolio owner sees the “Quick edit” option 
in the black bar that is shown at the top of a text block. They click “Quick 
edit” and the modal drawer is displayed from the right. A new function is 
created;
  - The extra things, i.e. instructions, tags, and retractable option, go into 
an “Advanced” panel when configuring the block;
  - In “Quick edit”, the instructions are displayed above the text box to be 
filled in like in the peer assessment block;
  - Portfolio owner can save their content as draft first so it's only visible 
to them and then publish it once completed so others can view it. They can 
still make changes afterwards, but all these changes will be visible to others 
instantly while in draft mode, only they can see them. Once the content has 
been published, it cannot be set back to draft;
  - It is still possible to edit text when opening the block in edit mode and 
clicking the “Configure block” icon, including draft and publish buttons.
  - Things not taken over from the peer assessment block:
-- Notifications about assessment;
-- Profile picture and date stamp of assessment as it's the portfolio 
author's own page.

  Note: Entering “Quick edit” via the details mode is chosen because one
  of the aims of Mahara 19.10 was to remove clutter from pages when they
  are viewed. That includes removing “Add comment” / “Details” links
  below artefacts that can have comments or have additional metadata.
  That information is still accessible via the details mode. When that
  mode is turned on, it is expected that work is to be done, e.g.
  commenting and reviewing comments.

  Adding the “Quick” edit into the details bar is an extension of that
  and a way towards making editing of blocks faster than in the past as
  the details mode can stay turned on even when a page is refreshed and
  a viewer or portfolio author navigates to another page.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1857931/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1873709] Re: Allow webservice wsdoc.php page to be public

2020-10-21 Thread Robert Lyon
** Changed in: mahara
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1873709

Title:
  Allow webservice wsdoc.php page to be public

Status in Mahara:
  Fix Released

Bug description:
  So that one can see what functions are available and how to access
  them

  Also show a list of available functions

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1873709/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1857933] Re: Portfolio completion progress page

2020-10-21 Thread Robert Lyon
** Changed in: mahara
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1857933

Title:
  Portfolio completion progress page

Status in Mahara:
  Fix Released

Bug description:
  When a portfolio is created for assessment purposes and uses sign-off
  and verification, it can receive a portfolio completion progress
  overview page.

  The first page of a portfolio contains a progress completion bar to
  indicate to the portfolio authors as well as others viewing the
  portfolio the status of completeness. The progress completion does not
  stop a user from submitting their portfolio for assessment. A
  collection can have the completion progress page when it is turned on
  in the collection settings (like SmartEvidence). The progress
  completion is activated in the institution settings, and then all
  collections can have the progress completion page.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1857933/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1876185] Re: Allow redis function without needing sentinel

2020-10-21 Thread Robert Lyon
** Changed in: mahara
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1876185

Title:
  Allow redis function without needing sentinel

Status in Mahara:
  Fix Released

Bug description:
  When redis was set up in mahara it was envisioned to be used with
  redis sentinel in a cluster situation

  But we should also allow redis to be usable without sentinel

  Looking at the code we probably need to adjust the get_redis_master()
  and get_redis_servers() functions in htdocs/auth/lib.php

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1876185/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1893291] Re: Undefined property: stdClass::$constraint_name error for MySql 8

2020-10-21 Thread Robert Lyon
** Changed in: mahara/19.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1893291

Title:
  Undefined property: stdClass::$constraint_name error for MySql 8

Status in Mahara:
  Fix Released
Status in Mahara 19.04 series:
  Fix Released
Status in Mahara 19.10 series:
  Fix Committed
Status in Mahara 20.04 series:
  Fix Committed
Status in Mahara 20.10 series:
  Fix Released

Bug description:
  The returned SQL result for checking find_key_name() for
  constraint_name has the column name in uppercase but we try to use it
  as $c->constraint_name (in lowercase)

  We need to check if property $c->CONSTRAINT_NAME exists and use that
  otherwise use $c->constraint_name

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1893291/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1883987] Re: Help Icon for authentication plugin not aligned properly

2020-10-21 Thread Robert Lyon
** Changed in: mahara/19.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1883987

Title:
  Help Icon for authentication plugin not aligned properly

Status in Mahara:
  Fix Released
Status in Mahara 19.04 series:
  Fix Released
Status in Mahara 19.10 series:
  Fix Committed
Status in Mahara 20.04 series:
  Fix Committed
Status in Mahara 20.10 series:
  Fix Released

Bug description:
  The Help icon for Admin Menu -> Institution settings -> Authentication
  plugin is not aligned properly with the content but is sitting below
  where it should be.

  To test:
  1. Log into Mahara as a site admin
  2. Navigate to Admin Menu -> Institution settings, select institution, view 
area for Authentication plugin
  Expected results:
  All visual content is aligned and consistent
  Actual results:
  The help icon for Authentication plugin is sitting below the area and is 
intersected by a horizontal line.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1883987/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1875492] Re: Add 'start' and 'end' date options to the default group page settings

2020-10-21 Thread Robert Lyon
** Changed in: mahara
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1875492

Title:
  Add 'start' and 'end' date  options to the default group page settings

Status in Mahara:
  Fix Released

Bug description:
  These settings are missing from admin/groups/settings.php page

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1875492/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1898643] Re: remove references to class used in old layout

2020-10-21 Thread Robert Lyon
** Changed in: mahara/20.10
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1898643

Title:
  remove references to class used in old layout

Status in Mahara:
  Fix Released
Status in Mahara 19.10 series:
  Fix Committed
Status in Mahara 20.04 series:
  Fix Committed
Status in Mahara 20.10 series:
  Fix Released

Bug description:
  Before gridstack layout, every time a block was moved in a page's edit
  mode, the background changed color to reflect that the block was being
  moved. This can be tested in 19.04 or older versions of Mahara.

  We don't do this anymore, so any reference to the css class "block-
  drop-on" needs to be removed from the code. Removing this class should
  not affect the styling of a block when it's being moved.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1898643/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1892449] Re: Behat: Improving resume_page.feature by loading resume information in the background

2020-10-21 Thread Robert Lyon
** Changed in: mahara
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1892449

Title:
  Behat: Improving resume_page.feature by loading resume information in
  the background

Status in Mahara:
  Fix Released

Bug description:
  instead of adding all the data manually, we can add some of it
  manually to test it works and the rest in the background

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1892449/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1875750] Re: Allow override of the HSTS setting if being set downstream

2020-10-21 Thread Robert Lyon
** Changed in: mahara
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1875750

Title:
  Allow override of the HSTS setting if being set downstream

Status in Mahara:
  Fix Released

Bug description:
  To avoid the Strict-Transport-Security header being set twice

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1875750/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1845053] Re: Increase base font size, update heading levels, use rem, and increase width

2020-10-21 Thread Robert Lyon
** Changed in: mahara
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1845053

Title:
  Increase base font size, update heading levels, use rem, and increase
  width

Status in Mahara:
  Fix Released

Bug description:
  As part of our accessibility review, we are going to increase the base
  font size from 14px to 16px. In addition, there are some elements that
  do not yet have font size variables. They will be changed to allow for
  flexibility.

  We'll also need to review the line height at the same time and the
  hover background and whether and if so where we are going to keep it.
  UX will be needed for that.

  All these changes are to be looked at alongside the WCAG 2.1
  guidelines after 20.10.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1845053/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1887450] Re: Block header buttons need better labels when Editing Pages

2020-10-21 Thread Robert Lyon
** Changed in: mahara/19.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1887450

Title:
  Block header buttons need better labels when Editing Pages

Status in Mahara:
  Fix Released
Status in Mahara 19.04 series:
  Fix Released
Status in Mahara 19.10 series:
  Fix Committed
Status in Mahara 20.04 series:
  Fix Committed
Status in Mahara 20.10 series:
  Fix Released

Bug description:
  It was found that the labels for the buttons that appear when editing
  a block on a page are not accurately described by a screen reader.
  The buttons are "Configure block" and "Remove block".  The "Remove
  block" button was entirely missing its label for screen readers, while
  the "Configure block" reads "Move block" instead of configure block.

  It looks like the 'sr-only' class needs to be applied correctly to the
  configure block button so that it misses the move button text and
  addresses its own purposes and for it to be applied to the remove
  block button in blocktypecontainerediting.tpl

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1887450/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1885982] Re: behat headless doesn't work with chrome 80

2020-10-21 Thread Robert Lyon
** Changed in: mahara/19.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1885982

Title:
  behat headless doesn't work with chrome 80

Status in Mahara:
  Fix Released
Status in Mahara 19.04 series:
  Fix Released
Status in Mahara 19.10 series:
  Fix Committed
Status in Mahara 20.04 series:
  Fix Committed
Status in Mahara 20.10 series:
  Fix Released

Bug description:
  patch for this here https://reviews.mahara.org/#/c/10785/5

  add -screen pixel depth and related xvfb params for bionic and chrome 80
fixes issue with chrome 80 and xvfb where default parameters (prob pixel 
depth)
makes chrome fail to connect to xvfb/selenium.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1885982/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1889340] Re: Adding indexes to tag table to speed things up

2020-10-21 Thread Robert Lyon
** Changed in: mahara/19.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1889340

Title:
  Adding indexes to tag table to speed things up

Status in Mahara:
  Fix Released
Status in Mahara 19.04 series:
  Fix Released
Status in Mahara 19.10 series:
  Fix Committed
Status in Mahara 20.04 series:
  Fix Committed
Status in Mahara 20.10 series:
  Fix Released

Bug description:
  To make requests to tags table faster

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1889340/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1883803] Re: Missing Help Text Icon: admin/site/menu.php

2020-10-21 Thread Robert Lyon
** Changed in: mahara/19.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1883803

Title:
  Missing Help Text Icon: admin/site/menu.php

Status in Mahara:
  Fix Released
Status in Mahara 19.04 series:
  Fix Released
Status in Mahara 19.10 series:
  Fix Committed
Status in Mahara 20.04 series:
  Fix Committed
Status in Mahara 20.10 series:
  Fix Released

Bug description:
  The Help icons are missing for "External link" and "Site file" on the
  "Menus" page (admin/site/menu.php) Admin menu -> Configure site ->
  Menus.

  To replicate:
  1. Log into Mahara as a site admin
  2. Navigate to the Menus page: Admin menu -> Configure Site -> Menus
  3. Set the Keyboard focus to the the radio button for "External link"
  4. Navigate the keyboard focus (tab once) and press enter
  5. Observe that the pop-up for the help text for "External link" will appear 
but does not have a help icon to distinguish it
  This happens with "Site file" as well.

  Another issue, is that when the cursor is hovered over the "External
  link" and "Site files" it changes to the cursor associated with
  mousing over links.

  Versions: Mahara 20.04, 19.10 19.04

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1883803/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1889341] Re: upgrade jquery 3.4.1 to 3.5.1

2020-10-21 Thread Robert Lyon
** Changed in: mahara/19.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1889341

Title:
  upgrade jquery 3.4.1 to 3.5.1

Status in Mahara:
  Fix Released
Status in Mahara 19.04 series:
  Fix Released
Status in Mahara 19.10 series:
  Fix Committed
Status in Mahara 20.04 series:
  Fix Committed
Status in Mahara 20.10 series:
  Fix Released

Bug description:
  Related to https://bugs.launchpad.net/mahara/+bug/1865115

  jquery is now at 3.5.1 and we are on 3.4.1.  Version 3.5.0 contained
  security fixes as described below:

  https://blog.jquery.com/2020/04/10/jquery-3-5-0-released/

  Change log:
  https://github.com/jquery/jquery/compare/3.4.1...3.5.1

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1889341/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1886593] Re: usr.active not changed when unexpiring a user from admin/user/edit.php screen

2020-10-21 Thread Robert Lyon
** Changed in: mahara/19.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1886593

Title:
  usr.active not changed when unexpiring a user from admin/user/edit.php
  screen

Status in Mahara:
  Fix Released
Status in Mahara 19.04 series:
  Fix Released
Status in Mahara 19.10 series:
  Fix Committed
Status in Mahara 20.04 series:
  Fix Committed
Status in Mahara 20.10 series:
  Fix Released

Bug description:
  When we expire a user their 'active' field in database usr table goes
  from 1 to 0 and if we un-expire them from the expired users list it
  sets it back to active correctly

  But if we try updating the user from admin/users/edit.php screen by
  adding / removing the expiry date in the form field it doesn't set the
  active value correctly

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1886593/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1892256] Re: Undefined variable: duplicates error when updating SAML metadata in SAML instance

2020-10-21 Thread Robert Lyon
** Changed in: mahara/19.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1892256

Title:
  Undefined variable: duplicates error when updating SAML metadata in
  SAML instance

Status in Mahara:
  Fix Released
Status in Mahara 19.04 series:
  Fix Released
Status in Mahara 19.10 series:
  Fix Committed
Status in Mahara 20.04 series:
  Fix Committed
Status in Mahara 20.10 series:
  Fix Released

Bug description:
  This is because we can't chain the db query result and finding the
  resultant object value in the same "if" statement

  We need to break this down into testable parts

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1892256/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1892660] Re: lti error when upgrading from 19.04 to 20.04

2020-10-21 Thread Robert Lyon
** Changed in: mahara/19.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1892660

Title:
  lti error when upgrading from 19.04 to 20.04

Status in Mahara 19.04 series:
  Fix Released
Status in Mahara 19.10 series:
  Fix Committed
Status in Mahara 20.04 series:
  Fix Committed

Bug description:
  If we're upgrading from an 19.04 install to a 20.04 version, there
  will be an error message in the upgrade page like the one copied
  below.

  This happens because we forgot to bump the lti plugin version number in the 
patch for the following bug
  https://bugs.launchpad.net/mahara/+bug/1795597

  As a result, any site upgrade that tries to also upgrade the lti
  plugin will try to run the postintall from the previous patch a second
  time, getting the error messages.

  Error messages during site upgrade:

  [DBG] 1b (module/lti/lib.php:30) Add indexes to lti_assessment table
  [DBG] 1b (lib/dml.php:180) mysqli error: [1061: Duplicate key name 
'mh2_ltiasse_res_ix'] in EXECUTE("CREATE INDEX mh2_ltiasse_res_ix ON 
mh2_lti_assessment (resourcelinkid(255))")Command was: CREATE INDEX 
mh2_ltiasse_res_ix ON mh2_lti_assessment (resourcelinkid(255))
  [WAR] 1b (lib/errors.php:859) Could not execute command: CREATE INDEX 
mh2_ltiasse_res_ix ON mh2_lti_assessment (resourcelinkid(255))
  Call stack (most recent first):

  log_message("Could not execute command: CREATE INDEX mh2_ltiass...", 8, 
true, true) at /home/ceciliavg/maharacode/mahara/htdocs/lib/errors.php:95
  log_warn("Could not execute command: CREATE INDEX mh2_ltiass...") at 
/home/ceciliavg/maharacode/mahara/htdocs/lib/errors.php:859
  SQLException->__construct("Could not execute command: CREATE INDEX 
mh2_ltiass...") at /home/ceciliavg/maharacode/mahara/htdocs/lib/dml.php:181
  execute_sql("CREATE INDEX mh2_ltiasse_res_ix ON mh2_lti_assessm...") at 
/home/ceciliavg/maharacode/mahara/htdocs/lib/dml.php:1661
  execute_sql_arr(array(size 1), true, true) at 
/home/ceciliavg/maharacode/mahara/htdocs/lib/ddl.php:1331
  add_index(object(XMLDBTable), object(XMLDBIndex)) at 
/home/ceciliavg/maharacode/mahara/htdocs/module/lti/lib.php:37
  PluginModuleLti::postinst("2018071009") at 
/home/ceciliavg/maharacode/mahara/htdocs/lib/mahara.php:1818
  call_static_method("PluginModuleLti", "postinst", "2018071009") at 
/home/ceciliavg/maharacode/mahara/htdocs/lib/upgrade.php:621
  upgrade_plugin(object(stdClass)) at 
/home/ceciliavg/maharacode/mahara/htdocs/admin/upgrade.json.php:84

  [DBG] 1b (lib/dml.php:180) mysqli error: [1061: Duplicate key name 
'mh2_ltiasse_con_ix'] in EXECUTE("CREATE INDEX mh2_ltiasse_con_ix ON 
mh2_lti_assessment (contextid(255))")Command was: CREATE INDEX 
mh2_ltiasse_con_ix ON mh2_lti_assessment (contextid(255))
  [WAR] 1b (lib/errors.php:859) Could not execute command: CREATE INDEX 
mh2_ltiasse_con_ix ON mh2_lti_assessment (contextid(255))
  Call stack (most recent first):

  log_message("Could not execute command: CREATE INDEX mh2_ltiass...", 8, 
true, true) at /home/ceciliavg/maharacode/mahara/htdocs/lib/errors.php:95
  log_warn("Could not execute command: CREATE INDEX mh2_ltiass...") at 
/home/ceciliavg/maharacode/mahara/htdocs/lib/errors.php:859
  SQLException->__construct("Could not execute command: CREATE INDEX 
mh2_ltiass...") at /home/ceciliavg/maharacode/mahara/htdocs/lib/dml.php:181
  execute_sql("CREATE INDEX mh2_ltiasse_con_ix ON mh2_lti_assessm...") at 
/home/ceciliavg/maharacode/mahara/htdocs/lib/dml.php:1661
  execute_sql_arr(array(size 1), true, true) at 
/home/ceciliavg/maharacode/mahara/htdocs/lib/ddl.php:1331
  add_index(object(XMLDBTable), object(XMLDBIndex)) at 
/home/ceciliavg/maharacode/mahara/htdocs/module/lti/lib.php:43
  PluginModuleLti::postinst("2018071009") at 
/home/ceciliavg/maharacode/mahara/htdocs/lib/mahara.php:1818
  call_static_method("PluginModuleLti", "postinst", "2018071009") at 
/home/ceciliavg/maharacode/mahara/htdocs/lib/upgrade.php:621
  upgrade_plugin(object(stdClass)) at 
/home/ceciliavg/maharacode/mahara/htdocs/admin/upgrade.json.php:84

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/19.04/+bug/1892660/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1863511] Re: Course completion block to show external data about course completions

2020-10-21 Thread Robert Lyon
** Changed in: mahara
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1863511

Title:
  Course completion block to show external data about course completions

Status in Mahara:
  Fix Released

Bug description:
  The creation of a blocktype 'courseinfo' that will display information
  from an external source relating to course completion.

  The information will be fetched via webservices where an external
  function/token will return information about a user based on the
  following criteria:

  1) The owner of the block (ie the owner of the page) will match up by 
username to the external system
  2) The external userid for the owner will then be recorded in the blocks 
configdata
  3) When anyone views the page once the userid is recorded the block will 
fetch the external course completion data and display it
  the data will consist of a json encoded packet that contains:
  - name The title of course
  - completiondate   When course was completed
  - courselength The amount of hours the course was
  - coursetype   What type of course it was
  - courseid The id of the course in the external system
  4) The data will show in the block paginated and with a courselength grand 
total

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1863511/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1888769] Re: Correct link to Badrg in 'Open Badges' block

2020-10-21 Thread Robert Lyon
** Changed in: mahara/19.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1888769

Title:
  Correct link to Badrg in 'Open Badges' block

Status in Mahara:
  Fix Released
Status in Mahara 19.04 series:
  Fix Released
Status in Mahara 19.10 series:
  Fix Committed
Status in Mahara 20.04 series:
  Fix Committed
Status in Mahara 20.10 series:
  Fix Released

Bug description:
  The link to Badgr in the 'Open Badges' configuration screen is wrong
  and points to the API, which is not going to be helpful for setting up
  an account. It should link to https://badgr.com instead.

  To replicate:

  1. Create a page with the 'Open Badges' block in it.
  2. In the block configuration check the link to Badgr.
  Expected result: Goes to https://badgr.com
  Actual result: Goes to https://api.badgr.io

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1888769/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1892790] Re: Google Apps Block unable to parse URL to google drive folder

2020-10-21 Thread Robert Lyon
** Changed in: mahara/19.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1892790

Title:
  Google Apps Block unable to parse URL to google drive folder

Status in Mahara:
  Fix Released
Status in Mahara 19.04 series:
  Fix Released
Status in Mahara 19.10 series:
  Fix Committed
Status in Mahara 20.04 series:
  Fix Committed
Status in Mahara 20.10 series:
  Fix Released

Bug description:
  Google Drive URLs aren't parsed correctly any more and don't display
  the Google Drive folder icon (or whatever needs to be displayed).

  For example, the folder https://drive.google.com/drive/folders/0B-V_s
  ... 00Y2JmLTkwNjUtZGM0ODJiZGNjYWEy has been shared publicly but on
  MyPortfolio (and also master) it only displays:

  "Unable to parse embedded code or URL:
  https://drive.google.com/drive/folders/0B-V_s ...
  0Y2JmLTkwNjUtZGM0ODJiZGNjYWEy"

  To replicate:
  1. Log in and create a page and select to create a "Google Apps" block
  2. In the "Embed code or URL" put the above url and save the block.
  Expected results:
  The block displays with icon etc... correctly
  Actual results:
  The block displays with "Unable to parse embedded code or URL: 
https://drive.google.com/drive/folders/0B-V_s9Ys157uZmFkY2RlOWMtNGY4Yy00Y2JmLTkwNjUtZGM0ODJiZGNjYWEy
 "

  Our regex is failing to parse this pattern and we'll need to add to it
  while keeping any necessary previous patterns for backwards
  compatibility.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1892790/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1892254] Re: Only SAML auth instance for metadata not active but can still see metadata choice on IdP discovery page

2020-10-21 Thread Robert Lyon
** Changed in: mahara
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1892254

Title:
  Only SAML auth instance for metadata not active but can still see
  metadata choice on IdP discovery page

Status in Mahara:
  Fix Released

Bug description:
  If we have the following:

  A site with a couple of institutions (Institution1 and Institution2)
  each having a SAML auth instance with different metadata (say IdP1 and
  IdP2)

  If Instance2 sets it's saml auth to not be active then we shouldn't
  expect to see the auth option on the IdP Discovery page (
  auth/saml/index.php  )

  We need to adjust the discovery page to only show the IdP's that are
  being used by 1 or more active SAML instances.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1892254/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1893159] Re: Dashboard widgets are not receiving customisable theme styling

2020-10-21 Thread Robert Lyon
** Changed in: mahara/19.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1893159

Title:
  Dashboard widgets are not receiving customisable theme styling

Status in Mahara:
  Fix Released
Status in Mahara 19.04 series:
  Fix Released
Status in Mahara 19.10 series:
  Fix Committed
Status in Mahara 20.04 series:
  Fix Committed
Status in Mahara 20.10 series:
  Fix Released

Bug description:
  Currently the Dashboard widgets for "Create", "Share" and "Engage" do
  not receive the styling carried over from an institution's
  customisable theme (see attached screen shot)

  To replicate:
  Have an institution and at least one member who has dashboard info showing 
(to see the widgets)
  1. Log in to site as administrator, in the Institution settings, select 
'Customisable theme' for Theme and select custom colours (default config theme 
colours are fine).
  2. Save the institution
  3. Log in as institution member and navigate to dashboard, hover over the 
dashboard widgets
  Expected results:
  The Dashboard widgets display in customised colours matching the header
  Actual results:
  The Dashboard widgets display in the Raw theme colours.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1893159/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1881677] Re: Give 3 options if new group name not unique

2020-10-21 Thread Robert Lyon
** Changed in: mahara
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1881677

Title:
  Give 3 options if new group name not unique

Status in Mahara:
  Fix Released

Bug description:
  As a member of a Mahara site
  I want assistance when the name I have chosen for my new group is not unique
  So that I can quickly choose one that is meaningful.

  Preconditions:
  Person1 has a group named 'MyGroup'.

  Steps:
  1. Person2 has logged in and navigated to 'Main menu' > 'Engage' > 'Groups'
  2. Person2 selects 'Create group'
  3. Person2 enters the value 'MyGroup' in the field 'Group name'
  4. Person2 selects to 'Save group'

  Actual result: (see attached screen shot) the error message 'A group
  by this name already exists.' is displayed underneath the field.

  Discussion (Tue 27 May 2020): 
  Question: If I am a student in an organisation/site that has 10,000+ other 
students. How am I going to know what I can meaningfully name my group? It 
could take ages trying things until I find one ?
  Response: This scenario is no different to signing up to a site with lots of 
users and trying to supply a username.
  We could add some code to give suggestions based on what they tried. If group 
name is already taken give 3 options in the error message returned.

  Alternatively, we could append a number to the clean URL of the group,
  e.g. instead of https://.../mygroup it'll be https://.../mygroup-1
  etc. if others already exist.

  Not everyone may want to change their group name significantly to make
  it very unique, esp. if the URL could handle that. When people search
  for groups, they'll always see who created it or is the admin and then
  choose the correct group.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1881677/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1886880] Re: behat check dependencies performance

2020-10-21 Thread Robert Lyon
** Changed in: mahara
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1886880

Title:
  behat check dependencies performance

Status in Mahara:
  Fix Released

Bug description:
  Everytime we have to run a behat test, we check composer dependencies
  by calling testing_update_dependencies() in testing/lib.php

  I think this should improve somehow by checking if we actually need to
  update dependencies, maybe by checking the hash on the file that gets
  installed and see if we actually need to run the dependencies check

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1886880/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 922911] Re: "Collections" email notification

2020-10-21 Thread Robert Lyon
** Changed in: mahara
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/922911

Title:
  "Collections" email notification

Status in Mahara:
  Fix Released

Bug description:
  Email notifications should be more descriptive. When a collection is
  shared, the notification email should say "a collection has been
  shared with you" (rather than just listing the first Page in the
  collection).

  Our students often share pages with their faculty mentors. We are
  trying to get students to use collections more, because they are often
  sharing 3-4 related pages with their mentor at a time.

  The faculty mentors are confused about whether or not each student is
  sharing individual pages with them, or a collection, because the
  notification emails do not differentiate between the two. When a
  students shares a collection, the faculty's notification email only
  lists the first page in the collection.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/922911/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1856824] Re: Ability to change old embedded urls into correct ones if the site changes domain name

2020-10-21 Thread Robert Lyon
** Changed in: mahara
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1856824

Title:
  Ability to change old embedded urls into correct ones if the site
  changes domain name

Status in Mahara:
  Fix Released

Bug description:
  If you have a Mahara site that has embedded content in description
  fields for example then if you change the URL of the site those
  embedded items will not show any more as the URL path is incorrect.

  You can fix most of this if you are a sysadmin by running queries on
  the database directly but there are other places that need to be fixed
  individually.

  It would be better to have an admin section page similar to cleanurls
  where one can check if there is any embedded content not using the
  current URL and if so allow one to switch content from old url to new
  url in a cleaner way

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1856824/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1867203] Re: Allow email links for recipients that need to login externally to redirect accordingly

2020-10-21 Thread Robert Lyon
** Changed in: mahara
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1867203

Title:
  Allow email links for recipients that need to login externally  to
  redirect accordingly

Status in Mahara:
  Fix Released

Bug description:
  Currently when Mahara sends a message to a user there usually a link
  that they can click to view the related page / part of Mahara that the
  email relates to.

  If the page needs authorisation the login box is displayed so they can
  login.

  But it can be confusing to the user that needs to login externally.

  Mahara currently has a $cfg->externallogin allowing the site to do a
  redirect on a site level to the correct login place . But if we have
  multiple institutions we may have multiple IdPs in play and so cannot
  do a redirect at the site level.

  However if the user authorises to Mahara via an external source, eg
  SAML Identity Provider (IdP) or LTI webservice, it would be more
  useful to redirect the user directly to the external place so they can
  login there on a per user basis.

  Also with SAML we can then redirect back and go to the URL that the
  email link wanted to go to.

  To do this:

  We will need to check that the user about to receive the email message
  has an external authinstance

  And if so we will need to append something to the email url address,
  eg authinstance id

  So that when they click on the link and go to Mahara it checks for
  that authinstance id and check internally to where they should be
  redirected to login

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1867203/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1895901] Re: Getting PHP Fatal error: Cannot redeclare serve_file() when using sync_langpacks

2020-10-21 Thread Robert Lyon
** Changed in: mahara/19.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1895901

Title:
  Getting PHP Fatal error:  Cannot redeclare serve_file() when using
  sync_langpacks

Status in Mahara:
  Fix Released
Status in Mahara 19.04 series:
  Fix Released
Status in Mahara 19.10 series:
  Fix Committed
Status in Mahara 20.04 series:
  Fix Committed
Status in Mahara 20.10 series:
  Fix Released

Bug description:
  This is because we are using require() instead of require_once() in
  sync_langpacks.php

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1895901/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1892106] Re: Allow webservices external apps to show configuration options based on functions it contains

2020-10-21 Thread Robert Lyon
** Changed in: mahara
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1892106

Title:
  Allow webservices external apps to show configuration options based on
  functions it contains

Status in Mahara:
  Fix Released

Bug description:
  Currently the LTI module has the ability to configure the following 2 options:
  - autocreateusers
  - parentauth

  And they are used in the module_lti_launch function.

  But if we make a custom webservice and include module_lti_launch as
  one of it's services we have no way (apart from directly on database)
  to set these options

  Currently the webservice/admin/oauthv1sregister.php page shows the config cog 
if a module has 
  has_oauth_service_config() set to true and displays the config form via 
get_oauth_service_config_options()

  But what we should have is some code that checks if the webservice
  contains functions that have config options and then display the
  button / form

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1892106/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1888743] Re: clean up references to old menu structure

2020-10-21 Thread Robert Lyon
** Changed in: mahara/19.04
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1888743

Title:
  clean up references to old menu structure

Status in Mahara:
  Fix Released
Status in Mahara 19.04 series:
  Fix Released
Status in Mahara 19.10 series:
  Fix Committed
Status in Mahara 20.04 series:
  Fix Committed
Status in Mahara 20.10 series:
  Fix Released

Bug description:
  Currently we still have some references to the old menu structure within 
Mahara.
  'myportfolio' and 'content' should both be updated to 'create'.

  Change: define(MENUITEM', 'myportfolio');
  To: define('MENUITEM', 'create');

  In the following files:
  relatedtags.php
  artefact/annotation/edit.php
  artefact/comment/edit.php
  artefact/peerassessment/edit.php

  In artefact/internal/socialprofile.php:
  Change: define('MENUITEM', 'content/profile');
  To: define('MENUITEM', 'create/files');

  In htdocs/lib/web.php:
  Change (ln 1476 in a comment): in_array(MENUITEM, array('myportfolio/view'))),
  To: in_array(MENUITEM, array('create/view'))),

  The old code was discovered when upgrading a site from 18.10 to 20.04.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1888743/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1895201] Re: Make Mahara available via Docker

2020-10-21 Thread Robert Lyon
** Changed in: mahara/20.10
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1895201

Title:
  Make Mahara available via Docker

Status in Mahara:
  Fix Released
Status in Mahara 20.10 series:
  Fix Released

Bug description:
  With more and more people using the cloud and containers to set up
  their applications, it would be good if Mahara were available via
  Docker. That also includes being able to run Behat tests via Docker.

  Separate services are set up via distinct containers.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1895201/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1898809] Re: replacing a block html after saving configuration needs to be done through gridstack functions

2020-10-21 Thread Robert Lyon
** Changed in: mahara/20.04
Milestone: 20.04.2 => 20.04.3

** Changed in: mahara/19.10
Milestone: 19.10.5 => 19.10.6

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1898809

Title:
  replacing a block html after saving configuration needs to be done
  through gridstack functions

Status in Mahara:
  Confirmed
Status in Mahara 19.10 series:
  Confirmed
Status in Mahara 20.04 series:
  Confirmed
Status in Mahara 20.10 series:
  Confirmed
Status in Mahara 21.04 series:
  Confirmed

Bug description:
  When replacing a block in the html after editing a block in a page 
  we need to do it by adding and removing a widget on the gridstack element, 
using the gridstack functions that come with the library.

  The way we do it now, we are just replacing the content of the DOM.
  Which is not ideal, the grid needs to have all the elements registered
  as gridstack items so it can handle them.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1898809/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1857382] Re: Remove WYSIWYG options for page description

2020-10-21 Thread Robert Lyon
** Changed in: mahara
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1857382

Title:
  Remove WYSIWYG options for page description

Status in Mahara:
  Fix Released

Bug description:
  In the past when the layout was not very flexible and we didn't have
  rows (i.e. a very long time ago), the page description text field
  was an important part of a page as it allowed people to create a
  section across an entire page of Mahara and use it as style element.
  People created banners in there and needed to have styling options
  available. That's why it has a visual editor with all the editing
  options.

  Now (well, for quite some time already actually) that we have a more
  flexible layout, we do not need this area anymore to style a page
  with. It also added to the confusion for some people as they thought
  that was the area where they would add their content.

  While the page description is shown on a page, the collection
  description is ignored (this may be a regression, but is OK).

  Since we have the "tiles" on "Pages and collections", the description
  shows up in the tile and is often cut off when it is too long and
  banners are not displayed in there either.

  I propose the following:

  1. Remove the visual editor from the page description.
  2. Limit the number of characters for the page and collection description to 
140 characters. That seems to fit in there (with our current font size).
  3. For existing sites, move the current page description content of pages to 
the first block on the page that goes across the entire width of the page and 
doesn't have a block heading. That way, the content is still displayed for 
pages that are used to displaying it, especially if the page uses the 
description as content styling element.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1857382/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1895477] Re: Allowing chosing existing SAML option without needing to supply XML

2020-10-21 Thread Robert Lyon
** Changed in: mahara
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1895477

Title:
  Allowing chosing existing SAML option without needing to supply XML

Status in Mahara:
  Fix Released

Bug description:
  If we are using the SAML refresh option then the refreshed SAML gets
  saved as a PHP array of information. We should be able to choose an
  IdP option from the list without having to also supply the XML markup
  for the instance to save the SAML config form.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1895477/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1889480] Re: Adding new Maroon theme

2020-10-21 Thread Robert Lyon
** Changed in: mahara
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1889480

Title:
  Adding new Maroon theme

Status in Mahara:
  Fix Released

Bug description:
  Adding a new theme called Maroon

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1889480/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


[Mahara-contributors] [Bug 1860380] Re: Add monitoring module to keep a track of fails like cron / elasticsearch / ldap

2020-10-21 Thread Robert Lyon
** Changed in: mahara
   Status: Fix Committed => Fix Released

-- 
You received this bug notification because you are a member of Mahara
Contributors, which is subscribed to Mahara.
Matching subscriptions: Subscription for all Mahara Contributors -- please ask 
on #mahara-dev or mahara.org forum before editing or unsubscribing it!
https://bugs.launchpad.net/bugs/1860380

Title:
  Add monitoring module to keep a track of fails like cron /
  elasticsearch / ldap

Status in Mahara:
  Fix Released

Bug description:
  To allow external monitoring systems check if certain
  functions/systems in Mahara are running smoothly or not.

  This way we can keep a track of the 'health' of a sites and get
  alerted if attention is needed.

To manage notifications about this bug go to:
https://bugs.launchpad.net/mahara/+bug/1860380/+subscriptions

___
Mailing list: https://launchpad.net/~mahara-contributors
Post to : mahara-contributors@lists.launchpad.net
Unsubscribe : https://launchpad.net/~mahara-contributors
More help   : https://help.launchpad.net/ListHelp


  1   2   3   >