[jira] [Assigned] (MAPREDUCE-6878) Method length of MRAppMaster #serviceInit() is too long

2019-06-27 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-6878?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Templeton reassigned MAPREDUCE-6878: --- Assignee: Yousef Abu-Salah > Method length of MRAppMaster

[jira] [Updated] (MAPREDUCE-7188) [Clean-up] Remove NULL check before instanceof and fix checkstyle issue in TaskResult

2019-03-18 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-7188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Templeton updated MAPREDUCE-7188: Resolution: Fixed Hadoop Flags: Reviewed Fix Version/s: 3.3.0

[jira] [Commented] (MAPREDUCE-7188) [Clean-up] Remove NULL check before instanceof and fix checkstyle issue in TaskResult

2019-03-06 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-7188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16786283#comment-16786283 ] Daniel Templeton commented on MAPREDUCE-7188: - Making the default constructor private

[jira] [Commented] (MAPREDUCE-7188) [Clean-up] Remove NULL check before instanceof and fix checkstyle issue in TaskResult

2019-03-05 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-7188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16785120#comment-16785120 ] Daniel Templeton commented on MAPREDUCE-7188: - Thanks, [~shwetayakkali]. It's a minor

[jira] [Assigned] (MAPREDUCE-7188) [Clean-up] Remove NULL check before instanceof and fix checkstyle issue in TaskResult

2019-03-05 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-7188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Templeton reassigned MAPREDUCE-7188: --- Assignee: Shweta > [Clean-up] Remove NULL check before instanceof and

[jira] [Comment Edited] (MAPREDUCE-7180) Relaunching Failed Containers

2019-03-01 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-7180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16782164#comment-16782164 ] Daniel Templeton edited comment on MAPREDUCE-7180 at 3/1/19 10:23 PM:

[jira] [Commented] (MAPREDUCE-7180) Relaunching Failed Containers

2019-03-01 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-7180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16782164#comment-16782164 ] Daniel Templeton commented on MAPREDUCE-7180: - This sounds like a fun discussion. Let me

[jira] [Commented] (MAPREDUCE-7172) Wildcard functionality of -libjar is broken when jars are located in same remote FS

2018-12-12 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-7172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16719005#comment-16719005 ] Daniel Templeton commented on MAPREDUCE-7172: - Playing around with a cluster a bit, I

[jira] [Commented] (MAPREDUCE-7007) Add LOG.isDebugEnabled() guard for each LOG.debug()

2017-11-13 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-7007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16250184#comment-16250184 ] Daniel Templeton commented on MAPREDUCE-7007: - It's probably worth it where there are

[jira] [Assigned] (MAPREDUCE-6837) Add an equivalent to Crunch's Pair class

2017-09-21 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-6837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Templeton reassigned MAPREDUCE-6837: --- Assignee: Peter Cseh > Add an equivalent to Crunch's Pair class >

[jira] [Commented] (MAPREDUCE-6870) Add configuration for MR job to finish when all reducers are complete (even with unfinished mappers)

2017-08-11 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-6870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16124318#comment-16124318 ] Daniel Templeton commented on MAPREDUCE-6870: - Good question. The change breaks the

[jira] [Created] (MAPREDUCE-6930) mapreduce.map.cpu.vcores and mapreduce.reduce.cpu.vcores are both present twice in mapred-default.xml

2017-08-02 Thread Daniel Templeton (JIRA)
Daniel Templeton created MAPREDUCE-6930: --- Summary: mapreduce.map.cpu.vcores and mapreduce.reduce.cpu.vcores are both present twice in mapred-default.xml Key: MAPREDUCE-6930 URL:

[jira] [Updated] (MAPREDUCE-6767) TestSlive fails after a common change

2017-07-22 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-6767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Templeton updated MAPREDUCE-6767: Fix Version/s: 3.0.0-alpha1 > TestSlive fails after a common change >

[jira] [Updated] (MAPREDUCE-6914) Tests use assertTrue(....equals(...)) instead of assertEquals()

2017-07-17 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-6914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Templeton updated MAPREDUCE-6914: Attachment: MAPREDUCE-6914.001.patch > Tests use assertTrue(equals(...))

[jira] [Updated] (MAPREDUCE-6914) Tests use assertTrue(....equals(...)) instead of assertEquals()

2017-07-17 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-6914?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Templeton updated MAPREDUCE-6914: Status: Patch Available (was: Open) > Tests use assertTrue(equals(...))

[jira] [Created] (MAPREDUCE-6914) Tests use assertTrue(....equals(...)) instead of assertEquals()

2017-07-17 Thread Daniel Templeton (JIRA)
Daniel Templeton created MAPREDUCE-6914: --- Summary: Tests use assertTrue(equals(...)) instead of assertEquals() Key: MAPREDUCE-6914 URL: https://issues.apache.org/jira/browse/MAPREDUCE-6914

[jira] [Updated] (MAPREDUCE-6896) Document wrong spelling in usage of MapredTestDriver tools.

2017-06-13 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-6896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Templeton updated MAPREDUCE-6896: Resolution: Fixed Hadoop Flags: Reviewed Fix Version/s: 3.0.0-alpha4

[jira] [Commented] (MAPREDUCE-6896) Document wrong spelling in usage of MapredTestDriver tools.

2017-06-07 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-6896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16041236#comment-16041236 ] Daniel Templeton commented on MAPREDUCE-6896: - LGTM +1 > Document wrong spelling in usage

[jira] [Assigned] (MAPREDUCE-6896) Document wrong spelling in usage of MapredTestDriver tools.

2017-06-07 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-6896?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Templeton reassigned MAPREDUCE-6896: --- Assignee: LiXin Ge > Document wrong spelling in usage of

[jira] [Created] (MAPREDUCE-6883) AuditLogger and TestAuditLogger are dead code

2017-05-03 Thread Daniel Templeton (JIRA)
Daniel Templeton created MAPREDUCE-6883: --- Summary: AuditLogger and TestAuditLogger are dead code Key: MAPREDUCE-6883 URL: https://issues.apache.org/jira/browse/MAPREDUCE-6883 Project: Hadoop

[jira] [Updated] (MAPREDUCE-6846) Fragments specified for libjar paths are not handled correctly

2017-04-05 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-6846?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Templeton updated MAPREDUCE-6846: Resolution: Fixed Hadoop Flags: Reviewed Fix Version/s: 3.0.0-alpha3

[jira] [Commented] (MAPREDUCE-6846) Fragments specified for libjar paths are not handled correctly

2017-03-31 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-6846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15951374#comment-15951374 ] Daniel Templeton commented on MAPREDUCE-6846: - Sorry, I have a couple more nits: # In

[jira] [Assigned] (MAPREDUCE-6848) MRApps.setMRFrameworkClasspath() unnecessarily declares that it throws IOException

2017-03-28 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-6848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Templeton reassigned MAPREDUCE-6848: --- Assignee: Wendy Turner (was: Daniel Templeton) >

[jira] [Comment Edited] (MAPREDUCE-6846) Fragments specified for libjar paths are not handled correctly

2017-03-24 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-6846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15941283#comment-15941283 ] Daniel Templeton edited comment on MAPREDUCE-6846 at 3/24/17 10:41 PM:

[jira] [Commented] (MAPREDUCE-6846) Fragments specified for libjar paths are not handled correctly

2017-03-24 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-6846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15941283#comment-15941283 ] Daniel Templeton commented on MAPREDUCE-6846: - What I meant was: {code} Path

[jira] [Assigned] (MAPREDUCE-6848) MRApps.setMRFrameworkClasspath() unnecessarily declares that it throws IOException

2017-03-21 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-6848?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Templeton reassigned MAPREDUCE-6848: --- Assignee: Daniel Templeton > MRApps.setMRFrameworkClasspath()

[jira] [Commented] (MAPREDUCE-6846) Fragments specified for libjar paths are not handled correctly

2017-03-20 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-6846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15933034#comment-15933034 ] Daniel Templeton commented on MAPREDUCE-6846: - Thanks, [~ctrezzo]. Here's my comments: #

[jira] [Created] (MAPREDUCE-6864) Hadoop streaming creates 2 mappers when the input has only one block

2017-03-17 Thread Daniel Templeton (JIRA)
Daniel Templeton created MAPREDUCE-6864: --- Summary: Hadoop streaming creates 2 mappers when the input has only one block Key: MAPREDUCE-6864 URL: https://issues.apache.org/jira/browse/MAPREDUCE-6864

[jira] [Updated] (MAPREDUCE-6825) YARNRunner#createApplicationSubmissionContext method is longer than 150 lines

2017-02-22 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-6825?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Templeton updated MAPREDUCE-6825: Resolution: Fixed Hadoop Flags: Reviewed Fix Version/s: 3.0.0-alpha3

[jira] [Commented] (MAPREDUCE-6825) YARNRunner#createApplicationSubmissionContext method is longer than 150 lines

2017-02-21 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-6825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15876729#comment-15876729 ] Daniel Templeton commented on MAPREDUCE-6825: - Looks good. I want to take one more pass

[jira] [Updated] (MAPREDUCE-6825) YARNRunner#createApplicationSubmissionContext method is longer than 150 lines

2017-02-20 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-6825?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Templeton updated MAPREDUCE-6825: Sounds good to me. > YARNRunner#createApplicationSubmissionContext method is

[jira] [Commented] (MAPREDUCE-6825) YARNRunner#createApplicationSubmissionContext method is longer than 150 lines

2017-02-15 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-6825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15868864#comment-15868864 ] Daniel Templeton commented on MAPREDUCE-6825: - Thanks for the updated patch,

[jira] [Created] (MAPREDUCE-6848) MRApps.setMRFrameworkClasspath() unnecessarily declares that it throws IOException

2017-02-15 Thread Daniel Templeton (JIRA)
Daniel Templeton created MAPREDUCE-6848: --- Summary: MRApps.setMRFrameworkClasspath() unnecessarily declares that it throws IOException Key: MAPREDUCE-6848 URL:

[jira] [Commented] (MAPREDUCE-6441) Improve temporary directory name generation in LocalDistributedCacheManager for concurrent processes

2017-02-07 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-6441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15857142#comment-15857142 ] Daniel Templeton commented on MAPREDUCE-6441: - Looks generally good to me. My only

[jira] [Updated] (MAPREDUCE-6842) Update the links in PiEstimator document

2017-02-07 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-6842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Templeton updated MAPREDUCE-6842: Resolution: Fixed Hadoop Flags: Reviewed Fix Version/s: 3.0.0-alpha3

[jira] [Commented] (MAPREDUCE-6825) YARNRunner#createApplicationSubmissionContext method is longer than 150 lines

2017-02-06 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-6825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15854425#comment-15854425 ] Daniel Templeton commented on MAPREDUCE-6825: - Thanks, [~GergelyNovak]. Some comments:

[jira] [Commented] (MAPREDUCE-6842) Update the links in PiEstimator document

2017-02-03 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-6842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15852427#comment-15852427 ] Daniel Templeton commented on MAPREDUCE-6842: - Jenkins in happy (enough). I'll commit it

[jira] [Commented] (MAPREDUCE-6842) Update the links in PiEstimator document

2017-02-03 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-6842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15852160#comment-15852160 ] Daniel Templeton commented on MAPREDUCE-6842: - LGTM +1 pending Jenkins not surprising us.

[jira] [Assigned] (MAPREDUCE-6841) Fix dead link in MapReduce tutorial document

2017-02-03 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-6841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Templeton reassigned MAPREDUCE-6841: --- Assignee: Victor Nee > Fix dead link in MapReduce tutorial document >

[jira] [Assigned] (MAPREDUCE-6842) Update the links in PiEstimator document

2017-02-03 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-6842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Templeton reassigned MAPREDUCE-6842: --- Assignee: Jung Yoo > Update the links in PiEstimator document >

[jira] [Assigned] (MAPREDUCE-6824) TaskAttemptImpl#createCommonContainerLaunchContext is longer than 150 lines

2017-02-01 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-6824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Templeton reassigned MAPREDUCE-6824: --- Assignee: Udai Kiran Potluri >

[jira] [Updated] (MAPREDUCE-6837) Add an equivalent to Crunch's Pair class

2017-01-26 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-6837?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Templeton updated MAPREDUCE-6837: Description: Crunch has this great {{Pair}} class

[jira] [Created] (MAPREDUCE-6837) Add an equivalent to Crunch's Pair class

2017-01-26 Thread Daniel Templeton (JIRA)
Daniel Templeton created MAPREDUCE-6837: --- Summary: Add an equivalent to Crunch's Pair class Key: MAPREDUCE-6837 URL: https://issues.apache.org/jira/browse/MAPREDUCE-6837 Project: Hadoop

[jira] [Updated] (MAPREDUCE-6808) Log map attempts as part of shuffle handler audit log

2017-01-25 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-6808?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Templeton updated MAPREDUCE-6808: Resolution: Fixed Hadoop Flags: Reviewed Fix Version/s: 3.0.0-alpha3

[jira] [Commented] (MAPREDUCE-6808) Log map attempts as part of shuffle handler audit log

2017-01-25 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-6808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15838716#comment-15838716 ] Daniel Templeton commented on MAPREDUCE-6808: - Sweet. +1 > Log map attempts as part of

[jira] [Commented] (MAPREDUCE-6808) Log map attempts as part of shuffle handler audit log

2017-01-24 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-6808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15836456#comment-15836456 ] Daniel Templeton commented on MAPREDUCE-6808: - Tiny nit, but can we make "mapper" be

[jira] [Updated] (MAPREDUCE-6715) Fix Several Unsafe Practices

2017-01-05 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-6715?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Templeton updated MAPREDUCE-6715: Resolution: Fixed Hadoop Flags: Reviewed Fix Version/s: 3.0.0-alpha2

[jira] [Updated] (MAPREDUCE-6715) Fix Several Unsafe Practices

2017-01-05 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-6715?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Templeton updated MAPREDUCE-6715: Summary: Fix Several Unsafe Practices (was: Fix Bad Practices) > Fix Several

[jira] [Commented] (MAPREDUCE-6715) Fix Bad Practices

2017-01-05 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-6715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15803071#comment-15803071 ] Daniel Templeton commented on MAPREDUCE-6715: - Yay! LGTM +1 I'll commit shortly. > Fix

[jira] [Commented] (MAPREDUCE-6715) Fix Bad Practices

2017-01-05 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-6715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15802758#comment-15802758 ] Daniel Templeton commented on MAPREDUCE-6715: - That part looks fine to me. I'm looking

[jira] [Commented] (MAPREDUCE-6715) Fix Bad Practices

2017-01-05 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-6715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15801651#comment-15801651 ] Daniel Templeton commented on MAPREDUCE-6715: - LGTM. About that pointless null check...

[jira] [Commented] (MAPREDUCE-6715) Fix Bad Practices

2017-01-03 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-6715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15795977#comment-15795977 ] Daniel Templeton commented on MAPREDUCE-6715: - Thanks for the updates. Just noticed a

[jira] [Resolved] (MAPREDUCE-6827) Failed to traverse Iterable values the second time in reduce() method

2017-01-03 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-6827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Templeton resolved MAPREDUCE-6827. - Resolution: Not A Problem That is known, documented, and intended behavior.

[jira] [Updated] (MAPREDUCE-5155) Race condition in test case TestFetchFailure cause it to fail

2016-12-29 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-5155?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Templeton updated MAPREDUCE-5155: Resolution: Fixed Hadoop Flags: Reviewed Fix Version/s: 3.0.0-alpha2

[jira] [Commented] (MAPREDUCE-5155) Race condition in test case TestFetchFailure cause it to fail

2016-12-28 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-5155?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15783963#comment-15783963 ] Daniel Templeton commented on MAPREDUCE-5155: - Looks good to me. +1. I'll commit

[jira] [Commented] (MAPREDUCE-6715) Fix Bad Practices

2016-12-28 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-6715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15783953#comment-15783953 ] Daniel Templeton commented on MAPREDUCE-6715: - Thanks, [~yufeigu]. Some comments: * In

[jira] [Comment Edited] (MAPREDUCE-6734) Add option to distcp to preserve file path structure of source files at the destination

2016-12-07 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-6734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15730367#comment-15730367 ] Daniel Templeton edited comment on MAPREDUCE-6734 at 12/8/16 12:24 AM:

[jira] [Commented] (MAPREDUCE-6734) Add option to distcp to preserve file path structure of source files at the destination

2016-12-07 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-6734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15730406#comment-15730406 ] Daniel Templeton commented on MAPREDUCE-6734: - Comments: * In {{CopyListing}}, I wouldn't

[jira] [Commented] (MAPREDUCE-6734) Add option to distcp to preserve file path structure of source files at the destination

2016-12-07 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-6734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15730367#comment-15730367 ] Daniel Templeton commented on MAPREDUCE-6734: - I meant the priority. > Add option to

[jira] [Commented] (MAPREDUCE-6734) Add option to distcp to preserve file path structure of source files at the destination

2016-12-07 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-6734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15730316#comment-15730316 ] Daniel Templeton commented on MAPREDUCE-6734: - Thanks, [~fctucker], for the patch. I'm

[jira] [Commented] (MAPREDUCE-4683) We need to fix our build to create/distribute hadoop-mapreduce-client-core-tests.jar

2016-12-07 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-4683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15730298#comment-15730298 ] Daniel Templeton commented on MAPREDUCE-4683: - Seems fine to me. +1 Shall we get this

[jira] [Commented] (MAPREDUCE-6704) Container fail to launch for mapred application

2016-12-07 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-6704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15730181#comment-15730181 ] Daniel Templeton commented on MAPREDUCE-6704: - Works for me. > Container fail to launch

[jira] [Commented] (MAPREDUCE-6704) Container fail to launch for mapred application

2016-11-22 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-6704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15687800#comment-15687800 ] Daniel Templeton commented on MAPREDUCE-6704: - Thanks, [~tangzhankun]. Just to be clear,

[jira] [Commented] (MAPREDUCE-6704) Container fail to launch for mapred application

2016-11-17 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-6704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15674297#comment-15674297 ] Daniel Templeton commented on MAPREDUCE-6704: - [~tangzhankun], you'll want to test with a

[jira] [Commented] (MAPREDUCE-6704) Container fail to launch for mapred application

2016-11-10 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-6704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15654241#comment-15654241 ] Daniel Templeton commented on MAPREDUCE-6704: - [~tangzhankun], I'm pretty surprised by

[jira] [Commented] (MAPREDUCE-6704) Container fail to launch for mapred application

2016-11-04 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-6704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15638066#comment-15638066 ] Daniel Templeton commented on MAPREDUCE-6704: - The patch looks fine. I'm OK with this

[jira] [Commented] (MAPREDUCE-6704) Container fail to launch for mapred application

2016-11-02 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-6704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15629641#comment-15629641 ] Daniel Templeton commented on MAPREDUCE-6704: - Yep. I was planning to submit a JIRA this

[jira] [Commented] (MAPREDUCE-6704) Container fail to launch for mapred application

2016-11-01 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-6704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15625447#comment-15625447 ] Daniel Templeton commented on MAPREDUCE-6704: - Since this is a rather core issue, I'd love

[jira] [Commented] (MAPREDUCE-6704) Container fail to launch for mapred application

2016-10-28 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-6704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15615461#comment-15615461 ] Daniel Templeton commented on MAPREDUCE-6704: - As if we're not split enough on this

[jira] [Comment Edited] (MAPREDUCE-6704) Container fail to launch for mapred application

2016-10-28 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-6704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15612421#comment-15612421 ] Daniel Templeton edited comment on MAPREDUCE-6704 at 10/28/16 1:39 PM:

[jira] [Comment Edited] (MAPREDUCE-6704) Container fail to launch for mapred application

2016-10-27 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-6704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15612421#comment-15612421 ] Daniel Templeton edited comment on MAPREDUCE-6704 at 10/27/16 4:30 PM:

[jira] [Commented] (MAPREDUCE-6704) Container fail to launch for mapred application

2016-10-27 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-6704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15612421#comment-15612421 ] Daniel Templeton commented on MAPREDUCE-6704: - +1 to #3. A agree with [~aw] that a little

[jira] [Commented] (MAPREDUCE-6728) Give fetchers hint when ShuffleHandler rejects a shuffling connection

2016-10-21 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-6728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15596254#comment-15596254 ] Daniel Templeton commented on MAPREDUCE-6728: - Thanks, [~haibochen]. Latest patch looks

[jira] [Commented] (MAPREDUCE-6728) Give fetchers hint when ShuffleHandler rejects a shuffling connection

2016-10-06 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-6728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15552572#comment-15552572 ] Daniel Templeton commented on MAPREDUCE-6728: - Sorry to string this out. I just caught

[jira] [Updated] (MAPREDUCE-6728) Give fetchers hint when ShuffleHandler rejects a shuffling connection

2016-10-06 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-6728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Templeton updated MAPREDUCE-6728: Status: Open (was: Patch Available) > Give fetchers hint when ShuffleHandler

[jira] [Updated] (MAPREDUCE-6789) TestAMWebApp fails

2016-10-05 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-6789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Templeton updated MAPREDUCE-6789: Status: Patch Available (was: Open) > TestAMWebApp fails > --

[jira] [Updated] (MAPREDUCE-6789) TestAMWebApp fails

2016-10-05 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-6789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Templeton updated MAPREDUCE-6789: Attachment: MAPREDUCE-6789.001.patch This should resolve the issue. >

[jira] [Assigned] (MAPREDUCE-6789) TestAMWebApp fails

2016-10-04 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-6789?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Templeton reassigned MAPREDUCE-6789: --- Assignee: Daniel Templeton > TestAMWebApp fails > -- > >

[jira] [Commented] (MAPREDUCE-6789) TestAMWebApp fails

2016-10-04 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-6789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15545498#comment-15545498 ] Daniel Templeton commented on MAPREDUCE-6789: - This is from YARN-4767. I'll look into it.

[jira] [Commented] (MAPREDUCE-6728) Give fetchers hint when ShuffleHandler rejects a shuffling connection

2016-10-03 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-6728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15542927#comment-15542927 ] Daniel Templeton commented on MAPREDUCE-6728: - Thanks, [~haibochen]! The patch looks

[jira] [Commented] (MAPREDUCE-6783) Default setting 'inheritParentEnv=false' caused mr executor failed to initialize

2016-09-28 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-6783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15529736#comment-15529736 ] Daniel Templeton commented on MAPREDUCE-6783: - Looks like it to me. > Default setting

[jira] [Commented] (MAPREDUCE-6728) Give fetchers hint when ShuffleHandler rejects a shuffling connection

2016-09-21 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-6728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15510648#comment-15510648 ] Daniel Templeton commented on MAPREDUCE-6728: - Thanks for the patch, [~haibochen].

[jira] [Commented] (MAPREDUCE-6765) MR should not schedule container requests in cases where reducer or mapper containers demand resource larger than the maximum supported

2016-09-16 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-6765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15496819#comment-15496819 ] Daniel Templeton commented on MAPREDUCE-6765: - LGTM. +1 (non-binding) > MR should not

[jira] [Updated] (MAPREDUCE-6776) yarn.app.mapreduce.client.job.max-retries should have a more useful default

2016-09-12 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-6776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Templeton updated MAPREDUCE-6776: Description: The default is 0, so any communication failure results in a client

[jira] [Created] (MAPREDUCE-6776) yarn.app.mapreduce.client.job.max-retries should have a more useful default

2016-09-12 Thread Daniel Templeton (JIRA)
Daniel Templeton created MAPREDUCE-6776: --- Summary: yarn.app.mapreduce.client.job.max-retries should have a more useful default Key: MAPREDUCE-6776 URL: https://issues.apache.org/jira/browse/MAPREDUCE-6776

[jira] [Commented] (MAPREDUCE-6765) MR should not schedule container requests in cases where reducer or mapper containers demand resource larger than the maximum supported

2016-09-07 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-6765?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15471227#comment-15471227 ] Daniel Templeton commented on MAPREDUCE-6765: - I share Djikstra's dislike of multiple exit

[jira] [Resolved] (MAPREDUCE-6560) ClientServiceDelegate doesn't handle retries during AM restart as intended

2016-08-31 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-6560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Templeton resolved MAPREDUCE-6560. - Resolution: Invalid Looks like I was just wrong. > ClientServiceDelegate

[jira] [Updated] (MAPREDUCE-6632) Master.getMasterAddress() should be updated to use YARN-4629

2016-08-28 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-6632?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Templeton updated MAPREDUCE-6632: Status: Patch Available (was: Open) > Master.getMasterAddress() should be

[jira] [Updated] (MAPREDUCE-6632) Master.getMasterAddress() should be updated to use YARN-4629

2016-08-28 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-6632?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Templeton updated MAPREDUCE-6632: Attachment: MAPREDUCE-6632.001.patch This patch adds a dependency from

[jira] [Commented] (MAPREDUCE-6767) TestSlive fails after a common change

2016-08-24 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-6767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15435883#comment-15435883 ] Daniel Templeton commented on MAPREDUCE-6767: - Oops. Thanks, [~chris.douglas]. >

[jira] [Updated] (MAPREDUCE-6767) TestSlive fails after a common change

2016-08-24 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-6767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Templeton updated MAPREDUCE-6767: Attachment: MAPREDUCE-6767.001.patch This resolves the Slive failures. >

[jira] [Assigned] (MAPREDUCE-6767) TestSlive fails after a common change

2016-08-24 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-6767?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Templeton reassigned MAPREDUCE-6767: --- Assignee: Daniel Templeton > TestSlive fails after a common change >

[jira] [Commented] (MAPREDUCE-6767) TestSlive fails after a common change

2016-08-24 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-6767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15435619#comment-15435619 ] Daniel Templeton commented on MAPREDUCE-6767: - Any details you can give? > TestSlive

[jira] [Commented] (MAPREDUCE-6761) Regression when handling providers - invalid configuration ServiceConfiguration causes Cluster initialization failure

2016-08-18 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-6761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15427613#comment-15427613 ] Daniel Templeton commented on MAPREDUCE-6761: - Thanks for the patch, [~pvary]!

[jira] [Commented] (MAPREDUCE-6724) Unsafe conversion from long to int in MergeManagerImpl.unconditionalReserve()

2016-07-18 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-6724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15383221#comment-15383221 ] Daniel Templeton commented on MAPREDUCE-6724: - LGTM. +1 > Unsafe conversion from long to

[jira] [Commented] (MAPREDUCE-6724) Unsafe conversion from long to int in MergeManagerImpl.unconditionalReserve()

2016-07-18 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-6724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15383085#comment-15383085 ] Daniel Templeton commented on MAPREDUCE-6724: - Works for me. I'd not say that the value

[jira] [Commented] (MAPREDUCE-6724) Unsafe conversion from long to int in MergeManagerImpl.unconditionalReserve()

2016-07-13 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-6724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15375783#comment-15375783 ] Daniel Templeton commented on MAPREDUCE-6724: - Thanks for the patch, [~haibochen]! A

[jira] [Commented] (MAPREDUCE-6725) Comment for CLI#listEvents() contains no-existent param

2016-06-24 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-6725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15348289#comment-15348289 ] Daniel Templeton commented on MAPREDUCE-6725: - [~ajisakaa], got time for a quickie? >

[jira] [Commented] (MAPREDUCE-6725) Comment for CLI#listEvents() contains no-existing param

2016-06-23 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-6725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15347599#comment-15347599 ] Daniel Templeton commented on MAPREDUCE-6725: - Works for me. +1 (non-binding) > Comment

[jira] [Commented] (MAPREDUCE-6725) Comment for CLI#listEvents() contains no-existing param

2016-06-23 Thread Daniel Templeton (JIRA)
[ https://issues.apache.org/jira/browse/MAPREDUCE-6725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15346452#comment-15346452 ] Daniel Templeton commented on MAPREDUCE-6725: - Thanks, [~shenyinjie]! Would you mind also

  1   2   >