[
https://issues.apache.org/jira/browse/MAPREDUCE-7188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16785120#comment-16785120
]
Daniel Templeton commented on MAPREDUCE-7188:
---------------------------------------------
Thanks, [~shwetayakkali]. It's a minor thing, but splitting lines on the dot
is a Scala thing, and we're not writing Scala. It's been slowly creeping into
our source base, but I'd rather not encourage it. Also, are you sure the
{{TaskResult()}} constructor is unused? Sometimes a default constructor is
there to enable instance creation through reflection or for Serialization
purposes. Unit tests might not catch those. Unless you have a good reason to
remove it, I'd leave it.
> [Clean-up] Remove NULL check before instanceof and fix checkstyle issue in
> TaskResult
> -------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-7188
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-7188
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Reporter: Shweta
> Assignee: Shweta
> Priority: Minor
> Attachments: MAPREDUCE-7188.001.patch, MAPREDUCE-7188.002.patch,
> MAPREDUCE-7188.003.patch
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
