Michael Widenius writes:
>
> revno: 2992
> revision-id: mo...@askmonty.org-20110517214756-6f7fv5uk68i4hb3b
> parent: sa...@askmonty.org-20110516132109-h2g9qzrfq3g9t6em
> committer: Michael Widenius
> branch nick: maria-5.3
> timestamp:
Daniel Bartholomew writes:
> I found Kristian's email that he sent me a long while back regarding
> how to determine the correct build number for a release. The link he
> gave me was this one (well, he gave me a 5.1 link, so I've updated it to
> 5.2):
>
> http://buildbot.askmonty.org/buildbot/gri
Arjen Lentz writes:
> It's a serious case for having CRCs in the binlog (yes I know it's put in
> from Google patches to later versions in 5.5+ but I really want it in
> MariaDB, urgently!), but also as a potential consideration for other
> communications, including client/server.
http://
Michael Widenius writes:
>> "Sergei" == Sergei Golubchik writes:
> Sergei> please create a macro extension_set(), and rewrite
> Sergei> extension_set_string() to use extension_set(). Something like
>
> Sergei> #define extension_set(OPTS, X, VAL) \
> Sergei>
Vladislav Vaintroub writes:
> Fix compiling on Windows.
Thanks for your help! I'm now merging this into the MWL#192 tree.
All the changes are good, but I would like your help to understand a couple of
them:
> === modified file 'client/async_example.c'
> --- a/client/async_example.c 2011-06
Thanks for the excellent explanations, all is clear now. Looks like you saved
me a few hours of head-scratching there ;-)
- Kristian.
___
Mailing list: https://launchpad.net/~maria-developers
Post to : maria-developers@lists.launchpad.net
Unsubscri
Hi Serg,
Can you review below patch? (sorry for no commit mail, I forgot to configure
outgoing mail on my new laptop before committing).
I was for a long time annoyed that mtr takes 20 seconds starting up before it
starts running the first test. So being bored one evening I ran a Perl
profiler on
Sergei Golubchik writes:
> Just one question and couple of suggestions below.
> If you agree with them - please change accordingly and push!
Thanks for review! I believe I addressed all your suggestions.
Comments below.
- Kristian.
>> + $base_dir= dirname($file)
>> +unless defined($base_
planas writes:
> If I try
> sudo /etc/init.d/mysql start I get
>
> * Starting MariaDB database server mysqld
> [fail]
The first step is to check /var/log/daemon.log for all error messages from
mysqld, they will likely explain what the problem is.
The most common cause of this kind of problem i
Monty, thanks for review!
I followed all your suggestions I believe and will push to 5.5 when current
merge is over.
- Kristian.
Michael Widenius writes:
> We agree to change the name of replicate-ignore-do-not-replicate
> variable to just 'replicate' with a default value of 1.
Yes (in the e
"Philip Stoev" writes:
> Bug https://bugs.launchpad.net/maria/+bug/824463, which is in state
> "Fix Committed", is still present. I assume it is waiting for a
> review. There may be others like it.
I think we are using "Fix committed" and "Fix released" somewhat
inconsistently. I see two differe
"Vladislav Vaintroub" writes:
> It is my own perception, but I feel the code got severely obfuscated through
> wrapper macros, and thus will be really hard to debug. Myself, I'd prefer
> it in a C/C++ source file, without macros (yes, it is means repetition, but
> I would not expect the result t
"Vladislav Vaintroub" writes:
> Hmm I missed something when reading this code. The wrapper macros are for
> internal testing use, for part of the API, they won't be debugged often,
> and not included into 2 different source files. Thus its usage seems ok now
> to me.
Ah ok, I'll leave them the
MARK CALLAGHAN writes:
> Why does this need to save/restore thread contexts (setcontext, etc)?
> I think that if the library is that hard to change then it should be
> fixed or a simpler solution should be attempted.
In general, when implementing non-blocking semantics like this, there are two
m
Daniel Bartholomew writes:
> First, I need one of the developers to tag the release in the source
> tree:
>
> http://bazaar.launchpad.net/~maria-captains/maria/5.2/changes
Done.
> Second, I need to know if there is anything that I should be sure to
> mention in the release notes. One thing I ca
MARK CALLAGHAN writes:
> getcontext is slow because it saves everything --FP regs, SSE regs,
> signal handlers. It was safe for RethinkDB to skip saving them but
The expensive part is signal handlers, as it requires a system call.
> they are not providing a library that can run in a wide variet
MARK CALLAGHAN writes:
> On Fri, Sep 23, 2011 at 4:32 AM, Kristian Nielsen
> wrote:
>> In general, when implementing non-blocking semantics like this, there are two
>> main approaches:
>>
>> 1. Write the code in event-driven style. This means using some kind of
Hi Serg,
Here is the status of my efforts to merge the rpl,binlog, and innodb suites.
These are the tests that still fail after my last pust to 5.5-serg:
binlog.binlog_innodb_row
This fails because of a problem in my merge of group commit, I will fix.
binlog.binlog_killed
I do not know
Oleksandr Byelkin writes:
> 26.10.2011 22:18, Michael Widenius пишет:
> [skip]
>>
>> === modified file 'storage/pbxt/src/thread_xt.cc'
>> --- a/storage/pbxt/src/thread_xt.cc 2010-09-28 13:05:45 +
>> +++ b/storage/pbxt/src/thread_xt.cc 2011-10-25 14:24:24 +
>> @@ -485,7 +485,8 @@ static
Oleksandr Byelkin writes:
> 27.10.2011 15:29, Kristian Nielsen пишет:
>> Oleksandr Byelkin writes:
>>
>>> 26.10.2011 22:18, Michael Widenius пишет:
>>> [skip]
>>>> === modified file 'storage/pbxt/src/thread_xt.cc'
>>>> -
Hi Daniel,
I believe I've fixed the issues for our .debs on Ubuntu 11.10.
I made buildbot create packages for MariaDB 5.2.9. They pass the tests.
Buildnumber: 1325
Location in archive: /archive/pack/5.2/build-1325/kvm-deb-oneiric-*
Maybe you can make them available alongside the existing 5.2.9
Marian Marinov writes:
> I'm trying to build MariaDB packages for CentOS.
> But the problem I have is that the Policy of the distro does not allow
> packages that are drop-in replacements of core packages.
> Meaning that I can not simply build MariaDB which will provide libmysqlclient
> and mys
Daniel Bartholomew writes:
> The MariaDB 5.2 Ubuntu packages are only available through the 5.2
> repositories. I think the easiest way to add the new Oneiric packages
> will be to use the mkrepo-ubuntu.sh script to regenerate the entire
> Ubuntu 5.2 repo. It appears build-1325 has all of the Ubu
Hi Serg,
If you remember, in Athens, we discovered that the feedback plugin is missing
from 5.1 .debs.
I fixed and pushed this (in the ourdelta scripts). I restarted latest 5.1
buildbot for this, and it seems to work.
So just a FYI ...
- Kristian.
_
Hi Wlad,
I got some progress with Buildbot and producing binary tarball packages for
MariaDB 5.5, using your suggestions.
But I encountered a problem. I used -DBUILD_CONFIG=mysql-release and installed
libaio-dev. But then the server fails like this:
./bin/mysqld: error while loading shared libra
I have been doing a bit of preparation/planning for the upcoming merge of
MySQL 5.6.
I think the 5.6 merge (and 5.5 merge) is very important for MariaDB. There is
much stuff in there that we really need to make available to our users (and
probably some better left out). If we fail to keep the merg
Hi Monty,
While fixing test failures in the MariaDB 5.5 tree, I encountered problems in
sql_string, related to changes you did there in 5.2. I managed to come up with
some solution, but please see below patch and see if you can suggest something
better.
Two issues:
1. You added realloc_with_ext
Hi Paul,
It seems a patch is needed for PBXT to build on 32-bit x86 in some cases:
Elena Stepanova writes:
> lock_xt.h: Assembler messages:
> lock_xt.h:70: Error: bad register name `%sil'
> After some re-installation and long digging, I found the ancient bug
> report http://gcc.gnu.org/bugzill
Sergei Petrunia writes:
> We have a repeatable failure like this:
>
> https://internal.askmonty.org/buildbot/builders/gcov/builds/830/steps/test_1/logs/stdio
> innodb_plugin.innodb_gis w3 [ fail ]
> Test ended at 2011-12-14 06:52:31
>
> CURRENT_TEST: innodb_plugin.innodb_g
Here is a patch for XtraDB (from Percona Server 5.5.17-rel22.1).
We needed this in MariaDB 5.5 to compile on Windows. The problem is that this
compiler apparently does not like having #ifdef inside macro invocations.
I thought Percona might want to include it upstream, in case there are other
com
Hi Serg,
As promised, here a summary of what I did to fix PAM in linux packages. I
managed to fix most issues I think (except for RHEL5 as noted below), but it
needs testing, which takes time due to waiting for Buildbot.
- I installed libpam0g-dev in all the VMs for .deb and bintar packages. I
I learned that there were many test failures with packages in 5.3.
I think it may be due to the version in configure.in not being increased after
last release. I pushed a commit that changes it to 5.3.4-rc, we will see if it
helps.
- Kristian.
___
Mai
Michael Widenius writes:
>> "knielsen" == knielsen writes:
> knielsen> timestamp: Tue 2011-09-20 12:49:25 +0200
> knielsen> message:
> knielsen> MWL#192: Non-blocking client API for libmysqlclient.
Hi Monty,
You probably remember this review even less than I ... the short summary is
th
Hi Serg!
As promised, I read through your MDEV-30, "mtr extensions for storage engine
testing".
Generally I think it looks good and reasonable. Here are a few comments:
- --record should have options so that it can generate .rdiff or
.COMBI.result. So one could say eg. ./mtr --record=rdiff
writes:
> At http://bazaar.launchpad.net/~maria-captains/maria/5.1/
>
>
> revno: 3129
> revision-id: ser...@pisem.net-20120124140839-iziwgt30gaalsiw9
> parent: ser...@pisem.net-20120124125357-b3o68crdtg2w3fzj
> committer: Sergei Golubch
Hi Serg,
As you suggested, I compared .deb file contents with what `make install`
produces in 5.5.
I discovered that the following files are missing from .debs. I need help
understanding which of these should be added to the .debs. (I think anything
added should be to package libmariadbclient-dev
Sergei Golubchik writes:
> In general, the direction I'm moving in is to remove as much of
> hard-coded special cases from mtr as possible.
Sure, but these extra checks for skip in mtr_cases are not hard-coded special
cases, they are optimisations to speed up the suite. They don't change
semanti
Arun Sharma writes:
> On 1/21/12 7:24 AM, Mark Callaghan wrote:
>> 1 millisecond per thread would be much better than what we experience
>> today.
>>
>
> Is there a reason why latency per-thread is more interesting than the
> absolute number?
You are right of course - the interesting number is t
Sergei Golubchik writes:
> On Jan 25, Kristian Nielsen wrote:
> Are you sure all these headers are missing? I'd suspect they're
> installed by libmariadbclient-dev, although not in /usr/include, but in
> /usr/include/mysql.
Yes, libmariadbclient-dev has a bunch of headers
Kristian Nielsen writes:
> So if I understand you correctly, you are saying that libmariadbclient-dev
> should install every .h file that `make install` does.
Do we really have to do this?
Eg. files like these:
/usr/local/mysql/include/decimal.h
/usr/local/mysql/include/er
Sergei Golubchik writes:
> Hi, Kristian!
>
> On Jan 25, Kristian Nielsen wrote:
>> Kristian Nielsen writes:
>>
>> > So if I understand you correctly, you are saying that libmariadbclient-dev
>> > should install every .h file that `make install` do
Just to finish our discussions on IRC...
I found that mysql_client_test.test runs fine without any --plugin-dir=xxx
option at all for mysql_client_test.
The reason is that the correct option is in the my.cnf that we generate.
So I decided to just remove the --plugin-dir option from the command l
Vladislav Vaintroub writes:
> Xtradb recently started to access thd members directly ,e.g thd->stmt_da
> (ha_innodb.cc)
> It needs recompilation for embedded server, as layout of THD is different
> in embedded.
Did you consider instead fixing XtraDB to not access thd members directly?
Eg.
Sergei Petrunia writes:
> I see MySQL have added an analog ours
> http://kb.askmonty.org/en/annotate_rows_log_event
>
> http://dev.mysql.com/doc/refman/5.6/en/replication-options-binary-log.html#sysvar_binlog_rows_query_log_events
>
> The names of the options are different: binlog_annotate_row_ev
Sergei Petrunia writes:
> Also, it seems that right now binary logs are not compatible between mysql-5.6
> and mariadb-5.3. When I try read one file with mysqlbinlog of the other I get
> this:
>
>
> mariadb-5.3 reading binlog from mysql-5.6
> #120131 2:43:14 server id 1 end_log_pos 295
Hi Serg,
5.5 Buildbot is getting greener, but there are still a couple of random
failures left.
One of them is in plugins.feedback_plugin_send:
---
plugins.feedback_plugin_send w1 [ fail ]
Test ended at 2012-
Hi Daniel,
I have pushed MWL#192 to 5.5.21. This introduces a minor change in
functionality. I hope you can find a good place to put this in the
documentation/knowledgebase. Here is suggested text, let me know if you have
questions, and feel free to improve the text as you like:
"In MySQL, an
Hi Daniel!
I have pushed MWL#192. It will be included in upcoming MariaDB 5.5.21.
So we need documentation of the feature :-)
I have written a first draft of this. I included it in the high-level
description in the WL:
http://askmonty.org/worklog/Client-Sprint/?tid=192#hld
There are two th
Hi Serg,
I'm merging MWL#234 into 5.5.
I have a session variable @@skip_replication. I want to ensure that this
variable is not modified in the middle of a statement or while a transaction
is active.
(The reason for this is that it changes whether changes are replicated or not
- and so changing
Davi Arnaut writes:
>>> I have a session variable @@skip_replication. I want to ensure that this
>>> variable is not modified in the middle of a statement or while a transaction
>>> is active.
> Copy and paste fail. I meant THD::in_multi_stmt_transaction_mode. Try
> to avoid using the flag direc
Terin Stock writes:
> MariaDB 5.3.5, 5.2.10 and possibly other versions, fails to compile using
> Apple's Clang compiler. As of Xcode 4.3, Clang is the default compiler,
> replacing LLVM-GCC.
>
> The issue seems to occur when checking for an ABI incompatibility in mysql.h.
> As Clang preproce
Hi Daniel,
Here is another new feature in 5.5 that needs documentation:
I have now pushed MWL#234, @@skip_replication, into MariaDB 5.5.21.
User documentation is written up in the worklog:
http://askmonty.org/worklog/Server-Sprint/?tid=234#hld
Can you get the text added to the knowledgebas
Terin Stock writes:
>> Could it be that Clang is lying to autoconf in Xcode 4.3, pretending to be
>> GCC? Maybe it would be worth investigating, and filing a bug against Clang or
>> Autoconf, if appropriate.
> It's possible this is the case, my configure output:
> checking whether we are usin
Daniel Bartholomew writes:
> A new question has been posted to the Knowledgebase:
>
> http://kb.askmonty.org/en/mariadb-compilation-flags
I added an answer.
- Kristian.
___
Mailing list: https://launchpad.net/~maria-developers
Post to : maria-de
I have been analysing the performance difference between MariaDB 5.5.21 and
MySQL 5.5.21 using oltp.lua in sysbench 0.5. It turns out that MySQL has about
8% higher tps in this benchmark when running CPU bound. (See below for links to
blog posts that started this).
I took the base sysbench run and
Kristian Nielsen writes:
Some additional info found from analysis so far:
> 39k mysql_select
This seems mostly caused by expensive JOIN constructor, as Wlad mentioned.
> 16k JOIN::choose_subquery_plan
This is caused by unnecessary C++ object construction (thanks,
Timour!).
MARK CALLAGHAN writes:
>> Another is my_hash_sort_simple(). This is not a regression, but Oprofile
>> shows
>> we spend 10% of total time in this function.
>
> Does this do utf aware compares or memcmp?
This one uses collations - so not memcmp. It is used for SELECT DISTINCT and
GROUP BY. This
Hi Serg,
I'd like to discuss this bug with you when convenient (which may be next week,
after the Percona Live conference :)
https://bugs.launchpad.net/maria/+bug/977571
See my comments on the bug. In 5.3.6, we merged from mysql an upgrade of
bundled yassl, and apparently this now conflicts wi
Daniel Bartholomew writes:
> I've installed buildbot on the bsd9 host at Timour's office and set it
> up as a buildslave.
> However, the builder keeps throwing an exception right at the start of
> the compile step. For example build 4:
> http://buildbot.askmonty.org/buildbot/builders/bsd9-64/bui
Sergei Golubchik writes:
> I suggest to move lp:maria to be lp:maria/5.5 at once.
> And change to lp:maria/trunk as soon as we'll have it.
Sounds good.
Also, I believe lp:maria becomes the default stacking branch? It would be best
if this is a tree that get merged from all/most other trees. Cur
Daniel Bartholomew writes:
> A question has been posted to the Knowledgebase:
>
> http://kb.askmonty.org/en/ubuntu-1004-lts-server-and-mariadb-5523
Answered.
- Kristian.
___
Mailing list: https://launchpad.net/~maria-developers
Post to : maria-d
Hi Serg, thanks for review!
Sergei Golubchik writes:
> On Apr 27, kniel...@knielsen-hq.org wrote:
>> Add that slaves set a variable @mariadb_slave_capability to inform
>> the master in a robust way about which events it can, and cannot,
>> handle.
> I'm not sure I like the idea of magic
md writes:
> 1) Extract 5.5.23 tar.gz source on Fedora 14-x64
> 2) using cmake-gui . -> generate make files (also dies with ccmake
> curses generator)
> 3) make
> 4) See Error below.
>
> But if you just unzip the source tar ball, execute cmake . ,
> and then make, the project will build succes
Michael Widenius writes:
> Kristian> And STRING_WITH_LEN(...) expands to two expressions with a comma
> between them
> Kristian> UUU, VVV - so I also cannot put DBUG_EVALUATE_IF() around
> STRING_WITH_LEN().
>
> Kristian> I rewrote it to use strlen() instead of STRING_WITH_LEN - this code
> is
Hi wlad,
Can I get you to review the following one-liner? (Just the Cmake part).
The problem is that the code in 5.5 currently does not use fdatasync(),
falling back to fsync(). The fdatasync() is detected correctly by cmake, but
the HAVE_DECL_FDATASYNC symbol does not get defined so code does no
"Vladislav Vaintroub" writes:
>> Can I get you to review the following one-liner? (Just the Cmake part).
> Yes, this is correct.
Thanks for checking!
- Kristian.
___
Mailing list: https://launchpad.net/~maria-developers
Post to : maria-develope
Sergei Golubchik writes:
> Here's my review.
Thanks!
I've implemented most of your suggestions, below find explanations for when I
differed, and answers to questions.
- Kristian.
>> === added file 'mysql-test/suite/binlog/t/binlog_xa_recover.test'
For MDEV-232, which I worked on during revi
Davi Arnaut writes:
> On Thu, Jul 26, 2012 at 5:50 PM, Igor Babaev wrote:
>> + bzero(column_stats, sizeof(Column_statistics) * cnt);
>
> That's not allowed for non-POD types.
Can you elaborate on exactly when bzero() (or memset() or similar) is allowed
or not allowed?
I searched in my C++ ref
>> "Rich" == Rich Prohaska writes:
> Rich> hello,
> Rich> we have been using gcc 4.4 to build mysql and mariadb successfully.
> Rich> however, when we tried to use gcc 4.7.1 to build mariadb-5.5.25, we
> Rich> hit this problem:
>
> Rich>
> /home/tokubuild/build-tokudb-46462/mariadb-5.5.25-to
Rich Prohaska writes:
> I suspect that we have a tool chain problem here at tokutek.
> We can build maria 5.5 with gcc 4.7.1 and binutils 2.22 on a centos
> 6.2 machine (we built gcc and binutils ourselves).
> We can not build it on a centos 5.8 machine with the same gcc 4.7.1
> and binutils 2.22
Rich Prohaska writes:
> We did not build gcc 4.7.1 correctly. When we built gcc 4.7.1, we
> used the default assembler that ships in centos 5. We needed to build
> gcc 4.7.1 with a newer binutils, so we built binutils 2.22 and then
> built gcc 4.7.1 with the binutils 2.22 assembler and linker.
This is a writeup of some thoughts I have on getting Global Transaction ID in
MariaDB, as well as some related thoughts on parallel slave and multi-source
replication.
MySQL 5.6 has global transaction ID now, and I looked into it in some
details. Unfortunately, I _really_ did not like what I saw.
Sergei Petrunia writes:
> As far I understood the proposal, it means that we will loose Master<->Slave
> compatibility between MariaDB and MySQL? (that is, it will no longer be
> possible to hook MariaDB slave to a MySQL master, or vice versa). This may be
> a problem. Of course,
Not really. M
Stewart Smith writes:
> Kristian Nielsen writes:
>> https://mariadb.atlassian.net/browse/TODO-171
>
> this seems to be private, and I can't view even having created a JIRA account.
Oops :-( Very sorry about that. I *think* I fixed it now, at least I could
open the li
Stewart Smith writes:
> Idea: if txn touches more than one database, record as metadata the
> position of other db, so slave just has to wait for at least that id to
> be applied in other database before applying this txn in this
> source. This seems like a relatively simple solution to the probl
Davi Arnaut writes:
> On Wed, Aug 1, 2012 at 12:46 AM, Kristian Nielsen
> wrote:
>> Davi Arnaut writes:
>>
>>> On Thu, Jul 26, 2012 at 5:50 PM, Igor Babaev wrote:
>>>> + bzero(column_stats, sizeof(Column_statistics) * cnt);
>>>
>>
Kristian Nielsen writes:
> Or compilers
> could optimise based on knowledge that no external code can modify a private
> member (so it does not need to be spilled over a call to pthread_mutex_lock()
> or similar). But none of this would give a problem with bzero-initialisation
> a
Sergei Golubchik writes:
> Hi, Kristian!
>
> On Jun 22, Kristian Nielsen wrote:
>> Can you review below patch for mdev-232 (At your convenience, not urgent)?
>
> Here's the review. Mostly questions, I have to confess :)
Thanks a lot for your review!
I've tri
Sergei Golubchik writes:
> On Aug 17, Kristian Nielsen wrote:
>> Do you want to see the changes for when I implement async
>> commit_checkpoint_request() in InnoDB/XtraDB, before I push it to 10.0?
> Yes, but it can be a separate patch.
Ok, will do.
>> "Contro
Hi Serg!
I've pushed the MDEV-181/MDEV-225/MDEV-232 to 10.0-base, thanks for review!
As you remember, we discussed extending it with a separate patch for doing the
checkpoint inside InnoDB in an asynchroneous manner. I have created MDEV-532
for this.
It was not hard to create the patch, and it s
Hi Serg!
Kristian Nielsen writes:
> rpl.rpl_binlog_index 'row' w7 [ fail ] Found warnings/errors
> in server log file!
> Test ended at 2012-09-13 15:44:01
> line
> 120913 15:43:48 [ERROR] mysqld: Table './test/t1' is marked as crashed
Hi Serg,
As we discussed under review of MDEV-232, here is a separate patch that makes
InnoDB/XtraDB commit checkpointing be more asynchroneous.
See MDEV-532 for further description of this task.
I hope you will review this, at your convenience.
- Kristian.
kniel...@knielsen-hq.org writes:
>
Robert Hodges writes:
> I think we need to take this out to one of the email threads. I hope other
> people would be interested in these problems.
Agree, I've quoted liberally and Cc:'ed maria-developers@
> On Aug 31, 2012, at 6:14 AM PDT, Kristian Nielsen wrote:
>&
Michael Widenius writes:
> I have now got the first version of multi source patch ported to
> MariadB.
As requested, I did a quick read through of the patch. I took the patch from
your 10.0-mdev253 tree, this revision:
revid:mo...@askmonty.org-20120930233044-e0m6u6t9q3jeqx03
Below are my c
Hi xiaobin,
I read through your patch found here:
http://mysql.taobao.org/index.php/RLPR_for_MariaDB
I am still a bit confused about the status of this patch. It would be useful
if you could explain a bit about the status of the patch:
- How have you tested the patch.
- How are you curr
Hi Kristian,
Monty asked me to connect with you regarding global transaction IDs in
MariaDB.
I reviewed some time ago the MySQL 5.6 global transaction ID design and
implementation. Unfortunately I really did not like what I found, to the point
that I decided this was not something we would want t
Peter Laursen writes:
> I wonder if it will be possible to use replication with GTID's on a 'mixed
> pool' or MariaDB and MySQL5.6 machines? Is this a concern or not? I see a
> problem with the CLOUD where users may not be able to choose the server as
> they want. But if it is *plain impossible*
Hi 丁奇,
Thanks for your answers, you have a good understanding of the potential issues
and how to solve them.
(I've replied to individual items below, but I mostly agree with your
answers).
I have thought a bit more about the overall idea, and I quite like it. In a
way, this is the natural way to
丁奇 writes:
> So I have changed the structure of the patch these two days. The main
> concept is not changed.
> Changes are:
>1) fix the case insensitivity problem
>2) fix the invalid memory access when the key is not long enough.
Great!
>3) Change the strategy in mixed cases
Zardosht Kasheff writes:
> Does Maria 10.0 implement crash safe replication that is found in
> MySQL 5.6.7? If so, does this issue exist there?
No (not yet at least). So the issue does not exist at the moment.
Note that XtraDB in MariaDB has another solution for crash safe replication.
- Kris
Zardosht Kasheff writes:
> What is that solution? Is the solution in MariaDB 5.5? Is there a way
> for another engine to also have this solution?
1.
http://www.percona.com/doc/percona-server/5.5/reliability/innodb_recovery_update_relay_log.html
2. Yes (I think it's even in MariaDB 5.1)
3. No,
Zardosht Kasheff writes:
> Thank you for the reply. I want to make sure I understand this
> correctly. Is the planned design for crash safe replication to be that
> the slave must have the binary log enabled, so that slaves may use the
> GTID and XA to ensure that the slave and master are in sync
(XA-capable) storage engine. However, the table
approach will have a large overhead when the engine used for the table is
different from the engine used in transactions.
Thoughts?
- Kristian.
Kristian Nielsen writes:
> Zardosht Kasheff writes:
>
>> Thank you for the reply. I want
Zardosht Kasheff writes:
> For me, the biggest design goal is to have a way for slaves to be
> crash safe without requiring the storage engine to fsync every
> transaction it processes. This would be a huge performance win.
Right. This basically requires [*] that everything goes through a single
Vladislav Vaintroub writes:
> === modified file 'mysys/my_context.c'
> --- a/mysys/my_context.c 2012-10-31 11:47:25 +
> +++ b/mysys/my_context.c 2012-11-02 23:31:50 +
> @@ -206,7 +206,7 @@
> (
> "movq %%rsp, (%[save])\n\t"
> "movq %[stack], %%rsp\n\t"
> -#if __G
Rich Prohaska writes:
> I made a 10.0.0 branch on launchpad with tokudb in it. The following
> can be used to hit the assert in TC_LOG_MMAP::log_one_transaction. If
Thanks a lot for your effort. I'll look into fixing this ASAP.
See MDEV-3861 for tracking this issue:
https://mariadb.atlas
Rich Prohaska writes:
> I made a 10.0.0 branch on launchpad with tokudb in it. The following
> can be used to hit the assert in TC_LOG_MMAP::log_one_transaction. If
With the test case you supplied, it was easy to repeat the problem, thanks a
lot!
The attached patch fixes the issue for me, ple
Kristian Nielsen writes:
> The attached patch fixes the issue for me, please try it and let me know if it
> solves the problem for you also.
Sorry, the patch is broken, I didn't test carefully enough.
I'll look at this further Monday and get back to you with more, please don
Kristian Nielsen writes:
> Sorry, the patch is broken, I didn't test carefully enough.
In fact, I found *another* bug, making it 3 in total...
The first two of these also exists in older MariaDB/MySQL, but may be
hard/impossible to trigger without the third bug, which is something I
in
Rich Prohaska writes:
> When one runs multiple XA clients with a debug build of my branch, we
> crash at log.cc line 7567. An unlocked mutex is being unlocked. I
> discussed this problem with Sergei and we think that the problem is
> caused a few lines above. I updated my branch (
> lp:~prohas
101 - 200 of 1032 matches
Mail list logo
