Re: [PATCH] Re: deb-support-without-dpkg.patch was Re: AMC patches ported to mc-2006-02-03-13.tar.gz
On Thu, 9 Mar 2006, Leonard den Ottolander wrote: On Thu, 2006-03-09 at 10:45 +0200, Pavel Tsekov wrote: The \? is GNU extension Is it? From the GNU sed info manual: `\?' As `*', but only matches zero or one. It is a GNU extension. ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [PATCH] Re: deb-support-without-dpkg.patch was Re: AMC patches ported to mc-2006-02-03-13.tar.gz
On Thu, 9 Mar 2006, Leonard den Ottolander wrote:
On Wed, 2006-03-08 at 17:50 +0200, Pavel Tsekov wrote:
2005 control.tar.gz
It appears ar is the app which uses 4 field dates that I was looking
for ;-s . Please try the following patch against vfs/extfs/uar. It
removes the fourth date field from the ls output.
The patch behaves well on Linux (with GNU tools), but not on Solaris for
example.
+ thisyear=$(date +%Y)
This should be changed to:
thisyear=`date +%Y`
Why is this necessary:
+ $XAR tv $1 | sed 's,^,-,;s, , 1 ,;s,/, ,' | sed -e
s/\(.\?\)\([0-2][0-9]\:[0-5][0-9] \)\(${thisyear} \)\(.*\)/\1\2\4/ | sed -e
s/\(.\?\)\([0-2][0-9]\:[0-5][0-9] \)\([0-2][0-9][0-9][0-9] \)\(.*\)/\1\3\4/
^^^
The \? is GNU extension and I don't really understand why that construct
is necessary (I am not a regex guru though) so can you explain ?
Since it is impossible to distinguish between 3 and 4 field dates and
the implementation of a separate path for 3 and 4 field dates is not
trivial the approach should always be to strip down 4 field dates to 3
fields.
I agree. Determining the date format could be achieved but it is not a
trivial task and I am not really sure that it is so important after all.
___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [PATCH] Re: deb-support-without-dpkg.patch was Re: AMC patches ported to mc-2006-02-03-13.tar.gz
Hi Pavel, On Thu, 2006-03-09 at 10:45 +0200, Pavel Tsekov wrote: thisyear=`date +%Y` I assumed the $(command) was portable. If not I need to restore the backticks in mc.wrapper.sh as well. The \? is GNU extension and I don't really understand why that construct is necessary (I am not a regex guru though) so can you explain ? The .* matches greedily, so a file name containing a time would be matched instead of the actual time. This is why I used the '?'. Is there a non GNU equivalent for a non greedy match? I'm no regex guru either, so input on how to do this better is appreciated. By the way, instead of a pipe the second expression should only be used if the first didn't match. The current construct strips the year of a file with a name that starts with a year and has a date in this year (i.e. 01:23 2006 2005 bla). I agree. Determining the date format could be achieved but it is not a trivial task and I am not really sure that it is so important after all. I'll document the fact that dates being passed to vfs_parse_ls_lga() need to be parsed back to 3 fields. Leonard. -- mount -t life -o ro /dev/dna /genetic/research ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: [PATCH] Re: deb-support-without-dpkg.patch was Re: AMC patches ported to mc-2006-02-03-13.tar.gz
Hi Pavel, On Thu, 2006-03-09 at 10:45 +0200, Pavel Tsekov wrote: The \? is GNU extension Is it? Leonard. -- mount -t life -o ro /dev/dna /genetic/research ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
deb-support-without-dpkg.patch was Re: AMC patches ported to mc-2006-02-03-13.tar.gz
On Mon, 6 Feb 2006, Pavel Tsekov wrote: deb-support-without-dpkg.patch For systems withoput dpkg (almost any non-debian OS). It handles .deb files as regular .ar archives, as they are in reality. This would be nice addition. Only if we could avoid the 'O' option of gnu tar... Does anyone know of a way to avoid it ? In any case I think this patch is worth adding. I've played with this patch again and I found a problem. In fact it is a problem in uar... When I press enter on either a .deb file or .a file I get directory listing containing file names like this: [excerpt from libc.a] 2005 C-address.o 2005 C-collate.o 2005 C-ctype.o [excerpt from mc_4.6.1-1_i386.deb] 2005 control.tar.gz 2005 data.tar.gz 2005 debian-binary See bellow the output of `ar tv' on the files above: [libc.a] rw-r--r-- 250/250 50188 Nov 4 04:56 2005 C-ctype.o rw-r--r-- 250/250932 Nov 4 04:56 2005 C-messages.o rw-r--r-- 250/250 1372 Nov 4 04:56 2005 C-monetary.o rw-r--r-- 250/250896 Nov 4 04:56 2005 C-numeric.o rw-r--r-- 250/250 3728 Nov 4 04:56 2005 C-time.o rw-r--r-- 250/250788 Nov 4 04:56 2005 C-paper.o rw-r--r-- 250/250952 Nov 4 04:56 2005 C-name.o rw-r--r-- 250/250 1132 Nov 4 04:56 2005 C-address.o rw-r--r-- 250/250904 Nov 4 04:56 2005 C-telephone.o rw-r--r-- 250/250868 Nov 4 04:56 2005 C-measurement.o rw-r--r-- 250/250 1528 Nov 4 04:56 2005 C-identification.o rw-r--r-- 250/250 2248 Nov 4 04:56 2005 C-collate.o [mc_4.6.1-1_i386.deb] rw-r--r-- 0/0 4 Oct 16 18:30 2005 debian-binary rw-r--r-- 0/0 5798 Oct 16 18:30 2005 control.tar.gz rw-r--r-- 0/0 2135380 Oct 16 18:30 2005 data.tar.gz It is obvious that the list command of uar doesn't process the output properly and produces bad filenames. The test was done on Fedora Core 3 (i386) ar is from binutils-2.15.92.0.2-5.1 ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: deb-support-without-dpkg.patch was Re: AMC patches ported to mc-2006-02-03-13.tar.gz
On Wed, 8 Mar 2006, Pavel Tsekov wrote: On Mon, 6 Feb 2006, Pavel Tsekov wrote: deb-support-without-dpkg.patch For systems withoput dpkg (almost any non-debian OS). It handles .deb files as regular .ar archives, as they are in reality. This would be nice addition. Only if we could avoid the 'O' option of gnu tar... Does anyone know of a way to avoid it ? In any case I think this patch is worth adding. I've played with this patch again and I found a problem. In fact it is a problem in uar... When I press enter on either a .deb file or .a file I get directory listing containing file names like this: [excerpt from libc.a] 2005 C-address.o 2005 C-collate.o 2005 C-ctype.o [excerpt from mc_4.6.1-1_i386.deb] 2005 control.tar.gz 2005 data.tar.gz 2005 debian-binary This may be blamed to vfs_parse_ls_lga() too since it processes the output of the extfs list command. Oh, well... ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: deb-support-without-dpkg.patch was Re: AMC patches ported to mc-2006-02-03-13.tar.gz
Hello Pavel, On Wed, 2006-03-08 at 17:50 +0200, Pavel Tsekov wrote: rw-r--r-- 250/250 50188 Nov 4 04:56 2005 C-ctype.o It is obvious that the list command of uar doesn't process the output properly and produces bad filenames. This is most probably caused by the fact that I removed the optional parsing of a fourth date field in vfs_parse_file_date() in utilvfs.c. Please do *not* restore the old behaviour as it is incapable of distinguishing between 3 and 4 field dates reliable. Instead a new function vfs_parse_file_date_4() should be created that is called explicitly for dates that are known to have four date fields. The old function can then be used for dates with three fields. I'm quite willing to implement this function (it's mostly a duplicate of the existing one), but please give me until next weekend. Thanks. Leonard. -- mount -t life -o ro /dev/dna /genetic/research ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: deb-support-without-dpkg.patch was Re: AMC patches ported to mc-2006-02-03-13.tar.gz
Hi, On Wed, 2006-03-08 at 17:35 +0100, Leonard den Ottolander wrote: On Wed, 2006-03-08 at 17:50 +0200, Pavel Tsekov wrote: rw-r--r-- 250/250 50188 Nov 4 04:56 2005 C-ctype.o Instead a new function vfs_parse_file_date_4() should be created that is called explicitly for dates that are known to have four date fields. The old function can then be used for dates with three fields. Hm. Still leaves the fact that vfs_parse_ls_lga() should be capable to distinguish between 3 and 4 field dates. This would require a rewrite of that function to distinguish between 3 and 4 field dates. Not trivial. The easier approach probably is to filter the output of ar through sed and get rid of the time field (simple but somewhat destructive) or to get rid of either the time field or the year field based on the current year... Leonard. -- mount -t life -o ro /dev/dna /genetic/research ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: AMC patches ported to mc-2006-02-03-13.tar.gz
Hi, /mask things in the current (/) directory mask/ or /mask/ only directories (path has '/' ending) here maskfiles (old behaviour) To me it is not obvious. When I see `/' I think root directory. Anyway, this is just me. What worries me most is the fact that this patch changes the old behaviour. I'd like to hear what other people think of it. What about using a trailing // (double slash) for dir+file? Arpad Biro __ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: AMC patches ported to mc-2006-02-03-13.tar.gz
On Fri, 10 Feb 2006, Arpad Biro wrote: /mask things in the current (/) directory mask/ or /mask/ only directories (path has '/' ending) here maskfiles (old behaviour) To me it is not obvious. When I see `/' I think root directory. Anyway, this is just me. What worries me most is the fact that this patch changes the old behaviour. I'd like to hear what other people think of it. What about using a trailing // (double slash) for dir+file? It make sense, IMO. And we are not going to change the old behaviour. Arpi ? ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: AMC patches ported to mc-2006-02-03-13.tar.gz
On Fri, Feb 10, 2006 at 04:27:42PM +0200, Pavel Tsekov wrote: On Fri, 10 Feb 2006, Arpad Biro wrote: /mask things in the current (/) directory mask/ or /mask/ only directories (path has '/' ending) here maskfiles (old behaviour) To me it is not obvious. When I see `/' I think root directory. Anyway, this is just me. What worries me most is the fact that this patch changes the old behaviour. I'd like to hear what other people think of it. What about using a trailing // (double slash) for dir+file? It make sense, IMO. foo - files foo/ - dirs foo// - files + dirs dunno if this is meant, but i definitely like it. :) as opposed to leading slashes, fwiw. And we are not going to change the old behaviour. dunno what this relates to, but excessive conservatism is detrimental to progress. oh, wait, that's a tautology ... -- Hi! I'm a .signature virus! Copy me into your ~/.signature, please! -- Chaos, panic, and disorder - my work here is done. ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: AMC patches ported to mc-2006-02-03-13.tar.gz
On Fri, 10 Feb 2006, Oswald Buddenhagen wrote: On Fri, Feb 10, 2006 at 04:27:42PM +0200, Pavel Tsekov wrote: On Fri, 10 Feb 2006, Arpad Biro wrote: /mask things in the current (/) directory mask/ or /mask/ only directories (path has '/' ending) here maskfiles (old behaviour) To me it is not obvious. When I see `/' I think root directory. Anyway, this is just me. What worries me most is the fact that this patch changes the old behaviour. I'd like to hear what other people think of it. What about using a trailing // (double slash) for dir+file? It make sense, IMO. foo - files foo/ - dirs foo// - files + dirs dunno if this is meant, but i definitely like it. :) as opposed to leading slashes, fwiw. And we are not going to change the old behaviour. dunno what this relates to, but excessive conservatism is detrimental to Try F9 - Right - Filter and enter /* . It's the same as */. progress. oh, wait, that's a tautology ... Yeah, yeah... :) Not that I use it but then someone might show up complaining that he/she is missing her favourite feature. If there is a less intrusive way to achieve the same thing I prefer to go that way. ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: AMC patches ported to mc-2006-02-03-13.tar.gz
On Sun, 5 Feb 2006, Leonard den Ottolander wrote: On Sun, 2006-02-05 at 00:53 +0100, Arpi wrote: I've just ported (updated) my patch set for the today version of mc. I didnt attach for size, download if interested, packed together: http://www1.mplayerhq.hu/~arpi/amc-patches-2006-02-03-13.tgz I'm not sure this is the most convenient way to submit patches. I'll just comment on a few of them based on your comments (instead of the code) for now. avoid-mc-in-mc.patch Do NOT allow starting mc from inside mc (mc in mc causes conflicts and confusion when changing to subshell with ctrl+o) We already have a dialog that warns you if you attempt this. No need to make it impossible. It is a different thing. I think Arpi's patch make sense. The current code detects if attempt is made to run MC via the subshell. If you run without a subshell you can run as many MC's as you want. However we must decide how to combine both... ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: AMC patches ported to mc-2006-02-03-13.tar.gz
On Sun, 5 Feb 2006, Arpi wrote: accept-screen.TERM-format.patch Newer GNU Screen sets TERM to screen.xxx where xxx is the client's terminal name. Currently mc only accepts TERM=screen, not TERM=screen* This patch seems pretty straight forward, but I'd like to discuss it first... From screen's info manual: [...] When `screen' tries to figure out a terminal name for itself, it first looks for an entry named `screen.TERM', where TERM is the contents of your `$TERM' variable. If no such entry exists, `screen' tries `screen' (or `screen-w', if the terminal is wide (132 cols or more)). If even this entry cannot be found, `vt100' is used as a substitute. The idea is that if you have a terminal which doesn't support an important feature (e.g. delete char or clear to EOS) you can build a new termcap/terminfo entry for `screen' (named `screen.DUMBTERM') in which this capability has been disabled. If this entry is installed on your machines you are able to do a rlogin and still keep the correct termcap/terminfo entry. The terminal name is put in the `$TERM' variable of all new windows. [...] So one may endup with TERM set to screen.linux - in this case I am not really sure that define_sequences (xterm_key_defines); should be executed. In fact after reading the info manual of screen I am not really sure that we should do this for screen in general but only for screen inside a xterm emulator. Maybe it won't hurt but still.. Opinions ? ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: AMC patches ported to mc-2006-02-03-13.tar.gz
deb-support-without-dpkg.patch For systems withoput dpkg (almost any non-debian OS). It handles .deb files as regular .ar archives, as they are in reality. This would be nice addition. Only if we could avoid the 'O' option of gnu tar... Does anyone know of a way to avoid it ? In any case I think this patch is worth adding. ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: AMC patches ported to mc-2006-02-03-13.tar.gz
On Sun, 5 Feb 2006, Arpi wrote: select_dirs.patch In select/unselect files dialog: let mask/ select directories only, and /mask select dirs+files This doesn't seem very intuitive. Isn't there another way for achieving the same thing. How do other file managers behave in this scenario ? ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: AMC patches ported to mc-2006-02-03-13.tar.gz
Hi, On Sun, 5 Feb 2006, Arpi wrote: select_dirs.patch In select/unselect files dialog: let mask/ select directories only, and /mask select dirs+files This doesn't seem very intuitive. Why? /mask things in the current (/) directory mask/ or /mask/ only directories (path has '/' ending) here maskfiles (old behaviour) Isn't there another way for achieving the same thing. How do other file managers behave in this scenario ? no idea, probably no such feature there A'rpi ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: AMC patches ported to mc-2006-02-03-13.tar.gz
On Mon, 6 Feb 2006, Arpi wrote: On Sun, 5 Feb 2006, Arpi wrote: select_dirs.patch In select/unselect files dialog: let mask/ select directories only, and /mask select dirs+files This doesn't seem very intuitive. Why? /mask things in the current (/) directory mask/ or /mask/ only directories (path has '/' ending) here maskfiles (old behaviour) To me it is not obvious. When I see `/' I think root directory. Anyway, this is just me. What worries me most is the fact that this patch changes the old behaviour. I'd like to hear what other people think of it. ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: AMC patches ported to mc-2006-02-03-13.tar.gz
Pavel Tsekov wrote: On Mon, 6 Feb 2006, Arpi wrote: On Sun, 5 Feb 2006, Arpi wrote: select_dirs.patch In select/unselect files dialog: let mask/ select directories only, and /mask select dirs+files This doesn't seem very intuitive. Why? /mask things in the current (/) directory mask/ or /mask/ only directories (path has '/' ending) here maskfiles (old behaviour) To me it is not obvious. When I see `/' I think root directory. Anyway, this is just me. What worries me most is the fact that this patch changes the old behaviour. I'd like to hear what other people think of it. Selecting directories with a mask looks useful to me, but the leading slash indeed looks odd. Concerning prior art: The shell expands */ to all directories in the current directory, and * to all files and directories. Here, the problem is that mc's behavior already differs from sh's. Otherwise I'd say we just imitate the shell. Roland ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: AMC patches ported to mc-2006-02-03-13.tar.gz
On Sun, 5 Feb 2006, Arpi wrote: ftpfs-allow-connect-interrupting.patch Let the user interrupt ftpfs in hostname lookup / connection state (for mistyped URL/IP or servers being shut down) Commited. Thanks! ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: AMC patches ported to mc-2006-02-03-13.tar.gz
Hi, On Sun, 5 Feb 2006, Arpi wrote: ftpfs-allow-connect-interrupting.patch Let the user interrupt ftpfs in hostname lookup / connection state (for mistyped URL/IP or servers being shut down) Commited. Thanks! thanks. what about the others? i'm interested in comments, reasons of refusing. there are a few i can accept being refused (like unesp support, although it's just a few lines, my syntax files, or the esc,shift+numbers mapping) but the others are IMHO clean and useful. A'rpi ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: AMC patches ported to mc-2006-02-03-13.tar.gz
On Sun, 5 Feb 2006, Arpi wrote: On Sun, 5 Feb 2006, Arpi wrote: ftpfs-allow-connect-interrupting.patch Let the user interrupt ftpfs in hostname lookup / connection state (for mistyped URL/IP or servers being shut down) Commited. Thanks! thanks. what about the others? i'm interested in comments, reasons of refusing. there are a few i can accept being refused (like unesp support, although it's just a few lines, my syntax files, or the esc,shift+numbers mapping) but the others are IMHO clean and useful. One at a time. I'll go trough all of them. ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: AMC patches ported to mc-2006-02-03-13.tar.gz
On Sun, 5 Feb 2006, Arpi wrote: more-xterm-keycodes.patch xterm codes for Shift + Pageup/Pagedown and some cosmetics (grouping same keys with different modifiers together) Which terminal emulator generates those sequences ? I've just tried xterm 6.8.2.0(202) under Cygwin and Shift + PgUp/PgDn doesn't output anything on the screen. ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: AMC patches ported to mc-2006-02-03-13.tar.gz
Hi, On Sun, 5 Feb 2006, Arpi wrote: more-xterm-keycodes.patch xterm codes for Shift + Pageup/Pagedown and some cosmetics (grouping same keys with different modifiers together) Which terminal emulator generates those sequences ? I've just tried xterm 6.8.2.0(202) under Cygwin and Shift + PgUp/PgDn doesn't output anything on the screen. iTerm on MAC OSX, it's xterm compatible anyway (at least it sets TERM=xterm and outputs the other codes same as xterm) anyway these codes has the same logic as the other modifier key seqs. A'rpi ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: AMC patches ported to mc-2006-02-03-13.tar.gz
On Sun, 5 Feb 2006, Arpi wrote: On Sun, 5 Feb 2006, Arpi wrote: more-xterm-keycodes.patch xterm codes for Shift + Pageup/Pagedown and some cosmetics (grouping same keys with different modifiers together) Which terminal emulator generates those sequences ? I've just tried xterm 6.8.2.0(202) under Cygwin and Shift + PgUp/PgDn doesn't output anything on the screen. iTerm on MAC OSX, it's xterm compatible anyway (at least it sets TERM=xterm and outputs the other codes same as xterm) anyway these codes has the same logic as the other modifier key seqs. Yeah, sure, however from the patch description it wasn't clear who emits those sequences. I was under the impression that it's xterm itself. ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: AMC patches ported to mc-2006-02-03-13.tar.gz
Hi, more-xterm-keycodes.patch xterm codes for Shift + Pageup/Pagedown and some cosmetics (grouping same keys with different modifiers together) Which terminal emulator generates those sequences ? I've just tried xterm 6.8.2.0(202) under Cygwin and Shift + PgUp/PgDn doesn't output anything on the screen. iTerm on MAC OSX, it's xterm compatible anyway (at least it sets TERM=xterm and outputs the other codes same as xterm) anyway these codes has the same logic as the other modifier key seqs. Yeah, sure, however from the patch description it wasn't clear who emits those sequences. I was under the impression that it's xterm itself. Sorry. I have added lots of such sequences long time ago to my AMC fork (made from 4.6.0, when my patches were ignored on this list 2 years ago), and now that i was trying to update my patches for current mc version, i found that most of them (except for this two) were already added by you, commented as 'xterm sequences'. i didnt care to test with xterm myself... Anyway i guess xterm should also emit these, if the keymaps are set up correctly, unless they are all hand-coded into xterm as hacks. (the codes show some logic, being constructed from 2 numbers, one refers to the key and the other to modifiers, so it could be handled generaly without listing any possible combinations - probably this is the reason why for example iTerm emits these too) A'rpi ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: AMC patches ported to mc-2006-02-03-13.tar.gz
On Sun, 5 Feb 2006, Arpi wrote:
On Sun, 5 Feb 2006, Arpi wrote:
more-xterm-keycodes.patch
xterm codes for Shift + Pageup/Pagedown
and some cosmetics (grouping same keys with different modifiers
together)
Which terminal emulator generates those sequences ? I've just tried
xterm 6.8.2.0(202) under Cygwin and Shift + PgUp/PgDn doesn't output
anything on the screen.
iTerm on MAC OSX, it's xterm compatible anyway (at least it sets TERM=xterm
and outputs the other codes same as xterm)
anyway these codes has the same logic as the other modifier key seqs.
The following patch was commited:
Index: src/ChangeLog
===
RCS file: /cvsroot/mc/mc/src/ChangeLog,v
retrieving revision 1.1798
diff -u -p -r1.1798 ChangeLog
--- src/ChangeLog 4 Feb 2006 14:41:41 - 1.1798
+++ src/ChangeLog 5 Feb 2006 15:25:12 -
@@ -1,3 +1,7 @@
+2006-02-05 Arpad Gereoffy (A'rpi) [EMAIL PROTECTED]
+
+ * key.c (xterm_key_defines): Add sequences for iTerm.
+
2006-02-04 Roland Illig [EMAIL PROTECTED]
* find.c: Added make_fullname() to avoid code duplication.
Index: src/key.c
===
RCS file: /cvsroot/mc/mc/src/key.c,v
retrieving revision 1.86
diff -u -p -r1.86 key.c
--- src/key.c 7 Jan 2006 12:49:08 - 1.86
+++ src/key.c 5 Feb 2006 15:25:12 -
@@ -304,6 +304,10 @@ static key_define_t xterm_key_defines []
{ KEY_M_SHIFT | KEY_M_CTRL | KEY_RIGHT, ESC_STR O6C, MCKEY_NOACTION },
{ KEY_M_SHIFT | KEY_M_CTRL | KEY_LEFT, ESC_STR O6D, MCKEY_NOACTION },
+/* iTerm */
+{ KEY_M_SHIFT | KEY_PPAGE, ESC_STR [5;2~, MCKEY_NOACTION },
+{ KEY_M_SHIFT | KEY_NPAGE, ESC_STR [6;2~, MCKEY_NOACTION },
+
/* keypad keys */
{ KEY_IC, ESC_STR Op, MCKEY_NOACTION },
{ KEY_DC, ESC_STR On, MCKEY_NOACTION },
___
Mc-devel mailing list
http://mail.gnome.org/mailman/listinfo/mc-devel
Re: AMC patches ported to mc-2006-02-03-13.tar.gz
On Sun, 5 Feb 2006, Arpi wrote: more-syntax-defs.patch Syntax highlight definition files for BAssPasC language, MHTML and JASM I don't see any obstacles to apply this one. But I'd rather let other people comment before I commit it since those languages are not widely used (IMO). swap-backslash-and-greyminus.patch map \ to directory-hotlist instead of unselect-files What's the rationale here ? Make MC behave like other file managers with regard to selecting/deselecting groups of files ? If this is the case we should at least keep the current shortcut for the directory hotlist. The drawback here is that users accustomed to MC may be unpleasantly surprised. ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: AMC patches ported to mc-2006-02-03-13.tar.gz
Hi, On Sun, 5 Feb 2006, Arpi wrote: more-syntax-defs.patch Syntax highlight definition files for BAssPasC language, MHTML and JASM I don't see any obstacles to apply this one. But I'd rather let other people comment before I commit it since those languages are not widely used (IMO). Probably it's better to put this to the homepage's Contributed code that won't be included into the distribution section... or just ignore. They are big and very few people uses it... they can add them manualy, as did before... swap-backslash-and-greyminus.patch map \ to directory-hotlist instead of unselect-files What's the rationale here ? Make MC behave like other file managers with regard to selecting/deselecting groups of files ? If this is the case yes. every other FMs i used uses - for unselect, and + for select. \ is unusual... we should at least keep the current shortcut for the directory hotlist. The drawback here is that users accustomed to MC may be unpleasantly surprised. yes ;( but there is no revolution without surprise :) A'rpi ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
Re: AMC patches ported to mc-2006-02-03-13.tar.gz
Hi Arpi, On Sun, 2006-02-05 at 00:53 +0100, Arpi wrote: I've just ported (updated) my patch set for the today version of mc. I didnt attach for size, download if interested, packed together: http://www1.mplayerhq.hu/~arpi/amc-patches-2006-02-03-13.tgz I'm not sure this is the most convenient way to submit patches. I'll just comment on a few of them based on your comments (instead of the code) for now. avoid-mc-in-mc.patch Do NOT allow starting mc from inside mc (mc in mc causes conflicts and confusion when changing to subshell with ctrl+o) We already have a dialog that warns you if you attempt this. No need to make it impossible. deb-support-without-dpkg.patch For systems withoput dpkg (almost any non-debian OS). It handles .deb files as regular .ar archives, as they are in reality. Haven't looked at the code but this seems useful. esc+shift+numbers_as_shift+F-keys.patch Useful only with english keyboard map! Maps ESC,Shift+0..9 to Shift+F1..F10 keys, like ESC,0..9 are mapped to F1..F10 (useful on dumb terminals not handling F-key codes correctly) Does this feature an option that can be toggled in any of the dialogs? more-syntax-defs.patch Syntax highlight definition files for BAssPasC language, MHTML and JASM There seems to be a difference of opinion whether we should support every obscure syntax there is out there. As such I don't mind we support as many syntaxes as we can, but how do we approach extension conflicts? option_beep_when_fileop_finished.patch beep sound when file op (copy,. move etc) finished. optional. Should be togglable. Not everyone likes beeping consoles. option_ctrl-o_blocking.patch block Ctrl+O (switch back to panels from subshell) when there is something types in the subshell (to avoid the annoying 'Subshell is already running a command' wahrning coming soon) - optional Don't like this. We've fixed the warning for white space lines already. I like to toggle a lot (especially from inside mcedit). optional: do not allow subshell to change panel's cwd Not without a selectable option. wildcards_and_quoting_in_quick_cd.patch allows quoting (cd There\ are\ spaces\ in\ this\ path) and wildcards (cd Mar*) in quick-cd. Quoting is fine but wildcards make no sense for cd. Where is a cd * supposed to go? Use auto completion (esc tab) instead. Leonard. -- mount -t life -o ro /dev/dna /genetic/research ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
AMC patches ported to mc-2006-02-03-13.tar.gz
Hi, I've just ported (updated) my patch set for the today version of mc. I didnt attach for size, download if interested, packed together: http://www1.mplayerhq.hu/~arpi/amc-patches-2006-02-03-13.tgz List of patches included: (content of README.patches) AMC patches, ported to mc-2006-02-03-13: (should work with others too) contact: [EMAIL PROTECTED] accept-screen.TERM-format.patch Newer GNU Screen sets TERM to screen.xxx where xxx is the client's terminal name. Currently mc only accepts TERM=screen, not TERM=screen* avoid-mc-in-mc.patch Do NOT allow starting mc from inside mc (mc in mc causes conflicts and confusion when changing to subshell with ctrl+o) deb-support-without-dpkg.patch For systems withoput dpkg (almost any non-debian OS). It handles .deb files as regular .ar archives, as they are in reality. esc+shift+numbers_as_shift+F-keys.patch Useful only with english keyboard map! Maps ESC,Shift+0..9 to Shift+F1..F10 keys, like ESC,0..9 are mapped to F1..F10 (useful on dumb terminals not handling F-key codes correctly) extfs-esp-archiver-support.patch Support for my (ESP-team's) ESP archive file format (listing, unpacking) ftpfs-allow-connect-interrupting.patch Let the user interrupt ftpfs in hostname lookup / connection state (for mistyped URL/IP or servers being shut down) more-syntax-defs.patch Syntax highlight definition files for BAssPasC language, MHTML and JASM more-xterm-keycodes.patch xterm codes for Shift + Pageup/Pagedown and some cosmetics (grouping same keys with different modifiers together) option_beep_when_fileop_finished.patch beep sound when file op (copy,. move etc) finished. optional. option_ctrl-o_blocking.patch block Ctrl+O (switch back to panels from subshell) when there is something types in the subshell (to avoid the annoying 'Subshell is already running a command' wahrning coming soon) - optional option_editor_prefix_control_chars.patch optional: disable prefixing of control chars (^M etc) in the editor option_prompt_type_and_subshell_chdir.patch optional: prompt can be changed (disable/short/path) optional: do not allow subshell to change panel's cwd options-COMMON.patch required for the option-* patches (common part) select_dirs.patch In select/unselect files dialog: let mask/ select directories only, and /mask select dirs+files swap-backslash-and-greyminus.patch map \ to directory-hotlist instead of unselect-files wildcards_and_quoting_in_quick_cd.patch allows quoting (cd There\ are\ spaces\ in\ this\ path) and wildcards (cd Mar*) in quick-cd. Quoting is required to 'cd ' then Alt+A to work for evil paths. Wildcarding is useful for very slow terminal connections. (easier to type cd W* than typing many UP keys then wait for result) Please apply the ones you can accept... thx. A'rpi ___ Mc-devel mailing list http://mail.gnome.org/mailman/listinfo/mc-devel
