Hello Urbanecm, jenkins-bot, Zoranzoki21,
I'd like you to do a code review. Please visit
https://gerrit.wikimedia.org/r/394408
to review the following change.
Change subject: Revert "wdbuild: Stop using wikidata build on LABS / BETA"
Hello Aude, Urbanecm, Hoo man, jenkins-bot, Zoranzoki21,
I'd like you to do a code review. Please visit
https://gerrit.wikimedia.org/r/394401
to review the following change.
Change subject: Revert "Revert "wdbuild: add switch to ease killing""
Hello Aude, Urbanecm, Hoo man, jenkins-bot, Zoranzoki21,
I'd like you to do a code review. Please visit
https://gerrit.wikimedia.org/r/394399
to review the following change.
Change subject: Revert "wdbuild: add switch to ease killing"
Addshore has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/394358 )
Change subject: Fix phpdoc for Category::newFromName
..
Fix phpdoc for Category::newFromName
Change-Id:
Addshore has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/394330 )
Change subject: WatchedItemStoreUnitTest return strings in db mocks
..
WatchedItemStoreUnitTest return strings in db mocks
Change-Id:
Addshore has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/394305 )
Change subject: Convert timestamp from DB in RevisionDbTestBase::testInsertOn
..
Convert timestamp from DB in
Addshore has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/394302 )
Change subject: Get page fromdbmaster in Importer
..
Get page fromdbmaster in Importer
Due to possible slave lag the page might not exist
Addshore has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/394299 )
Change subject: Force search profile advanced
..
Force search profile advanced
If the profile is not set to be advanced then the
Addshore has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/394297 )
Change subject: Force search profile advanced
..
Force search profile advanced
If the profile is not set to be advanced then the
Addshore has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/394291 )
Change subject: DNM Remove wikidatabuilder
..
DNM Remove wikidatabuilder
This must wait for the labs project using this to
first be
Addshore has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/394288 )
Change subject: DNM Remove Wikidata build from make-wmf-branch script
..
DNM Remove Wikidata build from make-wmf-branch script
Not to be
Addshore has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/394286 )
Change subject: Remove DataTypes extension from make-wmf-branch script
..
Remove DataTypes extension from make-wmf-branch script
This
Addshore has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/394283 )
Change subject: wdbuild: Switch wikidata extensions to json entrypoint where
possible
..
wdbuild: Switch wikidata extensions to json
Addshore has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/394282 )
Change subject: wdbuild: Add wikidata extensions to extension-list
..
wdbuild: Add wikidata extensions to extension-list
Also removes the
Addshore has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/394278 )
Change subject: Add config switch for betafeature mode
..
Add config switch for betafeature mode
Change-Id:
Addshore has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/394276 )
Change subject: Force search profile advanced
..
Force search profile advanced
If the profile is not set to be advanced then the
Addshore has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/394215 )
Change subject: wdbuild: Remove wmgUseWikidataBuild
..
wdbuild: Remove wmgUseWikidataBuild
Change-Id:
Addshore has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/394216 )
Change subject: wdbuild: Remove Wikibase-buildentry.php config file (empty)
..
wdbuild: Remove Wikibase-buildentry.php config file (empty)
Addshore has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/394214 )
Change subject: wdbuild: Stop loading from build on all wikis
..
wdbuild: Stop loading from build on all wikis
Bug: T176948
Change-Id:
Addshore has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/394210 )
Change subject: wdbuild: Stop loading from build on test and testwikidata
..
wdbuild: Stop loading from build on test and testwikidata
Addshore has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/394211 )
Change subject: wdbuild: Stop loading from build on group0
..
wdbuild: Stop loading from build on group0
Bug: T176948
Change-Id:
Addshore has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/394213 )
Change subject: wdbuild: Stop loading from build on all wikis (except enwiki)
..
wdbuild: Stop loading from build on all wikis (except
Addshore has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/394209 )
Change subject: wdbuild: Stop using wikidata build on LABS / BETA
..
wdbuild: Stop using wikidata build on LABS / BETA
Bug: T176948
Addshore has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/394208 )
Change subject: wdbuild: extension-list-labs stop using build entry points
..
wdbuild: extension-list-labs stop using build entry points
Addshore has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/394212 )
Change subject: wdbuild: Stop loading from build on group1
..
wdbuild: Stop loading from build on group1
Bug: T176948
Change-Id:
Addshore has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/394207 )
Change subject: wdbuild: add switch to ease killing
..
wdbuild: add switch to ease killing
Bug: T176948
Change-Id:
Addshore has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/393765 )
Change subject: Refactor test for WikiPage::doRollback
..
Refactor test for WikiPage::doRollback
This test was not running and a comment
Addshore has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/393761 )
Change subject: WikiPage tests @covers for doDeleteArticleReal & commitRollback
..
WikiPage tests @covers for doDeleteArticleReal &
Addshore has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/393599 )
Change subject: Split WikiPageTest into ContentHandler & NoContentHandler tests
..
Split WikiPageTest into ContentHandler &
Addshore has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/393593 )
Change subject: Cleanup WikiPageTest
..
Cleanup WikiPageTest
Change-Id: Id95b7153c42ddcd391f966b75f54e00c13d7ce5a
---
M
Addshore has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/393587 )
Change subject: BETA wmgMonologChannels 'FileImporter' => 'debug'
..
BETA wmgMonologChannels 'FileImporter' => 'debug'
Bug: T181383
Bug:
Addshore has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/393585 )
Change subject: Throw exception when createPostImportRevision fails to get
WikiPage
..
Throw exception when createPostImportRevision
Addshore has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/393582 )
Change subject: Actually call wfLoadExtension for FileExporter & Importer on
beta
..
Actually call wfLoadExtension for FileExporter &
Addshore has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/393577 )
Change subject: Enable FileImporter & FileExporter on BETA
..
Enable FileImporter & FileExporter on BETA
Bug: T181383
Change-Id:
Addshore has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/393576 )
Change subject: Add FileExporter & FileImporter to extension-list-labs
..
Add FileExporter & FileImporter to extension-list-labs
Bug:
Addshore has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/393568 )
Change subject: Remove hook to clear search profiles
..
Remove hook to clear search profiles
Do not clear the search profiles at all.
Addshore has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/393567 )
Change subject: return false in onSpecialSearchProfiles hook
..
return false in onSpecialSearchProfiles hook
It looks like this hook is
Addshore has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/393566 )
Change subject: Adjust links in beta section
..
Adjust links in beta section
Bug: T181222
Change-Id:
Addshore has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/393112 )
Change subject: Clarify the use of @group Database in MediaWikiTestCase
..
Clarify the use of @group Database in MediaWikiTestCase
Only
Addshore has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/393111 )
Change subject: Remove unused WikiPageTestContentHandlerUseDB (test)
..
Remove unused WikiPageTestContentHandlerUseDB (test)
This class
Addshore has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/393109 )
Change subject: Make WikiPageTestContentHandlerUseDBTest run
..
Make WikiPageTestContentHandlerUseDBTest run
Change-Id:
Addshore has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/392612 )
Change subject: return false in onSpecialSearchProfiles hook
..
return false in onSpecialSearchProfiles hook
It looks like this hook is
Addshore has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/392613 )
Change subject: Remove unused onSpecialSearchPowerBox hook
..
Remove unused onSpecialSearchPowerBox hook
Change-Id:
Addshore has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/392600 )
Change subject: Note about deployment in README
..
Note about deployment in README
Change-Id: I79bbe32fe3bb3b427ec81a716b3f0f9b3070d17b
Addshore has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/392599 )
Change subject: Note about deployment in README
..
Note about deployment in README
Change-Id: I79bbe32fe3bb3b427ec81a716b3f0f9b3070d17b
Addshore has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/392598 )
Change subject: Add .editorconfig
..
Add .editorconfig
Change-Id: I2a804762c02c177ea5e6fe1a9deae93e9b21ec55
---
A .editorconfig
1 file
Addshore has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/392597 )
Change subject: Add .editorconfig
..
Add .editorconfig
Change-Id: I2a804762c02c177ea5e6fe1a9deae93e9b21ec55
---
A .editorconfig
1 file
Addshore has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/392596 )
Change subject: Add advancedsearch to betafeature count script
..
Add advancedsearch to betafeature count script
Bug: T180570
Change-Id:
Addshore has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/392595 )
Change subject: Add codemirror-syntax-highlight beta feature
..
Add codemirror-syntax-highlight beta feature
Was deployed on July 5th and
Addshore has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/392593 )
Change subject: Add advancedsearch to betafeature sount script
..
Add advancedsearch to betafeature sount script
Bug: T180570
Change-Id:
Addshore has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/392484 )
Change subject: More user related Revision construction test cases
..
More user related Revision construction test cases
Addshore has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/392460 )
Change subject: Deprecate access to TitleValue properties
..
Deprecate access to TitleValue properties
This switches from private to
Addshore has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/392411 )
Change subject: More logging
..
More logging
This adds lots of logging in various places of various levels
for the FileImporter channel.
Addshore has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/392391 )
Change subject: Tests for TitleValue::__toString
..
Tests for TitleValue::__toString
Change-Id: Ibb157b8e6e4fdc75bdb27ecaa4a552304465c4b2
Addshore has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/392390 )
Change subject: Set wgCommentTableSchemaMigrationStage for some RevisionTests
..
Set wgCommentTableSchemaMigrationStage for some
Addshore has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/392214 )
Change subject: [MCR] tests for Revision::getArchiveQueryInfo
..
[MCR] tests for Revision::getArchiveQueryInfo
Bug: T180210
Change-Id:
Addshore has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/392215 )
Change subject: [MCR] tests for Revision::getQueryInfo
..
[MCR] tests for Revision::getQueryInfo
Bug: T180210
Change-Id:
Addshore has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/392208 )
Change subject: [MCR] Readd various field & cond method tests for Revision
..
[MCR] Readd various field & cond method tests for Revision
Addshore has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/392205 )
Change subject: Add __toString method to LinkTarget interface
..
Add __toString method to LinkTarget interface
Change-Id:
Addshore has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/392206 )
Change subject: @since tags & private class properties for TitleValue
..
@since tags & private class properties for TitleValue
Change-Id:
Addshore has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/392199 )
Change subject: DNM [MCR] fixes made in various Revision* files to pass tests
..
DNM [MCR] fixes made in various Revision* files to pass
Addshore has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/392016 )
Change subject: Manually applied: Load Wikibase view on clients as well
..
Manually applied: Load Wikibase view on clients as well
Now
Addshore has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/392015 )
Change subject: Load Wikibase view on clients as well
..
Load Wikibase view on clients as well
Now that many dependencies are in there,
Addshore has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/391853 )
Change subject: WIP RevisionStoreTest
..
WIP RevisionStoreTest
Change-Id: Iefad870baf2d16f12e9901b303246c64d6431ca6
---
A
Addshore has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/391790 )
Change subject: Manually applied: Fix SparqlHelper::getCacheMaxAge()
..
Manually applied: Fix SparqlHelper::getCacheMaxAge()
Some HTTP
Addshore has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/391787 )
Change subject: Fix SparqlHelper::getCacheMaxAge()
..
Fix SparqlHelper::getCacheMaxAge()
Some HTTP headers can be multi-valued, so
Addshore has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/391632 )
Change subject: DNM TEST require version of package not in mediawiki-vendor
..
DNM TEST require version of package not in mediawiki-vendor
Addshore has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/391631 )
Change subject: Update extensions/Wikidata to new wmf/1.31.0-wmf.8 branch
(again)
..
Update extensions/Wikidata to new wmf/1.31.0-wmf.8
Addshore has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/391598 )
Change subject: Autoload SpecialNewEntityTest
..
Autoload SpecialNewEntityTest
Change-Id: Ie3c508e52d024814662ab796c71e141cda701c9f
---
M
Addshore has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/391602 )
Change subject: Add CachingMetadata value object
..
Add CachingMetadata value object
A CachingMetadata object encapsulates information
Addshore has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/391597 )
Change subject: Family name of Thiemo changed
..
Family name of Thiemo changed
Change-Id: I6984837f5d82c76bd2035c32e8514bc55731b8ab
---
M
Addshore has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/391600 )
Change subject: Localisation updates from https://translatewiki.net.
..
Localisation updates from https://translatewiki.net.
Change-Id:
Addshore has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/391603 )
Change subject: Add CachedArray, CachedQueryResults containers
..
Add CachedArray, CachedQueryResults containers
CachedArray is simply a
Addshore has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/391601 )
Change subject: Really autoload client class in Repo-only mode tests
..
Really autoload client class in Repo-only mode tests
Doing
Addshore has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/391599 )
Change subject: Autoload client class in Repo-only mode tests
..
Autoload client class in Repo-only mode tests
Addshore has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/391596 )
Change subject: Add cause action/agent tracking to html purge jobs
..
Add cause action/agent tracking to html purge jobs
Also made
Addshore has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/391593 )
Change subject: New Wikidata Build - 2017-11-15T10:00:02+
..
New Wikidata Build - 2017-11-15T10:00:02+
Change-Id:
Addshore has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/391588 )
Change subject: Action override callbacks must still accept WikiPage for now.
..
Action override callbacks must still accept WikiPage for
Addshore has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/391559 )
Change subject: Setup home dir for addshore
..
Setup home dir for addshore
Change-Id: If51fc6a2ae85dad136b60d8c44fd2bd9199710bb
---
A
Hello Ladsgroup, jenkins-bot,
I'd like you to do a code review. Please visit
https://gerrit.wikimedia.org/r/391565
to review the following change.
Change subject: Revert "Update extensions/Wikidata to new wmf/1.31.0-wmf.8
branch"
Addshore has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/391534 )
Change subject: Revision::userCanBitfield test fallback to $wgUser
..
Revision::userCanBitfield test fallback to $wgUser
Bug: T180210
Addshore has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/391531 )
Change subject: Update extensions/Wikidata to new wmf/1.31.0-wmf.8 branch
..
Update extensions/Wikidata to new wmf/1.31.0-wmf.8 branch
Addshore has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/391524 )
Change subject: Branch Wikidata extension repo from master each week
..
Branch Wikidata extension repo from master each week
Bug: T180539
Addshore has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/391271 )
Change subject: Error if wiktionary creation attempted without using
aawiktionary
..
Error if wiktionary creation attempted without using
Addshore has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/391269 )
Change subject: Remove db_slave entry from statistics wmde graphite
..
Remove db_slave entry from statistics wmde graphite
This is not
Addshore has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/391255 )
Change subject: Add DEPRECATED note to build README
..
Add DEPRECATED note to build README
Change-Id:
Addshore has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/391253 )
Change subject: Add comment warning to Wikidata.localisation.php
..
Add comment warning to Wikidata.localisation.php
This also adds a
Addshore has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/391251 )
Change subject: Stop using extension-list-wikidata from Wikidat build for prod
..
Stop using extension-list-wikidata from Wikidat build
Addshore has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/391245 )
Change subject: Stop using extension-list-wikidata from Wikidata build for labs
..
Stop using extension-list-wikidata from Wikidata build
Addshore has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/391215 )
Change subject: Add data-values/data-types 2.0.0
..
Add data-values/data-types 2.0.0
Used in the Wikidata build as of
Addshore has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/391195 )
Change subject: Updating wikibase/data-model (7.2.0 => 7.3.0)
..
Updating wikibase/data-model (7.2.0 => 7.3.0)
Change-Id:
Addshore has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/391194 )
Change subject: Test for Revision::getRecentChange
..
Test for Revision::getRecentChange
Bug: T180210
Change-Id:
Addshore has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/391192 )
Change subject: Tests for Revision::getRevisionText with ExternalStore usage
..
Tests for Revision::getRevisionText with ExternalStore
Addshore has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/391186 )
Change subject: WIP DNM Introduce ExternalStoreFactory
..
WIP DNM Introduce ExternalStoreFactory
Change-Id:
Addshore has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/391183 )
Change subject: Initial tests for Revision::getRevisionText
..
Initial tests for Revision::getRevisionText
Bug: T180210
Change-Id:
Addshore has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/391089 )
Change subject: Add r-library dir to .gitignore
..
Add r-library dir to .gitignore
Change-Id: I82cb3c531f2d5dfa09e97c505e0204f36028d8ae
Addshore has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/391017 )
Change subject: Add zuul entry for analytics/wmde/WDCM-packages
..
Add zuul entry for analytics/wmde/WDCM-packages
Change-Id:
Addshore has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/391016 )
Change subject: .gitreview
..
.gitreview
Change-Id: I6d281aab3d1da72786cd631b6d969bc6697c185e
---
A .gitreview
1 file changed, 6
Addshore has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/391016 )
Change subject: .gitreview
..
.gitreview
Change-Id: I6d281aab3d1da72786cd631b6d969bc6697c185e
---
A .gitreview
1 file changed, 6
Addshore has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/390425 )
Change subject: Tests for Revision::userCan
..
Tests for Revision::userCan
Bug: T180210
Change-Id:
201 - 300 of 3702 matches
Mail list logo
