[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Fix i18n TODOs in CollabPad

2017-06-10 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/358168 ) Change subject: Fix i18n TODOs in CollabPad .. Fix i18n TODOs in CollabPad Change-Id: Ifa802773881e2f2763578223bc76ca2798a08b17 --- M

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: WIP Show visual diffs on DiffPage

2017-06-09 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/358022 ) Change subject: WIP Show visual diffs on DiffPage .. WIP Show visual diffs on DiffPage Currently: * All VE javascript is loaded (could be

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Fix check for CSS overflow on focusable nodes

2017-06-08 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/357854 ) Change subject: Fix check for CSS overflow on focusable nodes .. Fix check for CSS overflow on focusable nodes Bug: T167438 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...Math[master]: Limit overflow-x rule to block elements

2017-06-08 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/357845 ) Change subject: Limit overflow-x rule to block elements .. Limit overflow-x rule to block elements The overflow-x rule has no effect on

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Use static parseDocument method

2017-06-08 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/357813 ) Change subject: Use static parseDocument method .. Use static parseDocument method Change-Id: I545a58ffcbf1c7c57c197f4858958de835a40394

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: [DEPRECATING CHANGE] Make Target#createModelFromDom static

2017-06-08 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/357811 ) Change subject: [DEPRECATING CHANGE] Make Target#createModelFromDom static .. [DEPRECATING CHANGE] Make Target#createModelFromDom static

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: [DEPRECATING CHANGE] Make Target#parseDocument static

2017-06-08 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/357806 ) Change subject: [DEPRECATING CHANGE] Make Target#parseDocument static .. [DEPRECATING CHANGE] Make Target#parseDocument static Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...Score[master]: Specify iconWhenInvisible for score node

2017-06-07 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/357731 ) Change subject: Specify iconWhenInvisible for score node .. Specify iconWhenInvisible for score node Bug: T166526 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...Math[master]: Specify iconWhenInvisible for math/chem nodes

2017-06-07 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/357730 ) Change subject: Specify iconWhenInvisible for math/chem nodes .. Specify iconWhenInvisible for math/chem nodes Bug: T166526 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...wikihiero[master]: Use 'hiero' icon when invisible

2017-06-07 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/357728 ) Change subject: Use 'hiero' icon when invisible .. Use 'hiero' icon when invisible Bug: T166526 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Give extensions a fallback icon when invisible

2017-06-07 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/357726 ) Change subject: Give extensions a fallback icon when invisible .. Give extensions a fallback icon when invisible Bug: T166526 Change-Id:

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Remove unused MWImage-specific CSS

2017-06-07 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/357578 ) Change subject: Remove unused MWImage-specific CSS .. Remove unused MWImage-specific CSS This was moved into MW 3 years ago. Change-Id:

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Remove unused filibuster CSS

2017-06-07 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/357579 ) Change subject: Remove unused filibuster CSS .. Remove unused filibuster CSS Filibuster doesn't generate any table cells. Change-Id:

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Remove unused table editor CSS

2017-06-07 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/357577 ) Change subject: Remove unused table editor CSS .. Remove unused table editor CSS This is left over from before we implemented

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: dm.MWTransclusionNode: Move mixin comment, remove duplicated...

2017-06-06 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/357401 ) Change subject: dm.MWTransclusionNode: Move mixin comment, remove duplicated static property .. dm.MWTransclusionNode: Move mixin

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Fix mixing in of TableCellableNode to AlienTableCellNode

2017-06-06 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/357400 ) Change subject: Fix mixing in of TableCellableNode to AlienTableCellNode .. Fix mixing in of TableCellableNode to AlienTableCellNode Only

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: VisualDiff: Fix doc child replacement

2017-06-06 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/357397 ) Change subject: VisualDiff: Fix doc child replacement .. VisualDiff: Fix doc child replacement If types are not equal, mark the change as

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Add filename to gallery dialog page

2017-06-06 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/357394 ) Change subject: Add filename to gallery dialog page .. Add filename to gallery dialog page Also add fieldset headings consistent with

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Allow special character items to be marked as source mode only

2017-06-06 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/357385 ) Change subject: Allow special character items to be marked as source mode only .. Allow special character items to be marked as source

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Don't try to i18n-parse JSON string

2017-06-06 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/357360 ) Change subject: Don't try to i18n-parse JSON string .. Don't try to i18n-parse JSON string Bug: T167051 Change-Id:

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: DiffElement: Pass through config argument

2017-06-05 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/357231 ) Change subject: DiffElement: Pass through config argument .. DiffElement: Pass through config argument Change-Id:

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Rename local variables to distinguish between DM nodes and o...

2017-06-03 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/356998 ) Change subject: Rename local variables to distinguish between DM nodes and orderedNodes .. Rename local variables to distinguish between

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Guard against mwdata.body being null

2017-06-01 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/356581 ) Change subject: Guard against mwdata.body being null .. Guard against mwdata.body being null Bug: T166754 Change-Id:

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Add missing icon sets to rebaser demo

2017-06-01 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/356579 ) Change subject: Add missing icon sets to rebaser demo .. Add missing icon sets to rebaser demo Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Remove rarely-violated and auto-fixable eslint exceptions

2017-06-01 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/356577 ) Change subject: Remove rarely-violated and auto-fixable eslint exceptions .. Remove rarely-violated and auto-fixable eslint exceptions

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: [PULL THROUGH] Author list popup

2017-05-31 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/356451 ) Change subject: [PULL THROUGH] Author list popup .. [PULL THROUGH] Author list popup Change-Id: I36bcaf122528a4a12882aaff3b33ef936082a391

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Add missing icon set 'layout'

2017-05-31 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/356439 ) Change subject: Add missing icon set 'layout' .. Add missing icon set 'layout' Change-Id: Ie9d9df25646aa7e32b7eee6e170a6289481b9175 --- M

[MediaWiki-commits] [Gerrit] oojs/core[master]: eslint: Fix valid-jsdoc issues

2017-05-31 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/356419 ) Change subject: eslint: Fix valid-jsdoc issues .. eslint: Fix valid-jsdoc issues Leave rule disabled due to @chainable issue. Change-Id:

[MediaWiki-commits] [Gerrit] oojs/core[master]: Drop code supporting ES3 / IE<=9

2017-05-31 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/356344 ) Change subject: Drop code supporting ES3 / IE<=9 .. Drop code supporting ES3 / IE<=9 Change-Id: I6d20179860f133093b722affc24175224585cd74

[MediaWiki-commits] [Gerrit] oojs/core[master]: build: Update eslint to 0.4.0

2017-05-31 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/356343 ) Change subject: build: Update eslint to 0.4.0 .. build: Update eslint to 0.4.0 * Remove 'fix' option, not very useful anymore * Add

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Make author list a ListPopupTool

2017-05-30 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/356238 ) Change subject: Make author list a ListPopupTool .. Make author list a ListPopupTool Change-Id: I6180216e04747e4d230bdf782422643f61e01574

[MediaWiki-commits] [Gerrit] oojs/ui[master]: Only cancel mouse down event if tool in toolgroup clicked on

2017-05-30 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/356216 ) Change subject: Only cancel mouse down event if tool in toolgroup clicked on .. Only cancel mouse down event if tool in toolgroup clicked

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Auto-fix whitespaces issues with eslint

2017-05-28 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/355953 ) Change subject: Auto-fix whitespaces issues with eslint .. Auto-fix whitespaces issues with eslint Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Fix indentation according to eslint rules

2017-05-28 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/355900 ) Change subject: Fix indentation according to eslint rules .. Fix indentation according to eslint rules Eslint will be introduced in a

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Prevent massive loop by binding to the wrong method

2017-05-25 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/355712 ) Change subject: Prevent massive loop by binding to the wrong method .. Prevent massive loop by binding to the wrong method We were bind

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Don't add transactions to stack until they've had a chance t...

2017-05-25 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/355582 ) Change subject: Don't add transactions to stack until they've had a chance to fail .. Don't add transactions to stack until they've had a

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: describeChange can be null

2017-05-24 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/355438 ) Change subject: describeChange can be null .. describeChange can be null Change-Id: Iae42175d544d6ccba8ab7fe79b290443810743c2 --- M

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Remove dialog height hack tagged against resolved bug

2017-05-23 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/355247 ) Change subject: Remove dialog height hack tagged against resolved bug .. Remove dialog height hack tagged against resolved bug Bug:

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Drop support for Android 3

2017-05-22 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/355091 ) Change subject: Drop support for Android 3 .. Drop support for Android 3 Literally nobody uses it (0 reports on analytics) and we can't

[MediaWiki-commits] [Gerrit] oojs/ui[master]: Make disabled progress bar in demo determinate

2017-05-22 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/355089 ) Change subject: Make disabled progress bar in demo determinate .. Make disabled progress bar in demo determinate Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...WikiEditor[master]: Fix broken use of $.data as setter

2017-05-22 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/355084 ) Change subject: Fix broken use of $.data as setter .. Fix broken use of $.data as setter Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...WikiEditor[master]: Remove IE8 hacks

2017-05-22 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/355083 ) Change subject: Remove IE8 hacks .. Remove IE8 hacks Change-Id: I23e33e3498487bedcc50d95e2162175e940882c4 --- M

[MediaWiki-commits] [Gerrit] mediawiki...LiquidThreads[master]: Remove hacks for unsupported IE versions

2017-05-21 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/355005 ) Change subject: Remove hacks for unsupported IE versions .. Remove hacks for unsupported IE versions Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...LiquidThreads[master]: Re-initialize WikiEditor when not present

2017-05-21 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/355002 ) Change subject: Re-initialize WikiEditor when not present .. Re-initialize WikiEditor when not present Bug: T165976 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...LiquidThreads[master]: Remove unused jQuery.autogrow

2017-05-21 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/355001 ) Change subject: Remove unused jQuery.autogrow .. Remove unused jQuery.autogrow Change-Id: Ib8b2fd4d1306eec40adefaaca2219fd6a2fe4f34 --- M

[MediaWiki-commits] [Gerrit] mediawiki...LiquidThreads[master]: Remove code that initialises WikiEditor

2017-05-21 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/354941 ) Change subject: Remove code that initialises WikiEditor .. Remove code that initialises WikiEditor If WikiEditor is installed, then

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: rebaser: Initialize toolbar

2017-05-21 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/354921 ) Change subject: rebaser: Initialize toolbar .. rebaser: Initialize toolbar Change-Id: I06e66859219e8d657063f24c59811338a195a28b --- M

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: rebaser: Move synchronizer/authorList to Target from Target....

2017-05-20 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/354870 ) Change subject: rebaser: Move synchronizer/authorList to Target from Target.init .. rebaser: Move synchronizer/authorList to Target from

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: WIP Export to wikitext dialog

2017-05-20 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/354871 ) Change subject: WIP Export to wikitext dialog .. WIP Export to wikitext dialog Change-Id: I49841fd17dd106154a2f53df2e051c6dc0cc3910 --- M

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Move getWikitextFragment up to Target from ArticleTarget

2017-05-20 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/354869 ) Change subject: Move getWikitextFragment up to Target from ArticleTarget .. Move getWikitextFragment up to Target from ArticleTarget Any

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: rebaser: Add popstate/teardown handling

2017-05-20 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/354755 ) Change subject: rebaser: Add popstate/teardown handling .. rebaser: Add popstate/teardown handling Change-Id:

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: rebaser: Focus surface on load

2017-05-20 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/354718 ) Change subject: rebaser: Focus surface on load .. rebaser: Focus surface on load Change-Id: I5c7a921de014e5ad70063c6b46db6c23067af435 ---

[MediaWiki-commits] [Gerrit] oojs/ui[master]: Add more TextInpuWidget + label examples to demo

2017-05-20 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/354678 ) Change subject: Add more TextInpuWidget + label examples to demo .. Add more TextInpuWidget + label examples to demo Bug: T165866

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: rebaser: Make serializations shorter (2nd attempt)

2017-05-20 Thread Esanders (Code Review)
Hello Catrope, Divec, jenkins-bot, Jforrester, I'd like you to do a code review. Please visit https://gerrit.wikimedia.org/r/354659 to review the following change. Change subject: rebaser: Make serializations shorter (2nd attempt)

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Fix instantly closing progress bars in jQuery 3

2017-05-20 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/354658 ) Change subject: Fix instantly closing progress bars in jQuery 3 .. Fix instantly closing progress bars in jQuery 3 Change-Id:

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Revert "rebaser: Make serializations shorter"

2017-05-19 Thread Esanders (Code Review)
Hello Catrope, Divec, jenkins-bot, Jforrester, I'd like you to do a code review. Please visit https://gerrit.wikimedia.org/r/354556 to review the following change. Change subject: Revert "rebaser: Make serializations shorter"

[MediaWiki-commits] [Gerrit] oojs/ui[master]: icon: Copy userAvatar to Apex

2017-05-19 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/354513 ) Change subject: icon: Copy userAvatar to Apex .. icon: Copy userAvatar to Apex Change-Id: I7666910b2c79c0f387101d9fa20b9b1957398b6b --- M

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: rebaser: Show active user count

2017-05-19 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/354499 ) Change subject: rebaser: Show active user count .. rebaser: Show active user count Change-Id: Ic8321cc4f2c668f80f466c457340544ff28294d8

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: rebaser: Move author list to widget

2017-05-19 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/354498 ) Change subject: rebaser: Move author list to widget .. rebaser: Move author list to widget Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Allow extension nodes to convert to a specified type of data...

2017-05-19 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/354492 ) Change subject: Allow extension nodes to convert to a specified type of dataElement .. Allow extension nodes to convert to a specified

[MediaWiki-commits] [Gerrit] mediawiki...SyntaxHighlight_GeSHi[master]: Pass dataElement type to parent's toDataElement

2017-05-19 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/354491 ) Change subject: Pass dataElement type to parent's toDataElement .. Pass dataElement type to parent's toDataElement Ensures the rendering

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Always prefer wikitext for action=edit on non-SET wikis

2017-05-15 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/353858 ) Change subject: Always prefer wikitext for action=edit on non-SET wikis .. Always prefer wikitext for action=edit on non-SET wikis

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Fix action=edit links for NWE

2017-05-15 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/353854 ) Change subject: Fix action=edit links for NWE .. Fix action=edit links for NWE We added support loading NWE from action=edit in

[MediaWiki-commits] [Gerrit] mediawiki...SyntaxHighlight_GeSHi[master]: VE: Support editing start line parameter

2017-05-14 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/353764 ) Change subject: VE: Support editing start line parameter .. VE: Support editing start line parameter Change-Id:

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: VisualDiff: Show attribute changes for inline objects

2017-05-11 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/353331 ) Change subject: VisualDiff: Show attribute changes for inline objects .. VisualDiff: Show attribute changes for inline objects Change-Id:

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: VisualDiff: Bring in close dialog fix from downstream

2017-05-11 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/353330 ) Change subject: VisualDiff: Bring in close dialog fix from downstream .. VisualDiff: Bring in close dialog fix from downstream Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...UniversalLanguageSelector[master]: build: Update eslint to 0.4.0

2017-05-11 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/353320 ) Change subject: build: Update eslint to 0.4.0 .. build: Update eslint to 0.4.0 Change-Id: I1931699c578de724996649838b73d514e1e03477 --- M

[MediaWiki-commits] [Gerrit] mediawiki...Scribunto[master]: build: Replace jscs/jshint with eslint

2017-05-11 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/353314 ) Change subject: build: Replace jscs/jshint with eslint .. build: Replace jscs/jshint with eslint Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...Linter[master]: build: Replace jshint/jscs with eslint

2017-05-11 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/353313 ) Change subject: build: Replace jshint/jscs with eslint .. build: Replace jshint/jscs with eslint Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...ProofreadPage[master]: build: Replace jshint/jscs with eslint

2017-05-11 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/353308 ) Change subject: build: Replace jshint/jscs with eslint .. build: Replace jshint/jscs with eslint Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...MassMessage[master]: build: Replace jshint/jscs with eslint

2017-05-11 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/353306 ) Change subject: build: Replace jshint/jscs with eslint .. build: Replace jshint/jscs with eslint Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...GeoData[master]: build: Replace jshint with eslint

2017-05-11 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/353300 ) Change subject: build: Replace jshint with eslint .. build: Replace jshint with eslint Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...cldr[master]: build: Replace jshint with eslint

2017-05-11 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/353296 ) Change subject: build: Replace jshint with eslint .. build: Replace jshint with eslint Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Convert Special:Undelete search form to use OOUI

2017-05-09 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/352874 ) Change subject: Convert Special:Undelete search form to use OOUI .. Convert Special:Undelete search form to use OOUI Bug: T113758

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Convert article delete to use OOUI

2017-05-09 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/352863 ) Change subject: Convert article delete to use OOUI .. Convert article delete to use OOUI Bug: T113758 Change-Id:

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Upgrade tree differ to support timeouts, and handle them

2017-05-08 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/352669 ) Change subject: Upgrade tree differ to support timeouts, and handle them .. Upgrade tree differ to support timeouts, and handle them Bug:

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Generate visual diff only after switching to visual diff tab

2017-05-08 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/352642 ) Change subject: Generate visual diff only after switching to visual diff tab .. Generate visual diff only after switching to visual diff

[MediaWiki-commits] [Gerrit] mediawiki...Translate[master]: lint: Inline alert exceptions, and remove window. prefix con...

2017-05-05 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/352110 ) Change subject: lint: Inline alert exceptions, and remove window. prefix consistently .. lint: Inline alert exceptions, and remove

[MediaWiki-commits] [Gerrit] mediawiki...RelatedArticles[master]: build: Update linters

2017-05-05 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/352109 ) Change subject: build: Update linters .. build: Update linters Change-Id: I524c23c92d2d356ba1ce9552c7a0028c670e054f --- M Gruntfile.js M

[MediaWiki-commits] [Gerrit] mediawiki...wikihiero[master]: build: Update eslint to 0.4.0

2017-05-04 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/352042 ) Change subject: build: Update eslint to 0.4.0 .. build: Update eslint to 0.4.0 Change-Id: I3b9725dee021483022f5037826675cbd97c244ac --- M

[MediaWiki-commits] [Gerrit] mediawiki...WikiEditor[master]: build: Update eslint to 0.4.0 and make a pass

2017-05-04 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/352041 ) Change subject: build: Update eslint to 0.4.0 and make a pass .. build: Update eslint to 0.4.0 and make a pass Change-Id:

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: build: Update eslint to 0.4.0 and make a pass

2017-05-04 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/352040 ) Change subject: build: Update eslint to 0.4.0 and make a pass .. build: Update eslint to 0.4.0 and make a pass Change-Id:

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Fix typos and minor lint issues

2017-05-04 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/352038 ) Change subject: Fix typos and minor lint issues .. Fix typos and minor lint issues * HistoryCommand: Remove unnecessary 'call' and rename

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Avoid using the global namespace in test files

2017-05-04 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/352039 ) Change subject: Avoid using the global namespace in test files .. Avoid using the global namespace in test files Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: build: Update eslint to 0.4.0 and make a pass

2017-05-04 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/352036 ) Change subject: build: Update eslint to 0.4.0 and make a pass .. build: Update eslint to 0.4.0 and make a pass Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...TwoColConflict[master]: build: Update eslint to 0.4.0 and make a pass

2017-05-04 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/352033 ) Change subject: build: Update eslint to 0.4.0 and make a pass .. build: Update eslint to 0.4.0 and make a pass Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...Translate[master]: build: Remove eslint:fix

2017-05-04 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/352035 ) Change subject: build: Remove eslint:fix .. build: Remove eslint:fix Not as useful now the rules are stable. Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...Translate[master]: build: Update eslint to 0.4.0 and make a pass

2017-05-04 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/352034 ) Change subject: build: Update eslint to 0.4.0 and make a pass .. build: Update eslint to 0.4.0 and make a pass Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...SyntaxHighlight_GeSHi[master]: build: Update eslint to 0.4.0

2017-05-04 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/352013 ) Change subject: build: Update eslint to 0.4.0 .. build: Update eslint to 0.4.0 Change-Id: I0ea71dce95df6836c3a1dfecf4adedc7b1ae9f2f --- M

[MediaWiki-commits] [Gerrit] mediawiki...MultimediaViewer[master]: build: Update eslint to 0.4.0 and make a pass

2017-05-04 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/352014 ) Change subject: build: Update eslint to 0.4.0 and make a pass .. build: Update eslint to 0.4.0 and make a pass Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...TemplateSandbox[master]: build: Update eslint to 0.4.0

2017-05-04 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/352012 ) Change subject: build: Update eslint to 0.4.0 .. build: Update eslint to 0.4.0 Change-Id: Ifcb2477678cba0a2f68a41ebed627a1c5c86617f --- M

[MediaWiki-commits] [Gerrit] mediawiki...TimedMediaHandler[master]: build: Update eslint to 0.4.0 and make a pass

2017-05-04 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/352011 ) Change subject: build: Update eslint to 0.4.0 and make a pass .. build: Update eslint to 0.4.0 and make a pass Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...TemplateData[master]: build: Update eslint to 0.4.0

2017-05-04 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/352005 ) Change subject: build: Update eslint to 0.4.0 .. build: Update eslint to 0.4.0 Change-Id: Ief28d7ca2459afb6a1ff30ccdd5c97d71e51f243 --- M

[MediaWiki-commits] [Gerrit] mediawiki...Score[master]: build: Update eslint to 0.4.0

2017-05-04 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/352001 ) Change subject: build: Update eslint to 0.4.0 .. build: Update eslint to 0.4.0 Change-Id: I840cc76d21b1d0b7adb013e14b66102b3db45736 --- M

[MediaWiki-commits] [Gerrit] mediawiki...RevisionSlider[master]: build: Update eslint to 0.4.0 and make a pass

2017-05-04 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/351997 ) Change subject: build: Update eslint to 0.4.0 and make a pass .. build: Update eslint to 0.4.0 and make a pass Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: build: Update eslint to 0.4.0 and make a pass

2017-05-04 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/351993 ) Change subject: build: Update eslint to 0.4.0 and make a pass .. build: Update eslint to 0.4.0 and make a pass Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: build: Update eslint to 0.4.0 and make a pass

2017-05-04 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/351988 ) Change subject: build: Update eslint to 0.4.0 and make a pass .. build: Update eslint to 0.4.0 and make a pass Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...ORES[master]: build: Update eslint to 0.4.0

2017-05-04 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/351989 ) Change subject: build: Update eslint to 0.4.0 .. build: Update eslint to 0.4.0 Change-Id: Ie5af930b9d7703d33f5958f43efb7af6d9f9e4db --- M

[MediaWiki-commits] [Gerrit] mediawiki...Math[master]: build: Update eslint to 0.4.0

2017-05-04 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/351987 ) Change subject: build: Update eslint to 0.4.0 .. build: Update eslint to 0.4.0 Change-Id: I991df38973cac0dfc018bca925578648be6ee389 --- M

[MediaWiki-commits] [Gerrit] mediawiki...Kartographer[master]: build: Update eslint to 0.4.0 and make a pass

2017-05-04 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/351953 ) Change subject: build: Update eslint to 0.4.0 and make a pass .. build: Update eslint to 0.4.0 and make a pass Change-Id:

<    1   2   3   4   5   6   7   8   9   10   >