[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Register wgMinervaApplyKnownTemplateHacks via a Minerva hook

2017-05-20 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/354717 ) Change subject: Register wgMinervaApplyKnownTemplateHacks via a Minerva hook .. Register wgMinervaApplyKnownTemplateHacks via a Minerva

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Define skins.minerva.notifications in extension.json

2017-05-20 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/354715 ) Change subject: Define skins.minerva.notifications in extension.json .. Define skins.minerva.notifications in extension.json This can

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Introduce skinStyles folder

2017-05-20 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/354712 ) Change subject: Introduce skinStyles folder .. Introduce skinStyles folder * Introduce skinStyles folder for Minerva specific styles

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: MainMenu renames to Minerva not MobileFrontend

2017-05-20 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/354710 ) Change subject: MainMenu renames to Minerva not MobileFrontend .. MainMenu renames to Minerva not MobileFrontend While trying to

[MediaWiki-commits] [Gerrit] mediawiki...trending-edits[master]: BECOME MODERN!! Use const/let

2017-05-19 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/354490 ) Change subject: BECOME MODERN!! Use const/let .. BECOME MODERN!! Use const/let Change-Id: I4b47d9d996dcab9893c8e177fab245699ff031b6 ---

[MediaWiki-commits] [Gerrit] mediawiki...RelatedArticles[master]: DONOTMERGE: UI REGRESSION

2017-05-16 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/354001 ) Change subject: DONOTMERGE: UI REGRESSION .. DONOTMERGE: UI REGRESSION Change-Id: Ic4341759837ae97012df414bf525338ca418c635 --- M

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Add support for UI regression testing

2017-05-16 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/353993 ) Change subject: Add support for UI regression testing .. Add support for UI regression testing This adds wiring for

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Enable print styles for Minerva

2017-05-16 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/353979 ) Change subject: Enable print styles for Minerva .. Enable print styles for Minerva Bug: T163287 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...QuickSurveys[wmf/1.30.0-wmf.1]: Explicitly add mediawiki.cookie dependency

2017-05-16 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/353978 ) Change subject: Explicitly add mediawiki.cookie dependency .. Explicitly add mediawiki.cookie dependency This is needed to remember

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: DONOTMERGE: check uncompressed svg addition

2017-05-16 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/353959 ) Change subject: DONOTMERGE: check uncompressed svg addition .. DONOTMERGE: check uncompressed svg addition Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...RelatedArticles[master]: WIP: Webdriver CSS regression test

2017-05-15 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/353902 ) Change subject: WIP: Webdriver CSS regression test .. WIP: Webdriver CSS regression test To use: * Install webdrivercss in core

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[wmf/1.30.0-wmf.1]: Revert "Use csrf token for watching"

2017-05-15 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/353880 ) Change subject: Revert "Use csrf token for watching" .. Revert "Use csrf token for watching" Additional changes * Pass message to error

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Revert "Use csrf token for watching"

2017-05-15 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/353843 ) Change subject: Revert "Use csrf token for watching" .. Revert "Use csrf token for watching" Additional change: Pass message to error

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: WIP: ReferencesController

2017-05-12 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/353546 ) Change subject: WIP: ReferencesController .. WIP: ReferencesController Bug: T130551 Change-Id: Id607067c9716cf7a4a74e6cd00ed0e8541d152bb

[MediaWiki-commits] [Gerrit] mediawiki...QuickSurveys[master]: Explicitly add mediawiki.cookie dependency

2017-05-11 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/353294 ) Change subject: Explicitly add mediawiki.cookie dependency .. Explicitly add mediawiki.cookie dependency This is needed to remember

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Only wrap top level headings

2017-05-11 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/353293 ) Change subject: Only wrap top level headings .. Only wrap top level headings Changes: * prepareHeadings is now prepareHeading * A

[MediaWiki-commits] [Gerrit] mediawiki...QuickSurveys[master]: DONOTMERGE: Testing browser tests

2017-05-11 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/353288 ) Change subject: DONOTMERGE: Testing browser tests .. DONOTMERGE: Testing browser tests Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...QuickSurveys[master]: Do not run internal or external survey browser tests on BC

2017-05-11 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/353276 ) Change subject: Do not run internal or external survey browser tests on BC .. Do not run internal or external survey browser tests on BC

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Updates to print styles

2017-05-10 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/353051 ) Change subject: Updates to print styles .. Updates to print styles * hatnotes are hidden on mobile * Adjusted vertical padding of

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Add new Arabic Wikipedia logo

2017-05-10 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/353012 ) Change subject: Add new Arabic Wikipedia logo .. Add new Arabic Wikipedia logo Bug: T164648 Change-Id:

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Disable page previews beta features on various projects

2017-05-10 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/353011 ) Change subject: Disable page previews beta features on various projects .. Disable page previews beta features on various projects Bug:

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: False references should fall back to hash change

2017-05-08 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/352614 ) Change subject: False references should fall back to hash change .. False references should fall back to hash change If a reference

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: $wmgRelatedArticlesShowInSidebar is now undefined

2017-05-08 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/352596 ) Change subject: $wmgRelatedArticlesShowInSidebar is now undefined .. $wmgRelatedArticlesShowInSidebar is now undefined Remove this line

[MediaWiki-commits] [Gerrit] mediawiki...trending-edits[master]: Include reverts from bots

2017-05-08 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/352553 ) Change subject: Include reverts from bots .. Include reverts from bots Reverts from bots e.g. ClueBot are important for detecting

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Add Bengali logo to mobile site

2017-05-08 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/352547 ) Change subject: Add Bengali logo to mobile site .. Add Bengali logo to mobile site Bug: T164652 Change-Id:

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Clean up inappropriate usages of wmg

2017-05-04 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/351922 ) Change subject: Clean up inappropriate usages of wmg .. Clean up inappropriate usages of wmg Assuming that appropriate usage is only for

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Use transparent gif as lazy-image-placeholder

2017-05-03 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/351736 ) Change subject: Use transparent gif as lazy-image-placeholder .. Use transparent gif as lazy-image-placeholder The advantage of using an

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Wikivoyage should show related pages in footer of skin

2017-05-03 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/351664 ) Change subject: Wikivoyage should show related pages in footer of skin .. Wikivoyage should show related pages in footer of skin Bug:

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: All dd elements should use overflow scroll

2017-05-03 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/351662 ) Change subject: All dd elements should use overflow scroll .. All dd elements should use overflow scroll If a dd element contains an

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Use upstreamed mixins

2017-05-02 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/351563 ) Change subject: Use upstreamed mixins .. Use upstreamed mixins Depends-On: Ic2a68d2fa62dc079743de641ada4c7f4dd294f2f Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Upstream the transform mixin from MobileFrontend

2017-05-02 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/351561 ) Change subject: Upstream the transform mixin from MobileFrontend .. Upstream the transform mixin from MobileFrontend This is useful and

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Add quick shorthand for SVG generation

2017-05-02 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/351562 ) Change subject: Add quick shorthand for SVG generation .. Add quick shorthand for SVG generation Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Upstream transition-transform mixin from MobileFrontend

2017-05-02 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/351560 ) Change subject: Upstream transition-transform mixin from MobileFrontend .. Upstream transition-transform mixin from MobileFrontend This

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Use csrf token for watching

2017-05-02 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/351549 ) Change subject: Use csrf token for watching .. Use csrf token for watching Using watchtoken will fail on Tilman's Firefox device. Use of

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Add missing i18n message for watchstar failures

2017-05-02 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/351542 ) Change subject: Add missing i18n message for watchstar failures .. Add missing i18n message for watchstar failures Change-Id:

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Enable related pages for everyone

2017-05-02 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/351534 ) Change subject: Enable related pages for everyone .. Enable related pages for everyone Bug: T155079 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Hygiene: Don't unnecessarily use loadModuleScript

2017-05-01 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/351220 ) Change subject: Hygiene: Don't unnecessarily use loadModuleScript .. Hygiene: Don't unnecessarily use loadModuleScript This is loaded

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Hygiene: Notification filter

2017-05-01 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/351211 ) Change subject: Hygiene: Notification filter .. Hygiene: Notification filter Address bug: * Move creation of OOjs UI element inside

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Weaken noresize css rule

2017-05-01 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/351192 ) Change subject: Weaken noresize css rule .. Weaken noresize css rule Should apply to any img inside an element with the noresize class

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Correction to config definition

2017-05-01 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/351166 ) Change subject: Correction to config definition .. Correction to config definition Avoid conflicts between Navigation popup gadget

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: POC: The big Minerva submodule switcheroo

2017-04-28 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/350963 ) Change subject: POC: The big Minerva submodule switcheroo .. POC: The big Minerva submodule switcheroo TODO: Work out why the skin

[MediaWiki-commits] [Gerrit] integration/config[master]: Add experimental Node selenium job

2017-04-28 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/350941 ) Change subject: Add experimental Node selenium job .. Add experimental Node selenium job This will help us migrate the browser tests.

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Placeholders should not be block

2017-04-26 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/350496 ) Change subject: Placeholders should not be block .. Placeholders should not be block After applying this fix, the reflow drops

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Update browser tests for main menu non-Js experience

2017-04-26 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/350464 ) Change subject: Update browser tests for main menu non-Js experience .. Update browser tests for main menu non-Js experience This

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Workaround issue of overriding whitelist config variable

2017-04-26 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/350459 ) Change subject: Workaround issue of overriding whitelist config variable .. Workaround issue of overriding whitelist config variable

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Follow up to Ia1a6da9d844bd3ca7288a8d4f5f81a955e4061b4

2017-04-24 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/350095 ) Change subject: Follow up to Ia1a6da9d844bd3ca7288a8d4f5f81a955e4061b4 .. Follow up to Ia1a6da9d844bd3ca7288a8d4f5f81a955e4061b4 Use wmg

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Disable Page previews beta feature on Wiktionary and Wikidata

2017-04-24 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/350038 ) Change subject: Disable Page previews beta feature on Wiktionary and Wikidata .. Disable Page previews beta feature on Wiktionary and

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Category overlay should show "content based" categories

2017-04-24 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/349974 ) Change subject: Category overlay should show "content based" categories .. Category overlay should show "content based" categories Only

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: DONOTMERGE: Allow browser to progressively render images

2017-04-21 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/349717 ) Change subject: DONOTMERGE: Allow browser to progressively render images .. DONOTMERGE: Allow browser to progressively render images

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Drop SkinMinervaBeta

2017-04-20 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/349353 ) Change subject: Drop SkinMinervaBeta .. Drop SkinMinervaBeta beta flag is now set as a skin option when the skin is created The config

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: Generate cog icon via ResourceLoaderImage module

2017-04-20 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/349344 ) Change subject: Generate cog icon via ResourceLoaderImage module .. Generate cog icon via ResourceLoaderImage module * Merge

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: POC: Use JavaScript to animate the ease-in of lazy loaded image

2017-04-20 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/349275 ) Change subject: POC: Use JavaScript to animate the ease-in of lazy loaded image .. POC: Use JavaScript to animate the ease-in of lazy

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Search button should not be wrapped in a link

2017-04-20 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/349261 ) Change subject: Search button should not be wrapped in a link .. Search button should not be wrapped in a link This looks like an

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Please don't abuse global events on M object when you dont n...

2017-04-20 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/349252 ) Change subject: Please don't abuse global events on M object when you dont need to .. Please don't abuse global events on M object when

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: POC: Provide a formatter that routes through live Wikipedia ...

2017-04-19 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/349131 ) Change subject: POC: Provide a formatter that routes through live Wikipedia content .. POC: Provide a formatter that routes through live

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Create IParserContentFormatter for using different formattin...

2017-04-19 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/349130 ) Change subject: Create IParserContentFormatter for using different formatting engines .. Create IParserContentFormatter for using

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Reveal login/logout buttons when non-js editing is available

2017-04-19 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/349114 ) Change subject: Reveal login/logout buttons when non-js editing is available .. Reveal login/logout buttons when non-js editing is

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Restrict lazy loaded images to the viewport

2017-04-19 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/349107 ) Change subject: Restrict lazy loaded images to the viewport .. Restrict lazy loaded images to the viewport When lazy loading an image

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Move Log

2017-04-19 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/348953 ) Change subject: Move Log .. Move Log * MFCustomLogos renamed to MinervaCustomLogos since it is Minerva specific. For backwards

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Merge remote-tracking branch 'origin/printstyles' into print...

2017-04-18 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/348878 ) Change subject: Merge remote-tracking branch 'origin/printstyles' into printstylesdeploy .. Merge remote-tracking branch

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Drop unused config variable MFIgnoreEventLoggingBucketing

2017-04-18 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/348877 ) Change subject: Drop unused config variable MFIgnoreEventLoggingBucketing .. Drop unused config variable MFIgnoreEventLoggingBucketing

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[printstyles]: Tweak page margins

2017-04-18 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/348876 ) Change subject: Tweak page margins .. Tweak page margins Per Nirzar: The second page had no top margin Drop top padding on header to

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Merge remote-tracking branch 'origin/master' into HEAD

2017-04-18 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/348871 ) Change subject: Merge remote-tracking branch 'origin/master' into HEAD .. Merge remote-tracking branch 'origin/master' into HEAD

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Hygiene: Refactor Notification code - add NotificationBadge ...

2017-04-18 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/348795 ) Change subject: Hygiene: Refactor Notification code - add NotificationBadge class .. Hygiene: Refactor Notification code - add

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Avoid loading toasts in tests that are not testing toasts

2017-04-17 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/348641 ) Change subject: Avoid loading toasts in tests that are not testing toasts .. Avoid loading toasts in tests that are not testing toasts

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Add test for main menu in RTL mode

2017-04-17 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/348638 ) Change subject: Add test for main menu in RTL mode .. Add test for main menu in RTL mode Bug: T163059 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: CSSJanus now flips transforms so .rtl rules break main menu

2017-04-17 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/348568 ) Change subject: CSSJanus now flips transforms so .rtl rules break main menu .. CSSJanus now flips transforms so .rtl rules break main

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Notification icon tweak for better IE support

2017-04-17 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/348518 ) Change subject: Notification icon tweak for better IE support .. Notification icon tweak for better IE support Rather than trying to

[MediaWiki-commits] [Gerrit] mediawiki...PageImages[master]: DONOTMERGE

2017-04-17 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/348517 ) Change subject: DONOTMERGE .. DONOTMERGE Change-Id: I7f80c7e85f8dc937e74c5630db12740a4339a450 --- M PageImages.php 1 file changed, 1

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Remove border-bottom from section headings in print mode

2017-04-17 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/348488 ) Change subject: Remove border-bottom from section headings in print mode .. Remove border-bottom from section headings in print mode

[MediaWiki-commits] [Gerrit] mediawiki...ContactPage[master]: Drop DisplayFormat configuration

2017-04-17 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/348483 ) Change subject: Drop DisplayFormat configuration .. Drop DisplayFormat configuration Force ooui display format for all contact forms

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Remove mobile user modules

2017-04-17 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/348480 ) Change subject: Remove mobile user modules .. Remove mobile user modules These replicate functionality in core. Use User

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Correctly enforce config for related pages

2017-04-17 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/348472 ) Change subject: Correctly enforce config for related pages .. Correctly enforce config for related pages This avoids it showing up in

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[printstyles]: Improved infobox style hacks

2017-04-13 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/348183 ) Change subject: Improved infobox style hacks .. Improved infobox style hacks * Increased padding for table cells; * The table occupies

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Remove use of blacklist for related pages feature

2017-04-13 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/348176 ) Change subject: Remove use of blacklist for related pages feature .. Remove use of blacklist for related pages feature Bug: T162201

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Enable related pages on Vector for htwiki

2017-04-13 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/348161 ) Change subject: Enable related pages on Vector for htwiki .. Enable related pages on Vector for htwiki Bug: T126826 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Tweaks for printing layout

2017-04-12 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/348007 ) Change subject: Tweaks for printing layout .. Tweaks for printing layout * Use @page to override print margins in Chrome and force legal

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[wmf/1.29.0-wmf.20]: Log only infoboxes which are not a direct children of lead s...

2017-04-12 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/347990 ) Change subject: Log only infoboxes which are not a direct children of lead section .. Log only infoboxes which are not a direct children

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[printstyles]: h3->h5 should be san-serif

2017-04-12 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/347890 ) Change subject: h3->h5 should be san-serif .. h3->h5 should be san-serif We discussed this during implementation of the print styles.

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Tweak Russian logo wordmark

2017-04-12 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/347888 ) Change subject: Tweak Russian logo wordmark .. Tweak Russian logo wordmark Change dimensions and asset Bug: T162036 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[wmf/1.29.0-wmf.20]: setMobileOptions at time of skin creation

2017-04-12 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/347885 ) Change subject: setMobileOptions at time of skin creation .. setMobileOptions at time of skin creation Introduce

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[printstyles]: Don't change block quote styling in tablets

2017-04-11 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/347793 ) Change subject: Don't change block quote styling in tablets .. Don't change block quote styling in tablets The mock doesn't ask for this

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: setMobileOptions at time of skin creation

2017-04-11 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/347786 ) Change subject: setMobileOptions at time of skin creation .. setMobileOptions at time of skin creation Introduce

[MediaWiki-commits] [Gerrit] mediawiki...MinervaNeue[master]: Add scaffolding and migration script

2017-04-11 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/347775 ) Change subject: Add scaffolding and migration script .. Add scaffolding and migration script Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: WIP: Separate MobileFrontend and Minerva abstractions

2017-04-11 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/347768 ) Change subject: WIP: Separate MobileFrontend and Minerva abstractions .. WIP: Separate MobileFrontend and Minerva abstractions * Move

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Add mobile specific modules inside BeforePageDisplayMobile hook

2017-04-11 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/347671 ) Change subject: Add mobile specific modules inside BeforePageDisplayMobile hook .. Add mobile specific modules inside

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Deploy flicker free search

2017-04-11 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/347636 ) Change subject: Deploy flicker free search .. Deploy flicker free search Bug: T153973 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...ContactPage[master]: ContactForm should use OOUI for form rendering

2017-04-10 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/347535 ) Change subject: ContactForm should use OOUI for form rendering .. ContactForm should use OOUI for form rendering This makes the form

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[printstyles]: Tweaks for printing layout

2017-04-10 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/347533 ) Change subject: Tweaks for printing layout .. Tweaks for printing layout * Use @page to override print margins in Chrome * Limit desktop

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Remove deprecated config option

2017-04-10 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/347521 ) Change subject: Remove deprecated config option .. Remove deprecated config option This config flag doesn't do anything. Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: h3->h5 should be san-serif

2017-04-10 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/347520 ) Change subject: h3->h5 should be san-serif .. h3->h5 should be san-serif We discussed this during implementation of the print styles.

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Infobox print styles

2017-04-10 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/347516 ) Change subject: Infobox print styles .. Infobox print styles * Treat as table * Add padding * Align left * Add border to rows and table

[MediaWiki-commits] [Gerrit] mediawiki...QuickSurveys[master]: Only load bits of OOjs UI necessary for survey render

2017-04-10 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/347456 ) Change subject: Only load bits of OOjs UI necessary for survey render .. Only load bits of OOjs UI necessary for survey render This

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Mark images with width < 50 as inline

2017-04-07 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/347137 ) Change subject: Mark images with width < 50 as inline .. Mark images with width < 50 as inline At cost of potential reflows, try to

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Lead section edit icon should be visible when no-js editing ...

2017-04-07 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/347126 ) Change subject: Lead section edit icon should be visible when no-js editing is enabled .. Lead section edit icon should be visible when

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Improve layout of fallback editor

2017-04-07 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/347127 ) Change subject: Improve layout of fallback editor .. Improve layout of fallback editor This attempts to make the save changes button

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Hygiene: Folder rename + Document MFAllowNonJavaScriptEditin...

2017-04-07 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/347128 ) Change subject: Hygiene: Folder rename + Document MFAllowNonJavaScriptEditing config variable .. Hygiene: Folder rename + Document

[MediaWiki-commits] [Gerrit] mediawiki...RelatedArticles[master]: Upgrade to eslint

2017-04-07 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/347115 ) Change subject: Upgrade to eslint .. Upgrade to eslint We're going to want to use a newer version of JSHint anyway to support use of ES6

[MediaWiki-commits] [Gerrit] mediawiki...RelatedArticles[master]: Replace Ruby Related pages browser tests with node js version

2017-04-07 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/347116 ) Change subject: Replace Ruby Related pages browser tests with node js version .. Replace Ruby Related pages browser tests with node js

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Lint modules as part of npm-node-6-jessie

2017-04-07 Thread Jdlrobson (Code Review)
Jdlrobson has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/347051 ) Change subject: Lint modules as part of npm-node-6-jessie .. Lint modules as part of npm-node-6-jessie we now have ResourceLoader module

<    2   3   4   5   6   7   8   9   10   11   >