Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/324266
Change subject: Remove jscs in preparation for node template update
..
Remove jscs in preparation for node template update
The new node tem
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/324002
Change subject: Support inline `.hlists` for editors to avoid FOUC
..
Support inline `.hlists` for editors to avoid FOUC
Bug: T131423
Chang
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/323989
Change subject: Restrict page images to lead section
..
Restrict page images to lead section
When $wgPageImagesLeadSectionOnly is true rest
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/323897
Change subject: Track newly created pages
..
Track newly created pages
Bug: T145554
Change-Id: If71d673ac24fb229798d2c697f45b2e1deaf11cd
--
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/323878
Change subject: Disable Popups A/B test on Russian and Italian Wikipedias
..
Disable Popups A/B test on Russian and Italian Wikipedias
Bug:
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/323490
Change subject: Edit stream should replay edits up to the maximum age
..
Edit stream should replay edits up to the maximum age
Change-Id: I
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/323489
Change subject: Use Map for storing trending information
..
Use Map for storing trending information
It's better suited to this job.
Chang
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/323346
Change subject: Overlay content should have white background
..
Overlay content should have white background
It is currently transparent bu
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/323338
Change subject: EditWatchlist should always show 'List' as active
..
EditWatchlist should always show 'List' as active
Bug: T150650
Change-
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/323337
Change subject: Fix empty watchlist views
..
Fix empty watchlist views
A MobileCollection should be Countable
Additional changes:
* Add br
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/323324
Change subject: Record bytes change
..
Record bytes change
Note the bytes changed by the first revision are not available
and since we thro
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/323239
Change subject: WIP: Implement a configurable purge strategy
..
WIP: Implement a configurable purge strategy
To avoid taking up too much me
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/323238
Change subject: Use datacenter1 in development config for compatibility with
Vagrant
..
Use datacenter1 in development config for compatibi
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/323196
Change subject: Process move and delete events
..
Process move and delete events
Follow up to Ia711f3290e7331f4b9252289d964fa69d437e71e
and
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/323072
Change subject: Process contributor information and how biased editing is
..
Process contributor information and how biased editing is
A `c
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/323042
Change subject: Describe behaviour when pages are moved
..
Describe behaviour when pages are moved
Bug: T145554
Change-Id: I20907296aea5b3d
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/322787
Change subject: Exclude bots from edit count
..
Exclude bots from edit count
Bug: T145554
Change-Id: I5764455f14ab4baffcc89aec3539d0bfb8aa8
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/322784
Change subject: Ignore articles outside the main namespace
..
Ignore articles outside the main namespace
Bug: T145554
Change-Id: I006ac1daf
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/322773
Change subject: Lint PHP code
..
Lint PHP code
Change-Id: I494b01d1396bec17d2323d585f8594123d3e574b
---
M includes/ApiQueryPageImages.php
M
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/322710
Change subject: Hygiene: Generate user page talk icon via ResourceLoaderImage
module
..
Hygiene: Generate user page talk icon via ResourceL
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/322287
Change subject: Main page should not have an info property
..
Main page should not have an info property
Doing this can disrupt the renderi
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/322117
Change subject: Limit ios header hack to older versions
..
Limit ios header hack to older versions
This hack appears to be breaking newer v
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/322112
Change subject: Scope talk styles to talk overlay
..
Scope talk styles to talk overlay
Currently the talk styles can influence the
styles o
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/322081
Change subject: Avoid a flash of unstyled content on most tablet devices
..
Avoid a flash of unstyled content on most tablet devices
To avo
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/321863
Change subject: Fix test stubbing
..
Fix test stubbing
* Mock the class we're testing
* Only stub fetchFileMetadata method
* The stub's isI
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/321646
Change subject: WIP: Fix swagger file
..
WIP: Fix swagger file
Change-Id: I7f816deacdf3ab81becfae99b178c565e067
---
M spec.yaml
1 file
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/320802
Change subject: Enforce coding conventions using jscs
..
Enforce coding conventions using jscs
Life is too short to worry about coding conv
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/320755
Change subject: Fix test broken by I522bc288a665b9a238fbe9757a2190cef3c58d90
..
Fix test broken by I522bc288a665b9a238fbe9757a2190cef3c58d90
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/320754
Change subject: Update config.yaml files
..
Update config.yaml files
Bug: T145662
Change-Id: I603ead22374d99c157277179195b0007d900d19c
---
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/320628
Change subject: WIP: Surface edits via kafka
..
WIP: Surface edits via kafka
Bug: T145553
Change-Id: Ifd722c18683b33c38a6fc0cae9906a34b61b3
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/320366
Change subject: Add CI to trending-edits repo
..
Add CI to trending-edits repo
Bug: T149601
Change-Id: I09bf8a2f9976e7976eeb18b8d4c54236228
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/320365
Change subject: Restore info test
..
Restore info test
@Mobrovac says this is not an example so I've restored it.
I've captured my thoughts
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/319867
Change subject: Rename routes/v1.js
..
Rename routes/v1.js
Change-Id: I40700faba836a03aa809c3554a1f26c8074eb47a
---
R routes/trending-v1.js
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/319856
Change subject: Squash if necessary: Move inline script to skin hook
..
Squash if necessary: Move inline script to skin hook
Rather than ou
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/319833
Change subject: Updates to package.json
..
Updates to package.json
* Remove fields that are not needed until deployment
and non-essential
*
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/319830
Change subject: Use standardised HTTPError
..
Use standardised HTTPError
Change-Id: I522bc288a665b9a238fbe9757a2190cef3c58d90
---
M routes/
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/319826
Change subject: Trending edits should live under feed
..
Trending edits should live under feed
* Correct naming of endpoint
* Update docume
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/319827
Change subject: Assert contents of body in spec
..
Assert contents of body in spec
Change-Id: I5ce9bfc0cf693c98f470770d4c37a39237ededc5
---
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/319828
Change subject: Rename spec.template.yaml to spec.yaml
..
Rename spec.template.yaml to spec.yaml
Artifact from service template no longer n
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/319623
Change subject: Revert "Fix tooltip interactions"
..
Revert "Fix tooltip interactions"
There is one reference to removeTooltips in
ext.pop
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/319067
Change subject: Collapse sections by default
..
Collapse sections by default
A global function mfTempOpenSection is added to the top of the
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/319065
Change subject: Hygiene: Make use of makeSectionHtml helper
..
Hygiene: Make use of makeSectionHtml helper
Preparation for changes to secti
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/319066
Change subject: Section blocks should have id attribute
..
Section blocks should have id attribute
An id attribute allows JavaScript to acc
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/319056
Change subject: Hygiene: Tests should make use of helpers
..
Hygiene: Tests should make use of helpers
In preparation for altering the mark
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/318507
Change subject: Setup trending edit placeholder route
..
Setup trending edit placeholder route
This adds a route:
/en.wikipedia.org/v1/tren
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/318277
Change subject: Hygiene: Simplify removeTooltip and restoreTooltip test
..
Hygiene: Simplify removeTooltip and restoreTooltip test
I'm not
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/318270
Change subject: Hygiene: Rename getMassagedData to processHovercardEvent
..
Hygiene: Rename getMassagedData to processHovercardEvent
This n
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/318137
Change subject: linkInteractionToken is managed by getMassagedData
..
linkInteractionToken is managed by getMassagedData
Rather than genera
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/317868
Change subject: Cleanup unused config variables
..
Cleanup unused config variables
Bug: T148853
Change-Id: Iedd706f6f00f83f30f91b645ff44feb
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/317738
Change subject: Clear content to avoid user page float issues
..
Clear content to avoid user page float issues
Post content container shoul
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/317725
Change subject: QA: Search overlay gives false positives
..
QA: Search overlay gives false positives
Scenario "Closing search (overlay butt
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/317713
Change subject: Event and hover events are logged but not recorded
..
Event and hover events are logged but not recorded
This adds two new
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/317670
Change subject: Hygiene: Move logic for duplicate events into getMassagedData
..
Hygiene: Move logic for duplicate events into getMassagedDa
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/317563
Change subject: Tests: Test existing behaviour for getMassagedData
..
Tests: Test existing behaviour for getMassagedData
Change-Id: Ia26600
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/316984
Change subject: Hygiene: Rename track topic to be more consistent with new plans
..
Hygiene: Rename track topic to be more consistent with n
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/316848
Change subject: Hygiene: Remove dead code
..
Hygiene: Remove dead code
Since DWELL_EVENTS_MIN_INTERACTION_TIME is always
zero the check wil
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/316480
Change subject: ext.popups.schemaPopups now manages logic of whether to log an
event
..
ext.popups.schemaPopups now manages logic of whethe
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/316481
Change subject: Multiple hover events should not clear dwellStartTime
..
Multiple hover events should not clear dwellStartTime
If a user ha
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/316479
Change subject: Event and hover events are logged but not recorded
..
Event and hover events are logged but not recorded
This adds two new
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/316415
Change subject: Directory structure should reflect the ResourceLoader
definitions
..
Directory structure should reflect the ResourceLoader
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/316393
Change subject: QA: Search.feature browser test gives false positives
..
QA: Search.feature browser test gives false positives
* The closin
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/316020
Change subject: QA: Ensure JavaScript has loaded before running references and
search tests
..
QA: Ensure JavaScript has loaded before runn
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/315862
Change subject: WIP: Add `hover` and `displayed` events
..
WIP: Add `hover` and `displayed` events
Although we don't log them on the server
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/315857
Change subject: Hygiene: Pull out event handler for display of Hovercards
..
Hygiene: Pull out event handler for display of Hovercards
* Ma
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/315698
Change subject: Enable APISandbox code on mobile
..
Enable APISandbox code on mobile
It's a special page and only uses mobile vetted code
s
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/315610
Change subject: Move logic for dwelledButAbandoned to central log method
..
Move logic for dwelledButAbandoned to central log method
Add te
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/315585
Change subject: Wait and reset do not need to be exposed globally
..
Wait and reset do not need to be exposed globally
Bug: T147306
Change-
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/315583
Change subject: Log events in one central place
..
Log events in one central place
We calculate totalInteractionTime in every single log ev
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/315582
Change subject: Event handlers should not be exposed globally
..
Event handlers should not be exposed globally
Bug: T147306
Change-Id: Ib0b
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/315565
Change subject: Avoid margin collapsing
..
Avoid margin collapsing
Also remove inert css rule around border top color.
Bug: T147956
Change
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/315540
Change subject: Remove dead code in SkinMinervaBeta
..
Remove dead code in SkinMinervaBeta
All this code is unnecessary. The styles it adds
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/315541
Change subject: Load skins.minerva.icons.images.variants in stable
..
Load skins.minerva.icons.images.variants in stable
* Chevrons uses to
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/315450
Change subject: Always remember your wg prefix
..
Always remember your wg prefix
If not things won't work how you want them to...
Change-I
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/315437
Change subject: @phuedx: One possible fix
..
@phuedx: One possible fix
Change-Id: Ie7f20ea0a89d2ab8e1510a4662132fe244c9fd66
---
M tests/php
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/315427
Change subject: All View's can now call toHtmlString
..
All View's can now call toHtmlString
Change-Id: I92272d65bebdbcda407f98713be26ee712
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/315428
Change subject: Talk overlay's should not need so many partials
..
Talk overlay's should not need so many partials
Change-Id: I6820849028c5
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/315426
Change subject: Hygiene: Allow a more generalised Overlay header
..
Hygiene: Allow a more generalised Overlay header
Overlays can opt into
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/315414
Change subject: Fix logic of MinervaBottomLanguageButton
..
Fix logic of MinervaBottomLanguageButton
When MinervaBottomLanguageButton is fa
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/315325
Change subject: Remove language overlay instrumentation
..
Remove language overlay instrumentation
Interactions with the LanguageOverlay wi
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/315322
Change subject: Update Grunt dependencies to allow us to use jscs autofixing
..
Update Grunt dependencies to allow us to use jscs autofixing
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/315318
Change subject: Remove MinervaBottomLanguageButton
..
Remove MinervaBottomLanguageButton
The language button will show at the top of the pa
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/315314
Change subject: Disable bottom language button in Minerva
..
Disable bottom language button in Minerva
We plan to remove this config settin
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/315310
Change subject: Test case: Certain MediaWiki setups use locally served images
..
Test case: Certain MediaWiki setups use locally served imag
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/315309
Change subject: Tests: Add test coverage for Page:getThumbnails
..
Tests: Add test coverage for Page:getThumbnails
Change-Id: Ia1cb66a57c02
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/315126
Change subject: Do not relocate first paragraph in new endpoint
..
Do not relocate first paragraph in new endpoint
This moves the logic for
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/315118
Change subject: QA: Re-enable VisualEditor integration test
..
QA: Re-enable VisualEditor integration test
Change-Id: I0bb4a2b7a609a8fa38dc
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/315113
Change subject: Don't skip browser tests
..
Don't skip browser tests
If they are important fix them.
If not remove them.
Change-Id: I3477e
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/314771
Change subject: POC: Use jquery 3 in mobile target mode
..
POC: Use jquery 3 in mobile target mode
The savings of 3kb are probably not subs
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/314736
Change subject: Footer version 2 is now default
..
Footer version 2 is now default
* Update the config value
* Update the tests
Bug: T1476
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/314627
Change subject: Merge config declarations
..
Merge config declarations
wmg will override wg
Follow up to Ie7689477c163384eb27776f194f3ccc77
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/314616
Change subject: QA: Don't reference status of beta in browser test names
..
QA: Don't reference status of beta in browser test names
This d
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/314619
Change subject: QA: Remove indeterminism from test
..
QA: Remove indeterminism from test
Hitting random can have unexpected results on this
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/314615
Change subject: QA: Mark browser tests which have login steps which @login
..
QA: Mark browser tests which have login steps which @login
Th
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/314617
Change subject: QA: Make it clearer which tests require anonymous editing
support
..
QA: Make it clearer which tests require anonymous edit
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/314307
Change subject: Fix documentation for existing experimental endpoints
..
Fix documentation for existing experimental endpoints
This was a c
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/314210
Change subject: Collapse sections by default
..
Collapse sections by default
A global function mfTempOpenSection is added to the top of the
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/314195
Change subject: UC Mini should be blacklisted
..
UC Mini should be blacklisted
The UC Mini browser should be blacklisted. The experience
wh
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/314051
Change subject: Move versioning to bottom of HTML
..
Move versioning to bottom of HTML
Given `headelement` contains the tag and doctype th
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/313906
Change subject: Enable RelatedArticles on Minerva skin for all but top 6 wikis
..
Enable RelatedArticles on Minerva skin for all but top 6 w
Jdlrobson has uploaded a new change for review.
https://gerrit.wikimedia.org/r/313898
Change subject: Push footer version 2 to stable
..
Push footer version 2 to stable
Bug: T145442
Change-Id: Ic2c011c5bcf7296a302fd174e8a7956
901 - 1000 of 5352 matches
Mail list logo