[MediaWiki-commits] [Gerrit] Test Jenkins - change (mediawiki...Wikibase)

2015-03-11 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/196154 Change subject: Test Jenkins .. Test Jenkins Change-Id: I5e929e720ff8db6396672a5b5b71c89b8e2399d8 --- M

[MediaWiki-commits] [Gerrit] Remove myself from the TravisCI email notification list - change (mediawiki...Wikibase)

2015-03-11 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/196142 Change subject: Remove myself from the TravisCI email notification list .. Remove myself from the TravisCI email notification list

[MediaWiki-commits] [Gerrit] Add WikibaseView skeleton - change (mediawiki...Wikibase)

2015-02-21 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Add WikibaseView skeleton .. Add WikibaseView skeleton Change-Id: Ibbeed0a72d593d4a8cb583badc38a95d8c320e80 --- M Wikibase.composer.php A

[MediaWiki-commits] [Gerrit] Simplify SnaksFinder - change (mediawiki...Wikibase)

2015-02-21 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Simplify SnaksFinder .. Simplify SnaksFinder Per Daniel's comments on https://gerrit.wikimedia.org/r/190809 Change-Id:

[MediaWiki-commits] [Gerrit] Fix type hints in UpdateRepo classes - change (mediawiki...Wikibase)

2015-02-13 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Fix type hints in UpdateRepo classes .. Fix type hints in UpdateRepo classes * Fix wrong Job type hints. * More specific type hints. * Private by

[MediaWiki-commits] [Gerrit] Introduce ContentLanguages::hasLanguage and make use of it - change (mediawiki...Wikibase)

2015-02-13 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Introduce ContentLanguages::hasLanguage and make use of it .. Introduce ContentLanguages::hasLanguage and make use of it Change-Id:

[MediaWiki-commits] [Gerrit] Remove Utils::getLanguageCodes, make Babel handling more fle... - change (mediawiki...Wikibase)

2015-02-13 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Remove Utils::getLanguageCodes, make Babel handling more flexible .. Remove Utils::getLanguageCodes, make Babel handling more flexible This makes

[MediaWiki-commits] [Gerrit] Specific type hints in LabelDescriptionUniquenessValidatorTest - change (mediawiki...Wikibase)

2015-02-13 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Specific type hints in LabelDescriptionUniquenessValidatorTest .. Specific type hints in LabelDescriptionUniquenessValidatorTest Change-Id:

[MediaWiki-commits] [Gerrit] Fix RepoHooks test - change (mediawiki...Wikibase)

2015-02-13 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Fix RepoHooks test .. Fix RepoHooks test The finishImportPage callback changed in 341dfa25, adopt to that. Also make use of ImportStringSource which

[MediaWiki-commits] [Gerrit] Remove Utils, introduce LanguageNameLookup - change (mediawiki...Wikibase)

2015-02-13 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Remove Utils, introduce LanguageNameLookup .. Remove Utils, introduce LanguageNameLookup This finally removes the static Utils class! Also I've

[MediaWiki-commits] [Gerrit] Replace static Item::newEmpty() with new Item() constructor - change (mediawiki...Wikibase)

2015-02-12 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Replace static Item::newEmpty() with new Item() constructor .. Replace static Item::newEmpty() with new Item() constructor See

[MediaWiki-commits] [Gerrit] Private by default in ChangeOpFactory based API modules - change (mediawiki...Wikibase)

2015-02-12 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Private by default in ChangeOpFactory based API modules .. Private by default in ChangeOpFactory based API modules Change-Id:

[MediaWiki-commits] [Gerrit] Private by default in all Repo API modules - change (mediawiki...Wikibase)

2015-02-12 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Private by default in all Repo API modules .. Private by default in all Repo API modules The idea is simple: If a class does not have any subclasses,

[MediaWiki-commits] [Gerrit] Inline trivial ApiWikibase::formatSummary method - change (mediawiki...Wikibase)

2015-02-12 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Inline trivial ApiWikibase::formatSummary method .. Inline trivial ApiWikibase::formatSummary method I assume this method is there because it was way

[MediaWiki-commits] [Gerrit] SnakTypeSelector: Updated code documentation - change (mediawiki...Wikibase)

2015-02-02 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: SnakTypeSelector: Updated code documentation .. SnakTypeSelector: Updated code documentation Change-Id: I0c5904898e6b3c1340304352e220426380b69356 ---

[MediaWiki-commits] [Gerrit] Init nullable with null instead of false - change (mediawiki...Wikibase)

2015-01-29 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Init nullable with null instead of false .. Init nullable with null instead of false Change-Id: I0600d9180288837b37126e5dda09590262fb2462 --- M

[MediaWiki-commits] [Gerrit] Fix method signatures in all maintenance scripts - change (mediawiki...Wikibase)

2015-01-29 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Fix method signatures in all maintenance scripts .. Fix method signatures in all maintenance scripts This patch focuses on cleaning up method

[MediaWiki-commits] [Gerrit] Only allow QUnit and sinon in test files - change (mediawiki...Wikibase)

2015-01-29 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Only allow QUnit and sinon in test files .. Only allow QUnit and sinon in test files Change-Id: I413b9e8dcf92eccbdbbae4352b27a369db1ffc5e --- M

[MediaWiki-commits] [Gerrit] Fix wrong variable name in EntityIdHtmlLinkFormatter - change (mediawiki...Wikibase)

2015-01-29 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Fix wrong variable name in EntityIdHtmlLinkFormatter .. Fix wrong variable name in EntityIdHtmlLinkFormatter * Wrong variable name was introduced in

[MediaWiki-commits] [Gerrit] Change i18n file to JSON - change (mediawiki...GitHub)

2015-01-22 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Change i18n file to JSON .. Change i18n file to JSON In preparation for adding extension to translatewiki.net Change-Id:

[MediaWiki-commits] [Gerrit] Stop using deprecated method - change (mediawiki...Wikibase)

2015-01-22 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/186256 Change subject: Stop using deprecated method .. Stop using deprecated method Change-Id: Ie3b54ee0c732b4ca7cd93fa365bc096ef115df61 ---

[MediaWiki-commits] [Gerrit] Stop using deprecated methods in GenericEntityInfoBuilder - change (mediawiki...Wikibase)

2015-01-22 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/186250 Change subject: Stop using deprecated methods in GenericEntityInfoBuilder .. Stop using deprecated methods in GenericEntityInfoBuilder

[MediaWiki-commits] [Gerrit] Replace some string comparisons with instanceof - change (mediawiki...Wikibase)

2015-01-22 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Replace some string comparisons with instanceof .. Replace some string comparisons with instanceof These string comparisons are just not necesarry and

[MediaWiki-commits] [Gerrit] Drop unused use clauses from Client - change (mediawiki...Wikibase)

2015-01-22 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Drop unused use clauses from Client .. Drop unused use clauses from Client I found these with a regex. Change-Id:

[MediaWiki-commits] [Gerrit] Drop unused use clauses from Lib - change (mediawiki...Wikibase)

2015-01-22 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Drop unused use clauses from Lib .. Drop unused use clauses from Lib I found these with a regex. Change-Id: I30e44dc2626b708e93c4610204887d3d5becaa50

[MediaWiki-commits] [Gerrit] Remove dead code - change (mediawiki...Wikibase)

2015-01-20 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/186123 Change subject: Remove dead code .. Remove dead code This method can no longer return false since DM 2.0 (or 1.0, can't remember)

[MediaWiki-commits] [Gerrit] Stop using deprecated claims method - change (mediawiki...Wikibase)

2015-01-20 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/186124 Change subject: Stop using deprecated claims method .. Stop using deprecated claims method Change-Id:

[MediaWiki-commits] [Gerrit] Stop using deprecated method in EntityContent and add fixme ... - change (mediawiki...Wikibase)

2015-01-20 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/186119 Change subject: Stop using deprecated method in EntityContent and add fixme for now obvious issue .. Stop using deprecated method in

[MediaWiki-commits] [Gerrit] Require DM 2.5 - change (mediawiki...Wikibase)

2015-01-20 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/186116 Change subject: Require DM 2.5 .. Require DM 2.5 Change-Id: If37e4f728061e903407653eb9e3231d39be0909f --- M composer.json 1 file

[MediaWiki-commits] [Gerrit] Document alternative to deprecated function - change (mediawiki/core)

2015-01-20 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/186115 Change subject: Document alternative to deprecated function .. Document alternative to deprecated function Change-Id:

[MediaWiki-commits] [Gerrit] Increase encapsulation and decrease width of used interface - change (mediawiki...Wikibase)

2015-01-20 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/186118 Change subject: Increase encapsulation and decrease width of used interface .. Increase encapsulation and decrease width of used

[MediaWiki-commits] [Gerrit] Add missing @param doc - change (mediawiki...Wikibase)

2015-01-14 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/185078 Change subject: Add missing @param doc .. Add missing @param doc Change-Id: I0719316630a48b58e2f52f2fdd656b008c619ce2 --- M

[MediaWiki-commits] [Gerrit] Remove double doc - change (mediawiki...Wikibase)

2015-01-14 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/185084 Change subject: Remove double doc .. Remove double doc Change-Id: I8278d5f3f053e7716c4823286257833e41884699 --- M

[MediaWiki-commits] [Gerrit] Optimized imports - change (mediawiki...Wikibase)

2015-01-14 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/185086 Change subject: Optimized imports .. Optimized imports Change-Id: I4418f26501dae804d0d735f2d7860f1d64efe0c7 --- M

[MediaWiki-commits] [Gerrit] Return Term object from LabelLookup. - change (mediawiki...Wikibase)

2015-01-14 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Return Term object from LabelLookup. .. Return Term object from LabelLookup. This will allow formatters to show information of any language fallback

[MediaWiki-commits] [Gerrit] Address Adrians comment and remove not needed else-clause an... - change (mediawiki...Wikibase)

2015-01-14 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/184892 Change subject: Address Adrians comment and remove not needed else-clause and local var .. Address Adrians comment and remove not

[MediaWiki-commits] [Gerrit] Rename class from LanguageLinkBadgeDisplay to SiteLinkBadgeD... - change (mediawiki...Wikibase)

2015-01-05 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/182987 Change subject: Rename class from LanguageLinkBadgeDisplay to SiteLinkBadgeDisplay. .. Rename class from LanguageLinkBadgeDisplay to

[MediaWiki-commits] [Gerrit] Correct 292f4b8ae0230ae - change (mediawiki...SemanticWatchlist)

2014-12-11 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Correct 292f4b8ae0230ae .. Correct 292f4b8ae0230ae Parenthesis was added in the wrong place. This was reported by Temptuousinsolence at

[MediaWiki-commits] [Gerrit] Remove usages of deprecated code and bad assumptions from Rd... - change (mediawiki...Wikibase)

2014-11-28 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/176390 Change subject: Remove usages of deprecated code and bad assumptions from RdfBuilder .. Remove usages of deprecated code and bad

[MediaWiki-commits] [Gerrit] Remove usages of deprecated setSiteLink method - change (mediawiki...Wikibase)

2014-11-27 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/176313 Change subject: Remove usages of deprecated setSiteLink method .. Remove usages of deprecated setSiteLink method Change-Id:

[MediaWiki-commits] [Gerrit] Stop using deprecated Item::removeSiteLink method - change (mediawiki...Wikibase)

2014-11-27 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/176314 Change subject: Stop using deprecated Item::removeSiteLink method .. Stop using deprecated Item::removeSiteLink method Change-Id:

[MediaWiki-commits] [Gerrit] Remove usages of deprecated setLabel method - change (mediawiki...Wikibase)

2014-11-27 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/176315 Change subject: Remove usages of deprecated setLabel method .. Remove usages of deprecated setLabel method Change-Id:

[MediaWiki-commits] [Gerrit] Remove usages of deprecated setLabel method - change (mediawiki...Wikibase)

2014-11-27 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Remove usages of deprecated setLabel method .. Remove usages of deprecated setLabel method Change-Id: I60bbb4faea5c75d66a9cde56b79cb2c0c34f5ce3 --- M

[MediaWiki-commits] [Gerrit] Fix broken @see in Number(Un)Localizer doc - change (mediawiki...Wikibase)

2014-11-27 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Fix broken @see in Number(Un)Localizer doc .. Fix broken @see in Number(Un)Localizer doc Also see https://github.com/DataValues/Number/pull/14

[MediaWiki-commits] [Gerrit] Fix broken CreatedBlacklistedItems - change (mediawiki...Wikibase)

2014-11-27 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/176316 Change subject: Fix broken CreatedBlacklistedItems .. Fix broken CreatedBlacklistedItems Item was not referenced. Also removed usage

[MediaWiki-commits] [Gerrit] Stop using deprecated methods in importInterlang - change (mediawiki...Wikibase)

2014-11-27 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/176317 Change subject: Stop using deprecated methods in importInterlang .. Stop using deprecated methods in importInterlang Change-Id:

[MediaWiki-commits] [Gerrit] Remove no longer used class - change (mediawiki...Wikibase)

2014-11-27 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/176318 Change subject: Remove no longer used class .. Remove no longer used class Change-Id: Ie669575cc373d1f3b67050d842c47a74e0a35457 --- D

[MediaWiki-commits] [Gerrit] Fix typo in classname - change (mediawiki...Wikibase)

2014-11-27 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/176319 Change subject: Fix typo in classname .. Fix typo in classname Change-Id: I2e9ba46c50f3746f733d41d30132520dd4875b82 --- M

[MediaWiki-commits] [Gerrit] Move UpdateRepo hook handlers into a dedicated class - change (mediawiki...Wikibase)

2014-11-27 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Move UpdateRepo hook handlers into a dedicated class .. Move UpdateRepo hook handlers into a dedicated class Change-Id:

[MediaWiki-commits] [Gerrit] Also propagate moves/deletions from non-Wikibase enabled nam... - change (mediawiki...Wikibase)

2014-11-27 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Also propagate moves/deletions from non-Wikibase enabled namespaces .. Also propagate moves/deletions from non-Wikibase enabled namespaces Per

[MediaWiki-commits] [Gerrit] Use Statement rank enum - change (mediawiki...Wikibase)

2014-11-27 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/176320 Change subject: Use Statement rank enum .. Use Statement rank enum Change-Id: I4bbcb43131be2dd723c8f272abd5ecec29518654 --- M

[MediaWiki-commits] [Gerrit] Use Statement rank enum - change (mediawiki...Wikibase)

2014-11-27 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/176321 Change subject: Use Statement rank enum .. Use Statement rank enum Change-Id: I7f8270b6854d4f95ddf272822ee1b434d11a1fa8 --- M

[MediaWiki-commits] [Gerrit] Stop using deprecated Item::removeSiteLink method - change (mediawiki...Wikibase)

2014-11-27 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Stop using deprecated Item::removeSiteLink method .. Stop using deprecated Item::removeSiteLink method Change-Id:

[MediaWiki-commits] [Gerrit] Construct properties with a data type - change (mediawiki...Wikibase)

2014-11-27 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/176322 Change subject: Construct properties with a data type .. Construct properties with a data type (Doing without is deprecated, so we

[MediaWiki-commits] [Gerrit] Stop using deprecateds method in TestChanges - change (mediawiki...Wikibase)

2014-11-27 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Stop using deprecateds method in TestChanges .. Stop using deprecateds method in TestChanges Change-Id: I2397e394254a664ed40e76520383496f6fe31ca7 ---

[MediaWiki-commits] [Gerrit] Do not typehint against Entity in WikibaseLuaEntityBindingsTest - change (mediawiki...Wikibase)

2014-11-25 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/175734 Change subject: Do not typehint against Entity in WikibaseLuaEntityBindingsTest .. Do not typehint against Entity in

[MediaWiki-commits] [Gerrit] Remove seemingly unused code from EntityChange - change (mediawiki...Wikibase)

2014-11-25 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/175736 Change subject: Remove seemingly unused code from EntityChange .. Remove seemingly unused code from EntityChange Change-Id:

[MediaWiki-commits] [Gerrit] Do not type hint against Entity in EntityContentFactory - change (mediawiki...Wikibase)

2014-11-25 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/175738 Change subject: Do not type hint against Entity in EntityContentFactory .. Do not type hint against Entity in EntityContentFactory

[MediaWiki-commits] [Gerrit] Add TODO - change (mediawiki...Wikibase)

2014-11-25 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/175741 Change subject: Add TODO .. Add TODO Change-Id: I5a625295ce92e598d5e0abf8c32892fe49fe8d49 --- M lib/includes/store/EntityRevision.php

[MediaWiki-commits] [Gerrit] Make fields in EntityRevision private - change (mediawiki...Wikibase)

2014-11-25 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/175740 Change subject: Make fields in EntityRevision private .. Make fields in EntityRevision private Change-Id:

[MediaWiki-commits] [Gerrit] Act on TODO: rename getRevision to getRevisionId - change (mediawiki...Wikibase)

2014-11-25 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/175744 Change subject: Act on TODO: rename getRevision to getRevisionId .. Act on TODO: rename getRevision to getRevisionId Change-Id:

[MediaWiki-commits] [Gerrit] Stop type hinting against Entity in TermSqlIndex - change (mediawiki...Wikibase)

2014-11-25 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/175747 Change subject: Stop type hinting against Entity in TermSqlIndex .. Stop type hinting against Entity in TermSqlIndex Change-Id:

[MediaWiki-commits] [Gerrit] Stop using deprecated methods in GenericEntityInfoBuilder - change (mediawiki...Wikibase)

2014-11-25 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/175756 Change subject: Stop using deprecated methods in GenericEntityInfoBuilder .. Stop using deprecated methods in GenericEntityInfoBuilder

[MediaWiki-commits] [Gerrit] Thiemo should get a food? - change (mediawiki...Wikibase)

2014-11-25 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/175757 Change subject: Thiemo should get a food? .. Thiemo should get a food? Change-Id: I517b67433ff73b92840c23e86c2165005a246883 --- M

[MediaWiki-commits] [Gerrit] Rename class from LanguageLinkBadgeDisplay to SiteLinkBadgeD... - change (mediawiki...Wikibase)

2014-11-25 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/175760 Change subject: Rename class from LanguageLinkBadgeDisplay to SiteLinkBadgeDisplay .. Rename class from LanguageLinkBadgeDisplay to

[MediaWiki-commits] [Gerrit] Remove broken conditional branch using a non-existing object - change (mediawiki...Wikibase)

2014-11-25 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/175763 Change subject: Remove broken conditional branch using a non-existing object .. Remove broken conditional branch using a non-existing

[MediaWiki-commits] [Gerrit] Stop using deprecated Entity method in updateMockRepo - change (mediawiki...Wikibase)

2014-11-25 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/175762 Change subject: Stop using deprecated Entity method in updateMockRepo .. Stop using deprecated Entity method in updateMockRepo

[MediaWiki-commits] [Gerrit] Fix typo in use statement in EntityRetrievingTermLookup - change (mediawiki...Wikibase)

2014-11-25 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/175764 Change subject: Fix typo in use statement in EntityRetrievingTermLookup .. Fix typo in use statement in EntityRetrievingTermLookup

[MediaWiki-commits] [Gerrit] Improve variable naming - change (mediawiki...Wikibase)

2014-11-25 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/175765 Change subject: Improve variable naming .. Improve variable naming Change-Id: I1f92bf8b5e013898a49c1ea4ff63c7ce9172e427 --- M

[MediaWiki-commits] [Gerrit] Remove assmuption that all entities have a fingerprint - change (mediawiki...Wikibase)

2014-11-25 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/175766 Change subject: Remove assmuption that all entities have a fingerprint .. Remove assmuption that all entities have a fingerprint

[MediaWiki-commits] [Gerrit] Stop using deprecateds method in TestChanges - change (mediawiki...Wikibase)

2014-11-25 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/175770 Change subject: Stop using deprecateds method in TestChanges .. Stop using deprecateds method in TestChanges Change-Id:

[MediaWiki-commits] [Gerrit] Stop using deprecated method in EntityParserOutputGenerator - change (mediawiki...Wikibase)

2014-11-25 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/175774 Change subject: Stop using deprecated method in EntityParserOutputGenerator .. Stop using deprecated method in

[MediaWiki-commits] [Gerrit] Narrow TermSqlIndex interface to EntityId - change (mediawiki...Wikibase)

2014-11-25 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Narrow TermSqlIndex interface to EntityId .. Narrow TermSqlIndex interface to EntityId Change-Id: I179e1f4f6794819c7497dc8b33579ea0720c10b8 --- M

[MediaWiki-commits] [Gerrit] Stop using deprecated method - change (mediawiki...Wikibase)

2014-11-22 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/175314 Change subject: Stop using deprecated method .. Stop using deprecated method Change-Id: Ibb09e1a1699a02ab0a8fdb79f1f33286ec48c472 ---

[MediaWiki-commits] [Gerrit] Simplify SnakFiner - change (mediawiki...Wikibase)

2014-11-22 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/175316 Change subject: Simplify SnakFiner .. Simplify SnakFiner Change-Id: I0b17944523d7f297b2ae9fd036af3267e98ddc15 --- M

[MediaWiki-commits] [Gerrit] Make nil the default for acceptableRanks in formatPropertyVa... - change (mediawiki...Wikibase)

2014-11-19 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Make nil the default for acceptableRanks in formatPropertyValues .. Make nil the default for acceptableRanks in formatPropertyValues Change-Id:

[MediaWiki-commits] [Gerrit] Use Parser::SFH_NO_HASH class const - change (mediawiki...Wikibase)

2014-11-19 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Use Parser::SFH_NO_HASH class const .. Use Parser::SFH_NO_HASH class const Instead of the global const Change-Id:

[MediaWiki-commits] [Gerrit] More descriptive names for $repo variables and methods - change (mediawiki...Wikibase)

2014-11-18 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: More descriptive names for $repo variables and methods .. More descriptive names for $repo variables and methods This is split from If6c96e0 to make

[MediaWiki-commits] [Gerrit] Replace some deprecated setClaims with getStatements - change (mediawiki...Wikibase)

2014-11-18 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Replace some deprecated setClaims with getStatements .. Replace some deprecated setClaims with getStatements Change-Id:

[MediaWiki-commits] [Gerrit] Reduce inheritance in EntityContentTest - change (mediawiki...Wikibase)

2014-11-18 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Reduce inheritance in EntityContentTest .. Reduce inheritance in EntityContentTest Especially the redirect stuff is only needed in ItemContentTest.

[MediaWiki-commits] [Gerrit] Drop optional empty array() constructor parameters - change (mediawiki...Wikibase)

2014-11-18 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Drop optional empty array() constructor parameters .. Drop optional empty array() constructor parameters Change-Id:

[MediaWiki-commits] [Gerrit] Update min version of DataModel - change (mediawiki...Wikibase)

2014-11-18 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/174139 Change subject: Update min version of DataModel .. Update min version of DataModel It also should have been at 2.2 before already,

[MediaWiki-commits] [Gerrit] Update used version of DataValues - change (mediawiki...Wikibase)

2014-11-18 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/174140 Change subject: Update used version of DataValues .. Update used version of DataValues Change-Id:

[MediaWiki-commits] [Gerrit] Update used version of DataValues - change (mediawiki...Wikibase)

2014-11-18 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Update used version of DataValues .. Update used version of DataValues Change-Id: I6659e8fa9718566374f3bcb59f315e0fb1b3f8c2 --- M composer.json 1 file

[MediaWiki-commits] [Gerrit] Update min version of DataModel - change (mediawiki...Wikibase)

2014-11-18 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Update min version of DataModel .. Update min version of DataModel It also should have been at 2.2 before already, since we are using things from that

[MediaWiki-commits] [Gerrit] Use EntityDocument in WikibaseLuaBindings - change (mediawiki...Wikibase)

2014-11-18 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/174292 Change subject: Use EntityDocument in WikibaseLuaBindings .. Use EntityDocument in WikibaseLuaBindings Change-Id:

[MediaWiki-commits] [Gerrit] Stop using Claims and Entity in WikibaseLuaEntityBindings - change (mediawiki...Wikibase)

2014-11-18 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/174299 Change subject: Stop using Claims and Entity in WikibaseLuaEntityBindings .. Stop using Claims and Entity in WikibaseLuaEntityBindings

[MediaWiki-commits] [Gerrit] Remove usage of deprecated Claims and Entity classes - change (mediawiki...Wikibase)

2014-11-17 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/173810 Change subject: Remove usage of deprecated Claims and Entity classes .. Remove usage of deprecated Claims and Entity classes

[MediaWiki-commits] [Gerrit] Remove dead ref in comment - change (mediawiki...Wikibase)

2014-11-17 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/173814 Change subject: Remove dead ref in comment .. Remove dead ref in comment Change-Id: Ia0ef7bf5f9d7fd9e42ce925200274c2ff0f64c06 --- M

[MediaWiki-commits] [Gerrit] Update type hint in interface - change (mediawiki...Wikibase)

2014-11-17 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/173815 Change subject: Update type hint in interface .. Update type hint in interface Change-Id: Iede16f8e8386bb94ceeed04fcc317f65dcecaca7

[MediaWiki-commits] [Gerrit] Remove not needed variable assignment - change (mediawiki...Wikibase)

2014-11-17 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/173816 Change subject: Remove not needed variable assignment .. Remove not needed variable assignment Change-Id:

[MediaWiki-commits] [Gerrit] Fix various issues in EntitySearchTextGenerator and its test - change (mediawiki...Wikibase)

2014-11-17 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/173821 Change subject: Fix various issues in EntitySearchTextGenerator and its test .. Fix various issues in EntitySearchTextGenerator and

[MediaWiki-commits] [Gerrit] Replace some Claims with StatementList - change (mediawiki...Wikibase)

2014-11-17 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Replace some Claims with StatementList .. Replace some Claims with StatementList I wanted to replace some usages of the Claims class but immediatelly

[MediaWiki-commits] [Gerrit] Removed dead and broken code in statementview save - change (mediawiki...Wikibase)

2014-11-17 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Removed dead and broken code in statementview save .. Removed dead and broken code in statementview save Change-Id:

[MediaWiki-commits] [Gerrit] Move shared stuff in jquery.wikibase to jquery.wikibase-shared - change (mediawiki...Wikibase)

2014-11-17 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Move shared stuff in jquery.wikibase to jquery.wikibase-shared .. Move shared stuff in jquery.wikibase to jquery.wikibase-shared This allows us to

[MediaWiki-commits] [Gerrit] Remove usage of deprecated Entity methods - change (mediawiki...Wikibase)

2014-11-17 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/173840 Change subject: Remove usage of deprecated Entity methods .. Remove usage of deprecated Entity methods This includes fixing two of

[MediaWiki-commits] [Gerrit] Do not pass whole Entity when not needed - change (mediawiki...Wikibase)

2014-11-16 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/173676 Change subject: Do not pass whole Entity when not needed .. Do not pass whole Entity when not needed Change-Id:

[MediaWiki-commits] [Gerrit] Update type hints to not use Entity - change (mediawiki...Wikibase)

2014-11-16 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/173701 Change subject: Update type hints to not use Entity .. Update type hints to not use Entity Change-Id:

[MediaWiki-commits] [Gerrit] Update comment - change (mediawiki...Wikibase)

2014-11-16 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has uploaded a new change for review. https://gerrit.wikimedia.org/r/173724 Change subject: Update comment .. Update comment Change-Id: I290c90a07645dc49db58c5e894eb83eba86c73d3 --- M

[MediaWiki-commits] [Gerrit] Optimize all use sections in Lib - change (mediawiki...Wikibase)

2014-11-15 Thread Jeroen De Dauw (Code Review)
Jeroen De Dauw has submitted this change and it was merged. Change subject: Optimize all use sections in Lib .. Optimize all use sections in Lib Change-Id: I79df2962f6f2932986aae1f37ca8bfb9836be09f --- M

<    1   2   3   4   5   6   7   8   9   10   >