Jeroen De Dauw has uploaded a new change for review.
https://gerrit.wikimedia.org/r/151511
Change subject: Remove not needed ref to deprecated global
..
Remove not needed ref to deprecated global
Change-Id:
Jeroen De Dauw has uploaded a new change for review.
https://gerrit.wikimedia.org/r/151516
Change subject: Remove usage of evilDataValueMap
..
Remove usage of evilDataValueMap
Change-Id:
Jeroen De Dauw has uploaded a new change for review.
https://gerrit.wikimedia.org/r/150821
Change subject: DM 1.0 compat: do not use Claim::newFromArray
..
DM 1.0 compat: do not use Claim::newFromArray
Change-Id:
Jeroen De Dauw has uploaded a new change for review.
https://gerrit.wikimedia.org/r/150830
Change subject: DM 1.0 compat: only call setClaims for entities that have the
method
..
DM 1.0 compat: only call setClaims for
Jeroen De Dauw has submitted this change and it was merged.
Change subject: Cleanup Lib Validators
..
Cleanup Lib Validators
Change-Id: I58002a4de1ae11f07f8dd66e8febea71139f5763
---
M
Jeroen De Dauw has submitted this change and it was merged.
Change subject: Add order test to DataModelSerializationRoundtripTest
..
Add order test to DataModelSerializationRoundtripTest
I'm not very happy with this test. It's
Jeroen De Dauw has submitted this change and it was merged.
Change subject: Replace Aliases in WikibaseRepo class map
..
Replace Aliases in WikibaseRepo class map
I honestly don't know if this is a good idea. This may fail
Jeroen De Dauw has submitted this change and it was merged.
Change subject: wgTitle can be null in rare edge cases, e.g. in tests
..
wgTitle can be null in rare edge cases, e.g. in tests
Bug: 68697
Change-Id:
Jeroen De Dauw has submitted this change and it was merged.
Change subject: Fix mistakes and general cleanup in Wikibase\Validators
..
Fix mistakes and general cleanup in Wikibase\Validators
Main changes are:
* Added missing
Jeroen De Dauw has submitted this change and it was merged.
Change subject: Do not double escape HTML in form label
..
Do not double escape HTML in form label
Bug: 68221
Change-Id: I9181a6696de43f42b018a6060f85a5ffaa4c084d
---
Jeroen De Dauw has submitted this change and it was merged.
Change subject: Introduce item-redirect permission.
..
Introduce item-redirect permission.
When creating item redirects, check the item-redirect permission.
Per
Jeroen De Dauw has submitted this change and it was merged.
Change subject: Remove comment that perscribes dubious approach to solve a
problem
..
Remove comment that perscribes dubious approach to solve a problem
Change-Id:
Jeroen De Dauw has submitted this change and it was merged.
Change subject: Remove temporary performance hack
..
Remove temporary performance hack
See I3bb39e7. I don't see a difference when running this test on
my local
Jeroen De Dauw has submitted this change and it was merged.
Change subject: Also run ItemMoveTest on Wikis with client and repo
..
Also run ItemMoveTest on Wikis with client and repo
This was disabled in I34e02f9e1 for no
Jeroen De Dauw has submitted this change and it was merged.
Change subject: Introduce wbcreateredirect API module
..
Introduce wbcreateredirect API module
Bug: 65584
Change-Id: I4877736397646977f1aed4b5e4704833f528beaa
---
M
Jeroen De Dauw has submitted this change and it was merged.
Change subject: Drop dead experimental code
..
Drop dead experimental code
Warning: I honestly don't know what the purpose of this
UnitTestsList hook code was. But
Jeroen De Dauw has uploaded a new change for review.
https://gerrit.wikimedia.org/r/149497
Change subject: DM 1.0 compat: do not use Entity::toArray
..
DM 1.0 compat: do not use Entity::toArray
Change-Id:
Jeroen De Dauw has uploaded a new change for review.
https://gerrit.wikimedia.org/r/149498
Change subject: DM 1.0 compat: Another attempt to clean up testCanApply
..
DM 1.0 compat: Another attempt to clean up testCanApply
Jeroen De Dauw has uploaded a new change for review.
https://gerrit.wikimedia.org/r/149500
Change subject: Simplify negated if else
..
Simplify negated if else
Change-Id: I0bcb568c34e08538b64ec6428a07ece58fa9909c
---
M
Jeroen De Dauw has uploaded a new change for review.
https://gerrit.wikimedia.org/r/149502
Change subject: DM 1.0 compat: do not assume all entities have a setClaims
method
..
DM 1.0 compat: do not assume all entities have a
Jeroen De Dauw has uploaded a new change for review.
https://gerrit.wikimedia.org/r/149506
Change subject: Enable fast finish on TravisCI
..
Enable fast finish on TravisCI
Jeroen De Dauw has submitted this change and it was merged.
Change subject: Roundtrip tests for Qualifiers and References
..
Roundtrip tests for Qualifiers and References
I had to disable the UnDeserializableValue test for
Jeroen De Dauw has submitted this change and it was merged.
Change subject: Add test for ranks to DataModelSerializationRoundtripTest
..
Add test for ranks to DataModelSerializationRoundtripTest
Change-Id:
Jeroen De Dauw has uploaded a new change for review.
https://gerrit.wikimedia.org/r/149222
Change subject: [DNM] See if the CI passes
..
[DNM] See if the CI passes
Change-Id: Iaca7b44a03f935a1cf52d92baecb27002fb63a9f
---
M
Jeroen De Dauw has uploaded a new change for review.
https://gerrit.wikimedia.org/r/149223
Change subject: Use DataModel 0.8.2
..
Use DataModel 0.8.2
Change-Id: I64db1c59e8947415bd92ee7cd89bab76bca18bba
---
M composer.json
1
Jeroen De Dauw has submitted this change and it was merged.
Change subject: Use DataModel 0.8.2
..
Use DataModel 0.8.2
Change-Id: I64db1c59e8947415bd92ee7cd89bab76bca18bba
---
M composer.json
1 file changed, 1 insertion(+), 1
Jeroen De Dauw has uploaded a new change for review.
https://gerrit.wikimedia.org/r/149224
Change subject: DM 1.0 compat: do not use EntityId constructor
..
DM 1.0 compat: do not use EntityId constructor
Change-Id:
Jeroen De Dauw has uploaded a new change for review.
https://gerrit.wikimedia.org/r/149225
Change subject: DM 1.0 compat: do not use EntityId constructor
..
DM 1.0 compat: do not use EntityId constructor
Change-Id:
Jeroen De Dauw has uploaded a new change for review.
https://gerrit.wikimedia.org/r/149226
Change subject: DM 1.0 compat: do not use Entity::toArray
..
DM 1.0 compat: do not use Entity::toArray
Change-Id:
Jeroen De Dauw has uploaded a new change for review.
https://gerrit.wikimedia.org/r/149227
Change subject: DM 1.0 compat: do not use EntityId constructor
..
DM 1.0 compat: do not use EntityId constructor
Change-Id:
Jeroen De Dauw has uploaded a new change for review.
https://gerrit.wikimedia.org/r/149228
Change subject: DM 1.0 compat: do not use EntityId constructor
..
DM 1.0 compat: do not use EntityId constructor
Change-Id:
Jeroen De Dauw has uploaded a new change for review.
https://gerrit.wikimedia.org/r/149229
Change subject: DM 1.0 compat: do not use Entity::toArray
..
DM 1.0 compat: do not use Entity::toArray
Change-Id:
Jeroen De Dauw has uploaded a new change for review.
https://gerrit.wikimedia.org/r/149231
Change subject: DM 1.0 compat: do not use DataModel\Internal\ObjectComparer
..
DM 1.0 compat: do not use
Jeroen De Dauw has uploaded a new change for review.
https://gerrit.wikimedia.org/r/149230
Change subject: Some cleanup in ClaimDiffer
..
Some cleanup in ClaimDiffer
Change-Id: Ieb255d32ef2af57cb6af52dc824faae0e045c433
---
M
Jeroen De Dauw has uploaded a new change for review.
https://gerrit.wikimedia.org/r/149232
Change subject: DM 1.0 compat: remove bad test case from ChangeOpsMergeTest
..
DM 1.0 compat: remove bad test case from
Jeroen De Dauw has uploaded a new change for review.
https://gerrit.wikimedia.org/r/149233
Change subject: DM 1.0 compat: do not use Fingerprint::setLabel for now
..
DM 1.0 compat: do not use Fingerprint::setLabel for now
Jeroen De Dauw has uploaded a new change for review.
https://gerrit.wikimedia.org/r/149234
Change subject: Add DM 1.0 TODOs in WikibaseRepoTest
..
Add DM 1.0 TODOs in WikibaseRepoTest
Change-Id:
Jeroen De Dauw has uploaded a new change for review.
https://gerrit.wikimedia.org/r/149235
Change subject: DM 1.0 compat: do not use Entity::toArray
..
DM 1.0 compat: do not use Entity::toArray
Change-Id:
Jeroen De Dauw has uploaded a new change for review.
https://gerrit.wikimedia.org/r/149236
Change subject: DM 1.0 compat: do not use Snaks::toArray
..
DM 1.0 compat: do not use Snaks::toArray
Change-Id:
Jeroen De Dauw has uploaded a new change for review.
https://gerrit.wikimedia.org/r/149237
Change subject: DM 1.0 compat: do not use Entity::toArray
..
DM 1.0 compat: do not use Entity::toArray
Change-Id:
Jeroen De Dauw has uploaded a new change for review.
https://gerrit.wikimedia.org/r/149238
Change subject: Update ref to Entity and remove ref that has not existed for
years
..
Update ref to Entity and remove ref that has
Jeroen De Dauw has uploaded a new change for review.
https://gerrit.wikimedia.org/r/149240
Change subject: Update class refs and remove dead code
..
Update class refs and remove dead code
Change-Id:
Jeroen De Dauw has uploaded a new change for review.
https://gerrit.wikimedia.org/r/149239
Change subject: Remove dead code
..
Remove dead code
Change-Id: Iaeba1c3b90127de7b9b1a468e2252be6a212cf3f
---
M
Jeroen De Dauw has uploaded a new change for review.
https://gerrit.wikimedia.org/r/149241
Change subject: Update class ref
..
Update class ref
Change-Id: I5e7228f8fa94cc1f52ff9b65e71f67db814cca9c
---
M
Jeroen De Dauw has uploaded a new change for review.
https://gerrit.wikimedia.org/r/149242
Change subject: [DNM] Testing against DataModel 1.0
..
[DNM] Testing against DataModel 1.0
Change-Id:
Jeroen De Dauw has uploaded a new change for review.
https://gerrit.wikimedia.org/r/149244
Change subject: DM 1.0 compat: do not use return value of
SiteLinkList::addNewSiteLink
..
DM 1.0 compat: do not use return value of
Jeroen De Dauw has uploaded a new change for review.
https://gerrit.wikimedia.org/r/149245
Change subject: Add FIXME to EntityPerPageTable
..
Add FIXME to EntityPerPageTable
Change-Id:
Jeroen De Dauw has uploaded a new change for review.
https://gerrit.wikimedia.org/r/149246
Change subject: Remove comment that perscribes dubious approach to solve a
problem
..
Remove comment that perscribes dubious approach
Jeroen De Dauw has submitted this change and it was merged.
Change subject: DM 1.0 compat: do not use return value of
SiteLinkList::addNewSiteLink
..
DM 1.0 compat: do not use return value of SiteLinkList::addNewSiteLink
Jeroen De Dauw has uploaded a new change for review.
https://gerrit.wikimedia.org/r/149247
Change subject: DM 1.0 compat: do not use return value of
SiteLinkList::addNewSiteLink
..
DM 1.0 compat: do not use return value of
Jeroen De Dauw has uploaded a new change for review.
https://gerrit.wikimedia.org/r/149248
Change subject: Remove silly lines
..
Remove silly lines
Change-Id: I1142fcc8c23df72fe78085a8a1aed519e2f5d193
---
M
Jeroen De Dauw has submitted this change and it was merged.
Change subject: Some cleanup in ClaimDiffer
..
Some cleanup in ClaimDiffer
Change-Id: Ieb255d32ef2af57cb6af52dc824faae0e045c433
---
M repo/includes/ClaimDiffer.php
1
Jeroen De Dauw has submitted this change and it was merged.
Change subject: Remove silly lines
..
Remove silly lines
Change-Id: I1142fcc8c23df72fe78085a8a1aed519e2f5d193
---
M
Jeroen De Dauw has uploaded a new change for review.
https://gerrit.wikimedia.org/r/149249
Change subject: Improve test in SpecialUnconnectedPagesTest
..
Improve test in SpecialUnconnectedPagesTest
Change-Id:
Jeroen De Dauw has uploaded a new change for review.
https://gerrit.wikimedia.org/r/149250
Change subject: Added missing type hint
..
Added missing type hint
Change-Id: Iee802e58ea477c85b3d88dfeb68a435e7be1073b
---
M
Jeroen De Dauw has submitted this change and it was merged.
Change subject: Introduce RendererFactory class for parser function
..
Introduce RendererFactory class for parser function
Change-Id:
Jeroen De Dauw has submitted this change and it was merged.
Change subject: Don't end JSON snippets with new lines
..
Don't end JSON snippets with new lines
Also moved the phpunit tests to a location which is
in line with
Jeroen De Dauw has submitted this change and it was merged.
Change subject: Split parser function rendering and snaks finding code
..
Split parser function rendering and snaks finding code
Change-Id:
Jeroen De Dauw has submitted this change and it was merged.
Change subject: Move more parser function rendering code to Renderer
..
Move more parser function rendering code to Renderer
Change-Id:
Jeroen De Dauw has submitted this change and it was merged.
Change subject: Remove unused constructor params from parser function Runner
..
Remove unused constructor params from parser function Runner
Change-Id:
Jeroen De Dauw has submitted this change and it was merged.
Change subject: Move API-based formatting logic to
wikibase.RepoApi.FormatValueCaller
..
Move API-based formatting logic to wikibase.RepoApi.FormatValueCaller
Jeroen De Dauw has submitted this change and it was merged.
Change subject: Introduce ValueViewBuilder
..
Introduce ValueViewBuilder
Change-Id: I8bb89d007cc5ea048767da026848f9db246a9c42
---
M .jshintrc
M
Jeroen De Dauw has submitted this change and it was merged.
Change subject: Change option from lang to valuelang
..
Change option from lang to valuelang
This requires https://github.com/wmde/ValueView/pull/79
Please read the
Jeroen De Dauw has submitted this change and it was merged.
Change subject: Improve parser function registration
..
Improve parser function registration
Move code into hook handler so that dependencies can
be injected and the
Jeroen De Dauw has submitted this change and it was merged.
Change subject: Remove dead code path
..
Remove dead code path
Change-Id: Ic92fdf32e1b74caedefebcc087ced6b89e40bfc1
---
M repo/resources/wikibase.ui.entityViewInit.js
Jeroen De Dauw has submitted this change and it was merged.
Change subject: Clean-up IdGenerator after redirects are done
..
Clean-up IdGenerator after redirects are done
Looks like very much of the clean-up I originally did
Jeroen De Dauw has uploaded a new change for review.
https://gerrit.wikimedia.org/r/145907
Change subject: Clean some comments
..
Clean some comments
Change-Id: Id688489e27dcfc5d85aec3d42745ec06f8ce020c
---
M
Jeroen De Dauw has uploaded a new change for review.
https://gerrit.wikimedia.org/r/145906
Change subject: Remove misplaced knowledge from comments
..
Remove misplaced knowledge from comments
Change-Id:
Jeroen De Dauw has submitted this change and it was merged.
Change subject: Remove misplaced knowledge from comments
..
Remove misplaced knowledge from comments
Change-Id: Ia734ae7165b637dd3ffa2701baababcf10cf078f
---
M
Jeroen De Dauw has uploaded a new change for review.
https://gerrit.wikimedia.org/r/145909
Change subject: Use DataValues geo 0.2
..
Use DataValues geo 0.2
Change-Id: Ifdd2d467b6999c9933d4b859d2292a7c1de2cb5a
---
M
Jeroen De Dauw has submitted this change and it was merged.
Change subject: Remove compatibility code for Sanitizer::validateEmail
..
Remove compatibility code for Sanitizer::validateEmail
Sanitizer::validateEmail was added in
Jeroen De Dauw has uploaded a new change for review.
https://gerrit.wikimedia.org/r/143869
Change subject: Fix typo
..
Fix typo
Change-Id: If56e52f0a5e9fa036f1d7b5ebcbd5a40038e42e9
---
M repo/includes/store/sql/Wikibase.sql
Jeroen De Dauw has submitted this change and it was merged.
Change subject: MWException is part of the EntityContent::getEntity interface
..
MWException is part of the EntityContent::getEntity interface
It is, isn't it? Even
Jeroen De Dauw has submitted this change and it was merged.
Change subject: Bugfix for MediaWiki 1.22+ compatibility
..
Bugfix for MediaWiki 1.22+ compatibility
Fixed direct push of files to API via cURL. Had to change the way
Jeroen De Dauw has submitted this change and it was merged.
Change subject: Add support for login domains, to make this work with LDAP
Extension. Use egPushLoginDomains.
..
Add support for login domains, to make this work with
Jeroen De Dauw has submitted this change and it was merged.
Change subject: Remove getEditUrl from SectionEditLinkGenerator interface
..
Remove getEditUrl from SectionEditLinkGenerator interface
This also changes the interface
Jeroen De Dauw has uploaded a new change for review.
https://gerrit.wikimedia.org/r/142274
Change subject: Fix docs and type hints in SiteLinksView
..
Fix docs and type hints in SiteLinksView
Change-Id:
Jeroen De Dauw has uploaded a new change for review.
https://gerrit.wikimedia.org/r/142275
Change subject: Remove unused parameters
..
Remove unused parameters
Change-Id: I89baba5fc281cb002ea8df0cd36f3960ab3a6b03
---
M
Jeroen De Dauw has uploaded a new change for review.
https://gerrit.wikimedia.org/r/142284
Change subject: Move not needed dependencies up
..
Move not needed dependencies up
Change-Id:
Jeroen De Dauw has uploaded a new change for review.
https://gerrit.wikimedia.org/r/142285
Change subject: Remove SiteStore from SiteLinksView
..
Remove SiteStore from SiteLinksView
Change-Id:
Jeroen De Dauw has submitted this change and it was merged.
Change subject: Drop unused constraint messages
..
Drop unused constraint messages
Introduced in I4da67c8fc77092e3c4395edba4f509050aab1bb5,
unused since
Jeroen De Dauw has submitted this change and it was merged.
Change subject: Simplify API-based parsers in JS
..
Simplify API-based parsers in JS
Change-Id: I2634b82498aa6bc6b7fab9cbd81cbecede3d9d34
---
D
Jeroen De Dauw has uploaded a new change for review.
https://gerrit.wikimedia.org/r/142435
Change subject: Add missing type hint
..
Add missing type hint
Change-Id: I042540bd61220f1105d77fffe2e79bea0031f467
---
M
Jeroen De Dauw has uploaded a new change for review.
https://gerrit.wikimedia.org/r/142438
Change subject: Remove unused parameters and reduce visibility scope
..
Remove unused parameters and reduce visibility scope
Jeroen De Dauw has uploaded a new change for review.
https://gerrit.wikimedia.org/r/142451
Change subject: Stop using SimpleSiteLink alias
..
Stop using SimpleSiteLink alias
Change-Id:
Jeroen De Dauw has uploaded a new change for review.
https://gerrit.wikimedia.org/r/142452
Change subject: Stop using SimpleSiteLink alias
..
Stop using SimpleSiteLink alias
Change-Id:
Jeroen De Dauw has uploaded a new change for review.
https://gerrit.wikimedia.org/r/142453
Change subject: Stop using SimpleSiteLink alias
..
Stop using SimpleSiteLink alias
Change-Id:
Jeroen De Dauw has uploaded a new change for review.
https://gerrit.wikimedia.org/r/142454
Change subject: Rem dead method
..
Rem dead method
Change-Id: If75178bca0612c6ab6043f6d57252a21dde1ffe3
---
M
Jeroen De Dauw has submitted this change and it was merged.
Change subject: Move FetchedContentUnserializer from wb.serialization to
wb.store
..
Move FetchedContentUnserializer from wb.serialization to wb.store
Change-Id:
Jeroen De Dauw has submitted this change and it was merged.
Change subject: Remove unused function
..
Remove unused function
Change-Id: I370ac6103c76e0e2bb23fee807e5b6baa871e163
---
M
Jeroen De Dauw has submitted this change and it was merged.
Change subject: Remove duplicate dependency
..
Remove duplicate dependency
Change-Id: I01434c518a131961e373566b251c4c4231e79eb7
---
M lib/resources/Resources.php
1
Jeroen De Dauw has submitted this change and it was merged.
Change subject: Move uncompressed JavaScript comment out
..
Move uncompressed JavaScript comment out
This saves about 400 bytes of source code commentary that are
Jeroen De Dauw has submitted this change and it was merged.
Change subject: Register expert for MonolingualText
..
Register expert for MonolingualText
Bug: 64290
Change-Id: I65b504b75120a93880e448f22e451b71ee724cd9
---
M
Jeroen De Dauw has submitted this change and it was merged.
Change subject: Don't use unchecked global jQuery variable in non-critical
JavaScript
..
Don't use unchecked global jQuery variable in non-critical JavaScript
This
Jeroen De Dauw has submitted this change and it was merged.
Change subject: Fix @covers tag in client
..
Fix @covers tag in client
Change-Id: I2b44ec470e1475e98d5e77a4375cfed91966f4df
---
M
Jeroen De Dauw has uploaded a new change for review.
https://gerrit.wikimedia.org/r/140725
Change subject: Remove unused var
..
Remove unused var
Change-Id: Iae3dd3bbc5b32b680d14bf63a1778f9468bfd7e3
---
M
Jeroen De Dauw has uploaded a new change for review.
https://gerrit.wikimedia.org/r/140727
Change subject: Update Item reference
..
Update Item reference
Change-Id: I0a516e522f9e4f7e2376bfd5d3a8ba9a3ae42963
---
M
Jeroen De Dauw has submitted this change and it was merged.
Change subject: Fix 'Wikibase\SiteLinkTable' not found error in dispatchChanges
..
Fix 'Wikibase\SiteLinkTable' not found error in dispatchChanges
@todo next step,
Jeroen De Dauw has submitted this change and it was merged.
Change subject: Introduce Wikibase\Repo\View
..
Introduce Wikibase\Repo\View
Change-Id: If984fd732cd29c16aef5def1535116e2b87cf745
---
M composer.json
M
Jeroen De Dauw has submitted this change and it was merged.
Change subject: Factor out generation of site links HTML into own class
..
Factor out generation of site links HTML into own class
This has the nice side effect of
601 - 700 of 4901 matches
Mail list logo
