[MediaWiki-commits] [Gerrit] mediawiki/core[master]: resourceloader: Implement isKnownEmpty for user.options module

2017-09-18 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/378749 ) Change subject: resourceloader: Implement isKnownEmpty for user.options module .. resourceloader: Implement isKnownEmpty for user.options mo

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: resourceloader: Support isKnownEmpty for general modules

2017-09-18 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/378748 ) Change subject: resourceloader: Support isKnownEmpty for general modules .. resourceloader: Support isKnownEmpty for general modules It was

[MediaWiki-commits] [Gerrit] integration/docroot[master]: zuul: Don't toggle panel when clicking Gerrit patch link

2017-09-18 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/378743 ) Change subject: zuul: Don't toggle panel when clicking Gerrit patch link .. zuul: Don't toggle panel when clicking Gerrit patch link Each p

[MediaWiki-commits] [Gerrit] mediawiki...NavigationTiming[wmf/1.30.0-wmf.18]: Unbreak navTiming reporting

2017-09-18 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/378740 ) Change subject: Unbreak navTiming reporting .. Unbreak navTiming reporting Follows-up 3d5946f. The check for '> 0' of the computed relative

[MediaWiki-commits] [Gerrit] mediawiki...NavigationTiming[master]: Unbreak navTiming reporting

2017-09-18 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/378737 ) Change subject: Unbreak navTiming reporting .. Unbreak navTiming reporting Follows-up 3d5946f. The check for '> 0' of the computed relative

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: mw.loader: Prefer inherit over $.extend copying each prop wh...

2017-09-14 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/378070 ) Change subject: mw.loader: Prefer inherit over $.extend copying each prop where possible .. mw.loader: Prefer inherit over $.extend copying

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: mediawiki.Title: Remove obsolete Object.create ES3 fallback

2017-09-14 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/378065 ) Change subject: mediawiki.Title: Remove obsolete Object.create ES3 fallback .. mediawiki.Title: Remove obsolete Object.create ES3 fallback

[MediaWiki-commits] [Gerrit] mediawiki...PerformanceInspector[master]: startup: Use $() instead of deprecated $(document).ready()

2017-09-14 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/378063 ) Change subject: startup: Use $() instead of deprecated $(document).ready() .. startup: Use $() instead of deprecated $(document).ready()

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: mw.loader: Add unit test to confirm implicit 'site' dependen...

2017-09-14 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/377994 ) Change subject: mw.loader: Add unit test to confirm implicit 'site' dependency for 'user' .. mw.loader: Add unit test to confirm implicit '

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: mw.loader: Remove Deferred overhead from execute() hot code ...

2017-09-14 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/377995 ) Change subject: mw.loader: Remove Deferred overhead from execute() hot code path .. mw.loader: Remove Deferred overhead from execute() hot c

[MediaWiki-commits] [Gerrit] operations/puppet[production]: webperf: Use minimum sampling of 5 hits/min for by-country b...

2017-09-13 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/377806 ) Change subject: webperf: Use minimum sampling of 5 hits/min for by-country breakdown in navtiming .. webperf: Use minimum sampling of 5 hit

[MediaWiki-commits] [Gerrit] mediawiki...NavigationTiming[wmf/1.30.0-wmf.17]: Add unload delta to make reliable stackable metrics.

2017-09-12 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/377454 ) Change subject: Add unload delta to make reliable stackable metrics. .. Add unload delta to make reliable stackable metrics. Bug: T104902 C

[MediaWiki-commits] [Gerrit] labs...guc[master]: api: Remove hardcoded shard list, prep for new wikidata shar...

2017-09-12 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/377447 ) Change subject: api: Remove hardcoded shard list, prep for new wikidata shard (s8) .. api: Remove hardcoded shard list, prep for new wikida

[MediaWiki-commits] [Gerrit] labs...wikibugs2[master]: wikimedia-visualeditor: Add #Editing-team

2017-09-05 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/376156 ) Change subject: wikimedia-visualeditor: Add #Editing-team .. wikimedia-visualeditor: Add #Editing-team Change-Id: I3e07315a45241018fe5b2a65

[MediaWiki-commits] [Gerrit] operations/puppet[production]: jsbench: Prep osmium for decom and remove 've' and 'jsbench'...

2017-09-05 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/376151 ) Change subject: jsbench: Prep osmium for decom and remove 've' and 'jsbench' roles .. jsbench: Prep osmium for decom and remove 've' and 'j

[MediaWiki-commits] [Gerrit] operations/puppet[production]: webperf: Decom webperf::ve service

2017-09-05 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/376146 ) Change subject: webperf: Decom webperf::ve service .. webperf: Decom webperf::ve service Bug: T175083 Change-Id: I76bf0e43d700120551f79013a

[MediaWiki-commits] [Gerrit] labs...wikibugs2[master]: wikimedia-editing: Update renamed Editing-Department tag

2017-09-05 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/376144 ) Change subject: wikimedia-editing: Update renamed Editing-Department tag .. wikimedia-editing: Update renamed Editing-Department tag Tasks

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: resourceloader: Reduce severity for non-fatal JS errors to w...

2017-09-05 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/376036 ) Change subject: resourceloader: Reduce severity for non-fatal JS errors to warn() .. resourceloader: Reduce severity for non-fatal JS error

[MediaWiki-commits] [Gerrit] mediawiki...WaitConditionLoop[master]: readme: Fix broken rendering in Doxygen of code example

2017-09-04 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/375930 ) Change subject: readme: Fix broken rendering in Doxygen of code example .. readme: Fix broken rendering in Doxygen of code example Requires

[MediaWiki-commits] [Gerrit] mediawiki...TimedMediaHandler[master]: Remove dead isAndroid2() code

2017-09-04 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/375862 ) Change subject: Remove dead isAndroid2() code .. Remove dead isAndroid2() code Android 2 is a Grade C browser which is no longer served any

[MediaWiki-commits] [Gerrit] mediawiki...MwEmbedSupport[master]: Remove dead isAndroid2() code

2017-09-04 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/375861 ) Change subject: Remove dead isAndroid2() code .. Remove dead isAndroid2() code Android 2 is a Grade C browser which is no longer served any

[MediaWiki-commits] [Gerrit] operations/puppet[production]: webperf: Convert ve.py from ZMQ to KafkaConsumer

2017-08-31 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/375106 ) Change subject: webperf: Convert ve.py from ZMQ to KafkaConsumer .. webperf: Convert ve.py from ZMQ to KafkaConsumer Follows-up 06e9b65a7cc

[MediaWiki-commits] [Gerrit] operations/puppet[production]: webperf: Refactor ve.py and add unit tests

2017-08-31 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/375105 ) Change subject: webperf: Refactor ve.py and add unit tests .. webperf: Refactor ve.py and add unit tests Bug: T110903 Change-Id: I96e81be8d

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: exception: Support message normalisation for structured logging

2017-08-30 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/374895 ) Change subject: exception: Support message normalisation for structured logging .. exception: Support message normalisation for structured l

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Enable jQuery 3 on nlwiki sister projects (b, n, q, s, wikt)

2017-08-30 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/374850 ) Change subject: Enable jQuery 3 on nlwiki sister projects (b, n, q, s, wikt) .. Enable jQuery 3 on nlwiki sister projects (b, n, q, s, wikt)

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Enable jQuery 3 on nlwiki, svwiki, plwiki

2017-08-25 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/373987 ) Change subject: Enable jQuery 3 on nlwiki, svwiki, plwiki .. Enable jQuery 3 on nlwiki, svwiki, plwiki * svwiki: Confirmed by @Nirmox on T1

[MediaWiki-commits] [Gerrit] mediawiki/core[wmf/1.30.0-wmf.15]: Disable rebound CDN purges for backlinks in HTMLCacheUpdateJob

2017-08-25 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/373984 ) Change subject: Disable rebound CDN purges for backlinks in HTMLCacheUpdateJob .. Disable rebound CDN purges for backlinks in HTMLCacheUpdat

[MediaWiki-commits] [Gerrit] mediawiki/core[wmf/1.30.0-wmf.15]: Fix old regression in HTMLCacheUpdate de-duplication

2017-08-25 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/373983 ) Change subject: Fix old regression in HTMLCacheUpdate de-duplication .. Fix old regression in HTMLCacheUpdate de-duplication * The conditio

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: Docs: Fix typo in Grafana link label

2017-08-25 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/373981 ) Change subject: Docs: Fix typo in Grafana link label .. Docs: Fix typo in Grafana link label Change-Id: I35d984b9fd5d8dc39cb17d2ff1e69e58a4

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Skin: Make skins aware of their registered skin name

2017-08-25 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/373971 ) Change subject: Skin: Make skins aware of their registered skin name .. Skin: Make skins aware of their registered skin name Remove the nee

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Skin: Remove more use of QuickTemplate::setRef()

2017-08-23 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/373356 ) Change subject: Skin: Remove more use of QuickTemplate::setRef() .. Skin: Remove more use of QuickTemplate::setRef() Follows-up 2c01147c13b

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Mark various skin/OutputPage hooks as unabortable

2017-08-18 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/372595 ) Change subject: Mark various skin/OutputPage hooks as unabortable .. Mark various skin/OutputPage hooks as unabortable Follows-up I94c7ab65

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Hooks: Introduce NO_ABORT mode in Hooks::run()

2017-08-18 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/372594 ) Change subject: Hooks: Introduce NO_ABORT mode in Hooks::run() .. Hooks: Introduce NO_ABORT mode in Hooks::run() When set, any hook that re

[MediaWiki-commits] [Gerrit] mediawiki...Popups[wmf/1.30.0-wmf.14]: Remove aborting of BeforePageDisplay hook

2017-08-18 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/372593 ) Change subject: Remove aborting of BeforePageDisplay hook .. Remove aborting of BeforePageDisplay hook This caused random extensions to not

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: debug: Add cli_argv field to monolog WikiProcessor

2017-08-18 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/372592 ) Change subject: debug: Add cli_argv field to monolog WikiProcessor .. debug: Add cli_argv field to monolog WikiProcessor Follows investigat

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: Remove aborting of BeforePageDisplay hook

2017-08-18 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/372591 ) Change subject: Remove aborting of BeforePageDisplay hook .. Remove aborting of BeforePageDisplay hook This caused random extensions to not

[MediaWiki-commits] [Gerrit] operations/puppet[production]: webperf: Add unit tests for schema handlers and stat dispatc...

2017-08-18 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/372577 ) Change subject: webperf: Add unit tests for schema handlers and stat dispatching .. webperf: Add unit tests for schema handlers and stat dis

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Remove deprecated jquery.mwExtension module

2017-08-17 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/372498 ) Change subject: Remove deprecated jquery.mwExtension module .. Remove deprecated jquery.mwExtension module * Deprecated since MediaWiki 1.2

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: jquery.migrate: Instrument with mw.track()

2017-08-17 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/372496 ) Change subject: jquery.migrate: Instrument with mw.track() .. jquery.migrate: Instrument with mw.track() Inspired by cb20b5aa5a68d, which a

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Update jQuery Migrate to v3.0.1-pre (9e3dfcb)

2017-08-17 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/372494 ) Change subject: Update jQuery Migrate to v3.0.1-pre (9e3dfcb) .. Update jQuery Migrate to v3.0.1-pre (9e3dfcb) Highlights: * Event: Warn a

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Enable jQuery 3 on mediawiki.org and test.wikidata.org

2017-08-17 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/372485 ) Change subject: Enable jQuery 3 on mediawiki.org and test.wikidata.org .. Enable jQuery 3 on mediawiki.org and test.wikidata.org Follows-up

[MediaWiki-commits] [Gerrit] operations/puppet[production]: webperf: Convert navtiming.py to use KafkaConsumer

2017-08-17 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/372483 ) Change subject: webperf: Convert navtiming.py to use KafkaConsumer .. webperf: Convert navtiming.py to use KafkaConsumer Test plain: * Copy

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Skin: Remove redundant use of QuickTemplate::setRef()

2017-08-17 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/372471 ) Change subject: Skin: Remove redundant use of QuickTemplate::setRef() .. Skin: Remove redundant use of QuickTemplate::setRef() As part of l

[MediaWiki-commits] [Gerrit] utfnormal[master]: build: Update mediawiki/codesniffer to 0.11

2017-08-17 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/372443 ) Change subject: build: Update mediawiki/codesniffer to 0.11 .. build: Update mediawiki/codesniffer to 0.11 Change-Id: Id5e7a0544efc5d295c8d

[MediaWiki-commits] [Gerrit] utfnormal[master]: build: Update require-dev, enable coverage, update Travis image

2017-08-16 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/372226 ) Change subject: build: Update require-dev, enable coverage, update Travis image .. build: Update require-dev, enable coverage, update Travis

[MediaWiki-commits] [Gerrit] utfnormal[master]: Drop support for PHP 5.3 and PHP 5.4

2017-08-16 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/372225 ) Change subject: Drop support for PHP 5.3 and PHP 5.4 .. Drop support for PHP 5.3 and PHP 5.4 Per T75901, MediaWiki no longer supports this.

[MediaWiki-commits] [Gerrit] mediawiki...PoolCounter[master]: Move sources to includes/, remove b/c files

2017-08-13 Thread Krinkle (Code Review)
Krinkle has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/370698 ) Change subject: Move sources to includes/, remove b/c files .. Move sources to includes/, remove b/c files Change-Id: I2c0f0654f0a9

[MediaWiki-commits] [Gerrit] mediawiki/core[wmf/1.30.0-wmf.13]: Disallow job pushes from JobQueueGroup to bogus wikis

2017-08-12 Thread Krinkle (Code Review)
Krinkle has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/371643 ) Change subject: Disallow job pushes from JobQueueGroup to bogus wikis .. Disallow job pushes from JobQueueGroup to bogus wikis Bug:

[MediaWiki-commits] [Gerrit] mediawiki/core[wmf/1.30.0-wmf.13]: Disallow job pushes from JobQueueGroup to bogus wikis

2017-08-12 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/371643 ) Change subject: Disallow job pushes from JobQueueGroup to bogus wikis .. Disallow job pushes from JobQueueGroup to bogus wikis Bug: T171371

[MediaWiki-commits] [Gerrit] mediawiki...Timeless[master]: build: Resolve suppressed eslint warnings

2017-08-12 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/371624 ) Change subject: build: Resolve suppressed eslint warnings .. build: Resolve suppressed eslint warnings * Consistent string quoting style. *

[MediaWiki-commits] [Gerrit] mediawiki...Timeless[master]: build: Switch from JSHint to ESLint

2017-08-12 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/371623 ) Change subject: build: Switch from JSHint to ESLint .. build: Switch from JSHint to ESLint Change-Id: Ie090d1ba345b5e59c06c5aaa30cacfb14a41

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: SpecialDoubleRedirects: Fix undefined '$result->namespace' n...

2017-08-10 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/371143 ) Change subject: SpecialDoubleRedirects: Fix undefined '$result->namespace' notice .. SpecialDoubleRedirects: Fix undefined '$result->namesp

[MediaWiki-commits] [Gerrit] mediawiki...CirrusSearch[master]: tests: Avoid production-like dc and host names

2017-08-09 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/370875 ) Change subject: tests: Avoid production-like dc and host names .. tests: Avoid production-like dc and host names As a matter of principle,

[MediaWiki-commits] [Gerrit] labs...guc[master]: api: Fix 'replag.lagged' data to look at all instead of just...

2017-08-09 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/370856 ) Change subject: api: Fix 'replag.lagged' data to look at all instead of just the last shard .. api: Fix 'replag.lagged' data to look at all

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Make tests QUnit 2 compatible

2017-08-04 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/370300 ) Change subject: Make tests QUnit 2 compatible .. Make tests QUnit 2 compatible * Remove testCount in favour of assert.expect(). * Remove QU

[MediaWiki-commits] [Gerrit] mediawiki/core[wmf/1.30.0-wmf.12]: Special:Contribs: Ensure 'start' and 'end' are never undefined

2017-08-03 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/370142 ) Change subject: Special:Contribs: Ensure 'start' and 'end' are never undefined .. Special:Contribs: Ensure 'start' and 'end' are never undef

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: SpecialDoubleRedirects: Use more descriptive aliases in the ...

2017-08-03 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/370141 ) Change subject: SpecialDoubleRedirects: Use more descriptive aliases in the query .. SpecialDoubleRedirects: Use more descriptive aliases i

[MediaWiki-commits] [Gerrit] operations/puppet[production]: webperf: Fix broken example value for eventlogging_path

2017-08-03 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/370138 ) Change subject: webperf: Fix broken example value for eventlogging_path .. webperf: Fix broken example value for eventlogging_path Follows-

[MediaWiki-commits] [Gerrit] operations/puppet[production]: webperf: Move statsv monitoring from 'webperf' to 'webperf::...

2017-08-02 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/369835 ) Change subject: webperf: Move statsv monitoring from 'webperf' to 'webperf::statsv' .. webperf: Move statsv monitoring from 'webperf' to 'w

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: DefaultSettings: Update wgLocalVirtualHosts documentation

2017-08-02 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/369824 ) Change subject: DefaultSettings: Update wgLocalVirtualHosts documentation .. DefaultSettings: Update wgLocalVirtualHosts documentation Chan

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: wmf-config: Improve docs in CommonSettings.php and LocalSett...

2017-08-02 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/369818 ) Change subject: wmf-config: Improve docs in CommonSettings.php and LocalSettings.php header .. wmf-config: Improve docs in CommonSettings.p

[MediaWiki-commits] [Gerrit] oojs/core[master]: build: Add Travis CI and Codecov configuration

2017-07-29 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/368575 ) Change subject: build: Add Travis CI and Codecov configuration .. build: Add Travis CI and Codecov configuration * Update karma-chrome-laun

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: phpunit: Fix failing DeprecatedGlobalTest on HHVM at Travis CI

2017-07-28 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/368534 ) Change subject: phpunit: Fix failing DeprecatedGlobalTest on HHVM at Travis CI .. phpunit: Fix failing DeprecatedGlobalTest on HHVM at Travi

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: build: Update Travis CI config to use fast Trusty containers

2017-07-28 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/368535 ) Change subject: build: Update Travis CI config to use fast Trusty containers .. build: Update Travis CI config to use fast Trusty containers

[MediaWiki-commits] [Gerrit] mediawiki/vendor[master]: Update wikimedia/relpath from 1.0.3 -> 2.0.0

2017-07-28 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/368519 ) Change subject: Update wikimedia/relpath from 1.0.3 -> 2.0.0 .. Update wikimedia/relpath from 1.0.3 -> 2.0.0 Change-Id: I98eb809ff72c4d09bf

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Update wikimedia/relpath from 1.0.3 -> 2.0.0

2017-07-28 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/368518 ) Change subject: Update wikimedia/relpath from 1.0.3 -> 2.0.0 .. Update wikimedia/relpath from 1.0.3 -> 2.0.0 * (4f670afd92) Normalize leadi

[MediaWiki-commits] [Gerrit] RelPath[master]: Drop support for PHP 5.3 and PHP 5.4

2017-07-28 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/368516 ) Change subject: Drop support for PHP 5.3 and PHP 5.4 .. Drop support for PHP 5.3 and PHP 5.4 Per T75901, MediaWiki no longer supports this.

[MediaWiki-commits] [Gerrit] RelPath[master]: build: Migrate to Trusty image to fix HHVM

2017-07-28 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/368487 ) Change subject: build: Migrate to Trusty image to fix HHVM .. build: Migrate to Trusty image to fix HHVM Since the last build (4 months ago

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: resourceloader: Fix @covers for CSSMin tests

2017-07-27 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/368348 ) Change subject: resourceloader: Fix @covers for CSSMin tests .. resourceloader: Fix @covers for CSSMin tests Change-Id: Idb451d244fbdfbb218

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: rdbms: Complete coverage for Database::selectSQLText()

2017-07-27 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/368346 ) Change subject: rdbms: Complete coverage for Database::selectSQLText() .. rdbms: Complete coverage for Database::selectSQLText() Only missi

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: phpunit: Exclude /languages/messages from coverage report

2017-07-27 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/368344 ) Change subject: phpunit: Exclude /languages/messages from coverage report .. phpunit: Exclude /languages/messages from coverage report Inde

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: benchmarks: Add benchmarks for MapCacheLRU and HashBagOStuff

2017-07-27 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/368308 ) Change subject: benchmarks: Add benchmarks for MapCacheLRU and HashBagOStuff .. benchmarks: Add benchmarks for MapCacheLRU and HashBagOStuff

[MediaWiki-commits] [Gerrit] mediawiki...PoolCounter[master]: Add README.md

2017-07-26 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/368126 ) Change subject: Add README.md .. Add README.md Change-Id: Iad03c9ef47cef99056f19bbaf1672952399279d7 --- A README.md 1 file changed, 35 inse

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: resourceloader: Include lessVars in FileModule definition su...

2017-07-26 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/368122 ) Change subject: resourceloader: Include lessVars in FileModule definition summary .. resourceloader: Include lessVars in FileModule definit

[MediaWiki-commits] [Gerrit] data-values/value-view[master]: Make tests compatible with QUnit 2

2017-07-26 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/368121 ) Change subject: Make tests compatible with QUnit 2 .. Make tests compatible with QUnit 2 Avoid QUnit.asyncTest, QUnit.start/stop (deprecate

[MediaWiki-commits] [Gerrit] mediawiki...WikimediaMaintenance[master]: Create new wmfManageJobs.php for deleting queues from delete...

2017-07-26 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/368116 ) Change subject: Create new wmfManageJobs.php for deleting queues from deleted wikis .. Create new wmfManageJobs.php for deleting queues fro

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: [WIP] ParserOutput: Implement getText() post-cache transform...

2017-07-26 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/368107 ) Change subject: [WIP] ParserOutput: Implement getText() post-cache transform options .. [WIP] ParserOutput: Implement getText() post-cache

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: [WIP] Failing DatabaseTest::testTransactionPreCommitOrIdle_TRX

2017-07-26 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/368093 ) Change subject: [WIP] Failing DatabaseTest::testTransactionPreCommitOrIdle_TRX .. [WIP] Failing DatabaseTest::testTransactionPreCommitOrIdle

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Revert "Bump cache epoch for Wikidata"

2017-07-25 Thread Krinkle (Code Review)
Hello Aude, Hoo man, Florianschmidtwelzow, jenkins-bot, I'd like you to do a code review. Please visit https://gerrit.wikimedia.org/r/367853 to review the following change. Change subject: Revert "Bump cache epoch for Wikidata" .

[MediaWiki-commits] [Gerrit] mediawiki...UploadWizard[master]: Remove use of deprecated QUnit testCount

2017-07-25 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/367843 ) Change subject: Remove use of deprecated QUnit testCount .. Remove use of deprecated QUnit testCount Change-Id: I65918710c2b64e51127f669b55

[MediaWiki-commits] [Gerrit] mediawiki...UploadWizard[master]: Make tests QUnit 2 compatible

2017-07-25 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/367844 ) Change subject: Make tests QUnit 2 compatible .. Make tests QUnit 2 compatible * Remove use of QUnit.asyncTest and QUnit.start/stop. * Use

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: jquery.tablesorter: Make tests QUnit 2 compatible (remove te...

2017-07-25 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/367839 ) Change subject: jquery.tablesorter: Make tests QUnit 2 compatible (remove testCount) .. jquery.tablesorter: Make tests QUnit 2 compatible (

[MediaWiki-commits] [Gerrit] mediawiki...MultimediaViewer[master]: Avoid use of deprecated QUnit.asyncTest and QUnit.start/stop

2017-07-25 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/367830 ) Change subject: Avoid use of deprecated QUnit.asyncTest and QUnit.start/stop .. Avoid use of deprecated QUnit.asyncTest and QUnit.start/stop

[MediaWiki-commits] [Gerrit] mediawiki...MultimediaViewer[master]: [WIP] Avoid use of deprecated QUnit.asyncTest, QUnit.start a...

2017-07-25 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/367827 ) Change subject: [WIP] Avoid use of deprecated QUnit.asyncTest, QUnit.start and QUnit.stop .. [WIP] Avoid use of deprecated QUnit.asyncTest,

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: qunit: Remove unused and broken sinon.assert overrides

2017-07-25 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/367821 ) Change subject: qunit: Remove unused and broken sinon.assert overrides .. qunit: Remove unused and broken sinon.assert overrides Noticed th

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: Avoid use of deprecated QUnit.asyncTest()

2017-07-25 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/367820 ) Change subject: Avoid use of deprecated QUnit.asyncTest() .. Avoid use of deprecated QUnit.asyncTest() Bug: T170879 Change-Id: Ia3cb71f5558

[MediaWiki-commits] [Gerrit] mediawiki...jobrunner[master]: scap: Remove restart configuration

2017-07-25 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/367743 ) Change subject: scap: Remove restart configuration .. scap: Remove restart configuration The current config would issue a restart in both d

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Re-introduce use of mime_content_type()

2017-07-24 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/367640 ) Change subject: Re-introduce use of mime_content_type() .. Re-introduce use of mime_content_type() Follows-up eac059c7224. See also https:/

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: MultiWriteBagOStuff: Fix async writes of mutable objects

2017-07-24 Thread Krinkle (Code Review)
Krinkle has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/363831 ) Change subject: MultiWriteBagOStuff: Fix async writes of mutable objects .. MultiWriteBagOStuff: Fix async writes of mutable objects

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: rdbms: Increase coverage for Database::selectSQLText()

2017-07-24 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/367638 ) Change subject: rdbms: Increase coverage for Database::selectSQLText() .. rdbms: Increase coverage for Database::selectSQLText() * Add case

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: rdbms: Add more @covers to DatabaseSQLTest

2017-07-24 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/367637 ) Change subject: rdbms: Add more @covers to DatabaseSQLTest .. rdbms: Add more @covers to DatabaseSQLTest Many of the main methods here have

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: config: Add more EtcdConfig::fetchAllFromEtcdServer tests

2017-07-24 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/367476 ) Change subject: config: Add more EtcdConfig::fetchAllFromEtcdServer tests .. config: Add more EtcdConfig::fetchAllFromEtcdServer tests Bug:

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: config: Fix invalid EtcdConfig return value after JSON parse...

2017-07-24 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/367475 ) Change subject: config: Fix invalid EtcdConfig return value after JSON parse error .. config: Fix invalid EtcdConfig return value after JSO

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: config: Add tests for EtcdConfig::fetchAllFromEtcdServer

2017-07-22 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/367127 ) Change subject: config: Add tests for EtcdConfig::fetchAllFromEtcdServer .. config: Add tests for EtcdConfig::fetchAllFromEtcdServer Follow

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: config: Complete coverage for Config class

2017-07-22 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/367120 ) Change subject: config: Complete coverage for Config class .. config: Complete coverage for Config class * Fix @covers for testSalvage and

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: phpunit: Remove skins/ from coverage index

2017-07-22 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/367118 ) Change subject: phpunit: Remove skins/ from coverage index .. phpunit: Remove skins/ from coverage index As of a few releases ago, there ar

[MediaWiki-commits] [Gerrit] operations/puppet[production]: openstack: Remove stray pmtpa references

2017-07-21 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/367004 ) Change subject: openstack: Remove stray pmtpa references .. openstack: Remove stray pmtpa references Change-Id: I55be73c44018133f9280d76a03

[MediaWiki-commits] [Gerrit] mediawiki/vagrant[master]: wikitech: Remove stray pmtpa references

2017-07-21 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/367003 ) Change subject: wikitech: Remove stray pmtpa references .. wikitech: Remove stray pmtpa references The 'eqiad' references probably shouldn'

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: rdbms: Complete DatabaseDomain code coverage

2017-07-21 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/366997 ) Change subject: rdbms: Complete DatabaseDomain code coverage .. rdbms: Complete DatabaseDomain code coverage Add missing coverage for: * Da

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Enable jQuery 3 on test.wikipedia.org and test2.wikipedia.org

2017-07-21 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/366994 ) Change subject: Enable jQuery 3 on test.wikipedia.org and test2.wikipedia.org .. Enable jQuery 3 on test.wikipedia.org and test2.wikipedia.o

<    1   2   3   4   5   6   7   8   9   10   >