[MediaWiki-commits] [Gerrit] mediawiki...WikibaseLexeme[master]: Add dummy EntityHandler for Forms

2017-12-18 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/398843 ) Change subject: Add dummy EntityHandler for Forms .. Add dummy EntityHandler for Forms Does nothing, but declaration of such services

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseLexeme[master]: Rename FormSet::add to set

2017-12-18 Thread Thiemo Kreuz (WMDE) (Code Review)
Thiemo Kreuz (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/398838 ) Change subject: Rename FormSet::add to set .. Rename FormSet::add to set It's literally a Set. Elements in a Set are,

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Escape autocomment message arguments

2017-12-18 Thread Lucas Werkmeister (WMDE) (Code Review)
Lucas Werkmeister (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/398821 ) Change subject: Escape autocomment message arguments .. Escape autocomment message arguments As far as I can tell, none

[MediaWiki-commits] [Gerrit] mediawiki...TwoColConflict[master]: Replace class_exists with proper extension registration checks

2017-12-18 Thread WMDE-Fisch (Code Review)
WMDE-Fisch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/398820 ) Change subject: Replace class_exists with proper extension registration checks .. Replace class_exists with proper extension

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Avoid using EntityDiffChangedAspectsFactory like a static co...

2017-12-18 Thread Thiemo Kreuz (WMDE) (Code Review)
Thiemo Kreuz (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/398815 ) Change subject: Avoid using EntityDiffChangedAspectsFactory like a static constructor .. Avoid using

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Replace class_exists with proper extension registration checks

2017-12-18 Thread Thiemo Kreuz (WMDE) (Code Review)
Thiemo Kreuz (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/398797 ) Change subject: Replace class_exists with proper extension registration checks .. Replace class_exists with proper extension

[MediaWiki-commits] [Gerrit] mediawiki...AdvancedSearch[master]: Replace class_exists with proper extension registration checks

2017-12-18 Thread Thiemo Kreuz (WMDE) (Code Review)
Thiemo Kreuz (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/398796 ) Change subject: Replace class_exists with proper extension registration checks .. Replace class_exists with proper extension

[MediaWiki-commits] [Gerrit] mediawiki...CentralAuth[master]: Replace class_exists with proper extension registration checks

2017-12-18 Thread Thiemo Kreuz (WMDE) (Code Review)
Thiemo Kreuz (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/398794 ) Change subject: Replace class_exists with proper extension registration checks .. Replace class_exists with proper extension

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseLexeme[master]: Adapt JS statement revision data to allow saving statement o...

2017-12-15 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/398496 ) Change subject: Adapt JS statement revision data to allow saving statement on forms .. Adapt JS statement revision data to allow

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseQualityConstraints[master]: Minor test improvements

2017-12-15 Thread Lucas Werkmeister (WMDE) (Code Review)
Lucas Werkmeister (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/398487 ) Change subject: Minor test improvements .. Minor test improvements The “equal” matcher is the default, it doesn’t need to

[MediaWiki-commits] [Gerrit] mediawiki...Echo[master]: Minor cleanups to PHPDoc blocks

2017-12-15 Thread Thiemo Kreuz (WMDE) (Code Review)
Thiemo Kreuz (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/398476 ) Change subject: Minor cleanups to PHPDoc blocks .. Minor cleanups to PHPDoc blocks Change-Id

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: [DNM] Trigger failing EchoNotificationsHandlersTest

2017-12-15 Thread Thiemo Kreuz (WMDE) (Code Review)
Thiemo Kreuz (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/398475 ) Change subject: [DNM] Trigger failing EchoNotificationsHandlersTest .. [DNM] Trigger failing EchoNotificationsHandlersTest

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Add tests for invalid callbacks to TypeDispatchingEntity… cl...

2017-12-15 Thread Thiemo Kreuz (WMDE) (Code Review)
Thiemo Kreuz (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/398443 ) Change subject: Add tests for invalid callbacks to TypeDispatchingEntity… classes .. Add tests for invalid callbacks to

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: [WIP] Use MediaWiki's PSR-4 autoloader

2017-12-15 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/398010 ) Change subject: [WIP] Use MediaWiki's PSR-4 autoloader .. [WIP] Use MediaWiki's PSR-4 autoloader TODO: finish + ticket!

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Remove dead, unused method from abstract ModifyTerm

2017-12-14 Thread Thiemo Kreuz (WMDE) (Code Review)
Thiemo Kreuz (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/398291 ) Change subject: Remove dead, unused method from abstract ModifyTerm .. Remove dead, unused method from abstract ModifyTerm

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseLexeme[master]: Remove unused helpMessage code from senseview

2017-12-14 Thread Thiemo Kreuz (WMDE) (Code Review)
Thiemo Kreuz (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/398275 ) Change subject: Remove unused helpMessage code from senseview .. Remove unused helpMessage code from senseview Change-Id

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Make (get)HelpMessage optional in $.wikibase.edittoolbar.js

2017-12-14 Thread Thiemo Kreuz (WMDE) (Code Review)
Thiemo Kreuz (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/398274 ) Change subject: Make (get)HelpMessage optional in $.wikibase.edittoolbar.js .. Make (get)HelpMessage optional in

[MediaWiki-commits] [Gerrit] mediawiki...TwoColConflict[master]: Reject non-editable pages in test page

2017-12-14 Thread Lucas Werkmeister (WMDE) (Code Review)
Lucas Werkmeister (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/398270 ) Change subject: Reject non-editable pages in test page .. Reject non-editable pages in test page If the content model of

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseQualityConstraints[master]: Rename includes/ to src/

2017-12-14 Thread Lucas Werkmeister (WMDE) (Code Review)
Lucas Werkmeister (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/398261 ) Change subject: Rename includes/ to src/ .. Rename includes/ to src/ Git history details: - `git blame` follows whole

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseQualityConstraints[master]: Move source code into includes/

2017-12-14 Thread Lucas Werkmeister (WMDE) (Code Review)
Lucas Werkmeister (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/398260 ) Change subject: Move source code into includes/ .. Move source code into includes/ The Api and Specials namespaces are

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseQualityConstraints[master]: Add messages for longer cache durations

2017-12-14 Thread Lucas Werkmeister (WMDE) (Code Review)
Lucas Werkmeister (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/398248 ) Change subject: Add messages for longer cache durations .. Add messages for longer cache durations If the max age is

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseQualityConstraints[master]: Fix typo in message documentation

2017-12-14 Thread Lucas Werkmeister (WMDE) (Code Review)
Lucas Werkmeister (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/398247 ) Change subject: Fix typo in message documentation .. Fix typo in message documentation Change-Id

[MediaWiki-commits] [Gerrit] mediawiki...Flow[master]: Remove unused access to (Special)CheckUser object

2017-12-14 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/398231 ) Change subject: Remove unused access to (Special)CheckUser object .. Remove unused access to (Special)CheckUser object This

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseQualityConstraints[master]: Use plaintextParams for language name + code

2017-12-13 Thread Lucas Werkmeister (WMDE) (Code Review)
Lucas Werkmeister (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/398083 ) Change subject: Use plaintextParams for language name + code .. Use plaintextParams for language name + code We don’t

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Render autocomment parameters as plain text

2017-12-13 Thread Lucas Werkmeister (WMDE) (Code Review)
Lucas Werkmeister (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/398081 ) Change subject: Render autocomment parameters as plain text .. Render autocomment parameters as plain text None of the

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseLexeme[master]: Update lastrevid after adding a new Form

2017-12-13 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/398070 ) Change subject: Update lastrevid after adding a new Form .. Update lastrevid after adding a new Form This is mostly a

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Teach wb.RevisionStore.js to deal with (sub-)entities

2017-12-13 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/398068 ) Change subject: Teach wb.RevisionStore.js to deal with (sub-)entities .. Teach wb.RevisionStore.js to deal with (sub-)entities

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseQualityConstraints[master]: WIP: read constraint check results from cache

2017-12-13 Thread Lucas Werkmeister (WMDE) (Code Review)
Lucas Werkmeister (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/398064 ) Change subject: WIP: read constraint check results from cache .. WIP: read constraint check results from cache Bug

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseQualityConstraints[master]: Remove unused StatementChangeOpFactory in CheckConstraints

2017-12-13 Thread Lucas Werkmeister (WMDE) (Code Review)
Lucas Werkmeister (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/398060 ) Change subject: Remove unused StatementChangeOpFactory in CheckConstraints .. Remove unused StatementChangeOpFactory in

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Fix documentation mistakes in EntityDiffChangedAspectsFactory

2017-12-12 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/397896 ) Change subject: Fix documentation mistakes in EntityDiffChangedAspectsFactory .. Fix documentation mistakes in

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseLexeme[master]: Fix Lexeme::getForm failing with an unchecked null pointer

2017-12-12 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/397888 ) Change subject: Fix Lexeme::getForm failing with an unchecked null pointer .. Fix Lexeme::getForm failing with an unchecked

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseLexeme[master]: Update the base revision after saving a form with a FormChanger

2017-12-12 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/397838 ) Change subject: Update the base revision after saving a form with a FormChanger .. Update the base revision after saving a form with a

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseLexeme[master]: [DNM] Use change op to add a form in AddForm API

2017-12-12 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/397854 ) Change subject: [DNM] Use change op to add a form in AddForm API .. [DNM] Use change op to add a form in AddForm API TODO: - getting

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseLexeme[master]: Return the revision ID after adding form with wblexemeaddfor...

2017-12-12 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/397837 ) Change subject: Return the revision ID after adding form with wblexemeaddform API .. Return the revision ID after adding form with

[MediaWiki-commits] [Gerrit] mediawiki...TwoColConflict[master]: Remove unicode browser check code

2017-12-12 Thread WMDE-Fisch (Code Review)
WMDE-Fisch has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/396321 ) Change subject: Remove unicode browser check code .. Remove unicode browser check code Change-Id

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseQuality[master]: Use MediaWiki PSR-4 autoloader

2017-12-12 Thread Lucas Werkmeister (WMDE) (Code Review)
Lucas Werkmeister (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/397767 ) Change subject: Use MediaWiki PSR-4 autoloader .. Use MediaWiki PSR-4 autoloader This removes the AutoloadClasses added

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseQualityConstraints[master]: Use MediaWiki PSR-4 autoloader

2017-12-12 Thread Lucas Werkmeister (WMDE) (Code Review)
Lucas Werkmeister (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/397763 ) Change subject: Use MediaWiki PSR-4 autoloader .. Use MediaWiki PSR-4 autoloader This mostly reverts commit 3ea9ad549e

[MediaWiki-commits] [Gerrit] mediawiki...TwoColConflict[master]: How often are new editors involved in edit conflicts

2017-12-12 Thread Andrew-WMDE (Code Review)
Andrew-WMDE has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/397762 ) Change subject: How often are new editors involved in edit conflicts .. How often are new editors involved in edit conflicts Bug

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseQualityConstraints[master]: Add tests for entity IDs in CachingMetadata

2017-12-11 Thread Lucas Werkmeister (WMDE) (Code Review)
Lucas Werkmeister (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/397598 ) Change subject: Add tests for entity IDs in CachingMetadata .. Add tests for entity IDs in CachingMetadata I should have

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseQualityConstraints[master]: Add and use CachingResultsBuilder

2017-12-11 Thread Lucas Werkmeister (WMDE) (Code Review)
Lucas Werkmeister (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/397594 ) Change subject: Add and use CachingResultsBuilder .. Add and use CachingResultsBuilder This ResultsBuilder implementation

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseQualityConstraints[master]: Fix capitalization of ID

2017-12-11 Thread Lucas Werkmeister (WMDE) (Code Review)
Lucas Werkmeister (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/397593 ) Change subject: Fix capitalization of ID .. Fix capitalization of ID In most of the codebase, ID is not fully capitalized

[MediaWiki-commits] [Gerrit] mediawiki...TwoColConflict[master]: [WIP] Let the user save the currently selected parts

2017-12-11 Thread WMDE-Fisch (Code Review)
WMDE-Fisch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/397591 ) Change subject: [WIP] Let the user save the currently selected parts .. [WIP] Let the user save the currently selected parts - block

[MediaWiki-commits] [Gerrit] mediawiki...TwoColConflict[master]: [WIP] Allow editing of text in the two columns

2017-12-11 Thread WMDE-Fisch (Code Review)
WMDE-Fisch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/397592 ) Change subject: [WIP] Allow editing of text in the two columns .. [WIP] Allow editing of text in the two columns - added textboxes

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Remove unused 'pool' param from WANObjectCache::newEmpty()

2017-12-11 Thread Lucas Werkmeister (WMDE) (Code Review)
Lucas Werkmeister (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/397578 ) Change subject: Remove unused 'pool' param from WANObjectCache::newEmpty() .. Remove unused 'p

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseLexeme[master]: Convert form ID format in the data stored in the database

2017-12-11 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/397556 ) Change subject: Convert form ID format in the data stored in the database .. Convert form ID format in the data stored in the database

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseQualityConstraints[master]: Add missing tracking namespace

2017-12-11 Thread Lucas Werkmeister (WMDE) (Code Review)
Lucas Werkmeister (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/397522 ) Change subject: Add missing tracking namespace .. Add missing tracking namespace All our tracking events need to happen

[MediaWiki-commits] [Gerrit] mediawiki...DataTypes[master]: Add read-only/discontinuation notice to README

2017-12-11 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/397466 ) Change subject: Add read-only/discontinuation notice to README .. Add read-only/discontinuation notice to README Change-Id

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseQualityConstraints[master]: Add and use CachedCheckConstraintsResponse

2017-12-08 Thread Lucas Werkmeister (WMDE) (Code Review)
Lucas Werkmeister (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/396408 ) Change subject: Add and use CachedCheckConstraintsResponse .. Add and use CachedCheckConstraintsResponse

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseLexeme[master]: Enable skipped SetClaimTest with Forms

2017-12-08 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/396401 ) Change subject: Enable skipped SetClaimTest with Forms .. Enable skipped SetClaimTest with Forms Bug: T163724 Bug: T180471

[MediaWiki-commits] [Gerrit] wikidata...gui[master]: [DNM] test

2017-12-08 Thread Jonas Kress (WMDE) (Code Review)
Jonas Kress (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/396382 ) Change subject: [DNM] test .. [DNM] test Change-Id: I6fcca1f6b860dfa5ce47acdf33d341e193eb5494 --- M package.json 1 file changed

[MediaWiki-commits] [Gerrit] wikidata...gui[master]: Add test for DownloadJS utf-8

2017-12-08 Thread Jonas Kress (WMDE) (Code Review)
Jonas Kress (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/396325 ) Change subject: Add test for DownloadJS utf-8 .. Add test for DownloadJS utf-8 Bug:T165228 Change-Id

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Split StatementGroupRendererFactoryTest::testNewRenderer_usa...

2017-12-08 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/396322 ) Change subject: Split StatementGroupRendererFactoryTest::testNewRenderer_usageTracking .. Split

[MediaWiki-commits] [Gerrit] mediawiki...TwoColConflict[master]: Remove unicode browser check code

2017-12-08 Thread WMDE-Fisch (Code Review)
WMDE-Fisch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/396321 ) Change subject: Remove unicode browser check code .. Remove unicode browser check code Change-Id

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseQualityConstraints[master]: Implicitly track property of constraint

2017-12-08 Thread Lucas Werkmeister (WMDE) (Code Review)
Lucas Werkmeister (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/396320 ) Change subject: Implicitly track property of constraint .. Implicitly track property of constraint For now, we also want

[MediaWiki-commits] [Gerrit] mediawiki...TwoColConflict[master]: [WIP] Add new layout to simulation page

2017-12-08 Thread WMDE-Fisch (Code Review)
WMDE-Fisch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/396317 ) Change subject: [WIP] Add new layout to simulation page .. [WIP] Add new layout to simulation page Change-Id

[MediaWiki-commits] [Gerrit] mediawiki...TwoColConflict[master]: Move random change methods to own class

2017-12-08 Thread WMDE-Fisch (Code Review)
WMDE-Fisch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/396316 ) Change subject: Move random change methods to own class .. Move random change methods to own class Change-Id

[MediaWiki-commits] [Gerrit] mediawiki...TwoColConflict[master]: Move LineBasedUnifiedDiffFormater back to includes

2017-12-08 Thread WMDE-Fisch (Code Review)
WMDE-Fisch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/396313 ) Change subject: Move LineBasedUnifiedDiffFormater back to includes .. Move LineBasedUnifiedDiffFormater back to includes This will be

[MediaWiki-commits] [Gerrit] mediawiki...TwoColConflict[master]: [WIP] First layout for the experimental edit conflict view

2017-12-08 Thread WMDE-Fisch (Code Review)
WMDE-Fisch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/396314 ) Change subject: [WIP] First layout for the experimental edit conflict view .. [WIP] First layout for the experimental edit conflict view

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Remove detail from wbcheckconstraints API response

2017-12-08 Thread Lucas Werkmeister (WMDE) (Code Review)
Lucas Werkmeister (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/396311 ) Change subject: Remove detail from wbcheckconstraints API response .. Remove detail from wbcheckconstraints API response

[MediaWiki-commits] [Gerrit] analytics...scripts[master]: Record metrics for Wikidata task priorities (via color)

2017-12-07 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/396065 ) Change subject: Record metrics for Wikidata task priorities (via color) .. Record metrics for Wikidata task priorities (via

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseQualityConstraints[master]: Implicitly track current entity

2017-12-07 Thread Lucas Werkmeister (WMDE) (Code Review)
Lucas Werkmeister (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/396063 ) Change subject: Implicitly track current entity .. Implicitly track current entity We always want to invalidate check

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseQualityConstraints[master]: Track entity IDs in CachingMetadata

2017-12-07 Thread Lucas Werkmeister (WMDE) (Code Review)
Lucas Werkmeister (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/396060 ) Change subject: Track entity IDs in CachingMetadata .. Track entity IDs in CachingMetadata Bug: T182104 Change-Id

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseQualityConstraints[master]: Align inverse and symmetric checkers with target required claim

2017-12-07 Thread Lucas Werkmeister (WMDE) (Code Review)
Lucas Werkmeister (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/396061 ) Change subject: Align inverse and symmetric checkers with target required claim .. Align inverse and symmetric checkers

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseQualityConstraints[master]: Track target entity of inverse/symmetric/target checkers

2017-12-07 Thread Lucas Werkmeister (WMDE) (Code Review)
Lucas Werkmeister (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/396062 ) Change subject: Track target entity of inverse/symmetric/target checkers .. Track target entity of inverse/symmetric

[MediaWiki-commits] [Gerrit] wikidata...gui[master]: Move QueryExampleDialog to dialog package

2017-12-07 Thread Jonas Kress (WMDE) (Code Review)
Jonas Kress (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/395986 ) Change subject: Move QueryExampleDialog to dialog package .. Move QueryExampleDialog to dialog package Change-Id

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseQualityConstraints[master]: Rename chainable setter to withCachingMetadata()

2017-12-06 Thread Lucas Werkmeister (WMDE) (Code Review)
Lucas Werkmeister (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/395789 ) Change subject: Rename chainable setter to withCachingMetadata() .. Rename chainable setter to withCachingMetadata

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Moved textbox1 building into TextConflictHelper on edit conf...

2017-12-06 Thread WMDE-Fisch (Code Review)
WMDE-Fisch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/395743 ) Change subject: Moved textbox1 building into TextConflictHelper on edit conflicts .. Moved textbox1 building into TextConflictHelper on

[MediaWiki-commits] [Gerrit] mediawiki...TwoColConflict[master]: Rename TwoColConlict class to InlineTwoColConflict

2017-12-06 Thread WMDE-Fisch (Code Review)
WMDE-Fisch has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/395726 ) Change subject: Rename TwoColConlict class to InlineTwoColConflict .. Rename TwoColConlict class to InlineTwoColConflict Since we start

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Point $wgExtensionCredits paths to files instead of directories

2017-12-06 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/395723 ) Change subject: Point $wgExtensionCredits paths to files instead of directories .. Point $wgExtensionCredits paths to files

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Allow $wgExtensionCredits "path" to be a path to a directory

2017-12-06 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/395721 ) Change subject: Allow $wgExtensionCredits "path" to be a path to a directory .. Allow $wgExtensionCredits "pat

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseQualityConstraints[master]: Add tests for WikibaseQualityConstraintsHooks::isConstraintS...

2017-12-05 Thread Lucas Werkmeister (WMDE) (Code Review)
Lucas Werkmeister (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/395590 ) Change subject: Add tests for WikibaseQualityConstraintsHooks::isConstraintStatementsChange .. Add tests for

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseQualityConstraints[master]: Rename WikibaseQualityConstraintsHooks function

2017-12-05 Thread Lucas Werkmeister (WMDE) (Code Review)
Lucas Werkmeister (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/395589 ) Change subject: Rename WikibaseQualityConstraintsHooks function .. Rename WikibaseQualityConstraintsHooks function It now

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Don't track title usage when {{#property:…}} doesn't link to...

2017-12-05 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/395582 ) Change subject: Don't track title usage when {{#property:…}} doesn't link to that title .. Don't track t

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseQualityConstraints[master]: Remove UnitTestsList hook

2017-12-05 Thread Lucas Werkmeister (WMDE) (Code Review)
Lucas Werkmeister (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/395576 ) Change subject: Remove UnitTestsList hook .. Remove UnitTestsList hook Since MediaWiki 1.28, tests in the extension

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Fix broken path in ExtensionCredits for Wikibase View

2017-12-05 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/395573 ) Change subject: Fix broken path in ExtensionCredits for Wikibase View .. Fix broken path in ExtensionCredits for Wikibase View

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Force a content language in SpecialListDatatypesTest

2017-12-05 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/395567 ) Change subject: Force a content language in SpecialListDatatypesTest .. Force a content language in SpecialListDatatypesTest Removing

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseQualityConstraints[master]: Add tests for CheckingResultsBuilder::getResults()

2017-12-05 Thread Lucas Werkmeister (WMDE) (Code Review)
Lucas Werkmeister (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/395559 ) Change subject: Add tests for CheckingResultsBuilder::getResults() .. Add tests for CheckingResultsBuilder::getResults

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseQualityConstraints[master]: Add tests for CheckingResultsBuilder::checkResultToArray()

2017-12-05 Thread Lucas Werkmeister (WMDE) (Code Review)
Lucas Werkmeister (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/395558 ) Change subject: Add tests for CheckingResultsBuilder::checkResultToArray() .. Add tests for CheckingResultsBuilder

[MediaWiki-commits] [Gerrit] mediawiki/vendor[master]: Remove data-values/data-types

2017-12-05 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/395518 ) Change subject: Remove data-values/data-types .. Remove data-values/data-types To be merged together with

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Move over files of Data View library (JS part)

2017-12-05 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/395516 ) Change subject: Move over files of Data View library (JS part) .. Move over files of Data View library (JS part) Bug: T180454 Change

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Catch uncatched SerializationException in EntityContent::get...

2017-12-05 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/395515 ) Change subject: Catch uncatched SerializationException in EntityContent::getNativeData .. Catch uncatched

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseQualityConstraints[master]: WIP: Add layer where constraint check results can be cached

2017-12-04 Thread Lucas Werkmeister (WMDE) (Code Review)
Lucas Werkmeister (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/395007 ) Change subject: WIP: Add layer where constraint check results can be cached .. WIP: Add layer where constraint check

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseQualityConstraints[master]: Remove leftover constructor argument in test

2017-12-04 Thread Lucas Werkmeister (WMDE) (Code Review)
Lucas Werkmeister (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/394991 ) Change subject: Remove leftover constructor argument in test .. Remove leftover constructor argument in test The $apiV2

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Skip AnalysisConfigBuilder tests when no CirrusSearch enabled

2017-12-04 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/394978 ) Change subject: Skip AnalysisConfigBuilder tests when no CirrusSearch enabled .. Skip AnalysisConfigBuilder tests when no CirrusSearch

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Never show edit section links in entity diffs

2017-12-04 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/394973 ) Change subject: Never show edit section links in entity diffs .. Never show edit section links in entity diffs Bug: T181807

[MediaWiki-commits] [Gerrit] mediawiki...AdvancedSearch[master]: Fix UI namespace selection on Monobook skin

2017-12-04 Thread Andrew-WMDE (Code Review)
Andrew-WMDE has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/394971 ) Change subject: Fix UI namespace selection on Monobook skin .. Fix UI namespace selection on Monobook skin Bug: T181134 Change-Id

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Skip fewer tests in ViewEntityActionTest

2017-12-04 Thread WMDE-leszek (Code Review)
WMDE-leszek has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/394970 ) Change subject: Skip fewer tests in ViewEntityActionTest .. Skip fewer tests in ViewEntityActionTest Change-Id

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Test for HTML anchors on Special:ListDatatypes

2017-12-04 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/394961 ) Change subject: Test for HTML anchors on Special:ListDatatypes .. Test for HTML anchors on Special:ListDatatypes Bug: T181371

[MediaWiki-commits] [Gerrit] wikidata...gui[master]: [WIP]Introduce QueryWizard

2017-12-01 Thread Jonas Kress (WMDE) (Code Review)
Jonas Kress (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/394583 ) Change subject: [WIP]Introduce QueryWizard .. [WIP]Introduce QueryWizard Query Wizard helps creating a query by asking

[MediaWiki-commits] [Gerrit] mediawiki...Vector[master]: Fix dysfunctional collapseCondition when right-most tab is t...

2017-11-30 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/394349 ) Change subject: Fix dysfunctional collapseCondition when right-most tab is the star .. Fix dysfunctional collapseCondition

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseLexeme[master]: Let FormSet::add replace existing Form instead of failing

2017-11-29 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/394138 ) Change subject: Let FormSet::add replace existing Form instead of failing .. Let FormSet::add replace existing Form instead of

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseLexeme[master]: Remove redundant Lexeme::removeForm

2017-11-29 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/394137 ) Change subject: Remove redundant Lexeme::removeForm .. Remove redundant Lexeme::removeForm Same as $lexeme->getFo

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseLexeme[master]: Rename Lexeme::addForm to addNewForm

2017-11-29 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/394136 ) Change subject: Rename Lexeme::addForm to addNewForm .. Rename Lexeme::addForm to addNewForm This reflects much better what

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseLexeme[master]: Decorate EntityStore and EntityRevisionLookup to support Forms

2017-11-29 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/394072 ) Change subject: Decorate EntityStore and EntityRevisionLookup to support Forms .. Decorate EntityStore and

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Fix typo in the word "strategie"

2017-11-29 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/394071 ) Change subject: Fix typo in the word "strategie" .. Fix typo in the word "strate

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Allow extensions to decorate EntityStore and EntityRevisionL...

2017-11-29 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/394070 ) Change subject: Allow extensions to decorate EntityStore and EntityRevisionLookup .. Allow extensions to decorate EntityStore

[MediaWiki-commits] [Gerrit] purtle[master]: Family name of Thiemo changed

2017-11-29 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/394049 ) Change subject: Family name of Thiemo changed .. Family name of Thiemo changed Change-Id

[MediaWiki-commits] [Gerrit] mediawiki...WikibaseLexeme[master]: Remove -webkit-… vendor prefix from SVG/PNG fallback hack

2017-11-29 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/394048 ) Change subject: Remove -webkit-… vendor prefix from SVG/PNG fallback hack .. Remove -webkit-… vendor prefix from SVG/PNG

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: Avoid using EntityDiffChangedAspectsFactory like a static co...

2017-11-29 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/394044 ) Change subject: Avoid using EntityDiffChangedAspectsFactory like a static constructor .. Avoid using

[MediaWiki-commits] [Gerrit] mediawiki...AdvancedSearch[master]: Use Array.isArray and RegExp.test instead

2017-11-29 Thread WMDE
Thiemo Mättig (WMDE) has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/394023 ) Change subject: Use Array.isArray and RegExp.test instead .. Use Array.isArray and RegExp.test instead * Array.isArray is

<    1   2   3   4   5   6   7   8   9   10   >