[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Hygiene: fix diff tests

2018-01-23 Thread BearND (Code Review)
BearND has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/406015 ) Change subject: Hygiene: fix diff tests .. Hygiene: fix diff tests mw-redirect classes were added to a few links. Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Hygiene: fix jsdoc in extractLeadIntroduction

2018-01-19 Thread BearND (Code Review)
BearND has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/405351 ) Change subject: Hygiene: fix jsdoc in extractLeadIntroduction .. Hygiene: fix jsdoc in extractLeadIntroduction Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Use underscore's implementation of escape

2018-01-19 Thread BearND (Code Review)
BearND has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/405350 ) Change subject: Use underscore's implementation of escape .. Use underscore's implementation of escape The underscore implementation

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: WIP: Get ready for Parsoid change of references wrappers

2018-01-19 Thread BearND (Code Review)
BearND has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/405317 ) Change subject: WIP: Get ready for Parsoid change of references wrappers .. WIP: Get ready for Parsoid change of references wrappers

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Hygiene: update unit tests: refs changed from span to sup

2018-01-18 Thread BearND (Code Review)
BearND has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/405243 ) Change subject: Hygiene: update unit tests: refs changed from span to sup .. Hygiene: update unit tests: refs changed from span to sup

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Hygiene: remove unused addSectionTags for the section case

2018-01-18 Thread BearND (Code Review)
BearND has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/405242 ) Change subject: Hygiene: remove unused addSectionTags for the section case .. Hygiene: remove unused addSectionTags for the section case

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Include H1 heading tags to old section parsing

2018-01-18 Thread BearND (Code Review)
BearND has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/405241 ) Change subject: Include H1 heading tags to old section parsing .. Include H1 heading tags to old section parsing While not encouraged,

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Dev: debug log for MW API requests when debug is true in config

2018-01-18 Thread BearND (Code Review)
BearND has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/405239 ) Change subject: Dev: debug log for MW API requests when debug is true in config .. Dev: debug log for MW API requests when debug is true in

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Dev: debug log for RESTBase requests, too

2018-01-18 Thread BearND (Code Review)
BearND has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/405240 ) Change subject: Dev: debug log for RESTBase requests, too .. Dev: debug log for RESTBase requests, too Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Hygiene: Update diff results for -wrapped references, p...

2018-01-18 Thread BearND (Code Review)
BearND has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/405234 ) Change subject: Hygiene: Update diff results for -wrapped references, part 2 .. Hygiene: Update diff results for -wrapped references, part

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Dev: Make sure we tag the correct commit in the src repo

2018-01-18 Thread BearND (Code Review)
BearND has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/405210 ) Change subject: Dev: Make sure we tag the correct commit in the src repo .. Dev: Make sure we tag the correct commit in the src repo Get

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Hygiene: fix api-util-test

2018-01-17 Thread BearND (Code Review)
BearND has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/404744 ) Change subject: Hygiene: fix api-util-test .. Hygiene: fix api-util-test Should not have reused the list between tests. Bug: T182738

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Hygiene: remove unnecessary PREQ_CONNECT_TIMEOUT for unit te...

2018-01-17 Thread BearND (Code Review)
BearND has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/404742 ) Change subject: Hygiene: remove unnecessary PREQ_CONNECT_TIMEOUT for unit test run .. Hygiene: remove unnecessary PREQ_CONNECT_TIMEOUT for

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Skip beta cluster test

2018-01-16 Thread BearND (Code Review)
BearND has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/404622 ) Change subject: Skip beta cluster test .. Skip beta cluster test Beta cluster API is having some issues: PHP fatal error: Stack overflow

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: summary: reorder summarizer transforms

2018-01-16 Thread BearND (Code Review)
BearND has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/404514 ) Change subject: summary: reorder summarizer transforms .. summary: reorder summarizer transforms Doing the regex manipulations first, then

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: summary: skip removing data-mw attributes

2018-01-16 Thread BearND (Code Review)
BearND has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/404515 ) Change subject: summary: skip removing data-mw attributes .. summary: skip removing data-mw attributes Skip removing data-mw attributes in

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: summary: fix mainpage handling

2018-01-16 Thread BearND (Code Review)
BearND has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/404510 ) Change subject: summary: fix mainpage handling .. summary: fix mainpage handling The issue was that several non-English main pages are not

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Hygiene: extract method for when to return 204

2018-01-16 Thread BearND (Code Review)
BearND has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/404509 ) Change subject: Hygiene: extract method for when to return 204 .. Hygiene: extract method for when to return 204 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Also keep style attributes when flattening elements

2018-01-16 Thread BearND (Code Review)
BearND has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/404496 ) Change subject: Also keep style attributes when flattening elements .. Also keep style attributes when flattening elements See comment

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Hygiene: move summary library functions to own lib file

2018-01-14 Thread BearND (Code Review)
BearND has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/404245 ) Change subject: Hygiene: move summary library functions to own lib file .. Hygiene: move summary library functions to own lib file There

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: summary: inline 204 checks

2018-01-14 Thread BearND (Code Review)
BearND has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/404248 ) Change subject: summary: inline 204 checks .. summary: inline 204 checks The three checks for when to return 204 are simple enough that we

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: summary: just parse the lead section

2018-01-14 Thread BearND (Code Review)
BearND has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/404247 ) Change subject: summary: just parse the lead section .. summary: just parse the lead section No need to try to parse other sections for the

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Initial streamlining getting the summary HTML

2018-01-14 Thread BearND (Code Review)
BearND has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/404246 ) Change subject: Initial streamlining getting the summary HTML .. Initial streamlining getting the summary HTML * Replace pageJsonPromise

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Hygiene: remove extraneous disambig code

2018-01-14 Thread BearND (Code Review)
BearND has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/404242 ) Change subject: Hygiene: remove extraneous disambig code .. Hygiene: remove extraneous disambig code The disambig flag gets determined

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Hygiene: move summary route to own file

2018-01-14 Thread BearND (Code Review)
BearND has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/404244 ) Change subject: Hygiene: move summary route to own file .. Hygiene: move summary route to own file Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Hygiene: inline the summary call to _collectRawPageData

2018-01-14 Thread BearND (Code Review)
BearND has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/404243 ) Change subject: Hygiene: inline the summary call to _collectRawPageData .. Hygiene: inline the summary call to _collectRawPageData This

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Hygiene: add more summary tests

2018-01-14 Thread BearND (Code Review)
BearND has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/404241 ) Change subject: Hygiene: add more summary tests .. Hygiene: add more summary tests Change-Id: I245cb3b3715cb67b7c589f42079f34203c25d32d ---

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Flatten DOM anchors if no attributes kept

2018-01-12 Thread BearND (Code Review)
BearND has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/403977 ) Change subject: Flatten DOM anchors if no attributes kept .. Flatten DOM anchors if no attributes kept The flattenElements method

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Summary: flattened anchors stay anchors

2018-01-11 Thread BearND (Code Review)
BearND has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/403882 ) Change subject: Summary: flattened anchors stay anchors .. Summary: flattened anchors stay anchors We can remove the flattenElements call

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Summary: update regex for non-ASCII parentheses

2018-01-11 Thread BearND (Code Review)
BearND has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/403880 ) Change subject: Summary: update regex for non-ASCII parentheses .. Summary: update regex for non-ASCII parentheses The previous version

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Summary: update regex for finding parentheticals

2018-01-11 Thread BearND (Code Review)
BearND has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/403881 ) Change subject: Summary: update regex for finding parentheticals .. Summary: update regex for finding parentheticals For the latin

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Fix another lint issue

2018-01-11 Thread BearND (Code Review)
BearND has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/403770 ) Change subject: Fix another lint issue .. Fix another lint issue I ran into these when trying to commit my patches. I run the pre-commit

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: WIP: Remove parentheses using state machine instead of regex

2018-01-11 Thread BearND (Code Review)
BearND has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/403725 ) Change subject: WIP: Remove parentheses using state machine instead of regex .. WIP: Remove parentheses using state machine instead of regex

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Fix lint issues

2018-01-10 Thread BearND (Code Review)
BearND has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/403578 ) Change subject: Fix lint issues .. Fix lint issues Change-Id: I5dbf10b3479856a9e35d2fa32895373f63b577f4 --- M

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Remove unwanted nodes and attributes from summary

2018-01-10 Thread BearND (Code Review)
BearND has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/403568 ) Change subject: Remove unwanted nodes and attributes from summary .. Remove unwanted nodes and attributes from summary Bug: T184557

[MediaWiki-commits] [Gerrit] mediawiki...deploy[master]: Update mobileapps to d20915c

2018-01-08 Thread BearND (Code Review)
BearND has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/402984 ) Change subject: Update mobileapps to d20915c .. Update mobileapps to d20915c List of changes: 94845db Show MW API requests when debug is

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Add revision and tid to references output

2018-01-08 Thread BearND (Code Review)
BearND has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/402914 ) Change subject: Add revision and tid to references output .. Add revision and tid to references output Bug: T184328 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Hygiene: extract references endpoint into new module

2018-01-08 Thread BearND (Code Review)
BearND has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/402913 ) Change subject: Hygiene: extract references endpoint into new module .. Hygiene: extract references endpoint into new module Also

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Show MW API requests when env var DEBUG_MW_REQUESTS is set

2018-01-08 Thread BearND (Code Review)
BearND has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/402891 ) Change subject: Show MW API requests when env var DEBUG_MW_REQUESTS is set .. Show MW API requests when env var DEBUG_MW_REQUESTS is set

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Show MW API requests when debug is true

2018-01-04 Thread BearND (Code Review)
BearND has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/402129 ) Change subject: Show MW API requests when debug is true .. Show MW API requests when debug is true To make it easier to debug backend

[MediaWiki-commits] [Gerrit] mediawiki...deploy[master]: Update mobileapps to a4ba9fd

2018-01-04 Thread BearND (Code Review)
BearND has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/402096 ) Change subject: Update mobileapps to a4ba9fd .. Update mobileapps to a4ba9fd List of changes: 29fd37f References: add specific version

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: News: don't include empty stories

2018-01-04 Thread BearND (Code Review)
BearND has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/402083 ) Change subject: News: don't include empty stories .. News: don't include empty stories Bug: T184198 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Temporarily skip testing of French news.

2018-01-04 Thread BearND (Code Review)
BearND has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/402077 ) Change subject: Temporarily skip testing of French news. .. Temporarily skip testing of French news. Will add a separate patch to fix

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: random: fail early when MW API response has no query.pages

2018-01-04 Thread BearND (Code Review)
BearND has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/402074 ) Change subject: random: fail early when MW API response has no query.pages .. random: fail early when MW API response has no query.pages

[MediaWiki-commits] [Gerrit] mediawiki...deploy[master]: Update mobileapps to ff74bb1

2017-12-14 Thread BearND (Code Review)
BearND has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/398304 ) Change subject: Update mobileapps to ff74bb1 .. Update mobileapps to ff74bb1 List of changes: 96eab05 Revert "Revert "Update section

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Bump onthisday version

2017-12-14 Thread BearND (Code Review)
BearND has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/398300 ) Change subject: Bump onthisday version .. Bump onthisday version ... since we fixed the section heading id selector strings, see previous

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Fix onthisday entries from day pages

2017-12-14 Thread BearND (Code Review)
BearND has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/398268 ) Change subject: Fix onthisday entries from day pages .. Fix onthisday entries from day pages Since HTML5 section ids were deployed,

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Automatically end announcements after configured endTime

2017-12-14 Thread BearND (Code Review)
BearND has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/398254 ) Change subject: Automatically end announcements after configured endTime .. Automatically end announcements after configured endTime No

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Add unit test for logging the warning if section validation ...

2017-12-13 Thread BearND (Code Review)
BearND has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/398184 ) Change subject: Add unit test for logging the warning if section validation fails .. Add unit test for logging the warning if section

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Revert "Revert "Update section validation logic""

2017-12-13 Thread BearND (Code Review)
Hello jenkins-bot, Mholloway, I'd like you to do a code review. Please visit https://gerrit.wikimedia.org/r/398183 to review the following change. Change subject: Revert "Revert "Update section validation logic"" ..

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Skip some tests because of upstream issues

2017-12-13 Thread BearND (Code Review)
BearND has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/398085 ) Change subject: Skip some tests because of upstream issues .. Skip some tests because of upstream issues This is related to T182770.

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Adjust end time for fundraising announcements

2017-12-13 Thread BearND (Code Review)
BearND has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/398080 ) Change subject: Adjust end time for fundraising announcements .. Adjust end time for fundraising announcements New end date it is December

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Bump onthisday version.

2017-12-12 Thread BearND (Code Review)
BearND has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/397961 ) Change subject: Bump onthisday version. .. Bump onthisday version. Change-Id: I15a3dbb1337d56291a0e2bb85f2c043afe51 --- M

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Fix onthisday with section tags

2017-12-12 Thread BearND (Code Review)
BearND has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/397928 ) Change subject: Fix onthisday with section tags .. Fix onthisday with section tags Onthisday was looking for direct children of body to

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: References: citation type

2017-12-12 Thread BearND (Code Review)
BearND has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/397867 ) Change subject: References: citation type .. References: citation type Instead of an citations array we return a single value in the type

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: References: back_link as object

2017-12-11 Thread BearND (Code Review)
BearND has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/397737 ) Change subject: References: back_link as object .. References: back_link as object Instead of a single string a backlink is now an object

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: References: add specific version number

2017-12-11 Thread BearND (Code Review)
BearND has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/397640 ) Change subject: References: add specific version number .. References: add specific version number This will be part of PCS. Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Bump mobile-sections and definitions version

2017-12-11 Thread BearND (Code Review)
BearND has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/397633 ) Change subject: Bump mobile-sections and definitions version .. Bump mobile-sections and definitions version to hopefully follow shortly

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: WIP: Dev: Replace Sepia with Replayer

2017-12-08 Thread BearND (Code Review)
BearND has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/396428 ) Change subject: WIP: Dev: Replace Sepia with Replayer .. WIP: Dev: Replace Sepia with Replayer Unfortunately the Sepia project seems

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Bring back Sepia request caching

2017-12-07 Thread BearND (Code Review)
BearND has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/396297 ) Change subject: Bring back Sepia request caching .. Bring back Sepia request caching The key is to require sepia. This line got somehow

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Version number for the media endpoint

2017-12-06 Thread BearND (Code Review)
BearND has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/395849 ) Change subject: Version number for the media endpoint .. Version number for the media endpoint Bug: T177430 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: tag-deploy: push only the created tag

2017-11-30 Thread BearND (Code Review)
BearND has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/394522 ) Change subject: tag-deploy: push only the created tag .. tag-deploy: push only the created tag git push --tags would push any local tags

[MediaWiki-commits] [Gerrit] mediawiki...deploy[master]: Update mobileapps to 4317ea5

2017-11-30 Thread BearND (Code Review)
BearND has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/394479 ) Change subject: Update mobileapps to 4317ea5 .. Update mobileapps to 4317ea5 List of changes: dad2788 Add figure-inline transformation

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Add figure-inline transformation

2017-11-29 Thread BearND (Code Review)
BearND has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/394243 ) Change subject: Add figure-inline transformation .. Add figure-inline transformation Parsoid is going to change some img wrapper DOM

[MediaWiki-commits] [Gerrit] mediawiki...deploy[master]: Update mobileapps to dcea7d3

2017-11-29 Thread BearND (Code Review)
BearND has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/394227 ) Change subject: Update mobileapps to dcea7d3 .. Update mobileapps to dcea7d3 List of changes: e5b73f3 Add .nsprc and update

[MediaWiki-commits] [Gerrit] mediawiki...deploy[master]: Update mobileapps to dcea7d3

2017-11-29 Thread BearND (Code Review)
BearND has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/394227 ) Change subject: Update mobileapps to dcea7d3 .. Update mobileapps to dcea7d3 List of changes: e5b73f3 Add .nsprc and update dependencies to

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Tweak Big English fundraiser copy and start time again

2017-11-29 Thread BearND (Code Review)
BearND has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/394205 ) Change subject: Tweak Big English fundraiser copy and start time again .. Tweak Big English fundraiser copy and start time again Updated

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Tweak Big English fundraiser copy some more

2017-11-29 Thread BearND (Code Review)
BearND has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/394152 ) Change subject: Tweak Big English fundraiser copy some more .. Tweak Big English fundraiser copy some more Removed the extra "Privacy

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Tweak Big English fundraiser copy

2017-11-29 Thread BearND (Code Review)
BearND has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/394107 ) Change subject: Tweak Big English fundraiser copy .. Tweak Big English fundraiser copy Now with double the line breaks and updated button

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Big English fundraiser announcements

2017-11-29 Thread BearND (Code Review)
BearND has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/394013 ) Change subject: Big English fundraiser announcements .. Big English fundraiser announcements For the Big English fundraiser we need to have

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: featured-image: better diagnostics in error case

2017-11-13 Thread BearND (Code Review)
BearND has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/391157 ) Change subject: featured-image: better diagnostics in error case .. featured-image: better diagnostics in error case We don't want to have

[MediaWiki-commits] [Gerrit] mediawiki...trending-edits[master]: Hygiene: update simple node dependencies

2017-11-10 Thread BearND (Code Review)
BearND has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/390545 ) Change subject: Hygiene: update simple node dependencies .. Hygiene: update simple node dependencies This is more to document the node

[MediaWiki-commits] [Gerrit] mediawiki...trending-edits[master]: Update node-rdkafka dependency to 1.x

2017-11-10 Thread BearND (Code Review)
BearND has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/390544 ) Change subject: Update node-rdkafka dependency to 1.x .. Update node-rdkafka dependency to 1.x Bug: T179786 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...trending-edits[master]: Update node-rdkafka dependency to 2.x

2017-11-10 Thread BearND (Code Review)
BearND has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/390546 ) Change subject: Update node-rdkafka dependency to 2.x .. Update node-rdkafka dependency to 2.x Breaking Changes mentioned for 2.0.0

[MediaWiki-commits] [Gerrit] mediawiki...deploy[master]: Update mobileapps to 8e82983

2017-11-08 Thread BearND (Code Review)
BearND has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/390096 ) Change subject: Update mobileapps to 8e82983 .. Update mobileapps to 8e82983 List of changes: ad0b15a Exclude properties only needed for

[MediaWiki-commits] [Gerrit] mediawiki...deploy[master]: Update mobileapps to e86fb6c

2017-11-08 Thread BearND (Code Review)
BearND has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/390068 ) Change subject: Update mobileapps to e86fb6c .. Update mobileapps to e86fb6c List of changes: 0492af8 Remove unnecessary API call in unit

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Revert "Add canonical title to mobile-sections lead"

2017-11-08 Thread BearND (Code Review)
Hello Mobrovac, GWicke, Fjalapeno, Ppchelko, Mhurd, jenkins-bot, Jdlrobson, Mholloway, I'd like you to do a code review. Please visit https://gerrit.wikimedia.org/r/390047 to review the following change. Change subject: Revert "Add canonical title to mobile-sections lead"

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Hygiene: preserve response objects throughout special handling

2017-11-06 Thread BearND (Code Review)
BearND has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/389643 ) Change subject: Hygiene: preserve response objects throughout special handling .. Hygiene: preserve response objects throughout special

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Add canonical title to mobile-sections lead

2017-11-06 Thread BearND (Code Review)
BearND has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/389644 ) Change subject: Add canonical title to mobile-sections lead .. Add canonical title to mobile-sections lead Bug: T179600 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Hygiene: replace data-section-number with data-mw-section-id

2017-11-01 Thread BearND (Code Review)
BearND has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/387828 ) Change subject: Hygiene: replace data-section-number with data-mw-section-id .. Hygiene: replace data-section-number with data-mw-section-id

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Improve Parsoid section detection

2017-10-30 Thread BearND (Code Review)
BearND has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/387295 ) Change subject: Improve Parsoid section detection .. Improve Parsoid section detection Replaces individual implementations with a common

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Hygiene: rename parsoid-sections-test

2017-10-30 Thread BearND (Code Review)
BearND has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/387294 ) Change subject: Hygiene: rename parsoid-sections-test .. Hygiene: rename parsoid-sections-test Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Next gen definitions parsing, using section tags

2017-10-24 Thread BearND (Code Review)
BearND has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/386336 ) Change subject: Next gen definitions parsing, using section tags .. Next gen definitions parsing, using section tags Prep definitions

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Hygiene: rename parseDefinitions to parseDefinitionsUsingDivs

2017-10-24 Thread BearND (Code Review)
BearND has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/386334 ) Change subject: Hygiene: rename parseDefinitions to parseDefinitionsUsingDivs .. Hygiene: rename parseDefinitions to

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Hygiene: split up definitions parsing into two implementations

2017-10-24 Thread BearND (Code Review)
BearND has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/386335 ) Change subject: Hygiene: split up definitions parsing into two implementations .. Hygiene: split up definitions parsing into two

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Revert "Add fundraising test via announcement cards in France"

2017-10-24 Thread BearND (Code Review)
BearND has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/386268 ) Change subject: Revert "Add fundraising test via announcement cards in France" .. Revert "Add fundraising test via announcement cards in

[MediaWiki-commits] [Gerrit] mediawiki...deploy[master]: Update mobileapps to 3628105

2017-10-23 Thread BearND (Code Review)
BearND has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/386045 ) Change subject: Update mobileapps to 3628105 .. Update mobileapps to 3628105 List of changes: c330b3f Summary 2.0: Introduce namespace

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Rewrite sectioning using section tags code

2017-10-20 Thread BearND (Code Review)
BearND has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/385425 ) Change subject: Rewrite sectioning using section tags code .. Rewrite sectioning using section tags code For mobile-sections we only care

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Fail incomplete sections early

2017-10-20 Thread BearND (Code Review)
BearND has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/385424 ) Change subject: Fail incomplete sections early .. Fail incomplete sections early To avoid issues with incomplete sections, which let to

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Get section number from Parsoid

2017-10-20 Thread BearND (Code Review)
BearND has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/385422 ) Change subject: Get section number from Parsoid .. Get section number from Parsoid * Get section number from Parsoid's section element

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Hygiene: add tests for new Parsoid section elements

2017-10-20 Thread BearND (Code Review)
BearND has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/385423 ) Change subject: Hygiene: add tests for new Parsoid section elements .. Hygiene: add tests for new Parsoid section elements To prepare for

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Hygiene: create script to compare old and new sectioning code

2017-10-20 Thread BearND (Code Review)
BearND has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/385420 ) Change subject: Hygiene: create script to compare old and new sectioning code .. Hygiene: create script to compare old and new sectioning

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Hygiene: add tmp folder to eslintignore

2017-10-20 Thread BearND (Code Review)
BearND has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/385419 ) Change subject: Hygiene: add tmp folder to eslintignore .. Hygiene: add tmp folder to eslintignore Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...deploy[master]: Update mobileapps to c045afc

2017-10-11 Thread BearND (Code Review)
BearND has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/383648 ) Change subject: Update mobileapps to c045afc .. Update mobileapps to c045afc List of changes: 6b7a264 Account for instead of for inline

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Hygiene: simplify assert.closeTo and assert.contains

2017-10-06 Thread BearND (Code Review)
BearND has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/382875 ) Change subject: Hygiene: simplify assert.closeTo and assert.contains .. Hygiene: simplify assert.closeTo and assert.contains This is to

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Hygiene: simplify assertions in onthisday test

2017-10-06 Thread BearND (Code Review)
BearND has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/382876 ) Change subject: Hygiene: simplify assertions in onthisday test .. Hygiene: simplify assertions in onthisday test This is to make failure

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Hygiene: Update test fixtures

2017-10-06 Thread BearND (Code Review)
BearND has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/382878 ) Change subject: Hygiene: Update test fixtures .. Hygiene: Update test fixtures This is for news, onthisday, and a general test page. This

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Fix Portuguese news selector

2017-10-06 Thread BearND (Code Review)
BearND has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/382877 ) Change subject: Fix Portuguese news selector .. Fix Portuguese news selector The old version of the CSS selector for ptwiki news stories

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Hygiene: update diff test results

2017-10-05 Thread BearND (Code Review)
BearND has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/382628 ) Change subject: Hygiene: update diff test results .. Hygiene: update diff test results The Frankenstein test page has been protected.

[MediaWiki-commits] [Gerrit] mediawiki...deploy[master]: Update mobileapps to 5dc0c02

2017-10-03 Thread BearND (Code Review)
BearND has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/382073 ) Change subject: Update mobileapps to 5dc0c02 .. Update mobileapps to 5dc0c02 List of changes: 7139e27 Add featured feed In the news entry

  1   2   3   4   5   6   7   8   9   10   >