[MediaWiki-commits] [Gerrit] Flip edit icon in RTL - change (apps...wikipedia)

2014-04-17 Thread Brion VIBBER (Code Review)
Brion VIBBER has uploaded a new change for review. https://gerrit.wikimedia.org/r/127155 Change subject: Flip edit icon in RTL .. Flip edit icon in RTL Change-Id: Icc47adeda16b5f19a0e71afe86da942ccd1d7688 --- M

[MediaWiki-commits] [Gerrit] Fix crashes when only one section is in a page - change (apps...wikipedia)

2014-04-17 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Fix crashes when only one section is in a page .. Fix crashes when only one section is in a page Change-Id: I39061dd77862799cf1c16ca09b8235b2510e29dd

[MediaWiki-commits] [Gerrit] Small style adjustment. - change (apps...wikipedia)

2014-04-17 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Small style adjustment. .. Small style adjustment. To better sync w mobile web styling. Per Vibha and Katie. More tweaks soon. Change-Id:

[MediaWiki-commits] [Gerrit] Fix for bottom zero alert to play nice with TOC. - change (apps...wikipedia)

2014-04-17 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Fix for bottom zero alert to play nice with TOC. .. Fix for bottom zero alert to play nice with TOC. The bottom zero alert wan't fading out properly

[MediaWiki-commits] [Gerrit] Structure User-Agent similarly to Android app reboot. - change (apps...wikipedia)

2014-04-17 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Structure User-Agent similarly to Android app reboot. .. Structure User-Agent similarly to Android app reboot. * See

[MediaWiki-commits] [Gerrit] Further style tweaks. - change (apps...wikipedia)

2014-04-17 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Further style tweaks. .. Further style tweaks. From Vibha. Change-Id: I29d572d3d8335368bc1cd9e70b2ae53b4236014a --- M wikipedia/assets/styles.css M

[MediaWiki-commits] [Gerrit] Flip edit icon in RTL - change (apps...wikipedia)

2014-04-21 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Flip edit icon in RTL .. Flip edit icon in RTL Change-Id: Icc47adeda16b5f19a0e71afe86da942ccd1d7688 --- M wikipedia/assets/styles.css M

[MediaWiki-commits] [Gerrit] Make sure that captcha is not hidden by preview window - change (apps...wikipedia)

2014-04-21 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Make sure that captcha is not hidden by preview window .. Make sure that captcha is not hidden by preview window Change-Id:

[MediaWiki-commits] [Gerrit] Don't ask to log in more than once - change (apps...wikipedia)

2014-04-21 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Don't ask to log in more than once .. Don't ask to log in more than once Is annoying. Change-Id: Ic3989cf79ac7daea84ee8f1a47737dd2d3ba4ecf --- M

[MediaWiki-commits] [Gerrit] Add EventLogging for Edit Funnel - change (apps...wikipedia)

2014-04-21 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Add EventLogging for Edit Funnel .. Add EventLogging for Edit Funnel - Fix EL to actually work - Send UA properly Change-Id:

[MediaWiki-commits] [Gerrit] Add event logging for reading actions - change (apps...wikipedia)

2014-04-21 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Add event logging for reading actions .. Add event logging for reading actions Change-Id: Ie1c322fb2c32001807f4a538e094aaa774cc571d --- A

[MediaWiki-commits] [Gerrit] Add EL for login funnel - change (apps...wikipedia)

2014-04-21 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Add EL for login funnel .. Add EL for login funnel Change-Id: I9b1978e16fc91e17d84354b1017e7c8cc3bef968 --- M

[MediaWiki-commits] [Gerrit] Make log out log out user only from this device - change (apps...wikipedia)

2014-04-21 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Make log out log out user only from this device .. Make log out log out user only from this device API calls to action=logout logs you out from *all*

[MediaWiki-commits] [Gerrit] Switch to prod URL for remote config - change (apps...wikipedia)

2014-04-21 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Switch to prod URL for remote config .. Switch to prod URL for remote config Change-Id: Ide81f96bfd1e70a253a30ad0ac4defe5aab3b15e --- M

[MediaWiki-commits] [Gerrit] Variety of small UX/Design tweaks. - change (apps...wikipedia)

2014-04-21 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Variety of small UX/Design tweaks. .. Variety of small UX/Design tweaks. Search field's clear x button larger. Search field reverts to Search Wikipedia

[MediaWiki-commits] [Gerrit] First pass at credits page. - change (apps...wikipedia)

2014-04-21 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: First pass at credits page. .. First pass at credits page. Temporary menu entry and icon at bottom of main menu. Tapping on items loads respective urls

[MediaWiki-commits] [Gerrit] Add 'Log Out' functionality - change (apps...wikipedia)

2014-02-12 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Add 'Log Out' functionality .. Add 'Log Out' functionality Also stores username and password in SharedPreferences. Change-Id:

[MediaWiki-commits] [Gerrit] Handle back button properly when no more pages are left - change (apps...wikipedia)

2014-02-12 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Handle back button properly when no more pages are left .. Handle back button properly when no more pages are left Change-Id:

[MediaWiki-commits] [Gerrit] Make 'Done' perform login action - change (apps...wikipedia)

2014-02-12 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Make 'Done' perform login action .. Make 'Done' perform login action Bug: 61261 Change-Id: I461696aeddef1e717c3e831b3879c804bdba0a93 --- M

[MediaWiki-commits] [Gerrit] Fix cookie handling to support .wikipedia.org cookies - change (apps...wikipedia)

2014-02-12 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Fix cookie handling to support .wikipedia.org cookies .. Fix cookie handling to support .wikipedia.org cookies This makes centralauth work - you can

[MediaWiki-commits] [Gerrit] Add descriptions for Wikipedia mobile iOS components - change (mediawiki...Translate)

2014-02-12 Thread Brion VIBBER (Code Review)
Brion VIBBER has uploaded a new change for review. https://gerrit.wikimedia.org/r/112906 Change subject: Add descriptions for Wikipedia mobile iOS components .. Add descriptions for Wikipedia mobile iOS components Change-Id:

[MediaWiki-commits] [Gerrit] Fix compilation errors due to sig change - change (apps...wikipedia)

2014-02-12 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Fix compilation errors due to sig change .. Fix compilation errors due to sig change Change-Id: Ic05a84d4996adbcd18f590f95fefebcc38cf02b0 --- M

[MediaWiki-commits] [Gerrit] Display actions properly in Edit Window - change (apps...wikipedia)

2014-02-12 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Display actions properly in Edit Window .. Display actions properly in Edit Window Change-Id: Ib01b0a850ee4f8984f43a0b70ac9c3136c78c8bf --- M

[MediaWiki-commits] [Gerrit] Work in progress: set .svg and .ico files to be compressed o... - change (operations/puppet)

2014-02-16 Thread Brion VIBBER (Code Review)
Brion VIBBER has uploaded a new change for review. https://gerrit.wikimedia.org/r/113687 Change subject: Work in progress: set .svg and .ico files to be compressed on bits.wikimedia.org .. Work in progress: set .svg and .ico

[MediaWiki-commits] [Gerrit] Add $wgMFCollapseSectionsByDefault config var to allow disab... - change (mediawiki...MobileFrontend)

2014-02-16 Thread Brion VIBBER (Code Review)
Brion VIBBER has uploaded a new change for review. https://gerrit.wikimedia.org/r/113758 Change subject: Add $wgMFCollapseSectionsByDefault config var to allow disabling auto section collapse .. Add

[MediaWiki-commits] [Gerrit] Do not keep re-creating fragments when we rotate phone - change (apps...wikipedia)

2014-02-18 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Do not keep re-creating fragments when we rotate phone .. Do not keep re-creating fragments when we rotate phone Change-Id:

[MediaWiki-commits] [Gerrit] Clear anon tokens (if any) once you log in - change (apps...wikipedia)

2014-02-18 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Clear anon tokens (if any) once you log in .. Clear anon tokens (if any) once you log in Change-Id: I0c90a7f50018f863fe1c793d7ca9cc51803700ff --- M

[MediaWiki-commits] [Gerrit] Fix crashes with NavDrawer when running in Strict Mode - change (apps...wikipedia)

2014-02-18 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Fix crashes with NavDrawer when running in Strict Mode .. Fix crashes with NavDrawer when running in Strict Mode Change-Id:

[MediaWiki-commits] [Gerrit] Re-login if session cookies have expired - change (apps...wikipedia)

2014-02-18 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Re-login if session cookies have expired .. Re-login if session cookies have expired Change-Id: I45649e5a0af172d4aa9f7187044d92b3f706a9cb --- M

[MediaWiki-commits] [Gerrit] Hide keyboard when login screen exits - change (apps...wikipedia)

2014-02-18 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Hide keyboard when login screen exits .. Hide keyboard when login screen exits In a sane system there must exist another way of doing this. I hope

[MediaWiki-commits] [Gerrit] Do not crash when user has changed password - change (apps...wikipedia)

2014-02-18 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Do not crash when user has changed password .. Do not crash when user has changed password Change-Id: Ieeb10f0e6d053d8e0187c90a61e4de9023c4c36c --- M

[MediaWiki-commits] [Gerrit] Hide keyboard when edit activity exits - change (apps...wikipedia)

2014-02-18 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Hide keyboard when edit activity exits .. Hide keyboard when edit activity exits Bug: 61326 Change-Id: I72b02772181688f52cea266a4a37c18792f4b637 --- M

[MediaWiki-commits] [Gerrit] Display message when no saved pages exist - change (apps...wikipedia)

2014-02-18 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Display message when no saved pages exist .. Display message when no saved pages exist Bug: 60708 Change-Id: Ib64bd23c84c7a840838472ac408a95143d7dbb1a

[MediaWiki-commits] [Gerrit] Show a message when no items are present in History - change (apps...wikipedia)

2014-02-18 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Show a message when no items are present in History .. Show a message when no items are present in History Change-Id:

[MediaWiki-commits] [Gerrit] Hide search results when emptied - change (apps...wikipedia)

2014-02-18 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Hide search results when emptied .. Hide search results when emptied Bug: 60711 Change-Id: I863b5a25c7041df68f6d02c1db16bc5c426f1c55 --- M

[MediaWiki-commits] [Gerrit] Ignore two placeholder messages in wikimedia wikipedia ios app - change (translatewiki)

2014-02-18 Thread Brion VIBBER (Code Review)
Brion VIBBER has uploaded a new change for review. https://gerrit.wikimedia.org/r/113990 Change subject: Ignore two placeholder messages in wikimedia wikipedia ios app .. Ignore two placeholder messages in wikimedia wikipedia

[MediaWiki-commits] [Gerrit] Fix exporting issue in AppleFFS - change (mediawiki...Translate)

2014-02-18 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Fix exporting issue in AppleFFS .. Fix exporting issue in AppleFFS Change-Id: I7de4d6f181424d8a47e82585e286db9fa4799e2d --- M ffs/AppleFFS.php 1 file

[MediaWiki-commits] [Gerrit] Add basic Wikipedia Zero support for iOS. - change (apps...wikipedia)

2014-02-18 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Add basic Wikipedia Zero support for iOS. .. Add basic Wikipedia Zero support for iOS. * Ready for review. ** Once toast/alert approach app-wide is

[MediaWiki-commits] [Gerrit] When editing captcha is visible, editing window is now prope... - change (apps...wikipedia)

2014-02-18 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: When editing captcha is visible, editing window is now properly hidden. .. When editing captcha is visible, editing window is now properly hidden. When

[MediaWiki-commits] [Gerrit] Update some structure of Wikipedia Zero code in iOS app. - change (apps...wikipedia)

2014-02-18 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Update some structure of Wikipedia Zero code in iOS app. .. Update some structure of Wikipedia Zero code in iOS app. * Follow up from

[MediaWiki-commits] [Gerrit] Shorten variable name to use #define. - change (apps...wikipedia)

2014-02-19 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Shorten variable name to use #define. .. Shorten variable name to use #define. Change-Id: I89d233274180b2989d836655ad753d56bad96733 --- M

[MediaWiki-commits] [Gerrit] Add new language files to project - change (apps...wikipedia)

2014-02-19 Thread Brion VIBBER (Code Review)
Brion VIBBER has uploaded a new change for review. https://gerrit.wikimedia.org/r/114177 Change subject: Add new language files to project .. Add new language files to project Change-Id:

[MediaWiki-commits] [Gerrit] Add new language files to project - change (apps...wikipedia)

2014-02-19 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Add new language files to project .. Add new language files to project Change-Id: If33cc5534c07f250cb02641f595438080f785a7d --- M

[MediaWiki-commits] [Gerrit] Enable lower-res .ogv transcodes for fallback player on slow... - change (operations/mediawiki-config)

2014-02-20 Thread Brion VIBBER (Code Review)
Brion VIBBER has uploaded a new change for review. https://gerrit.wikimedia.org/r/114507 Change subject: Enable lower-res .ogv transcodes for fallback player on slow machines .. Enable lower-res .ogv transcodes for fallback

[MediaWiki-commits] [Gerrit] Add stub Create Account activity - change (apps...wikipedia)

2014-02-20 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Add stub Create Account activity .. Add stub Create Account activity Change-Id: I54f3efad4e48ec3b7220c301ed2b0c81a8e3f90c --- M

[MediaWiki-commits] [Gerrit] Pick up android support library from appropriate place - change (apps...wikipedia)

2014-02-20 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Pick up android support library from appropriate place .. Pick up android support library from appropriate place com.android.* is in maven central and

[MediaWiki-commits] [Gerrit] Add a task to do pre-flight request for account creation + test - change (apps...wikipedia)

2014-02-20 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Add a task to do pre-flight request for account creation + test .. Add a task to do pre-flight request for account creation + test Change-Id:

[MediaWiki-commits] [Gerrit] Separate captcha layout into own file - change (apps...wikipedia)

2014-02-20 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Separate captcha layout into own file .. Separate captcha layout into own file Change-Id: I3d2bdef1f722eacea4e350bd4c5463fb1d28cbe4 --- M

[MediaWiki-commits] [Gerrit] Refactor captcha handling into its own Handler - change (apps...wikipedia)

2014-02-20 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Refactor captcha handling into its own Handler .. Refactor captcha handling into its own Handler Change-Id: If25368484eed89ae8f00f203e0be7e23b640d779

[MediaWiki-commits] [Gerrit] Refactor out code that did non-empty validation - change (apps...wikipedia)

2014-02-20 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Refactor out code that did non-empty validation .. Refactor out code that did non-empty validation Change-Id: Ibea715f26cc3a2602a109ff46519e4806eaf4f23

[MediaWiki-commits] [Gerrit] Don't pass title to RefreshCaptcha when Site would do - change (apps...wikipedia)

2014-02-20 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Don't pass title to RefreshCaptcha when Site would do .. Don't pass title to RefreshCaptcha when Site would do Change-Id:

[MediaWiki-commits] [Gerrit] Actually create the account - change (apps...wikipedia)

2014-02-20 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Actually create the account .. Actually create the account - Might inconsistently fail on testwiki, see bug 61663 - Will crash if you do captcha wrong.

[MediaWiki-commits] [Gerrit] Don't crash if captcha is wrong in CreateAccount - change (apps...wikipedia)

2014-02-20 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Don't crash if captcha is wrong in CreateAccount .. Don't crash if captcha is wrong in CreateAccount Change-Id:

[MediaWiki-commits] [Gerrit] Add repeat password textbox to create account - change (apps...wikipedia)

2014-02-21 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Add repeat password textbox to create account .. Add repeat password textbox to create account Change-Id: I085774f19a76756533000d96ce5aa6f17707b3f1 ---

[MediaWiki-commits] [Gerrit] Use saripaar for validation before submitting - change (apps...wikipedia)

2014-02-21 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Use saripaar for validation before submitting .. Use saripaar for validation before submitting Change-Id: Ief393d9a5ed5259fdfe33dccb14c8380ba693f25 ---

[MediaWiki-commits] [Gerrit] Revert low-res .ogv transcode enable; player is picking too-... - change (operations/mediawiki-config)

2014-02-21 Thread Brion VIBBER (Code Review)
Brion VIBBER has uploaded a new change for review. https://gerrit.wikimedia.org/r/114761 Change subject: Revert low-res .ogv transcode enable; player is picking too-small version by default .. Revert low-res .ogv transcode

[MediaWiki-commits] [Gerrit] Display errors inline in Login form as well - change (apps...wikipedia)

2014-02-21 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Display errors inline in Login form as well .. Display errors inline in Login form as well Change-Id: I659024483932bed53c53d7dc7cbc9117fae4fbcd --- M

[MediaWiki-commits] [Gerrit] Treat titles as HTML rather than text - change (apps...wikipedia)

2014-02-21 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Treat titles as HTML rather than text .. Treat titles as HTML rather than text Bug: 61728 Change-Id: Ic620f84d93ef6bb44f07c64f197bc5f361428be8 --- M

[MediaWiki-commits] [Gerrit] Handle user account creation errors - change (apps...wikipedia)

2014-02-21 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Handle user account creation errors .. Handle user account creation errors Change-Id: Ibdd13bafcafd38c258bd6641c71f32ed64f45f0a --- M

[MediaWiki-commits] [Gerrit] Hide search results if drawer is opened - change (apps...wikipedia)

2014-02-21 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Hide search results if drawer is opened .. Hide search results if drawer is opened Bug: 61717 Change-Id: I5bf3efbb64cc64bea771a409035effa731c23242 --- M

[MediaWiki-commits] [Gerrit] Handle back button properly when overlay is open - change (apps...wikipedia)

2014-02-21 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Handle back button properly when overlay is open .. Handle back button properly when overlay is open Bug: 61722 Change-Id:

[MediaWiki-commits] [Gerrit] Handle minimal HTML in headings in ToC - change (apps...wikipedia)

2014-02-21 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Handle minimal HTML in headings in ToC .. Handle minimal HTML in headings in ToC Change-Id: I81f87c21c5a9e5e7d616d2bce325fc0695c71307 --- M

[MediaWiki-commits] [Gerrit] Persist Account creation status info across rotates - change (apps...wikipedia)

2014-02-21 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Persist Account creation status info across rotates .. Persist Account creation status info across rotates Change-Id:

[MediaWiki-commits] [Gerrit] Hide 'No Results found' message as well when hiding search r... - change (apps...wikipedia)

2014-02-21 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Hide 'No Results found' message as well when hiding search results .. Hide 'No Results found' message as well when hiding search results Change-Id:

[MediaWiki-commits] [Gerrit] Fix popup video size by ordering transcode settings properly - change (operations/mediawiki-config)

2014-02-23 Thread Brion VIBBER (Code Review)
Brion VIBBER has uploaded a new change for review. https://gerrit.wikimedia.org/r/115094 Change subject: Fix popup video size by ordering transcode settings properly .. Fix popup video size by ordering transcode settings

[MediaWiki-commits] [Gerrit] Fix crash when rotating phone with multiple pages - change (apps...wikipedia)

2014-02-24 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Fix crash when rotating phone with multiple pages .. Fix crash when rotating phone with multiple pages - This stops replacing fragments, and just adds

[MediaWiki-commits] [Gerrit] Cleanup webviews when we no longer require them - change (apps...wikipedia)

2014-02-24 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Cleanup webviews when we no longer require them .. Cleanup webviews when we no longer require them Change-Id: I55f3d58b80887131d76f71288d05d34833b82d6f

[MediaWiki-commits] [Gerrit] Add task to get a preview + tests - change (apps...wikipedia)

2014-02-24 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Add task to get a preview + tests .. Add task to get a preview + tests Change-Id: Iad4b6d1d13ad534f81afd751d4bad609d980123a --- A

[MediaWiki-commits] [Gerrit] Add 'preview' functionality - change (apps...wikipedia)

2014-02-24 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Add 'preview' functionality .. Add 'preview' functionality - Tapping save first takes you to preview, and then tapping again actually saves. This

[MediaWiki-commits] [Gerrit] Make the preview task POST - change (apps...wikipedia)

2014-02-24 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Make the preview task POST .. Make the preview task POST Change-Id: Ic0ea37941823de6fba0de4bf5c2708c3c69961b5 --- M

[MediaWiki-commits] [Gerrit] Hide editlinks in preview - change (apps...wikipedia)

2014-02-24 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Hide editlinks in preview .. Hide editlinks in preview Change-Id: I94bf163aad0590e6386d595c45442543e4d215d7 --- M wikipedia/assets/preview.css M

[MediaWiki-commits] [Gerrit] WIP testing hack: send Accept-Language with API requests - change (apps...wikipedia)

2014-07-03 Thread Brion VIBBER (Code Review)
Brion VIBBER has uploaded a new change for review. https://gerrit.wikimedia.org/r/144095 Change subject: WIP testing hack: send Accept-Language with API requests .. WIP testing hack: send Accept-Language with API requests

[MediaWiki-commits] [Gerrit] Work in progress: Footer updates - change (apps...wikipedia)

2014-07-05 Thread Brion VIBBER (Code Review)
Brion VIBBER has uploaded a new change for review. https://gerrit.wikimedia.org/r/144342 Change subject: Work in progress: Footer updates .. Work in progress: Footer updates * update to match new design * 'last modified' bit

[MediaWiki-commits] [Gerrit] Instead of send feedback, send app feedback. - change (apps...wikipedia)

2014-07-07 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Instead of send feedback, send app feedback. .. Instead of send feedback, send app feedback. * This is more consistent with Android. * Hopefully it

[MediaWiki-commits] [Gerrit] Comment out the onboarding always-on mode - change (apps...wikipedia)

2014-07-07 Thread Brion VIBBER (Code Review)
Brion VIBBER has uploaded a new change for review. https://gerrit.wikimedia.org/r/144594 Change subject: Comment out the onboarding always-on mode .. Comment out the onboarding always-on mode We can uncomment the lines for

[MediaWiki-commits] [Gerrit] Table of contents refinements. - change (apps...wikipedia)

2014-07-07 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Table of contents refinements. .. Table of contents refinements. Change-Id: I5b2b728fb804034919460e7a5afd72fe3eb9ca56 --- M

[MediaWiki-commits] [Gerrit] Add footer-divider.png (whoops!) - change (apps...wikipedia)

2014-07-07 Thread Brion VIBBER (Code Review)
Brion VIBBER has uploaded a new change for review. https://gerrit.wikimedia.org/r/144614 Change subject: Add footer-divider.png (whoops!) .. Add footer-divider.png (whoops!) Change-Id:

[MediaWiki-commits] [Gerrit] Launch videos in VLC app on iOS if installed - change (mediawiki...TimedMediaHandler)

2014-07-07 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Launch videos in VLC app on iOS if installed .. Launch videos in VLC app on iOS if installed iOS does not support ogg/webm. Direct people to install iOS

[MediaWiki-commits] [Gerrit] Hide images in toc for now. - change (apps...wikipedia)

2014-07-08 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Hide images in toc for now. .. Hide images in toc for now. Toc sub-section entries now indented (up to 3 sections deep). Change-Id:

[MediaWiki-commits] [Gerrit] Link directly to mobile site in CC-BY-SA 3.0 link - change (apps...wikipedia)

2014-07-08 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Link directly to mobile site in CC-BY-SA 3.0 link .. Link directly to mobile site in CC-BY-SA 3.0 link Bug: 67650 Change-Id:

[MediaWiki-commits] [Gerrit] Fix for line wrapping in TOC in iOS 6. - change (apps...wikipedia)

2014-07-08 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Fix for line wrapping in TOC in iOS 6. .. Fix for line wrapping in TOC in iOS 6. Faster (hopefully) performance in iOS 6 as well. Change-Id:

[MediaWiki-commits] [Gerrit] Work in progress: pull to refresh refactor - change (apps...wikipedia)

2014-07-08 Thread Brion VIBBER (Code Review)
Brion VIBBER has uploaded a new change for review. https://gerrit.wikimedia.org/r/144735 Change subject: Work in progress: pull to refresh refactor .. Work in progress: pull to refresh refactor Refactored pull-to-refresh

[MediaWiki-commits] [Gerrit] Allow HTML5 rtc tag (ruby support for East Asian typography). - change (mediawiki/core)

2014-07-08 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Allow HTML5 rtc tag (ruby support for East Asian typography). .. Allow HTML5 rtc tag (ruby support for East Asian typography). We currently allow ruby,

[MediaWiki-commits] [Gerrit] Footer style updates from Vibha - change (apps...wikipedia)

2014-07-08 Thread Brion VIBBER (Code Review)
Brion VIBBER has uploaded a new change for review. https://gerrit.wikimedia.org/r/144811 Change subject: Footer style updates from Vibha .. Footer style updates from Vibha Change-Id: I02aac1dbba6d214873e3a2cc6e985bff1464890c

[MediaWiki-commits] [Gerrit] Work in progress: pull to refresh UI on Saved Pages - change (apps...wikipedia)

2014-07-08 Thread Brion VIBBER (Code Review)
Brion VIBBER has uploaded a new change for review. https://gerrit.wikimedia.org/r/144846 Change subject: Work in progress: pull to refresh UI on Saved Pages .. Work in progress: pull to refresh UI on Saved Pages Adds

[MediaWiki-commits] [Gerrit] Remove redlinks - change (apps...wikipedia)

2014-07-09 Thread Brion VIBBER (Code Review)
Brion VIBBER has uploaded a new change for review. https://gerrit.wikimedia.org/r/145138 Change subject: Remove redlinks .. Remove redlinks (transform code nicked from Android side since it's already done) (we should move

[MediaWiki-commits] [Gerrit] Terms of Use update for edit screen - change (apps...wikipedia)

2014-07-09 Thread Brion VIBBER (Code Review)
Brion VIBBER has uploaded a new change for review. https://gerrit.wikimedia.org/r/145152 Change subject: Terms of Use update for edit screen .. Terms of Use update for edit screen * Now mentions both 'Terms of Use' and

[MediaWiki-commits] [Gerrit] Shortened edit workflow login message. - change (apps...wikipedia)

2014-07-09 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Shortened edit workflow login message. .. Shortened edit workflow login message. Change-Id: I12370fe0554cc04b7292fd3f2e73c773fd1f7d7e --- M

[MediaWiki-commits] [Gerrit] Fix a compiler warning about unknown symbol - change (apps...wikipedia)

2014-07-10 Thread Brion VIBBER (Code Review)
Brion VIBBER has uploaded a new change for review. https://gerrit.wikimedia.org/r/145363 Change subject: Fix a compiler warning about unknown symbol .. Fix a compiler warning about unknown symbol Change-Id:

[MediaWiki-commits] [Gerrit] Fetch CSS resources from prod instead of labs - change (apps...wikipedia)

2014-07-10 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Fetch CSS resources from prod instead of labs .. Fetch CSS resources from prod instead of labs Change-Id: Icac68b29224416689860aa33abd2b83cde5fe072 ---

[MediaWiki-commits] [Gerrit] File page cleanup hacks - change (apps...wikipedia)

2014-07-10 Thread Brion VIBBER (Code Review)
Brion VIBBER has uploaded a new change for review. https://gerrit.wikimedia.org/r/145424 Change subject: File page cleanup hacks .. File page cleanup hacks * hide edit section pencils that don't work * disable tapping on the

[MediaWiki-commits] [Gerrit] Fix for toc sometimes jumping to wrong section. - change (apps...wikipedia)

2014-07-18 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Fix for toc sometimes jumping to wrong section. .. Fix for toc sometimes jumping to wrong section. Change-Id: Ie0286319a2522341eeef3a6c49342ab35c784a2a

[MediaWiki-commits] [Gerrit] Fetch a working trusty box on VMWare Fusion provider - change (mediawiki/vagrant)

2014-07-19 Thread Brion VIBBER (Code Review)
Brion VIBBER has uploaded a new change for review. https://gerrit.wikimedia.org/r/147880 Change subject: Fetch a working trusty box on VMWare Fusion provider .. Fetch a working trusty box on VMWare Fusion provider

[MediaWiki-commits] [Gerrit] Switch vmware_fusion provider to puppetlabs/ubuntu-14.04-64-... - change (mediawiki/vagrant)

2014-07-20 Thread Brion VIBBER (Code Review)
Brion VIBBER has uploaded a new change for review. https://gerrit.wikimedia.org/r/147924 Change subject: Switch vmware_fusion provider to puppetlabs/ubuntu-14.04-64-puppet .. Switch vmware_fusion provider to

[MediaWiki-commits] [Gerrit] Added today to main menu. - change (apps...wikipedia)

2014-07-21 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Added today to main menu. .. Added today to main menu. Change-Id: I32ce96203cb4d4e4f4982bd9fbd2f3ae4b973874 --- M wikipedia/View

[MediaWiki-commits] [Gerrit] Use https: base address for long-press link menu - change (apps...wikipedia)

2014-07-21 Thread Brion VIBBER (Code Review)
Brion VIBBER has uploaded a new change for review. https://gerrit.wikimedia.org/r/148162 Change subject: Use https: base address for long-press link menu .. Use https: base address for long-press link menu The menu is

[MediaWiki-commits] [Gerrit] References click backend: detect link clicks and send data o... - change (apps...wikipedia)

2014-07-21 Thread Brion VIBBER (Code Review)
Brion VIBBER has uploaded a new change for review. https://gerrit.wikimedia.org/r/148247 Change subject: References click backend: detect link clicks and send data over bridge .. References click backend: detect link clicks

[MediaWiki-commits] [Gerrit] Restyle abuse filter warning/disallow screen. - change (apps...wikipedia)

2014-07-22 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Restyle abuse filter warning/disallow screen. .. Restyle abuse filter warning/disallow screen. Change-Id: I056ed6110745c0b95b3e12dcb1166f1ad170486c ---

[MediaWiki-commits] [Gerrit] Apply infobox-moving transform from Android - change (apps...wikipedia)

2014-07-23 Thread Brion VIBBER (Code Review)
Brion VIBBER has uploaded a new change for review. https://gerrit.wikimedia.org/r/148832 Change subject: Apply infobox-moving transform from Android .. Apply infobox-moving transform from Android Copied the common

[MediaWiki-commits] [Gerrit] Fix appearance of images in Night mode. - change (mediawiki...MobileApp)

2014-07-24 Thread Brion VIBBER (Code Review)
Brion VIBBER has submitted this change and it was merged. Change subject: Fix appearance of images in Night mode. .. Fix appearance of images in Night mode. - Explicitly apply a white background for images, so that images with

<    6   7   8   9   10   11   12   13   14   15   >