[MediaWiki-commits] [Gerrit] Move .commit()/.rollback() from TransactionProcessor to Docu... - change (mediawiki...VisualEditor)

2013-03-21 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/55230 Change subject: Move .commit()/.rollback() from TransactionProcessor to Document .. Move .commit()/.rollback() from TransactionProcessor to

[MediaWiki-commits] [Gerrit] Add Thanks to extension-list - change (operations/mediawiki-config)

2013-03-21 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/55231 Change subject: Add Thanks to extension-list .. Add Thanks to extension-list Change-Id: I658810397d7d1f61beb92809a8783cef0277fae6 --- M

[MediaWiki-commits] [Gerrit] Add Thanks to extension-list - change (operations/mediawiki-config)

2013-03-21 Thread Catrope (Code Review)
Catrope has submitted this change and it was merged. Change subject: Add Thanks to extension-list .. Add Thanks to extension-list Change-Id: I658810397d7d1f61beb92809a8783cef0277fae6 --- M wmf-config/extension-list 1 file

[MediaWiki-commits] [Gerrit] Add mutators in MetaList - change (mediawiki...VisualEditor)

2013-03-21 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/55243 Change subject: Add mutators in MetaList .. Add mutators in MetaList Add .insertMeta() and .removeMeta() methods to insert and remove

[MediaWiki-commits] [Gerrit] Add insert and remove events to MetaList - change (mediawiki...VisualEditor)

2013-03-21 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/55244 Change subject: Add insert and remove events to MetaList .. Add insert and remove events to MetaList These events occur when an item is

[MediaWiki-commits] [Gerrit] Convert AnnotationFactory and MetaItemFactory to NamedClassF... - change (mediawiki...VisualEditor)

2013-04-02 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/57244 Change subject: Convert AnnotationFactory and MetaItemFactory to NamedClassFactories .. Convert AnnotationFactory and MetaItemFactory to

[MediaWiki-commits] [Gerrit] Actually use the doc parameter in toDomElements() - change (mediawiki...VisualEditor)

2013-04-02 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/57246 Change subject: Actually use the doc parameter in toDomElements() .. Actually use the doc parameter in toDomElements() It's been passed in

[MediaWiki-commits] [Gerrit] Rename ve.NodeFactory to ve.NamedClassFactory - change (mediawiki...VisualEditor)

2013-04-02 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/57243 Change subject: Rename ve.NodeFactory to ve.NamedClassFactory .. Rename ve.NodeFactory to ve.NamedClassFactory We weren't really using it

[MediaWiki-commits] [Gerrit] Add ve.ce.View as a common base class for ce.Node and ce.Ann... - change (mediawiki...VisualEditor)

2013-04-02 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/57242 Change subject: Add ve.ce.View as a common base class for ce.Node and ce.Annotation .. Add ve.ce.View as a common base class for ce.Node and

[MediaWiki-commits] [Gerrit] Reduce code duplication for annotation rendering - change (mediawiki...VisualEditor)

2013-04-02 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/57245 Change subject: Reduce code duplication for annotation rendering .. Reduce code duplication for annotation rendering ve.dm.Converter and

[MediaWiki-commits] [Gerrit] Remove xenon and caesium from Parsoid service, RobH is recla... - change (operations/puppet)

2013-04-03 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/57334 Change subject: Remove xenon and caesium from Parsoid service, RobH is reclaiming them .. Remove xenon and caesium from Parsoid service,

[MediaWiki-commits] [Gerrit] Set defaultrebase=0 - change (mediawiki...MobileFrontend)

2013-04-03 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/57421 Change subject: Set defaultrebase=0 .. Set defaultrebase=0 Change-Id: I6b93571ac83f4fbbe48ccedb27a76d5d60747aad --- M .gitreview 1 file

[MediaWiki-commits] [Gerrit] Fix a bug where trimOuterSpaceFromRange() didn't trim an all... - change (mediawiki...VisualEditor)

2013-04-03 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/57441 Change subject: Fix a bug where trimOuterSpaceFromRange() didn't trim an all-whitespace range .. Fix a bug where trimOuterSpaceFromRange()

[MediaWiki-commits] [Gerrit] DO NOT MERGE test commit for QUnit in Jenkins - change (mediawiki...VisualEditor)

2013-04-03 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/57459 Change subject: DO NOT MERGE test commit for QUnit in Jenkins .. DO NOT MERGE test commit for QUnit in Jenkins Change-Id:

[MediaWiki-commits] [Gerrit] Really break tests - change (mediawiki...VisualEditor)

2013-04-03 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/57461 Change subject: Really break tests .. Really break tests Change-Id: Ic4e5bddd6745b1afea94e56c603eb4e398da8a61 --- M

[MediaWiki-commits] [Gerrit] Make the full document regex hack a bit more robust - change (mediawiki...VisualEditor)

2013-02-21 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/50308 Change subject: Make the full document regex hack a bit more robust .. Make the full document regex hack a bit more robust Anchor the regex

[MediaWiki-commits] [Gerrit] Add wtp1002-4 to Parsoid deployment list - change (operations/puppet)

2013-02-22 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/50392 Change subject: Add wtp1002-4 to Parsoid deployment list .. Add wtp1002-4 to Parsoid deployment list Change-Id:

[MediaWiki-commits] [Gerrit] Change one last .storeHTMLAttributes to .storeHtmlAttributes - change (mediawiki...VisualEditor)

2013-02-22 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/50460 Change subject: Change one last .storeHTMLAttributes to .storeHtmlAttributes .. Change one last .storeHTMLAttributes to .storeHtmlAttributes

[MediaWiki-commits] [Gerrit] After creating a ve.Surface in a test, destroy it - change (mediawiki...VisualEditor)

2013-02-22 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/50462 Change subject: After creating a ve.Surface in a test, destroy it .. After creating a ve.Surface in a test, destroy it I was seeing

[MediaWiki-commits] [Gerrit] Combine consecutive remove operations - change (mediawiki...VisualEditor)

2013-02-22 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/50471 Change subject: Combine consecutive remove operations .. Combine consecutive remove operations We already combine consecutive operations of

[MediaWiki-commits] [Gerrit] Add ve.Range.prototype.isBackwards() - change (mediawiki...VisualEditor)

2013-02-22 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/50472 Change subject: Add ve.Range.prototype.isBackwards() .. Add ve.Range.prototype.isBackwards() Change-Id:

[MediaWiki-commits] [Gerrit] Make translateRange() translate across wrapping transactions... - change (mediawiki...VisualEditor)

2013-02-22 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/50473 Change subject: Make translateRange() translate across wrapping transactions correctly .. Make translateRange() translate across wrapping

[MediaWiki-commits] [Gerrit] Use the new service IP for Parsoid in eqiad - change (operations/mediawiki-config)

2013-03-05 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/52312 Change subject: Use the new service IP for Parsoid in eqiad .. Use the new service IP for Parsoid in eqiad Change-Id:

[MediaWiki-commits] [Gerrit] Use the new service IP for Parsoid in eqiad - change (operations/mediawiki-config)

2013-03-05 Thread Catrope (Code Review)
Catrope has submitted this change and it was merged. Change subject: Use the new service IP for Parsoid in eqiad .. Use the new service IP for Parsoid in eqiad Change-Id: I0862f03f67a891808474dd1a5613d9a22e97fc01 --- M

[MediaWiki-commits] [Gerrit] Use the service IP for parsoidcache in Tampa as well - change (operations/mediawiki-config)

2013-03-07 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/52654 Change subject: Use the service IP for parsoidcache in Tampa as well .. Use the service IP for parsoidcache in Tampa as well Change-Id:

[MediaWiki-commits] [Gerrit] Use the service IP for parsoidcache in Tampa as well - change (operations/mediawiki-config)

2013-03-07 Thread Catrope (Code Review)
Catrope has submitted this change and it was merged. Change subject: Use the service IP for parsoidcache in Tampa as well .. Use the service IP for parsoidcache in Tampa as well Change-Id:

[MediaWiki-commits] [Gerrit] Use echowikis.dblist for the Echo cron job - change (operations/puppet)

2013-04-22 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/60303 Change subject: Use echowikis.dblist for the Echo cron job .. Use echowikis.dblist for the Echo cron job Change-Id:

[MediaWiki-commits] [Gerrit] Stop dropping properties in copyObject/copyArray - change (mediawiki...VisualEditor)

2013-04-22 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/60335 Change subject: Stop dropping properties in copyObject/copyArray .. Stop dropping properties in copyObject/copyArray Previously, if we

[MediaWiki-commits] [Gerrit] Allow iiurlheight to be used without iiurlwidth - change (mediawiki/core)

2013-04-23 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/60450 Change subject: Allow iiurlheight to be used without iiurlwidth .. Allow iiurlheight to be used without iiurlwidth Wanting to get a

[MediaWiki-commits] [Gerrit] Update VisualEditor to master - change (mediawiki/core)

2013-04-25 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/60876 Change subject: Update VisualEditor to master .. Update VisualEditor to master Change-Id: I8d5abe5c9fd6c6822ef55984457a0cfbf3a5cc74 --- M

[MediaWiki-commits] [Gerrit] Update VisualEditor to master - change (mediawiki/core)

2013-04-25 Thread Catrope (Code Review)
Catrope has submitted this change and it was merged. Change subject: Update VisualEditor to master .. Update VisualEditor to master Change-Id: I8d5abe5c9fd6c6822ef55984457a0cfbf3a5cc74 --- M extensions/VisualEditor 1 file

[MediaWiki-commits] [Gerrit] Update VisualEditor to master again to pick up link inspecto... - change (mediawiki/core)

2013-04-25 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/60908 Change subject: Update VisualEditor to master again to pick up link inspector fix .. Update VisualEditor to master again to pick up link

[MediaWiki-commits] [Gerrit] Update VisualEditor to master again to pick up link inspecto... - change (mediawiki/core)

2013-04-25 Thread Catrope (Code Review)
Catrope has submitted this change and it was merged. Change subject: Update VisualEditor to master again to pick up link inspector fix .. Update VisualEditor to master again to pick up link inspector fix Change-Id:

[MediaWiki-commits] [Gerrit] Revert Hack to escape angle brackets in data-parsoid attrib... - change (mediawiki...VisualEditor)

2013-04-25 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/60938 Change subject: Revert Hack to escape angle brackets in data-parsoid attribute .. Revert Hack to escape angle brackets in data-parsoid

[MediaWiki-commits] [Gerrit] Revert Serialize alienated context-sensitive nodes correctly - change (mediawiki...VisualEditor)

2013-04-25 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/60939 Change subject: Revert Serialize alienated context-sensitive nodes correctly .. Revert Serialize alienated context-sensitive nodes correctly

[MediaWiki-commits] [Gerrit] Add TableCaptionNode - change (mediawiki...VisualEditor)

2013-04-25 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/60940 Change subject: Add TableCaptionNode .. Add TableCaptionNode Because we have a node for table, we also need one for caption, otherwise we'll

[MediaWiki-commits] [Gerrit] Make clearing by type actually work - change (mediawiki...VisualEditor)

2013-04-25 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/60948 Change subject: Make clearing by type actually work .. Make clearing by type actually work Clearing by type in SurfaceFragment didn't

[MediaWiki-commits] [Gerrit] Tolerate !DOCTYPE - change (mediawiki...VisualEditor)

2013-04-25 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/60949 Change subject: Tolerate !DOCTYPE .. Tolerate !DOCTYPE Parsoid switched from !doctype to !DOCTYPE, which exposed the fact that our dirty

[MediaWiki-commits] [Gerrit] Deduplicate childUpdate events based on transaction and appl... - change (mediawiki...VisualEditor)

2013-04-25 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/60951 Change subject: Deduplicate childUpdate events based on transaction and appliedness .. Deduplicate childUpdate events based on transaction

[MediaWiki-commits] [Gerrit] Clean up VisualEditor settings - change (operations/mediawiki-config)

2013-04-25 Thread Catrope (Code Review)
Catrope has submitted this change and it was merged. Change subject: Clean up VisualEditor settings .. Clean up VisualEditor settings Remove wmgVisualEditorHide (we don't need this any more) and allow editing for NS_MAIN and

[MediaWiki-commits] [Gerrit] Update VisualEditor to master - change (mediawiki/core)

2013-04-25 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/60955 Change subject: Update VisualEditor to master .. Update VisualEditor to master Change-Id: If3c95f13f0dbf618f5a3cd9667c6320b4b9c9b4b --- M

[MediaWiki-commits] [Gerrit] Update VisualEditor to master - change (mediawiki/core)

2013-04-25 Thread Catrope (Code Review)
Catrope has submitted this change and it was merged. Change subject: Update VisualEditor to master .. Update VisualEditor to master Change-Id: If3c95f13f0dbf618f5a3cd9667c6320b4b9c9b4b --- M extensions/VisualEditor 1 file

[MediaWiki-commits] [Gerrit] Add a copy of jquery.client so the standalone still works - change (mediawiki...VisualEditor)

2013-04-26 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/61071 Change subject: Add a copy of jquery.client so the standalone still works .. Add a copy of jquery.client so the standalone still works The

[MediaWiki-commits] [Gerrit] Paragraph-heading conversion was broken when cursor next to... - change (mediawiki...VisualEditor)

2013-04-26 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/61157 Change subject: Paragraph-heading conversion was broken when cursor next to an inline node .. Paragraph-heading conversion was broken when

[MediaWiki-commits] [Gerrit] Enable VisualEditor on test2wiki - change (operations/mediawiki-config)

2013-04-28 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/61250 Change subject: Enable VisualEditor on test2wiki .. Enable VisualEditor on test2wiki Bug: 43018 Change-Id:

[MediaWiki-commits] [Gerrit] Add TemplateData extension - change (mediawiki/core)

2013-04-29 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/61475 Change subject: Add TemplateData extension .. Add TemplateData extension Change-Id: I6d7fc28c1e0e2bed92a80eb173cccfe1db0a5838 --- M

[MediaWiki-commits] [Gerrit] Add TemplateData extension - change (mediawiki/core)

2013-04-29 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/61476 Change subject: Add TemplateData extension .. Add TemplateData extension Change-Id: I6d7fc28c1e0e2bed92a80eb173cccfe1db0a5838 --- M

[MediaWiki-commits] [Gerrit] Add TemplateData extension - change (mediawiki/core)

2013-04-29 Thread Catrope (Code Review)
Catrope has submitted this change and it was merged. Change subject: Add TemplateData extension .. Add TemplateData extension Change-Id: I6d7fc28c1e0e2bed92a80eb173cccfe1db0a5838 --- M .gitmodules A extensions/TemplateData 2

[MediaWiki-commits] [Gerrit] Add TemplateData extension - change (mediawiki/core)

2013-04-29 Thread Catrope (Code Review)
Catrope has submitted this change and it was merged. Change subject: Add TemplateData extension .. Add TemplateData extension Change-Id: I6d7fc28c1e0e2bed92a80eb173cccfe1db0a5838 --- M .gitmodules A extensions/TemplateData 2

[MediaWiki-commits] [Gerrit] Add the TemplateData extension - change (operations/mediawiki-config)

2013-04-29 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/61481 Change subject: Add the TemplateData extension .. Add the TemplateData extension Change-Id: I99978f699c88e6bb9aea551fdb8deb06448fe19c --- M

[MediaWiki-commits] [Gerrit] Add the TemplateData extension - change (operations/mediawiki-config)

2013-04-29 Thread Catrope (Code Review)
Catrope has submitted this change and it was merged. Change subject: Add the TemplateData extension .. Add the TemplateData extension Change-Id: I99978f699c88e6bb9aea551fdb8deb06448fe19c --- M wmf-config/CommonSettings.php M

[MediaWiki-commits] [Gerrit] Add TemplateData - change (mediawiki...release)

2013-04-29 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/61486 Change subject: Add TemplateData .. Add TemplateData Change-Id: I190afc177457f9a5e7031bb67c070e5aa27e0939 --- M make-wmf-branch/default.conf

[MediaWiki-commits] [Gerrit] Enable TemplateData on mw.org, testwiki and test2wiki - change (operations/mediawiki-config)

2013-04-29 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/61488 Change subject: Enable TemplateData on mw.org, testwiki and test2wiki .. Enable TemplateData on mw.org, testwiki and test2wiki Change-Id:

[MediaWiki-commits] [Gerrit] Enable TemplateData on mw.org, testwiki and test2wiki - change (operations/mediawiki-config)

2013-04-29 Thread Catrope (Code Review)
Catrope has submitted this change and it was merged. Change subject: Enable TemplateData on mw.org, testwiki and test2wiki .. Enable TemplateData on mw.org, testwiki and test2wiki Change-Id:

[MediaWiki-commits] [Gerrit] Add TemplateData - change (mediawiki...release)

2013-04-29 Thread Catrope (Code Review)
Catrope has submitted this change and it was merged. Change subject: Add TemplateData .. Add TemplateData Change-Id: I190afc177457f9a5e7031bb67c070e5aa27e0939 --- M make-wmf-branch/default.conf 1 file changed, 1 insertion(+),

[MediaWiki-commits] [Gerrit] Fix ce.AlienNode - change (mediawiki...VisualEditor)

2013-04-29 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/61510 Change subject: Fix ce.AlienNode .. Fix ce.AlienNode Was completely broken after the dm.AlienNode changes Change-Id:

[MediaWiki-commits] [Gerrit] Use duck typing instead of instanceof Node - change (mediawiki...VisualEditor)

2013-04-29 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/61517 Change subject: Use duck typing instead of instanceof Node .. Use duck typing instead of instanceof Node instanceof Node doesn't work with

[MediaWiki-commits] [Gerrit] Update VisualEditor to master - change (mediawiki/core)

2013-04-29 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/61521 Change subject: Update VisualEditor to master .. Update VisualEditor to master Change-Id: Ic685de45e73efe2afedd97905d1cf4cee5025e75 --- M

[MediaWiki-commits] [Gerrit] Update VisualEditor to master - change (mediawiki/core)

2013-04-29 Thread Catrope (Code Review)
Catrope has submitted this change and it was merged. Change subject: Update VisualEditor to master .. Update VisualEditor to master Change-Id: Ic685de45e73efe2afedd97905d1cf4cee5025e75 --- M extensions/VisualEditor 1 file

[MediaWiki-commits] [Gerrit] Per Timo's comment, change $.makeArray( foo ) to foo.toArray() - change (mediawiki...VisualEditor)

2013-04-29 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/61530 Change subject: Per Timo's comment, change $.makeArray( foo ) to foo.toArray() .. Per Timo's comment, change $.makeArray( foo ) to

[MediaWiki-commits] [Gerrit] Also respect .static.renderHtmlAttributes when rerendering f... - change (mediawiki...VisualEditor)

2013-04-30 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/61718 Change subject: Also respect .static.renderHtmlAttributes when rerendering for attribute changes .. Also respect

[MediaWiki-commits] [Gerrit] When annotating, skip any branch nodes that are content - change (mediawiki...VisualEditor)

2013-04-30 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/61731 Change subject: When annotating, skip any branch nodes that are content .. When annotating, skip any branch nodes that are content We don't

[MediaWiki-commits] [Gerrit] Restrict Verified+1/2 and Submit to JenkinsBot and l10n-bot - change (mediawiki...TemplateData)

2013-05-02 Thread Catrope (Code Review)
Catrope has submitted this change and it was merged. Change subject: Restrict Verified+1/2 and Submit to JenkinsBot and l10n-bot .. Restrict Verified+1/2 and Submit to JenkinsBot and l10n-bot Change-Id:

[MediaWiki-commits] [Gerrit] Refetch the token when we get a badtoken error - change (mediawiki...VisualEditor)

2013-05-18 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/64492 Change subject: Refetch the token when we get a badtoken error .. Refetch the token when we get a badtoken error Intercept badtoken errors,

[MediaWiki-commits] [Gerrit] Clean up VisualEditor config - change (operations/mediawiki-config)

2013-05-18 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/64493 Change subject: Clean up VisualEditor config .. Clean up VisualEditor config * Pull list of VE-enabled wikis from visualeditor.dblist * Set

[MediaWiki-commits] [Gerrit] Enable TemplateData on all wikis - change (operations/mediawiki-config)

2013-05-20 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/64595 Change subject: Enable TemplateData on all wikis .. Enable TemplateData on all wikis Change-Id: I41a9b9a43d8e61255e6f5a0daf6f1f025520e11b

[MediaWiki-commits] [Gerrit] Add a transaction builder for replacing the contents of an i... - change (mediawiki...VisualEditor)

2013-05-20 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/64613 Change subject: Add a transaction builder for replacing the contents of an internal node .. Add a transaction builder for replacing the

[MediaWiki-commits] [Gerrit] Revert HTMLCheckMatrix support for forcing options on/off - change (mediawiki/core)

2013-05-22 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/64946 Change subject: Revert HTMLCheckMatrix support for forcing options on/off .. Revert HTMLCheckMatrix support for forcing options on/off This

[MediaWiki-commits] [Gerrit] Correctly populate internalList for example documents - change (mediawiki...VisualEditor)

2013-05-22 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/64957 Change subject: Correctly populate internalList for example documents .. Correctly populate internalList for example documents Right now the

[MediaWiki-commits] [Gerrit] Add getDocumentSlice() - change (mediawiki...VisualEditor)

2013-05-22 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/64958 Change subject: Add getDocumentSlice() .. Add getDocumentSlice() A document slice is a document built from a data slice of an existing

[MediaWiki-commits] [Gerrit] Merging and remapping - change (mediawiki...VisualEditor)

2013-05-22 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/64959 Change subject: Merging and remapping .. Merging and remapping Add merge() methods to IndexValueStore and InternalList, which merge another

[MediaWiki-commits] [Gerrit] Add newFromDocumentInsertion() - change (mediawiki...VisualEditor)

2013-05-22 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/64960 Change subject: Add newFromDocumentInsertion() .. Add newFromDocumentInsertion() This function builds a transaction that takes a document

[MediaWiki-commits] [Gerrit] Fix internal node weirdness - change (mediawiki...VisualEditor)

2013-05-22 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/64975 Change subject: Fix internal node weirdness .. Fix internal node weirdness * In getDataElementOrSlice(), we were slicing one too far * When

[MediaWiki-commits] [Gerrit] Fix getAnnotationIndexesFromOffset() to always return an array - change (mediawiki...VisualEditor)

2013-05-25 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/65430 Change subject: Fix getAnnotationIndexesFromOffset() to always return an array .. Fix getAnnotationIndexesFromOffset() to always return an

[MediaWiki-commits] [Gerrit] Remove duplicated code breaking the template dialog - change (mediawiki...VisualEditor)

2013-05-25 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/65435 Change subject: Remove duplicated code breaking the template dialog .. Remove duplicated code breaking the template dialog Change-Id:

[MediaWiki-commits] [Gerrit] Make reference editing work - change (mediawiki...VisualEditor)

2013-05-25 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/65441 Change subject: Make reference editing work .. Make reference editing work The only reason it doesn't save correctly right now is because

[MediaWiki-commits] [Gerrit] Fix undefined i18n message in category popout - change (mediawiki...VisualEditor)

2013-05-25 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/65442 Change subject: Fix undefined i18n message in category popout .. Fix undefined i18n message in category popout Message was renamed earlier

[MediaWiki-commits] [Gerrit] Fix misspelled event handler - change (mediawiki...VisualEditor)

2013-05-25 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/65444 Change subject: Fix misspelled event handler .. Fix misspelled event handler Change-Id: I3f3091aad24d4bfdea08fbce1c331e8767866bbc --- M

[MediaWiki-commits] [Gerrit] Convert from DOS line endings (CRLF) to Unix ones (LF) - change (mediawiki...VisualEditor)

2013-05-25 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/65471 Change subject: Convert from DOS line endings (CRLF) to Unix ones (LF) .. Convert from DOS line endings (CRLF) to Unix ones (LF) Change-Id:

[MediaWiki-commits] [Gerrit] Raise account creation throttle for the Amsterdam Hackathon IPs - change (operations/mediawiki-config)

2013-05-26 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/65544 Change subject: Raise account creation throttle for the Amsterdam Hackathon IPs .. Raise account creation throttle for the Amsterdam

[MediaWiki-commits] [Gerrit] Raise account creation throttle for the Amsterdam Hackathon IPs - change (operations/mediawiki-config)

2013-05-26 Thread Catrope (Code Review)
Catrope has submitted this change and it was merged. Change subject: Raise account creation throttle for the Amsterdam Hackathon IPs .. Raise account creation throttle for the Amsterdam Hackathon IPs Change-Id:

[MediaWiki-commits] [Gerrit] Clear phantoms on teardown in ProtectedNode - change (mediawiki...VisualEditor)

2013-05-26 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/65573 Change subject: Clear phantoms on teardown in ProtectedNode .. Clear phantoms on teardown in ProtectedNode When you typed after a

[MediaWiki-commits] [Gerrit] Don't do evil shadowing of mw - change (mediawiki...VisualEditor)

2013-05-26 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/65601 Change subject: Don't do evil shadowing of mw .. Don't do evil shadowing of mw Having local variable called mw that shadows the global

[MediaWiki-commits] [Gerrit] Make VisualEditor work in labs (hopefully) - change (operations/mediawiki-config)

2013-05-30 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/66100 Change subject: Make VisualEditor work in labs (hopefully) .. Make VisualEditor work in labs (hopefully) Change-Id:

[MediaWiki-commits] [Gerrit] Unwrap excess ps in inline template rendering - change (mediawiki...VisualEditor)

2013-05-30 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/66127 Change subject: Unwrap excess ps in inline template rendering .. Unwrap excess ps in inline template rendering This is a hack, in the future

[MediaWiki-commits] [Gerrit] Fix parsoid-common VCL inclusion and references - change (operations/puppet)

2013-06-04 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/67003 Change subject: Fix parsoid-common VCL inclusion and references .. Fix parsoid-common VCL inclusion and references Change-Id:

[MediaWiki-commits] [Gerrit] Actually use new Parsoid Varnish puppetization in production - change (operations/puppet)

2013-06-04 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/67006 Change subject: Actually use new Parsoid Varnish puppetization in production .. Actually use new Parsoid Varnish puppetization in production

[MediaWiki-commits] [Gerrit] Make toolbar group labels spans instead of divs - change (mediawiki...WikiEditor)

2013-04-08 Thread Catrope (Code Review)
Catrope has submitted this change and it was merged. Change subject: Make toolbar group labels spans instead of divs .. Make toolbar group labels spans instead of divs The mix of div and a tags, being floated left inside a

[MediaWiki-commits] [Gerrit] mw.loader: Fix regression that caused CSS load after scripts. - change (mediawiki/core)

2013-04-08 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/58134 Change subject: mw.loader: Fix regression that caused CSS load after scripts. .. mw.loader: Fix regression that caused CSS load after

[MediaWiki-commits] [Gerrit] Update WikiEditor to master to deploy 17a90bc74e87341199a50e... - change (mediawiki/core)

2013-04-08 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/58237 Change subject: Update WikiEditor to master to deploy 17a90bc74e87341199a50ebe5348576e05be028a .. Update WikiEditor to master to deploy

[MediaWiki-commits] [Gerrit] Update WikiEditor to master to deploy 17a90bc74e87341199a50e... - change (mediawiki/core)

2013-04-08 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/58238 Change subject: Update WikiEditor to master to deploy 17a90bc74e87341199a50ebe5348576e05be028a .. Update WikiEditor to master to deploy

[MediaWiki-commits] [Gerrit] Update WikiEditor to master to deploy 17a90bc74e87341199a50e... - change (mediawiki/core)

2013-04-08 Thread Catrope (Code Review)
Catrope has submitted this change and it was merged. Change subject: Update WikiEditor to master to deploy 17a90bc74e87341199a50ebe5348576e05be028a .. Update WikiEditor to master to deploy

[MediaWiki-commits] [Gerrit] Update WikiEditor to master to deploy 17a90bc74e87341199a50e... - change (mediawiki/core)

2013-04-08 Thread Catrope (Code Review)
Catrope has submitted this change and it was merged. Change subject: Update WikiEditor to master to deploy 17a90bc74e87341199a50ebe5348576e05be028a .. Update WikiEditor to master to deploy

[MediaWiki-commits] [Gerrit] Fix ModelRegistry bugs - change (mediawiki...VisualEditor)

2013-04-08 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/58259 Change subject: Fix ModelRegistry bugs .. Fix ModelRegistry bugs * In matchTypeRegExps(), skip string types ** Didn't break because we

[MediaWiki-commits] [Gerrit] Be resilient against an unset hrefPrefix in MWCategoryMetaItem - change (mediawiki...VisualEditor)

2013-04-08 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/58270 Change subject: Be resilient against an unset hrefPrefix in MWCategoryMetaItem .. Be resilient against an unset hrefPrefix in

[MediaWiki-commits] [Gerrit] Fix MetaList tests, were totally broken - change (mediawiki...VisualEditor)

2013-04-09 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/58277 Change subject: Fix MetaList tests, were totally broken .. Fix MetaList tests, were totally broken They worked fine with just one group, but

[MediaWiki-commits] [Gerrit] Make getDataFromDomRecursion() use a context stack to pass c... - change (mediawiki...VisualEditor)

2013-04-10 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/58642 Change subject: Make getDataFromDomRecursion() use a context stack to pass context info .. Make getDataFromDomRecursion() use a context

[MediaWiki-commits] [Gerrit] Pass the converter object to the node handler in toDataEleme... - change (mediawiki...VisualEditor)

2013-04-10 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/58643 Change subject: Pass the converter object to the node handler in toDataElement() .. Pass the converter object to the node handler in

[MediaWiki-commits] [Gerrit] Allow hybrids across Model subclasses - change (mediawiki...VisualEditor)

2013-04-10 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/58644 Change subject: Allow hybrids across Model subclasses .. Allow hybrids across Model subclasses A node could already implement a

[MediaWiki-commits] [Gerrit] Allow nodes to handle their own children - change (mediawiki...VisualEditor)

2013-04-10 Thread Catrope (Code Review)
Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/58645 Change subject: Allow nodes to handle their own children .. Allow nodes to handle their own children For data-DOM, this is easy:

<    4   5   6   7   8   9   10   11   12   13   >