[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Drop call of deprecated IE8-support method

2017-10-12 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/383851 ) Change subject: Drop call of deprecated IE8-support method .. Drop call of deprecated IE8-support method Bug: T123219 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...CodeEditor[master]: Remove deprecated methods

2017-10-12 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/383849 ) Change subject: Remove deprecated methods .. Remove deprecated methods Change-Id: Ib81592b4a13528a5ecf30d8a5cebbacae20be189 Depends-On:

[MediaWiki-commits] [Gerrit] mediawiki...WikiEditor[master]: Remove rest of partially-removed IE hack

2017-10-12 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/383850 ) Change subject: Remove rest of partially-removed IE hack .. Remove rest of partially-removed IE hack Bug: T123219 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...ContentTranslation[master]: Show available languages on suggested pages filter

2017-10-12 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/383832 ) Change subject: Show available languages on suggested pages filter .. Show available languages on suggested pages filter Bug: T176626

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: requestParsoidData: Support 'wikitext' param in RESTBase-les...

2017-10-11 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/383664 ) Change subject: requestParsoidData: Support 'wikitext' param in RESTBase-less environment .. requestParsoidData: Support 'wikitext' param

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Fix WikiEditor mode switcher widget

2017-10-11 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/383614 ) Change subject: Fix WikiEditor mode switcher widget .. Fix WikiEditor mode switcher widget Broken by upstream CSS changes in OOUI.

[MediaWiki-commits] [Gerrit] mediawiki...ContentTranslation[master]: Remove unused overlay property from source selector

2017-10-11 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/383570 ) Change subject: Remove unused overlay property from source selector .. Remove unused overlay property from source selector Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...ContentTranslation[master]: Use input padding and absolute positioning on page selector

2017-10-11 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/383540 ) Change subject: Use input padding and absolute positioning on page selector .. Use input padding and absolute positioning on page selector

[MediaWiki-commits] [Gerrit] mediawiki...ContentTranslation[master]: Use OOUI TextInputWidget for target title in dialog

2017-10-11 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/383539 ) Change subject: Use OOUI TextInputWidget for target title in dialog .. Use OOUI TextInputWidget for target title in dialog Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...ContentTranslation[master]: Use OOUI message dialog for deletion confirmation

2017-10-10 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/383397 ) Change subject: Use OOUI message dialog for deletion confirmation .. Use OOUI message dialog for deletion confirmation Replaces ~80 lines

[MediaWiki-commits] [Gerrit] mediawiki...ContentTranslation[master]: Fix typo in transition property (en-GB -> en-US)

2017-10-10 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/383366 ) Change subject: Fix typo in transition property (en-GB -> en-US) .. Fix typo in transition property (en-GB -> en-US) Change-Id:

[MediaWiki-commits] [Gerrit] oojs/ui[master]: Add reload icon to interactions

2017-10-10 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/383359 ) Change subject: Add reload icon to interactions .. Add reload icon to interactions Based on the icon in the ContentTranslation MediaWiki

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: build: Update eslint and other linters

2017-10-09 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/383144 ) Change subject: build: Update eslint and other linters .. build: Update eslint and other linters Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...Popups[master]: Remove old jscs file

2017-10-09 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/383140 ) Change subject: Remove old jscs file .. Remove old jscs file Change-Id: I16a4cbffc8dc7232f4bf620f44ff2b7597860517 --- D tests/.jscsrc.js

[MediaWiki-commits] [Gerrit] mediawiki...RelatedArticles[master]: build: Update eslint and stylelint

2017-10-09 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/383139 ) Change subject: build: Update eslint and stylelint .. build: Update eslint and stylelint Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...RelatedArticles[master]: build: Cleanup eslint config

2017-10-09 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/383138 ) Change subject: build: Cleanup eslint config .. build: Cleanup eslint config Change-Id: Icbdf65233ba343f973a5dd3c93088861c1d90ff5 --- M

[MediaWiki-commits] [Gerrit] mediawiki...TextExtracts[master]: build: Upgrade linters

2017-10-09 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/383136 ) Change subject: build: Upgrade linters .. build: Upgrade linters Change-Id: Ie377edfccd078e08a1cdb5c9e021a4b96a41599b --- A

[MediaWiki-commits] [Gerrit] mediawiki...cxserver[master]: Upgrade DOMPurify 0.9.0 > 1.0.2

2017-10-09 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/383135 ) Change subject: Upgrade DOMPurify 0.9.0 > 1.0.2 .. Upgrade DOMPurify 0.9.0 > 1.0.2 Change-Id: Ib7a995a86b1edc7707f72ddafb50d8718de57dda

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Add and [srcset] to DOMPurify exceptions

2017-10-09 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/383131 ) Change subject: Add and [srcset] to DOMPurify exceptions .. Add and [srcset] to DOMPurify exceptions Change-Id:

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Upgrade DOMPurify 0.8.5 > 1.0.2

2017-10-09 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/383130 ) Change subject: Upgrade DOMPurify 0.8.5 > 1.0.2 .. Upgrade DOMPurify 0.8.5 > 1.0.2 Change-Id: If901fdb0330e26cdc53e5b3f6c35cf9416987f4b

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: SearchInputWidget: Actually connect to change event

2017-10-09 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/383091 ) Change subject: SearchInputWidget: Actually connect to change event .. SearchInputWidget: Actually connect to change event This makes the

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: SearchInputWidget: Pass through description data

2017-10-09 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/383088 ) Change subject: SearchInputWidget: Pass through description data .. SearchInputWidget: Pass through description data Also make

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Remove setting of SearchInputWidget configs to already-defau...

2017-10-08 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/383038 ) Change subject: Remove setting of SearchInputWidget configs to already-default values .. Remove setting of SearchInputWidget configs to

[MediaWiki-commits] [Gerrit] mediawiki...ContentTranslation[master]: Use upstream icon for ellipsis

2017-10-07 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/383005 ) Change subject: Use upstream icon for ellipsis .. Use upstream icon for ellipsis Change-Id: Idba59a357271bb86cf24a8963d47c55905e24552 ---

[MediaWiki-commits] [Gerrit] oojs/ui[master]: Only store initialConfig in demo mode

2017-10-07 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/382970 ) Change subject: Only store initialConfig in demo mode .. Only store initialConfig in demo mode Bug: T177693 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...ContentTranslation[master]: Message widget fixes

2017-10-07 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/382969 ) Change subject: Message widget fixes .. Message widget fixes * Use position:relative to icons are placed correctly * Fix alignment using

[MediaWiki-commits] [Gerrit] mediawiki...ContentTranslation[master]: Use OOUI buttons for discard/continue translation

2017-10-06 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/382742 ) Change subject: Use OOUI buttons for discard/continue translation .. Use OOUI buttons for discard/continue translation Removes the need

[MediaWiki-commits] [Gerrit] oojs/ui[master]: TextInpuWidget: Use child selector for icons/indicators/labels

2017-10-06 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/382738 ) Change subject: TextInpuWidget: Use child selector for icons/indicators/labels .. TextInpuWidget: Use child selector for

[MediaWiki-commits] [Gerrit] mediawiki...ContentTranslation[master]: Remove unnecessary 'ease' value

2017-10-06 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/382731 ) Change subject: Remove unnecessary 'ease' value .. Remove unnecessary 'ease' value 'ease' in the default transition value. Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...ContentTranslation[master]: Use 100ms for background hover transition, not 1s

2017-10-06 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/382688 ) Change subject: Use 100ms for background hover transition, not 1s .. Use 100ms for background hover transition, not 1s This is what all

[MediaWiki-commits] [Gerrit] mediawiki...ContentTranslation[master]: Use upstream OOUI icon for list images

2017-10-06 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/382687 ) Change subject: Use upstream OOUI icon for list images .. Use upstream OOUI icon for list images No need to keep a downstream copy after

[MediaWiki-commits] [Gerrit] mediawiki...ContentTranslation[master]: Fix typos

2017-10-05 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/382515 ) Change subject: Fix typos .. Fix typos Change-Id: Ia5e35f63317363ef510972f330f8ff312d329438 --- M

[MediaWiki-commits] [Gerrit] mediawiki...ContentTranslation[master]: Use float clearing on sections

2017-10-05 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/382509 ) Change subject: Use float clearing on sections .. Use float clearing on sections ...instead of trying to reset the float property of an

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Target teardown refactor

2017-10-05 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/382488 ) Change subject: Target teardown refactor .. Target teardown refactor * Rename 'deactivate' to 'tryDeactivate' as it may prompts the

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Cleanup target teardown API

2017-10-05 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/382485 ) Change subject: Cleanup target teardown API .. Cleanup target teardown API Separate teardown from destroy, as MW targets do the former

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Use destroy event to teardown new section inputs

2017-10-05 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/382487 ) Change subject: Use destroy event to teardown new section inputs .. Use destroy event to teardown new section inputs Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Use parent #clearSurfaces method to clear surfaces

2017-10-05 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/382486 ) Change subject: Use parent #clearSurfaces method to clear surfaces .. Use parent #clearSurfaces method to clear surfaces Move mwTocWidget

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Move 'parentheses' message to MWSaveDialog's modules

2017-10-05 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/382428 ) Change subject: Move 'parentheses' message to MWSaveDialog's modules .. Move 'parentheses' message to MWSaveDialog's modules Bug: T177446

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Abort loading when 'escape' is pressed

2017-10-04 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/382158 ) Change subject: Abort loading when 'escape' is pressed .. Abort loading when 'escape' is pressed Bug: T117359 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...ContentTranslation[master]: Use item.getData to get string title

2017-10-03 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/382008 ) Change subject: Use item.getData to get string title .. Use item.getData to get string title item.getLabel can give you a jQuery

[MediaWiki-commits] [Gerrit] mediawiki...TemplateData[master]: Update language search widget from VE

2017-10-03 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/382005 ) Change subject: Update language search widget from VE .. Update language search widget from VE Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...TemplateData[master]: build: Update linters

2017-10-03 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/382002 ) Change subject: build: Update linters .. build: Update linters Change-Id: Idb5705ef24c0731c47f33b310a9a3fb2fa5f2227 --- M

[MediaWiki-commits] [Gerrit] mediawiki...TemplateSandbox[master]: build: Update linters

2017-10-03 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/382001 ) Change subject: build: Update linters .. build: Update linters Change-Id: I2ae8cf08730962485a9b25a6d617494d11fef633 --- M package.json 1

[MediaWiki-commits] [Gerrit] mediawiki...TemplateStyles[master]: build: Update eslint

2017-10-03 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/382000 ) Change subject: build: Update eslint .. build: Update eslint Change-Id: I690ef5856e2dbbd86522c01aea94e74a8b69a7e6 --- M package.json 1

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: TitleOptionWidget: Don't show an icon when showImages=false

2017-10-03 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/381999 ) Change subject: TitleOptionWidget: Don't show an icon when showImages=false .. TitleOptionWidget: Don't show an icon when showImages=false

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: TitleWidget: Only apply padding fix to withImages mode

2017-10-03 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/381996 ) Change subject: TitleWidget: Only apply padding fix to withImages mode .. TitleWidget: Only apply padding fix to withImages mode

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: mw.widgets.SearchInputWidget: Avoid overriding getOptionWidg...

2017-10-03 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/381992 ) Change subject: mw.widgets.SearchInputWidget: Avoid overriding getOptionWidgetData .. mw.widgets.SearchInputWidget: Avoid overriding

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Always use trackingName for tracking

2017-10-02 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/381880 ) Change subject: Always use trackingName for tracking .. Always use trackingName for tracking Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...Kartographer[master]: Use self closing tags when empty, and allow for mwData.body ...

2017-10-02 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/381797 ) Change subject: Use self closing tags when empty, and allow for mwData.body being null .. Use self closing tags when empty, and allow for

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Allow extensions to use self closing tags

2017-10-02 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/381796 ) Change subject: Allow extensions to use self closing tags .. Allow extensions to use self closing tags Parsoid now supports this by

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Follow-up Iea80013: Re-define this.$bounding after GCN re-re...

2017-10-02 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/381789 ) Change subject: Follow-up Iea80013: Re-define this.$bounding after GCN re-render .. Follow-up Iea80013: Re-define this.$bounding after GCN

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: MWExtensionWindow: Always send a string to setValueAndWhites...

2017-10-02 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/381788 ) Change subject: MWExtensionWindow: Always send a string to setValueAndWhitespace .. MWExtensionWindow: Always send a string to

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: MWAlienExtensionNode: Listen to attribute changes

2017-10-02 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/381786 ) Change subject: MWAlienExtensionNode: Listen to attribute changes .. MWAlienExtensionNode: Listen to attribute changes Also: * Disconnect

[MediaWiki-commits] [Gerrit] oojs/ui[master]: Follow-up I576f31: highlightQuery: Handle case when query is...

2017-10-02 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/381754 ) Change subject: Follow-up I576f31: highlightQuery: Handle case when query is not found .. Follow-up I576f31: highlightQuery: Handle case

[MediaWiki-commits] [Gerrit] oojs/ui[master]: LabelElement: Add tests for setHighlightedQuery

2017-10-02 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/381755 ) Change subject: LabelElement: Add tests for setHighlightedQuery .. LabelElement: Add tests for setHighlightedQuery Also remove

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: TitleWidget: Perform diacritic-insensitive highlighting

2017-10-01 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/381637 ) Change subject: TitleWidget: Perform diacritic-insensitive highlighting .. TitleWidget: Perform diacritic-insensitive highlighting

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: TitleWidget: Use OOUI query highlighting, instead of jQuery lib

2017-10-01 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/381636 ) Change subject: TitleWidget: Use OOUI query highlighting, instead of jQuery lib .. TitleWidget: Use OOUI query highlighting, instead of

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Remove upstreamed link inspector page icons

2017-09-29 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/381475 ) Change subject: Remove upstreamed link inspector page icons .. Remove upstreamed link inspector page icons Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Tweak layout of TitleWidget results

2017-09-29 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/381463 ) Change subject: Tweak layout of TitleWidget results .. Tweak layout of TitleWidget results Bug: T177085 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...Score[master]: Set padded=false for score inspector

2017-09-29 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/381459 ) Change subject: Set padded=false for score inspector .. Set padded=false for score inspector Logically depends on I615b485a272. Bug:

[MediaWiki-commits] [Gerrit] mediawiki...Citoid[master]: Set padded=false for citoid inspector

2017-09-29 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/381458 ) Change subject: Set padded=false for citoid inspector .. Set padded=false for citoid inspector Logically depends on I615b485a272. Bug:

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Set padded=false for link inspector

2017-09-29 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/381457 ) Change subject: Set padded=false for link inspector .. Set padded=false for link inspector Logically depends on I615b485a272. Bug:

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Make a clear API for setting inspector padding

2017-09-29 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/381455 ) Change subject: Make a clear API for setting inspector padding .. Make a clear API for setting inspector padding Bug: T177080 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: TitleWidget: Upstream generic page icons from VE

2017-09-29 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/381451 ) Change subject: TitleWidget: Upstream generic page icons from VE .. TitleWidget: Upstream generic page icons from VE Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Revert "CSSMin: Mangle whitespace in embedded SVGs"

2017-09-29 Thread Esanders (Code Review)
Hello Krinkle, Catrope, Platonides, jenkins-bot, I'd like you to do a code review. Please visit https://gerrit.wikimedia.org/r/381443 to review the following change. Change subject: Revert "CSSMin: Mangle whitespace in embedded SVGs"

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Follow-up Ia08dbb44: $attachable -> $bounding

2017-09-28 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/381245 ) Change subject: Follow-up Ia08dbb44: $attachable -> $bounding .. Follow-up Ia08dbb44: $attachable -> $bounding Change-Id:

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Follow-up Iea80013: $attachable -> $bounding

2017-09-28 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/381244 ) Change subject: Follow-up Iea80013: $attachable -> $bounding .. Follow-up Iea80013: $attachable -> $bounding Change-Id:

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Detach icon before updateInvisibleIcon

2017-09-28 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/381239 ) Change subject: Detach icon before updateInvisibleIcon .. Detach icon before updateInvisibleIcon Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Ensure mw-notification-area doesn't get disabled

2017-09-27 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/380977 ) Change subject: Ensure mw-notification-area doesn't get disabled .. Ensure mw-notification-area doesn't get disabled Bug: T176874

[MediaWiki-commits] [Gerrit] mediawiki...ContentTranslation[master]: Rename mw.cx.ui.TranslationView to ve.init.mw.CXTarget

2017-09-26 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/380883 ) Change subject: Rename mw.cx.ui.TranslationView to ve.init.mw.CXTarget .. Rename mw.cx.ui.TranslationView to ve.init.mw.CXTarget There is

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: ve.ce.Surface: Fix typo in documentation

2017-09-26 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/380820 ) Change subject: ve.ce.Surface: Fix typo in documentation .. ve.ce.Surface: Fix typo in documentation Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Follow-up Iebd1def1: Revert MWSignatureTool case

2017-09-26 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/380819 ) Change subject: Follow-up Iebd1def1: Revert MWSignatureTool case .. Follow-up Iebd1def1: Revert MWSignatureTool case The tool checks the

[MediaWiki-commits] [Gerrit] mediawiki...ContentTranslation[master]: Remove duplicated code in PageSelectorWidget

2017-09-26 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/380783 ) Change subject: Remove duplicated code in PageSelectorWidget .. Remove duplicated code in PageSelectorWidget Made possible by extra

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Make mw.widget.TitleWidget more flexible

2017-09-26 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/380782 ) Change subject: Make mw.widget.TitleWidget more flexible .. Make mw.widget.TitleWidget more flexible * Factor out #createOptionWidget so

[MediaWiki-commits] [Gerrit] mediawiki...ContentTranslation[master]: Ensure target#pageName is updated when targetTitle is changed

2017-09-26 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/380732 ) Change subject: Ensure target#pageName is updated when targetTitle is changed .. Ensure target#pageName is updated when targetTitle is

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Replace wg(Relevant)PageName with target#pageName

2017-09-26 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/380731 ) Change subject: Replace wg(Relevant)PageName with target#pageName .. Replace wg(Relevant)PageName with target#pageName The default value

[MediaWiki-commits] [Gerrit] mediawiki...ContentTranslation[master]: Use converter to generate HTML from source for translation

2017-09-25 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/380558 ) Change subject: Use converter to generate HTML from source for translation .. Use converter to generate HTML from source for translation

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Set bounding element to full frame for MW images

2017-09-25 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/380539 ) Change subject: Set bounding element to full frame for MW images .. Set bounding element to full frame for MW images Logically depends on

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Allow focusable nodes to define an element to be their bound...

2017-09-25 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/380538 ) Change subject: Allow focusable nodes to define an element to be their bounding box .. Allow focusable nodes to define an element to be

[MediaWiki-commits] [Gerrit] mediawiki...Timeless[master]: VE: Fix font sizes and toolbar position

2017-09-25 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/380468 ) Change subject: VE: Fix font sizes and toolbar position .. VE: Fix font sizes and toolbar position Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...ContentTranslation[master]: Fix single-line eslint exceptions

2017-09-25 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/380454 ) Change subject: Fix single-line eslint exceptions .. Fix single-line eslint exceptions As written they were disabling the rules for the

[MediaWiki-commits] [Gerrit] mediawiki...cxserver[master]: Remove eslint exceptions and make pass

2017-09-22 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/379797 ) Change subject: Remove eslint exceptions and make pass .. Remove eslint exceptions and make pass Most of these rules are adhered to

[MediaWiki-commits] [Gerrit] mediawiki...cxserver[master]: Fix eslint path: tests -> test

2017-09-22 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/379796 ) Change subject: Fix eslint path: tests -> test .. Fix eslint path: tests -> test Also fix resulting lint failures. Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...cxserver[master]: Fix single-line eslint exceptions

2017-09-22 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/379791 ) Change subject: Fix single-line eslint exceptions .. Fix single-line eslint exceptions As written they were disabling the rules for the

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Highlight locale substring match in language search

2017-09-22 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/379779 ) Change subject: Highlight locale substring match in language search .. Highlight locale substring match in language search Logically

[MediaWiki-commits] [Gerrit] oojs/ui[master]: Suport locale comparison in LabelElement#highlightQuery

2017-09-22 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/379778 ) Change subject: Suport locale comparison in LabelElement#highlightQuery .. Suport locale comparison in LabelElement#highlightQuery

[MediaWiki-commits] [Gerrit] VisualEditor/VisualEditor[master]: Use diacritic insensitive search in language search dialog

2017-09-22 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/379777 ) Change subject: Use diacritic insensitive search in language search dialog .. Use diacritic insensitive search in language search dialog

[MediaWiki-commits] [Gerrit] mediawiki...ContentTranslation[master]: Fix width of sub-heading

2017-09-22 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/379733 ) Change subject: Fix width of sub-heading .. Fix width of sub-heading .flex-center-justify resets width to auto from 100% so put it first.

[MediaWiki-commits] [Gerrit] mediawiki...ContentTranslation[master]: Wait for document render before first alignment

2017-09-22 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/379732 ) Change subject: Wait for document render before first alignment .. Wait for document render before first alignment Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...ContentTranslation[master]: Fix toolbar initialization (fixes tool width)

2017-09-22 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/379723 ) Change subject: Fix toolbar initialization (fixes tool width) .. Fix toolbar initialization (fixes tool width) * Initialize toolbar after

[MediaWiki-commits] [Gerrit] mediawiki...ContentTranslation[master]: Convert publishSettings widget to a toolbar group

2017-09-21 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/379606 ) Change subject: Convert publishSettings widget to a toolbar group .. Convert publishSettings widget to a toolbar group Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...ContentTranslation[master]: Add help and document options menu to toolbar

2017-09-21 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/379585 ) Change subject: Add help and document options menu to toolbar .. Add help and document options menu to toolbar Document options gives

[MediaWiki-commits] [Gerrit] mediawiki...ContentTranslation[master]: Use #setupToolbar method to prepare publish button

2017-09-21 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/379581 ) Change subject: Use #setupToolbar method to prepare publish button .. Use #setupToolbar method to prepare publish button Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...ContentTranslation[master]: Avoid using parseInt

2017-09-21 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/379551 ) Change subject: Avoid using parseInt .. Avoid using parseInt * For string conversion, the unary operator '+' is faster and handles all

[MediaWiki-commits] [Gerrit] mediawiki...cxserver[master]: Avoid using parseInt

2017-09-21 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/379550 ) Change subject: Avoid using parseInt .. Avoid using parseInt * For string conversion, the unary operator '+' is faster and handles all

[MediaWiki-commits] [Gerrit] mediawiki...ContentTranslation[master]: Fix typo

2017-09-21 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/379549 ) Change subject: Fix typo .. Fix typo Change-Id: I65a170a70ef6a2f4fd7cbce1c82abb575f3bf966 --- M modules/mw.cx.TranslationController.js 1

[MediaWiki-commits] [Gerrit] mediawiki...VisualEditor[master]: Fix font size in local overlays in monobook

2017-09-21 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/379548 ) Change subject: Fix font size in local overlays in monobook .. Fix font size in local overlays in monobook Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...ContentTranslation[master]: Remove source sectionNode opacity override

2017-09-21 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/379542 ) Change subject: Remove source sectionNode opacity override .. Remove source sectionNode opacity override No longer required as the

[MediaWiki-commits] [Gerrit] mediawiki...ContentTranslation[master]: Separate skin-specific fixes out, and fix monobook font sizes

2017-09-21 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/379541 ) Change subject: Separate skin-specific fixes out, and fix monobook font sizes .. Separate skin-specific fixes out, and fix monobook font

[MediaWiki-commits] [Gerrit] mediawiki...ContentTranslation[master]: Fix vertical alignment of cx-spinner

2017-09-20 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/379255 ) Change subject: Fix vertical alignment of cx-spinner .. Fix vertical alignment of cx-spinner Change-Id:

<    1   2   3   4   5   6   7   8   9   10   >