[MediaWiki-commits] [Gerrit] Add .jshintrc - change (mediawiki...TemplateData)

2014-01-10 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/106782 Change subject: Add .jshintrc .. Add .jshintrc Change-Id: Ia0df2fa9b2708a7b671052225e8a41094ae19522 --- A .jshintrc 1 file changed, 32

[MediaWiki-commits] [Gerrit] Add mwext-TemplateData-qunit - change (integration/jenkins-job-builder-config)

2014-01-10 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/106783 Change subject: Add mwext-TemplateData-qunit .. Add mwext-TemplateData-qunit Change-Id: I78b948aa0eaede430f887db8e805dc22c8948e23 --- M

[MediaWiki-commits] [Gerrit] Enable mwext-TemplateData-qunit - change (integration/zuul-config)

2014-01-10 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/106859 Change subject: Enable mwext-TemplateData-qunit .. Enable mwext-TemplateData-qunit Change-Id: I1053812d8acfe911526edfa5dba99c3ca08437d6 ---

[MediaWiki-commits] [Gerrit] Sample commit for Jenkins - change (mediawiki...TemplateData)

2014-01-10 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/106860 Change subject: Sample commit for Jenkins .. Sample commit for Jenkins Change-Id: Idd86dd57c72cd431e60f838914c17ac354b7616f --- A .jenkins

[MediaWiki-commits] [Gerrit] Remove unused ve-init-mw-viewPageTarget-transform-hidden - change (mediawiki...VisualEditor)

2014-01-13 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/107194 Change subject: Remove unused ve-init-mw-viewPageTarget-transform-hidden .. Remove unused ve-init-mw-viewPageTarget-transform-hidden

[MediaWiki-commits] [Gerrit] localsettings.js.example: Fix whitespace (mixed tabs and spa... - change (mediawiki...parsoid)

2014-01-13 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/107209 Change subject: localsettings.js.example: Fix whitespace (mixed tabs and spaces) .. localsettings.js.example: Fix whitespace (mixed tabs and

[MediaWiki-commits] [Gerrit] [WIP] Implement MWTemplateDialog (simplified MWTransclusionD... - change (mediawiki...VisualEditor)

2014-01-13 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/107275 Change subject: [WIP] Implement MWTemplateDialog (simplified MWTransclusionDialog) .. [WIP] Implement MWTemplateDialog (simplified

[MediaWiki-commits] [Gerrit] Add OOjs to jsduck index - change (mediawiki/core)

2014-01-15 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/107760 Change subject: Add OOjs to jsduck index .. Add OOjs to jsduck index Change-Id: I7ced3673a0a09ea0f37b59729318f02e52fe1340 --- M

[MediaWiki-commits] [Gerrit] Improve mediawiki.js documentation - change (mediawiki/core)

2014-01-15 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/107761 Change subject: Improve mediawiki.js documentation .. Improve mediawiki.js documentation Incorporate some of the edits made to the old

[MediaWiki-commits] [Gerrit] Fix jsduck publish errors (GERRIT_BRANCH - ZUUL_BRANCH) - change (integration/jenkins-job-builder-config)

2014-01-16 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/107860 Change subject: Fix jsduck publish errors (GERRIT_BRANCH - ZUUL_BRANCH) .. Fix jsduck publish errors (GERRIT_BRANCH - ZUUL_BRANCH) The

[MediaWiki-commits] [Gerrit] ve.init.Target: Fix $document property documentation - change (VisualEditor/VisualEditor)

2014-01-16 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/107863 Change subject: ve.init.Target: Fix $document property documentation .. ve.init.Target: Fix $document property documentation It was indexed

[MediaWiki-commits] [Gerrit] Clean up and doc fixes (submodule update) - change (mediawiki...VisualEditor)

2014-01-16 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/107866 Change subject: Clean up and doc fixes (submodule update) .. Clean up and doc fixes (submodule update) * Remove odd comment and move node

[MediaWiki-commits] [Gerrit] Fix jsduck publish errors for mediawiki-core (GERRIT_BRANCH ... - change (integration/jenkins-job-builder-config)

2014-01-16 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/107879 Change subject: Fix jsduck publish errors for mediawiki-core (GERRIT_BRANCH - ZUUL_BRANCH) .. Fix jsduck publish errors for mediawiki-core

[MediaWiki-commits] [Gerrit] jsduck: Fix script loading issues with eg-iframe in production - change (mediawiki...VisualEditor)

2014-01-16 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/107902 Change subject: jsduck: Fix script loading issues with eg-iframe in production .. jsduck: Fix script loading issues with eg-iframe in

[MediaWiki-commits] [Gerrit] mwext-VisualEditor-doc: Update publish and test to match new... - change (integration/jenkins-job-builder-config)

2014-01-16 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/107905 Change subject: mwext-VisualEditor-doc: Update publish and test to match new logistics .. mwext-VisualEditor-doc: Update publish and test

[MediaWiki-commits] [Gerrit] mwext-VisualEditor-doc: Fixup path changes from 69ec1bc - change (integration/jenkins-job-builder-config)

2014-01-17 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/108049 Change subject: mwext-VisualEditor-doc: Fixup path changes from 69ec1bc .. mwext-VisualEditor-doc: Fixup path changes from 69ec1bc It is no

[MediaWiki-commits] [Gerrit] [WIP] Support JSDuck v5.x - change (mediawiki/core)

2014-01-17 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/108053 Change subject: [WIP] Support JSDuck v5.x .. [WIP] Support JSDuck v5.x Experimental, don't merge! Wikimedia Jenkins still uses JSDuck v4.x

[MediaWiki-commits] [Gerrit] api: Passthrough $data directly instead of copying by property - change (mediawiki...TemplateData)

2014-01-17 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/108052 Change subject: api: Passthrough $data directly instead of copying by property .. api: Passthrough $data directly instead of copying by

[MediaWiki-commits] [Gerrit] Tag v1.0.7 - change (oojs/core)

2014-01-21 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/108875 Change subject: Tag v1.0.7 .. Tag v1.0.7 Change-Id: I9dc1d4e9a6317c16ab114cecd9a86a73c53de65c --- M History.md M package.json 2 files

[MediaWiki-commits] [Gerrit] ve.dm.MWTransclusionModel: Clean up and fix logic error - change (mediawiki...VisualEditor)

2014-01-22 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/108956 Change subject: ve.dm.MWTransclusionModel: Clean up and fix logic error .. ve.dm.MWTransclusionModel: Clean up and fix logic error * Reduce

[MediaWiki-commits] [Gerrit] resourceloader: Update cssjanus to v1.1.1 - change (mediawiki/core)

2014-11-19 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/174593 Change subject: resourceloader: Update cssjanus to v1.1.1 .. resourceloader: Update cssjanus to v1.1.1 Bug: 61440 Change-Id:

[MediaWiki-commits] [Gerrit] Update cssjanus to v1.1.1 - change (mediawiki/vendor)

2014-11-19 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/174610 Change subject: Update cssjanus to v1.1.1 .. Update cssjanus to v1.1.1 Per Id0221e9f68 in mediawiki-core. Change-Id:

[MediaWiki-commits] [Gerrit] jsduck: Remove redundant hack that searched jsduck.log for ... - change (integration/config)

2014-11-19 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/174619 Change subject: jsduck: Remove redundant hack that searched jsduck.log for Warning .. jsduck: Remove redundant hack that searched jsduck.log

[MediaWiki-commits] [Gerrit] ve.ce.MWMathNode: Remove reference to defunct ve.bind - change (mediawiki...Math)

2014-11-19 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/174622 Change subject: ve.ce.MWMathNode: Remove reference to defunct ve.bind .. ve.ce.MWMathNode: Remove reference to defunct ve.bind Bug: 73627

[MediaWiki-commits] [Gerrit] [WIP] Experimental mediawiki-core-qunit-labsSlave - change (integration/config)

2014-11-20 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/174731 Change subject: [WIP] Experimental mediawiki-core-qunit-labsSlave .. [WIP] Experimental mediawiki-core-qunit-labsSlave Don't merge. This is

[MediaWiki-commits] [Gerrit] [WIP] Debug QUnit race condition - change (mediawiki/core)

2014-11-20 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/174738 Change subject: [WIP] Debug QUnit race condition .. [WIP] Debug QUnit race condition Change-Id: I41058c4cba3383e3ad1456990ccf8dae4ca64951

[MediaWiki-commits] [Gerrit] mediawiki: Configure 'error' and 'exception' log groups - change (integration/jenkins)

2014-11-20 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/174810 Change subject: mediawiki: Configure 'error' and 'exception' log groups .. mediawiki: Configure 'error' and 'exception' log groups Also add

[MediaWiki-commits] [Gerrit] Enforce coding style - change (labs...guc)

2014-11-20 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/174894 Change subject: Enforce coding style .. Enforce coding style * Trim trailing whitespace. * Convert Windows (CR) to Git native new lines

[MediaWiki-commits] [Gerrit] settings: Read config from replica.my.cnf - change (labs...guc)

2014-11-20 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/174903 Change subject: settings: Read config from replica.my.cnf .. settings: Read config from replica.my.cnf Change-Id:

[MediaWiki-commits] [Gerrit] gitignore: Ignore cache/*.json - change (labs...guc)

2014-11-20 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/174904 Change subject: gitignore: Ignore cache/*.json .. gitignore: Ignore cache/*.json These shouldn't cause a local git clone to have local

[MediaWiki-commits] [Gerrit] settings: Read config from replica.my.cnf - change (labs...guc)

2014-11-20 Thread Krinkle (Code Review)
Krinkle has submitted this change and it was merged. Change subject: settings: Read config from replica.my.cnf .. settings: Read config from replica.my.cnf Change-Id: I26da65203c064e5cc87760a6847dbe18e91ccc96 --- M

[MediaWiki-commits] [Gerrit] Enforce coding style - change (labs...guc)

2014-11-20 Thread Krinkle (Code Review)
Krinkle has submitted this change and it was merged. Change subject: Enforce coding style .. Enforce coding style * Trim trailing whitespace. * Convert Windows (CR) to Git native new lines (LF). * Set up composer-test and

[MediaWiki-commits] [Gerrit] gitignore: Ignore cache/*.json - change (labs...guc)

2014-11-20 Thread Krinkle (Code Review)
Krinkle has submitted this change and it was merged. Change subject: gitignore: Ignore cache/*.json .. gitignore: Ignore cache/*.json These shouldn't cause a local git clone to have local changes. Change-Id:

[MediaWiki-commits] [Gerrit] composer: Rename package to 'oojs-ui' and require php 5.3.3 - change (oojs/ui)

2014-11-21 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/175177 Change subject: composer: Rename package to 'oojs-ui' and require php 5.3.3 .. composer: Rename package to 'oojs-ui' and require php 5.3.3

[MediaWiki-commits] [Gerrit] build: Set up phplint and phpunit via composer-test - change (cdb)

2014-11-24 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/175444 Change subject: build: Set up phplint and phpunit via composer-test .. build: Set up phplint and phpunit via composer-test Change-Id:

[MediaWiki-commits] [Gerrit] build: Add .npmignore - change (oojs/ui)

2014-11-24 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/175625 Change subject: build: Add .npmignore .. build: Add .npmignore Copy of .gitignore, but without the npm strict defaults, and most importantly

[MediaWiki-commits] [Gerrit] Tag v0.2.2 - change (oojs/ui)

2014-11-24 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/175627 Change subject: Tag v0.2.2 .. Tag v0.2.2 Change-Id: I741d18190e150f3e1d270bcfd4a01079885fb78f --- M History.md M package.json 2 files

[MediaWiki-commits] [Gerrit] Update OOjs UI to v0.2.2 - change (mediawiki/core)

2014-11-24 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/175631 Change subject: Update OOjs UI to v0.2.2 .. Update OOjs UI to v0.2.2 Release notes:

[MediaWiki-commits] [Gerrit] Maintenance: Simplify reading of package.json by using requi... - change (mediawiki/core)

2014-11-24 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/175650 Change subject: Maintenance: Simplify reading of package.json by using require() .. Maintenance: Simplify reading of package.json by using

[MediaWiki-commits] [Gerrit] Migrate jQuery andSelf() to addBack() - change (mediawiki...MultimediaViewer)

2014-11-24 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/175654 Change subject: Migrate jQuery andSelf() to addBack() .. Migrate jQuery andSelf() to addBack() Deprecated in jQuery 1.8

[MediaWiki-commits] [Gerrit] Use gmmktime instead of strtotime - change (mediawiki...CentralNotice)

2014-11-25 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/175907 Change subject: Use gmmktime instead of strtotime .. Use gmmktime instead of strtotime In MediaWiki settings are loaded before MediaWiki has

[MediaWiki-commits] [Gerrit] require_once is not a function - change (mediawiki...BounceHandler)

2014-11-25 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/175929 Change subject: require_once is not a function .. require_once is not a function Similar to 'echo' in that regard. The parentheses merely

[MediaWiki-commits] [Gerrit] Remove '@section LICENSE' - change (mediawiki/core)

2014-11-25 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/175932 Change subject: Remove '@section LICENSE' .. Remove '@section LICENSE' This was used in 2 special classes, the logger classes and spread to

[MediaWiki-commits] [Gerrit] mediawiki-core-qunit: Add archive-log-dir publisher - change (integration/config)

2014-11-25 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/175947 Change subject: mediawiki-core-qunit: Add archive-log-dir publisher .. mediawiki-core-qunit: Add archive-log-dir publisher

[MediaWiki-commits] [Gerrit] build: Upgrade grunt-jscs and remove legacy jshint camelcase... - change (mediawiki/core)

2014-11-25 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/175948 Change subject: build: Upgrade grunt-jscs and remove legacy jshint camelcase/nomen .. build: Upgrade grunt-jscs and remove legacy jshint

[MediaWiki-commits] [Gerrit] mediawiki.util: Remove test for jsMessage - change (mediawiki/core)

2014-11-25 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/175949 Change subject: mediawiki.util: Remove test for jsMessage .. mediawiki.util: Remove test for jsMessage jsMessage uses mw.notify, which

[MediaWiki-commits] [Gerrit] EventEmitter: Simplify #validateMethod and increase test cov... - change (oojs/core)

2014-11-05 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/171312 Change subject: EventEmitter: Simplify #validateMethod and increase test coverage .. EventEmitter: Simplify #validateMethod and increase

[MediaWiki-commits] [Gerrit] EventEmitter: Use hasOwn check in #off - change (oojs/core)

2014-11-05 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/171311 Change subject: EventEmitter: Use hasOwn check in #off .. EventEmitter: Use hasOwn check in #off * Add regression test. Change-Id:

[MediaWiki-commits] [Gerrit] test: Apply Sanitizer::decodeCharReferences for clearer tests - change (mediawiki...TemplateData)

2014-11-08 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/172042 Change subject: test: Apply Sanitizer::decodeCharReferences for clearer tests .. test: Apply Sanitizer::decodeCharReferences for clearer

[MediaWiki-commits] [Gerrit] WikiPage: Remove premature Content::isValid check - change (mediawiki/core)

2014-12-01 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/176845 Change subject: WikiPage: Remove premature Content::isValid check .. WikiPage: Remove premature Content::isValid check Content classes that

[MediaWiki-commits] [Gerrit] content: Minor clean up to make JsonContent match other classes - change (mediawiki/core)

2014-12-01 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/176852 Change subject: content: Minor clean up to make JsonContent match other classes .. content: Minor clean up to make JsonContent match other

[MediaWiki-commits] [Gerrit] content: Add validation for JavaScriptContent - change (mediawiki/core)

2014-12-01 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/176853 Change subject: content: Add validation for JavaScriptContent .. content: Add validation for JavaScriptContent Bug: T76204 Change-Id:

[MediaWiki-commits] [Gerrit] Icon: Remove confusing '0' argument to '.children()' - change (mediawiki...MobileFrontend)

2014-12-01 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/176872 Change subject: Icon: Remove confusing '0' argument to '.children()' .. Icon: Remove confusing '0' argument to '.children()' .children()

[MediaWiki-commits] [Gerrit] redlinks: Move contents instead of serialising/reparsing html - change (mediawiki...MobileFrontend)

2014-12-01 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/176873 Change subject: redlinks: Move contents instead of serialising/reparsing html .. redlinks: Move contents instead of serialising/reparsing

[MediaWiki-commits] [Gerrit] Fix Jenkins condition in entry file - change (mediawiki...Wikibase)

2014-12-01 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/176882 Change subject: Fix Jenkins condition in entry file .. Fix Jenkins condition in entry file Follows-up 6be762858a. The error message was,

[MediaWiki-commits] [Gerrit] mediawiki.Uri: Implement support for a mutable defaultUri - change (mediawiki/core)

2014-12-02 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/177076 Change subject: mediawiki.Uri: Implement support for a mutable defaultUri .. mediawiki.Uri: Implement support for a mutable defaultUri Bug:

[MediaWiki-commits] [Gerrit] exception: Hide suppressed errors in 'error' log, flag in 'e... - change (mediawiki/core)

2014-12-02 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/177096 Change subject: exception: Hide suppressed errors in 'error' log, flag in 'error-json' .. exception: Hide suppressed errors in 'error' log,

[MediaWiki-commits] [Gerrit] exception: Implement error-json log - change (mediawiki/core)

2014-12-02 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/177095 Change subject: exception: Implement error-json log .. exception: Implement error-json log Follows-up 399ba2f. Bug: T75619 Change-Id:

[MediaWiki-commits] [Gerrit] gerrit: Output space in commentlink commit before the link - change (operations/puppet)

2014-12-02 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/177106 Change subject: gerrit: Output space in commentlink commit before the link .. gerrit: Output space in commentlink commit before the link

[MediaWiki-commits] [Gerrit] gerrit: Don't match Phabricator identifiers within urls - change (operations/puppet)

2014-12-02 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/177128 Change subject: gerrit: Don't match Phabricator identifiers within urls .. gerrit: Don't match Phabricator identifiers within urls Sample *

[MediaWiki-commits] [Gerrit] content: Recognise .json as JsonContent User and MediaWiki n... - change (mediawiki/core)

2014-12-02 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/177172 Change subject: content: Recognise .json as JsonContent User and MediaWiki namespace .. content: Recognise .json as JsonContent User and

[MediaWiki-commits] [Gerrit] content: Re-arange tests to declare data provider first - change (mediawiki/core)

2014-12-02 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/177170 Change subject: content: Re-arange tests to declare data provider first .. content: Re-arange tests to declare data provider first For

[MediaWiki-commits] [Gerrit] content: Refactor and fix various bugs in JsonContent - change (mediawiki/core)

2014-12-02 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/177171 Change subject: content: Refactor and fix various bugs in JsonContent .. content: Refactor and fix various bugs in JsonContent Follows-up

[MediaWiki-commits] [Gerrit] content: Deprecate TitleIsCssOrJsPage and TitleIsWikitextPag... - change (mediawiki/core)

2014-12-02 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/177173 Change subject: content: Deprecate TitleIsCssOrJsPage and TitleIsWikitextPage hooks .. content: Deprecate TitleIsCssOrJsPage and

[MediaWiki-commits] [Gerrit] WIP: Refactor zuul layout templates - change (integration/config)

2014-12-02 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/177180 Change subject: WIP: Refactor zuul layout templates .. WIP: Refactor zuul layout templates Deprecate extension-unittests in favour of

[MediaWiki-commits] [Gerrit] Minor code clean up PHP and HTML files in w/ - change (operations/mediawiki-config)

2014-12-03 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/177459 Change subject: Minor code clean up PHP and HTML files in w/ .. Minor code clean up PHP and HTML files in w/ * Consistently use

[MediaWiki-commits] [Gerrit] Remove w/COPYING and w/CREDITS dead symlinks - change (operations/mediawiki-config)

2014-12-03 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/177476 Change subject: Remove w/COPYING and w/CREDITS dead symlinks .. Remove w/COPYING and w/CREDITS dead symlinks Not sure how useful these were

[MediaWiki-commits] [Gerrit] Create citoid-npm job and enable (non-voting) - change (integration/config)

2014-12-03 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/177484 Change subject: Create citoid-npm job and enable (non-voting) .. Create citoid-npm job and enable (non-voting) Change-Id:

[MediaWiki-commits] [Gerrit] package.json: Pin dependencies at a fixed version - change (mediawiki...citoid)

2014-12-03 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/177486 Change subject: package.json: Pin dependencies at a fixed version .. package.json: Pin dependencies at a fixed version Upgrade explicitly to

[MediaWiki-commits] [Gerrit] package.json: Point git-url to Git repository instead of Ger... - change (mediawiki...citoid)

2014-12-03 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/177485 Change subject: package.json: Point git-url to Git repository instead of Gerrit project page .. package.json: Point git-url to Git

[MediaWiki-commits] [Gerrit] package.json: Point git-url to Git repository instead of Ger... - change (mediawiki...citoid)

2014-12-03 Thread Krinkle (Code Review)
Krinkle has submitted this change and it was merged. Change subject: package.json: Point git-url to Git repository instead of Gerrit project page .. package.json: Point git-url to Git repository instead of Gerrit project page

[MediaWiki-commits] [Gerrit] package.json: Pin dependencies at a fixed version - change (mediawiki...citoid)

2014-12-03 Thread Krinkle (Code Review)
Krinkle has submitted this change and it was merged. Change subject: package.json: Pin dependencies at a fixed version .. package.json: Pin dependencies at a fixed version Upgrade explicitly to avoid silently upgrading to

[MediaWiki-commits] [Gerrit] robots.php: Fixup E_NOTICE undefined $stats - change (operations/mediawiki-config)

2014-12-12 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/179587 Change subject: robots.php: Fixup E_NOTICE undefined $stats .. robots.php: Fixup E_NOTICE undefined $stats Follows-up 611892c. Don't test

[MediaWiki-commits] [Gerrit] Remove $wgJavaScriptTestConfig - change (mediawiki/core)

2014-12-15 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/180116 Change subject: Remove $wgJavaScriptTestConfig .. Remove $wgJavaScriptTestConfig The config variable itself and the documentation property

[MediaWiki-commits] [Gerrit] Omit frontent and browsertest development files from release - change (mediawiki...release)

2014-12-15 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/180118 Change subject: Omit frontent and browsertest development files from release .. Omit frontent and browsertest development files from release

[MediaWiki-commits] [Gerrit] Minor clean up of release notes - change (mediawiki/core)

2014-12-16 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/180230 Change subject: Minor clean up of release notes .. Minor clean up of release notes * Consistently use 'Git' when referring to the system

[MediaWiki-commits] [Gerrit] Remove use of bind() for inline functions - change (mediawiki...VisualEditor)

2014-12-16 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/180301 Change subject: Remove use of bind() for inline functions .. Remove use of bind() for inline functions Follows-up b0e8900, 447e8de,

[MediaWiki-commits] [Gerrit] doc: Clean up Doxyfile for doxygen 1.8.6 - change (mediawiki/core)

2014-11-15 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/173502 Change subject: doc: Clean up Doxyfile for doxygen 1.8.6 .. doc: Clean up Doxyfile for doxygen 1.8.6 Latest stable is v1.8.8, but Ubunu

[MediaWiki-commits] [Gerrit] [WIP] contint: Add tmpfs mount in jenkins-deploy homedir for... - change (operations/puppet)

2014-11-15 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/173512 Change subject: [WIP] contint: Add tmpfs mount in jenkins-deploy homedir for labs slaves .. [WIP] contint: Add tmpfs mount in jenkins-deploy

[MediaWiki-commits] [Gerrit] contint: Move tmpfs Require to caller to support labs' jenki... - change (operations/puppet)

2014-11-15 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/173511 Change subject: contint: Move tmpfs Require to caller to support labs' jenkins-deploy .. contint: Move tmpfs Require to caller to support

[MediaWiki-commits] [Gerrit] mwconf: Remove references to pmtpa - change (integration/jenkins)

2014-11-15 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/173518 Change subject: mwconf: Remove references to pmtpa .. mwconf: Remove references to pmtpa Change-Id:

[MediaWiki-commits] [Gerrit] Document hasOwn optimisation - change (oojs/core)

2014-11-15 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/173521 Change subject: Document hasOwn optimisation .. Document hasOwn optimisation Change-Id: I3bc4310a4e85320cdb97d9a965584789c37b55c4 --- M

[MediaWiki-commits] [Gerrit] grunt: Remove unused --qunit-file option - change (integration/jenkins)

2014-11-15 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/173526 Change subject: grunt: Remove unused --qunit-file option .. grunt: Remove unused --qunit-file option Change-Id:

[MediaWiki-commits] [Gerrit] Migrate mediawiki/qunit jobs from production slaves to labs - change (integration/config)

2014-11-15 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/173529 Change subject: Migrate mediawiki/qunit jobs from production slaves to labs .. Migrate mediawiki/qunit jobs from production slaves to labs

[MediaWiki-commits] [Gerrit] [WIP] MWException: Log traces for php errors (not exceptions) - change (mediawiki/core)

2014-11-16 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/173642 Change subject: [WIP] MWException: Log traces for php errors (not exceptions) .. [WIP] MWException: Log traces for php errors (not

[MediaWiki-commits] [Gerrit] MWException: Log stack traces for php errors (not exceptions) - change (mediawiki/core)

2014-11-16 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/173645 Change subject: MWException: Log stack traces for php errors (not exceptions) .. MWException: Log stack traces for php errors (not

[MediaWiki-commits] [Gerrit] MWException: Log stack traces for php errors (not exceptions) - change (mediawiki/core)

2014-11-16 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/173646 Change subject: MWException: Log stack traces for php errors (not exceptions) .. MWException: Log stack traces for php errors (not

[MediaWiki-commits] [Gerrit] Declare 'error' log group - change (operations/mediawiki-config)

2014-11-16 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/173649 Change subject: Declare 'error' log group .. Declare 'error' log group Follows-up 399ba2fecf in mediawiki-core. Change-Id:

[MediaWiki-commits] [Gerrit] logstash: Update regex in 'exception' grokker - change (operations/puppet)

2014-11-16 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/173658 Change subject: logstash: Update regex in 'exception' grokker .. logstash: Update regex in 'exception' grokker Follows-up 399ba2fecf in

[MediaWiki-commits] [Gerrit] exception: Prefix error type in front of error message - change (mediawiki/core)

2014-11-16 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/173660 Change subject: exception: Prefix error type in front of error message .. exception: Prefix error type in front of error message Follows-up

[MediaWiki-commits] [Gerrit] Replaces spaces with tabs in en.json - change (mediawiki...VisualEditor)

2014-11-17 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/173969 Change subject: Replaces spaces with tabs in en.json .. Replaces spaces with tabs in en.json Bug: 72132 Change-Id:

[MediaWiki-commits] [Gerrit] autoloader: Remove incorrect documentation comment - change (mediawiki/core)

2014-11-18 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/174117 Change subject: autoloader: Remove incorrect documentation comment .. autoloader: Remove incorrect documentation comment Follows-up

[MediaWiki-commits] [Gerrit] diff: Fill background of transparent cells with white - change (mediawiki/core)

2014-11-18 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/174145 Change subject: diff: Fill background of transparent cells with white .. diff: Fill background of transparent cells with white In Vector the

[MediaWiki-commits] [Gerrit] profiler: Simplify code for class name mapping - change (mediawiki/core)

2014-11-18 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/174269 Change subject: profiler: Simplify code for class name mapping .. profiler: Simplify code for class name mapping Follows-up 000c6529d.

[MediaWiki-commits] [Gerrit] build: Clean up fileExists config - change (oojs/ui)

2014-11-18 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/174306 Change subject: build: Clean up fileExists config .. build: Clean up fileExists config Follows-up 7205b2a8. Avoid hardcoding invididual keys

[MediaWiki-commits] [Gerrit] Omit 'window.' when accessing browsing location - change (mediawiki/core)

2014-11-18 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/174321 Change subject: Omit 'window.' when accessing browsing location .. Omit 'window.' when accessing browsing location The location object is a

[MediaWiki-commits] [Gerrit] Consistently use location as global, and location.href for f... - change (mediawiki...VisualEditor)

2014-11-18 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/174324 Change subject: Consistently use location as global, and location.href for full url .. Consistently use location as global, and

[MediaWiki-commits] [Gerrit] resourceloader: Make arguments to mw.loader.implement optional - change (mediawiki/core)

2014-12-17 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/180659 Change subject: resourceloader: Make arguments to mw.loader.implement optional .. resourceloader: Make arguments to mw.loader.implement

[MediaWiki-commits] [Gerrit] build: Update devDependencies related to Karma - change (VisualEditor/VisualEditor)

2014-12-17 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/180682 Change subject: build: Update devDependencies related to Karma .. build: Update devDependencies related to Karma Minor improvements.

[MediaWiki-commits] [Gerrit] Add test to tolerate -composer instead of php-composer-validate - change (integration/config)

2014-12-17 Thread Krinkle (Code Review)
Krinkle has uploaded a new change for review. https://gerrit.wikimedia.org/r/180726 Change subject: Add test to tolerate -composer instead of php-composer-validate .. Add test to tolerate -composer instead of

  1   2   3   4   5   6   7   8   9   10   >