[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Localisation updates from https://translatewiki.net.

2016-09-26 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. https://gerrit.wikimedia.org/r/312849 Change subject: Localisation updates from https://translatewiki.net. .. Localisation updates from https://translatewiki.net. Change-Id: I

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Hygiene: remove dead code in LeadImagesHandler

2016-09-27 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. https://gerrit.wikimedia.org/r/313054 Change subject: Hygiene: remove dead code in LeadImagesHandler .. Hygiene: remove dead code in LeadImagesHandler Change-Id: I0794273f238a

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Hygiene: move MainActivity & Fragment to main pkg

2016-09-27 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. https://gerrit.wikimedia.org/r/313055 Change subject: Hygiene: move MainActivity & Fragment to main pkg .. Hygiene: move MainActivity & Fragment to main pkg MainActivity and M

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Hygiene: remove unused constructors

2016-09-01 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. https://gerrit.wikimedia.org/r/308101 Change subject: Hygiene: remove unused constructors .. Hygiene: remove unused constructors All FeedCardViews are constructed in Javaland,

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Add CardLargeHeaderViewTest

2016-09-01 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. https://gerrit.wikimedia.org/r/308105 Change subject: Add CardLargeHeaderViewTest .. Add CardLargeHeaderViewTest Bug: T144401 Change-Id: I2da84116a5d4d2e85b6fd704fe61b6d005494

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Update ViewTest to include system font size

2016-09-01 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. https://gerrit.wikimedia.org/r/308104 Change subject: Update ViewTest to include system font size .. Update ViewTest to include system font size Users may specify a font size

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Hygiene: remove commented out code

2016-09-01 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. https://gerrit.wikimedia.org/r/308102 Change subject: Hygiene: remove commented out code .. Hygiene: remove commented out code Change-Id: Ibfeb3541b03eaf1f96c2265d9512106aada0

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Hygiene: simplify CardLargeHeaderView

2016-09-01 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. https://gerrit.wikimedia.org/r/308103 Change subject: Hygiene: simplify CardLargeHeaderView .. Hygiene: simplify CardLargeHeaderView • Fix title for RTL. • Remove unused subt

[MediaWiki-commits] [Gerrit] integration/config[master]: Limit performance jobs IRC notification channels

2016-09-05 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. https://gerrit.wikimedia.org/r/308579 Change subject: Limit performance jobs IRC notification channels .. Limit performance jobs IRC notification channels The performance-webp

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Localisation updates from https://translatewiki.net.

2016-09-05 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. https://gerrit.wikimedia.org/r/308581 Change subject: Localisation updates from https://translatewiki.net. .. Localisation updates from https://translatewiki.net. Change-Id: I

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Reduce memory usage of Fragment pagers

2016-09-05 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. https://gerrit.wikimedia.org/r/308651 Change subject: Reduce memory usage of Fragment pagers .. Reduce memory usage of Fragment pagers Use FragmentStatePagerAdapter instead of

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Fix crash in reading lists screen

2016-09-05 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. https://gerrit.wikimedia.org/r/308652 Change subject: Fix crash in reading lists screen .. Fix crash in reading lists screen The default implementation of PagerAdapter.destroy

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Hygiene: use Butter Knife in ReadingListFragment

2016-09-05 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. https://gerrit.wikimedia.org/r/308653 Change subject: Hygiene: use Butter Knife in ReadingListFragment .. Hygiene: use Butter Knife in ReadingListFragment Change-Id: I0c5bebb4

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Hygiene: rename NavTabViewPagerAdapter

2016-09-05 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. https://gerrit.wikimedia.org/r/308654 Change subject: Hygiene: rename NavTabViewPagerAdapter .. Hygiene: rename NavTabViewPagerAdapter Rename NavTabViewPagerAdapter to NavTabF

[MediaWiki-commits] [Gerrit] integration/config[master]: Remove Android Commons app job

2016-09-05 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. https://gerrit.wikimedia.org/r/308669 Change subject: Remove Android Commons app job .. Remove Android Commons app job This app is no longer maintained by the Foundation. Cha

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Always hide the soft keyboard on the main screen

2016-09-06 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. https://gerrit.wikimedia.org/r/308758 Change subject: Always hide the soft keyboard on the main screen .. Always hide the soft keyboard on the main screen The soft keyboard re

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Use defaults for main config handling, launch mode

2016-09-06 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. https://gerrit.wikimedia.org/r/308760 Change subject: Use defaults for main config handling, launch mode .. Use defaults for main config handling, launch mode The OverhaulActi

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Update screenshot names for packaging changes

2016-09-07 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. https://gerrit.wikimedia.org/r/309007 Change subject: Update screenshot names for packaging changes .. Update screenshot names for packaging changes Change-Id: I6616dc78b8c57c

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Show the keyboard when tapping the history search

2016-09-08 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. https://gerrit.wikimedia.org/r/309376 Change subject: Show the keyboard when tapping the history search .. Show the keyboard when tapping the history search Show the soft keyb

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Don't resize the main screen when keyboard is up

2016-09-08 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. https://gerrit.wikimedia.org/r/309411 Change subject: Don't resize the main screen when keyboard is up .. Don't resize the main screen when keyboard is up Pan the app, don't r

[MediaWiki-commits] [Gerrit] mediawiki...MobileFrontend[master]: WIP: Hygiene: don't calculate, ask GeoData for distance

2016-09-10 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. https://gerrit.wikimedia.org/r/309811 Change subject: WIP: Hygiene: don't calculate, ask GeoData for distance .. WIP: Hygiene: don't calculate, ask GeoData for distance • use

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Hygiene: remove unused PageCache put callback code

2016-10-19 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. https://gerrit.wikimedia.org/r/316847 Change subject: Hygiene: remove unused PageCache put callback code .. Hygiene: remove unused PageCache put callback code Chip away at Pag

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: WIP: Replace PageCache with OkHttp caching

2016-10-19 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. https://gerrit.wikimedia.org/r/316852 Change subject: WIP: Replace PageCache with OkHttp caching .. WIP: Replace PageCache with OkHttp caching Seems snappier and promising. To

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Hygiene: update SaneAsyncTaskTest to JUnit 4

2016-10-19 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. https://gerrit.wikimedia.org/r/316911 Change subject: Hygiene: update SaneAsyncTaskTest to JUnit 4 .. Hygiene: update SaneAsyncTaskTest to JUnit 4 I thought this test was caus

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Hygiene: rename SaneAsyncTask test and package

2016-10-19 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. https://gerrit.wikimedia.org/r/316910 Change subject: Hygiene: rename SaneAsyncTask test and package .. Hygiene: rename SaneAsyncTask test and package Move org.wikipedia.test.

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Hygiene: suppress autoMirrored API level warnings

2016-10-20 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. https://gerrit.wikimedia.org/r/316986 Change subject: Hygiene: suppress autoMirrored API level warnings .. Hygiene: suppress autoMirrored API level warnings We should commit t

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Hygiene: replace deprecated android:singleLine

2016-10-20 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. https://gerrit.wikimedia.org/r/316989 Change subject: Hygiene: replace deprecated android:singleLine .. Hygiene: replace deprecated android:singleLine Change-Id: Ib13ee515c147

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Hygiene: remove unused resources

2016-10-20 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. https://gerrit.wikimedia.org/r/316992 Change subject: Hygiene: remove unused resources .. Hygiene: remove unused resources Change-Id: I0c4a942c224aae82fa0b6ad1ea5eaf6853bfe8a6

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Hygiene: suppress lints for lib resource overrides

2016-10-20 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. https://gerrit.wikimedia.org/r/316998 Change subject: Hygiene: suppress lints for lib resource overrides .. Hygiene: suppress lints for lib resource overrides HockeyApp librar

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Hygiene: remove unused colors and dimens

2016-10-20 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. https://gerrit.wikimedia.org/r/316999 Change subject: Hygiene: remove unused colors and dimens .. Hygiene: remove unused colors and dimens Change-Id: Ib34a23cf9f8cb2ab974ef4cf

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Hygiene: remove redundant method

2016-10-20 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. https://gerrit.wikimedia.org/r/317000 Change subject: Hygiene: remove redundant method .. Hygiene: remove redundant method getDimensionPixelOffset truncates whereas getDimensi

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Add content descriptions to article toolbar

2016-10-20 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. https://gerrit.wikimedia.org/r/317010 Change subject: Add content descriptions to article toolbar .. Add content descriptions to article toolbar Make the page toolbar more acc

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Fix abuse filter test

2016-10-20 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. https://gerrit.wikimedia.org/r/317065 Change subject: Fix abuse filter test .. Fix abuse filter test testAbuseFilterTriggerStopOnArbitraryErrorCode() tests for arbitrary error

[MediaWiki-commits] [Gerrit] integration/config[master]: Android: enable ANSI console coloring & timestamps

2016-10-20 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. https://gerrit.wikimedia.org/r/317068 Change subject: Android: enable ANSI console coloring & timestamps .. Android: enable ANSI console coloring & timestamps Change-Id: Ifc65

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Workaround EditTaskTest warning test

2016-10-20 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. https://gerrit.wikimedia.org/r/317070 Change subject: Workaround EditTaskTest warning test .. Workaround EditTaskTest warning test AbuseFilter/94 is currently returning abusef

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Upgrade to screenshot-tests-for-android v0.4.2

2016-10-20 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. https://gerrit.wikimedia.org/r/317073 Change subject: Upgrade to screenshot-tests-for-android v0.4.2 .. Upgrade to screenshot-tests-for-android v0.4.2 Upgrade to screenshot-te

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Hygiene: separate large numbers by thousands

2016-10-20 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. https://gerrit.wikimedia.org/r/317075 Change subject: Hygiene: separate large numbers by thousands .. Hygiene: separate large numbers by thousands Change-Id: Iabc12cea69f3b2b9

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Hygiene: update GetDescriptionsTaskTest to JUnit 4

2016-10-20 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. https://gerrit.wikimedia.org/r/317089 Change subject: Hygiene: update GetDescriptionsTaskTest to JUnit 4 .. Hygiene: update GetDescriptionsTaskTest to JUnit 4 Change-Id: I8d21

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Hygiene: consolidate runOnMainSync() helper method

2016-10-20 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. https://gerrit.wikimedia.org/r/317091 Change subject: Hygiene: consolidate runOnMainSync() helper method .. Hygiene: consolidate runOnMainSync() helper method Consolidate runO

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Hygiene: rename GetDescriptionsTask test & package

2016-10-20 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. https://gerrit.wikimedia.org/r/317090 Change subject: Hygiene: rename GetDescriptionsTask test & package .. Hygiene: rename GetDescriptionsTask test & package Move org.wikiped

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Hygiene: update test packaging and naming

2016-10-20 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. https://gerrit.wikimedia.org/r/317096 Change subject: Hygiene: update test packaging and naming .. Hygiene: update test packaging and naming Move tests to match subject packag

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Hygiene: consolidate PageTests into PageTest

2016-10-20 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. https://gerrit.wikimedia.org/r/317097 Change subject: Hygiene: consolidate PageTests into PageTest .. Hygiene: consolidate PageTests into PageTest Move PageTests into PageTest

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Hygiene: convert ParcelableTest to plain JUnit

2016-10-20 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. https://gerrit.wikimedia.org/r/317099 Change subject: Hygiene: convert ParcelableTest to plain JUnit .. Hygiene: convert ParcelableTest to plain JUnit Change-Id: I0d46e153b1c3

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Hygiene: convert ParcelableTest to JUnit 4

2016-10-20 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. https://gerrit.wikimedia.org/r/317098 Change subject: Hygiene: convert ParcelableTest to JUnit 4 .. Hygiene: convert ParcelableTest to JUnit 4 Change-Id: I1838c694c92e230a7c07

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Hygiene: convert SaneAsyncTaskTest to JUnit 4

2016-10-20 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. https://gerrit.wikimedia.org/r/317100 Change subject: Hygiene: convert SaneAsyncTaskTest to JUnit 4 .. Hygiene: convert SaneAsyncTaskTest to JUnit 4 Change-Id: Ib24132fdb203ec

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Hygiene: convert WikiSiteTest to plain JUnit

2016-10-20 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. https://gerrit.wikimedia.org/r/317102 Change subject: Hygiene: convert WikiSiteTest to plain JUnit .. Hygiene: convert WikiSiteTest to plain JUnit Change-Id: I3a73c29356ca34c9

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Hygiene: convert WikiSiteTest to JUnit 4

2016-10-20 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. https://gerrit.wikimedia.org/r/317101 Change subject: Hygiene: convert WikiSiteTest to JUnit 4 .. Hygiene: convert WikiSiteTest to JUnit 4 Change-Id: I356fa846e7263dda66ad7251

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Hygiene: convert NearbyUnitTests to JUnit 4

2016-10-20 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. https://gerrit.wikimedia.org/r/317104 Change subject: Hygiene: convert NearbyUnitTests to JUnit 4 .. Hygiene: convert NearbyUnitTests to JUnit 4 Change-Id: Iaa03df48677e570806

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Hygiene: convert SectionTest to JUnit 4

2016-10-20 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. https://gerrit.wikimedia.org/r/317106 Change subject: Hygiene: convert SectionTest to JUnit 4 .. Hygiene: convert SectionTest to JUnit 4 Change-Id: I0c4e85079bd906e20a2708e534

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Hygiene: update FetchSectionWikitextTaskTest

2016-10-20 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. https://gerrit.wikimedia.org/r/317103 Change subject: Hygiene: update FetchSectionWikitextTaskTest .. Hygiene: update FetchSectionWikitextTaskTest Convert FetchSectionWikitext

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Hygiene: convert NearbyUnitTests to plain JUnit

2016-10-20 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. https://gerrit.wikimedia.org/r/317105 Change subject: Hygiene: convert NearbyUnitTests to plain JUnit .. Hygiene: convert NearbyUnitTests to plain JUnit Convert NearbyUnitTest

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Hygiene: convert SectionTest to plain JUnit

2016-10-20 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. https://gerrit.wikimedia.org/r/317107 Change subject: Hygiene: convert SectionTest to plain JUnit .. Hygiene: convert SectionTest to plain JUnit Change-Id: I407a59a9508aa8fe23

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Hygiene: convert SuggestionsTaskTest to JUnit 4

2016-10-20 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. https://gerrit.wikimedia.org/r/317108 Change subject: Hygiene: convert SuggestionsTaskTest to JUnit 4 .. Hygiene: convert SuggestionsTaskTest to JUnit 4 Change-Id: I3898924b08

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Hygiene: convert FullSearchArticle*Test to JUnit 4

2016-10-20 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. https://gerrit.wikimedia.org/r/317109 Change subject: Hygiene: convert FullSearchArticle*Test to JUnit 4 .. Hygiene: convert FullSearchArticle*Test to JUnit 4 Convert FullSear

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Hygiene: update LanguageVariantTest to plain JUnit

2016-10-20 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. https://gerrit.wikimedia.org/r/317111 Change subject: Hygiene: update LanguageVariantTest to plain JUnit .. Hygiene: update LanguageVariantTest to plain JUnit Convert Language

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Hygiene: remove TestDummyActivity

2016-10-20 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. https://gerrit.wikimedia.org/r/317112 Change subject: Hygiene: remove TestDummyActivity .. Hygiene: remove TestDummyActivity This class is no longer needed. Change-Id: I87fcd

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Hygiene: convert LanguageVariantTests to JUnit 4

2016-10-20 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. https://gerrit.wikimedia.org/r/317110 Change subject: Hygiene: convert LanguageVariantTests to JUnit 4 .. Hygiene: convert LanguageVariantTests to JUnit 4 Change-Id: I5c36baa5

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Hygiene: minor clean up of TranslationTests

2016-10-20 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. https://gerrit.wikimedia.org/r/317113 Change subject: Hygiene: minor clean up of TranslationTests .. Hygiene: minor clean up of TranslationTests Replace System.out Log.* loggi

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Enforce default Android Studio import ordering

2016-10-21 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. https://gerrit.wikimedia.org/r/317170 Change subject: Enforce default Android Studio import ordering .. Enforce default Android Studio import ordering Also prohibit wildcard s

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Add CardHeaderViewTest

2016-10-21 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. https://gerrit.wikimedia.org/r/317285 Change subject: Add CardHeaderViewTest .. Add CardHeaderViewTest I had to change an ImageView in CardHeaderView back to an explicit AppCo

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Hygiene: replace Button with TextView

2016-10-23 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. https://gerrit.wikimedia.org/r/317461 Change subject: Hygiene: replace Button with TextView .. Hygiene: replace Button with TextView A follow up to 58eee82, replace Buttons wi

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Localisation updates from https://translatewiki.net.

2016-10-24 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. https://gerrit.wikimedia.org/r/317513 Change subject: Localisation updates from https://translatewiki.net. .. Localisation updates from https://translatewiki.net. Change-Id: I

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Request more search suggestions for filtering

2016-10-24 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. https://gerrit.wikimedia.org/r/317647 Change subject: Request more search suggestions for filtering .. Request more search suggestions for filtering Search suggestions are fil

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Hygiene: replace hardcoded font scale with symbol

2016-10-24 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. https://gerrit.wikimedia.org/r/317719 Change subject: Hygiene: replace hardcoded font scale with symbol .. Hygiene: replace hardcoded font scale with symbol Change-Id: Ib273e1

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Add ListCardViewTest

2016-10-24 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. https://gerrit.wikimedia.org/r/317718 Change subject: Add ListCardViewTest .. Add ListCardViewTest Bug: T144399 Change-Id: I1e1b1285d2dab4c99fee9822d63199402f7479b6 --- A app/

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Add DefaultFeedCardViewTest

2016-10-24 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. https://gerrit.wikimedia.org/r/317717 Change subject: Add DefaultFeedCardViewTest .. Add DefaultFeedCardViewTest Bug: T144399 Change-Id: I664d051183df7ba7cd8a343c6ca4e50969e28

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Upgrade minimum Android version to v4.1 (API 16)

2016-10-25 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. https://gerrit.wikimedia.org/r/317851 Change subject: Upgrade minimum Android version to v4.1 (API 16) .. Upgrade minimum Android version to v4.1 (API 16) Upgrade minSdkVersio

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Add ListCardItemViewTest

2016-10-25 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. https://gerrit.wikimedia.org/r/317858 Change subject: Add ListCardItemViewTest .. Add ListCardItemViewTest Bug: T144399 Change-Id: Ie3cc50516d783a6174d90490d6fa8f8b927a09ec --

[MediaWiki-commits] [Gerrit] integration/config[master]: Android: fix screenshot and test result dirs

2016-10-25 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. https://gerrit.wikimedia.org/r/317948 Change subject: Android: fix screenshot and test result dirs .. Android: fix screenshot and test result dirs • Screenshots are not stored

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Add CaptchaClientTest

2016-10-26 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. https://gerrit.wikimedia.org/r/318133 Change subject: Add CaptchaClientTest .. Add CaptchaClientTest Change-Id: I05a31d81a6a717d932d74ba7c14b64fc71bea4df --- M app/src/main/ja

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Hygiene: collapse PageTitleListCardItemView

2016-10-26 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. https://gerrit.wikimedia.org/r/318230 Change subject: Hygiene: collapse PageTitleListCardItemView .. Hygiene: collapse PageTitleListCardItemView Merge ListCardItemView into Pa

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Hygiene: update ViewTest packaging

2016-10-26 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. https://gerrit.wikimedia.org/r/318233 Change subject: Hygiene: update ViewTest packaging .. Hygiene: update ViewTest packaging Move ViewTest into org.wikipedia.test.view. This

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Hygiene: add TestStr to String helper in ViewTest

2016-10-27 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. https://gerrit.wikimedia.org/r/318440 Change subject: Hygiene: add TestStr to String helper in ViewTest .. Hygiene: add TestStr to String helper in ViewTest Change-Id: Id55360

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Add PageTitleListCardItemViewTest

2016-10-27 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. https://gerrit.wikimedia.org/r/318441 Change subject: Add PageTitleListCardItemViewTest .. Add PageTitleListCardItemViewTest Bug: T144399 Change-Id: I29ea5621f6e0e175ea4b1bd32

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Move CI scripts into version control

2016-10-27 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. https://gerrit.wikimedia.org/r/318446 Change subject: Move CI scripts into version control .. Move CI scripts into version control Copy over the shell commands from CI[0,1,2]

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Fix bug in Namespace to legacy string conversion

2016-10-27 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. https://gerrit.wikimedia.org/r/318452 Change subject: Fix bug in Namespace to legacy string conversion .. Fix bug in Namespace to legacy string conversion Fix capitalization b

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Bump versionCode

2016-09-28 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. https://gerrit.wikimedia.org/r/313220 Change subject: Bump versionCode .. Bump versionCode Change-Id: I37ba081e4f30a4d918b2e85a02c698bd1e1d8d84 --- M app/build.gradle 1 file c

[MediaWiki-commits] [Gerrit] mediawiki...mobileapps[master]: Remove dead link in readme

2016-10-03 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. https://gerrit.wikimedia.org/r/313875 Change subject: Remove dead link in readme .. Remove dead link in readme Change-Id: I6e7bdd8a51bdd3a5e93d8fe1ae04a08af56d3e86 --- M READM

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Hygiene: use TimeUnit instead of arithmetic

2016-10-04 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. https://gerrit.wikimedia.org/r/314031 Change subject: Hygiene: use TimeUnit instead of arithmetic .. Hygiene: use TimeUnit instead of arithmetic Change-Id: Ifca43a277058c1f580

[MediaWiki-commits] [Gerrit] integration/config[master]: Android: add IRC notification to alpha builds

2016-10-04 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. https://gerrit.wikimedia.org/r/314036 Change subject: Android: add IRC notification to alpha builds .. Android: add IRC notification to alpha builds Change-Id: I69f33209ab84a0

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Localisation updates from https://translatewiki.net.

2016-10-05 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. https://gerrit.wikimedia.org/r/314279 Change subject: Localisation updates from https://translatewiki.net. .. Localisation updates from https://translatewiki.net. Change-Id: I

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Demo: required field Gson fields

2016-10-05 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. https://gerrit.wikimedia.org/r/314331 Change subject: Demo: required field Gson fields .. Demo: required field Gson fields Just copy and paste this answer: http://stackoverflo

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Hygiene: remove legacy code for Site domain

2016-10-05 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. https://gerrit.wikimedia.org/r/314415 Change subject: Hygiene: remove legacy code for Site domain .. Hygiene: remove legacy code for Site domain Remove legacy unmarshalling co

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Don't toggle the GPS when requesting location

2016-10-05 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. https://gerrit.wikimedia.org/r/314419 Change subject: Don't toggle the GPS when requesting location .. Don't toggle the GPS when requesting location The Mapbox SDK will quickl

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Annotate BridgeTests as @Large

2016-10-07 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. https://gerrit.wikimedia.org/r/314770 Change subject: Annotate BridgeTests as @Large .. Annotate BridgeTests as @Large A follow-up to 4994f86, add @Large annotation to missed

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Annotate TranslationTests as @Large

2016-10-07 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. https://gerrit.wikimedia.org/r/314781 Change subject: Annotate TranslationTests as @Large .. Annotate TranslationTests as @Large A follow-up to 4994f86 and 8d2b632, add @Large

[MediaWiki-commits] [Gerrit] integration/config[master]: WIP: Android: upgrade emulator to API 24

2016-10-07 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. https://gerrit.wikimedia.org/r/314788 Change subject: WIP: Android: upgrade emulator to API 24 .. WIP: Android: upgrade emulator to API 24 • Upgrade the Android emulator to AP

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Hygiene: remove adb-setup.bash

2016-10-07 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. https://gerrit.wikimedia.org/r/314789 Change subject: Hygiene: remove adb-setup.bash .. Hygiene: remove adb-setup.bash Remove setup script which unlocked the screen, waited un

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Hygiene: remove ParcelableLruCache

2016-11-01 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. https://gerrit.wikimedia.org/r/319237 Change subject: Hygiene: remove ParcelableLruCache .. Hygiene: remove ParcelableLruCache The functionality of the superclass, LruCache, s

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Fix ArrayAdapters to use parent when inflating

2016-11-01 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. https://gerrit.wikimedia.org/r/319238 Change subject: Fix ArrayAdapters to use parent when inflating .. Fix ArrayAdapters to use parent when inflating When inflating items, co

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Hygiene: remove unused member in EditTokenStorage

2016-11-01 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. https://gerrit.wikimedia.org/r/319240 Change subject: Hygiene: remove unused member in EditTokenStorage .. Hygiene: remove unused member in EditTokenStorage Bug: T144318 Chang

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Update deprecated APIs

2016-11-01 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. https://gerrit.wikimedia.org/r/319241 Change subject: Update deprecated APIs .. Update deprecated APIs Bug: T144318 Change-Id: I9cdc208f2f61c940ba6aeedb153703ca16d83a05 --- M

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Capitalize "today" in because you read card titles

2016-11-02 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. https://gerrit.wikimedia.org/r/319390 Change subject: Capitalize "today" in because you read card titles .. Capitalize "today" in because you read card titles Bug: T148746 Cha

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Upgrade to Support Library v25.0.0

2016-11-02 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. https://gerrit.wikimedia.org/r/319486 Change subject: Upgrade to Support Library v25.0.0 .. Upgrade to Support Library v25.0.0 Upgrade the Support Libraries to v25.0.0[0], bui

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Fix duplicate show password icon

2016-11-02 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. https://gerrit.wikimedia.org/r/319487 Change subject: Fix duplicate show password icon .. Fix duplicate show password icon Bug: T144318 Change-Id: I7faa4aebebaf55f6b5b18a2a625

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Marshal DescriptionEditFragment Bundle not Intent

2016-11-03 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. https://gerrit.wikimedia.org/r/319760 Change subject: Marshal DescriptionEditFragment Bundle not Intent .. Marshal DescriptionEditFragment Bundle not Intent • Unmarshal from t

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Capitalize "yesterday" in feed card titles

2016-11-04 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. https://gerrit.wikimedia.org/r/319877 Change subject: Capitalize "yesterday" in feed card titles .. Capitalize "yesterday" in feed card titles A doh! follow-up to cb2b7f6. Bu

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Hygiene: replace requestFocus idiom with util

2016-11-04 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. https://gerrit.wikimedia.org/r/319918 Change subject: Hygiene: replace requestFocus idiom with util .. Hygiene: replace requestFocus idiom with util Bug: T148203 Change-Id: I7

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Add @TestedOnBool annotation for @Theory tests

2016-11-04 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. https://gerrit.wikimedia.org/r/319917 Change subject: Add @TestedOnBool annotation for @Theory tests .. Add @TestedOnBool annotation for @Theory tests Bug: T148203 Change-Id:

[MediaWiki-commits] [Gerrit] apps...wikipedia[master]: Add DescriptionEditViewTest

2016-11-04 Thread Niedzielski (Code Review)
Niedzielski has uploaded a new change for review. https://gerrit.wikimedia.org/r/319919 Change subject: Add DescriptionEditViewTest .. Add DescriptionEditViewTest Bug: T148203 Change-Id: I67b3250583784a3ba74b69bf46fbee76465dc

<    1   2   3   4   5   6   7   8   9   10   >