Daniel Kinzler has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/404173 )
Change subject: Document the interpretation of revision row fields.
..
Document the interpretation of revision row fields.
This
Daniel Kinzler has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/404152 )
Change subject: Add more tests for legacy encoding in RevisionTest
..
Add more tests for legacy encoding in RevisionTest
These are
Daniel Kinzler has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/403926 )
Change subject: Add tests for legacy encoding when constructing RevisionRecords
..
Add tests for legacy encoding when constructing
Daniel Kinzler has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/403922 )
Change subject: Document expandBlob behavior when no flags are given.
..
Document expandBlob behavior when no flags are given.
Bug:
Daniel Kinzler has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/403682 )
Change subject: Make Revision::__construct work with bad page ID
..
Make Revision::__construct work with bad page ID
For
Daniel Kinzler has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/403638 )
Change subject: Revision::newNullRevision should return null for bad page ID.
..
Revision::newNullRevision should return null for
Daniel Kinzler has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/403634 )
Change subject: Handle failure to load content in Revision getSize, etc
..
Handle failure to load content in Revision getSize, etc
Daniel Kinzler has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/402903 )
Change subject: Specify encoding expected by DatabaseDomain::newFromId.
..
Specify encoding expected by DatabaseDomain::newFromId.
Daniel Kinzler has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/402573 )
Change subject: Fix dropping of temp tables on SQLite and PG.
..
Fix dropping of temp tables on SQLite and PG.
Also addresses other
Daniel Kinzler has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/401594 )
Change subject: Simplify logic for replica selection with groups
..
Simplify logic for replica selection with groups
Change-Id:
Daniel Kinzler has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/401591 )
Change subject: Add test for LoadBalancer::getConenction with groups.
..
Add test for LoadBalancer::getConenction with groups.
Daniel Kinzler has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/401557 )
Change subject: Hint against IDatabase in EntityUsageTableTest
..
Hint against IDatabase in EntityUsageTableTest
Change-Id:
Daniel Kinzler has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/401556 )
Change subject: Fix accidental reference to IDatabase in docs.
..
Fix accidental reference to IDatabase in docs.
Change-Id:
Daniel Kinzler has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/401524 )
Change subject: Hint against IDatabase instead of the Database base class.
..
Hint against IDatabase instead of the Database base
Daniel Kinzler has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/401520 )
Change subject: getConnection( getWriterIndex() ) should return master
connection.
..
getConnection( getWriterIndex() ) should
Daniel Kinzler has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/401507 )
Change subject: Introduce DBConnectionProxy base class.
..
Introduce DBConnectionProxy base class.
DBConnectionProxy is intended to
Daniel Kinzler has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/401505 )
Change subject: Add test for DBConnRef
..
Add test for DBConnRef
Change-Id: I510b2ed22b3866392592a5df53aa0f3ff6aab750
---
A
Daniel Kinzler has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/400411 )
Change subject: Improve documentation and method naming on Revision and
RevisionStore.
..
Improve documentation and method naming
Daniel Kinzler has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/399679 )
Change subject: Typehint against IDatabase, nto DatabaseBase
..
Typehint against IDatabase, nto DatabaseBase
Change-Id:
Daniel Kinzler has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/399678 )
Change subject: Typehint against IDatabase, not plain Database
..
Typehint against IDatabase, not plain Database
Change-Id:
Daniel Kinzler has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/399663 )
Change subject: Use IDatabase instead of DatabaseBase
..
Use IDatabase instead of DatabaseBase
Change-Id:
Daniel Kinzler has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/399604 )
Change subject: Test for writes being prevented on replica connections.
..
Test for writes being prevented on replica connections.
Daniel Kinzler has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/399447 )
Change subject: Set CONN_NO_WRITE on all relevant code pathes in LoadBalancer.
..
Set CONN_NO_WRITE on all relevant code pathes in
Daniel Kinzler has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/399445 )
Change subject: [WIP] Prevent writes on connections obtained with DB_REPLICA.
..
[WIP] Prevent writes on connections obtained with
Daniel Kinzler has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/399208 )
Change subject: Prevent write operations to database replicas.
..
Prevent write operations to database replicas.
Bug: T183265
Daniel Kinzler has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/399174 )
Change subject: Deprecate and gut Revision class [DNM].
..
Deprecate and gut Revision class [DNM].
This is a re-submission of
Hello Bene, Cicalese, Ladsgroup, Brion VIBBER, Legoktm, Addshore, jenkins-bot,
Anomie,
I'd like you to do a code review. Please visit
https://gerrit.wikimedia.org/r/399156
to review the following change.
Change subject: Revert "[MCR] Turn Revision into a proxy to new code."
Daniel Kinzler has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/398885 )
Change subject: Fix cache key cleared by populateContentModel.php
..
Fix cache key cleared by populateContentModel.php
This is a
Daniel Kinzler has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/398884 )
Change subject: Fetch revisions from master DB if not found on replica.
..
Fetch revisions from master DB if not found on replica.
Daniel Kinzler has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/397899 )
Change subject: Make wbsetclaim and friends check entity permissions.
..
Make wbsetclaim and friends check entity permissions.
Daniel Kinzler has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/395815 )
Change subject: Document entity storage on wiki pages.
..
Document entity storage on wiki pages.
This clarifies the relationship
Daniel Kinzler has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/393243 )
Change subject: Assume PageIdentityValue exists in core.
..
Assume PageIdentityValue exists in core.
Change-Id:
Daniel Kinzler has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/393242 )
Change subject: Make unit tests aware of PageIdentity.
..
Make unit tests aware of PageIdentity.
Use of PageIdentity is protected
Daniel Kinzler has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/393048 )
Change subject: Fix name of test class.
..
Fix name of test class.
Change-Id: Ie38f9ed5f4ec93637e9a45b099ad8fe8ff21c73b
---
M
Daniel Kinzler has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/392679 )
Change subject: Remove the need for EntityDocument::isEmpty.
..
Remove the need for EntityDocument::isEmpty.
We'll keep isEmpty in
Daniel Kinzler has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/391888 )
Change subject: Introcude the UserIdentity interface.
..
Introcude the UserIdentity interface.
This provides a narrow view on a
Daniel Kinzler has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/391866 )
Change subject: Introduce DB schema overrides for unit tests.
..
Introduce DB schema overrides for unit tests.
This introduces
Daniel Kinzler has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/391606 )
Change subject: Allow action overrides to work with WikiPage for now.
..
Allow action overrides to work with WikiPage for now.
This
Daniel Kinzler has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/391604 )
Change subject: Allow EntityHandlerTest to be used with Lexemes, etc.
..
Allow EntityHandlerTest to be used with Lexemes, etc.
This
Daniel Kinzler has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/391577 )
Change subject: Action override callbacks must still accept WikiPage for now.
..
Action override callbacks must still accept
Daniel Kinzler has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/387788 )
Change subject: Always supplay an Article when constructing an Action.
..
Always supplay an Article when constructing an Action.
Daniel Kinzler has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/387787 )
Change subject: Always supplay an Article when constructing an Action.
..
Always supplay an Article when constructing an Action.
Daniel Kinzler has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/387685 )
Change subject: Deprecate methods in Article that delegate to WikiPage
..
Deprecate methods in Article that delegate to WikiPage
Daniel Kinzler has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/387640 )
Change subject: [MCR] Make WikiPage use Revisionrecord instead of Revision
..
[MCR] Make WikiPage use Revisionrecord instead of
Daniel Kinzler has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/387353 )
Change subject: Make MFMockRevision more robust against changes to Revision.
..
Make MFMockRevision more robust against changes to
Daniel Kinzler has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/387302 )
Change subject: Use mock titles instead of bogus page IDs in tests.
..
Use mock titles instead of bogus page IDs in tests.
With
Daniel Kinzler has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/387063 )
Change subject: Warn when page_latest is 0 unexpectedly.
..
Warn when page_latest is 0 unexpectedly.
Change-Id:
Daniel Kinzler has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/386422 )
Change subject: Introduce EntityByTitleLookup for use by EntityByTitleHelper
and EntityLoadingHelper.
..
Introduce
Daniel Kinzler has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/386048 )
Change subject: Treat NULL and 0 as equivalent for rev_parent_id
..
Treat NULL and 0 as equivalent for rev_parent_id
The return
Daniel Kinzler has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/383551 )
Change subject: Add tracking for fallout from fix for T177707
..
Add tracking for fallout from fix for T177707
Bug: T177707
Daniel Kinzler has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/383384 )
Change subject: Quick fix for flooding of the RC table.
..
Quick fix for flooding of the RC table.
Under some conditions, Wikibase
Daniel Kinzler has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/378946 )
Change subject: EXPERIMENT: treat Forms as Sub-Entities
..
EXPERIMENT: treat Forms as Sub-Entities
Change-Id:
Daniel Kinzler has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/378786 )
Change subject: EXPERIMENT: infrastructure for hierarchicaly adressable entities
..
EXPERIMENT: infrastructure for hierarchicaly
Daniel Kinzler has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/378729 )
Change subject: [DNM] Remove redundant fields from old DB tables.
..
[DNM] Remove redundant fields from old DB tables.
This patch
Daniel Kinzler has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/378724 )
Change subject: [WIP] first shot at MCR database schema
..
[WIP] first shot at MCR database schema
Bug: T174028
Change-Id:
Daniel Kinzler has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/378707 )
Change subject: Document change dispatching and change handling in
change-propagation.wiki
..
Document change dispatching and
Daniel Kinzler has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/377813 )
Change subject: Do not ignore edit conflicts with oneself.
..
Do not ignore edit conflicts with oneself.
Please refer to the ticket
Daniel Kinzler has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/377812 )
Change subject: Split page set before constructing InjectRCRecordsJob
..
Split page set before constructing InjectRCRecordsJob
Bug:
Daniel Kinzler has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/377811 )
Change subject: Split page set before constructing InjectRCRecordsJob
..
Split page set before constructing InjectRCRecordsJob
Bug:
Daniel Kinzler has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/377654 )
Change subject: First spike exploring usage of new RevisionStore class
..
First spike exploring usage of new RevisionStore class
Daniel Kinzler has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/377046 )
Change subject: Allow batch sizes for different jobs to be defined separately.
..
Allow batch sizes for different jobs to be defined
Daniel Kinzler has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/375050 )
Change subject: Turn Revision into a proxy to the new code.
..
Turn Revision into a proxy to the new code.
Change-Id:
Daniel Kinzler has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/375819 )
Change subject: Pass root job params through WikiPageUpdater
..
Pass root job params through WikiPageUpdater
Root job timestamps
Daniel Kinzler has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/374570 )
Change subject: Pre-fetch titles in ChangeHandler
..
Pre-fetch titles in ChangeHandler
This is for parity with I71af6f13c84.
Daniel Kinzler has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/370974 )
Change subject: Remove pointless showExternalRecentChanges option.
..
Remove pointless showExternalRecentChanges option.
Change-Id:
Daniel Kinzler has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/370972 )
Change subject: remove unused injectrecentChanges option
..
remove unused injectrecentChanges option
This setting has been
Daniel Kinzler has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/370966 )
Change subject: Enable injection of RC records on wikidata org.
..
Enable injection of RC records on wikidata org.
This will cause
Daniel Kinzler has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/370326 )
Change subject: Check Title::canHaveTalkPage before calling getTalkPage()
..
Check Title::canHaveTalkPage before calling
Daniel Kinzler has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/369847 )
Change subject: Hot fix for InjectRCRecordsJob: disable coalescing
..
Hot fix for InjectRCRecordsJob: disable coalescing
Bug:
Daniel Kinzler has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/369846 )
Change subject: Hot fix for InjectRCRecordsJob: disable coalescing
..
Hot fix for InjectRCRecordsJob: disable coalescing
Bug:
Daniel Kinzler has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/369424 )
Change subject: Introduce Title::getTalkPageIfDefined.
..
Introduce Title::getTalkPageIfDefined.
This is part of the effort to
Daniel Kinzler has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/369422 )
Change subject: Track per-client statistics for dispatchCHanges.
..
Track per-client statistics for dispatchCHanges.
Change-Id:
Daniel Kinzler has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/369394 )
Change subject: Fix bad value type in demo data for Leiter
..
Fix bad value type in demo data for Leiter
Change-Id:
Daniel Kinzler has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/368821 )
Change subject: Remove unused EditEntity::showErrorPage.
..
Remove unused EditEntity::showErrorPage.
This also removes the need to
Daniel Kinzler has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/368797 )
Change subject: Tweak demo data:
..
Tweak demo data:
* fix a type
* rename "related concept" to "evokes"
* introduce "denotes"
Daniel Kinzler has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/368224 )
Change subject: Move injection of RC records to a separate job.
..
Move injection of RC records to a separate job.
This should also
Daniel Kinzler has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/367703 )
Change subject: Track calls to wbeditentity and usage of the clear switch
..
Track calls to wbeditentity and usage of the clear
Daniel Kinzler has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/367328 )
Change subject: Move injection of RC records to a separate job.
..
Move injection of RC records to a separate job.
This should also
Daniel Kinzler has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/367325 )
Change subject: Use proper DB name for local wiki in wb_changes_dispatch table.
..
Use proper DB name for local wiki in
Daniel Kinzler has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/367045 )
Change subject: Streamline input validation for Special pages.
..
Streamline input validation for Special pages.
Change-Id:
Daniel Kinzler has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/366879 )
Change subject: Simplify edit conflict detection in EditEntity.
..
Simplify edit conflict detection in EditEntity.
This change does
Daniel Kinzler has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/366866 )
Change subject: Add P279 to $wgPropertySuggesterClassifyingPropertyIds
..
Add P279 to $wgPropertySuggesterClassifyingPropertyIds
Daniel Kinzler has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/366864 )
Change subject: Add P279 to PropertySuggesterClassifyingPropertyIds per default.
..
Add P279 to
Daniel Kinzler has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/366606 )
Change subject: Refactor SpecialModifyEntity to use EditPage.
..
Refactor SpecialModifyEntity to use EditPage.
SpecialModifyEntity
Daniel Kinzler has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/366590 )
Change subject: Refactor EditEntity interactor
..
Refactor EditEntity interactor
This change allows the EditEntity interactor to be
Daniel Kinzler has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/366588 )
Change subject: Avoid use of EditEntity in test case
..
Avoid use of EditEntity in test case
Change-Id:
Daniel Kinzler has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/365031 )
Change subject: Remove overengineered page update code from ChangeHandler
..
Remove overengineered page update code from
Daniel Kinzler has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/364205 )
Change subject: Use RefreshLinksJob instead of Title:invalidateCache
..
Use RefreshLinksJob instead of Title:invalidateCache
Bug:
Daniel Kinzler has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/364198 )
Change subject: Use multi-page RefreshLinksJobs in WikiPageUpdater
..
Use multi-page RefreshLinksJobs in WikiPageUpdater
Bug:
Daniel Kinzler has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/361851 )
Change subject: Temporarily set $wgPropertySuggesterClassifyingPropertyIds to [
31 ].
..
Temporarily set
Daniel Kinzler has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/360365 )
Change subject: Remove MediaWiki framework integration
..
Remove MediaWiki framework integration
Bug: T168359
Change-Id:
Daniel Kinzler has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/359184 )
Change subject: Deprecate Content::getNativeData, add TextContent::getText
..
Deprecate Content::getNativeData, add
Daniel Kinzler has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/359156 )
Change subject: Fix call to makeContent in SpecialChangeContentModel
..
Fix call to makeContent in SpecialChangeContentModel
Daniel Kinzler has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/359004 )
Change subject: Add redirect=force option to Special:EntitData
..
Add redirect=force option to Special:EntitData
This allows us to
Daniel Kinzler has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/358915 )
Change subject: makeEmptyContent must return empty content.
..
makeEmptyContent must return empty content.
This adds a sanity test
Daniel Kinzler has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/358423 )
Change subject: Add Title::isValid method.
..
Add Title::isValid method.
Make the notion of Title objects representing invalid
Daniel Kinzler has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/358163 )
Change subject: Rename canTalk methods
..
Rename canTalk methods
This renames Title::canTalk to Title::canHaveTalkPage
and
Daniel Kinzler has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/358047 )
Change subject: Make Titles with an unknown namespace ID refer to
Special:Badtitle.
..
Make Titles with an unknown namespace ID
Daniel Kinzler has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/357584 )
Change subject: Check that function hook is callable whe4n registering.
..
Check that function hook is callable whe4n registering.
Daniel Kinzler has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/356228 )
Change subject: Allow makeEmptyContent to return null for some kinds of content.
..
Allow makeEmptyContent to return null for some
1 - 100 of 1548 matches
Mail list logo
