[MediaWiki-commits] [Gerrit] operations/puppet[production]: lxc: Fix support for stretch

2018-01-22 Thread Faidon Liambotis (Code Review)
Faidon Liambotis has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/405208 ) Change subject: lxc: Fix support for stretch .. lxc: Fix support for stretch Was failing with No matching entry for

[MediaWiki-commits] [Gerrit] operations/puppet[production]: wmflib: make os_version spec more extensive

2018-01-19 Thread Faidon Liambotis (Code Review)
Faidon Liambotis has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/405387 ) Change subject: wmflib: make os_version spec more extensive .. wmflib: make os_version spec more extensive Cover cases

[MediaWiki-commits] [Gerrit] operations/puppet[production]: wmflib: make os_version spec more extensive

2018-01-19 Thread Faidon Liambotis (Code Review)
Faidon Liambotis has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/405387 ) Change subject: wmflib: make os_version spec more extensive .. wmflib: make os_version spec more extensive Cover cases such as: -

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Update group photo on people.wm.org

2018-01-17 Thread Faidon Liambotis (Code Review)
Faidon Liambotis has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/402583 ) Change subject: Update group photo on people.wm.org .. Update group photo on people.wm.org Update people.wikimedia with

[MediaWiki-commits] [Gerrit] analytics/kafkatee[master]: Define IOV_MAX properly, using _GNU_SOURCE

2018-01-16 Thread Faidon Liambotis (Code Review)
Faidon Liambotis has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/404456 ) Change subject: Define IOV_MAX properly, using _GNU_SOURCE .. Define IOV_MAX properly, using _GNU_SOURCE Undo the hack previously

[MediaWiki-commits] [Gerrit] analytics/kafkatee[master]: d/control: fix indentation of the extended description

2018-01-16 Thread Faidon Liambotis (Code Review)
Faidon Liambotis has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/404462 ) Change subject: d/control: fix indentation of the extended description .. d/control: fix indentation of the extended description

[MediaWiki-commits] [Gerrit] analytics/kafkatee[master]: Remove kafkatee upstart script

2018-01-16 Thread Faidon Liambotis (Code Review)
Faidon Liambotis has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/404458 ) Change subject: Remove kafkatee upstart script .. Remove kafkatee upstart script Upstart is not supported anymore. Change-Id:

[MediaWiki-commits] [Gerrit] analytics/kafkatee[master]: Bump debhelper compat to 11, Standards-Version

2018-01-16 Thread Faidon Liambotis (Code Review)
Faidon Liambotis has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/404457 ) Change subject: Bump debhelper compat to 11, Standards-Version .. Bump debhelper compat to 11, Standards-Version Change-Id:

[MediaWiki-commits] [Gerrit] analytics/kafkatee[master]: Set Maintainer to ops, add myself to Uploaders

2018-01-16 Thread Faidon Liambotis (Code Review)
Faidon Liambotis has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/404464 ) Change subject: Set Maintainer to ops, add myself to Uploaders .. Set Maintainer to ops, add myself to Uploaders Change-Id:

[MediaWiki-commits] [Gerrit] analytics/kafkatee[master]: Remove +x from debian/kafkatee.post{inst, rm}

2018-01-16 Thread Faidon Liambotis (Code Review)
Faidon Liambotis has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/404461 ) Change subject: Remove +x from debian/kafkatee.post{inst,rm} .. Remove +x from debian/kafkatee.post{inst,rm} Change-Id:

[MediaWiki-commits] [Gerrit] analytics/kafkatee[master]: Drop versioned Build-Depends to pre-jessie versions

2018-01-16 Thread Faidon Liambotis (Code Review)
Faidon Liambotis has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/404463 ) Change subject: Drop versioned Build-Depends to pre-jessie versions .. Drop versioned Build-Depends to pre-jessie versions

[MediaWiki-commits] [Gerrit] analytics/kafkatee[master]: Release 0.1.7-1

2018-01-16 Thread Faidon Liambotis (Code Review)
Faidon Liambotis has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/404465 ) Change subject: Release 0.1.7-1 .. Release 0.1.7-1 Change-Id: I31c323de012ce8ffd18a220933e4ae89fb3a8a06 --- M debian/changelog 1

[MediaWiki-commits] [Gerrit] analytics/kafkatee[master]: Use /run instead of /var/run in the source

2018-01-16 Thread Faidon Liambotis (Code Review)
Faidon Liambotis has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/404460 ) Change subject: Use /run instead of /var/run in the source .. Use /run instead of /var/run in the source Not applicable to the

[MediaWiki-commits] [Gerrit] analytics/kafkatee[master]: Don't create (or remove) /var/run/kafkatee anymore

2018-01-16 Thread Faidon Liambotis (Code Review)
Faidon Liambotis has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/404459 ) Change subject: Don't create (or remove) /var/run/kafkatee anymore .. Don't create (or remove) /var/run/kafkatee anymore We don't

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Use profile::pmacct, not profile::netinsights

2018-01-16 Thread Faidon Liambotis (Code Review)
Faidon Liambotis has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/404443 ) Change subject: Use profile::pmacct, not profile::netinsights .. Use profile::pmacct, not profile::netinsights Change-Id:

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Drop netinsights' override for Kafka cluster etc.

2018-01-16 Thread Faidon Liambotis (Code Review)
Faidon Liambotis has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/404443 ) Change subject: Drop netinsights' override for Kafka cluster etc. .. Drop netinsights' override for Kafka cluster etc. Should be

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Rename pmacct to netinsights also in hiera

2018-01-16 Thread Faidon Liambotis (Code Review)
Faidon Liambotis has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/404442 ) Change subject: Rename pmacct to netinsights also in hiera .. Rename pmacct to netinsights also in hiera Brown paper bag

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Rename pmacct to netinsights also in hiera

2018-01-16 Thread Faidon Liambotis (Code Review)
Faidon Liambotis has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/404442 ) Change subject: Rename pmacct to netinsights also in hiera .. Rename pmacct to netinsights also in hiera Brown paper bag fix for

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Rename role pmacct to netinsights

2018-01-16 Thread Faidon Liambotis (Code Review)
Faidon Liambotis has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/404441 ) Change subject: Rename role pmacct to netinsights .. Rename role pmacct to netinsights ...and add the base kafkatee class

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Rename role pmacct to netinsights

2018-01-16 Thread Faidon Liambotis (Code Review)
Faidon Liambotis has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/404441 ) Change subject: Rename role pmacct to netinsights .. Rename role pmacct to netinsights ...and add the base kafkatee class to it.

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Remove utils/expanderb.rb

2018-01-12 Thread Faidon Liambotis (Code Review)
Faidon Liambotis has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/403697 ) Change subject: Remove utils/expanderb.rb .. Remove utils/expanderb.rb Doesn't seem to be functional, and that in turn

[MediaWiki-commits] [Gerrit] operations/puppet[production]: wmflib/hiera: wrap long lines

2018-01-11 Thread Faidon Liambotis (Code Review)
Faidon Liambotis has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/403700 ) Change subject: wmflib/hiera: wrap long lines .. wmflib/hiera: wrap long lines Therefore allowing us to reduce Metrics/LineLength

[MediaWiki-commits] [Gerrit] operations/puppet[production]: base: wrap lines in check_puppetrun to < 110

2018-01-11 Thread Faidon Liambotis (Code Review)
Faidon Liambotis has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/403698 ) Change subject: base: wrap lines in check_puppetrun to < 110 .. base: wrap lines in check_puppetrun to < 110 Change-Id:

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Remove utils/expanderb.rb

2018-01-11 Thread Faidon Liambotis (Code Review)
Faidon Liambotis has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/403697 ) Change subject: Remove utils/expanderb.rb .. Remove utils/expanderb.rb Doesn't seem to be functional, and that in turn doesn't

[MediaWiki-commits] [Gerrit] operations/puppet[production]: network: reword slice_network_constants' errors

2018-01-11 Thread Faidon Liambotis (Code Review)
Faidon Liambotis has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/403699 ) Change subject: network: reword slice_network_constants' errors .. network: reword slice_network_constants' errors Too

[MediaWiki-commits] [Gerrit] operations/puppet[production]: utils: fix Style/GlobalVars cop violations

2018-01-11 Thread Faidon Liambotis (Code Review)
Faidon Liambotis has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/403616 ) Change subject: utils: fix Style/GlobalVars cop violations .. utils: fix Style/GlobalVars cop violations Change-Id:

[MediaWiki-commits] [Gerrit] operations/puppet[production]: utils: fix Style/GlobalVars cop violations

2018-01-11 Thread Faidon Liambotis (Code Review)
Faidon Liambotis has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/403616 ) Change subject: utils: fix Style/GlobalVars cop violations .. utils: fix Style/GlobalVars cop violations Change-Id:

[MediaWiki-commits] [Gerrit] operations/puppet[production]: wmflib: fix two RuboCop cops in require_package

2018-01-10 Thread Faidon Liambotis (Code Review)
Faidon Liambotis has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/403378 ) Change subject: wmflib: fix two RuboCop cops in require_package .. wmflib: fix two RuboCop cops in require_package Fix

[MediaWiki-commits] [Gerrit] operations/puppet[production]: wmflib: fix two RuboCop cops in require_package

2018-01-10 Thread Faidon Liambotis (Code Review)
Faidon Liambotis has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/403378 ) Change subject: wmflib: fix two RuboCop cops in require_package .. wmflib: fix two RuboCop cops in require_package Fix

[MediaWiki-commits] [Gerrit] operations/puppet[production]: rubocop: move three ignores to .rubocop.yml

2018-01-10 Thread Faidon Liambotis (Code Review)
Faidon Liambotis has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/359485 ) Change subject: rubocop: move three ignores to .rubocop.yml .. rubocop: move three ignores to .rubocop.yml As these are

[MediaWiki-commits] [Gerrit] operations/puppet[production]: tor: add an additional relay instance

2017-12-22 Thread Faidon Liambotis (Code Review)
Faidon Liambotis has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/399972 ) Change subject: tor: add an additional relay instance .. tor: add an additional relay instance Tor is notoriously bad at being

[MediaWiki-commits] [Gerrit] operations/puppet[production]: wmflib/to_milliseconds: fix two minor RuboCop cops

2017-12-12 Thread Faidon Liambotis (Code Review)
Faidon Liambotis has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/359450 ) Change subject: wmflib/to_milliseconds: fix two minor RuboCop cops .. wmflib/to_milliseconds: fix two minor RuboCop cops

[MediaWiki-commits] [Gerrit] operations/puppet[production]: puppet_statsd: fix three RuboCop offenses

2017-12-12 Thread Faidon Liambotis (Code Review)
Faidon Liambotis has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/397812 ) Change subject: puppet_statsd: fix three RuboCop offenses .. puppet_statsd: fix three RuboCop offenses -

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Fix Style/NumericLiterals RuboCop offense

2017-12-12 Thread Faidon Liambotis (Code Review)
Faidon Liambotis has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/397811 ) Change subject: Fix Style/NumericLiterals RuboCop offense .. Fix Style/NumericLiterals RuboCop offense Change-Id:

[MediaWiki-commits] [Gerrit] operations/puppet[production]: rubocop: remove exceptions for non-existent files

2017-12-12 Thread Faidon Liambotis (Code Review)
Faidon Liambotis has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/397810 ) Change subject: rubocop: remove exceptions for non-existent files .. rubocop: remove exceptions for non-existent files

[MediaWiki-commits] [Gerrit] operations/puppet[production]: puppet_statsd: fix three RuboCop offenses

2017-12-12 Thread Faidon Liambotis (Code Review)
Faidon Liambotis has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/397812 ) Change subject: puppet_statsd: fix three RuboCop offenses .. puppet_statsd: fix three RuboCop offenses - Layout/SpaceAfterComma -

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Fix Style/NumericLiterals RuboCop offense

2017-12-12 Thread Faidon Liambotis (Code Review)
Faidon Liambotis has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/397811 ) Change subject: Fix Style/NumericLiterals RuboCop offense .. Fix Style/NumericLiterals RuboCop offense Change-Id:

[MediaWiki-commits] [Gerrit] operations/puppet[production]: rubocop: remove exceptions for non-existent files

2017-12-12 Thread Faidon Liambotis (Code Review)
Faidon Liambotis has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/397810 ) Change subject: rubocop: remove exceptions for non-existent files .. rubocop: remove exceptions for non-existent files

[MediaWiki-commits] [Gerrit] operations/puppet[production]: geoip: add GeoIP2-ISP to the list

2017-12-05 Thread Faidon Liambotis (Code Review)
Faidon Liambotis has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/395549 ) Change subject: geoip: add GeoIP2-ISP to the list .. geoip: add GeoIP2-ISP to the list Change-Id:

[MediaWiki-commits] [Gerrit] operations/puppet[production]: geoip: add GeoIP2-ISP to the list

2017-12-05 Thread Faidon Liambotis (Code Review)
Faidon Liambotis has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/395549 ) Change subject: geoip: add GeoIP2-ISP to the list .. geoip: add GeoIP2-ISP to the list Change-Id:

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Include geoip in kafkatee::webrequest::ops

2017-11-27 Thread Faidon Liambotis (Code Review)
Faidon Liambotis has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/393536 ) Change subject: Include geoip in kafkatee::webrequest::ops .. Include geoip in kafkatee::webrequest::ops Make the GeoIP

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Include geoip in kafkatee::webrequest::ops

2017-11-26 Thread Faidon Liambotis (Code Review)
Faidon Liambotis has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/393536 ) Change subject: Include geoip in kafkatee::webrequest::ops .. Include geoip in kafkatee::webrequest::ops Make the GeoIP databases

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Remove unjustified overbroad /8 network from blocklist

2017-11-07 Thread Faidon Liambotis (Code Review)
Faidon Liambotis has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/389888 ) Change subject: Remove unjustified overbroad /8 network from blocklist .. Remove unjustified overbroad /8 network from

[MediaWiki-commits] [Gerrit] operations/dns[master]: Add reverse DNS zones for APNIC space

2017-10-20 Thread Faidon Liambotis (Code Review)
Faidon Liambotis has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/385366 ) Change subject: Add reverse DNS zones for APNIC space .. Add reverse DNS zones for APNIC space - 103.102.166.0/24 -

[MediaWiki-commits] [Gerrit] operations/dns[master]: Add reverse DNS zones for APNIC space

2017-10-20 Thread Faidon Liambotis (Code Review)
Faidon Liambotis has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/385366 ) Change subject: Add reverse DNS zones for APNIC space .. Add reverse DNS zones for APNIC space - 103.102.166.0/24 -

[MediaWiki-commits] [Gerrit] operations/puppet[production]: mirrors: use correct path for the config file

2017-10-17 Thread Faidon Liambotis (Code Review)
Faidon Liambotis has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/384803 ) Change subject: mirrors: use correct path for the config file .. mirrors: use correct path for the config file Change-Id:

[MediaWiki-commits] [Gerrit] operations/puppet[production]: mirrors: use correct path for the config file

2017-10-17 Thread Faidon Liambotis (Code Review)
Faidon Liambotis has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384803 ) Change subject: mirrors: use correct path for the config file .. mirrors: use correct path for the config file Change-Id:

[MediaWiki-commits] [Gerrit] operations/puppet[production]: mirrors: stop shipping ftpsync, use package instead

2017-10-17 Thread Faidon Liambotis (Code Review)
Faidon Liambotis has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/384791 ) Change subject: mirrors: stop shipping ftpsync, use package instead .. mirrors: stop shipping ftpsync, use package instead

[MediaWiki-commits] [Gerrit] operations/puppet[production]: mirrors: stop shipping ftpsync, use package instead

2017-10-17 Thread Faidon Liambotis (Code Review)
Faidon Liambotis has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/384791 ) Change subject: mirrors: stop shipping ftpsync, use package instead .. mirrors: stop shipping ftpsync, use package instead

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Remove ELF binaries from across the tree

2017-10-02 Thread Faidon Liambotis (Code Review)
Faidon Liambotis has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/381901 ) Change subject: Remove ELF binaries from across the tree .. Remove ELF binaries from across the tree Compiled binaries do

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Remove ELF binaries from across the tree

2017-10-02 Thread Faidon Liambotis (Code Review)
Faidon Liambotis has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/381901 ) Change subject: Remove ELF binaries from across the tree .. Remove ELF binaries from across the tree …as compiled binaries do not

[MediaWiki-commits] [Gerrit] operations/puppet[production]: interface::offload: remove hardcoded default eth0

2017-09-25 Thread Faidon Liambotis (Code Review)
Faidon Liambotis has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/380574 ) Change subject: interface::offload: remove hardcoded default eth0 .. interface::offload: remove hardcoded default eth0

[MediaWiki-commits] [Gerrit] operations/puppet[production]: interface::offload: remove hardcoded default eth0

2017-09-25 Thread Faidon Liambotis (Code Review)
Faidon Liambotis has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/380574 ) Change subject: interface::offload: remove hardcoded default eth0 .. interface::offload: remove hardcoded default eth0 Commit

[MediaWiki-commits] [Gerrit] operations/puppet[production]: openstack2: de-duplicate parameter $nova_controller

2017-09-14 Thread Faidon Liambotis (Code Review)
Faidon Liambotis has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/378038 ) Change subject: openstack2: de-duplicate parameter $nova_controller .. openstack2: de-duplicate parameter $nova_controller

[MediaWiki-commits] [Gerrit] operations/puppet[production]: openstack2: de-duplicate parameter $nova_controller

2017-09-14 Thread Faidon Liambotis (Code Review)
Faidon Liambotis has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/378038 ) Change subject: openstack2: de-duplicate parameter $nova_controller .. openstack2: de-duplicate parameter $nova_controller The

[MediaWiki-commits] [Gerrit] operations/puppet[production]: hhvm: use '', not undef for light_process_file_prefix

2017-09-12 Thread Faidon Liambotis (Code Review)
Faidon Liambotis has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/377688 ) Change subject: hhvm: use '', not undef for light_process_file_prefix .. hhvm: use '', not undef for light_process_file_prefix

[MediaWiki-commits] [Gerrit] operations/puppet[production]: scap: do scope lookups in mw-deployment-vars.erb

2017-09-12 Thread Faidon Liambotis (Code Review)
Faidon Liambotis has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/377689 ) Change subject: scap: do scope lookups in mw-deployment-vars.erb .. scap: do scope lookups in mw-deployment-vars.erb

[MediaWiki-commits] [Gerrit] operations/puppet[production]: snapshot: do a proper scope lookup for apachedir

2017-09-12 Thread Faidon Liambotis (Code Review)
Faidon Liambotis has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/377686 ) Change subject: snapshot: do a proper scope lookup for apachedir .. snapshot: do a proper scope lookup for apachedir

[MediaWiki-commits] [Gerrit] operations/puppet[production]: snapshot: do a proper scope lookup for apachedir

2017-09-12 Thread Faidon Liambotis (Code Review)
Faidon Liambotis has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/377686 ) Change subject: snapshot: do a proper scope lookup for apachedir .. snapshot: do a proper scope lookup for apachedir

[MediaWiki-commits] [Gerrit] operations/puppet[production]: role::snapshot::common: properly scope included classes

2017-09-12 Thread Faidon Liambotis (Code Review)
Faidon Liambotis has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/377493 ) Change subject: role::snapshot::common: properly scope included classes .. role::snapshot::common: properly scope included

[MediaWiki-commits] [Gerrit] operations/puppet[production]: salt: change roots/runner_dir from Array to String

2017-09-12 Thread Faidon Liambotis (Code Review)
Faidon Liambotis has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/377676 ) Change subject: salt: change roots/runner_dir from Array to String .. salt: change roots/runner_dir from Array to String

[MediaWiki-commits] [Gerrit] operations/puppet[production]: racktables: pass $racktables_host to module

2017-09-12 Thread Faidon Liambotis (Code Review)
Faidon Liambotis has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/377669 ) Change subject: racktables: pass $racktables_host to module .. racktables: pass $racktables_host to module

[MediaWiki-commits] [Gerrit] operations/puppet[production]: openstack2: use !~ instead of ! $title =~ /.../

2017-09-12 Thread Faidon Liambotis (Code Review)
Faidon Liambotis has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/377512 ) Change subject: openstack2: use !~ instead of ! $title =~ /.../ .. openstack2: use !~ instead of ! $title =~ /.../

[MediaWiki-commits] [Gerrit] operations/puppet[production]: salt: change roots/runner_dir from Array to String

2017-09-12 Thread Faidon Liambotis (Code Review)
Faidon Liambotis has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/377676 ) Change subject: salt: change roots/runner_dir from Array to String .. salt: change roots/runner_dir from Array to String In the

[MediaWiki-commits] [Gerrit] operations/puppet[production]: racktables: pass $racktables_host to module

2017-09-12 Thread Faidon Liambotis (Code Review)
Faidon Liambotis has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/377669 ) Change subject: racktables: pass $racktables_host to module .. racktables: pass $racktables_host to module $racktables_host is

[MediaWiki-commits] [Gerrit] operations/puppet[production]: openstack2: use !~ instead of ! $title =~ /.../

2017-09-12 Thread Faidon Liambotis (Code Review)
Faidon Liambotis has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/377512 ) Change subject: openstack2: use !~ instead of ! $title =~ /.../ .. openstack2: use !~ instead of ! $title =~ /.../ Current form

[MediaWiki-commits] [Gerrit] operations/puppet[production]: thumbor: fix weird integer interpolation

2017-09-12 Thread Faidon Liambotis (Code Review)
Faidon Liambotis has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/377513 ) Change subject: thumbor: fix weird integer interpolation .. thumbor: fix weird integer interpolation This addresses a an issue

[MediaWiki-commits] [Gerrit] operations/puppet[production]: nagios_common: use the template if empty($content)

2017-09-12 Thread Faidon Liambotis (Code Review)
Faidon Liambotis has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/377445 ) Change subject: nagios_common: use the template if empty($content) .. nagios_common: use the template if empty($content) We

[MediaWiki-commits] [Gerrit] operations/puppet[production]: grafana: quote 'type' as the class' parameter

2017-09-12 Thread Faidon Liambotis (Code Review)
Faidon Liambotis has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/377444 ) Change subject: grafana: quote 'type' as the class' parameter .. grafana: quote 'type' as the class' parameter As type is a

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Use String as redis::instance's $name (noop)

2017-09-12 Thread Faidon Liambotis (Code Review)
Faidon Liambotis has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/377440 ) Change subject: Use String as redis::instance's $name (noop) .. Use String as redis::instance's $name (noop) Replace instances

[MediaWiki-commits] [Gerrit] operations/puppet[production]: ganglia: fix class dependencies

2017-09-12 Thread Faidon Liambotis (Code Review)
Faidon Liambotis has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/377441 ) Change subject: ganglia: fix class dependencies .. ganglia: fix class dependencies Depend on Class['::ganglia::web'] instead of

[MediaWiki-commits] [Gerrit] operations/puppet[production]: openstack: move $ssl_settings near the template

2017-09-12 Thread Faidon Liambotis (Code Review)
Faidon Liambotis has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/377442 ) Change subject: openstack: move $ssl_settings near the template .. openstack: move $ssl_settings near the template As passing it

[MediaWiki-commits] [Gerrit] operations/puppet[production]: statsd_proxy: use validate_numeric()

2017-09-12 Thread Faidon Liambotis (Code Review)
Faidon Liambotis has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/377439 ) Change subject: statsd_proxy: use validate_numeric() .. statsd_proxy: use validate_numeric() Use validate_numeric() to validate

[MediaWiki-commits] [Gerrit] operations/puppet[production]: uwsgi: use validate_numeric()

2017-09-12 Thread Faidon Liambotis (Code Review)
Faidon Liambotis has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/377438 ) Change subject: uwsgi: use validate_numeric() .. uwsgi: use validate_numeric() Use validate_numeric() to validate the $port

[MediaWiki-commits] [Gerrit] operations/puppet[production]: swift: use !~ instead of ! $title =~ /.../

2017-09-12 Thread Faidon Liambotis (Code Review)
Faidon Liambotis has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/377436 ) Change subject: swift: use !~ instead of ! $title =~ /.../ .. swift: use !~ instead of ! $title =~ /.../ Current form breaks with

[MediaWiki-commits] [Gerrit] operations/puppet[production]: nutcracker: use validate_numeric()

2017-09-12 Thread Faidon Liambotis (Code Review)
Faidon Liambotis has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/377437 ) Change subject: nutcracker: use validate_numeric() .. nutcracker: use validate_numeric() Use validate_numeric() instead of

[MediaWiki-commits] [Gerrit] operations/dns[master]: Add mgmt IPs for cr3-esams, new MX480

2017-08-29 Thread Faidon Liambotis (Code Review)
Faidon Liambotis has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/374548 ) Change subject: Add mgmt IPs for cr3-esams, new MX480 .. Add mgmt IPs for cr3-esams, new MX480 Change-Id:

[MediaWiki-commits] [Gerrit] operations/dns[master]: Add mgmt IPs for cr3-esams, new MX480

2017-08-29 Thread Faidon Liambotis (Code Review)
Faidon Liambotis has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/374548 ) Change subject: Add mgmt IPs for cr3-esams, new MX480 .. Add mgmt IPs for cr3-esams, new MX480 Change-Id:

[MediaWiki-commits] [Gerrit] operations/dns[master]: Add sandbox1-esams and ripe-atlas-esams

2017-08-29 Thread Faidon Liambotis (Code Review)
Faidon Liambotis has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/374545 ) Change subject: Add sandbox1-esams and ripe-atlas-esams .. Add sandbox1-esams and ripe-atlas-esams Change-Id:

[MediaWiki-commits] [Gerrit] operations/dns[master]: Add sandbox1-esams and ripe-atlas-esams

2017-08-29 Thread Faidon Liambotis (Code Review)
Faidon Liambotis has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/374545 ) Change subject: Add sandbox1-esams and ripe-atlas-esams .. Add sandbox1-esams and ripe-atlas-esams Change-Id:

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Add SPF and DKIM perl package requires to spamassassin class

2017-08-28 Thread Faidon Liambotis (Code Review)
Faidon Liambotis has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/370487 ) Change subject: Add SPF and DKIM perl package requires to spamassassin class .. Add SPF and DKIM perl package requires to

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Delete stray patch file

2017-08-23 Thread Faidon Liambotis (Code Review)
Faidon Liambotis has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/373281 ) Change subject: Delete stray patch file .. Delete stray patch file Introduced accidentally in commit 73964dd. Change-Id:

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Delete stray patch file

2017-08-23 Thread Faidon Liambotis (Code Review)
Faidon Liambotis has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/373281 ) Change subject: Delete stray patch file .. Delete stray patch file Introduced accidentally in commit 73964dd. Change-Id:

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Revert "Kill module puppet_statsd"

2017-07-26 Thread Faidon Liambotis (Code Review)
Faidon Liambotis has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/367877 ) Change subject: Revert "Kill module puppet_statsd" .. Revert "Kill module puppet_statsd" This reverts commit

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Revert "Kill module puppet_statsd"

2017-07-26 Thread Faidon Liambotis (Code Review)
Hello Giuseppe Lavagetto, Alexandros Kosiaris, jenkins-bot, I'd like you to do a code review. Please visit https://gerrit.wikimedia.org/r/367877 to review the following change. Change subject: Revert "Kill module puppet_statsd"

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Kill module puppet_statsd

2017-07-26 Thread Faidon Liambotis (Code Review)
Faidon Liambotis has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/359448 ) Change subject: Kill module puppet_statsd .. Kill module puppet_statsd Unused in years. We can always revert if we ever

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Use Python yaml.safe_load everywhere

2017-07-25 Thread Faidon Liambotis (Code Review)
Faidon Liambotis has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/367671 ) Change subject: Use Python yaml.safe_load everywhere .. Use Python yaml.safe_load everywhere We don't really have a use

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Use Python yaml.safe_load everywhere

2017-07-25 Thread Faidon Liambotis (Code Review)
Faidon Liambotis has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/367671 ) Change subject: Use Python yaml.safe_load everywhere .. Use Python yaml.safe_load everywhere We don't really have a use case for

[MediaWiki-commits] [Gerrit] operations/puppet[production]: base: cleanup absented CAs

2017-07-20 Thread Faidon Liambotis (Code Review)
Faidon Liambotis has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/366518 ) Change subject: base: cleanup absented CAs .. base: cleanup absented CAs Remove the WMF CA 2014-2017 & RapidSSL ensure =>

[MediaWiki-commits] [Gerrit] operations/puppet[production]: motd::script: use validate_numeric for priority

2017-07-20 Thread Faidon Liambotis (Code Review)
Faidon Liambotis has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/365569 ) Change subject: motd::script: use validate_numeric for priority .. motd::script: use validate_numeric for priority This

[MediaWiki-commits] [Gerrit] operations/puppet[production]: base: remove WMF CA 2014-2017

2017-07-20 Thread Faidon Liambotis (Code Review)
Faidon Liambotis has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/366517 ) Change subject: base: remove WMF CA 2014-2017 .. base: remove WMF CA 2014-2017 Expired & replaced by WMF CA 2017-2020.

[MediaWiki-commits] [Gerrit] operations/puppet[production]: base: cleanup absented CAs

2017-07-20 Thread Faidon Liambotis (Code Review)
Faidon Liambotis has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/366518 ) Change subject: base: cleanup absented CAs .. base: cleanup absented CAs Remove the WMF CA 2014-2017 & RapidSSL ensure => absent,

[MediaWiki-commits] [Gerrit] operations/puppet[production]: base: remove WMF CA 2014-2017

2017-07-20 Thread Faidon Liambotis (Code Review)
Faidon Liambotis has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/366517 ) Change subject: base: remove WMF CA 2014-2017 .. base: remove WMF CA 2014-2017 Expired & replaced by WMF CA 2017-2020.

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Update ldap-corp.{eqiad, codfw}.wikimedia certs

2017-07-19 Thread Faidon Liambotis (Code Review)
Faidon Liambotis has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/366462 ) Change subject: Update ldap-corp.{eqiad,codfw}.wikimedia certs .. Update ldap-corp.{eqiad,codfw}.wikimedia certs Update:

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Update ldap-corp.{eqiad, codfw}.wikimedia certs

2017-07-19 Thread Faidon Liambotis (Code Review)
Faidon Liambotis has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/366462 ) Change subject: Update ldap-corp.{eqiad,codfw}.wikimedia certs .. Update ldap-corp.{eqiad,codfw}.wikimedia certs Update: -

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Update ldap-labs.{eqiad, codfw}.wikimedia certs

2017-07-19 Thread Faidon Liambotis (Code Review)
Faidon Liambotis has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/366428 ) Change subject: Update ldap-labs.{eqiad,codfw}.wikimedia certs .. Update ldap-labs.{eqiad,codfw}.wikimedia certs Update:

[MediaWiki-commits] [Gerrit] operations/puppet[production]: base: add new WMF 2017-2020 Certificate Authority

2017-07-19 Thread Faidon Liambotis (Code Review)
Faidon Liambotis has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/366422 ) Change subject: base: add new WMF 2017-2020 Certificate Authority .. base: add new WMF 2017-2020 Certificate Authority

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Update ldap-labs.{eqiad, codfw}.wikimedia certs

2017-07-19 Thread Faidon Liambotis (Code Review)
Faidon Liambotis has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/366428 ) Change subject: Update ldap-labs.{eqiad,codfw}.wikimedia certs .. Update ldap-labs.{eqiad,codfw}.wikimedia certs Update: -

[MediaWiki-commits] [Gerrit] operations/puppet[production]: base: add new WMF 2017-2020 Certificate Authority

2017-07-19 Thread Faidon Liambotis (Code Review)
Faidon Liambotis has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/366422 ) Change subject: base: add new WMF 2017-2020 Certificate Authority .. base: add new WMF 2017-2020 Certificate Authority Change-Id:

[MediaWiki-commits] [Gerrit] operations/puppet[production]: aptrepo: drop files/log, use templates/log.erb

2017-07-17 Thread Faidon Liambotis (Code Review)
Faidon Liambotis has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/365633 ) Change subject: aptrepo: drop files/log, use templates/log.erb .. aptrepo: drop files/log, use templates/log.erb For some

  1   2   3   4   5   6   7   8   9   10   >