[MediaWiki-commits] [Gerrit] T121174: Carry over paramInfo when unpacking DOMFragment - change (mediawiki...parsoid)

2015-12-10 Thread Inez (Code Review)
Inez has uploaded a new change for review. https://gerrit.wikimedia.org/r/258386 Change subject: T121174: Carry over paramInfo when unpacking DOMFragment .. T121174: Carry over paramInfo when unpacking DOMFragment Change-Id:

[MediaWiki-commits] [Gerrit] Fix for endless loop in SelectWidget - change (oojs/ui)

2014-09-26 Thread Inez (Code Review)
Inez has uploaded a new change for review. https://gerrit.wikimedia.org/r/163273 Change subject: Fix for endless loop in SelectWidget .. Fix for endless loop in SelectWidget In case when there are no results

[MediaWiki-commits] [Gerrit] Fix ve.init.mw.TargetEvents.js to subscribe to events that a... - change (mediawiki...VisualEditor)

2014-07-31 Thread Inez (Code Review)
Inez has uploaded a new change for review. https://gerrit.wikimedia.org/r/150983 Change subject: Fix ve.init.mw.TargetEvents.js to subscribe to events that actually exists and are emitted .. Fix ve.init.mw.TargetEvents.js to

[MediaWiki-commits] [Gerrit] Blur contentEditable node while destroying surface. - change (VisualEditor/VisualEditor)

2014-07-03 Thread Inez (Code Review)
Inez has uploaded a new change for review. https://gerrit.wikimedia.org/r/144089 Change subject: Blur contentEditable node while destroying surface. .. Blur contentEditable node while destroying surface. This solves problem

[MediaWiki-commits] [Gerrit] Support for passing API endpoint to be used in the URL (enco... - change (mediawiki...parsoid)

2014-04-17 Thread Inez (Code Review)
Inez has uploaded a new change for review. https://gerrit.wikimedia.org/r/127172 Change subject: Support for passing API endpoint to be used in the URL (encoded) instead of having to specify it in the localsettings.js ..

[MediaWiki-commits] [Gerrit] (bug 54727) item itself is an item, there is no need to try ... - change (mediawiki...VisualEditor)

2013-09-27 Thread Inez (Code Review)
Inez has uploaded a new change for review. https://gerrit.wikimedia.org/r/86341 Change subject: (bug 54727) item itself is an item, there is no need to try to pass item of that item .. (bug 54727) item itself is an item,

[MediaWiki-commits] [Gerrit] Modify mockAPI to return correct answer for not existing files - change (mediawiki...Parsoid)

2013-09-13 Thread Inez (Code Review)
Inez has uploaded a new change for review. https://gerrit.wikimedia.org/r/84186 Change subject: Modify mockAPI to return correct answer for not existing files .. Modify mockAPI to return correct answer for not existing files

[MediaWiki-commits] [Gerrit] Define RDFa types in ve.dm.MWInlineImageNode once and reuse ... - change (mediawiki...VisualEditor)

2013-09-09 Thread Inez (Code Review)
Inez has uploaded a new change for review. https://gerrit.wikimedia.org/r/83503 Change subject: Define RDFa types in ve.dm.MWInlineImageNode once and reuse whenever possible .. Define RDFa types in ve.dm.MWInlineImageNode

[MediaWiki-commits] [Gerrit] Apply DOM changes in onProtectedSetup and onProtectedTeatdow... - change (mediawiki...VisualEditor)

2013-09-05 Thread Inez (Code Review)
Inez has uploaded a new change for review. https://gerrit.wikimedia.org/r/82943 Change subject: Apply DOM changes in onProtectedSetup and onProtectedTeatdown instead of construictor .. Apply DOM changes in onProtectedSetup

[MediaWiki-commits] [Gerrit] Define RDFa types in ve.dm.MWBlockImageNode once and reuse w... - change (mediawiki...VisualEditor)

2013-09-05 Thread Inez (Code Review)
Inez has uploaded a new change for review. https://gerrit.wikimedia.org/r/83006 Change subject: Define RDFa types in ve.dm.MWBlockImageNode once and reuse whenever possible .. Define RDFa types in ve.dm.MWBlockImageNode

[MediaWiki-commits] [Gerrit] (bug 51995) Bugfix - change (mediawiki...VisualEditor)

2013-07-24 Thread Inez (Code Review)
Inez has uploaded a new change for review. https://gerrit.wikimedia.org/r/75803 Change subject: (bug 51995) Bugfix .. (bug 51995) Bugfix Introduce method ve.ce.MWBlockImageNode.getCssClass and use it instead of accessing

[MediaWiki-commits] [Gerrit] (WIP) Support for galleries in Parsoid - change (mediawiki...Parsoid)

2013-07-12 Thread Inez (Code Review)
Inez has uploaded a new change for review. https://gerrit.wikimedia.org/r/73406 Change subject: (WIP) Support for galleries in Parsoid .. (WIP) Support for galleries in Parsoid Change-Id:

[MediaWiki-commits] [Gerrit] Performance optimizations for ve.ce.ProtectedNode - change (mediawiki...VisualEditor)

2013-07-05 Thread Inez (Code Review)
Inez has uploaded a new change for review. https://gerrit.wikimedia.org/r/72113 Change subject: Performance optimizations for ve.ce.ProtectedNode .. Performance optimizations for ve.ce.ProtectedNode * shields are create in

[MediaWiki-commits] [Gerrit] (bug 47947) Allow creating lists while selection is collapse... - change (mediawiki...VisualEditor)

2013-07-01 Thread Inez (Code Review)
Inez has uploaded a new change for review. https://gerrit.wikimedia.org/r/71353 Change subject: (bug 47947) Allow creating lists while selection is collapsed and in block slug .. (bug 47947) Allow creating lists while

[MediaWiki-commits] [Gerrit] Make toolbar look correct in case of non-standard browser fo... - change (mediawiki...VisualEditor)

2013-06-30 Thread Inez (Code Review)
Inez has uploaded a new change for review. https://gerrit.wikimedia.org/r/71284 Change subject: Make toolbar look correct in case of non-standard browser font size settings .. Make toolbar look correct in case of

[MediaWiki-commits] [Gerrit] (WIP) Do not allow to resize thumb image to be bigger than o... - change (mediawiki...VisualEditor)

2013-06-30 Thread Inez (Code Review)
Inez has uploaded a new change for review. https://gerrit.wikimedia.org/r/71285 Change subject: (WIP) Do not allow to resize thumb image to be bigger than original file .. (WIP) Do not allow to resize thumb image to be

[MediaWiki-commits] [Gerrit] Simplify ve.ce.ResizableNode by removing code for 'transitio... - change (mediawiki...VisualEditor)

2013-06-30 Thread Inez (Code Review)
Inez has uploaded a new change for review. https://gerrit.wikimedia.org/r/71286 Change subject: Simplify ve.ce.ResizableNode by removing code for 'transition' which is not used anyway .. Simplify ve.ce.ResizableNode by

[MediaWiki-commits] [Gerrit] Make node resizing happen inside onAttributeChange - change (mediawiki...VisualEditor)

2013-06-30 Thread Inez (Code Review)
Inez has uploaded a new change for review. https://gerrit.wikimedia.org/r/71287 Change subject: Make node resizing happen inside onAttributeChange .. Make node resizing happen inside onAttributeChange This change fixed not

[MediaWiki-commits] [Gerrit] Set renderHtmlAttributes to false, for both block and inline... - change (mediawiki...VisualEditor)

2013-06-28 Thread Inez (Code Review)
Inez has uploaded a new change for review. https://gerrit.wikimedia.org/r/71109 Change subject: Set renderHtmlAttributes to false, for both block and inline transclusions .. Set renderHtmlAttributes to false, for both block

[MediaWiki-commits] [Gerrit] Minor performance optimization and cleanup in FocusableNode - change (mediawiki...VisualEditor)

2013-06-28 Thread Inez (Code Review)
Inez has uploaded a new change for review. https://gerrit.wikimedia.org/r/71137 Change subject: Minor performance optimization and cleanup in FocusableNode .. Minor performance optimization and cleanup in FocusableNode

[MediaWiki-commits] [Gerrit] Get rid of mw-figcaption class (Parsoid does not use it anym... - change (mediawiki...VisualEditor)

2013-06-27 Thread Inez (Code Review)
Inez has uploaded a new change for review. https://gerrit.wikimedia.org/r/70934 Change subject: Get rid of mw-figcaption class (Parsoid does not use it anymore) .. Get rid of mw-figcaption class (Parsoid does not use it

[MediaWiki-commits] [Gerrit] (bug 49424) Add empty lines before/after new block level images - change (mediawiki...Parsoid)

2013-06-27 Thread Inez (Code Review)
Inez has uploaded a new change for review. https://gerrit.wikimedia.org/r/70949 Change subject: (bug 49424) Add empty lines before/after new block level images .. (bug 49424) Add empty lines before/after new block level

[MediaWiki-commits] [Gerrit] Revert (WIP) Cleanup for handling image size - change (mediawiki...Parsoid)

2013-06-26 Thread Inez (Code Review)
Inez has uploaded a new change for review. https://gerrit.wikimedia.org/r/70784 Change subject: Revert (WIP) Cleanup for handling image size .. Revert (WIP) Cleanup for handling image size This reverts commit

[MediaWiki-commits] [Gerrit] Always prefer 'thumb' over 'thumbnail' when serializing HTML... - change (mediawiki...Parsoid)

2013-06-25 Thread Inez (Code Review)
Inez has uploaded a new change for review. https://gerrit.wikimedia.org/r/70545 Change subject: Always prefer 'thumb' over 'thumbnail' when serializing HTML DOM to wikitext .. Always prefer 'thumb' over 'thumbnail' when

[MediaWiki-commits] [Gerrit] Don't set link parameter for block image if value of href is... - change (mediawiki...Parsoid)

2013-06-25 Thread Inez (Code Review)
Inez has uploaded a new change for review. https://gerrit.wikimedia.org/r/70546 Change subject: Don't set link parameter for block image if value of href is empty .. Don't set link parameter for block image if value of href

[MediaWiki-commits] [Gerrit] Set href attribute of newly inserted image to image title - change (mediawiki...VisualEditor)

2013-06-25 Thread Inez (Code Review)
Inez has uploaded a new change for review. https://gerrit.wikimedia.org/r/70551 Change subject: Set href attribute of newly inserted image to image title .. Set href attribute of newly inserted image to image title I'm not

[MediaWiki-commits] [Gerrit] (bug 49696) Allow any number of spaces between int value and... - change (mediawiki...Parsoid)

2013-06-25 Thread Inez (Code Review)
Inez has uploaded a new change for review. https://gerrit.wikimedia.org/r/70573 Change subject: (bug 49696) Allow any number of spaces between int value and 'px' in value of width/height for images .. (bug 49696) Allow any

[MediaWiki-commits] [Gerrit] (WIP) Cleanup for handling image size - change (mediawiki...Parsoid)

2013-06-25 Thread Inez (Code Review)
Inez has uploaded a new change for review. https://gerrit.wikimedia.org/r/70578 Change subject: (WIP) Cleanup for handling image size .. (WIP) Cleanup for handling image size Change-Id:

[MediaWiki-commits] [Gerrit] Do not apply unnecessary file dimensions constraints - change (mediawiki...Parsoid)

2013-06-24 Thread Inez (Code Review)
Inez has uploaded a new change for review. https://gerrit.wikimedia.org/r/70308 Change subject: Do not apply unnecessary file dimensions constraints .. Do not apply unnecessary file dimensions constraints I'm not sure

[MediaWiki-commits] [Gerrit] (bug 50113) Do not display captions for block images which a... - change (mediawiki...VisualEditor)

2013-06-24 Thread Inez (Code Review)
Inez has uploaded a new change for review. https://gerrit.wikimedia.org/r/70336 Change subject: (bug 50113) Do not display captions for block images which are neither frame nor thumb .. (bug 50113) Do not display captions

[MediaWiki-commits] [Gerrit] (bug 49849) Fix for retrieving localized version of align at... - change (mediawiki...Parsoid)

2013-06-24 Thread Inez (Code Review)
Inez has uploaded a new change for review. https://gerrit.wikimedia.org/r/70343 Change subject: (bug 49849) Fix for retrieving localized version of align attribute for images .. (bug 49849) Fix for retrieving localized

[MediaWiki-commits] [Gerrit] (bug 43015) Make Parsoid use protocol relative URLs for imag... - change (mediawiki...Parsoid)

2013-06-24 Thread Inez (Code Review)
Inez has uploaded a new change for review. https://gerrit.wikimedia.org/r/70344 Change subject: (bug 43015) Make Parsoid use protocol relative URLs for images (http vs. https) .. (bug 43015) Make Parsoid use protocol

[MediaWiki-commits] [Gerrit] Adjust parserTests.txt for bug 43015 - change (mediawiki/core)

2013-06-24 Thread Inez (Code Review)
Inez has uploaded a new change for review. https://gerrit.wikimedia.org/r/70348 Change subject: Adjust parserTests.txt for bug 43015 .. Adjust parserTests.txt for bug 43015 Change-Id:

[MediaWiki-commits] [Gerrit] Do not add empty figcaption to figure tag - change (mediawiki...VisualEditor)

2013-06-24 Thread Inez (Code Review)
Inez has uploaded a new change for review. https://gerrit.wikimedia.org/r/70357 Change subject: Do not add empty figcaption to figure tag .. Do not add empty figcaption to figure tag Change-Id:

[MediaWiki-commits] [Gerrit] Proper handling for block level frameless images - change (mediawiki...VisualEditor)

2013-06-24 Thread Inez (Code Review)
Inez has uploaded a new change for review. https://gerrit.wikimedia.org/r/70358 Change subject: Proper handling for block level frameless images .. Proper handling for block level frameless images Change-Id:

[MediaWiki-commits] [Gerrit] Adjust tests for gerrit 69509 - change (mediawiki/core)

2013-06-24 Thread Inez (Code Review)
Inez has uploaded a new change for review. https://gerrit.wikimedia.org/r/70365 Change subject: Adjust tests for gerrit 69509 .. Adjust tests for gerrit 69509 Change-Id: I38f3cbd36dbd2653ba5c18935619cf72834e30c5 --- M

[MediaWiki-commits] [Gerrit] Fix for rendering block images - change (mediawiki...VisualEditor)

2013-06-21 Thread Inez (Code Review)
Inez has uploaded a new change for review. https://gerrit.wikimedia.org/r/69899 Change subject: Fix for rendering block images .. Fix for rendering block images Change-Id: I4e5317f128f2b3f6742e7ed280c96fde37f52bb4 --- M

[MediaWiki-commits] [Gerrit] Fix incorrectly written CSS that was affecting all table cel... - change (mediawiki...VisualEditor)

2013-06-21 Thread Inez (Code Review)
Inez has uploaded a new change for review. https://gerrit.wikimedia.org/r/69901 Change subject: Fix incorrectly written CSS that was affecting all table cells on the page instead of cells in mwMetaDialog only .. Fix

[MediaWiki-commits] [Gerrit] Match data inserted from MWMediaInsertDialog with MWBlockIma... - change (mediawiki...VisualEditor)

2013-06-21 Thread Inez (Code Review)
Inez has uploaded a new change for review. https://gerrit.wikimedia.org/r/69902 Change subject: Match data inserted from MWMediaInsertDialog with MWBlockImageNode .. Match data inserted from MWMediaInsertDialog with

[MediaWiki-commits] [Gerrit] There is no need to apply CSS changes (width and height) to ... - change (mediawiki...VisualEditor)

2013-06-20 Thread Inez (Code Review)
Inez has uploaded a new change for review. https://gerrit.wikimedia.org/r/69810 Change subject: There is no need to apply CSS changes (width and height) to an image inside ve.ce.MWBlockImageNode because it is already handled in ve.ce.ResizableNode

[MediaWiki-commits] [Gerrit] (bug 49896) Dirty workaround - change (mediawiki...Parsoid)

2013-06-20 Thread Inez (Code Review)
Inez has uploaded a new change for review. https://gerrit.wikimedia.org/r/69822 Change subject: (bug 49896) Dirty workaround .. (bug 49896) Dirty workaround Change-Id: I9db6f0c7ab5162801545507bc08e220c7d107e6b --- M

[MediaWiki-commits] [Gerrit] Ignore shortcut keys inside key press handler - change (mediawiki...VisualEditor)

2013-06-19 Thread Inez (Code Review)
Inez has uploaded a new change for review. https://gerrit.wikimedia.org/r/69503 Change subject: Ignore shortcut keys inside key press handler .. Ignore shortcut keys inside key press handler Change-Id:

[MediaWiki-commits] [Gerrit] Always emit figcaption inside figure (even if caption is emp... - change (mediawiki...Parsoid)

2013-06-19 Thread Inez (Code Review)
Inez has uploaded a new change for review. https://gerrit.wikimedia.org/r/69509 Change subject: Always emit figcaption inside figure (even if caption is empty) and don't put mw-figcaption class on it (there is no value added in it)

[MediaWiki-commits] [Gerrit] Handle correctly figure tags with typeof=mw:Image - change (mediawiki...VisualEditor)

2013-06-19 Thread Inez (Code Review)
Inez has uploaded a new change for review. https://gerrit.wikimedia.org/r/69586 Change subject: Handle correctly figure tags with typeof=mw:Image .. Handle correctly figure tags with typeof=mw:Image Change-Id:

[MediaWiki-commits] [Gerrit] Added proper rendering (matching MediaWiki) for block images... - change (mediawiki...VisualEditor)

2013-06-19 Thread Inez (Code Review)
Inez has uploaded a new change for review. https://gerrit.wikimedia.org/r/69602 Change subject: Added proper rendering (matching MediaWiki) for block images which are not thumb nor frame .. Added proper rendering (matching

[MediaWiki-commits] [Gerrit] After figuring out that wikitext for caption is empty don't ... - change (mediawiki...Parsoid)

2013-06-18 Thread Inez (Code Review)
Inez has uploaded a new change for review. https://gerrit.wikimedia.org/r/69426 Change subject: After figuring out that wikitext for caption is empty don't process it any further .. After figuring out that wikitext for

[MediaWiki-commits] [Gerrit] Support for editing captions of block images - change (mediawiki...VisualEditor)

2013-06-18 Thread Inez (Code Review)
Inez has uploaded a new change for review. https://gerrit.wikimedia.org/r/69434 Change subject: Support for editing captions of block images .. Support for editing captions of block images Change-Id:

[MediaWiki-commits] [Gerrit] One method onAttributeChange in ve.ce.MWBlockImageNode is pl... - change (mediawiki...VisualEditor)

2013-06-18 Thread Inez (Code Review)
Inez has uploaded a new change for review. https://gerrit.wikimedia.org/r/69450 Change subject: One method onAttributeChange in ve.ce.MWBlockImageNode is plenty .. One method onAttributeChange in ve.ce.MWBlockImageNode is

[MediaWiki-commits] [Gerrit] Added ve.ce.FocusableNode mixin to ve.ce.MWReferenceListNode... - change (mediawiki...VisualEditor)

2013-06-17 Thread Inez (Code Review)
Inez has uploaded a new change for review. https://gerrit.wikimedia.org/r/69158 Change subject: Added ve.ce.FocusableNode mixin to ve.ce.MWReferenceListNode so its selection look better after user click on it .. Added

[MediaWiki-commits] [Gerrit] (WIP) Re-create DOM element for MWBlockImageNode only when n... - change (mediawiki...VisualEditor)

2013-06-17 Thread Inez (Code Review)
Inez has uploaded a new change for review. https://gerrit.wikimedia.org/r/69268 Change subject: (WIP) Re-create DOM element for MWBlockImageNode only when necessary .. (WIP) Re-create DOM element for MWBlockImageNode only

[MediaWiki-commits] [Gerrit] Initial import of Selenium tests and Chrome WebDriver for Ma... - change (mediawiki...VisualEditor)

2013-06-13 Thread Inez (Code Review)
Inez has uploaded a new change for review. https://gerrit.wikimedia.org/r/68605 Change subject: Initial import of Selenium tests and Chrome WebDriver for MacOS. .. Initial import of Selenium tests and Chrome WebDriver for

[MediaWiki-commits] [Gerrit] (bug 48335) Use more generic approach to filter out non-char... - change (mediawiki...VisualEditor)

2013-06-12 Thread Inez (Code Review)
Inez has uploaded a new change for review. https://gerrit.wikimedia.org/r/68296 Change subject: (bug 48335) Use more generic approach to filter out non-character key presses. .. (bug 48335) Use more generic approach to

[MediaWiki-commits] [Gerrit] (bug 43082) Fix problem by calling surfaceObserver.stop( tru... - change (mediawiki...VisualEditor)

2013-06-12 Thread Inez (Code Review)
Inez has uploaded a new change for review. https://gerrit.wikimedia.org/r/68300 Change subject: (bug 43082) Fix problem by calling surfaceObserver.stop( true ) first - before calling handleEnter. .. (bug 43082) Fix problem

[MediaWiki-commits] [Gerrit] (WIP) Handle deletion programmatically always. - change (mediawiki...VisualEditor)

2013-06-12 Thread Inez (Code Review)
Inez has uploaded a new change for review. https://gerrit.wikimedia.org/r/68332 Change subject: (WIP) Handle deletion programmatically always. .. (WIP) Handle deletion programmatically always. Change-Id:

[MediaWiki-commits] [Gerrit] Support for editing captions of block images. - change (mediawiki...VisualEditor)

2013-06-11 Thread Inez (Code Review)
Inez has uploaded a new change for review. https://gerrit.wikimedia.org/r/67952 Change subject: Support for editing captions of block images. .. Support for editing captions of block images. Change-Id:

[MediaWiki-commits] [Gerrit] Fix selection and hover for MW inline images. - change (mediawiki...VisualEditor)

2013-06-10 Thread Inez (Code Review)
Inez has uploaded a new change for review. https://gerrit.wikimedia.org/r/67897 Change subject: Fix selection and hover for MW inline images. .. Fix selection and hover for MW inline images. Change-Id:

[MediaWiki-commits] [Gerrit] Wrap inline images in spans with display: inline-block. - change (mediawiki...VisualEditor)

2013-06-10 Thread Inez (Code Review)
Inez has uploaded a new change for review. https://gerrit.wikimedia.org/r/67905 Change subject: Wrap inline images in spans with display: inline-block. .. Wrap inline images in spans with display: inline-block. Change-Id:

[MediaWiki-commits] [Gerrit] Use blacklist instead of whitelist for storeHtmlAttributes o... - change (mediawiki...VisualEditor)

2013-06-07 Thread Inez (Code Review)
Inez has uploaded a new change for review. https://gerrit.wikimedia.org/r/67550 Change subject: Use blacklist instead of whitelist for storeHtmlAttributes of MWBlockImageNode. .. Use blacklist instead of whitelist for

[MediaWiki-commits] [Gerrit] Let's not put slugs around lists because there is no such need. - change (mediawiki...VisualEditor)

2013-06-06 Thread Inez (Code Review)
Inez has uploaded a new change for review. https://gerrit.wikimedia.org/r/67283 Change subject: Let's not put slugs around lists because there is no such need. .. Let's not put slugs around lists because there is no such

[MediaWiki-commits] [Gerrit] Use classes collection instead of jQuery.hasClass (for perfo... - change (mediawiki...VisualEditor)

2013-06-06 Thread Inez (Code Review)
Inez has uploaded a new change for review. https://gerrit.wikimedia.org/r/67326 Change subject: Use classes collection instead of jQuery.hasClass (for performance reason). .. Use classes collection instead of

[MediaWiki-commits] [Gerrit] In case when MW does not scale images (down or up) do it in ... - change (mediawiki...Parsoid)

2013-06-06 Thread Inez (Code Review)
Inez has uploaded a new change for review. https://gerrit.wikimedia.org/r/67366 Change subject: In case when MW does not scale images (down or up) do it in Parsoid (the same way Parser would). .. In case when MW does not

[MediaWiki-commits] [Gerrit] For some reason we get text_bottom instead of text-bottom an... - change (mediawiki...Parsoid)

2013-06-06 Thread Inez (Code Review)
Inez has uploaded a new change for review. https://gerrit.wikimedia.org/r/67376 Change subject: For some reason we get text_bottom instead of text-bottom and text_top instead of text-top. .. For some reason we get

[MediaWiki-commits] [Gerrit] Support for inline images. - change (mediawiki...VisualEditor)

2013-06-06 Thread Inez (Code Review)
Inez has uploaded a new change for review. https://gerrit.wikimedia.org/r/67391 Change subject: Support for inline images. .. Support for inline images. Handles typeof mw:Image and mw:Image/Frameless Change-Id:

[MediaWiki-commits] [Gerrit] ve.dm.Converter: Fix too-much-ascending bug in Converter. - change (mediawiki...VisualEditor)

2013-06-05 Thread Inez (Code Review)
Inez has uploaded a new change for review. https://gerrit.wikimedia.org/r/67152 Change subject: ve.dm.Converter: Fix too-much-ascending bug in Converter. .. ve.dm.Converter: Fix too-much-ascending bug in Converter.

[MediaWiki-commits] [Gerrit] ve.dm.MWBlockImageNode: Make toDomElements add more informat... - change (mediawiki...VisualEditor)

2013-06-05 Thread Inez (Code Review)
Inez has uploaded a new change for review. https://gerrit.wikimedia.org/r/67163 Change subject: ve.dm.MWBlockImageNode: Make toDomElements add more information to its output so round-tripping can work properly. ..

[MediaWiki-commits] [Gerrit] 'typeof' for templates changed in Parsoid, it is 'Transclusi... - change (mediawiki...VisualEditor)

2013-06-05 Thread Inez (Code Review)
Inez has uploaded a new change for review. https://gerrit.wikimedia.org/r/67169 Change subject: 'typeof' for templates changed in Parsoid, it is 'Transclusion' now and used to be 'Object/Template' .. 'typeof' for templates

[MediaWiki-commits] [Gerrit] Retrieve fig caption by its tag name instead of classname (w... - change (mediawiki...Parsoid)

2013-06-05 Thread Inez (Code Review)
Inez has uploaded a new change for review. https://gerrit.wikimedia.org/r/67198 Change subject: Retrieve fig caption by its tag name instead of classname (which is not required). .. Retrieve fig caption by its tag name

[MediaWiki-commits] [Gerrit] Proper support for frame images (do not display magnify icon). - change (mediawiki...VisualEditor)

2013-06-04 Thread Inez (Code Review)
Inez has uploaded a new change for review. https://gerrit.wikimedia.org/r/67039 Change subject: Proper support for frame images (do not display magnify icon). .. Proper support for frame images (do not display magnify icon).

[MediaWiki-commits] [Gerrit] (WIP) Introduction of method ve.ce.Document.getRelativeRange... - change (mediawiki...VisualEditor)

2013-05-31 Thread Inez (Code Review)
Inez has uploaded a new change for review. https://gerrit.wikimedia.org/r/66322 Change subject: (WIP) Introduction of method ve.ce.Document.getRelativeRange(…) as a new method to be used for cursor left and right movement.

[MediaWiki-commits] [Gerrit] Adjust coverter getDomSubtreeFromData method call inside ve.... - change (mediawiki...VisualEditor)

2013-05-28 Thread Inez (Code Review)
Inez has uploaded a new change for review. https://gerrit.wikimedia.org/r/65854 Change subject: Adjust coverter getDomSubtreeFromData method call inside ve.dm.MWBlockImageNode to pass correct arguments (there was an API change).

[MediaWiki-commits] [Gerrit] Add class mw-figcaption to figcaption tag inside mwimage - t... - change (mediawiki...VisualEditor)

2013-05-28 Thread Inez (Code Review)
Inez has uploaded a new change for review. https://gerrit.wikimedia.org/r/65855 Change subject: Add class mw-figcaption to figcaption tag inside mwimage - this is currently required by Parsoid in order to serialize (HTMLDOM - wikitext) correctly.

[MediaWiki-commits] [Gerrit] (WIP) Convert GeneratedContentNode into a mixing (instead of... - change (mediawiki...VisualEditor)

2013-05-28 Thread Inez (Code Review)
Inez has uploaded a new change for review. https://gerrit.wikimedia.org/r/65864 Change subject: (WIP) Convert GeneratedContentNode into a mixing (instead of an abstract class). .. (WIP) Convert GeneratedContentNode into a

[MediaWiki-commits] [Gerrit] Use our own collection of constant to key code. The one base... - change (mediawiki...VisualEditor)

2013-05-23 Thread Inez (Code Review)
Inez has uploaded a new change for review. https://gerrit.wikimedia.org/r/65151 Change subject: Use our own collection of constant to key code. The one based on w3c is not reliable. .. Use our own collection of constant to

[MediaWiki-commits] [Gerrit] Get rid of try..catch by using ve.dm.nodeFactory.lookup. - change (mediawiki...VisualEditor)

2013-05-22 Thread Inez (Code Review)
Inez has uploaded a new change for review. https://gerrit.wikimedia.org/r/64977 Change subject: Get rid of try..catch by using ve.dm.nodeFactory.lookup. .. Get rid of try..catch by using ve.dm.nodeFactory.lookup. Change-Id:

[MediaWiki-commits] [Gerrit] Added comment to explain better what ve.Keys is. - change (mediawiki...VisualEditor)

2013-05-22 Thread Inez (Code Review)
Inez has uploaded a new change for review. https://gerrit.wikimedia.org/r/64984 Change subject: Added comment to explain better what ve.Keys is. .. Added comment to explain better what ve.Keys is. Change-Id:

[MediaWiki-commits] [Gerrit] (WIP) Support for thumb and frame images with captions. - change (mediawiki...VisualEditor)

2013-05-22 Thread Inez (Code Review)
Inez has uploaded a new change for review. https://gerrit.wikimedia.org/r/65090 Change subject: (WIP) Support for thumb and frame images with captions. .. (WIP) Support for thumb and frame images with captions. *

[MediaWiki-commits] [Gerrit] Add class mw-content-ltr or mw-content-rtl to surface in ord... - change (mediawiki...VisualEditor)

2013-05-20 Thread Inez (Code Review)
Inez has uploaded a new change for review. https://gerrit.wikimedia.org/r/64632 Change subject: Add class mw-content-ltr or mw-content-rtl to surface in order to correctly match MediaWiki styling. .. Add class

[MediaWiki-commits] [Gerrit] Fix for check if data is balanced. - change (mediawiki...VisualEditor)

2013-05-20 Thread Inez (Code Review)
Inez has uploaded a new change for review. https://gerrit.wikimedia.org/r/64643 Change subject: Fix for check if data is balanced. .. Fix for check if data is balanced. Previous check wouldn't make sense, cause the last

[MediaWiki-commits] [Gerrit] Wrap img in a inside image thumb in order to match Media... - change (mediawiki...VisualEditor)

2013-05-17 Thread Inez (Code Review)
Inez has uploaded a new change for review. https://gerrit.wikimedia.org/r/64356 Change subject: Wrap img in a inside image thumb in order to match MediaWiki parser output. .. Wrap img in a inside image thumb in order to

[MediaWiki-commits] [Gerrit] Added very basic support (rendering) for captions of thumb a... - change (mediawiki...VisualEditor)

2013-05-17 Thread Inez (Code Review)
Inez has uploaded a new change for review. https://gerrit.wikimedia.org/r/64367 Change subject: Added very basic support (rendering) for captions of thumb and frame images. .. Added very basic support (rendering) for

[MediaWiki-commits] [Gerrit] Keep veaction=edit in the url when VE runs in debug mode so ... - change (mediawiki...VisualEditor)

2013-05-16 Thread Inez (Code Review)
Inez has uploaded a new change for review. https://gerrit.wikimedia.org/r/64210 Change subject: Keep veaction=edit in the url when VE runs in debug mode so it keeps user just refresh the page in order to get into the edit mode.

[MediaWiki-commits] [Gerrit] Support for nodes that handles their own children in ve.dm.C... - change (mediawiki...VisualEditor)

2013-05-16 Thread Inez (Code Review)
Inez has uploaded a new change for review. https://gerrit.wikimedia.org/r/64219 Change subject: Support for nodes that handles their own children in ve.dm.Converter.prototype.getDomSubtreeFromData .. Support for nodes that

[MediaWiki-commits] [Gerrit] Set editMode to true as a default in ParsoidConfig.js - change (mediawiki...Parsoid)

2013-05-16 Thread Inez (Code Review)
Inez has uploaded a new change for review. https://gerrit.wikimedia.org/r/64238 Change subject: Set editMode to true as a default in ParsoidConfig.js .. Set editMode to true as a default in ParsoidConfig.js Change-Id:

[MediaWiki-commits] [Gerrit] Use promise pattern inside MWTemplateDialog in order to down... - change (mediawiki...VisualEditor)

2013-05-16 Thread Inez (Code Review)
Inez has uploaded a new change for review. https://gerrit.wikimedia.org/r/64255 Change subject: Use promise pattern inside MWTemplateDialog in order to download TemplateData (currently just mocked) asynchronously. .. Use

[MediaWiki-commits] [Gerrit] Added method getDataFromDomRecursionClean to ve.dm.Converter... - change (mediawiki...VisualEditor)

2013-05-15 Thread Inez (Code Review)
Inez has uploaded a new change for review. https://gerrit.wikimedia.org/r/63871 Change subject: Added method getDataFromDomRecursionClean to ve.dm.Converter - used by nodes that handle their own children. .. Added method

[MediaWiki-commits] [Gerrit] Make MWBlockImageNode a ProtectedNode (by adding mixin). - change (mediawiki...VisualEditor)

2013-05-15 Thread Inez (Code Review)
Inez has uploaded a new change for review. https://gerrit.wikimedia.org/r/63872 Change subject: Make MWBlockImageNode a ProtectedNode (by adding mixin). .. Make MWBlockImageNode a ProtectedNode (by adding mixin). Change-Id:

[MediaWiki-commits] [Gerrit] Make ve.ce.ProtectedNode use setup (for setup) and teardown ... - change (mediawiki...VisualEditor)

2013-05-15 Thread Inez (Code Review)
Inez has uploaded a new change for review. https://gerrit.wikimedia.org/r/63876 Change subject: Make ve.ce.ProtectedNode use setup (for setup) and teardown (for teardown) events so it is going to work well after node is rewrapped (example: MWBlockImageNode).

[MediaWiki-commits] [Gerrit] Added clearPages method to ve.ui.PagedDialog. - change (mediawiki...VisualEditor)

2013-05-15 Thread Inez (Code Review)
Inez has uploaded a new change for review. https://gerrit.wikimedia.org/r/63968 Change subject: Added clearPages method to ve.ui.PagedDialog. .. Added clearPages method to ve.ui.PagedDialog. Change-Id:

[MediaWiki-commits] [Gerrit] Process example template data and add pages to PagedDialog b... - change (mediawiki...VisualEditor)

2013-05-15 Thread Inez (Code Review)
Inez has uploaded a new change for review. https://gerrit.wikimedia.org/r/63971 Change subject: Process example template data and add pages to PagedDialog based on it. .. Process example template data and add pages to

[MediaWiki-commits] [Gerrit] Build TemplateDialog based on parameters that are passed to ... - change (mediawiki...VisualEditor)

2013-05-15 Thread Inez (Code Review)
Inez has uploaded a new change for review. https://gerrit.wikimedia.org/r/63983 Change subject: Build TemplateDialog based on parameters that are passed to template (instead of TemplateData as before). .. Build

[MediaWiki-commits] [Gerrit] Introduce createPage method in ve.ui.MWTemplateDialog and ev... - change (mediawiki...VisualEditor)

2013-05-15 Thread Inez (Code Review)
Inez has uploaded a new change for review. https://gerrit.wikimedia.org/r/63994 Change subject: Introduce createPage method in ve.ui.MWTemplateDialog and even use it! .. Introduce createPage method in ve.ui.MWTemplateDialog

[MediaWiki-commits] [Gerrit] Create and commit transaction after attributes of the templa... - change (mediawiki...VisualEditor)

2013-05-15 Thread Inez (Code Review)
Inez has uploaded a new change for review. https://gerrit.wikimedia.org/r/64007 Change subject: Create and commit transaction after attributes of the template are changed and applied. .. Create and commit transaction after

[MediaWiki-commits] [Gerrit] Emit teardown event before replacing generated content node ... - change (mediawiki...VisualEditor)

2013-05-15 Thread Inez (Code Review)
Inez has uploaded a new change for review. https://gerrit.wikimedia.org/r/64011 Change subject: Emit teardown event before replacing generated content node content and emit setup event after. .. Emit teardown event before

[MediaWiki-commits] [Gerrit] Better support for MediaWiki block level images (thumb and f... - change (mediawiki...VisualEditor)

2013-05-14 Thread Inez (Code Review)
Inez has uploaded a new change for review. https://gerrit.wikimedia.org/r/63803 Change subject: Better support for MediaWiki block level images (thumb and frame) .. Better support for MediaWiki block level images (thumb and

[MediaWiki-commits] [Gerrit] (bug 48386) Use DOM_VK_ENTER instead of DOM_VK_RETURN (which... - change (mediawiki...VisualEditor)

2013-05-13 Thread Inez (Code Review)
Inez has uploaded a new change for review. https://gerrit.wikimedia.org/r/63413 Change subject: (bug 48386) Use DOM_VK_ENTER instead of DOM_VK_RETURN (which is not defined anymore) .. (bug 48386) Use DOM_VK_ENTER instead of

[MediaWiki-commits] [Gerrit] Introduction of setup and teardown events for ve.ce.View nodes - change (mediawiki...VisualEditor)

2013-05-13 Thread Inez (Code Review)
Inez has uploaded a new change for review. https://gerrit.wikimedia.org/r/63585 Change subject: Introduction of setup and teardown events for ve.ce.View nodes .. Introduction of setup and teardown events for ve.ce.View nodes

[MediaWiki-commits] [Gerrit] (bug 48022) Ignore certain function keys in key press handler - change (mediawiki...VisualEditor)

2013-05-10 Thread Inez (Code Review)
Inez has uploaded a new change for review. https://gerrit.wikimedia.org/r/63223 Change subject: (bug 48022) Ignore certain function keys in key press handler .. (bug 48022) Ignore certain function keys in key press handler

[MediaWiki-commits] [Gerrit] There is no need to call renderContents in ContentBranchNode... - change (mediawiki...VisualEditor)

2013-05-09 Thread Inez (Code Review)
Inez has uploaded a new change for review. https://gerrit.wikimedia.org/r/63096 Change subject: There is no need to call renderContents in ContentBranchNode constructor because it is going to be called anyways in onSplice ..

[MediaWiki-commits] [Gerrit] Allow merging of content nodes with nodes that can contain c... - change (mediawiki...VisualEditor)

2013-04-29 Thread Inez (Code Review)
Inez has uploaded a new change for review. https://gerrit.wikimedia.org/r/61520 Change subject: Allow merging of content nodes with nodes that can contain content (but are not content themself) .. Allow merging of content

[MediaWiki-commits] [Gerrit] (bug 47711) Fix FF specific bug - change (mediawiki...VisualEditor)

2013-04-26 Thread Inez (Code Review)
Inez has uploaded a new change for review. https://gerrit.wikimedia.org/r/61055 Change subject: (bug 47711) Fix FF specific bug .. (bug 47711) Fix FF specific bug Firefox fires key press events for arrow keys - but we

  1   2   >