[MediaWiki-commits] [Gerrit] Don't show blacklist warning for autoconfirmed protection - change (mediawiki...TitleBlacklist)

2016-06-14 Thread Jackmcbarn (Code Review)
Jackmcbarn has uploaded a new change for review. https://gerrit.wikimedia.org/r/294419 Change subject: Don't show blacklist warning for autoconfirmed protection .. Don't show blacklist warning for autoconfirmed protection

[MediaWiki-commits] [Gerrit] Fix protectionexpiry using the wrong page - change (mediawiki/core)

2016-01-14 Thread Jackmcbarn (Code Review)
Jackmcbarn has uploaded a new change for review. https://gerrit.wikimedia.org/r/264093 Change subject: Fix protectionexpiry using the wrong page .. Fix protectionexpiry using the wrong page Change-Id:

[MediaWiki-commits] [Gerrit] Replace based off with based on in messages - change (mediawiki...FlaggedRevs)

2015-07-26 Thread Jackmcbarn (Code Review)
Jackmcbarn has uploaded a new change for review. https://gerrit.wikimedia.org/r/227078 Change subject: Replace based off with based on in messages .. Replace based off with based on in messages Change-Id:

[MediaWiki-commits] [Gerrit] Prevent leaking title fragments across invokes - change (mediawiki...Scribunto)

2015-07-25 Thread Jackmcbarn (Code Review)
Jackmcbarn has uploaded a new change for review. https://gerrit.wikimedia.org/r/226987 Change subject: Prevent leaking title fragments across invokes .. Prevent leaking title fragments across invokes Bug: T106951 Change-Id:

[MediaWiki-commits] [Gerrit] Revert Add an additional cache layer for module revision text - change (mediawiki...Scribunto)

2015-07-22 Thread Jackmcbarn (Code Review)
Jackmcbarn has uploaded a new change for review. https://gerrit.wikimedia.org/r/226468 Change subject: Revert Add an additional cache layer for module revision text .. Revert Add an additional cache layer for module revision

[MediaWiki-commits] [Gerrit] Revert Add an additional cache layer for module revision text - change (mediawiki...Scribunto)

2015-07-22 Thread Jackmcbarn (Code Review)
Jackmcbarn has uploaded a new change for review. https://gerrit.wikimedia.org/r/226467 Change subject: Revert Add an additional cache layer for module revision text .. Revert Add an additional cache layer for module revision

[MediaWiki-commits] [Gerrit] Include the bad timestamp string in the error when unable to... - change (mediawiki...Scribunto)

2015-07-09 Thread Jackmcbarn (Code Review)
Jackmcbarn has uploaded a new change for review. https://gerrit.wikimedia.org/r/223888 Change subject: Include the bad timestamp string in the error when unable to parse it .. Include the bad timestamp string in the error

[MediaWiki-commits] [Gerrit] Mark metatables from mw.loadData - change (mediawiki...Scribunto)

2015-06-27 Thread Jackmcbarn (Code Review)
Jackmcbarn has uploaded a new change for review. https://gerrit.wikimedia.org/r/221431 Change subject: Mark metatables from mw.loadData .. Mark metatables from mw.loadData Add mw_loadData=true to metatables set by

[MediaWiki-commits] [Gerrit] Fix some PHPCS issues - change (mediawiki...Scribunto)

2015-06-26 Thread Jackmcbarn (Code Review)
Jackmcbarn has uploaded a new change for review. https://gerrit.wikimedia.org/r/221144 Change subject: Fix some PHPCS issues .. Fix some PHPCS issues Change-Id: I5a44d07553d45bc01db070c99856b35a3d275bd1 --- M

[MediaWiki-commits] [Gerrit] Fix some PHPCS issues - change (mediawiki/core)

2015-06-25 Thread Jackmcbarn (Code Review)
Jackmcbarn has uploaded a new change for review. https://gerrit.wikimedia.org/r/221051 Change subject: Fix some PHPCS issues .. Fix some PHPCS issues Change-Id: I6289ce362f8dfde7baf2b665f082820898844973 --- M

[MediaWiki-commits] [Gerrit] Display backtraces in the Scribunto console - change (mediawiki...Scribunto)

2015-06-24 Thread Jackmcbarn (Code Review)
Jackmcbarn has uploaded a new change for review. https://gerrit.wikimedia.org/r/220704 Change subject: Display backtraces in the Scribunto console .. Display backtraces in the Scribunto console When the Scribunto console

[MediaWiki-commits] [Gerrit] Deactivate the HHVM tag - change (mediawiki...WikimediaEvents)

2015-06-23 Thread Jackmcbarn (Code Review)
Jackmcbarn has uploaded a new change for review. https://gerrit.wikimedia.org/r/220381 Change subject: Deactivate the HHVM tag .. Deactivate the HHVM tag Since we're no longer applying the HHVM tag, we shouldn't still be

[MediaWiki-commits] [Gerrit] Don't check namespace in SpecialWantedtemplates - change (mediawiki/core)

2015-06-13 Thread Jackmcbarn (Code Review)
Jackmcbarn has uploaded a new change for review. https://gerrit.wikimedia.org/r/218116 Change subject: Don't check namespace in SpecialWantedtemplates .. Don't check namespace in SpecialWantedtemplates Templates are

[MediaWiki-commits] [Gerrit] Give the same error for a blank ref tag and a self-closing one - change (mediawiki...Cite)

2015-05-27 Thread Jackmcbarn (Code Review)
Jackmcbarn has uploaded a new change for review. https://gerrit.wikimedia.org/r/214099 Change subject: Give the same error for a blank ref tag and a self-closing one .. Give the same error for a blank ref tag and a

[MediaWiki-commits] [Gerrit] Parse references as we go - change (mediawiki...Cite)

2015-05-27 Thread Jackmcbarn (Code Review)
Jackmcbarn has uploaded a new change for review. https://gerrit.wikimedia.org/r/214116 Change subject: Parse references as we go .. Parse references as we go Parse each ref tag as we process it, rather than saving them all

[MediaWiki-commits] [Gerrit] Unstrip any text we add in ParserAfterUnstrip - change (mediawiki...Cite)

2015-05-27 Thread Jackmcbarn (Code Review)
Jackmcbarn has uploaded a new change for review. https://gerrit.wikimedia.org/r/214082 Change subject: Unstrip any text we add in ParserAfterUnstrip .. Unstrip any text we add in ParserAfterUnstrip Since ParserAfterUnstrip

[MediaWiki-commits] [Gerrit] Don't run references if the output type isn't HTML - change (mediawiki...Cite)

2015-05-24 Thread Jackmcbarn (Code Review)
Jackmcbarn has uploaded a new change for review. https://gerrit.wikimedia.org/r/213313 Change subject: Don't run references if the output type isn't HTML .. Don't run references if the output type isn't HTML It's possible

[MediaWiki-commits] [Gerrit] SpecialWhatlinkshere: Mark redirects containing templates - change (mediawiki/core)

2015-02-11 Thread Jackmcbarn (Code Review)
Jackmcbarn has submitted this change and it was merged. Change subject: SpecialWhatlinkshere: Mark redirects containing templates .. SpecialWhatlinkshere: Mark redirects containing templates Mark redirects containing templates

[MediaWiki-commits] [Gerrit] Don't expose TRY_FIXING - change (mediawiki...Scribunto)

2015-02-05 Thread Jackmcbarn (Code Review)
Jackmcbarn has uploaded a new change for review. https://gerrit.wikimedia.org/r/13 Change subject: Don't expose TRY_FIXING .. Don't expose TRY_FIXING In new code, I don't see the value in decoding things that happen to

[MediaWiki-commits] [Gerrit] Revert Escape unsafe messages in CategoryViewer.php - change (mediawiki/core)

2015-02-05 Thread Jackmcbarn (Code Review)
Jackmcbarn has uploaded a new change for review. https://gerrit.wikimedia.org/r/188891 Change subject: Revert Escape unsafe messages in CategoryViewer.php .. Revert Escape unsafe messages in CategoryViewer.php This reverts

[MediaWiki-commits] [Gerrit] Properly escape the messages in CategoryViewer.php - change (mediawiki/core)

2015-02-05 Thread Jackmcbarn (Code Review)
Jackmcbarn has uploaded a new change for review. https://gerrit.wikimedia.org/r/188944 Change subject: Properly escape the messages in CategoryViewer.php .. Properly escape the messages in CategoryViewer.php This mostly

[MediaWiki-commits] [Gerrit] Properly escape the messages in CategoryViewer.php - change (mediawiki/core)

2015-02-05 Thread Jackmcbarn (Code Review)
Jackmcbarn has uploaded a new change for review. https://gerrit.wikimedia.org/r/188945 Change subject: Properly escape the messages in CategoryViewer.php .. Properly escape the messages in CategoryViewer.php This mostly

[MediaWiki-commits] [Gerrit] Expose user information to Lua - change (mediawiki...Scribunto)

2015-02-03 Thread Jackmcbarn (Code Review)
Jackmcbarn has uploaded a new change for review. https://gerrit.wikimedia.org/r/188503 Change subject: Expose user information to Lua .. Expose user information to Lua Add mw.user, which allows viewing groups, blocks, and

[MediaWiki-commits] [Gerrit] Don't use vary-revision for self-transclusions - change (mediawiki/core)

2015-01-26 Thread Jackmcbarn (Code Review)
Jackmcbarn has uploaded a new change for review. https://gerrit.wikimedia.org/r/186843 Change subject: Don't use vary-revision for self-transclusions .. Don't use vary-revision for self-transclusions Instead of using

[MediaWiki-commits] [Gerrit] Revert Set vary-revision appropriately with getContent() - change (mediawiki...Scribunto)

2015-01-26 Thread Jackmcbarn (Code Review)
Jackmcbarn has uploaded a new change for review. https://gerrit.wikimedia.org/r/186873 Change subject: Revert Set vary-revision appropriately with getContent() .. Revert Set vary-revision appropriately with getContent() No

[MediaWiki-commits] [Gerrit] Render bad images in wikitext as links - change (mediawiki/core)

2015-01-08 Thread Jackmcbarn (Code Review)
Jackmcbarn has uploaded a new change for review. https://gerrit.wikimedia.org/r/183548 Change subject: Render bad images in wikitext as links .. Render bad images in wikitext as links In galleries, bad images are rendered as

[MediaWiki-commits] [Gerrit] Pass the title's fragment to getExpensiveData - change (mediawiki...Scribunto)

2015-01-08 Thread Jackmcbarn (Code Review)
Jackmcbarn has uploaded a new change for review. https://gerrit.wikimedia.org/r/183552 Change subject: Pass the title's fragment to getExpensiveData .. Pass the title's fragment to getExpensiveData Without this, an error

[MediaWiki-commits] [Gerrit] Pass the title's fragment to getExpensiveData - change (mediawiki...Scribunto)

2015-01-08 Thread Jackmcbarn (Code Review)
Jackmcbarn has uploaded a new change for review. https://gerrit.wikimedia.org/r/183561 Change subject: Pass the title's fragment to getExpensiveData .. Pass the title's fragment to getExpensiveData Without this, an error

[MediaWiki-commits] [Gerrit] Pass the title's fragment to getExpensiveData - change (mediawiki...Scribunto)

2015-01-08 Thread Jackmcbarn (Code Review)
Jackmcbarn has uploaded a new change for review. https://gerrit.wikimedia.org/r/183563 Change subject: Pass the title's fragment to getExpensiveData .. Pass the title's fragment to getExpensiveData Without this, an error

[MediaWiki-commits] [Gerrit] Pass the title's fragment to getExpensiveData - change (mediawiki...Scribunto)

2015-01-08 Thread Jackmcbarn (Code Review)
Jackmcbarn has submitted this change and it was merged. Change subject: Pass the title's fragment to getExpensiveData .. Pass the title's fragment to getExpensiveData Without this, an error occurs when calling

[MediaWiki-commits] [Gerrit] Don't hide filter IDs - change (mediawiki...AbuseFilter)

2015-01-07 Thread Jackmcbarn (Code Review)
Jackmcbarn has uploaded a new change for review. https://gerrit.wikimedia.org/r/183301 Change subject: Don't hide filter IDs .. Don't hide filter IDs We show filter names even for private filters. There's no reason we

[MediaWiki-commits] [Gerrit] Fix title equality checking and closure style - change (mediawiki...TemplateSandbox)

2014-12-30 Thread Jackmcbarn (Code Review)
Jackmcbarn has uploaded a new change for review. https://gerrit.wikimedia.org/r/182196 Change subject: Fix title equality checking and closure style .. Fix title equality checking and closure style Compare titles with

[MediaWiki-commits] [Gerrit] Change tboverride to tboverride-account for enwiki accountcr... - change (operations/mediawiki-config)

2014-12-30 Thread Jackmcbarn (Code Review)
Jackmcbarn has uploaded a new change for review. https://gerrit.wikimedia.org/r/182197 Change subject: Change tboverride to tboverride-account for enwiki accountcreators .. Change tboverride to tboverride-account for enwiki

[MediaWiki-commits] [Gerrit] Restore backwards compatibility - change (mediawiki...Vector)

2014-12-29 Thread Jackmcbarn (Code Review)
Jackmcbarn has uploaded a new change for review. https://gerrit.wikimedia.org/r/182091 Change subject: Restore backwards compatibility .. Restore backwards compatibility When status indicators were added, backwards

[MediaWiki-commits] [Gerrit] Fix TOC anchor name collisions in edge cases - change (mediawiki/core)

2014-12-28 Thread Jackmcbarn (Code Review)
Jackmcbarn has uploaded a new change for review. https://gerrit.wikimedia.org/r/181999 Change subject: Fix TOC anchor name collisions in edge cases .. Fix TOC anchor name collisions in edge cases Currently, the parser adds a

[MediaWiki-commits] [Gerrit] Do all of Cite's real work during unstrip - change (mediawiki...Cite)

2014-12-19 Thread Jackmcbarn (Code Review)
Jackmcbarn has uploaded a new change for review. https://gerrit.wikimedia.org/r/181112 Change subject: Do all of Cite's real work during unstrip .. Do all of Cite's real work during unstrip Cite has side effects that

[MediaWiki-commits] [Gerrit] DO NOT MERGE - testing Jenkins - change (mediawiki...Scribunto)

2014-12-18 Thread Jackmcbarn (Code Review)
Jackmcbarn has uploaded a new change for review. https://gerrit.wikimedia.org/r/181027 Change subject: DO NOT MERGE - testing Jenkins .. DO NOT MERGE - testing Jenkins Change-Id: I27d3a660c57259e804b01970495ece95c6d73488 ---

[MediaWiki-commits] [Gerrit] Make Jenkins tests pass - change (mediawiki...Scribunto)

2014-12-18 Thread Jackmcbarn (Code Review)
Jackmcbarn has uploaded a new change for review. https://gerrit.wikimedia.org/r/181029 Change subject: Make Jenkins tests pass .. Make Jenkins tests pass Something apparently changed in core, and now we need some additional

[MediaWiki-commits] [Gerrit] Allow running code during unstrip - change (mediawiki/core)

2014-12-18 Thread Jackmcbarn (Code Review)
Jackmcbarn has uploaded a new change for review. https://gerrit.wikimedia.org/r/181046 Change subject: Allow running code during unstrip .. Allow running code during unstrip When adding strip markers, allow closures to be

[MediaWiki-commits] [Gerrit] Only use mw.ustring when necessary - change (mediawiki...Scribunto)

2014-12-16 Thread Jackmcbarn (Code Review)
Jackmcbarn has uploaded a new change for review. https://gerrit.wikimedia.org/r/180380 Change subject: Only use mw.ustring when necessary .. Only use mw.ustring when necessary mw.ustring is really really slow. I've

[MediaWiki-commits] [Gerrit] Record a link to pages looked up by ID - change (mediawiki...Scribunto)

2014-12-11 Thread Jackmcbarn (Code Review)
Jackmcbarn has uploaded a new change for review. https://gerrit.wikimedia.org/r/179196 Change subject: Record a link to pages looked up by ID .. Record a link to pages looked up by ID If mw.title.new is called with a page

[MediaWiki-commits] [Gerrit] Always use the newly-saved revision with vary-revision - change (mediawiki/core)

2014-12-11 Thread Jackmcbarn (Code Review)
Jackmcbarn has uploaded a new change for review. https://gerrit.wikimedia.org/r/179397 Change subject: Always use the newly-saved revision with vary-revision .. Always use the newly-saved revision with vary-revision When

[MediaWiki-commits] [Gerrit] Avoid unnecessary database queries - change (mediawiki...Scribunto)

2014-12-09 Thread Jackmcbarn (Code Review)
Jackmcbarn has uploaded a new change for review. https://gerrit.wikimedia.org/r/178698 Change subject: Avoid unnecessary database queries .. Avoid unnecessary database queries Currently, mw.title.new always results in a

[MediaWiki-commits] [Gerrit] Allow non-hacky modification of loadData tables - change (mediawiki...Scribunto)

2014-12-09 Thread Jackmcbarn (Code Review)
Jackmcbarn has uploaded a new change for review. https://gerrit.wikimedia.org/r/178760 Change subject: Allow non-hacky modification of loadData tables .. Allow non-hacky modification of loadData tables It's always been

[MediaWiki-commits] [Gerrit] Simplify code in mw.html - change (mediawiki...Scribunto)

2014-12-08 Thread Jackmcbarn (Code Review)
Jackmcbarn has uploaded a new change for review. https://gerrit.wikimedia.org/r/178244 Change subject: Simplify code in mw.html .. Simplify code in mw.html Replace numeric loops with iteration, don't unnecessarily check for

[MediaWiki-commits] [Gerrit] Remove unused variable - change (mediawiki...Scribunto)

2014-12-01 Thread Jackmcbarn (Code Review)
Jackmcbarn has uploaded a new change for review. https://gerrit.wikimedia.org/r/176669 Change subject: Remove unused variable .. Remove unused variable Change-Id: I31c339dd68081a6c3d140011dc7c00eb2ddbef64 --- M

[MediaWiki-commits] [Gerrit] Darken the text color in successbox - change (mediawiki/core)

2014-12-01 Thread Jackmcbarn (Code Review)
Jackmcbarn has uploaded a new change for review. https://gerrit.wikimedia.org/r/176841 Change subject: Darken the text color in successbox .. Darken the text color in successbox A user mentioned that there isn't currently

[MediaWiki-commits] [Gerrit] Make indicators use nowiki strip markers - change (mediawiki/core)

2014-11-29 Thread Jackmcbarn (Code Review)
Jackmcbarn has uploaded a new change for review. https://gerrit.wikimedia.org/r/176481 Change subject: Make indicators use nowiki strip markers .. Make indicators use nowiki strip markers Currently, the indicator tag returns

[MediaWiki-commits] [Gerrit] Set the correct error source from mw.html - change (mediawiki...Scribunto)

2014-11-02 Thread Jackmcbarn (Code Review)
Jackmcbarn has uploaded a new change for review. https://gerrit.wikimedia.org/r/170648 Change subject: Set the correct error source from mw.html .. Set the correct error source from mw.html When mw.html errors, make the

[MediaWiki-commits] [Gerrit] Expose all ancestor frames - change (mediawiki...Scribunto)

2014-10-29 Thread Jackmcbarn (Code Review)
Jackmcbarn has uploaded a new change for review. https://gerrit.wikimedia.org/r/169983 Change subject: Expose all ancestor frames .. Expose all ancestor frames The original reason for not exposing all ancestor frames was to

[MediaWiki-commits] [Gerrit] Remove parameter left over from trial long since ended - change (operations/mediawiki-config)

2014-10-27 Thread Jackmcbarn (Code Review)
Jackmcbarn has uploaded a new change for review. https://gerrit.wikimedia.org/r/169247 Change subject: Remove parameter left over from trial long since ended .. Remove parameter left over from trial long since ended

[MediaWiki-commits] [Gerrit] Remove temp hack quota - change (mediawiki...FlaggedRevs)

2014-10-27 Thread Jackmcbarn (Code Review)
Jackmcbarn has uploaded a new change for review. https://gerrit.wikimedia.org/r/169254 Change subject: Remove temp hack quota .. Remove temp hack quota This was put in place while enwiki was trialing FlaggedRevs, which was

[MediaWiki-commits] [Gerrit] Remove quota from the rest of the wikis - change (operations/mediawiki-config)

2014-10-27 Thread Jackmcbarn (Code Review)
Jackmcbarn has uploaded a new change for review. https://gerrit.wikimedia.org/r/169258 Change subject: Remove quota from the rest of the wikis .. Remove quota from the rest of the wikis The quota was originally for when

[MediaWiki-commits] [Gerrit] Warn when duplicate arguments are found - change (mediawiki/core)

2014-10-24 Thread Jackmcbarn (Code Review)
Jackmcbarn has uploaded a new change for review. https://gerrit.wikimedia.org/r/168607 Change subject: Warn when duplicate arguments are found .. Warn when duplicate arguments are found Currently, duplicate arguments result

[MediaWiki-commits] [Gerrit] Support protocol-relative URLs in the whitelist - change (mediawiki...ConfirmEdit)

2014-10-22 Thread Jackmcbarn (Code Review)
Jackmcbarn has uploaded a new change for review. https://gerrit.wikimedia.org/r/168074 Change subject: Support protocol-relative URLs in the whitelist .. Support protocol-relative URLs in the whitelist Bug: 61556 Change-Id:

[MediaWiki-commits] [Gerrit] Fix Special:Version - change (mediawiki...Capiunto)

2014-10-15 Thread Jackmcbarn (Code Review)
Jackmcbarn has uploaded a new change for review. https://gerrit.wikimedia.org/r/166934 Change subject: Fix Special:Version .. Fix Special:Version Currently, this extension makes Special:Version fatal because it's missing a

[MediaWiki-commits] [Gerrit] Remove negative caching from Revision::getContentInternal - change (mediawiki/core)

2014-10-13 Thread Jackmcbarn (Code Review)
Jackmcbarn has uploaded a new change for review. https://gerrit.wikimedia.org/r/166522 Change subject: Remove negative caching from Revision::getContentInternal .. Remove negative caching from Revision::getContentInternal

[MediaWiki-commits] [Gerrit] Fix access level and remove unnecessary redefinitions - change (mediawiki...Scribunto)

2014-10-10 Thread Jackmcbarn (Code Review)
Jackmcbarn has uploaded a new change for review. https://gerrit.wikimedia.org/r/166038 Change subject: Fix access level and remove unnecessary redefinitions .. Fix access level and remove unnecessary redefinitions In

[MediaWiki-commits] [Gerrit] Add a test case for a pattern that fails on some servers - change (mediawiki...Scribunto)

2014-10-09 Thread Jackmcbarn (Code Review)
Jackmcbarn has uploaded a new change for review. https://gerrit.wikimedia.org/r/165943 Change subject: Add a test case for a pattern that fails on some servers .. Add a test case for a pattern that fails on some servers On

[MediaWiki-commits] [Gerrit] Fix fatal error in delayed parser tests - change (mediawiki/core)

2014-10-07 Thread Jackmcbarn (Code Review)
Jackmcbarn has uploaded a new change for review. https://gerrit.wikimedia.org/r/165385 Change subject: Fix fatal error in delayed parser tests .. Fix fatal error in delayed parser tests Change-Id:

[MediaWiki-commits] [Gerrit] Expose argument keys without their values - change (mediawiki/core)

2014-10-06 Thread Jackmcbarn (Code Review)
Jackmcbarn has uploaded a new change for review. https://gerrit.wikimedia.org/r/165103 Change subject: Expose argument keys without their values .. Expose argument keys without their values It's possible that some argument

[MediaWiki-commits] [Gerrit] Add frame.argKeys - change (mediawiki...Scribunto)

2014-10-06 Thread Jackmcbarn (Code Review)
Jackmcbarn has uploaded a new change for review. https://gerrit.wikimedia.org/r/165108 Change subject: Add frame.argKeys .. Add frame.argKeys Currently, it's impossible to get a list of all provided arguments without

[MediaWiki-commits] [Gerrit] Remove loadedLibraries - change (mediawiki...Scribunto)

2014-10-05 Thread Jackmcbarn (Code Review)
Jackmcbarn has uploaded a new change for review. https://gerrit.wikimedia.org/r/164788 Change subject: Remove loadedLibraries .. Remove loadedLibraries Nothing actually uses this, so I'm not sure why we ever kept track of

[MediaWiki-commits] [Gerrit] (bug 71633) Include categories in Special:ExpandTemplates - change (mediawiki/core)

2014-10-05 Thread Jackmcbarn (Code Review)
Jackmcbarn has uploaded a new change for review. https://gerrit.wikimedia.org/r/164889 Change subject: (bug 71633) Include categories in Special:ExpandTemplates .. (bug 71633) Include categories in Special:ExpandTemplates

[MediaWiki-commits] [Gerrit] Allow numbers in tag names - change (mediawiki...Scribunto)

2014-10-03 Thread Jackmcbarn (Code Review)
Jackmcbarn has uploaded a new change for review. https://gerrit.wikimedia.org/r/164535 Change subject: Allow numbers in tag names .. Allow numbers in tag names HTML tags can contain numbers, like h2. Bug: 71594 Change-Id:

[MediaWiki-commits] [Gerrit] Convert Capiunto to a delayed-load module - change (mediawiki...Capiunto)

2014-10-03 Thread Jackmcbarn (Code Review)
Jackmcbarn has uploaded a new change for review. https://gerrit.wikimedia.org/r/164560 Change subject: Convert Capiunto to a delayed-load module .. Convert Capiunto to a delayed-load module Instead of storing Capiunto inside

[MediaWiki-commits] [Gerrit] Return registerInterface() per Ibdc1f4ef - change (mediawiki...ParserFunctions)

2014-10-03 Thread Jackmcbarn (Code Review)
Jackmcbarn has uploaded a new change for review. https://gerrit.wikimedia.org/r/164561 Change subject: Return registerInterface() per Ibdc1f4ef .. Return registerInterface() per Ibdc1f4ef Change-Id:

[MediaWiki-commits] [Gerrit] Return registerInterface() per Ibdc1f4ef - change (mediawiki...TitleBlacklist)

2014-10-03 Thread Jackmcbarn (Code Review)
Jackmcbarn has uploaded a new change for review. https://gerrit.wikimedia.org/r/164562 Change subject: Return registerInterface() per Ibdc1f4ef .. Return registerInterface() per Ibdc1f4ef Change-Id:

[MediaWiki-commits] [Gerrit] Throw an exception if LuaSandboxFunction::call returns false - change (mediawiki...Scribunto)

2014-09-27 Thread Jackmcbarn (Code Review)
Jackmcbarn has uploaded a new change for review. https://gerrit.wikimedia.org/r/163359 Change subject: Throw an exception if LuaSandboxFunction::call returns false .. Throw an exception if LuaSandboxFunction::call returns

[MediaWiki-commits] [Gerrit] Update CREDITS - change (mediawiki/core)

2014-09-27 Thread Jackmcbarn (Code Review)
Jackmcbarn has uploaded a new change for review. https://gerrit.wikimedia.org/r/163452 Change subject: Update CREDITS .. Update CREDITS Add myself as a developer, and sort the whole thing alphabetically. Change-Id:

[MediaWiki-commits] [Gerrit] Don't clobber revision size of 0 - change (mediawiki/core)

2014-09-27 Thread Jackmcbarn (Code Review)
Jackmcbarn has uploaded a new change for review. https://gerrit.wikimedia.org/r/163458 Change subject: Don't clobber revision size of 0 .. Don't clobber revision size of 0 When a revision's size is 0, don't clobber it by

[MediaWiki-commits] [Gerrit] Revert Preprocess text arguments - change (mediawiki...Capiunto)

2014-09-26 Thread Jackmcbarn (Code Review)
Jackmcbarn has uploaded a new change for review. https://gerrit.wikimedia.org/r/163325 Change subject: Revert Preprocess text arguments .. Revert Preprocess text arguments This reverts commit

[MediaWiki-commits] [Gerrit] Don't check interwiki redirect targets against the blacklist - change (mediawiki...TitleBlacklist)

2014-09-24 Thread Jackmcbarn (Code Review)
Jackmcbarn has uploaded a new change for review. https://gerrit.wikimedia.org/r/162597 Change subject: Don't check interwiki redirect targets against the blacklist .. Don't check interwiki redirect targets against the

[MediaWiki-commits] [Gerrit] Don't test against redirect targets - change (mediawiki...TitleBlacklist)

2014-09-24 Thread Jackmcbarn (Code Review)
Jackmcbarn has uploaded a new change for review. https://gerrit.wikimedia.org/r/162607 Change subject: Don't test against redirect targets .. Don't test against redirect targets There was never any use-case given for this,

[MediaWiki-commits] [Gerrit] Expose ResourceLoader modules to action=expandtemplates - change (mediawiki/core)

2014-09-22 Thread Jackmcbarn (Code Review)
Jackmcbarn has uploaded a new change for review. https://gerrit.wikimedia.org/r/162123 Change subject: Expose ResourceLoader modules to action=expandtemplates .. Expose ResourceLoader modules to action=expandtemplates Needed

[MediaWiki-commits] [Gerrit] Revert Completely remove skin autodiscovery - change (mediawiki/core)

2014-09-21 Thread Jackmcbarn (Code Review)
Jackmcbarn has uploaded a new change for review. https://gerrit.wikimedia.org/r/161892 Change subject: Revert Completely remove skin autodiscovery .. Revert Completely remove skin autodiscovery 1.24 was un-branched. This

[MediaWiki-commits] [Gerrit] Don't escape the delete character - change (mediawiki...Scribunto)

2014-09-21 Thread Jackmcbarn (Code Review)
Jackmcbarn has uploaded a new change for review. https://gerrit.wikimedia.org/r/161900 Change subject: Don't escape the delete character .. Don't escape the delete character Escaping the delete character breaks strip

[MediaWiki-commits] [Gerrit] Include regex in addItem exception - change (mediawiki/core)

2014-09-21 Thread Jackmcbarn (Code Review)
Jackmcbarn has uploaded a new change for review. https://gerrit.wikimedia.org/r/161907 Change subject: Include regex in addItem exception .. Include regex in addItem exception An apparently valid strip marker is throwing

[MediaWiki-commits] [Gerrit] Improve mod_security warning - change (mediawiki/core)

2014-09-20 Thread Jackmcbarn (Code Review)
Jackmcbarn has uploaded a new change for review. https://gerrit.wikimedia.org/r/161669 Change subject: Improve mod_security warning .. Improve mod_security warning Make it detect mod_security2 as well, and make the warning

[MediaWiki-commits] [Gerrit] Add OTRS-member group to enwiki - change (operations/mediawiki-config)

2014-09-19 Thread Jackmcbarn (Code Review)
Jackmcbarn has uploaded a new change for review. https://gerrit.wikimedia.org/r/161456 Change subject: Add OTRS-member group to enwiki .. Add OTRS-member group to enwiki Add OTRS-member to enwiki, addable and removable by

[MediaWiki-commits] [Gerrit] Re-enable the Lua profiler on production HHVM - change (operations/mediawiki-config)

2014-09-19 Thread Jackmcbarn (Code Review)
Jackmcbarn has uploaded a new change for review. https://gerrit.wikimedia.org/r/161468 Change subject: Re-enable the Lua profiler on production HHVM .. Re-enable the Lua profiler on production HHVM It's been back on in beta

[MediaWiki-commits] [Gerrit] Add TitleExists hook - change (mediawiki/core)

2014-09-15 Thread Jackmcbarn (Code Review)
Jackmcbarn has uploaded a new change for review. https://gerrit.wikimedia.org/r/160546 Change subject: Add TitleExists hook .. Add TitleExists hook Bug: 70495 Change-Id: I4f9a04d09ff8c4bdda678a591aea7f1153cb0a40 --- M

[MediaWiki-commits] [Gerrit] Call Title::exists() instead of checking the ID - change (mediawiki...ParserFunctions)

2014-09-15 Thread Jackmcbarn (Code Review)
Jackmcbarn has uploaded a new change for review. https://gerrit.wikimedia.org/r/160549 Change subject: Call Title::exists() instead of checking the ID .. Call Title::exists() instead of checking the ID Bug: 70495 Change-Id:

[MediaWiki-commits] [Gerrit] Call Title::exists() instead of checking the ID - change (mediawiki...Scribunto)

2014-09-15 Thread Jackmcbarn (Code Review)
Jackmcbarn has uploaded a new change for review. https://gerrit.wikimedia.org/r/160550 Change subject: Call Title::exists() instead of checking the ID .. Call Title::exists() instead of checking the ID Bug: 70495 Change-Id:

[MediaWiki-commits] [Gerrit] Hook TitleExists when previewing - change (mediawiki...TemplateSandbox)

2014-09-15 Thread Jackmcbarn (Code Review)
Jackmcbarn has uploaded a new change for review. https://gerrit.wikimedia.org/r/160555 Change subject: Hook TitleExists when previewing .. Hook TitleExists when previewing Bug: 70495 Change-Id:

[MediaWiki-commits] [Gerrit] Add RevisionFromTitle hook - change (mediawiki/core)

2014-09-15 Thread Jackmcbarn (Code Review)
Jackmcbarn has uploaded a new change for review. https://gerrit.wikimedia.org/r/160570 Change subject: Add RevisionFromTitle hook .. Add RevisionFromTitle hook Whenever Revision::newFromTitle or Revision::loadFromTitle is

[MediaWiki-commits] [Gerrit] Use RevisionFromTitle instead of a template callback - change (mediawiki...TemplateSandbox)

2014-09-15 Thread Jackmcbarn (Code Review)
Jackmcbarn has uploaded a new change for review. https://gerrit.wikimedia.org/r/160572 Change subject: Use RevisionFromTitle instead of a template callback .. Use RevisionFromTitle instead of a template callback

[MediaWiki-commits] [Gerrit] Check content model instead of title - change (mediawiki...Scribunto)

2014-09-15 Thread Jackmcbarn (Code Review)
Jackmcbarn has uploaded a new change for review. https://gerrit.wikimedia.org/r/160605 Change subject: Check content model instead of title .. Check content model instead of title Make Scribunto compatible with storing

[MediaWiki-commits] [Gerrit] Set $wgAbuseFilterAnonBlockDuration to 3 months on mediawiki... - change (operations/mediawiki-config)

2014-09-14 Thread Jackmcbarn (Code Review)
Jackmcbarn has uploaded a new change for review. https://gerrit.wikimedia.org/r/160286 Change subject: Set $wgAbuseFilterAnonBlockDuration to 3 months on mediawikiwiki .. Set $wgAbuseFilterAnonBlockDuration to 3 months on

[MediaWiki-commits] [Gerrit] Let wikis disable Allow saving code with errors - change (mediawiki...Scribunto)

2014-09-14 Thread Jackmcbarn (Code Review)
Jackmcbarn has uploaded a new change for review. https://gerrit.wikimedia.org/r/160367 Change subject: Let wikis disable Allow saving code with errors .. Let wikis disable Allow saving code with errors Add

[MediaWiki-commits] [Gerrit] Don't allow granting a removed group - change (operations/mediawiki-config)

2014-09-14 Thread Jackmcbarn (Code Review)
Jackmcbarn has uploaded a new change for review. https://gerrit.wikimedia.org/r/160372 Change subject: Don't allow granting a removed group .. Don't allow granting a removed group If a wiki removed the reviewer group (like

[MediaWiki-commits] [Gerrit] Don't list nonexistent groups as addable or removable - change (mediawiki/core)

2014-09-14 Thread Jackmcbarn (Code Review)
Jackmcbarn has uploaded a new change for review. https://gerrit.wikimedia.org/r/160377 Change subject: Don't list nonexistent groups as addable or removable .. Don't list nonexistent groups as addable or removable You can't

[MediaWiki-commits] [Gerrit] Re-enable the Lua profiler on HHVM - change (operations/mediawiki-config)

2014-09-11 Thread Jackmcbarn (Code Review)
Jackmcbarn has uploaded a new change for review. https://gerrit.wikimedia.org/r/159903 Change subject: Re-enable the Lua profiler on HHVM .. Re-enable the Lua profiler on HHVM Now that bug 68413 is fixed, there's no reason

[MediaWiki-commits] [Gerrit] Only skip apparent null-edits when the page exists - change (mediawiki...AbuseFilter)

2014-09-10 Thread Jackmcbarn (Code Review)
Jackmcbarn has uploaded a new change for review. https://gerrit.wikimedia.org/r/159556 Change subject: Only skip apparent null-edits when the page exists .. Only skip apparent null-edits when the page exists Bug: 70675

[MediaWiki-commits] [Gerrit] Don't output a semicolon at the end of CSS - change (mediawiki...Scribunto)

2014-09-10 Thread Jackmcbarn (Code Review)
Jackmcbarn has uploaded a new change for review. https://gerrit.wikimedia.org/r/159629 Change subject: Don't output a semicolon at the end of CSS .. Don't output a semicolon at the end of CSS It's not necessary, it makes the

[MediaWiki-commits] [Gerrit] Simplify if statement logic - change (mediawiki...Popups)

2014-09-10 Thread Jackmcbarn (Code Review)
Jackmcbarn has uploaded a new change for review. https://gerrit.wikimedia.org/r/159654 Change subject: Simplify if statement logic .. Simplify if statement logic (A and B) or ~A is the same as ~A or B, so use the latter.

[MediaWiki-commits] [Gerrit] Expose variables (aka magic words) to Lua - change (mediawiki...Scribunto)

2014-09-08 Thread Jackmcbarn (Code Review)
Jackmcbarn has uploaded a new change for review. https://gerrit.wikimedia.org/r/159238 Change subject: Expose variables (aka magic words) to Lua .. Expose variables (aka magic words) to Lua Currently, there's no way to get a

[MediaWiki-commits] [Gerrit] Warn about bug 44011 - change (mediawiki/core)

2014-09-07 Thread Jackmcbarn (Code Review)
Jackmcbarn has uploaded a new change for review. https://gerrit.wikimedia.org/r/158935 Change subject: Warn about bug 44011 .. Warn about bug 44011 Add a note to the documentation for $wgURLProtocols warning about bug

[MediaWiki-commits] [Gerrit] Increase $wgSVGMaxSize to 4096 - change (operations/mediawiki-config)

2014-09-07 Thread Jackmcbarn (Code Review)
Jackmcbarn has uploaded a new change for review. https://gerrit.wikimedia.org/r/158951 Change subject: Increase $wgSVGMaxSize to 4096 .. Increase $wgSVGMaxSize to 4096 With everyone having big monitors these days, 2048 just

[MediaWiki-commits] [Gerrit] Output nbsp; instead of #nbsp; - change (mediawiki...Scribunto)

2014-09-06 Thread Jackmcbarn (Code Review)
Jackmcbarn has uploaded a new change for review. https://gerrit.wikimedia.org/r/158872 Change subject: Output nbsp; instead of #nbsp; .. Output nbsp; instead of #nbsp; Bug: 70475 Change-Id:

  1   2   3   >