[MediaWiki-commits] [Gerrit] operations/puppet[production]: Fix 'sql' script for multi-instance hosts

2018-01-08 Thread Tim Starling (Code Review)
Tim Starling has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/397912 ) Change subject: Fix 'sql' script for multi-instance hosts .. Fix 'sql' script for multi-instance hosts It needs to extract

[MediaWiki-commits] [Gerrit] mediawiki...luasandbox[master]: Fix README again

2018-01-04 Thread Tim Starling (Code Review)
Tim Starling has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/402169 ) Change subject: Fix README again .. Fix README again Change-Id: Ifcb2445b7fc076ba5f9f20e7c59aba9ca361139f --- M README 1 file

[MediaWiki-commits] [Gerrit] mediawiki...luasandbox[master]: Update README to remove reference to LuaJIT

2018-01-03 Thread Tim Starling (Code Review)
Tim Starling has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/401894 ) Change subject: Update README to remove reference to LuaJIT .. Update README to remove reference to LuaJIT Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/vendor[master]: Update wikimedia/remex-html to 1.0.2

2018-01-01 Thread Tim Starling (Code Review)
Tim Starling has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/401416 ) Change subject: Update wikimedia/remex-html to 1.0.2 .. Update wikimedia/remex-html to 1.0.2 Bug: T183379 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Split limit report out of Parser::parse()

2017-12-07 Thread Tim Starling (Code Review)
Tim Starling has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/396303 ) Change subject: Split limit report out of Parser::parse() .. Split limit report out of Parser::parse() It was 100 lines. Also update

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Fix maintenance script failure when run as a child of a Fast...

2017-12-07 Thread Tim Starling (Code Review)
Tim Starling has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/396301 ) Change subject: Fix maintenance script failure when run as a child of a FastCGI worker .. Fix maintenance script failure when run as

[MediaWiki-commits] [Gerrit] mediawiki...namespaceizer[master]: Add a tool to modify and standardize file headers

2017-12-03 Thread Tim Starling (Code Review)
Tim Starling has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/394905 ) Change subject: Add a tool to modify and standardize file headers .. Add a tool to modify and standardize file headers See the core

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Move license headers out of @file, and other cleanups

2017-12-03 Thread Tim Starling (Code Review)
Tim Starling has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/394904 ) Change subject: Move license headers out of @file, and other cleanups .. Move license headers out of @file, and other cleanups This

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: A few doc comment fixups

2017-12-03 Thread Tim Starling (Code Review)
Tim Starling has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/394903 ) Change subject: A few doc comment fixups .. A few doc comment fixups * Remove some creation dates, they are not protected by GPL *

[MediaWiki-commits] [Gerrit] mediawiki...namespaceizer[master]: Added conflict and reserved word detection

2017-11-30 Thread Tim Starling (Code Review)
Tim Starling has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/392364 ) Change subject: Added conflict and reserved word detection .. Added conflict and reserved word detection Detect conflicts due

[MediaWiki-commits] [Gerrit] mediawiki...namespaceizer[master]: Added conflict and reserved word detection

2017-11-19 Thread Tim Starling (Code Review)
Tim Starling has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/392364 ) Change subject: Added conflict and reserved word detection .. Added conflict and reserved word detection Detect conflicts due to two

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Fix RemexCompatMunger infinite recursion

2017-11-17 Thread Tim Starling (Code Review)
Tim Starling has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/392028 ) Change subject: Fix RemexCompatMunger infinite recursion .. Fix RemexCompatMunger infinite recursion When TreeBuilder requests

[MediaWiki-commits] [Gerrit] operations/puppet[production]: In furl use /usr/bin/php instead of php5

2017-11-15 Thread Tim Starling (Code Review)
Tim Starling has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/391748 ) Change subject: In furl use /usr/bin/php instead of php5 .. In furl use /usr/bin/php instead of php5 This FastCGI client script

[MediaWiki-commits] [Gerrit] operations...dcat[master]: Work around HHVM bug by using XMLWriter::writeAttribute()

2017-11-14 Thread Tim Starling (Code Review)
Tim Starling has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/391489 ) Change subject: Work around HHVM bug by using XMLWriter::writeAttribute() .. Work around HHVM bug by using XMLWriter::writeAttribute()

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Do not limit filesize when running a maintenance script

2017-11-14 Thread Tim Starling (Code Review)
Tim Starling has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/391170 ) Change subject: Do not limit filesize when running a maintenance script .. Do not limit filesize when running a maintenance script

[MediaWiki-commits] [Gerrit] mediawiki...Wikibase[master]: To identify superseded requests, use the requested search te...

2017-11-09 Thread Tim Starling (Code Review)
Tim Starling has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/390365 ) Change subject: To identify superseded requests, use the requested search term instead of the returned search term .. To identify

[MediaWiki-commits] [Gerrit] operations/puppet[production]: dumps: Fix typo in archive_index.html

2017-11-01 Thread Tim Starling (Code Review)
Tim Starling has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/387977 ) Change subject: dumps: Fix typo in archive_index.html .. dumps: Fix typo in archive_index.html Change-Id:

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Update dumps archive_index.html for the files I just uploaded

2017-11-01 Thread Tim Starling (Code Review)
Tim Starling has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/383958 ) Change subject: Update dumps archive_index.html for the files I just uploaded .. Update dumps archive_index.html for the files

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Update dumps archive_index.html for the files I just uploaded

2017-10-12 Thread Tim Starling (Code Review)
Tim Starling has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/383958 ) Change subject: Update dumps archive_index.html for the files I just uploaded .. Update dumps archive_index.html for the files I just

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Deprecate $wgEnableAPI and $wgEnableWriteAPI

2017-10-11 Thread Tim Starling (Code Review)
Tim Starling has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/383726 ) Change subject: Deprecate $wgEnableAPI and $wgEnableWriteAPI .. Deprecate $wgEnableAPI and $wgEnableWriteAPI $wgEnableAPI and

[MediaWiki-commits] [Gerrit] mediawiki...Vector[wmf/1.31.0-wmf.1]: [1.31.0-wmf.1] Fix reversed nav elements when viewing cached...

2017-09-27 Thread Tim Starling (Code Review)
Tim Starling has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/381161 ) Change subject: [1.31.0-wmf.1] Fix reversed nav elements when viewing cached HTML .. [1.31.0-wmf.1] Fix reversed nav elements when

[MediaWiki-commits] [Gerrit] mediawiki/core[wmf/1.30.0-wmf.18]: [1.30.0-wmf.18] SECURITY: Fix handling of CommentStore and i...

2017-09-18 Thread Tim Starling (Code Review)
Tim Starling has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/378819 ) Change subject: [1.30.0-wmf.18] SECURITY: Fix handling of CommentStore and insertSelect .. [1.30.0-wmf.18] SECURITY: Fix handling of

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: SECURITY: Fix handling of CommentStore and insertSelect

2017-09-18 Thread Tim Starling (Code Review)
Tim Starling has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/378818 ) Change subject: SECURITY: Fix handling of CommentStore and insertSelect .. SECURITY: Fix handling of CommentStore and insertSelect

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Use RemexHtml instead of Tidy on mediawikiwiki, testwiki

2017-09-13 Thread Tim Starling (Code Review)
Tim Starling has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/377943 ) Change subject: Use RemexHtml instead of Tidy on mediawikiwiki, testwiki .. Use RemexHtml instead of Tidy on mediawikiwiki, testwiki

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Re-enable EtcdConfig in beta cluster

2017-08-31 Thread Tim Starling (Code Review)
Tim Starling has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/375108 ) Change subject: Re-enable EtcdConfig in beta cluster .. Re-enable EtcdConfig in beta cluster Use a single EtcdConfig object, with

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: EtcdConfig: allow slashes in config key names

2017-08-31 Thread Tim Starling (Code Review)
Tim Starling has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/375104 ) Change subject: EtcdConfig: allow slashes in config key names .. EtcdConfig: allow slashes in config key names Allowing slashes in

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Revert "Fix link prefix/suffixes around Category and Languag...

2017-08-31 Thread Tim Starling (Code Review)
Hello Subramanya Sastry, C. Scott Ananian, jenkins-bot, Arlolra, Jackmcbarn, I'd like you to do a code review. Please visit https://gerrit.wikimedia.org/r/375095 to review the following change. Change subject: Revert "Fix link prefix/suffixes around Category and Language links."

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Split common pre-setup code out of WebStart/doMaintenance

2017-08-22 Thread Tim Starling (Code Review)
Tim Starling has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/373174 ) Change subject: Split common pre-setup code out of WebStart/doMaintenance .. Split common pre-setup code out of WebStart/doMaintenance

[MediaWiki-commits] [Gerrit] mediawiki...namespaceizer[master]: [WIP] Core alias list

2017-08-18 Thread Tim Starling (Code Review)
Tim Starling has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/372521 ) Change subject: [WIP] Core alias list .. [WIP] Core alias list Bug: T166010 Change-Id: I05949673837e797093da7b4e4241c00077f912ec ---

[MediaWiki-commits] [Gerrit] mediawiki...PoolCounter[master]: Add README.md

2017-07-26 Thread Tim Starling (Code Review)
Tim Starling has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/368126 ) Change subject: Add README.md .. Add README.md Change-Id: Iad03c9ef47cef99056f19bbaf1672952399279d7 --- A README.md 1 file

[MediaWiki-commits] [Gerrit] mediawiki...PoolCounter[master]: Show the hostname in error messages

2017-07-21 Thread Tim Starling (Code Review)
Tim Starling has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/366983 ) Change subject: Show the hostname in error messages .. Show the hostname in error messages It's helpful for the system administrator

[MediaWiki-commits] [Gerrit] mediawiki...PoolCounter[master]: Fix hour count in stats

2017-07-21 Thread Tim Starling (Code Review)
Tim Starling has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/366789 ) Change subject: Fix hour count in stats .. Fix hour count in stats Change-Id: If886a9ac864ae063c1a121840fbb80f88b6ab1b7 --- M

[MediaWiki-commits] [Gerrit] mediawiki...luasandbox[debian]: Updates for release of 2.0.13

2017-07-20 Thread Tim Starling (Code Review)
Tim Starling has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/366785 ) Change subject: Updates for release of 2.0.13 .. Updates for release of 2.0.13 * Changelog for branch merge * Non-alpha version

[MediaWiki-commits] [Gerrit] mediawiki...luasandbox[debian]: Merge branch 'master' into debian

2017-07-20 Thread Tim Starling (Code Review)
Tim Starling has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/366782 ) Change subject: Merge branch 'master' into debian .. Merge branch 'master' into debian Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...ParserMigration[master]: Add API to ParserMigration

2017-06-29 Thread Tim Starling (Code Review)
Tim Starling has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/362331 ) Change subject: Add API to ParserMigration .. Add API to ParserMigration Bug: T162275 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...Wigo3[master]: Add .gitreview

2017-06-15 Thread Tim Starling (Code Review)
Tim Starling has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/359108 ) Change subject: Add .gitreview .. Add .gitreview Change-Id: I1346fdb941be02d37963d7d35f1833a96b9a5db9 --- A .gitreview 1 file

[MediaWiki-commits] [Gerrit] mediawiki...Wigo3[master]: Fix security vulnerabilities

2017-06-15 Thread Tim Starling (Code Review)
Tim Starling has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/359107 ) Change subject: Fix security vulnerabilities .. Fix security vulnerabilities Removed some commented-out code so that I didn't have to

[MediaWiki-commits] [Gerrit] mediawiki...RemexHtml[master]: Add contributor list

2017-06-12 Thread Tim Starling (Code Review)
Tim Starling has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/358508 ) Change subject: Add contributor list .. Add contributor list Change-Id: I8a5548d760dc0be7ae6142538c9e94e777fa9709 --- A CREDITS 1

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Fix SqlBagOStuff exptime uniqueness assumption

2017-06-10 Thread Tim Starling (Code Review)
Tim Starling has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/358166 ) Change subject: Fix SqlBagOStuff exptime uniqueness assumption .. Fix SqlBagOStuff exptime uniqueness assumption The WMF parser cache

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Improve test coverage in includes/password

2017-06-05 Thread Tim Starling (Code Review)
Tim Starling has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/357338 ) Change subject: Improve test coverage in includes/password .. Improve test coverage in includes/password From 21% to 82%. * Added

[MediaWiki-commits] [Gerrit] operations/puppet[production]: For HHVM set LANG=C.UTF-8

2017-05-11 Thread Tim Starling (Code Review)
Tim Starling has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/353228 ) Change subject: For HHVM set LANG=C.UTF-8 .. For HHVM set LANG=C.UTF-8 If we set the locale to this using setlocale() in Setup.php,

[MediaWiki-commits] [Gerrit] mediawiki...AbuseFilter[master]: Fix usage of $db->nextSequenceValue()

2017-05-10 Thread Tim Starling (Code Review)
Tim Starling has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/353198 ) Change subject: Fix usage of $db->nextSequenceValue() .. Fix usage of $db->nextSequenceValue() The return value from the method is

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Remove EtcdConfig from beta cluster for now

2017-05-04 Thread Tim Starling (Code Review)
Tim Starling has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/351767 ) Change subject: Remove EtcdConfig from beta cluster for now .. Remove EtcdConfig from beta cluster for now To match production. We're

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: EtcdConfig: Fix infinite timeout bug, and reduce timeout

2017-05-03 Thread Tim Starling (Code Review)
Tim Starling has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/351759 ) Change subject: EtcdConfig: Fix infinite timeout bug, and reduce timeout .. EtcdConfig: Fix infinite timeout bug, and reduce timeout

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Revert "Enable EtcdConfig in production"

2017-05-02 Thread Tim Starling (Code Review)
Hello Giuseppe Lavagetto, Krinkle, Brion VIBBER, jenkins-bot, Volans, I'd like you to do a code review. Please visit https://gerrit.wikimedia.org/r/351550 to review the following change. Change subject: Revert "Enable EtcdConfig in production"

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Revert "wmf-config: readonly is set in etcd now"

2017-05-02 Thread Tim Starling (Code Review)
Hello Giuseppe Lavagetto, jenkins-bot, Volans, I'd like you to do a code review. Please visit https://gerrit.wikimedia.org/r/351551 to review the following change. Change subject: Revert "wmf-config: readonly is set in etcd now"

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Add $wmfMasterDatacenter to meta=siteinfo

2017-05-01 Thread Tim Starling (Code Review)
Tim Starling has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/351232 ) Change subject: Add $wmfMasterDatacenter to meta=siteinfo .. Add $wmfMasterDatacenter to meta=siteinfo Bug: T156924 Change-Id:

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Disable suppress_san_warnings

2017-05-01 Thread Tim Starling (Code Review)
Tim Starling has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/351223 ) Change subject: Disable suppress_san_warnings .. Disable suppress_san_warnings conftool::__init__: Could not load driver

[MediaWiki-commits] [Gerrit] operations/puppet[production]: Disable suppress_san_warnings

2017-05-01 Thread Tim Starling (Code Review)
Tim Starling has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/351223 ) Change subject: Disable suppress_san_warnings .. Disable suppress_san_warnings conftool::__init__: Could not load driver etcd:

[MediaWiki-commits] [Gerrit] operations/puppet[production]: conftool: add mwconfig object type, define the first couple ...

2017-05-01 Thread Tim Starling (Code Review)
Tim Starling has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/347360 ) Change subject: conftool: add mwconfig object type, define the first couple variables .. conftool: add mwconfig object type,

[MediaWiki-commits] [Gerrit] mediawiki/core[wmf/1.29.0-wmf.21]: [1.29.0-wmf.21] config: Use less generic cache key, and not ...

2017-05-01 Thread Tim Starling (Code Review)
Tim Starling has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/351217 ) Change subject: [1.29.0-wmf.21] config: Use less generic cache key, and not fragmented by wiki .. [1.29.0-wmf.21] config: Use less

[MediaWiki-commits] [Gerrit] mediawiki/core[wmf/1.29.0-wmf.21]: EtcdConfig: use array_key_exists(), the value can be null

2017-05-01 Thread Tim Starling (Code Review)
Tim Starling has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/351208 ) Change subject: EtcdConfig: use array_key_exists(), the value can be null .. EtcdConfig: use array_key_exists(), the value can be null

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Enable EtcdConfig in production

2017-04-30 Thread Tim Starling (Code Review)
Tim Starling has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/351132 ) Change subject: Enable EtcdConfig in production .. Enable EtcdConfig in production Ideally, Iae175401da8d should be present before

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: EtcdConfig: use array_key_exists(), the value can be null

2017-04-27 Thread Tim Starling (Code Review)
Tim Starling has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/350793 ) Change subject: EtcdConfig: use array_key_exists(), the value can be null .. EtcdConfig: use array_key_exists(), the value can be null

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Make "eval.php -d 2" work again

2017-04-27 Thread Tim Starling (Code Review)
Tim Starling has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/350786 ) Change subject: Make "eval.php -d 2" work again .. Make "eval.php -d 2" work again Instead of iterating through load balancer info,

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Improve HTTP logging

2017-04-27 Thread Tim Starling (Code Review)
Tim Starling has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/350787 ) Change subject: Improve HTTP logging .. Improve HTTP logging * Log HTTP debug lines to the "http" channel instead of wfDebug() * Add

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Add ConsoleLogger, use it for eval.php -d

2017-04-27 Thread Tim Starling (Code Review)
Tim Starling has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/350781 ) Change subject: Add ConsoleLogger, use it for eval.php -d .. Add ConsoleLogger, use it for eval.php -d eval.php previously set

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Document rationale or primary use case for many indexes

2017-04-24 Thread Tim Starling (Code Review)
Tim Starling has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/349872 ) Change subject: Document rationale or primary use case for many indexes .. Document rationale or primary use case for many indexes

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Use EtcdConfig

2017-04-10 Thread Tim Starling (Code Review)
Tim Starling has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/347537 ) Change subject: Use EtcdConfig .. Use EtcdConfig Use a MultiConfig which checks etcd first as the main configuration instance for MW.

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: [WIP] A service for read-only mode

2017-04-09 Thread Tim Starling (Code Review)
Tim Starling has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/347315 ) Change subject: [WIP] A service for read-only mode .. [WIP] A service for read-only mode Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/core[REL1_23]: Fix short array syntax in REL1_23 branch

2017-04-07 Thread Tim Starling (Code Review)
Tim Starling has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/346949 ) Change subject: Fix short array syntax in REL1_23 branch .. Fix short array syntax in REL1_23 branch MW 1.23.x only requires PHP 5.3

[MediaWiki-commits] [Gerrit] mediawiki...ParserMigration[wmf/1.29.0-wmf.18]: Don't run tidy twice

2017-04-04 Thread Tim Starling (Code Review)
Tim Starling has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/346478 ) Change subject: Don't run tidy twice .. Don't run tidy twice It defeats the purpose. Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...ParserMigration[master]: Don't run tidy twice

2017-04-04 Thread Tim Starling (Code Review)
Tim Starling has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/346242 ) Change subject: Don't run tidy twice .. Don't run tidy twice It defeats the purpose. Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Fix two bugs in installer session error display

2017-04-02 Thread Tim Starling (Code Review)
Tim Starling has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/346091 ) Change subject: Fix two bugs in installer session error display .. Fix two bugs in installer session error display If

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Fix incorrect index name in new 1.28.0 installations

2017-04-02 Thread Tim Starling (Code Review)
Tim Starling has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/346090 ) Change subject: Fix incorrect index name in new 1.28.0 installations .. Fix incorrect index name in new 1.28.0 installations This

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Update comment for indexName(), explaining why it exists

2017-03-29 Thread Tim Starling (Code Review)
Tim Starling has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/345494 ) Change subject: Update comment for indexName(), explaining why it exists .. Update comment for indexName(), explaining why it exists

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: RemexCompatMunger: fix a couple of memory leaks

2017-03-22 Thread Tim Starling (Code Review)
Tim Starling has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/344289 ) Change subject: RemexCompatMunger: fix a couple of memory leaks .. RemexCompatMunger: fix a couple of memory leaks Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Add benchmarkTidy.php, to benchmark tidy drivers

2017-03-22 Thread Tim Starling (Code Review)
Tim Starling has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/344290 ) Change subject: Add benchmarkTidy.php, to benchmark tidy drivers .. Add benchmarkTidy.php, to benchmark tidy drivers Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Update RemexHtml to 1.0.1

2017-03-22 Thread Tim Starling (Code Review)
Tim Starling has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/344288 ) Change subject: Update RemexHtml to 1.0.1 .. Update RemexHtml to 1.0.1 For a bug fix Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...release[master]: Add ParserMigration

2017-03-22 Thread Tim Starling (Code Review)
Tim Starling has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/344280 ) Change subject: Add ParserMigration .. Add ParserMigration Change-Id: I0afc58e50f77e67e851bc860ee8198a5607a38e4 --- M

[MediaWiki-commits] [Gerrit] operations/mediawiki-config[master]: Deploy ParserMigration extension

2017-03-22 Thread Tim Starling (Code Review)
Tim Starling has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/344276 ) Change subject: Deploy ParserMigration extension .. Deploy ParserMigration extension A tool to compare RemexHtml output with Tidy.

[MediaWiki-commits] [Gerrit] mediawiki...Scribunto[master]: Make the maximum language cache size configurable

2017-03-19 Thread Tim Starling (Code Review)
Tim Starling has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/343590 ) Change subject: Make the maximum language cache size configurable .. Make the maximum language cache size configurable Make the

[MediaWiki-commits] [Gerrit] mediawiki...RemexHtml[master]: Basic PHPLint support

2017-03-13 Thread Tim Starling (Code Review)
Tim Starling has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/342562 ) Change subject: Basic PHPLint support .. Basic PHPLint support Move src to a directory named after the namespace RemexHtml, to

[MediaWiki-commits] [Gerrit] mediawiki...RemexHtml[master]: Added testing for error counts, and disabled it

2017-03-13 Thread Tim Starling (Code Review)
Tim Starling has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/342556 ) Change subject: Added testing for error counts, and disabled it .. Added testing for error counts, and disabled it Added tests for

[MediaWiki-commits] [Gerrit] mediawiki...RemexHtml[master]: Fix utfnormal dependency to 1.1.0

2017-03-12 Thread Tim Starling (Code Review)
Tim Starling has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/342412 ) Change subject: Fix utfnormal dependency to 1.1.0 .. Fix utfnormal dependency to 1.1.0 Per MW policy Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...RemexHtml[master]: Fix missing breaks in switch statements

2017-03-12 Thread Tim Starling (Code Review)
Tim Starling has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/342413 ) Change subject: Fix missing breaks in switch statements .. Fix missing breaks in switch statements What clown wrote this code, eh?

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: RemexDriver: optional decoding of character references

2017-03-09 Thread Tim Starling (Code Review)
Tim Starling has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/342151 ) Change subject: RemexDriver: optional decoding of character references .. RemexDriver: optional decoding of character references

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Add RemexHtml to the list of available Tidy drivers

2017-03-08 Thread Tim Starling (Code Review)
Tim Starling has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/341921 ) Change subject: Add RemexHtml to the list of available Tidy drivers .. Add RemexHtml to the list of available Tidy drivers Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Fix @covers for FileBackend

2017-02-26 Thread Tim Starling (Code Review)
Tim Starling has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/340065 ) Change subject: Fix @covers for FileBackend .. Fix @covers for FileBackend It's up to the developer to choose the level of

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Fix @covers for (non-integration) parser tests

2017-02-26 Thread Tim Starling (Code Review)
Tim Starling has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/340062 ) Change subject: Fix @covers for (non-integration) parser tests .. Fix @covers for (non-integration) parser tests You have to allow

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Fix @covers for BalancerTest

2017-02-26 Thread Tim Starling (Code Review)
Tim Starling has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/340061 ) Change subject: Fix @covers for BalancerTest .. Fix @covers for BalancerTest This test is intended to cover the whole file, not just

[MediaWiki-commits] [Gerrit] mediawiki/vendor[master]: Add wikimedia/remex-html

2017-02-23 Thread Tim Starling (Code Review)
Tim Starling has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/339600 ) Change subject: Add wikimedia/remex-html .. Add wikimedia/remex-html For I900155b7dd199b0ae2a3b9cdb6db5136fc4f35a8 Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...RemexHtml[master]: Explain "fast not elegant" in README.md

2017-02-23 Thread Tim Starling (Code Review)
Tim Starling has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/339596 ) Change subject: Explain "fast not elegant" in README.md .. Explain "fast not elegant" in README.md Per Subbu's suggestion Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Log a backtrace from the culprit location if headers were al...

2017-02-19 Thread Tim Starling (Code Review)
Tim Starling has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/338705 ) Change subject: Log a backtrace from the culprit location if headers were already sent .. Log a backtrace from the culprit location

[MediaWiki-commits] [Gerrit] mediawiki...RemexHtml[master]: Guard against runtime creation of undeclared properties

2017-02-16 Thread Tim Starling (Code Review)
Tim Starling has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/338309 ) Change subject: Guard against runtime creation of undeclared properties .. Guard against runtime creation of undeclared properties

[MediaWiki-commits] [Gerrit] mediawiki...RemexHtml[master]: Add Serializer::getLastChild()

2017-02-15 Thread Tim Starling (Code Review)
Tim Starling has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/338051 ) Change subject: Add Serializer::getLastChild() .. Add Serializer::getLastChild() Change-Id: Icd5df8c83930849cb3438393f99ff88654d187a3

[MediaWiki-commits] [Gerrit] mediawiki...RemexHtml[master]: Fix CachingStack::dump

2017-02-14 Thread Tim Starling (Code Review)
Tim Starling has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/337773 ) Change subject: Fix CachingStack::dump .. Fix CachingStack::dump Change-Id: I8d84da0440b05e47226252c975dfbc4a68aa5d54 --- M

[MediaWiki-commits] [Gerrit] mediawiki...RemexHtml[master]: Composer updates: ext-mbstring, add gitattributes

2017-02-14 Thread Tim Starling (Code Review)
Tim Starling has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/337772 ) Change subject: Composer updates: ext-mbstring, add gitattributes .. Composer updates: ext-mbstring, add gitattributes Change-Id:

[MediaWiki-commits] [Gerrit] mediawiki...RemexHtml[master]: Some Serializer changes to support extending it

2017-02-14 Thread Tim Starling (Code Review)
Tim Starling has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/337774 ) Change subject: Some Serializer changes to support extending it .. Some Serializer changes to support extending it RemexCompatMunger

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: [WIP] RemexHtml tidy driver with p-wrapping

2017-02-14 Thread Tim Starling (Code Review)
Tim Starling has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/337771 ) Change subject: [WIP] RemexHtml tidy driver with p-wrapping .. [WIP] RemexHtml tidy driver with p-wrapping Some tests still fail.

[MediaWiki-commits] [Gerrit] mediawiki...ParsoidBatchAPI[master]: Do not generate responsive images for iconThumb

2017-02-07 Thread Tim Starling (Code Review)
Tim Starling has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/336569 ) Change subject: Do not generate responsive images for iconThumb .. Do not generate responsive images for iconThumb Should fix the

[MediaWiki-commits] [Gerrit] mediawiki...RemexHtml[master]: Add XML infoset coercion to DOMBuilder

2017-02-01 Thread Tim Starling (Code Review)
Tim Starling has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/335596 ) Change subject: Add XML infoset coercion to DOMBuilder .. Add XML infoset coercion to DOMBuilder * In DOMBuilder, encode names that

[MediaWiki-commits] [Gerrit] mediawiki...RemexHtml[master]: Fix phpcs test.php rule

2017-02-01 Thread Tim Starling (Code Review)
Tim Starling has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/335581 ) Change subject: Fix phpcs test.php rule .. Fix phpcs test.php rule The rule to exclude test.php from phpcs turns out to exclude any

[MediaWiki-commits] [Gerrit] mediawiki...RemexHtml[master]: Improve DOMBuilder and add tests

2017-01-31 Thread Tim Starling (Code Review)
Tim Starling has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/335367 ) Change subject: Improve DOMBuilder and add tests .. Improve DOMBuilder and add tests * Move DOM-related classes to a separate

[MediaWiki-commits] [Gerrit] mediawiki...RemexHtml[master]: Remove XhtmlFormatter and Parser

2017-01-23 Thread Tim Starling (Code Review)
Tim Starling has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/333824 ) Change subject: Remove XhtmlFormatter and Parser .. Remove XhtmlFormatter and Parser They were not fully baked, and are not necessary

[MediaWiki-commits] [Gerrit] mediawiki/core[master]: Protect -{...}- variant constructs in images.

2016-12-20 Thread Tim Starling (Code Review)
Tim Starling has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/327042 ) Change subject: Protect -{...}- variant constructs in images. .. Protect -{...}- variant constructs in images. A protected

[MediaWiki-commits] [Gerrit] integration/config[master]: Clarify fab reload prompt

2016-12-19 Thread Tim Starling (Code Review)
Tim Starling has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/328334 ) Change subject: Clarify fab reload prompt .. Clarify fab reload prompt Change-Id: Ica548822f08e4402611c8660023b87df75d7b07c --- M

[MediaWiki-commits] [Gerrit] integration/config[master]: Restore "Configure jobs for mediawiki/libs/RemexHtml"

2016-12-19 Thread Tim Starling (Code Review)
Hello Legoktm, jenkins-bot, I'd like you to do a code review. Please visit https://gerrit.wikimedia.org/r/328332 to review the following change. Change subject: Restore "Configure jobs for mediawiki/libs/RemexHtml" ..

[MediaWiki-commits] [Gerrit] mediawiki...RemexHtml[master]: Fixes for old PCRE and PHP 5

2016-12-19 Thread Tim Starling (Code Review)
Tim Starling has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/328331 ) Change subject: Fixes for old PCRE and PHP 5 .. Fixes for old PCRE and PHP 5 * In the script data regex, replace the possessive

[MediaWiki-commits] [Gerrit] mediawiki...RemexHtml[master]: Better README.md

2016-12-19 Thread Tim Starling (Code Review)
Tim Starling has uploaded a new change for review. ( https://gerrit.wikimedia.org/r/328143 ) Change subject: Better README.md .. Better README.md Change-Id: Ic41dd895a6761d7b2e5c0cb55afbb58f237e2ab2 --- M README.md 1 file

  1   2   3   4   5   6   7   8   9   10   >