[MediaWiki-commits] [Gerrit] Move initial selection to first content offset - change (VisualEditor/VisualEditor)

2014-01-10 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/106707 Change subject: Move initial selection to first content offset .. Move initial selection to first content offset This stops weird

[MediaWiki-commits] [Gerrit] Add 'get range on change' toggle button to standalone demo - change (VisualEditor/VisualEditor)

2014-01-11 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/106881 Change subject: Add 'get range on change' toggle button to standalone demo .. Add 'get range on change' toggle button to standalone demo

[MediaWiki-commits] [Gerrit] Update categories HTML on page save - change (mediawiki...VisualEditor)

2014-01-12 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/107036 Change subject: Update categories HTML on page save .. Update categories HTML on page save Because there's an API for that. Bug: 48560

[MediaWiki-commits] [Gerrit] Hide #contentSub properly - change (mediawiki...VisualEditor)

2014-01-13 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/107133 Change subject: Hide #contentSub properly .. Hide #contentSub properly it is treated specially which results in it being set to opacity=0

[MediaWiki-commits] [Gerrit] Check for valid offset when calculating insertion annotations - change (VisualEditor/VisualEditor)

2014-01-13 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/107134 Change subject: Check for valid offset when calculating insertion annotations .. Check for valid offset when calculating insertion

[MediaWiki-commits] [Gerrit] Fix descriptions of ve.dm.Surface#change tests - change (VisualEditor/VisualEditor)

2014-01-13 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/107137 Change subject: Fix descriptions of ve.dm.Surface#change tests .. Fix descriptions of ve.dm.Surface#change tests Change-Id:

[MediaWiki-commits] [Gerrit] Fix deletion inside a structural node at start/end of document - change (VisualEditor/VisualEditor)

2014-01-13 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/107142 Change subject: Fix deletion inside a structural node at start/end of document .. Fix deletion inside a structural node at start/end of

[MediaWiki-commits] [Gerrit] WIP Keyboard shortcuts dialog - change (VisualEditor/VisualEditor)

2014-01-13 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/107153 Change subject: WIP Keyboard shortcuts dialog .. WIP Keyboard shortcuts dialog TODO: * Define shortcuts list manually, instead of scraping

[MediaWiki-commits] [Gerrit] Fix more copyright headers not updated to 2013 - change (VisualEditor/VisualEditor)

2014-01-13 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/107155 Change subject: Fix more copyright headers not updated to 2013 .. Fix more copyright headers not updated to 2013 Change-Id:

[MediaWiki-commits] [Gerrit] Fix more copyright headers not updated to 2014 - change (oojs/ui)

2014-01-13 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/107157 Change subject: Fix more copyright headers not updated to 2014 .. Fix more copyright headers not updated to 2014 Change-Id:

[MediaWiki-commits] [Gerrit] Fix more copyright headers not updated to 2013 - change (mediawiki...VisualEditor)

2014-01-13 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/107156 Change subject: Fix more copyright headers not updated to 2013 .. Fix more copyright headers not updated to 2013 Change-Id:

[MediaWiki-commits] [Gerrit] Fix comment in header for MWEditModeTool - change (mediawiki...VisualEditor)

2014-01-13 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/107160 Change subject: Fix comment in header for MWEditModeTool .. Fix comment in header for MWEditModeTool Change-Id:

[MediaWiki-commits] [Gerrit] Replace emdash with hypen - change (VisualEditor/VisualEditor)

2014-01-13 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/107162 Change subject: Replace emdash with hypen .. Replace emdash with hypen For consistency with VE copyright dates when replacing in the

[MediaWiki-commits] [Gerrit] Refactor converter test utils to run single cases - change (VisualEditor/VisualEditor)

2014-01-14 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/107381 Change subject: Refactor converter test utils to run single cases .. Refactor converter test utils to run single cases This is so we can

[MediaWiki-commits] [Gerrit] Wrap text nodes in spans if trying to mark as data-ve-ignore - change (mediawiki...VisualEditor)

2014-01-14 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/107511 Change subject: Wrap text nodes in spans if trying to mark as data-ve-ignore .. Wrap text nodes in spans if trying to mark as

[MediaWiki-commits] [Gerrit] About-group extra DOM data in toDomElements - change (mediawiki...VisualEditor)

2014-01-15 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/107559 Change subject: About-group extra DOM data in toDomElements .. About-group extra DOM data in toDomElements Although marked as

[MediaWiki-commits] [Gerrit] Make min/max dimensions configurable on ResizableNode - change (VisualEditor/VisualEditor)

2014-01-15 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/107604 Change subject: Make min/max dimensions configurable on ResizableNode .. Make min/max dimensions configurable on ResizableNode Make

[MediaWiki-commits] [Gerrit] Make config default to an empty object in ResizableNode - change (VisualEditor/VisualEditor)

2014-01-15 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/107603 Change subject: Make config default to an empty object in ResizableNode .. Make config default to an empty object in ResizableNode Makes

[MediaWiki-commits] [Gerrit] Only show non-anchored resize handles for MWBlock/InlineImages - change (mediawiki...VisualEditor)

2014-01-15 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/107736 Change subject: Only show non-anchored resize handles for MWBlock/InlineImages .. Only show non-anchored resize handles for

[MediaWiki-commits] [Gerrit] Add method to show only specified resize handles - change (VisualEditor/VisualEditor)

2014-01-15 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/107737 Change subject: Add method to show only specified resize handles .. Add method to show only specified resize handles Depending on how an

[MediaWiki-commits] [Gerrit] Fix png transparency on required.png - change (oojs/ui)

2014-01-16 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/107834 Change subject: Fix png transparency on required.png .. Fix png transparency on required.png Change-Id:

[MediaWiki-commits] [Gerrit] Fix png transparency on gallery.png - change (mediawiki...VisualEditor)

2014-01-16 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/107835 Change subject: Fix png transparency on gallery.png .. Fix png transparency on gallery.png Change-Id:

[MediaWiki-commits] [Gerrit] Update uses of Push/IconButtonWidget to ButtonWidget - change (VisualEditor/VisualEditor)

2014-01-17 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/108043 Change subject: Update uses of Push/IconButtonWidget to ButtonWidget .. Update uses of Push/IconButtonWidget to ButtonWidget Separated

[MediaWiki-commits] [Gerrit] Update uses of Push/IconButtonWidget to ButtonWidget in MW - change (mediawiki...VisualEditor)

2014-01-17 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/108044 Change subject: Update uses of Push/IconButtonWidget to ButtonWidget in MW .. Update uses of Push/IconButtonWidget to ButtonWidget in MW

[MediaWiki-commits] [Gerrit] Protect RDFa attributes from obliteration - change (VisualEditor/VisualEditor)

2014-01-21 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/108680 Change subject: Protect RDFa attributes from obliteration .. Protect RDFa attributes from obliteration Firefox decides to not keep some

[MediaWiki-commits] [Gerrit] Fix exception thrown by findEndOfNode - change (VisualEditor/VisualEditor)

2014-01-21 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/108692 Change subject: Fix exception thrown by findEndOfNode .. Fix exception thrown by findEndOfNode Also rewrite init/while/increment as a for

[MediaWiki-commits] [Gerrit] Fix Document#selectNodes error documentation - change (VisualEditor/VisualEditor)

2014-01-21 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/108695 Change subject: Fix Document#selectNodes error documentation .. Fix Document#selectNodes error documentation Change-Id:

[MediaWiki-commits] [Gerrit] Remove unnecessary strangely written range clone - change (mediawiki...VisualEditor)

2014-01-21 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/108697 Change subject: Remove unnecessary strangely written range clone .. Remove unnecessary strangely written range clone Probably left over

[MediaWiki-commits] [Gerrit] Fix up result of selectNodes to remove empty items - change (VisualEditor/VisualEditor)

2014-01-21 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/108720 Change subject: Fix up result of selectNodes to remove empty items .. Fix up result of selectNodes to remove empty items Bug: 60117

[MediaWiki-commits] [Gerrit] Add internalList nodes to example data - change (VisualEditor/VisualEditor)

2014-01-22 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/108920 Change subject: Add internalList nodes to example data .. Add internalList nodes to example data So they can be used to create full

[MediaWiki-commits] [Gerrit] Resolve URLs against correct document when copying. - change (VisualEditor/VisualEditor)

2014-01-22 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/108953 Change subject: Resolve URLs against correct document when copying. .. Resolve URLs against correct document when copying. Also provide

[MediaWiki-commits] [Gerrit] Relativise URLs against target document - change (mediawiki...VisualEditor)

2014-01-22 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/108954 Change subject: Relativise URLs against target document .. Relativise URLs against target document mw.Uri will just be using

[MediaWiki-commits] [Gerrit] WIP Find and replace - change (VisualEditor/VisualEditor)

2014-11-19 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/174491 Change subject: WIP Find and replace .. WIP Find and replace To-do: * UI * Show/hide trigger Change-Id:

[MediaWiki-commits] [Gerrit] Remove unused CSS: toolbar contains no PopupButtonWidgets - change (mediawiki...VisualEditor)

2014-11-20 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/174686 Change subject: Remove unused CSS: toolbar contains no PopupButtonWidgets .. Remove unused CSS: toolbar contains no PopupButtonWidgets

[MediaWiki-commits] [Gerrit] Use super to call parent constructors - change (mediawiki...VisualEditor)

2014-11-20 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/174687 Change subject: Use super to call parent constructors .. Use super to call parent constructors Change-Id:

[MediaWiki-commits] [Gerrit] Fix z-indexes in core - change (VisualEditor/VisualEditor)

2014-11-20 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/174688 Change subject: Fix z-indexes in core .. Fix z-indexes in core The toolbar only needs to be z-index 1, not 100. The global overlay needs to

[MediaWiki-commits] [Gerrit] Give help content box a reasonable line height for legibility - change (oojs/ui)

2014-11-20 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/174692 Change subject: Give help content box a reasonable line height for legibility .. Give help content box a reasonable line height for

[MediaWiki-commits] [Gerrit] Fix poision of popup anchor, specifically on the help conten... - change (oojs/ui)

2014-11-20 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/174700 Change subject: Fix poision of popup anchor, specifically on the help content popup. .. Fix poision of popup anchor, specifically on the

[MediaWiki-commits] [Gerrit] Restore toolbar class - change (oojs/ui)

2014-11-20 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/174743 Change subject: Restore toolbar class .. Restore toolbar class Change-Id: Ic5b79d251c25a578e8c8efcc4e98aba5630f5c68 --- M src/Toolbar.js 1

[MediaWiki-commits] [Gerrit] Fix lots of spelling mistakes and typos - change (VisualEditor/VisualEditor)

2014-11-21 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/174938 Change subject: Fix lots of spelling mistakes and typos .. Fix lots of spelling mistakes and typos Change-Id:

[MediaWiki-commits] [Gerrit] Fix lots of spelling mistakes and typos - change (oojs/ui)

2014-11-21 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/174940 Change subject: Fix lots of spelling mistakes and typos .. Fix lots of spelling mistakes and typos Change-Id:

[MediaWiki-commits] [Gerrit] Fix lots of spelling mistakes and typos - change (mediawiki...VisualEditor)

2014-11-21 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/174941 Change subject: Fix lots of spelling mistakes and typos .. Fix lots of spelling mistakes and typos Change-Id:

[MediaWiki-commits] [Gerrit] Fix lots of spelling mistakes and typos - change (unicodejs)

2014-11-21 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/174942 Change subject: Fix lots of spelling mistakes and typos .. Fix lots of spelling mistakes and typos Change-Id:

[MediaWiki-commits] [Gerrit] Use newFromReplacement in insertContent - change (VisualEditor/VisualEditor)

2014-11-22 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/175208 Change subject: Use newFromReplacement in insertContent .. Use newFromReplacement in insertContent Because processing one transaction is

[MediaWiki-commits] [Gerrit] Pass through excludeInsertions in get(Linear)Fragment - change (VisualEditor/VisualEditor)

2014-11-22 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/175209 Change subject: Pass through excludeInsertions in get(Linear)Fragment .. Pass through excludeInsertions in get(Linear)Fragment Change-Id:

[MediaWiki-commits] [Gerrit] Move getText from dm.Document to ElementLinearData - change (VisualEditor/VisualEditor)

2014-11-22 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/175210 Change subject: Move getText from dm.Document to ElementLinearData .. Move getText from dm.Document to ElementLinearData Also add

[MediaWiki-commits] [Gerrit] Emit ce.Surface#position after dm.Surface#documentUpdate - change (VisualEditor/VisualEditor)

2014-11-22 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/175211 Change subject: Emit ce.Surface#position after dm.Surface#documentUpdate .. Emit ce.Surface#position after dm.Surface#documentUpdate

[MediaWiki-commits] [Gerrit] Fix MW skin hacks - change (mediawiki...VisualEditor)

2014-11-22 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/175222 Change subject: Fix MW skin hacks .. Fix MW skin hacks * Ensure surface widget font size matches main surface, move vector-specific hack

[MediaWiki-commits] [Gerrit] Make debug bar controls narrower - change (VisualEditor/VisualEditor)

2014-11-22 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/175226 Change subject: Make debug bar controls narrower .. Make debug bar controls narrower * Merge dump model (on change), and replace with icon.

[MediaWiki-commits] [Gerrit] Improve logging - change (VisualEditor/VisualEditor)

2014-11-22 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/175227 Change subject: Improve logging .. Improve logging * Refuse to log collapsed selections. * Log all ranges on a table selection. Change-Id:

[MediaWiki-commits] [Gerrit] Move toolbar scroll hack to surface - change (VisualEditor/VisualEditor)

2014-11-22 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/175305 Change subject: Move toolbar scroll hack to surface .. Move toolbar scroll hack to surface Instead of having the toolbar scroll the

[MediaWiki-commits] [Gerrit] Find and replace tool - change (VisualEditor/VisualEditor)

2014-11-22 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/175306 Change subject: Find and replace tool .. Find and replace tool Change-Id: I311b16c5aa5cfa96ac909bbd3aeebeae2a15a2c2 --- M

[MediaWiki-commits] [Gerrit] Create ve.ui.Sequence which matches commands to typed text - change (VisualEditor/VisualEditor)

2014-11-23 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/175334 Change subject: Create ve.ui.Sequence which matches commands to typed text .. Create ve.ui.Sequence which matches commands to typed text

[MediaWiki-commits] [Gerrit] Always return boolean from an action - change (VisualEditor/VisualEditor)

2014-11-23 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/175333 Change subject: Always return boolean from an action .. Always return boolean from an action Command#execute expects this so it knows if

[MediaWiki-commits] [Gerrit] Register 'p# ' sequence for creating numbered lists - change (mediawiki...VisualEditor)

2014-11-23 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/175337 Change subject: Register 'p# ' sequence for creating numbered lists .. Register 'p# ' sequence for creating numbered lists Replaces

[MediaWiki-commits] [Gerrit] Replace hacky wikitext warning listener with sequences - change (mediawiki...VisualEditor)

2014-11-23 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/175336 Change subject: Replace hacky wikitext warning listener with sequences .. Replace hacky wikitext warning listener with sequences Uses the

[MediaWiki-commits] [Gerrit] Always return boolean from an action - change (mediawiki...VisualEditor)

2014-11-23 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/175335 Change subject: Always return boolean from an action .. Always return boolean from an action Command#execute expects this so it knows if

[MediaWiki-commits] [Gerrit] Filter out comments from external paste - change (VisualEditor/VisualEditor)

2014-11-23 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/175392 Change subject: Filter out comments from external paste .. Filter out comments from external paste Bug: T71821 Change-Id:

[MediaWiki-commits] [Gerrit] Filter out comments from external paste - change (mediawiki...VisualEditor)

2014-11-24 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/175415 Change subject: Filter out comments from external paste .. Filter out comments from external paste Bug: T71821 Change-Id:

[MediaWiki-commits] [Gerrit] [BREAKING CHANGE] Rename paste rules to import rules - change (VisualEditor/VisualEditor)

2014-11-24 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/175418 Change subject: [BREAKING CHANGE] Rename paste rules to import rules .. [BREAKING CHANGE] Rename paste rules to import rules Also used by

[MediaWiki-commits] [Gerrit] Rename paste rules to import rules - change (mediawiki...VisualEditor)

2014-11-24 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/175417 Change subject: Rename paste rules to import rules .. Rename paste rules to import rules Also used by drag and drop Depends on I40d1d78 in

[MediaWiki-commits] [Gerrit] [BREAKING CHANGE] Change command list from whitelist to blac... - change (VisualEditor/VisualEditor)

2014-11-24 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/175461 Change subject: [BREAKING CHANGE] Change command list from whitelist to blacklist .. [BREAKING CHANGE] Change command list from whitelist

[MediaWiki-commits] [Gerrit] Use OOjs UI progress bar while VE is loading - change (mediawiki...VisualEditor)

2014-11-24 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/175488 Change subject: Use OOjs UI progress bar while VE is loading .. Use OOjs UI progress bar while VE is loading Depends on OOjs UI CSS being

[MediaWiki-commits] [Gerrit] Add missing documentation for label widget - change (oojs/ui)

2014-11-24 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/175481 Change subject: Add missing documentation for label widget .. Add missing documentation for label widget Change-Id:

[MediaWiki-commits] [Gerrit] Change command list from whitelist to blacklist - change (mediawiki...VisualEditor)

2014-11-24 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/175476 Change subject: Change command list from whitelist to blacklist .. Change command list from whitelist to blacklist Also remove toolbar

[MediaWiki-commits] [Gerrit] Remove padding from undecorated option widgets - change (oojs/ui)

2014-11-24 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/175592 Change subject: Remove padding from undecorated option widgets .. Remove padding from undecorated option widgets No decoration, no padding.

[MediaWiki-commits] [Gerrit] Removing padding override from LanguageResultWidget - change (VisualEditor/VisualEditor)

2014-11-24 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/175605 Change subject: Removing padding override from LanguageResultWidget .. Removing padding override from LanguageResultWidget Depends on

[MediaWiki-commits] [Gerrit] Add missing file ProgressDialog.js - change (mediawiki...VisualEditor)

2014-11-25 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/175680 Change subject: Add missing file ProgressDialog.js .. Add missing file ProgressDialog.js Change-Id:

[MediaWiki-commits] [Gerrit] Files, messages and toolbar config for find and replace - change (mediawiki...VisualEditor)

2014-11-25 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/175699 Change subject: Files, messages and toolbar config for find and replace .. Files, messages and toolbar config for find and replace Depends

[MediaWiki-commits] [Gerrit] Fix rounded corners issue on help button by destroying notices - change (mediawiki...VisualEditor)

2014-11-25 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/175700 Change subject: Fix rounded corners issue on help button by destroying notices .. Fix rounded corners issue on help button by destroying

[MediaWiki-commits] [Gerrit] Fix demo width now that OOUI sets max height - change (VisualEditor/VisualEditor)

2014-11-25 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/175709 Change subject: Fix demo width now that OOUI sets max height .. Fix demo width now that OOUI sets max height Change-Id:

[MediaWiki-commits] [Gerrit] Reduce height hack on command help dialog - change (VisualEditor/VisualEditor)

2014-11-25 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/175724 Change subject: Reduce height hack on command help dialog .. Reduce height hack on command help dialog Any extra height needed for MW

[MediaWiki-commits] [Gerrit] Create ve.ui.MWCommandHelpDialog.css for height hack - change (mediawiki...VisualEditor)

2014-11-25 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/175723 Change subject: Create ve.ui.MWCommandHelpDialog.css for height hack .. Create ve.ui.MWCommandHelpDialog.css for height hack Height differs

[MediaWiki-commits] [Gerrit] Rename variables in surface#execute for clarity - change (VisualEditor/VisualEditor)

2014-11-25 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/175726 Change subject: Rename variables in surface#execute for clarity .. Rename variables in surface#execute for clarity Change-Id:

[MediaWiki-commits] [Gerrit] Refactor WindowAction to include close and toggle methods - change (VisualEditor/VisualEditor)

2014-11-25 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/175748 Change subject: Refactor WindowAction to include close and toggle methods .. Refactor WindowAction to include close and toggle methods

[MediaWiki-commits] [Gerrit] Update inexplicably old version of PapaParse library - change (VisualEditor/VisualEditor)

2014-11-25 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/175758 Change subject: Update inexplicably old version of PapaParse library .. Update inexplicably old version of PapaParse library Change-Id:

[MediaWiki-commits] [Gerrit] Update PapaParse to 4.0.6 - change (VisualEditor/VisualEditor)

2014-11-25 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/175875 Change subject: Update PapaParse to 4.0.6 .. Update PapaParse to 4.0.6 Change-Id: If6581cc4571676c66de00142a09909a8db944f1f --- M

[MediaWiki-commits] [Gerrit] Switch to personal fork of Papa Parse - change (VisualEditor/VisualEditor)

2014-11-25 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/175876 Change subject: Switch to personal fork of Papa Parse .. Switch to personal fork of Papa Parse Fixes async load issue. Will switch back

[MediaWiki-commits] [Gerrit] Add missing documentation to ToolFactory - change (oojs/ui)

2014-11-25 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/175880 Change subject: Add missing documentation to ToolFactory .. Add missing documentation to ToolFactory Change-Id:

[MediaWiki-commits] [Gerrit] Go backwards through find and replace results on shift enter - change (VisualEditor/VisualEditor)

2014-11-25 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/175883 Change subject: Go backwards through find and replace results on shift enter .. Go backwards through find and replace results on shift enter

[MediaWiki-commits] [Gerrit] Move window managers to sub folder - change (VisualEditor/VisualEditor)

2014-11-26 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/175980 Change subject: Move window managers to sub folder .. Move window managers to sub folder Also rename DesktopInspectorManager to

[MediaWiki-commits] [Gerrit] Use selected annotations when replacing content - change (VisualEditor/VisualEditor)

2014-11-26 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/175982 Change subject: Use selected annotations when replacing content .. Use selected annotations when replacing content If you select some

[MediaWiki-commits] [Gerrit] Support toDomElements returning an empty array - change (VisualEditor/VisualEditor)

2014-11-04 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/170958 Change subject: Support toDomElements returning an empty array .. Support toDomElements returning an empty array Change-Id:

[MediaWiki-commits] [Gerrit] Placholder - placeholder - change (VisualEditor/VisualEditor)

2014-11-04 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/170959 Change subject: Placholder - placeholder .. Placholder - placeholder Change-Id: I40178739f988085ce6588f52b6ee3f5314747286 --- M

[MediaWiki-commits] [Gerrit] paralell - parallel - change (oojs/ui)

2014-11-05 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/171233 Change subject: paralell - parallel .. paralell - parallel Change-Id: I9f9aa8df254dacbdc2d539e1a14a7ed31f3c6df3 --- M src/WindowManager.js

[MediaWiki-commits] [Gerrit] Add isAllowed(Child|Parent)NodeType to ve.Node - change (VisualEditor/VisualEditor)

2014-11-05 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/171270 Change subject: Add isAllowed(Child|Parent)NodeType to ve.Node .. Add isAllowed(Child|Parent)NodeType to ve.Node Change-Id:

[MediaWiki-commits] [Gerrit] Node method cleanups - change (VisualEditor/VisualEditor)

2014-11-05 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/171269 Change subject: Node method cleanups .. Node method cleanups For methods which exist in dm ce, move to ve.Node as abstract and replace

[MediaWiki-commits] [Gerrit] Replace block drop logic with isAllowedChildNodeType check - change (VisualEditor/VisualEditor)

2014-11-05 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/171271 Change subject: Replace block drop logic with isAllowedChildNodeType check .. Replace block drop logic with isAllowedChildNodeType check

[MediaWiki-commits] [Gerrit] Don't focus Edit HTML on load - change (VisualEditor/VisualEditor)

2014-11-05 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/171279 Change subject: Don't focus Edit HTML on load .. Don't focus Edit HTML on load Causes scrolling issues. Change-Id:

[MediaWiki-commits] [Gerrit] Create table cells with wrapper paragraphs by default - change (VisualEditor/VisualEditor)

2014-11-05 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/171280 Change subject: Create table cells with wrapper paragraphs by default .. Create table cells with wrapper paragraphs by default Change-Id:

[MediaWiki-commits] [Gerrit] Allow headings in table cells - change (mediawiki...VisualEditor)

2014-11-05 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/171288 Change subject: Allow headings in table cells .. Allow headings in table cells We possibly want to discourage this somehow but our current

[MediaWiki-commits] [Gerrit] Use hasOwn check in EventEmitter#emit - change (oojs/core)

2014-11-05 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/171293 Change subject: Use hasOwn check in EventEmitter#emit .. Use hasOwn check in EventEmitter#emit TODO: Unit test Bug: 73034 Change-Id:

[MediaWiki-commits] [Gerrit] Use OO.hasOwnProperty where appropriate - change (oojs/ui)

2014-11-05 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/171320 Change subject: Use OO.hasOwnProperty where appropriate .. Use OO.hasOwnProperty where appropriate Change-Id:

[MediaWiki-commits] [Gerrit] Use hasOwnProperty instead of 'key in obj' - change (VisualEditor/VisualEditor)

2014-11-05 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/171326 Change subject: Use hasOwnProperty instead of 'key in obj' .. Use hasOwnProperty instead of 'key in obj' Change-Id:

[MediaWiki-commits] [Gerrit] Use hasOwnProperty instead of 'key in obj' - change (mediawiki...VisualEditor)

2014-11-05 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/171328 Change subject: Use hasOwnProperty instead of 'key in obj' .. Use hasOwnProperty instead of 'key in obj' Change-Id:

[MediaWiki-commits] [Gerrit] Add 'indeterminate' state to progress bar widget - change (oojs/ui)

2014-11-06 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/171548 Change subject: Add 'indeterminate' state to progress bar widget .. Add 'indeterminate' state to progress bar widget Use typical 'bouncing'

[MediaWiki-commits] [Gerrit] Refactor out show/hide loading spinner - change (mediawiki...VisualEditor)

2014-11-06 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/171564 Change subject: Refactor out show/hide loading spinner .. Refactor out show/hide loading spinner Change-Id:

[MediaWiki-commits] [Gerrit] Generic progress dialog for drag and drop uploads - change (VisualEditor/VisualEditor)

2014-11-06 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/171770 Change subject: Generic progress dialog for drag and drop uploads .. Generic progress dialog for drag and drop uploads Change-Id:

[MediaWiki-commits] [Gerrit] Show the modal overlay as soon as openWindow is called - change (oojs/ui)

2014-11-07 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/171823 Change subject: Show the modal overlay as soon as openWindow is called .. Show the modal overlay as soon as openWindow is called Dialogs

[MediaWiki-commits] [Gerrit] Support pre's in tables - change (mediawiki...VisualEditor)

2014-11-07 Thread Esanders (Code Review)
Esanders has uploaded a new change for review. https://gerrit.wikimedia.org/r/171835 Change subject: Support pre's in tables .. Support pre's in tables Bug: 73100 Change-Id: I971420047026c91ed92a19a52d2fd3b6fbeac24a --- M

  1   2   3   4   5   6   7   8   9   10   >