[MediaWiki-commits] [Gerrit] Add .gitignore and .gitreview - change (openzim)

2013-09-18 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. Change subject: Add .gitignore and .gitreview .. Add .gitignore and .gitreview Bug: 54175 Change-Id: Ic900b6a1aa3848aa59b428adef19115a9c55ac61 --- A .gitignore A .gitreview 2

[MediaWiki-commits] [Gerrit] Fix mobile/desktop view choices substainability on 3 parts d... - change (mediawiki...MobileFrontend)

2014-03-09 Thread Kelson (Code Review)
Kelson has uploaded a new change for review. https://gerrit.wikimedia.org/r/117699 Change subject: Fix mobile/desktop view choices substainability on 3 parts domain names (like wikimedia.org.uk) #54885 .. Fix mobile/desktop

[MediaWiki-commits] [Gerrit] Allow to backup globalimagelinks table, T87571 - change (operations/dumps)

2015-03-28 Thread Kelson (Code Review)
Kelson has uploaded a new change for review. https://gerrit.wikimedia.org/r/200313 Change subject: Allow to backup globalimagelinks table, T87571 .. Allow to backup globalimagelinks table, T87571 Change-Id:

[MediaWiki-commits] [Gerrit] Fixed wrong libmagic path - change (openzim)

2015-06-07 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. Change subject: Fixed wrong libmagic path .. Fixed wrong libmagic path Change-Id: Ic7674a62530abde447252fd6c0b693a8d741443e --- M zimwriterfs/macosx-build.sh 1 file changed,

[MediaWiki-commits] [Gerrit] Fixed compilation on OSX. made a script to compile both stat... - change (openzim)

2015-06-06 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. Change subject: Fixed compilation on OSX. made a script to compile both static and shared .. Fixed compilation on OSX. made a script to compile both static and shared

[MediaWiki-commits] [Gerrit] Move few utility functions to a separate module. - change (openzim)

2016-06-22 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. Change subject: Move few utility functions to a separate module. .. Move few utility functions to a separate module. Change-Id: Ia26754d14f0cd6c557626675beb5a7c5fe2cadaa ---

[MediaWiki-commits] [Gerrit] Move article's related stuffs in article.(h|cpp). - change (openzim)

2016-06-22 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. Change subject: Move article's related stuffs in article.(h|cpp). .. Move article's related stuffs in article.(h|cpp). Change-Id: I2a257ea1a0a13eca0748b444838a525666a9090d

[MediaWiki-commits] [Gerrit] Move articleSource's related stuffs in articlesource.(h|cpp). - change (openzim)

2016-06-22 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. Change subject: Move articleSource's related stuffs in articlesource.(h|cpp). .. Move articleSource's related stuffs in articlesource.(h|cpp). Change-Id:

[MediaWiki-commits] [Gerrit] Use a Queue object to handle threadsafe access to a queue. - change (openzim)

2016-06-22 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. Change subject: Use a Queue object to handle threadsafe access to a queue. .. Use a Queue object to handle threadsafe access to a queue. By using a Queue object we avoid the

[MediaWiki-commits] [Gerrit] Compress blobs and track file size immediately after adding ... - change (openzim)

2016-06-22 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. Change subject: Compress blobs and track file size immediately after adding each article. .. Compress blobs and track file size immediately after adding each article. Rather

[MediaWiki-commits] [Gerrit] Update build instructions for MacOS X. - change (openzim)

2016-06-21 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. Change subject: Update build instructions for MacOS X. .. Update build instructions for MacOS X. Change-Id: I0190ada3bf02c42ed34cb6d253516a9c662357e1 --- M zimlib/README.md M

[MediaWiki-commits] [Gerrit] Include files from srcdir; built files in builddir. - change (openzim)

2016-06-19 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. Change subject: Include files from srcdir; built files in builddir. .. Include files from srcdir; built files in builddir. Change-Id:

[MediaWiki-commits] [Gerrit] Minor wording and typo fixes to the zimwriterfs README. - change (openzim)

2016-06-18 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. Change subject: Minor wording and typo fixes to the zimwriterfs README. .. Minor wording and typo fixes to the zimwriterfs README. Change-Id:

[MediaWiki-commits] [Gerrit] Move zim::writer::ArticleSource::getData() to zim::writer::A... - change (openzim)

2016-06-23 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. Change subject: Move zim::writer::ArticleSource::getData() to zim::writer::Article::getData(). .. Move zim::writer::ArticleSource::getData() to

[MediaWiki-commits] [Gerrit] Readd call to stripTitleInvalidChars. - change (openzim)

2016-06-23 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. Change subject: Readd call to stripTitleInvalidChars. .. Readd call to stripTitleInvalidChars. Commit 1c969dd remove the call to stripTitleInvalidChars in Article. This was a

[MediaWiki-commits] [Gerrit] Update zimwriterfs makefiles. - change (openzim)

2016-06-18 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. Change subject: Update zimwriterfs makefiles. .. Update zimwriterfs makefiles. Change-Id: Ic0f93e19eb3e07d86c115bd15f47ef5fbc74f954 --- M zimwriterfs/Makefile.am M

[MediaWiki-commits] [Gerrit] Update .gitignore files. - change (openzim)

2016-06-18 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. Change subject: Update .gitignore files. .. Update .gitignore files. Change-Id: Iad8d95fa2deab178396e8804b6e195a5b1520a4a --- C zimlib/.gitignore R zimwriterfs/.gitignore 2

[MediaWiki-commits] [Gerrit] Convert READMEs to markdown. - change (openzim)

2016-06-18 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. Change subject: Convert READMEs to markdown. .. Convert READMEs to markdown. Change-Id: I596bec7ef70bd0a7d45ba67d4fa313d93c861890 --- A README.md D zimlib/README A

[MediaWiki-commits] [Gerrit] Use the system's libgumbo. - change (openzim)

2016-06-18 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. Change subject: Use the system's libgumbo. .. Use the system's libgumbo. Change-Id: Id6b06033bba6c1d47d305b50259e7eaf41c073e2 --- M zimwriterfs/Makefile.am M

[MediaWiki-commits] [Gerrit] Move `throw` statement out of header file. - change (openzim)

2016-06-23 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. Change subject: Move `throw` statement out of header file. .. Move `throw` statement out of header file. This ensures that we don't fail compilation when including the header

[MediaWiki-commits] [Gerrit] Bug fix: correctly update cluster offsets in directory entries. - change (openzim)

2016-06-26 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. Change subject: Bug fix: correctly update cluster offsets in directory entries. .. Bug fix: correctly update cluster offsets in directory entries. This is a follow-up to

[MediaWiki-commits] [Gerrit] Fix regex to enable upload from ETHZ Library with the GWT - change (operations/mediawiki-config)

2016-02-28 Thread Kelson (Code Review)
Kelson has uploaded a new change for review. https://gerrit.wikimedia.org/r/273774 Change subject: Fix regex to enable upload from ETHZ Library with the GWT .. Fix regex to enable upload from ETHZ Library with the GWT

[MediaWiki-commits] [Gerrit] openzim[master]: Fix memory corruption in decodeUrl.

2016-08-09 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. Change subject: Fix memory corruption in decodeUrl. .. Fix memory corruption in decodeUrl. Reuse the function from kiwix as it does the same thing but with much better c++

[MediaWiki-commits] [Gerrit] openzim[master]: The indexed url must contain the namespace.

2016-08-11 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. Change subject: The indexed url must contain the namespace. .. The indexed url must contain the namespace. Change-Id: Icc17c7552a2b213a15edc2c674fe00aacb36952b --- M

[MediaWiki-commits] [Gerrit] openzim[master]: Remove temporary ft_index.

2016-08-12 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. Change subject: Remove temporary ft_index. .. Remove temporary ft_index. Xapian indexer create temporary files while indexing content. Remove those files at end. Change-Id:

[MediaWiki-commits] [Gerrit] openzim[master]: Fix memory leak in zimwriterfs.

2016-08-09 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. Change subject: Fix memory leak in zimwriterfs. .. Fix memory leak in zimwriterfs. We are using polymorphism in articlesource.cpp (a Article* pointer but derived class as

[MediaWiki-commits] [Gerrit] openzim[master]: Delete all articles, even the last one.

2016-08-09 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. Change subject: Delete all articles, even the last one. .. Delete all articles, even the last one. No so important, only one article *could* be impacted. (If it is the last

[MediaWiki-commits] [Gerrit] openzim[master]: Close the magic database.

2016-08-09 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. Change subject: Close the magic database. .. Close the magic database. Change-Id: Ib0c7d1736d804526eea701ef39cb9ae5780b13c1 --- M zimwriterfs/zimwriterfs.cpp 1 file changed,

[MediaWiki-commits] [Gerrit] openzim[master]: Better replaceStringInPlaceOnce.

2016-08-09 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. Change subject: Better replaceStringInPlaceOnce. .. Better replaceStringInPlaceOnce. If we do only one replace, we do not need a while and a update of pos. (Thank to

[MediaWiki-commits] [Gerrit] Revert "Use explicit LZMA_STREAM_INIT initializer, instead o... - change (openzim)

2016-07-01 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. Change subject: Revert "Use explicit LZMA_STREAM_INIT initializer, instead of memset." .. Revert "Use explicit LZMA_STREAM_INIT initializer, instead of memset." This reverts

[MediaWiki-commits] [Gerrit] Explain that ZIntStream only represents uint32_t values righ... - change (openzim)

2016-06-29 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. Change subject: Explain that ZIntStream only represents uint32_t values right now. .. Explain that ZIntStream only represents uint32_t values right now. Change-Id:

[MediaWiki-commits] [Gerrit] Add a indexer. - change (openzim)

2016-07-03 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. Change subject: Add a indexer. .. Add a indexer. This indexer is not used. This is mainly code from kiwix-indexer imported in openzim. Unused function in *Tools has been

[MediaWiki-commits] [Gerrit] Port zimwriterfs to the new API. - change (openzim)

2016-07-03 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. Change subject: Port zimwriterfs to the new API. .. Port zimwriterfs to the new API. No more ArticleSource::getData. Change-Id: I76cd6f3e7e4a390ed6a58cf9815dda2a2f1bfde5 ---

[MediaWiki-commits] [Gerrit] Handle the case of last article for filenameQueue is invalid. - change (openzim)

2016-07-03 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. Change subject: Handle the case of last article for filenameQueue is invalid. .. Handle the case of last article for filenameQueue is invalid. Change-Id:

[MediaWiki-commits] [Gerrit] Add xapian indexer. - change (openzim)

2016-07-03 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. Change subject: Add xapian indexer. .. Add xapian indexer. Xapian is optional. Build your index inside zim by adding "-i" or "--createFullTextIndex" to zimwriterfs' command

[MediaWiki-commits] [Gerrit] Revert compatibility with previous API. - change (openzim)

2016-07-03 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. Change subject: Revert compatibility with previous API. .. Revert compatibility with previous API. The API has changed. The behavior is different, so do not try to keep a

[MediaWiki-commits] [Gerrit] Add a API to get the offset of a article in the zimfile. - change (openzim)

2016-07-03 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. Change subject: Add a API to get the offset of a article in the zimfile. .. Add a API to get the offset of a article in the zimfile. To get the offset of a article : - get

[MediaWiki-commits] [Gerrit] Fix issue #2 Zimdump crashes on long titles. - change (openzim)

2016-07-03 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. Change subject: Fix issue #2 Zimdump crashes on long titles. .. Fix issue #2 Zimdump crashes on long titles. Most of filesystems have a filename limited to 255 bytes. If the

[MediaWiki-commits] [Gerrit] Bug fix: don't store pointers inside a dynamic vector. - change (openzim)

2016-06-29 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. Change subject: Bug fix: don't store pointers inside a dynamic vector. .. Bug fix: don't store pointers inside a dynamic vector. Use offsets instead, since the actual objects

[MediaWiki-commits] [Gerrit] Actually call the (previously-unused) ArticleSource#setFilen... - change (openzim)

2016-06-29 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. Change subject: Actually call the (previously-unused) ArticleSource#setFilename method. .. Actually call the (previously-unused) ArticleSource#setFilename method. Change-Id:

[MediaWiki-commits] [Gerrit] openzim[master]: libzim.pc: Add "Requires" field

2017-01-23 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/330857 ) Change subject: libzim.pc: Add "Requires" field .. libzim.pc: Add "Requires" field Follows-up b7e5564423b8644c. Change-Id:

[MediaWiki-commits] [Gerrit] openzim[master]: Make zimlib compilable with meson.

2017-01-23 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/328341 ) Change subject: Make zimlib compilable with meson. .. Make zimlib compilable with meson. Also install a correct pkg-config file who

[MediaWiki-commits] [Gerrit] openzim[master]: Fix use of ENABLE_* by preprocessor.

2017-01-23 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/330236 ) Change subject: Fix use of ENABLE_* by preprocessor. .. Fix use of ENABLE_* by preprocessor. If a compression lib is not present,

[MediaWiki-commits] [Gerrit] openzim[master]: Make zimlib compilable with meson.

2017-01-23 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/330417 ) Change subject: Make zimlib compilable with meson. .. Make zimlib compilable with meson. Also install a correct pkg-config file who

[MediaWiki-commits] [Gerrit] openzim[master]: Support running tests with "make check"

2017-01-18 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/330859 ) Change subject: Support running tests with "make check" .. Support running tests with "make check" Change-Id:

[MediaWiki-commits] [Gerrit] openzim[master]: Provide time gap between uuid generation during tests

2017-01-18 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/330861 ) Change subject: Provide time gap between uuid generation during tests .. Provide time gap between uuid generation during tests GNU

[MediaWiki-commits] [Gerrit] openzim[master]: Read the cluster content only when necessary.

2016-10-09 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. Change subject: Read the cluster content only when necessary. .. Read the cluster content only when necessary. Instead of reading the full cluster content at cluster

[MediaWiki-commits] [Gerrit] openzim[master]: Avoid get the dirent too many time.

2016-10-09 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. Change subject: Avoid get the dirent too many time. .. Avoid get the dirent too many time. Article::is* functions are "alias" to Article::getDirent().is* functions. As we

[MediaWiki-commits] [Gerrit] openzim[master]: Adapt tests to new internal cluster API.

2016-11-07 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. Change subject: Adapt tests to new internal cluster API. .. Adapt tests to new internal cluster API. - There is no more operator>>() on cluster. We should use

[MediaWiki-commits] [Gerrit] openzim[master]: [zimwriterfs] Try to avoid too big cluster.

2016-10-12 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. Change subject: [zimwriterfs] Try to avoid too big cluster. .. [zimwriterfs] Try to avoid too big cluster. We check that cluster will not be too big *before* adding the

[MediaWiki-commits] [Gerrit] openzim[master]: Do not cache uncompressed cluster by default.

2016-10-12 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. Change subject: Do not cache uncompressed cluster by default. .. Do not cache uncompressed cluster by default. Uncompressed cluster can be big (if they contain videos for

[MediaWiki-commits] [Gerrit] openzim[master]: Always try to cache a cluster, even if it is a uncompressed ...

2016-10-09 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. Change subject: Always try to cache a cluster, even if it is a uncompressed one. .. Always try to cache a cluster, even if it is a uncompressed one. Creating a cluster is

[MediaWiki-commits] [Gerrit] openzim[master]: Invalidate internal streambuf buffer when we change it.

2016-10-09 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. Change subject: Invalidate internal streambuf buffer when we change it. .. Invalidate internal streambuf buffer when we change it. It may be not necessary as it never fails

[MediaWiki-commits] [Gerrit] openzim[master]: Remove unused currentPos from fstream.

2016-10-09 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. Change subject: Remove unused currentPos from fstream. .. Remove unused currentPos from fstream. Change-Id: Idd7e392b35dbe36e5d4ee4a03f6119bb01ab4e2e --- M

[MediaWiki-commits] [Gerrit] openzim[master]: Add libzim.pc for pkg-config

2016-12-31 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/329759 ) Change subject: Add libzim.pc for pkg-config .. Add libzim.pc for pkg-config This registers the libzim library with pkg-config,

[MediaWiki-commits] [Gerrit] openzim[master]: pkg_config dependencies are properly declared.

2017-03-23 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/333593 ) Change subject: pkg_config dependencies are properly declared. .. pkg_config dependencies are properly declared. The 'Requires'

[MediaWiki-commits] [Gerrit] openzim[master]: Add the valuesmap metadata.

2017-03-23 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/343896 ) Change subject: Add the valuesmap metadata. .. Add the valuesmap metadata. This way, the searcher will know where values are

[MediaWiki-commits] [Gerrit] openzim[master]: Few clean and better verbose message.

2017-03-23 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/343898 ) Change subject: Few clean and better verbose message. .. Few clean and better verbose message. Change-Id:

[MediaWiki-commits] [Gerrit] openzim[master]: Do not store the snippet nor the size of the content in the ...

2017-03-23 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/343897 ) Change subject: Do not store the snippet nor the size of the content in the database. .. Do not store the snippet nor the size of

[MediaWiki-commits] [Gerrit] openzim[master]: Store the stop words used by the indexer in the database.

2017-03-27 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/344963 ) Change subject: Store the stop words used by the indexer in the database. .. Store the stop words used by the indexer in the

[MediaWiki-commits] [Gerrit] openzim[master]: Store the language used by the stemmer in the database.

2017-03-27 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/344962 ) Change subject: Store the language used by the stemmer in the database. .. Store the language used by the stemmer in the database.

[MediaWiki-commits] [Gerrit] openzim[master]: Actually call the (previously-unused) ArticleSource#setFilen...

2017-03-25 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/296632 ) Change subject: Actually call the (previously-unused) ArticleSource#setFilename method. .. Actually call the (previously-unused)

[MediaWiki-commits] [Gerrit] openzim[master]: Bug fix: don't store pointers inside a dynamic vector.

2017-03-25 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/296644 ) Change subject: Bug fix: don't store pointers inside a dynamic vector. .. Bug fix: don't store pointers inside a dynamic vector.

[MediaWiki-commits] [Gerrit] openzim[master]: Move article's related stuffs in article.(h|cpp).

2017-03-25 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/295516 ) Change subject: Move article's related stuffs in article.(h|cpp). .. Move article's related stuffs in article.(h|cpp). Change-Id:

[MediaWiki-commits] [Gerrit] openzim[master]: Port zimwriterfs to the new API.

2017-03-25 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/296911 ) Change subject: Port zimwriterfs to the new API. .. Port zimwriterfs to the new API. No more ArticleSource::getData. Change-Id:

[MediaWiki-commits] [Gerrit] openzim[master]: Move few utility functions to a separate module.

2017-03-25 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/295515 ) Change subject: Move few utility functions to a separate module. .. Move few utility functions to a separate module. Change-Id:

[MediaWiki-commits] [Gerrit] openzim[master]: Add xapian indexer.

2017-03-25 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/296913 ) Change subject: Add xapian indexer. .. Add xapian indexer. Xapian is optional. Build your index inside zim by adding "-i" or

[MediaWiki-commits] [Gerrit] openzim[master]: Revert "Use explicit LZMA_STREAM_INIT initializer, instead o...

2017-03-25 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/296752 ) Change subject: Revert "Use explicit LZMA_STREAM_INIT initializer, instead of memset." .. Revert "Use explicit LZMA_STREAM_INIT

[MediaWiki-commits] [Gerrit] openzim[master]: Revert compatibility with previous API.

2017-03-25 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/296910 ) Change subject: Revert compatibility with previous API. .. Revert compatibility with previous API. The API has changed. The

[MediaWiki-commits] [Gerrit] openzim[master]: Compress blobs and track file size immediately after adding ...

2017-03-25 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/295383 ) Change subject: Compress blobs and track file size immediately after adding each article. .. Compress blobs and track file size

[MediaWiki-commits] [Gerrit] openzim[master]: Bug fix: preserve cluster compression type after clear().

2017-03-25 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/296547 ) Change subject: Bug fix: preserve cluster compression type after clear(). .. Bug fix: preserve cluster compression type after

[MediaWiki-commits] [Gerrit] openzim[master]: Update .gitignore files.

2017-03-25 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/295037 ) Change subject: Update .gitignore files. .. Update .gitignore files. Change-Id: Iad8d95fa2deab178396e8804b6e195a5b1520a4a --- C

[MediaWiki-commits] [Gerrit] openzim[master]: Update zimwriterfs makefiles.

2017-03-25 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/295038 ) Change subject: Update zimwriterfs makefiles. .. Update zimwriterfs makefiles. Change-Id: Ic0f93e19eb3e07d86c115bd15f47ef5fbc74f954

[MediaWiki-commits] [Gerrit] openzim[master]: Explain that ZIntStream only represents uint32_t values righ...

2017-03-25 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/296657 ) Change subject: Explain that ZIntStream only represents uint32_t values right now. .. Explain that ZIntStream only represents

[MediaWiki-commits] [Gerrit] openzim[master]: Use a Queue object to handle threadsafe access to a queue.

2017-03-25 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/295518 ) Change subject: Use a Queue object to handle threadsafe access to a queue. .. Use a Queue object to handle threadsafe access to a

[MediaWiki-commits] [Gerrit] openzim[master]: Move `throw` statement out of header file.

2017-03-25 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/295720 ) Change subject: Move `throw` statement out of header file. .. Move `throw` statement out of header file. This ensures that we don't

[MediaWiki-commits] [Gerrit] openzim[master]: Support running tests with "make check"

2017-03-25 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/330859 ) Change subject: Support running tests with "make check" .. Support running tests with "make check" Change-Id:

[MediaWiki-commits] [Gerrit] openzim[master]: Add a indexer.

2017-03-25 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/296912 ) Change subject: Add a indexer. .. Add a indexer. This indexer is not used. This is mainly code from kiwix-indexer imported in

[MediaWiki-commits] [Gerrit] openzim[master]: Bug fix: correctly update cluster offsets in directory entries.

2017-03-25 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/296158 ) Change subject: Bug fix: correctly update cluster offsets in directory entries. .. Bug fix: correctly update cluster offsets in

[MediaWiki-commits] [Gerrit] openzim[master]: Fix memory corruption in decodeUrl.

2017-03-25 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/303540 ) Change subject: Fix memory corruption in decodeUrl. .. Fix memory corruption in decodeUrl. Reuse the function from kiwix as it does

[MediaWiki-commits] [Gerrit] openzim[master]: Include files from srcdir; built files in builddir.

2017-03-25 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/295111 ) Change subject: Include files from srcdir; built files in builddir. .. Include files from srcdir; built files in builddir.

[MediaWiki-commits] [Gerrit] openzim[master]: Convert READMEs to markdown.

2017-03-25 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/295035 ) Change subject: Convert READMEs to markdown. .. Convert READMEs to markdown. Change-Id: I596bec7ef70bd0a7d45ba67d4fa313d93c861890

[MediaWiki-commits] [Gerrit] openzim[master]: Readd call to stripTitleInvalidChars.

2017-03-25 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/295633 ) Change subject: Readd call to stripTitleInvalidChars. .. Readd call to stripTitleInvalidChars. Commit 1c969dd remove the call to

[MediaWiki-commits] [Gerrit] openzim[master]: Move articleSource's related stuffs in articlesource.(h|cpp).

2017-03-25 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/295517 ) Change subject: Move articleSource's related stuffs in articlesource.(h|cpp). .. Move articleSource's related stuffs in

[MediaWiki-commits] [Gerrit] openzim[master]: Use the system's libgumbo.

2017-03-25 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/295039 ) Change subject: Use the system's libgumbo. .. Use the system's libgumbo. Change-Id: Id6b06033bba6c1d47d305b50259e7eaf41c073e2 --- M

[MediaWiki-commits] [Gerrit] openzim[master]: Use explicit LZMA_STREAM_INIT initializer, instead of memset.

2017-03-25 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/296548 ) Change subject: Use explicit LZMA_STREAM_INIT initializer, instead of memset. .. Use explicit LZMA_STREAM_INIT initializer, instead

[MediaWiki-commits] [Gerrit] openzim[master]: Move zim::writer::ArticleSource::getData() to zim::writer::A...

2017-03-25 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/295460 ) Change subject: Move zim::writer::ArticleSource::getData() to zim::writer::Article::getData(). .. Move

[MediaWiki-commits] [Gerrit] openzim[master]: Update build instructions for MacOS X.

2017-03-25 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/295382 ) Change subject: Update build instructions for MacOS X. .. Update build instructions for MacOS X. Change-Id:

[MediaWiki-commits] [Gerrit] openzim[master]: Fixed compilation on OSX. made a script to compile both stat...

2017-03-25 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/216507 ) Change subject: Fixed compilation on OSX. made a script to compile both static and shared .. Fixed compilation on OSX. made a

[MediaWiki-commits] [Gerrit] openzim[master]: Invalidate internal streambuf buffer when we change it.

2017-03-25 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/314720 ) Change subject: Invalidate internal streambuf buffer when we change it. .. Invalidate internal streambuf buffer when we change it.

[MediaWiki-commits] [Gerrit] openzim[master]: Delete all articles, even the last one.

2017-03-25 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/303776 ) Change subject: Delete all articles, even the last one. .. Delete all articles, even the last one. No so important, only one

[MediaWiki-commits] [Gerrit] openzim[master]: Add a API to get the offset of a article in the zimfile.

2017-03-25 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/296914 ) Change subject: Add a API to get the offset of a article in the zimfile. .. Add a API to get the offset of a article in the zimfile.

[MediaWiki-commits] [Gerrit] openzim[master]: Fix issue #2 Zimdump crashes on long titles.

2017-03-25 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/296931 ) Change subject: Fix issue #2 Zimdump crashes on long titles. .. Fix issue #2 Zimdump crashes on long titles. Most of filesystems

[MediaWiki-commits] [Gerrit] openzim[master]: Handle the case of last article for filenameQueue is invalid.

2017-03-25 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/296915 ) Change subject: Handle the case of last article for filenameQueue is invalid. .. Handle the case of last article for filenameQueue

[MediaWiki-commits] [Gerrit] openzim[master]: libzim.pc: Add "Requires" field

2017-03-25 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/330857 ) Change subject: libzim.pc: Add "Requires" field .. libzim.pc: Add "Requires" field Follows-up b7e5564423b8644c. Change-Id:

[MediaWiki-commits] [Gerrit] openzim[master]: Bug Fix for bug no 52324 on openzim. Sorts the MIME Types be...

2017-03-25 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/79021 ) Change subject: Bug Fix for bug no 52324 on openzim. Sorts the MIME Types before storing them to file. .. Bug Fix for bug no 52324

[MediaWiki-commits] [Gerrit] openzim[master]: Add .gitignore and .gitreview

2017-03-25 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/84432 ) Change subject: Add .gitignore and .gitreview .. Add .gitignore and .gitreview Bug: 54175 Change-Id:

[MediaWiki-commits] [Gerrit] openzim[refs/meta/config]: Modify access rules

2017-03-25 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/344685 ) Change subject: Modify access rules .. Modify access rules Change-Id: I8ff42c3054bc6b67f0dba0e3ee96d101bde215d9 --- M

[MediaWiki-commits] [Gerrit] openzim[refs/meta/config]: Modify access rules

2017-03-25 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/344794 ) Change subject: Modify access rules .. Modify access rules Change-Id: Ifb79d6cb21c10144d5cce325136a3f68257b2ec9 --- M

[MediaWiki-commits] [Gerrit] openzim[master]: Few clean and better verbose message.

2017-03-25 Thread Kelson (Code Review)
Kelson has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/343898 ) Change subject: Few clean and better verbose message. .. Few clean and better verbose message. Change-Id:

  1   2   >