D618: largefiles: remove unused assignments from wrapfunction()

lothiraldan added a comment. In https://phab.mercurial-scm.org/D618#10161, @mharbison72 wrote: > Is it acceptable to move the exthelper stuff in evolve into the core somewhere? The fact that there are so many functions and commands wrapped in largefiles makes it harder to read the

D542: effectflag: document effect flag

lothiraldan added a comment. @quark Thank you for reposting your comment here, it's helpful to not lose track on all these discussions. We've had this experiment in Evolve for a little while now and the users using it are giving positive feedback. The next step is to upstream it in

D691: cmdutil: fix amend when passing a date

This revision was automatically updated to reflect the committed changes. Closed by commit rHGae95853c250a: cmdutil: fix amend when passing a date (authored by lothiraldan, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D691?vs=1763=1765

D691: cmdutil: fix amend when passing a date

lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Following https://phab.mercurial-scm.org/D636, passing the same date that the changeset to amend would results in no new commits but the output changed

D567: patch: take messages out of the function so that extensions can add entries

lothiraldan accepted this revision. lothiraldan added a comment. LGTM REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D567 To: pulkit, #hg-reviewers, lothiraldan Cc: lothiraldan, mercurial-devel ___ Mercurial-devel

D530: obsolete: move merge logic on the smaller object

This revision was automatically updated to reflect the committed changes. Closed by commit rHGc0bbaefc2c5a: obsolete: move merge logic on the smaller object (authored by lothiraldan). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D530?vs=1334=1353

D531: obsolete: fix old typo

This revision was automatically updated to reflect the committed changes. Closed by commit rHG54c21114e41d: obsolete: fix old typo (authored by lothiraldan). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D531?vs=1335=1354#toc REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D541: effectflag: detect when diff changed

lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Store in effect flag when the diff changed between the predecessor and its successors. Comparing the diff is not easy because we do not want to

D542: effectflag: document effect flag

lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D542 AFFECTED FILES mercurial/obsutil.py CHANGE DETAILS diff --git a/mercurial/obsutil.py

D539: effectflag: detect when parents changed

lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Store in effect flag when the parents changed between the predecessor and its successors. It can happens with "hg rebase" or "hg grab". REPOSITORY rHG

D540: effectflag: detect when meta changed

lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Store in effect flag when the meta changed between the predecessor and its successors. We blacklisted some known meta that would always changed when another

D537: effectflag: detect when date changed

lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Store in effect flag when the date changed between the predecessor and its successors. It can happens with "hg commit --amend -d", "hg amend -d" or

D536: effectflag: detect when user changed

lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Store in effect flag when the user changed between the predecessor and its successors. It can happens with "hg commit --amend -u" or "histedit".

D538: effectflag: detect when branch changed

lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Store in effect flag when the branch changed between the predecessor and its successors. It can happens with "hg branch" + "hg commit --amend", "hg

D535: effectflag: detect when description changed

lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Store in effect flag when the description changed between the predecessor and its successors. It can happens with "hg commit --amend -e", "hg amend -e"

D533: effectflag: store an empty effect flag for the moment

lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The idea behind effect flag is to store additional information in obs-markers about what changed between a changeset and its successor(s). It's a low-level

D534: tests: add tests for effect flags

lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Add all the tests in this patch, it makes the patch quite big but will clarify the following patches impact on tests. REPOSITORY rHG Mercurial REVISION

D532: obsolete: clean createmarkers part about operation

lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I will add another experiment in createmarkers, add a comment and some blank lines for aesthetic sake. REPOSITORY rHG Mercurial REVISION DETAIL

D531: obsolete: fix old typo

lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Clean an old typo in successorssets. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D531 AFFECTED FILES mercurial/obsutil.py

D530: obsolete: move merge logic on the smaller object

lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Refactor some logic in _succs in order to clean successorssets code. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D530

D472: extensions: make wrapfunction() return a context manager

lothiraldan added a comment. Maybe instead of replacing wrapfunction with a context manager, what about introducing it with a separate name? All users of wrapfunction will need to be updated anyway to use the context manager style REPOSITORY rHG Mercurial REVISION DETAIL

D482: bundle2: fixed usage of an attribute that was removed in py3k

lothiraldan added a comment. Good for me. I have the impression that we tend to defined static data (like `pycompat.bytestr(string.ascii_letters)` or some translations) inside functions while they could be defined once at module level. Is it intentional, is it for reducing startup

D482: bundle2: fixed usage of an attribute that was removed in py3k

lothiraldan added a comment. Would it be possible to define `pycompat.bytestr(string.ascii_letters)` at the module level once and for all? REPOSITORY rHG Mercurial BRANCH py3k-stuff (bookmark) on default (branch) REVISION DETAIL https://phab.mercurial-scm.org/D482 To: alex.gaynor,

D426: obsutil: correct deprecation warning message

lothiraldan added a comment. Thx @ryanmce, the fix (https://phab.mercurial-scm.org/D413) should already been pushed to hg-commited, could you try pulling and see if you have it? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D426 To: ryanmce, #hg-reviewers Cc:

D414: obsmarker: precnode was renamed into prednode

This revision was automatically updated to reflect the committed changes. Closed by commit rHGeae63a9e59da: obsmarker: precnode was renamed into prednode (authored by lothiraldan). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D414?vs=986=1007 REVISION

D413: obsmarker: fix precnode deprecation

This revision was automatically updated to reflect the committed changes. Closed by commit rHG833f70277f0e: obsmarker: fix precnode deprecation (authored by lothiraldan). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D413?vs=983=1008 REVISION DETAIL

D416: revset: mark evolution-related revsets as experimental

This revision was automatically updated to reflect the committed changes. Closed by commit rHG457d1ebf151b: revset: mark evolution-related revsets as experimental (authored by lothiraldan). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D416?vs=987=1006

D252: revset: rename bumped into phasedivergent

lothiraldan marked 3 inline comments as done. lothiraldan added inline comments. INLINE COMMENTS > lothiraldan wrote in revset.py:472 > My bad, these revset are Evolution-related and not phases-related, I will > send a follow-up marking them as experimental. Done:

D416: revset: mark evolution-related revsets as experimental

lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D416 AFFECTED FILES mercurial/revset.py CHANGE DETAILS diff --git a/mercurial/revset.py

D414: obsmarker: precnode was renamed into prednode

lothiraldan updated this revision to Diff 986. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D414?vs=984=986 REVISION DETAIL https://phab.mercurial-scm.org/D414 AFFECTED FILES mercurial/cmdutil.py tests/test-obsolete.t CHANGE DETAILS diff --git

D252: revset: rename bumped into phasedivergent

lothiraldan added inline comments. INLINE COMMENTS > lothiraldan wrote in revset.py:472 > I'm not sure to see why, are phases out of the experimental status? My bad, these revset are Evolution-related and not phases-related, I will send a follow-up marking them as experimental. REPOSITORY

D252: revset: rename bumped into phasedivergent

lothiraldan added inline comments. INLINE COMMENTS > yuja wrote in revset.py:472 > Maybe these revset functions should be marked as `(EXPERIMENTAL)`? I'm not sure to see why, are phases out of the experimental status? REPOSITORY rHG Mercurial REVISION DETAIL

D399: filemerge: eliminate most uses of tempfiles

lothiraldan added a comment. Small typo in the commit message: s/remobe/remove REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D399 To: phillco, #hg-reviewers Cc: lothiraldan, mercurial-devel ___ Mercurial-devel mailing

D243: obsmarker: rename precnode into prednode

lothiraldan marked 3 inline comments as done. lothiraldan added inline comments. INLINE COMMENTS > yuja wrote in cmdutil.py:1916 > `fm.write('prednode', ...)` I've send a follow-up: https://phab.mercurial-scm.org/D414 REPOSITORY rHG Mercurial REVISION DETAIL

D414: obsmarker: precnode was renamed into prednode

lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Update all calls to formatter.write first arguments to remove references to precnode and use prednode consistently everywhere. REPOSITORY rHG Mercurial

D413: obsmarker: fix precnode deprecation

lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The deprecation message for marker.precnode was wrong. Fix the typo. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D413

D384: context: fix troubled deprecation

This revision was automatically updated to reflect the committed changes. Closed by commit rHG4abf34f47526: context: fix troubled deprecation (authored by lothiraldan). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D384?vs=865=920 REVISION DETAIL

D384: context: fix troubled deprecation

lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY troubled has been renamed into isunstable but troubled was calling unstable instead. Fix the mistake. REPOSITORY rHG Mercurial REVISION DETAIL

D369: util: add `hgdatetopython` to convert hg-style dates to datetimes

lothiraldan added a comment. Small nit-picking style comments on the doc-string. Also the message description must match contribution guidelines: https://www.mercurial-scm.org/wiki/ContributingChanges#Submission_checklist. This should be catched by the test `test-check-commit.t`. I

D243: obsmarker: rename precnode into prednode

lothiraldan added inline comments. INLINE COMMENTS > yuja wrote in cmdutil.py:1916 > The template keyword should be updated as well. Please send a follow-up. I'm not sure to see which template keyword you are talking about. REPOSITORY rHG Mercurial REVISION DETAIL

D359: pushvars: add a coreconfigitem for push.pushvars.server

lothiraldan accepted this revision. lothiraldan added a comment. LGTM REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D359 To: pulkit, #hg-reviewers, lothiraldan Cc: lothiraldan, mercurial-devel ___ Mercurial-devel

D259: label: rename log.trouble into log.instability

This revision was automatically updated to reflect the committed changes. Closed by commit rHGdb6b666ce1e6: label: rename log.trouble into log.instability (authored by lothiraldan). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D259?vs=604=813 REVISION

D257: label: rename changeset.troubled into changeset.unstable

This revision was automatically updated to reflect the committed changes. Closed by commit rHG3821dfee2cfc: label: rename changeset.troubled into changeset.unstable (authored by lothiraldan). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D257?vs=602=811

D258: label: rename trouble.X into instability.X

This revision was automatically updated to reflect the committed changes. Closed by commit rHG40739aef97f7: label: rename trouble.X into instability.X (authored by lothiraldan). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D258?vs=603=812 REVISION

D249: test: update evolution config

This revision was automatically updated to reflect the committed changes. Closed by commit rHG6c1a9fd8361b: test: update evolution config (authored by lothiraldan). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D249?vs=594=803 REVISION DETAIL

D256: test: add a test for stabilization related labels

This revision was automatically updated to reflect the committed changes. Closed by commit rHG2415ad743642: test: add a test for stabilization related labels (authored by lothiraldan). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D256?vs=601=810

D253: obsolete: rename unstable volatile set into orphan volatile set

This revision was automatically updated to reflect the committed changes. Closed by commit rHGd4b7496f7d0b: obsolete: rename unstable volatile set into orphan volatile set (authored by lothiraldan). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D255: obsolete: rename bumped volatile set into phasedivergent volatile set

This revision was automatically updated to reflect the committed changes. Closed by commit rHG9fa874fb34e1: obsolete: rename bumped volatile set into phasedivergent volatile set (authored by lothiraldan). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D254: obsolete: rename divergent volatile set into contentdivergent volatile set

This revision was automatically updated to reflect the committed changes. Closed by commit rHGf3f06c260e9e: obsolete: rename divergent volatile set into contentdivergent volatile set (authored by lothiraldan). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D252: revset: rename bumped into phasedivergent

This revision was automatically updated to reflect the committed changes. Closed by commit rHGed99d3afef88: revset: rename bumped into phasedivergent (authored by lothiraldan). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D252?vs=597=806 REVISION DETAIL

D248: config: rename evolution config into stabilization

This revision was automatically updated to reflect the committed changes. Closed by commit rHGd434a7f0685c: config: rename evolution config into stabilization (authored by lothiraldan). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D248?vs=593=802

D251: revset: remane divergent into contentdivergent

This revision was automatically updated to reflect the committed changes. Closed by commit rHGf078d7358e90: revset: remane divergent into contentdivergent (authored by lothiraldan). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D251?vs=596=805 REVISION

D250: revset: rename unstable into orphan

This revision was automatically updated to reflect the committed changes. Closed by commit rHG9dcc3529e002: revset: rename unstable into orphan (authored by lothiraldan). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D250?vs=595=804 REVISION DETAIL

D303: bundle2: fix transaction availability detection

This revision was automatically updated to reflect the committed changes. Closed by commit rHG119e1c6be1ce: bundle2: fix transaction availability detection (authored by lothiraldan). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D303?vs=687=797 REVISION

D331: sshpeer: make instance attributes and methods internal

lothiraldan added a comment. Silly question, what is the deprecation policy for such internal classes? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D331 To: indygreg, #hg-reviewers Cc: lothiraldan, mercurial-devel

D322: fsmonitor: correct an error message

lothiraldan accepted this revision. lothiraldan added a comment. LGTM, we don't have a test for it? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D322 To: quark, #hg-reviewers, lothiraldan Cc: lothiraldan, mercurial-devel

D246: obsolete: rename precursor into predecessor in obsolete docstrings

lothiraldan updated this revision to Diff 708. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D246?vs=702=708 REVISION DETAIL https://phab.mercurial-scm.org/D246 AFFECTED FILES mercurial/obsolete.py CHANGE DETAILS diff --git a/mercurial/obsolete.py

D247: obsutil: rename allprecursors into allpredecessors

lothiraldan updated this revision to Diff 709. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D247?vs=703=709 REVISION DETAIL https://phab.mercurial-scm.org/D247 AFFECTED FILES contrib/phabricator.py mercurial/obsolete.py mercurial/obsutil.py

D242: context: rename troubled into isunstable

lothiraldan updated this revision to Diff 704. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D242?vs=700=704 REVISION DETAIL https://phab.mercurial-scm.org/D242 AFFECTED FILES mercurial/cmdutil.py mercurial/commands.py mercurial/context.py

D243: obsmarker: rename precnode into prednode

lothiraldan updated this revision to Diff 705. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D243?vs=699=705 REVISION DETAIL https://phab.mercurial-scm.org/D243 AFFECTED FILES mercurial/cmdutil.py mercurial/obsutil.py CHANGE DETAILS diff --git

D245: obsstore: rename precursors into predecessors

lothiraldan updated this revision to Diff 707. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D245?vs=701=707 REVISION DETAIL https://phab.mercurial-scm.org/D245 AFFECTED FILES mercurial/obsolete.py mercurial/obsutil.py CHANGE DETAILS diff --git

D244: obsolete: rename _addprecursors into _addpredecessors

lothiraldan updated this revision to Diff 706. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D244?vs=698=706 REVISION DETAIL https://phab.mercurial-scm.org/D244 AFFECTED FILES mercurial/obsolete.py CHANGE DETAILS diff --git a/mercurial/obsolete.py

D238: context: rename troubles into instabilities

This revision was automatically updated to reflect the committed changes. Closed by commit rHGab0c55c2ad9a: context: rename troubles into instabilities (authored by lothiraldan). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D238?vs=664=694 REVISION

D242: context: rename troubled into isunstable

This revision was automatically updated to reflect the committed changes. Closed by commit rHG52c5ff856b49: context: rename troubled into isunstable (authored by lothiraldan). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D242?vs=665=700 REVISION DETAIL

D243: obsmarker: rename precnode into prednode

This revision was automatically updated to reflect the committed changes. Closed by commit rHG2cb442bc1a76: obsmarker: rename precnode into prednode (authored by lothiraldan). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D243?vs=588=699 REVISION DETAIL

D247: obsutil: rename allprecursors into allpredecessors

This revision was automatically updated to reflect the committed changes. Closed by commit rHGe6d8ee3c9ec3: obsutil: rename allprecursors into allpredecessors (authored by lothiraldan). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D247?vs=592=703

D246: obsolete: rename precursor into predecessor in obsolete docstrings

This revision was automatically updated to reflect the committed changes. Closed by commit rHG0c3112f17610: obsolete: rename precursor into predecessor in obsolete docstrings (authored by lothiraldan). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D241: context: rename bumped into phasedivergent

This revision was automatically updated to reflect the committed changes. Closed by commit rHG8413cbeae275: context: rename bumped into phasedivergent (authored by lothiraldan). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D241?vs=622=697 REVISION

D244: obsolete: rename _addprecursors into _addpredecessors

This revision was automatically updated to reflect the committed changes. Closed by commit rHG32d4f815c4f4: obsolete: rename _addprecursors into _addpredecessors (authored by lothiraldan). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D244?vs=589=698

D239: context: rename unstable into orphan

This revision was automatically updated to reflect the committed changes. lothiraldan marked an inline comment as done. Closed by commit rHGf163edb45c47: context: rename unstable into orphan (authored by lothiraldan). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D240: context: rename divergent into contentdivergent

This revision was automatically updated to reflect the committed changes. Closed by commit rHG8b2d7684407b: context: rename divergent into contentdivergent (authored by lothiraldan). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D240?vs=621=696 REVISION

D303: bundle2: fix transaction availability detection

lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Changeset https://phab.mercurial-scm.org/rHG5fc4ddfbe62601613ad68bcfa194c209ccf2fd30 introduce more complex logic around 'bundleoperation.gettransaction'.

D288: bundlerepo: move temp bundle creation to a separate function

lothiraldan added a comment. LGTM REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D288 To: durham, #hg-reviewers Cc: lothiraldan, mercurial-devel ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org

D292: repair: move manifest strip to a separate function

lothiraldan added a comment. LGTM REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D292 To: durham, #hg-reviewers Cc: lothiraldan, mercurial-devel ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org

D291: repair: refactor broken linkrev collection

lothiraldan added a comment. LGTM REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D291 To: durham, #hg-reviewers Cc: lothiraldan, mercurial-devel ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org

D242: context: rename troubled into isunstable

lothiraldan updated this revision to Diff 665. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D242?vs=626=665 REVISION DETAIL https://phab.mercurial-scm.org/D242 AFFECTED FILES mercurial/cmdutil.py mercurial/commands.py mercurial/context.py

D237: template: rename troubles templatekw into instabilities

lothiraldan updated this revision to Diff 663. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D237?vs=653=663 REVISION DETAIL https://phab.mercurial-scm.org/D237 AFFECTED FILES mercurial/templatekw.py mercurial/templates/map-cmdline.default

D237: template: rename troubles templatekw into instabilities

This revision was automatically updated to reflect the committed changes. Closed by commit rHG511d6ae462f3: template: rename troubles templatekw into instabilities (authored by lothiraldan). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D237?vs=582=653

D245: obsstore: rename precursors into predecessors

lothiraldan added inline comments. INLINE COMMENTS > dsp wrote in obsutil.py:210 > should this be called `predecessormarkers`? Ideally yes. I wanted to limit this series to external impacting changes only (either output or API changes) so extensions and tests could be updated once and for

D242: context: rename troubled into isunstable

lothiraldan updated this revision to Diff 626. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D242?vs=587=626 REVISION DETAIL https://phab.mercurial-scm.org/D242 AFFECTED FILES mercurial/cmdutil.py mercurial/commands.py mercurial/context.py

D238: context: rename troubles into instabilities

lothiraldan added inline comments. INLINE COMMENTS > indygreg wrote in context.py:246-248 > This feels like it should be a set not a list. > > Should this be changed as part of changing the API? Semantically I agree, but the list has the nice property of being sorted. If we change it to a

D239: context: rename unstable into orphan

lothiraldan marked an inline comment as done. lothiraldan added inline comments. INLINE COMMENTS > indygreg wrote in context.py:208 > Typo. Can be fixed in flight if you don't submit a new series. I have made the fix as I sent another series REPOSITORY rHG Mercurial REVISION DETAIL

D239: context: rename unstable into orphan

lothiraldan updated this revision to Diff 623. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D239?vs=584=623 REVISION DETAIL https://phab.mercurial-scm.org/D239 AFFECTED FILES mercurial/context.py CHANGE DETAILS diff --git a/mercurial/context.py

D240: context: rename divergent into contentdivergent

lothiraldan added inline comments. INLINE COMMENTS > lothiraldan wrote in context.py:227 > Damn it you are right, good catch! Sorry for the tone of my comment, I was only angry against myself, I thought I have fixed this code too many times due to merge conflicts. REPOSITORY rHG Mercurial

D240: context: rename divergent into contentdivergent

lothiraldan updated this revision to Diff 621. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D240?vs=585=621 REVISION DETAIL https://phab.mercurial-scm.org/D240 AFFECTED FILES mercurial/context.py CHANGE DETAILS diff --git a/mercurial/context.py

D241: context: rename bumped into phasedivergent

lothiraldan updated this revision to Diff 622. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D241?vs=586=622 REVISION DETAIL https://phab.mercurial-scm.org/D241 AFFECTED FILES mercurial/context.py CHANGE DETAILS diff --git a/mercurial/context.py

D240: context: rename divergent into contentdivergent

lothiraldan added inline comments. INLINE COMMENTS > indygreg wrote in context.py:227 > This should be `self.contentdivergent()` no? Damn it you are right, good catch! REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D240 To: lothiraldan, #hg-reviewers, indygreg

D241: context: rename bumped into phasedivergent

lothiraldan added inline comments. INLINE COMMENTS > indygreg wrote in context.py:220 > Shouldn't this be `self.phasedivergent()`? Yes definitely, thanks for the catch REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D241 To: lothiraldan, #hg-reviewers, indygreg

D262: test-rebase: add a brute force test

lothiraldan added a comment. Thanks for the patch, more testing is always good. I'm wondering if we could use hypothesis (https://github.com/HypothesisWorks/hypothesis-python) for more tests like that. One article I found interesting was:

D259: label: rename log.trouble into log.instability

lothiraldan added a reviewer: quark. lothiraldan added a subscriber: quark. lothiraldan added a comment. Here are hopefully the last patches of this series. @quark I tried running the hg-experimental (https://bitbucket.org/facebook/hg-experimental) tests against this series. I think

D259: label: rename log.trouble into log.instability

lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The renaming is done according to https://www.mercurial-scm.org/wiki/CEDVocabulary. REPOSITORY rHG Mercurial REVISION DETAIL

D251: revset: remane divergent into contentdivergent

lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Don't touch divergent volatile set name, only the revset name. The volatile set name will be updated in a later patch. The renaming is done according to

D254: obsolete: rename divergent volatile set into contentdivergent volatile set

lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The renaming is done according to https://www.mercurial-scm.org/wiki/CEDVocabulary. REPOSITORY rHG Mercurial REVISION DETAIL

D252: revset: rename bumped into phasedivergent

lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Don't touch bumped volatile set name, only the revset name. The volatile set name will be updated in a later patch. The renaming is done according to

D253: obsolete: rename unstable volatile set into orphan volatile set

lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The renaming is done according to https://www.mercurial-scm.org/wiki/CEDVocabulary. REPOSITORY rHG Mercurial REVISION DETAIL

D258: label: rename trouble.X into instability.X

lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The renaming is done according to https://www.mercurial-scm.org/wiki/CEDVocabulary. REPOSITORY rHG Mercurial REVISION DETAIL

D255: obsolete: rename bumped volatile set into phasedivergent volatile set

lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The renaming is done according to https://www.mercurial-scm.org/wiki/CEDVocabulary. REPOSITORY rHG Mercurial REVISION DETAIL

D256: test: add a test for stabilization related labels

lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D256 AFFECTED FILES tests/test-obsolete.t CHANGE DETAILS diff --git a/tests/test-obsolete.t

D257: label: rename changeset.troubled into changeset.unstable

lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The renaming is done according to https://www.mercurial-scm.org/wiki/CEDVocabulary. REPOSITORY rHG Mercurial REVISION DETAIL

D249: test: update evolution config

lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY evolution* config has been rewritten in stabilization* in the previous patch, update tests file to use the new names. REPOSITORY rHG Mercurial REVISION

<    2   3   4   5   6   7   8   >