D6709: config: add --registered flag to show all known configs

This revision now requires changes to proceed. baymax added a comment. baymax requested changes to this revision. There seems to have been no activities on this Diff for the past 3 Months. By policy, we are automatically moving it out of the `need-review` state. Please, move it back

D6709: config: add --registered flag to show all known configs

navaneeth.suresh added a comment. Now I understand that this patch does an enormous number of changes. I've split this patch into three. Will be working on each of them separately from now on. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6709/new/

D6709: config: add --registered flag to show all known configs

navaneeth.suresh edited the summary of this revision. navaneeth.suresh updated this revision to Diff 16800. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6709?vs=16306=16800 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6709/new/ REVISION

D6709: config: add --registered flag to show all known configs

pulkit added a comment. In D6709#100698 , @av6 wrote: > And to make the review process easier, I propose doing this in 3 or 4 patches: > > - adding `--registered`: will simply show all registered options in key=value format > - adding

D6709: config: add --registered flag to show all known configs

marmoute added a comment. In D6709#100698 , @av6 wrote: > In D6709#100618 , @marmoute wrote: > >> In D6709#99199 , @av6 wrote: >> >>> I'm strongly

D6709: config: add --registered flag to show all known configs

av6 added a comment. In D6709#100618 , @marmoute wrote: > In D6709#99199 , @av6 wrote: > >> I'm strongly -1 on adding qualifiers straight to the keys. The primary usage scenario here is scripts

D6709: config: add --registered flag to show all known configs

mharbison72 added a comment. In D6709#100618 , @marmoute wrote: > In D6709#99199 , @av6 wrote: > >> I'm strongly -1 on adding qualifiers straight to the keys. The primary usage scenario here is

D6709: config: add --registered flag to show all known configs

This revision now requires changes to proceed. marmoute added a comment. marmoute requested changes to this revision. Sorry for the late review. I though this diff was taken while I was in vacation/unstacking-post-vacation. I just recently reappeared on my rader. I made multiple comments

D6709: config: add --registered flag to show all known configs

av6 added a comment. I'll be okay with this too, once we get rid of `(EXPERIMENTAL)` everywhere. INLINE COMMENTS > test-config.t:962 > + > + $ hg showconfig --registered -T '{name}={value}\n' | egrep '^(color|diff)' > + color.mode=auto Let's change this to `hg showconfig cmdserver

D6709: config: add --registered flag to show all known configs

durin42 added a comment. durin42 accepted this revision. I'm okay with this as-is. Barring an objection in a week or so I'll queue it. (It's also possible I've missed something important when I read through the extensive review history here. Apologies if true, but please restate your

D6709: config: add --registered flag to show all known configs

navaneeth.suresh added a comment. @av6 I have updated the tests. @marmoute can we just get rid of `(EXPERIMENTAL)` in the output? If we want to do that, changes have to be made in `ui.walkregisteredconfig()`. But, that's a hack which appends to either name or value and as @av6 mentioned,

D6709: config: add --registered flag to show all known configs

navaneeth.suresh updated this revision to Diff 16306. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6709?vs=16290=16306 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6709/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6709

D6709: config: add --registered flag to show all known configs

This revision now requires changes to proceed. av6 added a comment. av6 requested changes to this revision. I'm strongly -1 on adding qualifiers straight to the keys. The primary usage scenario here is scripts (as explained in issue6014) -- regular users lived without this feature for years

D6709: config: add --registered flag to show all known configs

navaneeth.suresh added a comment. In D6709#99166 , @av6 wrote: > @marmoute did you want this flag marked as experimental or am I misremembering? @av6 @marmoute told me to add `EXPERIMENTAL` in the output of the config options which are

D6709: config: add --registered flag to show all known configs

av6 added a comment. av6 accepted this revision. @marmoute did you want this flag marked as experimental or am I misremembering? REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6709/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6709 To:

D6709: config: add --registered flag to show all known configs

navaneeth.suresh updated this revision to Diff 16290. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6709?vs=16286=16290 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6709/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6709

D6709: config: add --registered flag to show all known configs

av6 added inline comments. INLINE COMMENTS > commands.py:1893 > else: > -fm.write('name value', '%s=%s\n', entryname, value) > -fm.data(defaultvalue=defaultvalue) > +value_ = value > +for tfopt in [('True', 'yes'), ('False', 'no'), ('true',

D6709: config: add --registered flag to show all known configs

navaneeth.suresh updated this revision to Diff 16286. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6709?vs=16248=16286 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6709/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6709

D6709: config: add --registered flag to show all known configs

navaneeth.suresh updated this revision to Diff 16248. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6709?vs=16247=16248 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6709/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6709

D6709: config: add --registered flag to show all known configs

navaneeth.suresh updated this revision to Diff 16247. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6709?vs=16229=16247 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6709/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6709

D6709: config: add --registered flag to show all known configs

av6 added inline comments. INLINE COMMENTS > ui.py:832 > +# Omit config items with dynamicdefault, devel, > +# experimental and generic config opts. > +continue Nit: originally I was fine with two different `if ...: continue` blocks

D6709: config: add --registered flag to show all known configs

navaneeth.suresh updated this revision to Diff 16229. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6709?vs=16220=16229 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6709/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6709

D6709: config: add --registered flag to show all known configs

navaneeth.suresh updated this revision to Diff 16220. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6709?vs=16218=16220 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6709/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6709

D6709: config: add --registered flag to show all known configs

navaneeth.suresh updated this revision to Diff 16218. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6709?vs=16216=16218 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6709/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6709

D6709: config: add --registered flag to show all known configs

navaneeth.suresh marked an inline comment as done. navaneeth.suresh updated this revision to Diff 16216. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6709?vs=16209=16216 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6709/new/ REVISION

D6709: config: add --registered flag to show all known configs

durin42 added a comment. durin42 accepted this revision as: durin42. Looks good to me, but I want someone else to put eyes on it before it gets pushed. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6709/new/ REVISION DETAIL

D6709: config: add --registered flag to show all known configs

navaneeth.suresh added a comment. In D6709#98718 , @marmoute wrote: > I get 28 of them. > I think we need to add an `experimental` or `status` argument ot the config registration. Created D6728 to

D6709: config: add --registered flag to show all known configs

navaneeth.suresh updated this revision to Diff 16209. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6709?vs=16172=16209 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6709/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6709

D6709: config: add --registered flag to show all known configs

marmoute added a comment. I get 28 of them. I think we need to add an `experimental` or `status` argument ot the config registration. > ag --nofilename '# experimental config:.*' -o | sort -u # experimental config: censor.policy # experimental config:

D6709: config: add --registered flag to show all known configs

pulkit added a comment. In D6709#98716 , @marmoute wrote: > We will need more than just matching the categoie name to detect experimental/deprecated config. There are such option outside of the `experimental` section, and we still need to hide

D6709: config: add --registered flag to show all known configs

navaneeth.suresh updated this revision to Diff 16172. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6709?vs=16171=16172 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6709/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6709

D6709: config: add --registered flag to show all known configs

mharbison72 added a comment. I missed the `debug` one too, sorry. (Although I’m not sure why that also isn’t `devel.`, so maybe it isn’t a big deal. Curious what others think.) REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6709/new/ REVISION DETAIL

D6709: config: add --registered flag to show all known configs

navaneeth.suresh updated this revision to Diff 16171. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6709?vs=16170=16171 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6709/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6709

D6709: config: add --registered flag to show all known configs

navaneeth.suresh added a comment. In D6709#98542 , @mharbison72 wrote: > Should we hide `devel.*` like we do `experimental` when `verbose` isn’t applied? Presumably we don’t want regular users to know about them. Done. REPOSITORY rHG

D6709: config: add --registered flag to show all known configs

mharbison72 added a comment. Should we hide `devel.*` like we do `experimental` when `verbose` isn’t applied? Presumably we don’t want regular users to know about them. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6709/new/ REVISION DETAIL

D6709: config: add --registered flag to show all known configs

navaneeth.suresh updated this revision to Diff 16170. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6709?vs=16167=16170 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6709/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6709

D6709: config: add --registered flag to show all known configs

navaneeth.suresh added inline comments. INLINE COMMENTS > marmoute wrote in test-config.t:232 > We should be consistent when printing. And we should also be consistent when > recording stuff in data. > > I think it make sense to print human friendly version ('yes/no') and use the > actual

D6709: config: add --registered flag to show all known configs

marmoute added inline comments. INLINE COMMENTS > navaneeth.suresh wrote in test-config.t:232 > that change was there in my patch one revision before. i was asked by @pulkit > to modify it as of now. would you recommend writing `no` to `fm.data()` also? > the `defaultvalue` was not in

D6709: config: add --registered flag to show all known configs

navaneeth.suresh added inline comments. navaneeth.suresh added a subscriber: yuja. INLINE COMMENTS > marmoute wrote in test-config.t:232 > the `(default: False)` should be `(default: no)` too. that change was there in my patch one revision before. i was asked by @pulkit to modify it as of now.

D6709: config: add --registered flag to show all known configs

marmoute added inline comments. INLINE COMMENTS > test-config.t:232 > + annotate.git=no (default: False) > + annotate.ignoreblanklines=no (default: False) > + annotate.ignorews=no (default: False) the `(default: False)` should be `(default: no)` too. REPOSITORY rHG Mercurial CHANGES

D6709: config: add --registered flag to show all known configs

navaneeth.suresh updated this revision to Diff 16167. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6709?vs=16165=16167 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6709/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6709

D6709: config: add --registered flag to show all known configs

pulkit added inline comments. INLINE COMMENTS > commands.py:1888 > fm.condwrite(ui.debugflag, 'source', '%s: ', source) > +fm.data(defaultvalue=defaultvalue) > if uniquesel: unrequired change I guess > marmoute wrote in test-config.t:228 > Displaying the default vs

D6709: config: add --registered flag to show all known configs

pulkit added a comment. In D6709#98493 , @marmoute wrote: > In D6709#98479 , @navaneeth.suresh wrote: > >> @pulkit I couldn't figure out why the devel-warnings are coming. It's being shown for

D6709: config: add --registered flag to show all known configs

navaneeth.suresh updated this revision to Diff 16165. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6709?vs=16164=16165 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6709/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6709

D6709: config: add --registered flag to show all known configs

navaneeth.suresh added a comment. In D6709#98493 , @marmoute wrote: > In D6709#98479 , @navaneeth.suresh wrote: > >> @pulkit I couldn't figure out why the devel-warnings are coming. It's being

D6709: config: add --registered flag to show all known configs

navaneeth.suresh updated this revision to Diff 16164. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6709?vs=16154=16164 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6709/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6709

D6709: config: add --registered flag to show all known configs

marmoute added a comment. In D6709#98479 , @navaneeth.suresh wrote: > @pulkit I couldn't figure out why the devel-warnings are coming. It's being shown for the following > items in `configitems.py`. IIUC, it should be visible when we are

D6709: config: add --registered flag to show all known configs

navaneeth.suresh added a comment. @pulkit I couldn't figure out why the devel-warnings are coming. It's being shown for the following items in `configitems.py`. IIUC, it should be visible when we are trying to read a config item which is not in the registered items. But, we are

D6709: config: add --registered flag to show all known configs

navaneeth.suresh updated this revision to Diff 16154. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6709?vs=16153=16154 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6709/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6709

D6709: config: add --registered flag to show all known configs

navaneeth.suresh updated this revision to Diff 16153. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D6709?vs=16119=16153 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D6709/new/ REVISION DETAIL https://phab.mercurial-scm.org/D6709

D6709: config: add --registered flag to show all known configs

This revision now requires changes to proceed. marmoute added inline comments. marmoute requested changes to this revision. INLINE COMMENTS > pulkit wrote in test-config.t:228 > In cases when the default value and the value of config set are different, > let's do something like ` (default=)`

D6709: config: add --registered flag to show all known configs

pulkit added inline comments. INLINE COMMENTS > ui.py:821 > > +def walkallconfig(self, untrusted=False): > +"""walk through all known config options in the registrar""" Since, we renamed the flag which was good idea, let's rename the function too. Also, this should better return

D6709: config: add --registered flag to show all known configs

navaneeth.suresh retitled this revision from "config: add --all flag to show all known configs" to "config: add --registered flag to show all known configs". navaneeth.suresh edited the summary of this revision. navaneeth.suresh marked an inline comment as done. navaneeth.suresh updated this