D7922: rust-matchers: add function to generate a regex matcher function

Closed by commit rHG52d40f8fb82d: rust-matchers: add function to generate a regex matcher function (authored by Alphare). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D7922: rust-matchers: add function to generate a regex matcher function

martinvonz added a comment. In D7922#123207 , @pulkit wrote: > In D7922#123193 , @martinvonz wrote: > >> In D7922#123057 , @pulkit wrote: >> >>>

D7922: rust-matchers: add function to generate a regex matcher function

pulkit added a comment. In D7922#123193 , @martinvonz wrote: > In D7922#123057 , @pulkit wrote: > >> @martinvonz this (and next few patches) seems accepted by you and Augie. Should I go ahead

D7922: rust-matchers: add function to generate a regex matcher function

martinvonz added a comment. In D7922#123057 , @pulkit wrote: > @martinvonz this (and next few patches) seems accepted by you and Augie. Should I go ahead and push it or I missed some discussion on IRC about it? You can push it. I wanted

D7922: rust-matchers: add function to generate a regex matcher function

pulkit added a comment. @martinvonz this seems accepted by you and Augie. Should I go ahead and push it or I missed some discussion on IRC about it? REPOSITORY rHG Mercurial BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7922/new/ REVISION DETAIL

D7922: rust-matchers: add function to generate a regex matcher function

This revision is now accepted and ready to land. martinvonz added a comment. martinvonz accepted this revision. In D7922#121720 , @durin42 wrote: > I think this looks good, but I want Martin to ack that his concern is adequately resolved.

D7922: rust-matchers: add function to generate a regex matcher function

durin42 added a comment. durin42 accepted this revision as: durin42. I think this looks good, but I want Martin to ack that his concern is adequately resolved. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7922/new/ REVISION DETAIL

D7922: rust-matchers: add function to generate a regex matcher function

Alphare updated this revision to Diff 20160. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7922?vs=20154=20160 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7922/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7922

D7922: rust-matchers: add function to generate a regex matcher function

Alphare added inline comments. INLINE COMMENTS > Alphare wrote in matchers.rs:224 > I am having a little trouble reading the patchwork thread, but I gather that > you want to get rid of the preventive splitting of patterns and just let the > regex engine handle it on its own? Was this measure

D7922: rust-matchers: add function to generate a regex matcher function

Alphare updated this revision to Diff 20154. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7922?vs=19401=20154 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7922/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7922

D7922: rust-matchers: add function to generate a regex matcher function

Alphare added inline comments. INLINE COMMENTS > martinvonz wrote in matchers.rs:224 > Hmm, I don't like to replicate this into Rust. I argued for a long time with > Boris over a year ago that we should see if we can remove it from Python. He > said they (Octobus, I think) would look into that

D7922: rust-matchers: add function to generate a regex matcher function

This revision now requires changes to proceed. martinvonz added inline comments. martinvonz requested changes to this revision. INLINE COMMENTS > matchers.rs:224 > + > +const MAX_RE_SIZE: usize = 2; > + Hmm, I don't like to replicate this into Rust. I argued for a long time with Boris over

D7922: rust-matchers: add function to generate a regex matcher function

pulkit added a comment. This one failed to apply on latest default, needs rebase. REPOSITORY rHG Mercurial BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7922/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7922 To: Alphare, #hg-reviewers, pulkit Cc:

D7922: rust-matchers: add function to generate a regex matcher function

Alphare created this revision. Herald added subscribers: mercurial-devel, kevincox, durin42. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This function will be used to help build the upcoming `IncludeMatcher`. While Re2 is still used and behind a feature flag, this function returns