D7941: py3: wallpaper over demand importer differences on Python 3.5

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY For some reason, Python 3.5 and only Python 3.5's demand importer is importing extra parent modules. This is causing test output on 3.5 to diverge. While

D7939: py3: glob over exception in test-check-py3-compat.t

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Python 3.6+ raise ModuleNotFoundError and older versions raise ImportError. Glob over the exception differences. For whatever reason, we were already doing

D7938: py3: string normalization and I/O tweaks in test-lfs.t

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The print was inserting b'' on Python 3. In addition, since we weren't writing to the ui instance (which isn't readily available in this function), output

mercurial@44109: 7 new changesets

7 new changesets in mercurial: https://www.mercurial-scm.org/repo/hg/rev/2077ffede71f changeset: 44103:2077ffede71f user:Martin von Zweigbergk date:Thu Jan 16 08:41:38 2020 -0800 summary: examples: refer to nightly rustfmt in Windows-compatible way

D7937: python-zstandard: blacken at 80 characters

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I made this change upstream and it will make it into the next release of python-zstandard. I figured I'd send it Mercurial's way because it will allow us to

D7790: rust-node: handling binary Node prefix

martinvonz added inline comments. INLINE COMMENTS > node.rs:62-64 > +/// Since it can potentially come from an hexadecimal representation with > +/// odd length, it needs to carry around whether the last 4 bits are relevant > +/// or not. Did you consider using a full u8 for each nibble

D7936: help: minor copy editing to the `config.format` section

mharbison72 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D7936 AFFECTED FILES mercurial/helptext/config.txt CHANGE DETAILS diff --git

D7920: tests: restore phabricator tests and regenerate the recordings

mharbison72 added a comment. In D7920#116596 , @mharbison72 wrote: > I did `hg phabread D7920 | hg import --bypass -` on another Windows system, and it gives the following error when running the test (omitting the cascading failures):

D7789: rust-revlog: a trait for the revlog index

martinvonz added a comment. > The None return cases in node() match what the index_node() > C function does. You mean the code on https://www.mercurial-scm.org/repo/hg/file/fdaa4233dc18/mercurial/cext/revlog.c#l388? Line 394 there returns nullid, so does that really match? Why not

D7788: rust-node: binary Node and conversion utilities

This revision now requires changes to proceed. martinvonz added inline comments. martinvonz requested changes to this revision. INLINE COMMENTS > dirs_multiset.rs:111 > path.as_ref().to_owned(), > -)) > +)); > }

mercurial@44102: 2 new changesets

2 new changesets in mercurial: https://www.mercurial-scm.org/repo/hg/rev/25097b4d2c6f changeset: 44101:25097b4d2c6f user:Inada Naoki date:Tue Jan 14 17:57:15 2020 +0900 summary: remotefilelog: fix opening validatecachelog in text mode

D7920: tests: restore phabricator tests and regenerate the recordings

mharbison72 added a comment. In D7920#116596 , @mharbison72 wrote: > I did `hg phabread D7920 | hg import --bypass -` on another Windows system, and it gives the following error when running the test (omitting the cascading failures): >

D7935: phabricator: use .arcconfig for `phabricator.url` if not set locally

mharbison72 created this revision. Herald added subscribers: mercurial-devel, Kwan. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This setting is also per repo; see the previous commit for details. The existing `conduit_uri` setting is the previous name of `phabricator.uri`[1]

D7934: phabricator: use .arcconfig for the callsign if not set locally (issue6243)

mharbison72 created this revision. Herald added subscribers: mercurial-devel, Kwan. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This makes things easier for people working with more than one repository because this file can be committed to each repository. The bug report asks to

D7933: config: add a function to insert non-file based, but overridable settings

mharbison72 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This will be used in the next patch. Until relatively recently (473510bf0575

D7920: tests: restore phabricator tests and regenerate the recordings

mharbison72 added a comment. I did `hg phabread D7920 | hg import --bypass -` on another Windows system, and it gives the following error when running the test (omitting the cascading failures): --- d:/mercurial/tests/test-phabricator.t +++

D7932: [RFC]debugbackups: introduce command to interact with strip backups

pulkit created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This vendors backups extension from hg-experimental. Listing backups and having some utility to apply them is nice. I know we have obsmarkers now, but this

Heptapod 0.8.0 (SSH) released

We're glad to announce version 0.8.0 of Heptapod, the project to integrate Mercurial in GitLab. What follows is an abridged version of the online announcement published earlier today [1]. It's been a crowded development cycle, as we are readying ourselves for public hosting at Clever Cloud [2],

D7894: nodemap: introduce an option to use mmap to read the nodemap mapping

marmoute updated this revision to Diff 19435. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7894?vs=19312=19435 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7894/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7894 AFFECTED FILES

D7888: nodemap: track the maximum revision tracked in the nodemap

marmoute updated this revision to Diff 19433. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7888?vs=19306=19433 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7888/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7888 AFFECTED FILES

D7889: nodemap: track the total and unused amount of data in the rawdata file

marmoute updated this revision to Diff 19434. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7889?vs=19307=19434 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7889/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7889 AFFECTED FILES

D7887: nodemap: add a flag to dump the details of the docket

marmoute updated this revision to Diff 19432. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7887?vs=19305=19432 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7887/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7887 AFFECTED FILES

D7885: nodemap: keep track of the docket for loaded data

marmoute updated this revision to Diff 19431. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7885?vs=19303=19431 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7885/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7885 AFFECTED FILES

D7840: nodemap: add a (python) index class for persistent nodemap testing

marmoute updated this revision to Diff 19428. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7840?vs=19186=19428 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7840/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7840 AFFECTED FILES

D7845: nodemap: add basic checking of the on disk nodemap content

marmoute updated this revision to Diff 19429. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7845?vs=19299=19429 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7845/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7845 AFFECTED FILES

D7847: nodemap: provide the on disk data to indexes who support it

marmoute updated this revision to Diff 19430. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7847?vs=19184=19430 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7847/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7847 AFFECTED FILES

D7835: nodemap: write nodemap data on disk

marmoute updated this revision to Diff 19425. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7835?vs=19185=19425 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7835/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7835 AFFECTED FILES

D7834: nodemap: have some python code serializing a nodemap

marmoute updated this revision to Diff 19424. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7834?vs=19171=19424 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7834/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7834 AFFECTED FILES

D7836: nodemap: add a function to read the data from disk

marmoute updated this revision to Diff 19426. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7836?vs=19173=19426 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7836/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7836 AFFECTED FILES

D7837: nodemap: only use persistent nodemap for non-inlined revlog

marmoute updated this revision to Diff 19427. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7837?vs=19174=19427 CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7837/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7837 AFFECTED FILES

D7834: nodemap: have some python code serializing a nodemap

marmoute added a comment. As stated yesterday, I'll have limited screen exposure time available for the next couple of day. I am going to ignore any minor nits during that time. (Am I happy to look at them afterward and follow up). Right now, I have only identified the

D7914: rust-matchers: implement `visit_children_set` for `FileMatcher`

martinvonz added inline comments. INLINE COMMENTS > Alphare wrote in matchers.rs:166 > I don't feel like this is an issue of code quality. This is (probably) an > issue of performance, and I have a good incentive for making this code go > faster in the future. I don't think this is necessary

D7931: rust-status: use bare hg status fastpath from Python

Alphare created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This change also adds a test case for subrepos. Repeating the benchmark information from the `hg-core` commit: On the Netbeans repository: C: 840ms

D7930: rust-status: update rust-cpython bridge to account for the changes in core

Alphare created this revision. Herald added subscribers: mercurial-devel, kevincox. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D7930 AFFECTED FILES rust/hg-cpython/src/dirstate.rs

D7929: rust-status: add bare `hg status` support in hg-core

Alphare created this revision. Herald added subscribers: mercurial-devel, kevincox. Herald added a reviewer: hg-reviewers. REVISION SUMMARY A lot of performance remains to be gained, most notably by doing more things in parallel, but also by caching, not falling back to Python but switching

D7925: rust-matchers: add `IgnoreMatcher`

Alphare updated this revision to Diff 19420. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7925?vs=19404=19420 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7925/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7925

D7924: rust-matchers: add `build_regex_match` function

Alphare updated this revision to Diff 19419. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7924?vs=19403=19419 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7924/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7924

D7923: rust-matchers: add functions to get roots, dirs and parents from patterns

Alphare updated this revision to Diff 19418. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7923?vs=19402=19418 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7923/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7923

D7914: rust-matchers: implement `visit_children_set` for `FileMatcher`

Alphare added inline comments. INLINE COMMENTS > martinvonz wrote in matchers.rs:166 > Yes, code quality is never urgent. The problem is that there isn't much > incentive for people to clean it up after. So I'd really prefer to not queue > this without the cleanup. I don't feel like this is

D7894: nodemap: introduce an option to use mmap to read the nodemap mapping

marmoute added a comment. In D7894#116540 , @martinvonz wrote: > In D7894#116407 , @marmoute wrote: > >> In D7894#116397 , @martinvonz wrote: >>

D7926: rust-dependencies: update rayon

martinvonz added a comment. I have no problem with the patch itself, but could you add a few words about the motivation? Even if that's just "no particular reason, I just like us to stay up to date". REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION

D7894: nodemap: introduce an option to use mmap to read the nodemap mapping

martinvonz added a comment. In D7894#116407 , @marmoute wrote: > In D7894#116397 , @martinvonz wrote: > >> How much does this patch help performance? >> I would also like to see performance

mercurial@44100: 2 new changesets

2 new changesets in mercurial: https://www.mercurial-scm.org/repo/hg/rev/b4420cea45e8 changeset: 44099:b4420cea45e8 user:Matt Harbison date:Wed Jan 15 23:34:04 2020 -0500 summary: sha1dc: avoid including the nonexistent stdint.h with Visual Studio 2008

D7914: rust-matchers: implement `visit_children_set` for `FileMatcher`

martinvonz added inline comments. INLINE COMMENTS > Alphare wrote in matchers.rs:166 > Agreed. In much of this series there exist opportunities for caching/making > things run in parallel, etc. With the freeze approaching really fast, I > prefer to prioritize getting correct - albeit

D7923: rust-matchers: add functions to get roots, dirs and parents from patterns

This revision now requires changes to proceed. kevincox added inline comments. kevincox requested changes to this revision. INLINE COMMENTS > matchers.rs:250 > +/// This calculates the roots and directories exactly matching the patterns > and > +/// returns a tuple of (roots, dirs) for each. It

D7834: nodemap: have some python code serializing a nodemap

martinvonz added a comment. In D7834#116533 , @marmoute wrote: > Can you clarify which change you are actually requesting (I see mostly nits). > So far I see the `**args` → `**opts` change but I might be missing others. I'd prefer if

D7834: nodemap: have some python code serializing a nodemap

marmoute added a comment. Can you clarify which change you are actually requesting (I see mostly nits). So far I see the `**args` → `**opts` change but I might be missing others. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7834/new/ REVISION

D7928: rust-status: add function for sequential traversal of the working directory

Alphare created this revision. Herald added subscribers: mercurial-devel, kevincox, durin42. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This change also introduces helper structs to make things clearer. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL

D7927: rust-status: add util for listing a directory

Alphare created this revision. Herald added subscribers: mercurial-devel, kevincox, durin42. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I debated moving it to utils, but it is not used anywhere else for now, and its skip behavior is pretty specific to status. REPOSITORY rHG

D7926: rust-dependencies: update rayon

Alphare created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL https://phab.mercurial-scm.org/D7926 AFFECTED FILES rust/Cargo.lock rust/hg-core/Cargo.toml CHANGE DETAILS diff

D7492: localrepo: also fastpath access to working copy parents when possible

Closed by commit rHG85c4cd73996b: localrepo: also fastpath access to working copy parents when possible (authored by marmoute). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D7502: changectx: mark parent of changesets as non filtered

Closed by commit rHG98349eddceef: changectx: mark parent of changesets as non filtered (authored by marmoute). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7502?vs=19366=19414

D7501: changectx: use unfiltered changelog to walk ancestors in annotate

Closed by commit rHGc472970339d2: changectx: use unfiltered changelog to walk ancestors in annotate (authored by marmoute). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D7495: localrepo: recognize trivial request for '.'

Closed by commit rHGbfaf4c673bec: localrepo: recognize trivial request for . (authored by marmoute). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7495?vs=19363=19411 CHANGES

D7498: localrepo: also fast past the parents of working copies parents

Closed by commit rHG5a012404503b: localrepo: also fast past the parents of working copies parents (authored by marmoute). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D7494: localrepo: fastpath access to "."

Closed by commit rHGd86dede17392: localrepo: fastpath access to . (authored by marmoute). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7494?vs=19362=19410 CHANGES SINCE LAST

D7911: examples: refer to nightly rustfmt in Windows-compatible way

Closed by commit rHG2077ffede71f: examples: refer to nightly rustfmt in Windows-compatible way (authored by martinvonz). This revision was automatically updated to reflect the committed changes. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D7732: convert: refactor authormap into separate function for outside use

Closed by commit rHGfdaa4233dc18: convert: refactor authormap into separate function for outside use (authored by joerg.sonnenberger). This revision was automatically updated to reflect the committed changes. CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D7732?vs=19398=19407#toc

D7732: convert: refactor authormap into separate function for outside use

pulkit added a comment. Amending the following in flight to make `test-check-format.t` (or black) happy: diff --git a/hgext/convert/convcmd.py b/hgext/convert/convcmd.py --- a/hgext/convert/convcmd.py +++ b/hgext/convert/convcmd.py @@ -55,6 +55,7 @@ svn_source =

D7492: localrepo: also fastpath access to working copy parents when possible

marmoute added a comment. Thank you, much appreciated. REPOSITORY rHG Mercurial BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7492/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7492 To: marmoute, #hg-reviewers, pulkit Cc: pulkit, martinvonz,

D7498: localrepo: also fast past the parents of working copies parents

This revision is now accepted and ready to land. pulkit added a comment. pulkit accepted this revision. > There are a descent odds that their will be needed too. There are descent odds that they will be needed too. made the above edit in flight. REPOSITORY rHG Mercurial BRANCH

D7494: localrepo: fastpath access to "."

pulkit added a comment. > "." is just an aliast for `p1(wdir()`, "." is just an alias for `p1(wdir())`, in flight. REPOSITORY rHG Mercurial CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7494/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7494 To: marmoute,

D7492: localrepo: also fastpath access to working copy parents when possible

This revision is now accepted and ready to land. pulkit added a comment. pulkit accepted this revision. Amending the perf numbers in commit message and fixed some spellings. REPOSITORY rHG Mercurial BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7492/new/

Re: [PATCH] remotefilelog: fix opening validatecachelog in text mode

On Tue, 14 Jan 2020 18:02:47 +0900, Inada Naoki wrote: > # HG changeset patch > # User Inada Naoki > # Date 1578992235 -32400 > # Tue Jan 14 17:57:15 2020 +0900 > # Node ID b8231c6f3cdd3dd56eb0b9aa24b70644ec3d0026 > # Parent 8e09551206f54bb102cdcbf4c57b0b10284735ce > remotefilelog: fix

[PATCH] remotefilelog: fix opening validatecachelog in text mode

# HG changeset patch # User Inada Naoki # Date 1578992235 -32400 # Tue Jan 14 17:57:15 2020 +0900 # Node ID b8231c6f3cdd3dd56eb0b9aa24b70644ec3d0026 # Parent 8e09551206f54bb102cdcbf4c57b0b10284735ce remotefilelog: fix opening validatecachelog in text mode diff -r 8e09551206f5 -r

mercurial@44098: new changeset

New changeset in mercurial: https://www.mercurial-scm.org/repo/hg/rev/19533e4c3450 changeset: 44098:19533e4c3450 bookmark:@ tag: tip user:Kyle Lippincott date:Thu Jan 16 12:17:03 2020 -0800 summary: py3: fix curses chunkselector fallback (when diffs are too

D7913: cext: fix compiler warning about sign changing

Closed by commit rHG969527ac7b44: cext: fix compiler warning about sign changing (authored by spectral). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review". REPOSITORY rHG Mercurial

D7903: sha1dc: avoid including the nonexistent stdint.h with Visual Studio 2008

Closed by commit rHGb4420cea45e8: sha1dc: avoid including the nonexistent stdint.h with Visual Studio 2008 (authored by mharbison72). This revision was automatically updated to reflect the committed changes. This revision was not accepted when it landed; it landed in state "Needs Review".

D7913: cext: fix compiler warning about sign changing

yuja added a comment. > static PyObject *hashflags(line *l) > { > > char *s = l->start; > > - size_t plen = pathlen(l); > > + Py_ssize_t plen = pathlen(l); We'll probably want to change `hplen` to `Py_ssize_t` as well. REPOSITORY rHG Mercurial CHANGES SINCE LAST

Re: D7913: cext: fix compiler warning about sign changing

> static PyObject *hashflags(line *l) > { > char *s = l->start; > - size_t plen = pathlen(l); > + Py_ssize_t plen = pathlen(l); We'll probably want to change `hplen` to `Py_ssize_t` as well. ___ Mercurial-devel mailing list

D7925: rust-matchers: add `IgnoreMatcher`

Alphare created this revision. Herald added subscribers: mercurial-devel, kevincox, durin42. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This is a big change but all of the pieces call each other, so it makes sense to have this all in one patch. REPOSITORY rHG Mercurial BRANCH

D7910: rust-re2: add wrapper for calling Re2 from Rust

Alphare updated this revision to Diff 19399. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D7910?vs=19386=19399 BRANCH default CHANGES SINCE LAST ACTION https://phab.mercurial-scm.org/D7910/new/ REVISION DETAIL https://phab.mercurial-scm.org/D7910

D7924: rust-matchers: add `build_regex_match` function

Alphare created this revision. Herald added subscribers: mercurial-devel, kevincox, durin42. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This function will be used to help build the upcoming `IncludeMatcher`. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL

D7921: rust-dirs-multiset: improve temporary error message

Alphare created this revision. Herald added subscribers: mercurial-devel, kevincox, durin42. Herald added a reviewer: hg-reviewers. REVISION SUMMARY While we wait on a future patch that could verify that the paths passed to `DirsMultiset` have been audited, we still need to handle this error.

D7922: rust-matchers: add function to generate a regex matcher function

Alphare created this revision. Herald added subscribers: mercurial-devel, kevincox, durin42. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This function will be used to help build the upcoming `IncludeMatcher`. While Re2 is still used and behind a feature flag, this function returns

D7923: rust-matchers: add functions to get roots, dirs and parents from patterns

Alphare created this revision. Herald added subscribers: mercurial-devel, kevincox, durin42. Herald added a reviewer: hg-reviewers. REVISION SUMMARY These functions will be used to help build the upcoming `IncludeMatcher`. REPOSITORY rHG Mercurial BRANCH default REVISION DETAIL

D7894: nodemap: introduce an option to use mmap to read the nodemap mapping

marmoute added a comment. marmoute added a subscriber: gracinet. In D7894#116397 , @martinvonz wrote: > How much does this patch help performance? > I would also like to see performance numbers (even just rough ones) for the Rust version.

D7886: nodemap: introduce append-only incremental update of the persisten data

marmoute added inline comments. INLINE COMMENTS > martinvonz wrote in test-persistent-nodemap.t:53 > Which patch introduced the C code? I have not looked at all patches yet, but > I thought the idea was that this entire stack was just pure Python and then > you'd add a Rust version (not C) in

D7834: nodemap: have some python code serializing a nodemap

marmoute added inline comments. INLINE COMMENTS > martinvonz wrote in debugcommands.py:2084 > could you also rename `args` to `opts`? or is there a reason to not follow > the same convention we follow everywhere (?) else? No good reason for this to not be `opts`. I'll rename it. REPOSITORY

D7914: rust-matchers: implement `visit_children_set` for `FileMatcher`

Alphare added inline comments. INLINE COMMENTS > martinvonz wrote in matchers.rs:166 > This will often be called repeatedly, so isn't it better to calculate a map > of each parent directory to its `VisitChildrenSet` value upfront (in > `FilesMatcher::new()`)? Agreed. In much of this series