[Differential] [Commented On] D37: phabricator: avoid calling differential.getrawdiff

durin42 added a comment. In https://phab.mercurial-scm.org/D37#1094, @quark wrote: > If the time to fetch a stack is not a concern, I can drop this. I'm not worried about it for now. Speed of `hg phabread` is nowhere near even being a pain point for me (the web UI is a much bigger

[Differential] [Accepted] D26: rebase: remove revignored and nullmerge states

durin42 accepted this revision. durin42 added a comment. This revision is now accepted and ready to land. Once d21 is done, this looks fine. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D26 EMAIL PREFERENCES https://phab.mercurial-scm.org/settings/panel/email

[Differential] [Requested Changes] D21: rebase: rewrite defineparents

durin42 requested changes to this revision. durin42 added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > rebase.py:910 > > -p1n = parents[0].rev() > -if p1n in destancestors: > -p1 = dest > -elif p1n in state: > -if state[p1n] == nu

[Differential] [Accepted] D24: rebase: remove revprecursor and revpruned states (BC)

durin42 accepted this revision. durin42 added a comment. This revision is now accepted and ready to land. Once d21 is done, this looks fine. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D24 EMAIL PREFERENCES https://phab.mercurial-scm.org/settings/panel/email

[Differential] [Accepted] D25: rebase: remove messages for nullmerge and revignored (BC)

durin42 accepted this revision. durin42 added a comment. This revision is now accepted and ready to land. Once d21 is done, this looks fine. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D25 EMAIL PREFERENCES https://phab.mercurial-scm.org/settings/panel/email

[Differential] [Accepted] D23: rebase: move obsoleted not rebased messages earlier (BC)

durin42 accepted this revision. durin42 added a comment. This revision is now accepted and ready to land. Once d21 is done, this looks fine. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D23 EMAIL PREFERENCES https://phab.mercurial-scm.org/settings/panel/email

[Differential] [Accepted] D22: rebase: extract ctx description logic to a function

durin42 accepted this revision. durin42 added a comment. Once d21 is done, this looks fine. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D22 EMAIL PREFERENCES https://phab.mercurial-scm.org/settings/panel/emailpreferences/ To: quark, phillco, durin42 Cc: dur

[Differential] [Commented On] D30: merge: Removed sorting in casefolding detection, for a slight performance win

durin42 added a comment. Ah, I see. Alex, do you have any idea what the performance numbers on this are like, anecdotally on your mozilla repo? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D30 EMAIL PREFERENCES https://phab.mercurial-scm.org/settings/panel/e

[Differential] [Commented On] D21: rebase: rewrite defineparents

durin42 added a comment. Almost there. INLINE COMMENTS > rebase.py:923 > +| || > +| B <- rebased as B' G <- destination of C, separate subgraph > +|/ How did C' end up in a separate subgraph? I thought it was moving to F? (I suspect this

Re: D97: revset: pass repo when passing ui

durin42 accepted this revision. durin42 added a comment. This revision is now accepted and ready to land. Taking this one, but going to punt on https://phab.mercurial-scm.org/D98 per the "consider this an RFC" comment I saw. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial

Re: D98: revset: support reading aliases from a .hgrevsets file

durin42 added a comment. In https://phab.mercurial-scm.org/D98#2104, @yuja wrote: > Can we have a single source file for project's revset/fileset aliases and maybe templates? > I don't think it's good idea to create `.hgxxx` file per config section. > > [revsetalias] > fileal

D171: phabricator: include the suggested arc config in the repo

durin42 accepted this revision as: durin42. durin42 added subscribers: durham, quark. durin42 added a comment. This looks fine to me, but I also have no idea what I'm doing. I'd appreciate someone with more arc experience letting me know if "history.immutable" : false being missing from the

D151: match: override visitdir() in nevermatcher to return False

durin42 accepted this revision. durin42 added a comment. This revision is now accepted and ready to land. Seems fine for stable. Queued. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D151 To: martinvonz, #hg-reviewers, durham, durin42 Cc: durin42, durham, mercur

D185: setup: fix mistake that prevented Python 3 from being excluded

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY My intent was to only allow Python 3 if the right environment variable is set (for when people want to use `pip install .` on hg locally). This fixes the bug in

D185: setup: fix mistake that prevented Python 3 from being excluded

This revision was automatically updated to reflect the committed changes. Closed by commit rHGee11d18fcd3c: setup: fix mistake that prevented Python 3 from being excluded (authored by durin42). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D185?vs=413&id=4

D190: docker: pass proxy arguments to docker process

durin42 accepted this revision. durin42 added a comment. This revision is now accepted and ready to land. queued these thanks REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D190 To: Mathiasdm, #hg-reviewers, durin42 Cc: durin42, mercurial-devel __

D199: tests: make test-profile.t pass if statprof didn't collect samples

durin42 accepted this revision. durin42 added a comment. This revision is now accepted and ready to land. Looking at https://launchpadlibrarian.net/331265805/buildlog_ubuntu-xenial-amd64.mercurial_4.3~rc+34-xenial-806351695c6a_BUILDING.txt.gz this has happened outside of Google's environment

D202: tests: fix test-flagprocessor.t flakiness

durin42 accepted this revision. durin42 added a comment. queued 201, 202 for stable REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D202 To: martinvonz, #hg-reviewers, dsp, akushner, durin42 Cc: durin42, dsp, mercurial-devel ___

D210: pushvars: move fb extension pushvars to core

durin42 added a comment. I've often wanted a way to have extra arguments to push commands (etc), but I'm not sure that just exporting all environment variables is exactly the interface I want. Could we accomplish something similar by having an --extra-args= flag that delivers a part with an

D216: evolution: rename bumped to phase-divergent

durin42 added a comment. I'd like to hear others chime in on this and https://phab.mercurial-scm.org/D215. Do we /know/ that something that's phase-divergent is only divergent by phase? or could the content also be different? Is it possible to have a case in the tests that's both content-di

D210: pushvars: move fb extension pushvars to core

durin42 added a comment. In https://phab.mercurial-scm.org/D210#3506, @akushner wrote: > @durin42 - This isn't exporting all the shell variables it works almost exactly like you are suggesting > > > Could we accomplish something similar by having an --extra-args= flag that delive

D216: evolution: rename bumped to phase-divergent

durin42 accepted this revision as: durin42. durin42 added a comment. I'm fine with this as-is for now, with the caveat that we might want to fix the two -divergent names in the future if they lead to user confusion. (Someone should feel encouraged to land this, I'm in the middle of some

D230: http: add a test of actually pushing with httppostargs

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This was previously untested. Sigh. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D230 AFFECTED FILES tests/test-push-http.t CHAN

D231: httppeer: add support for httppostargs when we're sending a file

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This is probably only used in the 'unbundle' command, but the code ended up being cleaner to make it generic and treat *all* httppostargs with a non-args request

D218: phabricator: add --confirm option to phabsend command

durin42 accepted this revision. durin42 added a comment. This revision is now accepted and ready to land. Sure. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D218 To: pulkit, #hg-reviewers, durin42 Cc: durin42, mercurial-devel ___

D210: pushvars: move fb extension pushvars to core

durin42 accepted this revision. durin42 added a comment. This revision is now accepted and ready to land. I like this, it opens the doors to some things I've wanted to do for a while. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D210 To: pulkit, #hg-reviewers,

D219: morestatus: move fb extension to core as '--repo-state' option to status

durin42 requested changes to this revision. durin42 added a comment. This revision now requires changes to proceed. In https://phab.mercurial-scm.org/D219#3755, @martinvonz wrote: > In https://phab.mercurial-scm.org/D219#3661, @quark wrote: > > > I'm thinking about the difference betwe

D230: http: add a test of actually pushing with httppostargs

This revision was automatically updated to reflect the committed changes. Closed by commit rHG970967e0a917: http: add a test of actually pushing with httppostargs (authored by durin42). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D230?vs=558&id=620 REVI

D231: httppeer: add support for httppostargs when we're sending a file

durin42 updated this revision to Diff 627. durin42 marked 3 inline comments as done. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D231?vs=559&id=627 REVISION DETAIL https://phab.mercurial-scm.org/D231 AFFECTED FILES mercurial/hgweb/protocol.py merc

D231: httppeer: add support for httppostargs when we're sending a file

durin42 added inline comments. INLINE COMMENTS > martinvonz wrote in httppeer.py:96 > It doesn't matter much since it's just a programming error if it happens, but > how will these arguments to ValueError be rendered? ValueError: ('_multifile only supports file objects that have a length but th

D238: context: rename troubles into instabilities

durin42 added inline comments. INLINE COMMENTS > lothiraldan wrote in exchange.py:694 > I think it was easier to display a message when considering a single trouble. > We could do better, but I'm not sure how displaying all troubles would > interact with translation. Let's add a TODO about thi

D219: morestatus: move fb extension to core by plugging to `hg status --verbose`

durin42 accepted this revision as: durin42. durin42 added a comment. I'm still a tiny bit worried about potential confusion between --terse and --verbose (in that they're not opposites), but I'm also fine with this. I'll take it in a couple of days if I don't hear any objections. REPOSITORY

D270: tests: fix up test-run-tests failures on Python 3.6

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Some of the recent work on run-tests.py didn't work on Python 3. This fixes the regressions. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-

D273: changegroup: more **kwargs

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D273 AFFECTED FILES mercurial/changegroup.py CHANGE DETAILS diff --git a/mercurial/changegroup.py b/me

D276: i18n: fix check-translation.py to be less broken on Python 3

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY These are all simple one-argument print statements, so this syntax works the same way in 2 and 3. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercu

D274: obsutil: defend against succsmarkers() returning None

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I'm not sure if this is a realistic problem, but doing this avoids some pretty awful test failures on Python 3, and it looks like it should be harmless. REPOSIT

D275: ui: refactor extractchoices so it doesn't break on Python 3

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D275 AFFECTED FILES mercurial/ui.py CHANGE DETAILS diff --git a/mercurial/ui.py b/mercurial/ui.py ---

D272: bundle2: convert ints to strings using pycompat.bytestring()

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Fixes some Python 3 regressions. We don't use %d here because the part id is actually an Optional[int]. It should always be initialized to a non-None value by

D279: tests: fix test-notify.t to use $PYTHON

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY In doing so, I consolidated the filtering logic. This resulted in some small test output changes, but I think the consistency throughout the test is worth it. R

D271: obsolete: use bytestr() instead of str() so the node is bytes on py3

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I'm not sure this is right, since this should either be bytes or str to match what's going on in the revlog layer. REPOSITORY rHG Mercurial REVISION DETAIL h

D277: dagparser: make print statement in doctest Py3 portable

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D277 AFFECTED FILES mercurial/dagparser.py CHANGE DETAILS diff --git a/mercurial/dagparser.py b/mercur

D278: tests: make test-highlight code portable to python3

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This is easier than trying to do some sort of check-code shenanigans. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D278 AFFECTED FI

D273: changegroup: more **kwargs

This revision was automatically updated to reflect the committed changes. Closed by commit rHG672ad4f3bb84: changegroup: more **kwargs (authored by durin42). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D273?vs=638&id=668 REVISION DETAIL https://phab.m

D276: i18n: fix check-translation.py to be less broken on Python 3

This revision was automatically updated to reflect the committed changes. Closed by commit rHG29238dbf718e: i18n: fix check-translation.py to be less broken on Python 3 (authored by durin42). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D276?vs=641&id=671

D277: dagparser: make print statement in doctest Py3 portable

This revision was automatically updated to reflect the committed changes. Closed by commit rHGc91013452b33: dagparser: make print statement in doctest Py3 portable (authored by durin42). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D277?vs=642&id=672 REV

D270: tests: fix up test-run-tests failures on Python 3.6

This revision was automatically updated to reflect the committed changes. Closed by commit rHG2e43c5cd57a7: tests: fix up test-run-tests failures on Python 3.6 (authored by durin42). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D270?vs=635&id=666 REVISIO

D278: tests: make test-highlight code portable to python3

This revision was automatically updated to reflect the committed changes. Closed by commit rHG65de152ba375: tests: make test-highlight code portable to python3 (authored by durin42). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D278?vs=643&id=673 REVISIO

D279: tests: fix test-notify.t to use $PYTHON

This revision was automatically updated to reflect the committed changes. Closed by commit rHGfa9f7b5d4397: tests: fix test-notify.t to use $PYTHON (authored by durin42). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D279?vs=644&id=674 REVISION DETAIL h

D272: bundle2: convert ints to strings using pycompat.bytestring()

This revision was automatically updated to reflect the committed changes. Closed by commit rHG373ca5103ba8: bundle2: convert ints to strings using pycompat.bytestring() (authored by durin42). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D272?vs=637&id=667

D274: obsutil: defend against succsmarkers() returning None

This revision was automatically updated to reflect the committed changes. Closed by commit rHG888f24810ea2: obsutil: defend against succsmarkers() returning None (authored by durin42). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D274?vs=639&id=669 REVIS

D275: ui: refactor extractchoices so it doesn't break on Python 3

This revision was automatically updated to reflect the committed changes. Closed by commit rHGd880a6bcef2f: ui: refactor extractchoices so it doesn't break on Python 3 (authored by durin42). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D275?vs=640&id=670

D271: obsolete: use bytes() instead of str() so the node is bytes on py3

durin42 updated this revision to Diff 675. durin42 retitled this revision from "obsolete: use bytestr() instead of str() so the node is bytes on py3" to "obsolete: use bytes() instead of str() so the node is bytes on py3". REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.merc

D293: tests: fix simple heredoc print statements to work on Py3

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY There are a handful left that require some more care. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D293 AFFECTED FILES tests/test

D297: tests: update duplicateoptions test to use bytestrings everywhere

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Test now passes on Python 3. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D297 AFFECTED FILES tests/test-duplicateoptions.py CHA

D295: extensions: attempt to use non-deprecated inspect method

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Avoids some deprecation warnings when extension loading breaks. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D295 AFFECTED FILES

D296: extensions: if on py3 and propname is a bytestr, decode as ascii

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Property names are unicodes on Python 3. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D296 AFFECTED FILES mercurial/extensions.py

D298: python3: whitelist two more passing tests

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D298 AFFECTED FILES contrib/python3-whitelist CHANGE DETAILS diff --git a/contrib/python3-whitelist b/

D299: pycompat: introduce a wrapper for __builtins__.{raw_,}input()

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY In order to make this work, we have to wrap the io streams in a TextIOWrapper so that __builtins__.input() can do unicode IO on Python 3. We can't just restor

D301: scmutil: use util.shellquote instead of %r

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Changes some output, but also resolves differences with Python 3. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D301 AFFECTED FILES

D294: tests: clean up many print statements to be print functions instead

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D294 AFFECTED FILES tests/test-commit-interactive-curses.t tests/test-commit-multiple.t tests/test-c

D271: obsolete: use bytes() instead of str() so the node is bytes on py3

durin42 marked an inline comment as done. durin42 added inline comments. INLINE COMMENTS > yuja wrote in obsolete.py:587 > Why can't this be just `bytes(prec)` ? > > I don't think `str(prec).encode('ascii')` is valid for binary node id. I swear that didn't work before. But it does work, so yay!

D300: python3: whitelist two more passing tests

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D300 AFFECTED FILES contrib/python3-whitelist CHANGE DETAILS diff --git a/contrib/python3-whitelist b/

D302: python3: whitelist another *13* tests that now pass

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D302 AFFECTED FILES contrib/python3-whitelist CHANGE DETAILS diff --git a/contrib/python3-whitelist b/

D271: obsolete: use bytes() instead of str() so the node is bytes on py3

This revision was automatically updated to reflect the committed changes. durin42 marked an inline comment as done. Closed by commit rHG388901a15bfa: obsolete: use bytes() instead of str() so the node is bytes on py3 (authored by durin42). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE h

D293: tests: fix simple heredoc print statements to work on Py3

This revision was automatically updated to reflect the committed changes. Closed by commit rHG27fb986e54d0: tests: fix simple heredoc print statements to work on Py3 (authored by durin42). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D293?vs=676&id=688 R

D295: extensions: attempt to use non-deprecated inspect method

This revision was automatically updated to reflect the committed changes. Closed by commit rHG62fbe95075d3: extensions: attempt to use non-deprecated inspect method (authored by durin42). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D295?vs=678&id=690 RE

D297: tests: update duplicateoptions test to use bytestrings everywhere

This revision was automatically updated to reflect the committed changes. Closed by commit rHG5b2f331d0a33: tests: update duplicateoptions test to use bytestrings everywhere (authored by durin42). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D297?vs=680&i

D294: tests: clean up many print statements to be print functions instead

This revision was automatically updated to reflect the committed changes. Closed by commit rHG24849d53697d: tests: clean up many print statements to be print functions instead (authored by durin42). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D294?vs=677

D231: httppeer: add support for httppostargs when we're sending a file

durin42 updated this revision to Diff 745. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D231?vs=627&id=745 REVISION DETAIL https://phab.mercurial-scm.org/D231 AFFECTED FILES mercurial/hgweb/protocol.py mercurial/httppeer.py CHANGE DETAILS diff --

D332: repository: formalize peer interface with abstract base class

durin42 added inline comments. INLINE COMMENTS > repository.py:29 > +def url(self): > +"""Returns a string representing this peer.""" > + Nit: shouldn't this typically be a connection string with any credentials potentially redacted? > repository.py:43 > + > +Most implement

D331: sshpeer: make instance attributes and methods internal

durin42 accepted this revision. durin42 added a comment. This revision is now accepted and ready to land. I've queued up to this point in the series. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D331 To: indygreg, #hg-reviewers, durin42 Cc: durin42, lothiraldan

D333: repository: formalize wire protocol interface

durin42 added inline comments. INLINE COMMENTS > repository.py:59 > +class _basewirecommands(object): > +"""Client-side interfac for communicating over the wire protocol. > + spelling: interfac > repository.py:217 > +of results in the order they were called. > +""" > + Prob

D339: tests: verify that peer instances only expose interface members

durin42 accepted this revision. durin42 added a comment. This revision is now accepted and ready to land. Might also be neat to have a test to assert the peer and legacy peer interfaces don't overlap? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D339 To: indyg

D329: setup: Fix installing in a mingw environment

durin42 added a comment. Should we put this on stable? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D329 To: glandium, #hg-reviewers, quark Cc: durin42, mercurial-devel ___ Mercurial-devel mailing list Mercurial-devel

D219: morestatus: move fb extension to core by plugging to `hg status --verbose`

durin42 accepted this revision. durin42 added a comment. This revision is now accepted and ready to land. I've heard no objections, but also the suggestion that --terse be something like --terse-dirs or similar so it's obviously not the antonym of --verbose. REPOSITORY rHG Mercurial REVISI

D299: pycompat: introduce a wrapper for __builtins__.{raw_,}input()

durin42 marked an inline comment as done. durin42 added inline comments. INLINE COMMENTS > yuja wrote in pycompat.py:84 > Needs to specify encoding because user input may contain > non-ascii characters. > > Perhaps it should be `noclosetextio(s, encoding=encoding.encoding)` and > `encoding.strto

D296: extensions: if on py3 and propname is a bytestr, convert to sysstr

durin42 updated this revision to Diff 799. durin42 marked 2 inline comments as done. durin42 retitled this revision from "extensions: if on py3 and propname is a bytestr, decode as ascii" to "extensions: if on py3 and propname is a bytestr, convert to sysstr". REPOSITORY rHG Mercurial CHANGES

D353: extensions: don't give AttributeError bytes message on Python 3

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D353 AFFECTED FILES mercurial/extensions.py CHANGE DETAILS diff --git a/mercurial/extensions.py b/merc

D296: extensions: if on py3 and propname is a bytestr, convert to sysstr

durin42 added inline comments. INLINE COMMENTS > yuja wrote in extensions.py:401 > Perhaps this shouldn't be bytes. Needs `r''` and drop `_()`. Done in a followup change. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D296 To: durin42, #hg-reviewers Cc: yuja, merc

D299: pycompat: introduce a wrapper for __builtins__.{raw_,}input()

durin42 updated this revision to Diff 801. durin42 marked an inline comment as done. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D299?vs=682&id=801 REVISION DETAIL https://phab.mercurial-scm.org/D299 AFFECTED FILES hgext/hgk.py mercurial/pycompat.

D301: scmutil: use util.shellquote instead of %r

This revision was automatically updated to reflect the committed changes. Closed by commit rHG2cd5aba5e1d2: scmutil: use util.shellquote instead of %r (authored by durin42). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D301?vs=684&id=923 REVISION DETAIL

D369: util: add `hgdatetopython` to convert hg-style dates to datetimes

durin42 added inline comments. INLINE COMMENTS > util.py:1862 > +def hgdatetopython(date): > +"""Returns a Python datetime from a Mercurial tuple-style date""" > +t, tz = date This function makes me really nervous, because it's a naive datetime rather than a tz-aware datetime. Could we

D368: releasenotes: add check flag for use of admonitions and its validity

durin42 requested changes to this revision. durin42 added a comment. This revision now requires changes to proceed. A style nit, generally +1 and if you get the style nits handled we should be good to go. INLINE COMMENTS > releasenotes.py:266 > +else: > +ui.write(

D355: contrib: add check flag for use of admonitions and its validity

durin42 added a comment. is this the same thing as https://phab.mercurial-scm.org/D368? Should we close this one in favor of that one? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D355 To: rishabhmadan96, #hg-reviewers, pulkit Cc: durin42, pulkit, mercurial-de

D362: hg: Avoid relying on errno numbers / descriptions

durin42 added a comment. Sigh. Do you happen to know if the names of the errno enum values is constant? If it is, maybe we could turn the number back into a name. In any case, queued for stable. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D362 To: mithra

D300: python3: whitelist four more passing tests

durin42 updated this revision to Diff 944. durin42 retitled this revision from "python3: whitelist two more passing tests" to "python3: whitelist four more passing tests". REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D300?vs=683&id=944 REVISION DETAIL

D296: extensions: if on py3 and propname is a bytestr, convert to sysstr

durin42 updated this revision to Diff 945. durin42 marked 2 inline comments as done. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D296?vs=799&id=945 REVISION DETAIL https://phab.mercurial-scm.org/D296 AFFECTED FILES mercurial/extensions.py CHANGE DE

D298: python3: whitelist four more passing tests

durin42 updated this revision to Diff 947. durin42 retitled this revision from "python3: whitelist two more passing tests" to "python3: whitelist four more passing tests". REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D298?vs=681&id=947 REVISION DETAIL

D353: extensions: don't give AttributeError bytes message on Python 3

durin42 updated this revision to Diff 946. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D353?vs=800&id=946 REVISION DETAIL https://phab.mercurial-scm.org/D353 AFFECTED FILES mercurial/extensions.py CHANGE DETAILS diff --git a/mercurial/extensions.p

D296: extensions: if on py3 and propname is a bytestr, convert to sysstr

durin42 added a comment. Take another look? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D296 To: durin42, #hg-reviewers Cc: yuja, mercurial-devel ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org htt

D299: py3: introduce a wrapper for __builtins__.{raw_,}input()

durin42 updated this revision to Diff 948. durin42 edited the summary of this revision. durin42 retitled this revision from "pycompat: introduce a wrapper for __builtins__.{raw_,}input()" to "py3: introduce a wrapper for __builtins__.{raw_,}input()". REPOSITORY rHG Mercurial CHANGES SINCE LAS

D299: py3: introduce a wrapper for __builtins__.{raw_,}input()

durin42 marked 5 inline comments as done. durin42 added inline comments. INLINE COMMENTS > yuja wrote in pycompat.py:84 > Nah. So this could be `util.bytesinput(fin, fout)` and `encoding.strio()`. Sigh. I'm not sure I got the encoding.py bit quite right, take a look? REPOSITORY rHG Mercurial

D231: httppeer: add support for httppostargs when we're sending a file

This revision was automatically updated to reflect the committed changes. Closed by commit rHG3c91cc0c5fde: httppeer: add support for httppostargs when we're sending a file (authored by durin42). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D231?vs=745&id

D377: simplemerge: add `filtereddata=False` to simplemerge()

durin42 added a comment. (from an IRC conversation) I'm not crazy about the shape this makes the API, as I'd rather we didn't start growing awareness of filtering in layers this high. I think we can probably kill contrib/simplemerge entirely - it's had nothing but cleanup changes an

D377: simplemerge: add `filtereddata=False` to simplemerge()

durin42 added a comment. Also, timeless noticed https://phab.mercurial-scm.org/rHGabd66eb0889e3efaca4f960e0eacd719c18880dd, which reinforces my belief that we don't need contrib/simplemerge anymore. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D377 To: phillc

D126: phabricator: add status to revision query language

durin42 accepted this revision. durin42 added a comment. This revision is now accepted and ready to land. queued, thanks REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D126 To: quark, #hg-reviewers, durin42 Cc: durin42, mercurial-devel ___

D127: phabricator: add phabupdate command to update status in batch

durin42 accepted this revision. durin42 added a comment. This revision is now accepted and ready to land. queued, thanks REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D127 To: quark, #hg-reviewers, durin42 Cc: durin42, krbullock, mercurial-devel

D299: py3: introduce a wrapper for __builtins__.{raw_,}input()

This revision was automatically updated to reflect the committed changes. durin42 marked an inline comment as done. Closed by commit rHGd390726b575d: py3: introduce a wrapper for __builtins__.{raw_,}input() (authored by durin42). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D299?vs=94

D298: python3: whitelist four more passing tests

This revision was automatically updated to reflect the committed changes. Closed by commit rHG48f3e87ce650: python3: whitelist four more passing tests (authored by durin42). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D298?vs=947&id=970 REVISION DETAIL

D302: python3: whitelist another *13* tests that now pass

This revision was automatically updated to reflect the committed changes. Closed by commit rHG470e2c7ee34f: python3: whitelist another *13* tests that now pass (authored by durin42). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D302?vs=685&id=972 REVISIO

<    1   2   3   4   5   6   7   8   9   10   >