D4562: py3: whitelist another passing test

2018-09-13 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a reviewer: pulkit. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4562 AFFECTED FILES contrib/python3-whitelist CHANGE DETAILS diff --

D4584: dagop: fix typo spotted while doing unrelated investigation

2018-09-13 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4584 AFFECTED FILES mercurial/dagop.py CHANGE DETAILS diff --git a/mercurial/dagop.py b/mercurial/dag

D4584: dagop: fix typo spotted while doing unrelated investigation

2018-09-13 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG5362c96f2feb: dagop: fix typo spotted while doing unrelated investigation (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D458

D4582: censor: use a reasonable amount of memory

2018-09-13 Thread durin42 (Augie Fackler)
durin42 added a comment. In https://phab.mercurial-scm.org/D4582#69941, @indygreg wrote: > This effectively changes things from a list to a generator. That means we can only iterate `headctxs` once. > > We do only iterate `headctxs` once, so this is safe. But it isn't a good practice

D4562: py3: whitelist another passing test

2018-09-14 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG053aa673947f: py3: whitelist another passing test (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4562?vs=10994&id=11040 REV

D4564: localrepo: move some vfs initialization out of __init__

2018-09-14 Thread durin42 (Augie Fackler)
durin42 accepted this revision. durin42 added a comment. This revision is now accepted and ready to land. I think I like where this is headed. Will read rest of series later. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4564 To: indygreg, #hg-reviewers, durin4

D4595: create alpha for phabricator test

2018-09-14 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4595 AFFECTED FILES alpha CHANGE DETAILS diff --git a/alpha b/alpha new file mode 100644 --- /dev/nul

D4596: create alpha for phabricator test

2018-09-14 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4596 AFFECTED FILES alpha CHANGE DETAILS diff --git a/alpha b/alpha new file mode 100644 --- /dev/nul

D4596: create alpha for phabricator test

2018-09-14 Thread durin42 (Augie Fackler)
durin42 updated this revision to Diff 11073. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4596?vs=11072&id=11073 REVISION DETAIL https://phab.mercurial-scm.org/D4596 AFFECTED FILES alpha CHANGE DETAILS diff --git a/alpha b/alpha new file mode 1006

D4597: create beta for phabricator test

2018-09-14 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4597 AFFECTED FILES beta CHANGE DETAILS diff --git a/beta b/beta new file mode 100644 --- /dev/null +

D4598: hghave: add a checker for the vcr HTTP record/replay library

2018-09-14 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I'm going to use this to write some tests of the phabricator extension. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4598 AFFECT

D4599: keepalive: work around slight deficiency in vcr

2018-09-14 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY VCR's response type doesn't define the will_close attribute. Let's just have keepalive default to closing the socket if the will_close attribute is missing. REP

D4600: phabricator: add support for using the vcr library to mock interactions

2018-09-14 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I'll use this in an upcoming test. The decorator dancing in this is more complicated than I'd like, but it beats repeating all this code everywhere. REPOSITORY

D4602: phabricator: move extension from contrib to hgext

2018-09-14 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY It's well-enough tested now and widely enough used I think we should ship it. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4602

D4603: phabricator: add tests of templatekeyword

2018-09-14 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Having tests is paying off: I found a bug and now it'll be easy to fix! REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4603 AFFECT

D4604: phabricator: fix templating bug by using hybriddict

2018-09-14 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4604 AFFECTED FILES hgext/phabricator.py tests/test-phabricator.t CHANGE DETAILS diff --git a/tests

D4602: phabricator: move extension from contrib to hgext

2018-09-14 Thread durin42 (Augie Fackler)
durin42 updated this revision to Diff 11083. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4602?vs=11079&id=11083 REVISION DETAIL https://phab.mercurial-scm.org/D4602 AFFECTED FILES contrib/phabricator.py hgext/phabricator.py tests/test-phabricat

D4603: phabricator: add tests of templatekeyword

2018-09-14 Thread durin42 (Augie Fackler)
durin42 updated this revision to Diff 11084. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4603?vs=11080&id=11084 REVISION DETAIL https://phab.mercurial-scm.org/D4603 AFFECTED FILES tests/test-phabricator.t CHANGE DETAILS diff --git a/tests/test-ph

D4604: phabricator: fix templating bug by using hybriddict

2018-09-14 Thread durin42 (Augie Fackler)
durin42 updated this revision to Diff 11085. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4604?vs=11081&id=11085 REVISION DETAIL https://phab.mercurial-scm.org/D4604 AFFECTED FILES hgext/phabricator.py tests/test-phabricator.t CHANGE DETAILS dif

D4605: phabricator: mark extension as experimental for now

2018-09-14 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I don't want us to commit to this having a stable interface just yet. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4605 AFFECTED F

D4598: hghave: add a checker for the vcr HTTP record/replay library

2018-09-15 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGe37a0fcd82c0: hghave: add a checker for the vcr HTTP record/replay library (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D45

D4599: keepalive: work around slight deficiency in vcr

2018-09-15 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGd6d094259d9c: keepalive: work around slight deficiency in vcr (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4599?vs=11076&i

D4600: phabricator: add support for using the vcr library to mock interactions

2018-09-15 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGd8f07b16abfc: phabricator: add support for using the vcr library to mock interactions (authored by durin42, committed by ). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D4600?vs=11077&id=1108

D4602: phabricator: move extension from contrib to hgext

2018-09-15 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGd2c81e83de2a: phabricator: move extension from contrib to hgext (authored by durin42, committed by ). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D4602?vs=11083&id=11091#toc REPOSITORY rH

D4603: phabricator: add tests of templatekeyword

2018-09-15 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG10c53b2e9d52: phabricator: add tests of templatekeyword (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4603?vs=11084&id=1109

D4604: phabricator: fix templating bug by using hybriddict

2018-09-15 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG4057e38bba76: phabricator: fix templating bug by using hybriddict (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4604?vs=110

D4605: phabricator: mark extension as experimental for now

2018-09-15 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG87539f615b87: phabricator: mark extension as experimental for now (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4605?vs=110

D4635: tests: fix a couple of drawdag.py references

2018-09-17 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4635 AFFECTED FILES tests/test-absorb-phase.t tests/test-absorb-strip.t CHANGE DETAILS diff --git a

D4635: tests: fix a couple of drawdag.py references

2018-09-18 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG0b7594ada0db: tests: fix a couple of drawdag.py references (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4635?vs=11134&id=1

D4640: narrow: add test showing that local-to-local narrow clones don't work

2018-09-18 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY It turns out they've never actually worked: prior to some recent refactoring they just unintentionally followed the full-clone path, which we unintentionally rel

D4615: wireprotov2: declare command arguments richly

2018-09-18 Thread durin42 (Augie Fackler)
durin42 added inline comments. INLINE COMMENTS > wireprotov2server.py:543-546 > + ``default`` > + A callable returning the default value for this argument. > + > + ``required`` Shouldn't there be a default XOR required == true? That is, could we get away with `default=None`

D4576: localrepo: extract resolving of opener options to standalone functions

2018-09-18 Thread durin42 (Augie Fackler)
durin42 added a comment. I kind of hope that eventually you're going to break all the requirements-handling nonsense out into its own module somehow? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4576 To: indygreg, #hg-reviewers Cc: durin42, mercurial-devel __

D2679: [PoC] obsolete: config option to enable local only obsolescence mode

2018-09-19 Thread durin42 (Augie Fackler)
durin42 added a comment. In https://phab.mercurial-scm.org/D2679#70934, @lothiraldan wrote: > In https://phab.mercurial-scm.org/D2679#69388, @durin42 wrote: > > > I'm slowly becoming convinced that the long-unquestioned axiom that "all markers are distributed globally" isn't correct,

D4640: narrow: add test showing that local-to-local narrow clones don't work

2018-09-20 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGb990f5a31e6b: narrow: add test showing that local-to-local narrow clones don't work (authored by durin42, committed by ). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D4640?vs=11147&id=11206#

D4684: changegroup: remove outdated comment

2018-09-20 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4684 AFFECTED FILES mercurial/changegroup.py CHANGE DETAILS diff --git a/mercurial/changegroup.py b/m

D4685: changegroup: tease out a temporary prune method for manifests

2018-09-20 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY It's extracted so extensions can filter manifest nodes if needed. This is an unfortunate hack, but I think I only need it for manifests. The long-term solution w

D4686: changegroup: reintroduce some comments that have gotten lost over the years

2018-09-20 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I got concerned about the correctness of the pruning logic, but I was misreading it. I didn't figure that out until I walked all the way back to https://phab.me

D4684: changegroup: remove outdated comment

2018-09-20 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGc71f80bfb414: changegroup: remove outdated comment (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4684?vs=11224&id=11235 RE

D4685: changegroup: tease out a temporary prune method for manifests

2018-09-20 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGe03c1a63155c: changegroup: tease out a temporary prune method for manifests (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4

D4686: changegroup: reintroduce some comments that have gotten lost over the years

2018-09-20 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG5adc5fe41a7d: changegroup: reintroduce some comments that have gotten lost over the years (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercur

D4689: py3: mark another passing test

2018-09-21 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a reviewer: pulkit. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4689 AFFECTED FILES contrib/python3-whitelist CHANGE DETAILS diff --

D4690: streamclone: reimplement nested context manager

2018-09-21 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY It's gone in Python 3, and you can't *ctxs into a with statement. Sigh. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4690 AFFECTED

D4691: bundle2: grab kwarg using sysstr

2018-09-21 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY 1. skip-blame just an r prefix on a string REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4691 AFFECTED FILES mercurial/bundle2.py

D4689: py3: mark another passing test

2018-09-21 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGe65697cce065: py3: mark another passing test (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4689?vs=11256&id=11259 REVISION

D4691: bundle2: grab kwarg using sysstr

2018-09-21 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG4a8bfec90ae6: bundle2: grab kwarg using sysstr (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4691?vs=11258&id=11260 REVISI

D4690: streamclone: reimplement nested context manager

2018-09-21 Thread durin42 (Augie Fackler)
durin42 updated this revision to Diff 11261. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4690?vs=11257&id=11261 REVISION DETAIL https://phab.mercurial-scm.org/D4690 AFFECTED FILES mercurial/streamclone.py CHANGE DETAILS diff --git a/mercurial/str

D4690: streamclone: reimplement nested context manager

2018-09-21 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG97f2992c26f6: streamclone: reimplement nested context manager (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4690?vs=11261&i

D4615: wireprotov2: declare command arguments richly

2018-09-24 Thread durin42 (Augie Fackler)
durin42 added inline comments. INLINE COMMENTS > wireprotov2server.py:547 > + > + ``required`` > + Bool indicating whether the argument is required. https://phab.mercurial-scm.org/D4617 no longer exists, so I'm taking this change as-is, but expect a follow-up (at least conversati

D4615: wireprotov2: declare command arguments richly

2018-09-24 Thread durin42 (Augie Fackler)
durin42 added a subscriber: indygreg. durin42 added a comment. > indygreg added inline comments. > > INLINE COMMENTS > >> wireprotov2server.py:602-605 >> +if 'default' in meta and meta.get('required'): >> +raise error.ProgrammingError('%s argument for command

D4728: keepalive: be more careful about self._rbuf when calling super impls

2018-09-24 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY In Python 3, HTTPResponse implements read() in terms of readinto(), which was calling back into our readinto(), which duplicates self._rbuf if it's not empty. Be

D4729: py3: whitelist two more passing tests

2018-09-24 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a reviewer: pulkit. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Caught by the ratchet, but initially only the non-legacy path of test-clone-uncompressed.t was passing. That required the precedin

D4728: keepalive: be more careful about self._rbuf when calling super impls

2018-09-24 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG1cf1680b0554: keepalive: be more careful about self._rbuf when calling super impls (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm

D4729: py3: whitelist two more passing tests

2018-09-24 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG94c25f694ec3: py3: whitelist two more passing tests (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4729?vs=11337&id=11339 R

D4782: remotefilelog: import pruned-down remotefilelog extension from hg-experimental

2018-09-27 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added subscribers: mercurial-devel, mjpieters. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This is remotefilelog as of my recent patches for compatibility with current tip of hg, minus support for old versions of Mercurial and some FB-specifi

D4782: remotefilelog: import pruned-down remotefilelog extension from hg-experimental

2018-09-28 Thread durin42 (Augie Fackler)
durin42 updated this revision to Diff 11467. durin42 edited the summary of this revision. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4782?vs=11454&id=11467 REVISION DETAIL https://phab.mercurial-scm.org/D4782 AFFECTED FILES hgext/remotefilelog/REA

D4782: remotefilelog: import pruned-down remotefilelog extension from hg-experimental

2018-09-28 Thread durin42 (Augie Fackler)
durin42 updated this revision to Diff 11468. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D4782?vs=11467&id=11468 REVISION DETAIL https://phab.mercurial-scm.org/D4782 AFFECTED FILES hgext/remotefilelog/README.md hgext/remotefilelog/__init__.py hg

D4817: py3: whitelist two additional tests

2018-10-01 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a reviewer: pulkit. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4817 AFFECTED FILES contrib/python3-whitelist CHANGE DETAILS diff --

D4818: catapipe: fix bug introduced when switching to the timer api

2018-10-01 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D4818 AFFECTED FILES contrib/catapipe.py CHANGE DETAILS diff --git a/contrib/catapipe.py b/contrib/cat

D4817: py3: whitelist two additional tests

2018-10-01 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG2dac1f730562: py3: whitelist one additional test (authored by durin42, committed by ). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D4817?vs=11512&id=11514#toc REPOSITORY rHG Mercurial CH

D4818: catapipe: fix bug introduced when switching to the timer api

2018-10-01 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGcb9b23ec093c: catapipe: fix bug introduced when switching to the timer api (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D48

D4803: storageutil: extract most of emitrevisions() to standalone function

2018-10-03 Thread durin42 (Augie Fackler)
durin42 requested changes to this revision. durin42 added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > storageutil.py:266 > + > +def emitrevisions(store, revs, resultcls, deltaparentfn, candeltafn, > + rawsizefn, revdifffn, flagsfn, sendfullte

D4803: storageutil: extract most of emitrevisions() to standalone function

2018-10-03 Thread durin42 (Augie Fackler)
durin42 added a comment. Oh, I just got to https://phab.mercurial-scm.org/D4805. I think the helper is still of somewhat limited utility and truly novel storage engines will end up totally reimplementing emitrevisions, but that's fine. REPOSITORY rHG Mercurial REVISION DETAIL https://ph

D4870: showstack: also handle SIGALRM

2018-10-03 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This is looking *very* handy when debugging mysterious hangs in a test: you can wrap a hanging invocation in `perl -e 'alarm shift @ARGV; exec @ARGV' 1`

D2058: chg: enable clang-format on all .c and .h files

2018-02-06 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Nothing in here looks awful, so I think we may as well just do it. 1. skip-blame because it's just reformatting with no functionality change REPOSITORY rHG M

D2059: hgsh: enable clang-format

2018-02-06 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Nothing looks awful, so we can just turn it on. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2059 AFFECTED FILES contrib/clang-f

D2057: translate base85.c into rust code

2018-02-06 Thread durin42 (Augie Fackler)
durin42 added a subscriber: indygreg. durin42 added a comment. I'd be curious to see what @indygreg has to say about this, maybe wait on his input before doing any work in response to my feedback? I do wonder if we should have at least three crates: 1. hgcli 2. libmercurial 3. hg

D2078: python3: whitelist an additional 11 tests

2018-02-07 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a reviewer: pulkit. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I think these are mostly the result of Pulkit's recent work. Thanks! REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mer

D2078: python3: whitelist an additional 11 tests

2018-02-07 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGfd9f2a22ee83: python3: whitelist an additional 11 tests (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2078?vs=5292&id=5294

D2059: hgsh: enable clang-format

2018-02-07 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG580f7b1b88c7: hgsh: enable clang-format (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2059?vs=5240&id=5296 REVISION DETAIL

D2058: chg: enable clang-format on all .c and .h files

2018-02-07 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG9724f54923ec: chg: enable clang-format on all .c and .h files (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2058?vs=5239&id

D2061: sshpeer: initial definition and implementation of new SSH protocol

2018-02-07 Thread durin42 (Augie Fackler)
durin42 added inline comments. INLINE COMMENTS > joerg.sonnenberger wrote in test-ssh-proto.t:396 > I'm a bit concerned about the order here. I would prefer to stay with the > spirit of the original SSH protocol and go with the following order instead: > > - client sends hello to the server > -

D2064: wireprotoserver: document and improve the httplib workaround

2018-02-07 Thread durin42 (Augie Fackler)
durin42 accepted this revision. durin42 added a comment. This revision is now accepted and ready to land. I'm so sorry for this technical debt, even if it's httplib's fault. :/ REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2064 To: indygreg, #hg-reviewers, duri

D1998: wireproto: define and use types for wire protocol commands

2018-02-07 Thread durin42 (Augie Fackler)
durin42 added a comment. I'm curious what registrations you need that don't fit in 2-tuples. Can I see a sample of where that's going? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1998 To: indygreg, #hg-reviewers Cc: durin42, mercurial-devel _

D2048: utils: copy util.py as utils/dateutil.py

2018-02-07 Thread durin42 (Augie Fackler)
durin42 requested changes to this revision. durin42 added a comment. This revision now requires changes to proceed. Can we do all of https://phab.mercurial-scm.org/D2048::https://phab.mercurial-scm.org/D2056 as a single change? What you've done means we have no useful blame information on ev

D1998: wireproto: define and use types for wire protocol commands

2018-02-07 Thread durin42 (Augie Fackler)
durin42 accepted this revision. durin42 added a comment. This revision is now accepted and ready to land. I'm sold. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1998 To: indygreg, #hg-reviewers, durin42 Cc: durin42, mercurial-devel

D2048: utils: copy util.py as utils/dateutil.py

2018-02-08 Thread durin42 (Augie Fackler)
durin42 added a comment. In https://phab.mercurial-scm.org/D2048#34978, @lothiraldan wrote: > In https://phab.mercurial-scm.org/D2048#34743, @durin42 wrote: > > > Can we do all of https://phab.mercurial-scm.org/D2048::https://phab.mercurial-scm.org/D2056 as a single change? What you'

D2177: bdiff: add to clang-format oversight

2018-02-12 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This file didn't require any complex fixes, so we may as well enable clang-format while I'm editing it. REPOSITORY rHG Mercurial REVISION DETAIL https://phab

D1973: bdiff: write a native version of splitnewlines

2018-02-12 Thread durin42 (Augie Fackler)
durin42 updated this revision to Diff 5487. durin42 marked an inline comment as done. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D1973?vs=5160&id=5487 REVISION DETAIL https://phab.mercurial-scm.org/D1973 AFFECTED FILES mercurial/cext/bdiff.c merc

D1973: bdiff: write a native version of splitnewlines

2018-02-12 Thread durin42 (Augie Fackler)
durin42 marked an inline comment as done. durin42 added a comment. Good catches. This should be ready now. I also added bdiff.c to clang-format oversight in a newly inserted parent, because the file is simple enough that doing so was easy. REPOSITORY rHG Mercurial REVISION DETAIL ht

D2180: charencode: adjust clang-format enable/disable comments

2018-02-12 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We're pretty close to being able to let clang-format manage most of these files. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D218

D2178: pathencode: allow clang-format oversight

2018-02-12 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Only had to add two trailing commas to make the file format acceptably! REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2178 AFFECTED

D2181: charencode: allow clang-format oversight

2018-02-12 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Nice and easy. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2181 AFFECTED FILES contrib/clang-format-blacklist mercurial/cext/

D2179: diffhelpers: allow clang-format oversight

2018-02-12 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY One trailing comma! REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2179 AFFECTED FILES contrib/clang-format-blacklist mercurial/

D2182: base85: allow clang-format oversight

2018-02-12 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2182 AFFECTED FILES contrib/clang-format-blacklist mercurial/cext/base85.c CHANGE DETAILS diff --gi

D2183: mpatch: allow clang-format oversight

2018-02-12 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2183 AFFECTED FILES contrib/clang-format-blacklist mercurial/cext/mpatch.c CHANGE DETAILS diff --gi

D2177: bdiff: add to clang-format oversight

2018-02-12 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGb4fdc6177b29: bdiff: add to clang-format oversight (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2177?vs=5486&id=5494 REVI

D2178: pathencode: allow clang-format oversight

2018-02-12 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG44cb058bc0d3: pathencode: allow clang-format oversight (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2178?vs=5488&id=5495

D2179: diffhelpers: allow clang-format oversight

2018-02-12 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG7f8338b87c88: diffhelpers: allow clang-format oversight (authored by durin42, committed by ). CHANGED PRIOR TO COMMIT https://phab.mercurial-scm.org/D2179?vs=5489&id=5496#toc REPOSITORY rHG Mercuria

D2180: charencode: adjust clang-format enable/disable comments

2018-02-12 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG81199632fa42: charencode: adjust clang-format enable/disable comments (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2180?vs

D1974: narrow: import experimental extension from narrowhg revision cb51d673e9c5

2018-02-12 Thread durin42 (Augie Fackler)
durin42 updated this revision to Diff 5498. durin42 marked 12 inline comments as done. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D1974?vs=5095&id=5498 REVISION DETAIL https://phab.mercurial-scm.org/D1974 AFFECTED FILES hgext/narrow/__init__.py h

D2187: manifest: clean up dirlog() to take a d parameter to avoid shadowing dir()

2018-02-12 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2187 AFFECTED FILES hgext/narrow/narrowrevlog.py mercurial/manifest.py CHANGE DETAILS diff --git a/

D2188: narrowrevlog: add what little I can remember about rename filtering

2018-02-12 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2188 AFFECTED FILES hgext/narrow/narrowrevlog.py CHANGE DETAILS diff --git a/hgext/narrow/narrowrevlo

D2008: revlog: move ELLIPSIS_NODE_FLAG to core from narrowrevlog

2018-02-12 Thread durin42 (Augie Fackler)
durin42 updated this revision to Diff 5499. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2008?vs=5158&id=5499 REVISION DETAIL https://phab.mercurial-scm.org/D2008 AFFECTED FILES hgext/narrow/narrowchangegroup.py hgext/narrow/narrowrevlog.py hgex

D2189: narrowrevlog: add a TODO around remotefilelog moving to core

2018-02-12 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We should clean this up considerably when remotefilelog lands, which we expect to try and accomplish in the near-ish future. REPOSITORY rHG Mercurial REVISION

D2190: narrowspec: document constraints when validating patterns

2018-02-12 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2190 AFFECTED FILES hgext/narrow/narrowspec.py CHANGE DETAILS diff --git a/hgext/narrow/narrowspec.py

D2191: narrowspec: consistently use set() to copy sets

2018-02-12 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2191 AFFECTED FILES hgext/narrow/narrowspec.py CHANGE DETAILS diff --git a/hgext/narrow/narrowspec.py

D2193: narrowwirepeer: rename expandnarrow capability to exp-expandnarrow

2018-02-12 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The expandnarrow functionality lets a client have a shorthand (for Google it's a reference to a checked-in file) for a set of includes and excludes. For testing

D2186: narrowrevlog: replace AssertionError with ProgrammingError

2018-02-12 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2186 AFFECTED FILES hgext/narrow/narrowrevlog.py CHANGE DETAILS diff --git a/hgext/narrow/narrowrevlo

D2185: narrowrevlog: document excludeddir class and friends

2018-02-12 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2185 AFFECTED FILES hgext/narrow/narrowrevlog.py CHANGE DETAILS diff --git a/hgext/narrow/narrowrevlo

D2184: narrowrepo: add docstring for narrowpats

2018-02-12 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2184 AFFECTED FILES hgext/narrow/narrowrepo.py CHANGE DETAILS diff --git a/hgext/narrow/narrowrepo.py

<    5   6   7   8   9   10   11   12   13   14   >