martinvonz added a comment.
In https://phab.mercurial-scm.org/D3145#50619, @martinvonz wrote:
> In https://phab.mercurial-scm.org/D3145#50598, @yuja wrote:
>
> > It seems incorrect to me to catch LookupError of `node` returned by
> > a namespace API, not by a user-specified node
yuja requested changes to this revision.
yuja added a comment.
This revision now requires changes to proceed.
It seems incorrect to me to catch LookupError of `node` returned by
a namespace API, not by a user-specified node value.
I think the reason why catching `RepoLookupError` here
martinvonz created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Similar to the previous patch, here we were catching
FilteredRepoLookupError and RepoLookupError instead of
FilteredLookupError and LookupError. What makes
