indygreg added inline comments.
INLINE COMMENTS
> yuja wrote in wireproto.py:526
> My two cents. I think it's better to pass `args` dict without expansion.
> `**args` means we can't use `repo` and `proto` as parameter names.
I agree about not using ``**args``. It is there mostly for compatibilit
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG0b7475ea38cf: wireproto: port heads command to wire
protocol v2 (authored by indygreg, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D3179?vs=7864
yuja added inline comments.
INLINE COMMENTS
> wireproto.py:526
> +elif isinstance(args, dict):
> +return func(repo, proto, **args)
> +else:
My two cents. I think it's better to pass `args` dict without expansion.
`**args` means we can't use `repo` and `proto` as parameter names.
indygreg created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
After much thought and consideration, wire protocol version 2's
commands will be defined in different functions from the existing
commands. This will make it ea
