D243: obsmarker: rename precnode into prednode

2017-08-09 Thread lothiraldan (Boris Feld)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG2cb442bc1a76: obsmarker: rename precnode into prednode (authored by lothiraldan). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D243?vs=588=699 REVISION DETAIL

D238: context: rename troubles into instabilities

2017-08-09 Thread lothiraldan (Boris Feld)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGab0c55c2ad9a: context: rename troubles into instabilities (authored by lothiraldan). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D238?vs=664=694 REVISION

D246: obsolete: rename precursor into predecessor in obsolete docstrings

2017-08-09 Thread lothiraldan (Boris Feld)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG0c3112f17610: obsolete: rename precursor into predecessor in obsolete docstrings (authored by lothiraldan). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D242: context: rename troubled into isunstable

2017-08-09 Thread lothiraldan (Boris Feld)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG52c5ff856b49: context: rename troubled into isunstable (authored by lothiraldan). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D242?vs=665=700 REVISION DETAIL

D247: obsutil: rename allprecursors into allpredecessors

2017-08-09 Thread lothiraldan (Boris Feld)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGe6d8ee3c9ec3: obsutil: rename allprecursors into allpredecessors (authored by lothiraldan). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D247?vs=592=703

Re: D242: context: rename troubled into isunstable

2017-08-09 Thread Brandon McCaig
On Wed, Aug 09, 2017 at 03:37:26PM +, lothiraldan (Boris Feld) wrote: > diff --git a/mercurial/context.py b/mercurial/context.py --- > a/mercurial/context.py +++ b/mercurial/context.py @@ -240,6 > +240,12 @@ return self.rev() in obsmod.getrevs(self._repo, > 'divergent') > > def

Re: D242: context: rename troubled into isunstable

2017-08-09 Thread Boris Feld
On Wed, 2017-08-09 at 12:32 -0400, Brandon McCaig wrote: > On Wed, Aug 09, 2017 at 03:37:26PM +, lothiraldan (Boris Feld) > wrote: > > diff --git a/mercurial/context.py b/mercurial/context.py --- > > a/mercurial/context.py +++ b/mercurial/context.py @@ -240,6 > > +240,12 @@ return self.rev()

D237: template: rename troubles templatekw into instabilities

2017-08-09 Thread lothiraldan (Boris Feld)
lothiraldan updated this revision to Diff 663. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D237?vs=653=663 REVISION DETAIL https://phab.mercurial-scm.org/D237 AFFECTED FILES mercurial/templatekw.py mercurial/templates/map-cmdline.default

D242: context: rename troubled into isunstable

2017-08-09 Thread lothiraldan (Boris Feld)
lothiraldan updated this revision to Diff 665. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D242?vs=626=665 REVISION DETAIL https://phab.mercurial-scm.org/D242 AFFECTED FILES mercurial/cmdutil.py mercurial/commands.py mercurial/context.py

D291: repair: refactor broken linkrev collection

2017-08-09 Thread lothiraldan (Boris Feld)
lothiraldan added a comment. LGTM REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D291 To: durham, #hg-reviewers Cc: lothiraldan, mercurial-devel ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org

D292: repair: move manifest strip to a separate function

2017-08-09 Thread lothiraldan (Boris Feld)
lothiraldan added a comment. LGTM REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D292 To: durham, #hg-reviewers Cc: lothiraldan, mercurial-devel ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org

D288: bundlerepo: move temp bundle creation to a separate function

2017-08-09 Thread lothiraldan (Boris Feld)
lothiraldan added a comment. LGTM REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D288 To: durham, #hg-reviewers Cc: lothiraldan, mercurial-devel ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org

D246: obsolete: rename precursor into predecessor in obsolete docstrings

2017-08-09 Thread lothiraldan (Boris Feld)
lothiraldan updated this revision to Diff 708. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D246?vs=702=708 REVISION DETAIL https://phab.mercurial-scm.org/D246 AFFECTED FILES mercurial/obsolete.py CHANGE DETAILS diff --git a/mercurial/obsolete.py

D291: repair: refactor broken linkrev collection

2017-08-09 Thread durham (Durham Goode)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG6626d12e7a85: repair: refactor broken linkrev collection (authored by durham). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D291?vs=661=692 REVISION DETAIL

D239: context: rename unstable into orphan

2017-08-09 Thread lothiraldan (Boris Feld)
This revision was automatically updated to reflect the committed changes. lothiraldan marked an inline comment as done. Closed by commit rHGf163edb45c47: context: rename unstable into orphan (authored by lothiraldan). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D292: repair: move manifest strip to a separate function

2017-08-09 Thread durham (Durham Goode)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG86ea201eaeb9: repair: move manifest strip to a separate function (authored by durham). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D292?vs=662=693 REVISION

D241: context: rename bumped into phasedivergent

2017-08-09 Thread lothiraldan (Boris Feld)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG8413cbeae275: context: rename bumped into phasedivergent (authored by lothiraldan). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D241?vs=622=697 REVISION

D244: obsolete: rename _addprecursors into _addpredecessors

2017-08-09 Thread lothiraldan (Boris Feld)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG32d4f815c4f4: obsolete: rename _addprecursors into _addpredecessors (authored by lothiraldan). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D244?vs=589=698

D240: context: rename divergent into contentdivergent

2017-08-09 Thread lothiraldan (Boris Feld)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG8b2d7684407b: context: rename divergent into contentdivergent (authored by lothiraldan). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D240?vs=621=696 REVISION

D299: pycompat: introduce a wrapper for __builtins__.{raw_,}input()

2017-08-09 Thread yuja (Yuya Nishihara)
yuja added inline comments. INLINE COMMENTS > pycompat.py:84 > +setattr(sys, stream, noclosetextio(s)) > +return bytestr(input(*args, **kwargs)) > +finally: Needs to specify encoding because user input may contain non-ascii characters. Perhaps it should

D244: obsolete: rename _addprecursors into _addpredecessors

2017-08-09 Thread lothiraldan (Boris Feld)
lothiraldan updated this revision to Diff 706. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D244?vs=698=706 REVISION DETAIL https://phab.mercurial-scm.org/D244 AFFECTED FILES mercurial/obsolete.py CHANGE DETAILS diff --git a/mercurial/obsolete.py

D245: obsstore: rename precursors into predecessors

2017-08-09 Thread lothiraldan (Boris Feld)
lothiraldan updated this revision to Diff 707. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D245?vs=701=707 REVISION DETAIL https://phab.mercurial-scm.org/D245 AFFECTED FILES mercurial/obsolete.py mercurial/obsutil.py CHANGE DETAILS diff --git

D243: obsmarker: rename precnode into prednode

2017-08-09 Thread lothiraldan (Boris Feld)
lothiraldan updated this revision to Diff 705. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D243?vs=699=705 REVISION DETAIL https://phab.mercurial-scm.org/D243 AFFECTED FILES mercurial/cmdutil.py mercurial/obsutil.py CHANGE DETAILS diff --git

D242: context: rename troubled into isunstable

2017-08-09 Thread lothiraldan (Boris Feld)
lothiraldan updated this revision to Diff 704. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D242?vs=700=704 REVISION DETAIL https://phab.mercurial-scm.org/D242 AFFECTED FILES mercurial/cmdutil.py mercurial/commands.py mercurial/context.py

D247: obsutil: rename allprecursors into allpredecessors

2017-08-09 Thread lothiraldan (Boris Feld)
lothiraldan updated this revision to Diff 709. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D247?vs=703=709 REVISION DETAIL https://phab.mercurial-scm.org/D247 AFFECTED FILES contrib/phabricator.py mercurial/obsolete.py mercurial/obsutil.py

D30: merge: Removed sorting in casefolding detection, for a slight performance win

2017-08-09 Thread quark (Jun Wu)
quark added a comment. @durin42 The case-folding collision might be a small feature that Rust is meaningful. INLINE COMMENTS > merge.py:765 > foldprefix = unfoldprefix = lastfull = '' > -for fold, f in sorted(foldmap.items()): > +for fold, f in foldmap.items(): > if

D98: revset: support reading aliases from a .hgrevsets file

2017-08-09 Thread quark (Jun Wu)
quark added a comment. Security-wise, the "shelling out revset" seems hard to solve cleanly. By having `%include ../hgrc` in `$REPO/.hg/hgrc`, we could already read config in working copy for a trusted repo today. It seems to me that a lot of security work (ex. knowing the "origin" when

D219: morestatus: move fb extension to core by plugging to `hg status --verbose`

2017-08-09 Thread pulkit (Pulkit Goyal)
pulkit added a comment. In https://phab.mercurial-scm.org/D219#4343, @durin42 wrote: > I'm still a tiny bit worried about potential confusion between --terse and --verbose (in that they're not opposites), but I'm also fine with this. I'll take it in a couple of days if I don't hear any

Re: [PATCH 4 of 8] template: add minimal obsfate template function

2017-08-09 Thread Yuya Nishihara
On Tue, 08 Aug 2017 18:48:08 +0200, Boris Feld wrote: > On Wed, 2017-08-09 at 00:19 +0900, Yuya Nishihara wrote: > > On Mon, 07 Aug 2017 16:56:23 +0200, Boris Feld wrote: > > > +@templatekeyword("succsandmarkers") > > > +def showsuccsandmarkers(repo, ctx, **args): > > > +"""Returns a list of

D279: tests: fix test-notify.t to use $PYTHON

2017-08-09 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGfa9f7b5d4397: tests: fix test-notify.t to use $PYTHON (authored by durin42). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D279?vs=644=674 REVISION DETAIL

D272: bundle2: convert ints to strings using pycompat.bytestring()

2017-08-09 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG373ca5103ba8: bundle2: convert ints to strings using pycompat.bytestring() (authored by durin42). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D272?vs=637=667

D274: obsutil: defend against succsmarkers() returning None

2017-08-09 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG888f24810ea2: obsutil: defend against succsmarkers() returning None (authored by durin42). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D274?vs=639=669

D275: ui: refactor extractchoices so it doesn't break on Python 3

2017-08-09 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGd880a6bcef2f: ui: refactor extractchoices so it doesn't break on Python 3 (authored by durin42). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D275?vs=640=670

D273: changegroup: more **kwargs

2017-08-09 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG672ad4f3bb84: changegroup: more **kwargs (authored by durin42). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D273?vs=638=668 REVISION DETAIL

D276: i18n: fix check-translation.py to be less broken on Python 3

2017-08-09 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG29238dbf718e: i18n: fix check-translation.py to be less broken on Python 3 (authored by durin42). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D276?vs=641=671

D277: dagparser: make print statement in doctest Py3 portable

2017-08-09 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGc91013452b33: dagparser: make print statement in doctest Py3 portable (authored by durin42). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D277?vs=642=672

D270: tests: fix up test-run-tests failures on Python 3.6

2017-08-09 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG2e43c5cd57a7: tests: fix up test-run-tests failures on Python 3.6 (authored by durin42). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D270?vs=635=666 REVISION

D278: tests: make test-highlight code portable to python3

2017-08-09 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG65de152ba375: tests: make test-highlight code portable to python3 (authored by durin42). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D278?vs=643=673 REVISION

D296: extensions: if on py3 and propname is a bytestr, decode as ascii

2017-08-09 Thread yuja (Yuya Nishihara)
yuja added inline comments. INLINE COMMENTS > extensions.py:388 > +if pycompat.ispy3 and isinstance(propname, bytes): > +propname = propname.decode('ascii') > assert callable(wrapper) `pycompat.sysstr()` ? > extensions.py:401 > raise AttributeError( >

D271: obsolete: use bytestr() instead of str() so the node is bytes on py3

2017-08-09 Thread yuja (Yuya Nishihara)
yuja added inline comments. INLINE COMMENTS > obsolete.py:587 > > -marker = (str(prec), tuple(succs), int(flag), metadata, date, > parents) > +prec = bytes(pycompat.bytestr(prec)) > +marker = (prec, tuple(succs), int(flag), metadata, date, parents) Why can't this be

D303: bundle2: fix transaction availability detection

2017-08-09 Thread lothiraldan (Boris Feld)
lothiraldan created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Changeset https://phab.mercurial-scm.org/rHG5fc4ddfbe62601613ad68bcfa194c209ccf2fd30 introduce more complex logic around 'bundleoperation.gettransaction'.

D301: scmutil: use util.shellquote instead of %r

2017-08-09 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Changes some output, but also resolves differences with Python 3. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D301 AFFECTED FILES

D294: tests: clean up many print statements to be print functions instead

2017-08-09 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D294 AFFECTED FILES tests/test-commit-interactive-curses.t tests/test-commit-multiple.t

D271: obsolete: use bytes() instead of str() so the node is bytes on py3

2017-08-09 Thread durin42 (Augie Fackler)
durin42 marked an inline comment as done. durin42 added inline comments. INLINE COMMENTS > yuja wrote in obsolete.py:587 > Why can't this be just `bytes(prec)` ? > > I don't think `str(prec).encode('ascii')` is valid for binary node id. I swear that didn't work before. But it does work, so

D300: python3: whitelist two more passing tests

2017-08-09 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D300 AFFECTED FILES contrib/python3-whitelist CHANGE DETAILS diff --git a/contrib/python3-whitelist

D302: python3: whitelist another *13* tests that now pass

2017-08-09 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D302 AFFECTED FILES contrib/python3-whitelist CHANGE DETAILS diff --git a/contrib/python3-whitelist

D299: pycompat: introduce a wrapper for __builtins__.{raw_,}input()

2017-08-09 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY In order to make this work, we have to wrap the io streams in a TextIOWrapper so that __builtins__.input() can do unicode IO on Python 3. We can't just

D294: tests: clean up many print statements to be print functions instead

2017-08-09 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG24849d53697d: tests: clean up many print statements to be print functions instead (authored by durin42). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D295: extensions: attempt to use non-deprecated inspect method

2017-08-09 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG62fbe95075d3: extensions: attempt to use non-deprecated inspect method (authored by durin42). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D295?vs=678=690

D297: tests: update duplicateoptions test to use bytestrings everywhere

2017-08-09 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG5b2f331d0a33: tests: update duplicateoptions test to use bytestrings everywhere (authored by durin42). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D293: tests: fix simple heredoc print statements to work on Py3

2017-08-09 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG27fb986e54d0: tests: fix simple heredoc print statements to work on Py3 (authored by durin42). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D293?vs=676=688

D293: tests: fix simple heredoc print statements to work on Py3

2017-08-09 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY There are a handful left that require some more care. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D293 AFFECTED FILES

D297: tests: update duplicateoptions test to use bytestrings everywhere

2017-08-09 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Test now passes on Python 3. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D297 AFFECTED FILES tests/test-duplicateoptions.py

D295: extensions: attempt to use non-deprecated inspect method

2017-08-09 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Avoids some deprecation warnings when extension loading breaks. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D295 AFFECTED FILES

D296: extensions: if on py3 and propname is a bytestr, decode as ascii

2017-08-09 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Property names are unicodes on Python 3. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D296 AFFECTED FILES

D298: python3: whitelist two more passing tests

2017-08-09 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D298 AFFECTED FILES contrib/python3-whitelist CHANGE DETAILS diff --git a/contrib/python3-whitelist

D271: obsolete: use bytes() instead of str() so the node is bytes on py3

2017-08-09 Thread durin42 (Augie Fackler)
durin42 updated this revision to Diff 675. durin42 retitled this revision from "obsolete: use bytestr() instead of str() so the node is bytes on py3" to "obsolete: use bytes() instead of str() so the node is bytes on py3". REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D271: obsolete: use bytes() instead of str() so the node is bytes on py3

2017-08-09 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. durin42 marked an inline comment as done. Closed by commit rHG388901a15bfa: obsolete: use bytes() instead of str() so the node is bytes on py3 (authored by durin42). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE