D2280: remotenames: port partway to python3

2018-02-16 Thread dlax (Denis Laxalde)
dlax added inline comments. INLINE COMMENTS > remotenames.py:30 > +import collections > +dictmixin = collections.MutableMapping > `collections.MutableMapping` exists on Python2 as well (from 2.6 apparently), can't we use it? REPOSITORY rHG Mercurial REVISION DETAIL

D2282: util: extract all date-related utils in utils/dateutil module

2018-02-16 Thread lothiraldan (Boris Feld)
lothiraldan added a comment. In https://phab.mercurial-scm.org/D2282#37751, @dlax wrote: > Having both a `util` module and a `utils` package looks weird. > Have you considered moving `util.py` into `util/__init__.py` and then adding new modules under `util` package? I have but

D2282: util: extract all date-related utils in utils/dateutil module

2018-02-16 Thread dlax (Denis Laxalde)
dlax added a comment. Having both a `util` module and a `utils` package looks weird. Have you considered moving `util.py` into `util/__init__.py` and then adding new modules under `util` package? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2282 To:

D2294: hgweb: open server logs in binary mode

2018-02-16 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This is consistent with when we're logging to stdout, so we don't have to do something annoyingly complicated in the logging infrastructure. REPOSITORY rHG

D2292: scmutil: bytes-ify IOErrors before wrapping them in abort message

2018-02-16 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2292 AFFECTED FILES mercurial/scmutil.py CHANGE DETAILS diff --git a/mercurial/scmutil.py

D2295: py3: get bytes-repr of network errors portably

2018-02-16 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This resolves a lot of weird issues in Python 3 around error strings. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2295 AFFECTED

D2296: py3: whitelist test-pull-http.t

2018-02-16 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a reviewer: pulkit. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY There's a lot of work left to do on network-related stuff, but I at least got one more test passing. REPOSITORY rHG Mercurial

D2290: printenv: port to python3

2018-02-16 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2290 AFFECTED FILES tests/printenv.py CHANGE DETAILS diff --git a/tests/printenv.py

D2293: tests: add some b prefixes in test-http-bundle1.t

2018-02-16 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY 1. skip-blame just some b prefixes REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2293 AFFECTED FILES tests/test-http-bundle1.t

D2291: hgweb: correctly bytes-ify status, not string-ify

2018-02-16 Thread durin42 (Augie Fackler)
durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2291 AFFECTED FILES mercurial/hgweb/request.py CHANGE DETAILS diff --git

D2281: py3: whitelist another eight passing tests

2018-02-16 Thread durin42 (Augie Fackler)
durin42 updated this revision to Diff 5791. durin42 retitled this revision from "py3: whitelist another six passing tests" to "py3: whitelist another eight passing tests". REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2281?vs=5769=5791 REVISION DETAIL

D2278: bundle: updates the help text for hg bundle (issue5744) [bugzilla]

2018-02-16 Thread yuja (Yuya Nishihara)
yuja requested changes to this revision. yuja added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > commands.py:1165 > (or --base null). Otherwise, hg assumes the destination will have > -all the nodes you specify with --base parameters. Otherwise, hg >

[PATCH] debuginstall: do not parse editor command in posix way on Windows

2018-02-16 Thread Yuya Nishihara
# HG changeset patch # User Yuya Nishihara # Date 1518840784 -32400 # Sat Feb 17 13:13:04 2018 +0900 # Node ID b42f9a63030fee00568add7aa5a5ff983fbcd06d # Parent c9f30dcc3f43793088c99c3acef7db12857cc2cc debuginstall: do not parse editor command in posix way on Windows An

mercurial@36239: 4 new changesets

2018-02-16 Thread Mercurial Commits
4 new changesets in mercurial: https://www.mercurial-scm.org/repo/hg/rev/564dec70b50c changeset: 36236:564dec70b50c user:Kyle Lippincott date:Thu Jan 04 16:29:07 2018 -0800 summary: debugcommands: print out the editor that was searched for (post

D2281: py3: whitelist another eight passing tests

2018-02-16 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGc9f30dcc3f43: py3: whitelist another eight passing tests (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2281?vs=5791=5793

D2280: remotenames: port partway to python3 by using collections.MutableMapping

2018-02-16 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG25a7d2761898: remotenames: port partway to python3 by using collections.MutableMapping (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

[Bug 5795] New: Server side evolve crashes with current default branch

2018-02-16 Thread mercurial-bugs
https://bz.mercurial-scm.org/show_bug.cgi?id=5795 Bug ID: 5795 Summary: Server side evolve crashes with current default branch Product: Mercurial Version: default branch Hardware: All OS: All Status: UNCONFIRMED

[Bug 5793] New: Fix for #5675 made it impossible to share repositories containing external subrepositories

2018-02-16 Thread mercurial-bugs
https://bz.mercurial-scm.org/show_bug.cgi?id=5793 Bug ID: 5793 Summary: Fix for #5675 made it impossible to share repositories containing external subrepositories Product: Mercurial Version: 4.4 Hardware: All

D2277: remotenames: don't use the default value of logfmt for namespaces

2018-02-16 Thread yuja (Yuya Nishihara)
yuja requested changes to this revision. yuja added a comment. This revision now requires changes to proceed. Looks good, but perhaps we can delete `logname` superseded by `logfmt`. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2277 To: pulkit, #hg-reviewers,

D2282: util: extract all date-related utils in utils/dateutil module

2018-02-16 Thread lothiraldan (Boris Feld)
lothiraldan added a subscriber: durin42. lothiraldan added a comment. In https://phab.mercurial-scm.org/D2282#37757, @dlax wrote: > lothiraldan (Boris Feld) wrote: > > > I have but I'm always very cautious when creating a new package with the > > name of an old module.

Re: [PATCH 1 of 2] gitweb: make span.age CSS selector more specific

2018-02-16 Thread Yuya Nishihara
On Thu, 15 Feb 2018 22:38:01 +0800, Anton Shestakov wrote: > # HG changeset patch > # User Anton Shestakov > # Date 1518699931 -28800 > # Thu Feb 15 21:05:31 2018 +0800 > # Node ID e4803e41e488aa52e56280bfd6bce4156dc402a6 > # Parent

D2278: bundle: updates the help text for hg bundle (issue5744) [bugzilla]

2018-02-16 Thread yuja (Yuya Nishihara)
yuja requested changes to this revision. yuja added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > commands.py:1161 > +Generate a bundle file containing data to be added to the > +destination/[DEST] which is probably a repository. > "probably a

D2282: util: extract all date-related utils in utils/dateutil module

2018-02-16 Thread dlax (Denis Laxalde)
dlax added a comment. lothiraldan (Boris Feld) wrote: > I have but I'm always very cautious when creating a new package with the > name of an old module. .pyc/.pycache files may still be there both for > Mercurial developers and for Mercurial users using their deb/rpm package. >

D2277: remotenames: don't use the default value of logfmt for namespaces

2018-02-16 Thread pulkit (Pulkit Goyal)
pulkit updated this revision to Diff 5777. pulkit edited the summary of this revision. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2277?vs=5756=5777 REVISION DETAIL https://phab.mercurial-scm.org/D2277 AFFECTED FILES hgext/remotenames.py

D2278: bundle: updates the help text for hg bundle (issue5744) [bugzilla]

2018-02-16 Thread khanchi97 (Sushil khanchi)
khanchi97 updated this revision to Diff 5778. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2278?vs=5760=5778 REVISION DETAIL https://phab.mercurial-scm.org/D2278 AFFECTED FILES mercurial/commands.py CHANGE DETAILS diff --git

D2286: tests: actually check that HGDEMANDIMPORT=disable disables demandimport

2018-02-16 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY At the point in the test where we were checking that the 'node' got eagerly loaded, it had already been loaded (via the pvec module), so our check wasn't

D2282: util: extract all date-related utils in utils/dateutil module

2018-02-16 Thread martinvonz (Martin von Zweigbergk)
martinvonz added a comment. In https://phab.mercurial-scm.org/D2282#37758, @lothiraldan wrote: > In https://phab.mercurial-scm.org/D2282#37757, @dlax wrote: > > > lothiraldan (Boris Feld) wrote: > > > > > I have but I'm always very cautious when creating a new package with the >

D2282: util: extract all date-related utils in utils/dateutil module

2018-02-16 Thread durin42 (Augie Fackler)
durin42 added a comment. In https://phab.mercurial-scm.org/D2282#37774, @martinvonz wrote: > In https://phab.mercurial-scm.org/D2282#37758, @lothiraldan wrote: > > > In https://phab.mercurial-scm.org/D2282#37757, @dlax wrote: > > > > > lothiraldan (Boris Feld) wrote: > > > > >

D2288: pvec: delete module

2018-02-16 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY The pvec module was introduced in https://phab.mercurial-scm.org/rHG0d175ac527c1d1b51b1de6dff25907ae377b9280 (pvec: introduce pvecs, 2012-03-12), but it

D2287: tests: avoid referring to pvec in demandimport test

2018-02-16 Thread martinvonz (Martin von Zweigbergk)
martinvonz created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY I'm going to delete pvec, so this patch replaces it by the error module in the demandimport test (any module works). However, since the error module had

[Bug 5794] New: lfs doesn't play well with narrow

2018-02-16 Thread mercurial-bugs
https://bz.mercurial-scm.org/show_bug.cgi?id=5794 Bug ID: 5794 Summary: lfs doesn't play well with narrow Product: Mercurial Version: default branch Hardware: PC OS: Linux Status: UNCONFIRMED Severity:

D2013: commit: allow --no-secret to override phases.new-commit setting

2018-02-16 Thread martinvonz (Martin von Zweigbergk)
martinvonz added a comment. In https://phab.mercurial-scm.org/D2013#34509, @martinvonz wrote: > In https://phab.mercurial-scm.org/D2013#34320, @spectral wrote: > > > In https://phab.mercurial-scm.org/D2013#33867, @martinvonz wrote: > > > > > I wonder if we should instead have a

D1919: phabricator: specify API tokens per host, rather than per repo

2018-02-16 Thread tom.prince (Tom Prince)
tom.prince added a comment. Personally, I don't have arc installed, so I'd prefer putting the auth information in mercurial rather than arc specific places (this is what is stored in `.arcrc` I think). It would make sense to support `.arcrc` as well, though. It would make sense to read

D2289: date: fix parsing months

2018-02-16 Thread martinvonz (Martin von Zweigbergk)
martinvonz added a comment. Queuing for stable REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2289 To: quark, #hg-reviewers, martinvonz Cc: mercurial-devel ___ Mercurial-devel mailing list

D2289: date: fix parsing months

2018-02-16 Thread quark (Jun Wu)
quark created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY Thanks nemo for discovering this on #mercurial IRC channel. TEST PLAN Add a test. It fails before this patch: + hg: parse error: invalid date: 'Feb 2018'

D1919: phabricator: specify API tokens per host, rather than per repo

2018-02-16 Thread durin42 (Augie Fackler)
durin42 added a comment. I generally agree we should support a non-arc option, I'm happy to not have arc on my machines anymore. I'll meditate on this over the long weekend. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D1919 To: tom.prince,

D2048: utils: copy util.py as utils/dateutil.py

2018-02-16 Thread durin42 (Augie Fackler)
durin42 added a comment. In https://phab.mercurial-scm.org/D2048#37691, @lothiraldan wrote: > I've resent the series as https://phab.mercurial-scm.org/D2282 as a single changeset. I've included a note for extension authors with a link to the old series to more easily bisect the

D2279: node: make bin() be a wrapper instead of just an alias

2018-02-16 Thread durin42 (Augie Fackler)
durin42 updated this revision to Diff 5784. durin42 edited the summary of this revision. Herald added a reviewer: indygreg. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2279?vs=5761=5784 REVISION DETAIL https://phab.mercurial-scm.org/D2279 AFFECTED

D2279: node: make bin() be a wrapper instead of just an alias

2018-02-16 Thread durin42 (Augie Fackler)
durin42 added a comment. In https://phab.mercurial-scm.org/D2279#37680, @martinvonz wrote: > Also make this commit back out https://phab.mercurial-scm.org/rHG30d0cb279bacf791577e90124b2a94018588f0b8? done REPOSITORY rHG Mercurial REVISION DETAIL

D2279: node: make bin() be a wrapper instead of just an alias

2018-02-16 Thread durin42 (Augie Fackler)
This revision was automatically updated to reflect the committed changes. Closed by commit rHGaba1d578c97f: node: make bin() be a wrapper instead of just an alias (authored by durin42, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

Re: [PATCH 3 of 3] help: use cmdutil.parsealiases() to resolve command name

2018-02-16 Thread Augie Fackler
On Thu, Feb 15, 2018 at 10:42:38PM +0900, Yuya Nishihara wrote: > # HG changeset patch > # User Yuya Nishihara > # Date 1515380983 -32400 > # Mon Jan 08 12:09:43 2018 +0900 > # Node ID 74f1b48042c6595ae49aaee050d1eac3b672fe6d > # Parent

Re: [PATCH 6 of 6] cmdutil: expand filename format string by templater (BC)

2018-02-16 Thread Augie Fackler
On Thu, Feb 15, 2018 at 10:18:44PM +0900, Yuya Nishihara wrote: > # HG changeset patch > # User Yuya Nishihara > # Date 1515293587 -32400 > # Sun Jan 07 11:53:07 2018 +0900 > # Node ID 437212580debfa26ee266598f64139b4df5a9cfd > # Parent

D2288: pvec: delete module

2018-02-16 Thread martinvonz (Martin von Zweigbergk)
martinvonz updated this revision to Diff 5789. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2288?vs=5781=5789 REVISION DETAIL https://phab.mercurial-scm.org/D2288 AFFECTED FILES mercurial/debugcommands.py mercurial/pvec.py

D2287: tests: avoid referring to pvec in demandimport test

2018-02-16 Thread martinvonz (Martin von Zweigbergk)
martinvonz added a comment. In https://phab.mercurial-scm.org/D2287#37835, @durin42 wrote: > +1 on decoupling this from pvec, but per discussion on https://phab.mercurial-scm.org/D2288 revise commit message per pvec's (temporary) stay of execution? Done REPOSITORY rHG

D1808: debugcommands: print out the editor that was searched for (post shlexsplit)

2018-02-16 Thread spectral (Kyle Lippincott)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG04e81ae47066: debugcommands: print out the editor that was searched for (post shlexsplit) (authored by spectral, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2288: pvec: delete module

2018-02-16 Thread durin42 (Augie Fackler)
durin42 added a comment. SoI actually have an idea involving pvec and obsmarker metadata in `hg export` output. I'll work on fixing any problems in pvec, can we keep it around a little longer? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2288 To:

D2288: pvec: delete module

2018-02-16 Thread martinvonz (Martin von Zweigbergk)
martinvonz added a comment. In https://phab.mercurial-scm.org/D2288#37819, @durin42 wrote: > SoI actually have an idea involving pvec and obsmarker metadata in `hg export` output. I'll work on fixing any problems in pvec, can we keep it around a little longer? Definitely. It

D2280: remotenames: port partway to python3 by using collections.MutableMapping

2018-02-16 Thread durin42 (Augie Fackler)
durin42 updated this revision to Diff 5785. durin42 marked an inline comment as done. durin42 retitled this revision from "remotenames: port partway to python3" to "remotenames: port partway to python3 by using collections.MutableMapping". REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2280: remotenames: port partway to python3 by using collections.MutableMapping

2018-02-16 Thread durin42 (Augie Fackler)
durin42 added a comment. Updated REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2280 To: durin42, #hg-reviewers Cc: dlax, yuja, mercurial-devel ___ Mercurial-devel mailing list Mercurial-devel@mercurial-scm.org

D2287: tests: avoid referring to pvec in demandimport test

2018-02-16 Thread durin42 (Augie Fackler)
durin42 added a comment. +1 on decoupling this from pvec, but per discussion on https://phab.mercurial-scm.org/D2288 revise commit message per pvec's (temporary) stay of execution? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2287 To: martinvonz,

D2289: date: fix parsing months

2018-02-16 Thread quark (Jun Wu)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG4878f45c: date: fix parsing months (authored by quark, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2289?vs=5782=5786 REVISION DETAIL

D2286: tests: actually check that HGDEMANDIMPORT=disable disables demandimport

2018-02-16 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG02bb24cf6fd9: tests: actually check that HGDEMANDIMPORT=disable disables demandimport (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

D2287: tests: avoid referring to pvec in demandimport test

2018-02-16 Thread martinvonz (Martin von Zweigbergk)
This revision was automatically updated to reflect the committed changes. Closed by commit rHG0ae9fe9952b5: tests: avoid referring to pvec in demandimport test (authored by martinvonz, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE

mercurial@36235: 4 new changesets (1 on stable)

2018-02-16 Thread Mercurial Commits
4 new changesets (1 on stable) in mercurial: https://www.mercurial-scm.org/repo/hg/rev/881596e51fca changeset: 36232:881596e51fca user:Anton Shestakov date:Thu Feb 15 21:05:31 2018 +0800 summary: gitweb: make span.age CSS selector more specific