dlax added inline comments.
INLINE COMMENTS
> remotenames.py:30
> +import collections
> +dictmixin = collections.MutableMapping
>
`collections.MutableMapping` exists on Python2 as well (from 2.6 apparently),
can't we use it?
REPOSITORY
rHG Mercurial
REVISION DETAIL
lothiraldan added a comment.
In https://phab.mercurial-scm.org/D2282#37751, @dlax wrote:
> Having both a `util` module and a `utils` package looks weird.
> Have you considered moving `util.py` into `util/__init__.py` and then
adding new modules under `util` package?
I have but
dlax added a comment.
Having both a `util` module and a `utils` package looks weird.
Have you considered moving `util.py` into `util/__init__.py` and then adding
new modules under `util` package?
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D2282
To:
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This is consistent with when we're logging to stdout, so we don't have
to do something annoyingly complicated in the logging infrastructure.
REPOSITORY
rHG
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D2292
AFFECTED FILES
mercurial/scmutil.py
CHANGE DETAILS
diff --git a/mercurial/scmutil.py
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
This resolves a lot of weird issues in Python 3 around error strings.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D2295
AFFECTED
durin42 created this revision.
Herald added a reviewer: pulkit.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
There's a lot of work left to do on network-related stuff, but I at
least got one more test passing.
REPOSITORY
rHG Mercurial
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D2290
AFFECTED FILES
tests/printenv.py
CHANGE DETAILS
diff --git a/tests/printenv.py
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
1. skip-blame just some b prefixes
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D2293
AFFECTED FILES
tests/test-http-bundle1.t
durin42 created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D2291
AFFECTED FILES
mercurial/hgweb/request.py
CHANGE DETAILS
diff --git
durin42 updated this revision to Diff 5791.
durin42 retitled this revision from "py3: whitelist another six passing tests"
to "py3: whitelist another eight passing tests".
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2281?vs=5769=5791
REVISION DETAIL
yuja requested changes to this revision.
yuja added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> commands.py:1165
> (or --base null). Otherwise, hg assumes the destination will have
> -all the nodes you specify with --base parameters. Otherwise, hg
>
# HG changeset patch
# User Yuya Nishihara
# Date 1518840784 -32400
# Sat Feb 17 13:13:04 2018 +0900
# Node ID b42f9a63030fee00568add7aa5a5ff983fbcd06d
# Parent c9f30dcc3f43793088c99c3acef7db12857cc2cc
debuginstall: do not parse editor command in posix way on Windows
An
4 new changesets in mercurial:
https://www.mercurial-scm.org/repo/hg/rev/564dec70b50c
changeset: 36236:564dec70b50c
user:Kyle Lippincott
date:Thu Jan 04 16:29:07 2018 -0800
summary: debugcommands: print out the editor that was searched for (post
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGc9f30dcc3f43: py3: whitelist another eight passing tests
(authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2281?vs=5791=5793
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG25a7d2761898: remotenames: port partway to python3 by using
collections.MutableMapping (authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://bz.mercurial-scm.org/show_bug.cgi?id=5795
Bug ID: 5795
Summary: Server side evolve crashes with current default branch
Product: Mercurial
Version: default branch
Hardware: All
OS: All
Status: UNCONFIRMED
https://bz.mercurial-scm.org/show_bug.cgi?id=5793
Bug ID: 5793
Summary: Fix for #5675 made it impossible to share repositories
containing external subrepositories
Product: Mercurial
Version: 4.4
Hardware: All
yuja requested changes to this revision.
yuja added a comment.
This revision now requires changes to proceed.
Looks good, but perhaps we can delete `logname` superseded by `logfmt`.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D2277
To: pulkit, #hg-reviewers,
lothiraldan added a subscriber: durin42.
lothiraldan added a comment.
In https://phab.mercurial-scm.org/D2282#37757, @dlax wrote:
> lothiraldan (Boris Feld) wrote:
>
> > I have but I'm always very cautious when creating a new package with the
> > name of an old module.
On Thu, 15 Feb 2018 22:38:01 +0800, Anton Shestakov wrote:
> # HG changeset patch
> # User Anton Shestakov
> # Date 1518699931 -28800
> # Thu Feb 15 21:05:31 2018 +0800
> # Node ID e4803e41e488aa52e56280bfd6bce4156dc402a6
> # Parent
yuja requested changes to this revision.
yuja added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> commands.py:1161
> +Generate a bundle file containing data to be added to the
> +destination/[DEST] which is probably a repository.
>
"probably a
dlax added a comment.
lothiraldan (Boris Feld) wrote:
> I have but I'm always very cautious when creating a new package with the
> name of an old module. .pyc/.pycache files may still be there both for
> Mercurial developers and for Mercurial users using their deb/rpm package.
>
pulkit updated this revision to Diff 5777.
pulkit edited the summary of this revision.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2277?vs=5756=5777
REVISION DETAIL
https://phab.mercurial-scm.org/D2277
AFFECTED FILES
hgext/remotenames.py
khanchi97 updated this revision to Diff 5778.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2278?vs=5760=5778
REVISION DETAIL
https://phab.mercurial-scm.org/D2278
AFFECTED FILES
mercurial/commands.py
CHANGE DETAILS
diff --git
martinvonz created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
At the point in the test where we were checking that the 'node' got
eagerly loaded, it had already been loaded (via the pvec module), so
our check wasn't
martinvonz added a comment.
In https://phab.mercurial-scm.org/D2282#37758, @lothiraldan wrote:
> In https://phab.mercurial-scm.org/D2282#37757, @dlax wrote:
>
> > lothiraldan (Boris Feld) wrote:
> >
> > > I have but I'm always very cautious when creating a new package with the
>
durin42 added a comment.
In https://phab.mercurial-scm.org/D2282#37774, @martinvonz wrote:
> In https://phab.mercurial-scm.org/D2282#37758, @lothiraldan wrote:
>
> > In https://phab.mercurial-scm.org/D2282#37757, @dlax wrote:
> >
> > > lothiraldan (Boris Feld) wrote:
> > >
> >
martinvonz created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
The pvec module was introduced in
https://phab.mercurial-scm.org/rHG0d175ac527c1d1b51b1de6dff25907ae377b9280
(pvec: introduce pvecs,
2012-03-12), but it
martinvonz created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
I'm going to delete pvec, so this patch replaces it by the error
module in the demandimport test (any module works). However, since the
error module had
https://bz.mercurial-scm.org/show_bug.cgi?id=5794
Bug ID: 5794
Summary: lfs doesn't play well with narrow
Product: Mercurial
Version: default branch
Hardware: PC
OS: Linux
Status: UNCONFIRMED
Severity:
martinvonz added a comment.
In https://phab.mercurial-scm.org/D2013#34509, @martinvonz wrote:
> In https://phab.mercurial-scm.org/D2013#34320, @spectral wrote:
>
> > In https://phab.mercurial-scm.org/D2013#33867, @martinvonz wrote:
> >
> > > I wonder if we should instead have a
tom.prince added a comment.
Personally, I don't have arc installed, so I'd prefer putting the auth
information in mercurial rather than arc specific places (this is what is
stored in `.arcrc` I think). It would make sense to support `.arcrc` as well,
though.
It would make sense to read
martinvonz added a comment.
Queuing for stable
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D2289
To: quark, #hg-reviewers, martinvonz
Cc: mercurial-devel
___
Mercurial-devel mailing list
quark created this revision.
Herald added a subscriber: mercurial-devel.
Herald added a reviewer: hg-reviewers.
REVISION SUMMARY
Thanks nemo for discovering this on #mercurial IRC channel.
TEST PLAN
Add a test. It fails before this patch:
+ hg: parse error: invalid date: 'Feb 2018'
durin42 added a comment.
I generally agree we should support a non-arc option, I'm happy to not have
arc on my machines anymore.
I'll meditate on this over the long weekend.
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D1919
To: tom.prince,
durin42 added a comment.
In https://phab.mercurial-scm.org/D2048#37691, @lothiraldan wrote:
> I've resent the series as https://phab.mercurial-scm.org/D2282 as a single
changeset. I've included a note for extension authors with a link to the old
series to more easily bisect the
durin42 updated this revision to Diff 5784.
durin42 edited the summary of this revision.
Herald added a reviewer: indygreg.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2279?vs=5761=5784
REVISION DETAIL
https://phab.mercurial-scm.org/D2279
AFFECTED
durin42 added a comment.
In https://phab.mercurial-scm.org/D2279#37680, @martinvonz wrote:
> Also make this commit back out
https://phab.mercurial-scm.org/rHG30d0cb279bacf791577e90124b2a94018588f0b8?
done
REPOSITORY
rHG Mercurial
REVISION DETAIL
This revision was automatically updated to reflect the committed changes.
Closed by commit rHGaba1d578c97f: node: make bin() be a wrapper instead of just
an alias (authored by durin42, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
On Thu, Feb 15, 2018 at 10:42:38PM +0900, Yuya Nishihara wrote:
> # HG changeset patch
> # User Yuya Nishihara
> # Date 1515380983 -32400
> # Mon Jan 08 12:09:43 2018 +0900
> # Node ID 74f1b48042c6595ae49aaee050d1eac3b672fe6d
> # Parent
On Thu, Feb 15, 2018 at 10:18:44PM +0900, Yuya Nishihara wrote:
> # HG changeset patch
> # User Yuya Nishihara
> # Date 1515293587 -32400
> # Sun Jan 07 11:53:07 2018 +0900
> # Node ID 437212580debfa26ee266598f64139b4df5a9cfd
> # Parent
martinvonz updated this revision to Diff 5789.
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2288?vs=5781=5789
REVISION DETAIL
https://phab.mercurial-scm.org/D2288
AFFECTED FILES
mercurial/debugcommands.py
mercurial/pvec.py
martinvonz added a comment.
In https://phab.mercurial-scm.org/D2287#37835, @durin42 wrote:
> +1 on decoupling this from pvec, but per discussion on
https://phab.mercurial-scm.org/D2288 revise commit message per pvec's
(temporary) stay of execution?
Done
REPOSITORY
rHG
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG04e81ae47066: debugcommands: print out the editor that was
searched for (post shlexsplit) (authored by spectral, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
durin42 added a comment.
SoI actually have an idea involving pvec and obsmarker metadata in `hg
export` output. I'll work on fixing any problems in pvec, can we keep it around
a little longer?
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D2288
To:
martinvonz added a comment.
In https://phab.mercurial-scm.org/D2288#37819, @durin42 wrote:
> SoI actually have an idea involving pvec and obsmarker metadata in `hg
export` output. I'll work on fixing any problems in pvec, can we keep it around
a little longer?
Definitely. It
durin42 updated this revision to Diff 5785.
durin42 marked an inline comment as done.
durin42 retitled this revision from "remotenames: port partway to python3" to
"remotenames: port partway to python3 by using collections.MutableMapping".
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
durin42 added a comment.
Updated
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D2280
To: durin42, #hg-reviewers
Cc: dlax, yuja, mercurial-devel
___
Mercurial-devel mailing list
Mercurial-devel@mercurial-scm.org
durin42 added a comment.
+1 on decoupling this from pvec, but per discussion on
https://phab.mercurial-scm.org/D2288 revise commit message per pvec's
(temporary) stay of execution?
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D2287
To: martinvonz,
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG4878f45c: date: fix parsing months (authored by quark,
committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
https://phab.mercurial-scm.org/D2289?vs=5782=5786
REVISION DETAIL
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG02bb24cf6fd9: tests: actually check that
HGDEMANDIMPORT=disable disables demandimport (authored by martinvonz, committed
by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit rHG0ae9fe9952b5: tests: avoid referring to pvec in
demandimport test (authored by martinvonz, committed by ).
REPOSITORY
rHG Mercurial
CHANGES SINCE LAST UPDATE
4 new changesets (1 on stable) in mercurial:
https://www.mercurial-scm.org/repo/hg/rev/881596e51fca
changeset: 36232:881596e51fca
user:Anton Shestakov
date:Thu Feb 15 21:05:31 2018 +0800
summary: gitweb: make span.age CSS selector more specific
54 matches
Mail list logo