Re: [PATCH] mdiff: split on unicode character boundaries when shortening function name

Josef 'Jeff' Sipek wrote: > # HG changeset patch > # User Josef 'Jeff' Sipek > # Date 1519251311 18000 > # Wed Feb 21 17:15:11 2018 -0500 > # Node ID b99df94fdd4813e0ce538a8caa682802da4a6cb2 > # Parent 106872aa15af9919220705ed72c78459774e1575 > mdiff: split on unicode character boundaries wh

D2377: util: add a file object proxy that can read at most N bytes

lothiraldan accepted this revision. lothiraldan added a comment. LGTM REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2377 To: indygreg, #hg-reviewers, lothiraldan Cc: lothiraldan, mercurial-devel ___ Mercurial-devel ma

Re: [PATCH STABLE] graphlog: document what "_" and "*" mean

LGTM On 22/02/2018 08:34, Anton Shestakov wrote: # HG changeset patch # User Anton Shestakov # Date 1519283924 -28800 # Thu Feb 22 15:18:44 2018 +0800 # Branch stable # Node ID a1b8de1983b1c5421f7c7195e01b20df5306500a # Parent c19e66dacaa184feba31136c18a369ba995ddfe4 graphlog: document w

[PATCH V2] patches: release the GIL while applying the patch

# HG changeset patch # User Boris Feld # Date 1517839431 -3600 # Mon Feb 05 15:03:51 2018 +0100 # Node ID 585005c9c4901f4f94847e8637fbc58cc5b29c56 # Parent 0c34cb461a1ea5d3f8e1300e0b8bc16ed8fa8802 # EXP-Topic parallel-patching # Available At https://bitbucket.org/octobus/mercurial-devel/ #

Re: [PATCH STABLE] graphlog: document what "_" and "*" mean

On Thu, 22 Feb 2018 15:34:03 +0800, Anton Shestakov wrote: > # HG changeset patch > # User Anton Shestakov > # Date 1519283924 -28800 > # Thu Feb 22 15:18:44 2018 +0800 > # Branch stable > # Node ID a1b8de1983b1c5421f7c7195e01b20df5306500a > # Parent c19e66dacaa184feba31136c18a369ba995ddfe4

Re: [PATCH] help: fix wording describing SSH requirements

On Wed, 21 Feb 2018 17:51:08 -0500, Josef 'Jeff' Sipek wrote: > # HG changeset patch > # User Josef 'Jeff' Sipek > # Date 1519249869 18000 > # Wed Feb 21 16:51:09 2018 -0500 > # Node ID 106872aa15af9919220705ed72c78459774e1575 > # Parent c8891cc3fa9ec855a3bdefd3dd759d19927c6b85 > help: fix w

Re: [PATCH] mdiff: split on unicode character boundaries when shortening function name

On Thu, 22 Feb 2018 09:01:14 +0100, Denis Laxalde wrote: > Josef 'Jeff' Sipek wrote: > > # HG changeset patch > > # User Josef 'Jeff' Sipek > > # Date 1519251311 18000 > > # Wed Feb 21 17:15:11 2018 -0500 > > # Node ID b99df94fdd4813e0ce538a8caa682802da4a6cb2 > > # Parent 106872aa15af9919220

Re: [PATCH V2] patches: release the GIL while applying the patch

On Thu, 22 Feb 2018 12:10:12 +0100, Boris Feld wrote: > # HG changeset patch > # User Boris Feld > # Date 1517839431 -3600 > # Mon Feb 05 15:03:51 2018 +0100 > # Node ID 585005c9c4901f4f94847e8637fbc58cc5b29c56 > # Parent 0c34cb461a1ea5d3f8e1300e0b8bc16ed8fa8802 > # EXP-Topic parallel-patchi

Re: [PATCH 2 of 2] perfbranchmap: allow to select the filter to benchmark

On Wed, 21 Feb 2018 15:38:12 +0100, Boris Feld wrote: > # HG changeset patch > # User Boris Feld > # Date 1519209792 -3600 > # Wed Feb 21 11:43:12 2018 +0100 > # Node ID ddab5cae846a3e05ec4b951472e562fce06301ea > # Parent f40e09835c645bbc0b535228ac743d84e952f866 > # EXP-Topic filter-perfbran

Re: [PATCH V2] patches: release the GIL while applying the patch

On Thu, 22 Feb 2018 12:10:12 +0100, Boris Feld wrote: > # HG changeset patch > # User Boris Feld > # Date 1517839431 -3600 > # Mon Feb 05 15:03:51 2018 +0100 > # Node ID 585005c9c4901f4f94847e8637fbc58cc5b29c56 > # Parent 0c34cb461a1ea5d3f8e1300e0b8bc16ed8fa8802 > # EXP-Topic parallel-patchi

mercurial@36352: 15 new changesets

15 new changesets in mercurial: https://www.mercurial-scm.org/repo/hg/rev/ddd9474d2e08 changeset: 36338:ddd9474d2e08 user:Martin von Zweigbergk date:Tue Feb 06 08:48:05 2018 -0800 summary: walkrepos: don't reimplement any() https://www.mercurial-scm.org/repo/hg/rev/a4d41ba4

D2090: fancyopts: add support for custom multi-arg opts in fancyopts.py

yuja added inline comments. INLINE COMMENTS > fancyopts.py:258 > +elif isinstance(default, list): > +return _listopt(default[:]) > +elif type(default) is type(1): Perhaps it's safer to make `defaultvalue()` a function returning a copy of default, instead of passing a copy to `_li

mercurial@36358: 6 new changesets

6 new changesets in mercurial: https://www.mercurial-scm.org/repo/hg/rev/cc9d0763c8e9 changeset: 36353:cc9d0763c8e9 user:Daniel Ploch date:Wed Feb 21 20:05:29 2018 -0800 summary: fancyopts: add support for custom multi-arg opts in fancyopts.py https://www.mercurial-scm.org/

D2380: sshpeer: return framed file object when needed

This revision was automatically updated to reflect the committed changes. Closed by commit rHG043e77f3be09: sshpeer: return framed file object when needed (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2380?vs=5966&id

D2381: tests: store protocol payload in files

This revision was automatically updated to reflect the committed changes. Closed by commit rHG02782e6e2c38: tests: store protocol payload in files (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2381?vs=5967&id=5999 R

D2378: sshpeer: rename _recv and _send to _readframed and _writeframed

This revision was automatically updated to reflect the committed changes. Closed by commit rHG7f8f74531b0b: sshpeer: rename _recv and _send to _readframed and _writeframed (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org

D2379: sshpeer: move logic for sending a request into a new function

This revision was automatically updated to reflect the committed changes. Closed by commit rHGa34d5ef53c2e: sshpeer: move logic for sending a request into a new function (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D

D2382: sshpeer: make pipe polling code more explicit

This revision was automatically updated to reflect the committed changes. Closed by commit rHG066e6a9d52bb: sshpeer: make pipe polling code more explicit (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2382?vs=5968&id=

D2384: wireprototypes: move baseprotocolhandler from wireprotoserver

This revision was automatically updated to reflect the committed changes. Closed by commit rHG0c231df1ffdc: wireprototypes: move baseprotocolhandler from wireprotoserver (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D

D2383: sshpeer: defer pipe buffering and stderr sidechannel binding

This revision was automatically updated to reflect the committed changes. Closed by commit rHG11ba1a96f946: sshpeer: defer pipe buffering and stderr sidechannel binding (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2

D2385: wireproto: document the wonky push protocol for SSH

This revision was automatically updated to reflect the committed changes. Closed by commit rHGb8d0761a85c7: wireproto: document the wonky push protocol for SSH (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2385?vs=59

D2377: util: add a file object proxy that can read at most N bytes

This revision was automatically updated to reflect the committed changes. Closed by commit rHG01e29e885600: util: add a file object proxy that can read at most N bytes (authored by indygreg, committed by ). REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D23

D2367: narrowcommands: add some missing strkwargs calls for py3

pulkit added a comment. This one got pushed with a wrong commit message. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2367 To: durin42, #hg-reviewers, indygreg Cc: indygreg, pulkit, mercurial-devel ___ Mercurial-deve

[PATCH 1 of 2 RFC] dispatch: remember command table per extension (PoC DO NOT PUSH)

# HG changeset patch # User Yuya Nishihara # Date 1516797703 -32400 # Wed Jan 24 21:41:43 2018 +0900 # Node ID e2030eaec92b1ed12577cbe48cd0495d106818a9 # Parent b8d0761a85c7421071750de23228415306852d69 dispatch: remember command table per extension (PoC DO NOT PUSH) The next patch will make

[PATCH 2 of 2 RFC] dispatch: look up command by [:] syntax (PoC)

# HG changeset patch # User Yuya Nishihara # Date 1516798904 -32400 # Wed Jan 24 22:01:44 2018 +0900 # Node ID cb9e1cad42a9a13f17c4c75d350cd509b08f4a21 # Parent e2030eaec92b1ed12577cbe48cd0495d106818a9 dispatch: look up command by [:] syntax (PoC) This allows us to run the show command with

Re: [PATCH] mdiff: split on unicode character boundaries when shortening function name

On Thu, Feb 22, 2018 at 21:01:44 +0900, Yuya Nishihara wrote: > On Thu, 22 Feb 2018 09:01:14 +0100, Denis Laxalde wrote: > > Josef 'Jeff' Sipek wrote: > > > # HG changeset patch > > > # User Josef 'Jeff' Sipek > > > # Date 1519251311 18000 > > > # Wed Feb 21 17:15:11 2018 -0500 > > > # Node I

D2297: py3: backout 7c54917b31f6 to make sure second argument of open() is str

pulkit added a comment. In https://phab.mercurial-scm.org/D2297#37960, @yuja wrote: > Can you elaborate why you think it wasn't a good idea to replace open()? > > IMHO, it's as hackish as replacing '' with b''. Added couple of points. REPOSITORY rHG Mercurial REVISION DETAI

Re: D2297: py3: backout 7c54917b31f6 to make sure second argument of open() is str

"There are around 100 occurences of open() call, it's better if we can prevent replacing all these calls "In future, when we will dropping all the compatibility code, we don't have to take care of changing pycompat.open back to open Yeah, that's the point why we have `from pycompat import open` to

D2297: py3: backout 7c54917b31f6 to make sure second argument of open() is str

yuja added a comment. "There are around 100 occurences of open() call, it's better if we can prevent replacing all these calls "In future, when we will dropping all the compatibility code, we don't have to take care of changing pycompat.open back to open Yeah, that's the point why we

Re: [PATCH] mdiff: split on unicode character boundaries when shortening function name

On Thu, 22 Feb 2018 10:01:00 -0500, Josef 'Jeff' Sipek wrote: > On Thu, Feb 22, 2018 at 21:01:44 +0900, Yuya Nishihara wrote: > > On Thu, 22 Feb 2018 09:01:14 +0100, Denis Laxalde wrote: > > > Josef 'Jeff' Sipek wrote: > > > > # HG changeset patch > > > > # User Josef 'Jeff' Sipek > > > > # Date 1

[Bug 5801] New: pure-python manifest code produces corrupt unsorted manifests

https://bz.mercurial-scm.org/show_bug.cgi?id=5801 Bug ID: 5801 Summary: pure-python manifest code produces corrupt unsorted manifests Product: Mercurial Version: default branch Hardware: PC OS: Mac OS

Re: [PATCH] mdiff: split on unicode character boundaries when shortening function name

On Fri, Feb 23, 2018 at 01:06:28 +0900, Yuya Nishihara wrote: > On Thu, 22 Feb 2018 10:01:00 -0500, Josef 'Jeff' Sipek wrote: ... > > Yeah... I thought that might be an issue. The code in the 'except' is meant > > as best-effort - > > Ok, I didn't notice that. It's indeed better to catch the Unic

[PATCH] namespace: fastpath name lookup on invalid name

# HG changeset patch # User Boris Feld # Date 1519313522 -3600 # Thu Feb 22 16:32:02 2018 +0100 # Node ID b65a85952c09cf4c71a1458fbc4ec77c49683314 # Parent 428de1a59f2df3d6d07ff1d7164c8ee56cbb7825 # EXP-Topic noname # Available At https://bitbucket.org/octobus/mercurial-devel/ #

D2391: sshpeer: factor out code for creating peers from pipes

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY An upcoming commit will want to instantiate an SSH peer via an alternate mechanism that doesn't require running a new SSH command. To facilitate that, we extrac

D2392: debugcommands: add debugwireproto command

indygreg created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY We currently don't have a low-level mechanism for sending arbitrary wire protocol commands. Having a generic and robust mechanism for sending wire protocol comm

D2392: debugcommands: add debugwireproto command

indygreg added a subscriber: sid0. indygreg added a comment. @sid0: I reckon we could find a way to take what I did in this commit and turn it into a wire protocol conformance tester. i.e. if we could refactor the test so it instantiates the server via alternate mechanisms, we could point the

D2393: cleanup: say goodbye to manifestv2 format

durin42 created this revision. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REVISION SUMMARY This experiment was a bust: we'd hoped for smaller repository sizes, but things got larger. Google ended up rolling out tree manifests in a format that's compati

Re: [PATCH 2 of 2 RFC] dispatch: look up command by [:] syntax (PoC)

On Thu, 22 Feb 2018 23:54:47 +0900 Yuya Nishihara wrote: > # HG changeset patch > # User Yuya Nishihara > # Date 1516798904 -32400 > # Wed Jan 24 22:01:44 2018 +0900 > # Node ID cb9e1cad42a9a13f17c4c75d350cd509b08f4a21 > # Parent e2030eaec92b1ed12577cbe48cd0495d106818a9 > dispatch: look up

D2393: cleanup: say goodbye to manifestv2 format

martinvonz added a comment. LGTM. Last time I was going to remove it, I left it in because Durham felt that it was useful for forcing him to not specialize the manifest API too much for how v1 works. I believe he's pretty much done with that now, so that should no longer be a reason to keep

D2391: sshpeer: factor out code for creating peers from pipes

dhduvall added inline comments. INLINE COMMENTS > sshpeer.py:537 > + > +``path`` and ``path`` are stored on the eventual peer instance and may > +not be used for anything meaningful. That second `path` should be `proc`? REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercuria

[Bug 5802] New: old pager.attend setting breaks hg import

https://bz.mercurial-scm.org/show_bug.cgi?id=5802 Bug ID: 5802 Summary: old pager.attend setting breaks hg import Product: Mercurial Version: stable branch Hardware: PC OS: Linux Status: UNCONFIRMED Severi

D2394: histedit: make histedit's commands accept revsets (issue5746)

sangeet259 created this revision. Herald added a reviewer: durin42. Herald added a subscriber: mercurial-devel. Herald added a reviewer: hg-reviewers. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2394 AFFECTED FILES hgext/histedit.py CHANGE DETAILS diff --git

D2394: histedit: make histedit's commands accept revsets (issue5746)

sangeet259 updated this revision to Diff 6008. REPOSITORY rHG Mercurial CHANGES SINCE LAST UPDATE https://phab.mercurial-scm.org/D2394?vs=6007&id=6008 REVISION DETAIL https://phab.mercurial-scm.org/D2394 AFFECTED FILES hgext/histedit.py CHANGE DETAILS diff --git a/hgext/histedit.py b/

D2394: histedit: make histedit's commands accept revsets (issue5746)

sangeet259 added a comment. **What I did**: @durin42 suggested in the issue page that the error was in the `verify` function of the `histedit.py` file. But when I ran through debugger using a revision number, the code was throwing the error

D2394: histedit: make histedit's commands accept revsets (issue5746)

sangeet259 added a comment. Oh, I forgot adding tests as @durin42 told. Doing that right away! REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2394 To: sangeet259, durin42, #hg-reviewers Cc: mercurial-devel ___ Mercuria

D2394: histedit: make histedit's commands accept revsets (issue5746)

rishabhmadan96 added a comment. It'd be better if you could update the commit message with the necessary details that you mentioned in your previous comment. REPOSITORY rHG Mercurial REVISION DETAIL https://phab.mercurial-scm.org/D2394 To: sangeet259, durin42, #hg-reviewers Cc: rishabhm

Re: [PATCH 1 of 6 remotenames-ext] Back out "remotenames: push anonymous head if --force is given"

Ryan McElroy writes: > On 2/20/18 11:44 PM, Sean Farley wrote: >> Ryan McElroy writes: >> >>> # HG changeset patch >>> # User Ryan McElroy >>> # Date 1519040197 28800 >>> # Mon Feb 19 03:36:37 2018 -0800 >>> # Node ID 6b80188783ee2626030113a9b2319f2fd14a8119 >>> # Parent 905b79d62df82d8c