Re: [Mesa-dev] [PATCH] glsl: add ir_unop_b2d

On Tue, 2016-01-12 at 12:41 -0500, Ilia Mirkin wrote: > On Tue, Jan 12, 2016 at 12:33 PM, Ian Romanick wrote: > > On 01/12/2016 07:29 AM, Ilia Mirkin wrote: > >> IIRC this should come out as b2i + i2d. You should be able to test this > >> with llvmpipe/softpipe, which support fp64. > > > > Either

Re: [Mesa-dev] [PATCH 2/2] i965/fs: Skip assertion on NaN.

On Tue, 2016-01-12 at 11:53 -0800, Matt Turner wrote: > On Tue, Jan 12, 2016 at 1:41 AM, Iago Toral wrote: > > On Mon, 2016-01-11 at 09:36 -0800, Matt Turner wrote: > >> A shader in Unreal4 uses the result of divide by zero in its color > >> output, producing NaN and triggering this assertion sinc

Re: [Mesa-dev] [PATCH] glsl: add ir_unop_b2d

On Tue, 2016-01-12 at 10:29 -0500, Ilia Mirkin wrote: > IIRC this should come out as b2i + i2d. You should be able to test > this with llvmpipe/softpipe, which support fp64. I see, thanks for the quick reply, I'll check this on intel. Iago > On Jan 12, 2016 9:49 AM, "Iago Toral Quiroga" > wrote

[Mesa-dev] [Bug 93686] Performance improvement ?=:=?UTF-8?Q? Please consider hardware ɢᴘᴜ rendering in llvmpipe

https://bugs.freedesktop.org/show_bug.cgi?id=93686 Kenneth Graunke changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH] radeonsi: don't print a warning for unhandled registers returned by LLVM

On 12.01.2016 22:25, Michel Dänzer wrote: On 13.01.2016 03:44, Marek Olšák wrote: From: Marek Olšák We don't want apps to flood stderr. New LLVM + old Mesa is a perfectly valid combination (if it doesn't fail to build, of course). Actually it's not, in general. Maybe you're thinking of stabl

Re: [Mesa-dev] [PATCH] glsl: add ir_unop_b2d

On 13 January 2016 at 03:41, Ilia Mirkin wrote: > On Tue, Jan 12, 2016 at 12:33 PM, Ian Romanick wrote: >> On 01/12/2016 07:29 AM, Ilia Mirkin wrote: >>> IIRC this should come out as b2i + i2d. You should be able to test this >>> with llvmpipe/softpipe, which support fp64. >> >> Either that or b2

Re: [Mesa-dev] [PATCH] draw: fix key comparison with uninitialized value

On 12/01/16 17:49, srol...@vmware.com wrote: From: Roland Scheidegger Discovered by accident, valgrind was complaining (could have possibly caused us to create redundant geometry shader variants). v2: convinced by Brian and Jose, just use memset for both gs and vs keys, just as easy and less e

Re: [Mesa-dev] [PATCH v4 1/3] gallium/st: add pipe_context::generate_mipmap()

On 13/01/16 03:45, Michel Dänzer wrote: On 13.01.2016 12:23, Charmaine Lee wrote: This patch adds a new interface to support hardware mipmap generation. PIPE_CAP_GENERATE_MIPMAP is added to allow a driver to specify if this new interface is supported; if not supported, the state tracker will fal

[Mesa-dev] [PATCH] gallivm: merge two identical LLVM version checks

--- src/gallium/auxiliary/gallivm/lp_bld_misc.cpp | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/gallium/auxiliary/gallivm/lp_bld_misc.cpp b/src/gallium/auxiliary/gallivm/lp_bld_misc.cpp index 3ee708f..b119a93 100644 --- a/src/gallium/auxiliary/gallivm/lp_bld_misc.cpp

Re: [Mesa-dev] [PATCH v4 1/3] gallium/st: add pipe_context::generate_mipmap()

On 13.01.2016 12:23, Charmaine Lee wrote: > This patch adds a new interface to support hardware mipmap generation. > PIPE_CAP_GENERATE_MIPMAP is added to allow a driver to specify > if this new interface is supported; if not supported, the state tracker will > fallback to mipmap generation by rende

[Mesa-dev] [PATCH v4 1/3] gallium/st: add pipe_context::generate_mipmap()

This patch adds a new interface to support hardware mipmap generation. PIPE_CAP_GENERATE_MIPMAP is added to allow a driver to specify if this new interface is supported; if not supported, the state tracker will fallback to mipmap generation by rendering/texturing. v2: add PIPE_CAP_GENERATE_MIPMAP

Re: [Mesa-dev] [PATCH] radeonsi: don't print a warning for unhandled registers returned by LLVM

On 13.01.2016 03:44, Marek Olšák wrote: > From: Marek Olšák > > We don't want apps to flood stderr. New LLVM + old Mesa is a perfectly > valid combination (if it doesn't fail to build, of course). Actually it's not, in general. Maybe you're thinking of stable LLVM point releases adding new confi

Re: [Mesa-dev] [PATCH 1/3] gallium/st: add pipe_context::generate_mipmap()

On 13.01.2016 04:20, Charmaine Lee wrote: > >> From: Michel Dänzer >> Sent: Monday, January 11, 2016 11:37 PM >> To: Charmaine Lee >> Cc: mesa-dev@lists.freedesktop.org >> Subject: Re: [Mesa-dev] [PATCH 1/3] gallium/st: add >> pipe_context::generate_mipmap() > >> On 12.01.2016 15:18, Charmaine

Re: [Mesa-dev] [PATCH 1/2] nir: Add a fquantize2f16 opcode

Am 13.01.2016 um 02:41 schrieb Matt Turner: > On Tue, Jan 12, 2016 at 4:10 PM, Jason Ekstrand wrote: >> On Tue, Jan 12, 2016 at 3:52 PM, Matt Turner wrote: >>> >>> On Tue, Jan 12, 2016 at 3:35 PM, Jason Ekstrand >>> wrote: This opcode simply takes a 32-bit floating-point value and reduces i

Re: [Mesa-dev] [PATCH 1/2] nir: Add a fquantize2f16 opcode

On Tue, Jan 12, 2016 at 4:10 PM, Jason Ekstrand wrote: > On Tue, Jan 12, 2016 at 3:52 PM, Matt Turner wrote: >> >> On Tue, Jan 12, 2016 at 3:35 PM, Jason Ekstrand >> wrote: >> > This opcode simply takes a 32-bit floating-point value and reduces its >> > effective precision to 16 bits. >> > --- >

Re: [Mesa-dev] [PATCH v3 1/3] gallium/st: add pipe_context::generate_mipmap()

Am 13.01.2016 um 01:01 schrieb Charmaine Lee: > This patch adds a new interface to support hardware mipmap generation. > PIPE_CAP_GENERATE_MIPMAP is added to allow a driver to specify > if this new interface is supported; if not supported, the state tracker will > fallback to mipmap generation by r

Re: [Mesa-dev] [PATCH 1/2] nir: Add a fquantize2f16 opcode

Am 13.01.2016 um 02:23 schrieb Jason Ekstrand: > On Tue, Jan 12, 2016 at 4:50 PM, Ian Romanick > wrote: > > With the SPIR-V link added and the wording change suggested by Erik RE: > precision vs. number of bits in the type, this series is > > > How about: >

Re: [Mesa-dev] [PATCH 1/2] nir: Add a fquantize2f16 opcode

On Tue, Jan 12, 2016 at 4:50 PM, Ian Romanick wrote: > With the SPIR-V link added and the wording change suggested by Erik RE: > precision vs. number of bits in the type, this series is > How about: This opcode takes a 32-bit floating-point value and reduces its precision to that of a 16-bit ha

Re: [Mesa-dev] [PATCH 1/2] nir: Add a fquantize2f16 opcode

With the SPIR-V link added and the wording change suggested by Erik RE: precision vs. number of bits in the type, this series is Reviewed-by: Ian Romanick At some point we should add a debug mode that inserts these operations in GLSL ES shaders around mediump and lowp types and operations. Mayb

Re: [Mesa-dev] [PATCH 2/8] mesa: add Driver.InvalidateBufferSubData

This patch is Reviewed-by: Ian Romanick On 01/12/2016 08:06 AM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > --- > src/mesa/main/bufferobj.c | 12 > src/mesa/main/dd.h| 5 + > 2 files changed, 9 insertions(+), 8 deletions(-) > > diff --git a/src/mesa/main/buffer

[Mesa-dev] [Bug 93686] Performance improvement ?=:=?UTF-8?Q? Please consider hardware ɢᴘᴜ rendering in llvmpipe

https://bugs.freedesktop.org/show_bug.cgi?id=93686 ytr...@sdf-eu.org changed: What|Removed |Added CC||ytr...@sdf-eu.org -- You are receivi

Re: [Mesa-dev] [PATCH 1/8] mesa: fix the checks in _mesa_InvalidateBuffer(Sub)Data

This patch is Reviewed-by: Ian Romanick On 01/12/2016 08:06 AM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > Change the check to be in line with what the quoted spec fragment says. > > I have sent out a piglit test for this as well. > --- > src/mesa/main/bufferobj.c | 18 +++-

[Mesa-dev] [Bug 93686] Performance improvement ?=:=?UTF-8?Q? Please consider hardware ɢᴘᴜ rendering in llvmpipe

https://bugs.freedesktop.org/show_bug.cgi?id=93686 Bug ID: 93686 Summary: Performance improvement : Please consider hardware ɢᴘᴜ rendering in llvmpipe Product: Mesa Version: unspecified Hardware: x86-64 (AMD64)

Re: [Mesa-dev] [PATCH v3 1/3] gallium/st: add pipe_context::generate_mipmap()

The series looks good to me. Reviewed-by: Brian Paul On 01/12/2016 05:01 PM, Charmaine Lee wrote: This patch adds a new interface to support hardware mipmap generation. PIPE_CAP_GENERATE_MIPMAP is added to allow a driver to specify if this new interface is supported; if not supported, the sta

Re: [Mesa-dev] [PATCH 1/2] nir: Add a fquantize2f16 opcode

On Wed, Jan 13, 2016 at 1:10 AM, Jason Ekstrand wrote: > On Tue, Jan 12, 2016 at 3:52 PM, Matt Turner wrote: >> >> On Tue, Jan 12, 2016 at 3:35 PM, Jason Ekstrand >> wrote: >> > This opcode simply takes a 32-bit floating-point value and reduces its >> > effective precision to 16 bits. >> > --- >

Re: [Mesa-dev] [PATCH 19/28] glsl: add support for explicit components to frag outputs

On Mon, Dec 28, 2015 at 9:00 PM, Timothy Arceri wrote: > --- > src/glsl/linker.cpp | 56 > - > 1 file changed, 55 insertions(+), 1 deletion(-) > > diff --git a/src/glsl/linker.cpp b/src/glsl/linker.cpp > index 41ff057..44dd7f0 100644 > --- a/sr

[Mesa-dev] [PATCH v3 1/3] gallium/st: add pipe_context::generate_mipmap()

This patch adds a new interface to support hardware mipmap generation. PIPE_CAP_GENERATE_MIPMAP is added to allow a driver to specify if this new interface is supported; if not supported, the state tracker will fallback to mipmap generation by rendering/texturing. v2: add PIPE_CAP_GENERATE_MIPMAP

Re: [Mesa-dev] [PATCH 1/2] nir: Add a fquantize2f16 opcode

On Tue, Jan 12, 2016 at 3:52 PM, Matt Turner wrote: > On Tue, Jan 12, 2016 at 3:35 PM, Jason Ekstrand > wrote: > > This opcode simply takes a 32-bit floating-point value and reduces its > > effective precision to 16 bits. > > --- > > What's it supposed to do for values not representable in half-

Re: [Mesa-dev] [PATCH] radeonsi: enable late VS export memory allocation

On 12.01.2016 18:55, Marek Olšák wrote: Hi Nicolai, I only tested piglit on Bonaire. The scratch buffer can deadlock too, though I guess we have enough scratch space that we should never run out of it. a) The lockup is prevented by the change to the value of SHADER_PGM_RSRC3_VS. It means that

Re: [Mesa-dev] [PATCH] radeonsi: enable late VS export memory allocation

Hi Nicolai, I only tested piglit on Bonaire. The scratch buffer can deadlock too, though I guess we have enough scratch space that we should never run out of it. a) The lockup is prevented by the change to the value of SHADER_PGM_RSRC3_VS. It means that 1 compute unit is reserved for PS only. Th

Re: [Mesa-dev] [PATCH 1/2] nir: Add a fquantize2f16 opcode

On Tue, Jan 12, 2016 at 3:35 PM, Jason Ekstrand wrote: > This opcode simply takes a 32-bit floating-point value and reduces its > effective precision to 16 bits. > --- What's it supposed to do for values not representable in half-precision? I think we need some more information about this opcode

Re: [Mesa-dev] [PATCH 18/28] glsl: validate linking of intrastage component qualifiers

On Mon, Dec 28, 2015 at 9:00 PM, Timothy Arceri wrote: > --- > src/glsl/linker.cpp | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/src/glsl/linker.cpp b/src/glsl/linker.cpp > index f709922..41ff057 100644 > --- a/src/glsl/linker.cpp > +++ b/src/glsl/linker.cpp > @@ -990,6 +990,13

[Mesa-dev] [PATCH 2/2] i965: Implement nir_op_fquantize2f16

--- src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 13 + src/mesa/drivers/dri/i965/brw_vec4_nir.cpp | 10 ++ 2 files changed, 23 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp b/src/mesa/drivers/dri/i965/brw_fs_nir.cpp index 6213378..ffb8059 100644 --- a/sr

[Mesa-dev] [PATCH 1/2] nir: Add a fquantize2f16 opcode

This opcode simply takes a 32-bit floating-point value and reduces its effective precision to 16 bits. --- src/glsl/nir/nir_opcodes.py | 1 + 1 file changed, 1 insertion(+) diff --git a/src/glsl/nir/nir_opcodes.py b/src/glsl/nir/nir_opcodes.py index d31507f..9dbb341 100644 --- a/src/glsl/nir/nir_

Re: [Mesa-dev] [PATCH] glsl: add packed varyings for outputs with single stage program

Reviewed-by: Timothy Arceri ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 1/2] radeonsi: simplify gl_FragCoord behavior

Fine with me On 12.01.2016 13:10, Marek Olšák wrote: Hi, For AMD guys: Is it okay with you to push this patch series? Thanks, Marek On Fri, Jan 8, 2016 at 2:30 AM, Marek Olšák wrote: From: Marek Olšák It will become a system value, not an input. --- src/gallium/drivers/radeonsi/si_stat

Re: [Mesa-dev] [PATCH] radeonsi: enable late VS export memory allocation

How well-tested is this? I'm a bit confused because I thought the scratch_waves is about the scratch buffer ring (which should always be allocated immediately when the shader starts), while the late_alloc is about allocating the space where exports go. So late_alloc is basically bounded by (a

Re: [Mesa-dev] [PATCH] radeonsi: don't print a warning for unhandled registers returned by LLVM

Makes sense. Reviewed-by: Nicolai Hähnle On 12.01.2016 13:44, Marek Olšák wrote: From: Marek Olšák We don't want apps to flood stderr. New LLVM + old Mesa is a perfectly valid combination (if it doesn't fail to build, of course). --- src/gallium/drivers/radeonsi/si_shader.c | 5 + 1 f

Re: [Mesa-dev] [PATCH 7/8] gallium/radeon: implement PIPE_CAP_INVALIDATE_BUFFER

On 12.01.2016 13:41, Fredrik Höglund wrote: On Tuesday 12 January 2016, Nicolai Hähnle wrote: From: Nicolai Hähnle --- src/gallium/drivers/r600/r600_pipe.c| 2 +- src/gallium/drivers/radeon/r600_buffer_common.c | 23 --- src/gallium/drivers/radeon/r600_pipe

Re: [Mesa-dev] [PATCH 5/5] i965/gen9: Don't allow the RGBX formats for texturing/rendering

On Mon, Nov 23, 2015 at 3:00 AM, Neil Roberts wrote: > Ben Widawsky writes: > >>> + /* The RGBX formats are not renderable. Normally these get mapped >>> +* internally to RGBA formats when rendering. However on Gen9+ when this >>> +* internal override is used fast clears don't work so t

Re: [Mesa-dev] [PATCH 2/2] gallium: always build glsl for gallium

On Tue, Jan 12, 2016 at 2:46 PM, Marek Olšák wrote: > From: Jammy Zhou > > It is needed if the GL/ES build is disabled. Otherwise, there will > be an error that nir_opcodes.h is missing. The motivation is to allow > building Gallium VDPAU/OMX/VA without OpenGL. > > For example: > ./autogen.sh --e

Re: [Mesa-dev] [PATCH 2/2] i965/fs: Skip assertion on NaN.

On Tue, Jan 12, 2016 at 1:41 AM, Iago Toral wrote: > On Mon, 2016-01-11 at 09:36 -0800, Matt Turner wrote: >> A shader in Unreal4 uses the result of divide by zero in its color >> output, producing NaN and triggering this assertion since NaN is not >> equal to itself. >> >> Bugzilla: https://bugs.

[Mesa-dev] [PATCH 1/2] configure.ac: don't require EGL/DRM ang GBM if OpenGL is disabled

From: Marek Olšák This allows building VDPAU/OMX/VA drivers without OpenGL and its dependencies. --- configure.ac | 5 + 1 file changed, 5 insertions(+) diff --git a/configure.ac b/configure.ac index 8d19dab..04b5fd8 100644 --- a/configure.ac +++ b/configure.ac @@ -2159,7 +2159,12 @@ galliu

[Mesa-dev] [PATCH 2/2] gallium: always build glsl for gallium

From: Jammy Zhou It is needed if the GL/ES build is disabled. Otherwise, there will be an error that nir_opcodes.h is missing. The motivation is to allow building Gallium VDPAU/OMX/VA without OpenGL. For example: ./autogen.sh --enable-vdpau --disable-opengl --disable-gles1 \ -disable-gles2 --w

Re: [Mesa-dev] [PATCH] draw: fix key comparison with uninitialized value

On 01/12/2016 10:49 AM, srol...@vmware.com wrote: From: Roland Scheidegger Discovered by accident, valgrind was complaining (could have possibly caused us to create redundant geometry shader variants). v2: convinced by Brian and Jose, just use memset for both gs and vs keys, just as easy and l

Re: [Mesa-dev] [PATCH V3] glapi: add GL_OES_geometry_shader extension

On 01/12/2016 10:09 AM, Ilia Mirkin wrote: > On Tue, Jan 12, 2016 at 9:13 AM, Marta Lofstedt > wrote: >> From: Marta Lofstedt >> >> Add xml definitions for the GL_OES_geometry_shader extension >> and expose the extension for OpenGL ES 3.1. >> >> V3: Added dependency to OES_shader_io_blocks and up

Re: [Mesa-dev] [PATCH 1/3] gallium/st: add pipe_context::generate_mipmap()

>From: Michel Dänzer >Sent: Monday, January 11, 2016 11:37 PM >To: Charmaine Lee >Cc: mesa-dev@lists.freedesktop.org >Subject: Re: [Mesa-dev] [PATCH 1/3] gallium/st: add >pipe_context::generate_mipmap() >On 12.01.2016 15:18, Charmaine Lee wrote: >> This patch adds a new interface to support har

Re: [Mesa-dev] [PATCH 08/18] meta/blit: Don't pollute the sampler object namespace in _mesa_meta_setup_sampler

On Tue, Jan 12, 2016 at 5:44 PM, Ian Romanick wrote: > On 01/12/2016 01:36 AM, Erik Faye-Lund wrote: >> On Sat, Jan 9, 2016 at 3:59 AM, Ian Romanick wrote: >>> From: Ian Romanick >>> >>> tl;dr: For many types of GL object, we can *NEVER* use the Gen function. >>> >>> In OpenGL ES (all versions!)

[Mesa-dev] [PATCH] radeonsi: don't print a warning for unhandled registers returned by LLVM

From: Marek Olšák We don't want apps to flood stderr. New LLVM + old Mesa is a perfectly valid combination (if it doesn't fail to build, of course). --- src/gallium/drivers/radeonsi/si_shader.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/gallium/drivers/radeonsi/s

Re: [Mesa-dev] [PATCH 7/8] gallium/radeon: implement PIPE_CAP_INVALIDATE_BUFFER

On Tuesday 12 January 2016, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > --- > src/gallium/drivers/r600/r600_pipe.c| 2 +- > src/gallium/drivers/radeon/r600_buffer_common.c | 23 --- > src/gallium/drivers/radeon/r600_pipe_common.c | 1 + > src/gallium/driv

Re: [Mesa-dev] [PATCH 1/2] radeonsi: simplify gl_FragCoord behavior

On Tue, Jan 12, 2016 at 1:10 PM, Marek Olšák wrote: > Hi, > > For AMD guys: Is it okay with you to push this patch series? No objections here. Alex > > Thanks, > > Marek > > On Fri, Jan 8, 2016 at 2:30 AM, Marek Olšák wrote: >> From: Marek Olšák >> >> It will become a system value, not an inp

Re: [Mesa-dev] Avoid segfault in omx deconstructor

Pushed to master, thanks. Marek On Tue, Nov 3, 2015 at 7:38 PM, Christian König wrote: > The subject line should have something like "st/omx: ...". > > Apart from that the patch is Reviewed-by: Christian König > > > Regards, > Christian. > > > On 03.11.2015 19:06, StDenis, Tom wrote: > > Now wi

Re: [Mesa-dev] [PATCH 1/2] radeonsi: simplify gl_FragCoord behavior

Hi, For AMD guys: Is it okay with you to push this patch series? Thanks, Marek On Fri, Jan 8, 2016 at 2:30 AM, Marek Olšák wrote: > From: Marek Olšák > > It will become a system value, not an input. > --- > src/gallium/drivers/radeonsi/si_state_shaders.c | 45 > - >

Re: [Mesa-dev] [PATCH V3] glapi: add GL_OES_geometry_shader extension

On Tue, Jan 12, 2016 at 9:13 AM, Marta Lofstedt wrote: > From: Marta Lofstedt > > Add xml definitions for the GL_OES_geometry_shader extension > and expose the extension for OpenGL ES 3.1. > > V3: Added dependency to OES_shader_io_blocks and updated to > correct Khronos extension number. May I a

[Mesa-dev] [PATCH] radeonsi: enable late VS export memory allocation

From: Marek Olšák This allows more VS waves to run on CIK and VI. --- src/gallium/drivers/radeonsi/si_pipe.c | 4 +++- src/gallium/drivers/radeonsi/si_pipe.h | 4 src/gallium/drivers/radeonsi/si_state.c | 5 +++-- 3 files changed, 10 insertions(+), 3 deletions(-) diff --git a/src/gallium

Re: [Mesa-dev] [PATCH V3] glapi: add GL_OES_geometry_shader extension

On Tue, Jan 12, 2016 at 03:13:54PM +0100, Marta Lofstedt wrote: > From: Marta Lofstedt > > Add xml definitions for the GL_OES_geometry_shader extension > and expose the extension for OpenGL ES 3.1. > > V3: Added dependency to OES_shader_io_blocks and updated to > correct Khronos extension number

[Mesa-dev] [PATCH] draw: fix key comparison with uninitialized value

From: Roland Scheidegger Discovered by accident, valgrind was complaining (could have possibly caused us to create redundant geometry shader variants). v2: convinced by Brian and Jose, just use memset for both gs and vs keys, just as easy and less error prone. --- src/gallium/auxiliary/draw/dra

Re: [Mesa-dev] [PATCH] meta: remove const qualifier on _mesa_meta_fb_tex_blit_begin()

On 01/12/2016 07:51 AM, Brian Paul wrote: > To silence a compiler warning about a const/non-const mismatch. It is weird that I didn't notice that before. It is clearly there. :( drivers/common/meta_blit.c:822:35: warning: passing argument 1 of ‘_mesa_reference_sampler_object’ discards ‘const’ q

Re: [Mesa-dev] [PATCH] winsys/radeon: fix warnings about incompatible pointer types

Reviewed-by: Marek Olšák Marek On Tue, Jan 12, 2016 at 6:29 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > Some confusion between pb_buffer and radeon_bo as well as between > radeon_drm_winsys and radeon_winsys. > --- > src/gallium/winsys/radeon/drm/radeon_drm_bo.c | 12 ++-- >

Re: [Mesa-dev] [PATCH] glsl: add ir_unop_b2d

On Tue, Jan 12, 2016 at 12:33 PM, Ian Romanick wrote: > On 01/12/2016 07:29 AM, Ilia Mirkin wrote: >> IIRC this should come out as b2i + i2d. You should be able to test this >> with llvmpipe/softpipe, which support fp64. > > Either that or b2f + f2d. I remember there being discussion about this >

Re: [Mesa-dev] [PATCH] glsl: add ir_unop_b2d

On 01/12/2016 07:29 AM, Ilia Mirkin wrote: > IIRC this should come out as b2i + i2d. You should be able to test this > with llvmpipe/softpipe, which support fp64. Either that or b2f + f2d. I remember there being discussion about this topic when Dave first sent out the fp64 patches. I thought we

[Mesa-dev] [PATCH] winsys/radeon: fix warnings about incompatible pointer types

From: Nicolai Hähnle Some confusion between pb_buffer and radeon_bo as well as between radeon_drm_winsys and radeon_winsys. --- src/gallium/winsys/radeon/drm/radeon_drm_bo.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/gallium/winsys/radeon/drm/radeon_drm_

Re: [Mesa-dev] [PATCH 8/9] nir: Add code to fixup bitfield_insert/extract.

On 01/11/2016 10:04 PM, Connor Abbott wrote: > On Tue, Jan 12, 2016 at 12:54 AM, Matt Turner wrote: >> On Mon, Jan 11, 2016 at 6:58 PM, Jason Ekstrand wrote: >>> >>> On Jan 11, 2016 2:47 PM, "Matt Turner" wrote: The OpenGL specifications for bitfieldInsert() and bitfieldExtract() says:

Re: [Mesa-dev] [PATCH 08/18] meta/blit: Don't pollute the sampler object namespace in _mesa_meta_setup_sampler

On 01/12/2016 01:36 AM, Erik Faye-Lund wrote: > On Sat, Jan 9, 2016 at 3:59 AM, Ian Romanick wrote: >> From: Ian Romanick >> >> tl;dr: For many types of GL object, we can *NEVER* use the Gen function. >> >> In OpenGL ES (all versions!) and OpenGL compatibility profile, >> applications don't have

Re: [Mesa-dev] [PATCH 1/9] nir: Fix constant evaluation of bfm.

On Mon, Jan 11, 2016 at 6:52 PM, Ian Romanick wrote: > On 01/11/2016 02:48 PM, Matt Turner wrote: >> NIR's bfm, like Intel/AMD's hardware instructions and GLSL IR's >> ir_binop_bfm takes as src0 and as src1. > > All the questions... > > Is the ordering of the operands documented anywhere? I was

Re: [Mesa-dev] [PATCH] draw: fix key comparison with uninitialized value

Am 12.01.2016 um 10:49 schrieb Jose Fonseca: > On 12/01/16 02:11, srol...@vmware.com wrote: >> From: Roland Scheidegger >> >> Discovered by accident, valgrind was complaining (could have possibly >> caused >> us to create redundant geometry shader variants). > > Great fine. > >> --- >> src/gal

[Mesa-dev] [PATCH] util/hash_table: add _mesa_hash_table_clear (v4)

From: Nicolai Hähnle v4: coding style change (Matt Turner) Reviewed-by: Ian Romanick (v3) --- src/util/hash_table.c | 26 ++ src/util/hash_table.h | 2 + src/util/tests/hash_table/Makefile.am | 1 + src/util/tests/hash_table/clear.c | 91 ++

[Mesa-dev] [Bug 93653] Crash while using GALLIUM_HUD

https://bugs.freedesktop.org/show_bug.cgi?id=93653 --- Comment #1 from Nicolai Hähnle --- The HUD uses a fixed size allocation for the vertex buffer that holds the glyph rectangles. If you feel like it, you can try increasing the number in hud_context.c:524, e.g. hud_alloc_vertices(hud, &hud->te

Re: [Mesa-dev] [PATCHv3 3/9] glsl, nir: Make ir_quadop_bitfield_insert a vectorized operation.

On Mon, Jan 11, 2016 at 7:20 PM, Ilia Mirkin wrote: > On Mon, Jan 11, 2016 at 7:12 PM, Matt Turner wrote: >> From: Kenneth Graunke >> >> We would like to be able to combine >> >>result.x = bitfieldInsert(src0.x, src1.x, src2.x, src3.x); >>result.y = bitfieldInsert(src0.y, src1.y, src2.y,

[Mesa-dev] [PATCH 6/8] gallium/radeon: reset valid_buffer_range on PIPE_TRANSFER_DISCARD_WHOLE_RESOURCE

From: Nicolai Hähnle This accomodates a streaming pattern where the discard flag is set when the application wraps back to the beginning of the buffer. --- src/gallium/drivers/radeon/r600_buffer_common.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/gallium/drivers/radeon/r600_buffe

[Mesa-dev] [PATCH 2/8] mesa: add Driver.InvalidateBufferSubData

From: Nicolai Hähnle --- src/mesa/main/bufferobj.c | 12 src/mesa/main/dd.h| 5 + 2 files changed, 9 insertions(+), 8 deletions(-) diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c index 63d563e..e8baf05 100644 --- a/src/mesa/main/bufferobj.c +++ b/src

[Mesa-dev] [PATCH 3/8] gallium: add PIPE_CAP_INVALIDATE_BUFFER

From: Nicolai Hähnle It makes sense to re-use pipe->invalidate_resource for the purpose of glInvalidateBufferData, but this function is already implemented in vc4 where it doesn't have the expected behavior. So add a capability flag to indicate that the driver supports the expected behavior. ---

[Mesa-dev] [PATCH 8/8] gallium/radeon: do not reallocate user memory buffers

From: Nicolai Hähnle The whole point of AMD_pinned_memory is that applications don't have to map buffers via OpenGL - but they're still allowed to, so make sure we don't break the link between buffer object and user memory unless explicitly instructed to. --- src/gallium/drivers/radeon/r600_buff

[Mesa-dev] [PATCH 7/8] gallium/radeon: implement PIPE_CAP_INVALIDATE_BUFFER

From: Nicolai Hähnle --- src/gallium/drivers/r600/r600_pipe.c| 2 +- src/gallium/drivers/radeon/r600_buffer_common.c | 23 --- src/gallium/drivers/radeon/r600_pipe_common.c | 1 + src/gallium/drivers/radeon/r600_pipe_common.h | 3 +++ src/gallium/drivers/ra

[Mesa-dev] [PATCH 5/8] st/mesa: implement Driver.InvalidateBufferSubData

From: Nicolai Hähnle --- src/mesa/state_tracker/st_cb_bufferobjects.c | 31 +++- src/mesa/state_tracker/st_cb_bufferobjects.h | 3 ++- src/mesa/state_tracker/st_context.c | 2 +- 3 files changed, 33 insertions(+), 3 deletions(-) diff --git a/src/mesa/state_tra

[Mesa-dev] [PATCH 1/8] mesa: fix the checks in _mesa_InvalidateBuffer(Sub)Data

From: Nicolai Hähnle Change the check to be in line with what the quoted spec fragment says. I have sent out a piglit test for this as well. --- src/mesa/main/bufferobj.c | 18 +++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/src/mesa/main/bufferobj.c b/src/mesa

[Mesa-dev] [PATCH 0/8] Proper implementation of glInvalidateBuffer(Sub)Data

Hi, Mesa's current implementation of glInvalidateBuffer(Sub)Data is a no-op. This is allowed by the spec, but it's not what applications expect. For example, the game Planet Explorers uses streaming VBOs and relies on glInvalidateBufferData for performance. In a user-provided apitrace of the game,

[Mesa-dev] [PATCH 4/8] st/mesa: use pipe->invalidate_resource instead of buffer re-allocation

From: Nicolai Hähnle Drivers are expected to avoid unnecessary work when possible in this code path. --- src/mesa/state_tracker/st_cb_bufferobjects.c | 31 1 file changed, 18 insertions(+), 13 deletions(-) diff --git a/src/mesa/state_tracker/st_cb_bufferobjects.c b

[Mesa-dev] [PATCH] meta: remove const qualifier on _mesa_meta_fb_tex_blit_begin()

To silence a compiler warning about a const/non-const mismatch. --- src/mesa/drivers/common/meta.h | 2 +- src/mesa/drivers/common/meta_blit.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/common/meta.h b/src/mesa/drivers/common/meta.h index d7d8fd3..

Re: [Mesa-dev] [PATCH] glsl: add ir_unop_b2d

IIRC this should come out as b2i + i2d. You should be able to test this with llvmpipe/softpipe, which support fp64. On Jan 12, 2016 9:49 AM, "Iago Toral Quiroga" wrote: > For boolean to double conversions > --- > > Looks like d2b is present but this one was missing for some reason. I found > this

Re: [Mesa-dev] [PATCH 1/3] gallium/st: add pipe_context::generate_mipmap()

Just a few nit-picks below... On 01/11/2016 11:18 PM, Charmaine Lee wrote: This patch adds a new interface to support hardware mipmap generation. PIPE_CAP_GENERATE_MIPMAP is added to allow a driver to specify if this new interface is supported; if not supported, the state tracker will fallback

Re: [Mesa-dev] [PATCH 3/3] svga: add DXGenMips command support

Looks good. Just nit-picks below. On 01/11/2016 07:31 PM, Charmaine Lee wrote: For those formats that support hw mipmap generation, use the DXGenMips command. Otherwise fallback to the mipmap generation utility. Tested with piglit, OpenGL apps (Heaven, Turbine, Cinebench) --- src/gallium/dr

[Mesa-dev] [PATCH] glsl: add ir_unop_b2d

For boolean to double conversions --- Looks like d2b is present but this one was missing for some reason. I found this while testing fp64 support on Intel. I have the NIR and i965 implementation of this too but that is be part of the fp64 enablement in NIR/i965 that is not ready for review yet.

Re: [Mesa-dev] [PATCH] glsl: add packed varyings for outputs with single stage program

Reviewed-by: Marta Lofstedt > -Original Message- > From: Palli, Tapani > Sent: Tuesday, January 12, 2016 10:03 AM > To: mesa-dev@lists.freedesktop.org > Cc: Lofstedt, Marta; Palli, Tapani > Subject: [PATCH] glsl: add packed varyings for outputs with single stage > program > > Commit 8926

Re: [Mesa-dev] [PATCH] draw: fix key comparison with uninitialized value

On 01/12/2016 02:49 AM, Jose Fonseca wrote: On 12/01/16 02:11, srol...@vmware.com wrote: From: Roland Scheidegger Discovered by accident, valgrind was complaining (could have possibly caused us to create redundant geometry shader variants). Great fine. --- src/gallium/auxiliary/draw/draw

Re: [Mesa-dev] [PATCH] gallium/aux: Turn TGSI_CHAN_* into enum

The prefix on the subject line could be "tgsi: " Is this the first in a series? There's quite a few other places where uint/unsigned could be replaced with enum tgsi_chan if you want to be consistent. -Brian On 01/12/2016 02:55 AM, Edward O'Callaghan wrote: Signed-off-by: Edward O'Callagha

[Mesa-dev] [PATCH V3] glapi: add GL_OES_geometry_shader extension

From: Marta Lofstedt Add xml definitions for the GL_OES_geometry_shader extension and expose the extension for OpenGL ES 3.1. V3: Added dependency to OES_shader_io_blocks and updated to correct Khronos extension number. Signed-off-by: Marta Lofstedt --- src/mapi/glapi/gen/apiexec.py

Re: [Mesa-dev] [PATCH v2 2/6] glapi: add GL_OES_geometry_shader extension

> -Original Message- > From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On > Behalf Of Ian Romanick > Sent: Monday, November 30, 2015 8:38 PM > To: Ilia Mirkin; Marta Lofstedt > Cc: mesa-dev@lists.freedesktop.org > Subject: Re: [Mesa-dev] [PATCH v2 2/6] glapi: add > GL_OES_g

Re: [Mesa-dev] [PATCH] nir: special hack for TGSI vs indirect inputs

Am 11.01.2016 um 20:55 schrieb Marek Olšák: On Mon, Jan 11, 2016 at 8:00 PM, Rob Clark wrote: On Mon, Jan 11, 2016 at 1:52 PM, Marek Olšák wrote: On Mon, Jan 11, 2016 at 6:07 PM, Rob Clark wrote: Quite possibly I am.. although wouldn't I still have the same issue with other state trackers?

Re: [Mesa-dev] [PATCH 9/9] st/va: add motion adaptive deinterlacing

Am 18.12.2015 um 16:04 schrieb Emil Velikov: On 16 December 2015 at 20:14, Christian König wrote: @@ -174,6 +175,51 @@ static VAStatus vlVaPostProcBlit(vlVaDriver *drv, vlVaContext *context, return VA_STATUS_SUCCESS; } +static struct pipe_video_buffer * +vlVaApplyDeint(vlVaDriver *dr

Re: [Mesa-dev] [PATCH] mesa: print the invalid enum when CreateShader fails

Reviewed-by: Tapani Pälli On 01/12/2016 10:37 AM, Timothy Arceri wrote: --- src/mesa/main/shaderapi.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/mesa/main/shaderapi.c b/src/mesa/main/shaderapi.c index e258ad9..4321950 100644 --- a/src/mesa/main/shaderapi.c +++

Re: [Mesa-dev] NIR, SCons, and Gallium

On Tue, Jan 12, 2016 at 1:11 AM, Ian Romanick wrote: > On 01/11/2016 06:21 AM, Jose Fonseca wrote: >> FWIW, I updated SCons to build NIR, both with GCC and MSVC: >> >> http://cgit.freedesktop.org/~jrfonseca/mesa/log/?h=scons-nir >> >> It was actually simpler than I anticipated. >> >> But I hit a

Re: [Mesa-dev] [PATCH 2/9] glsl: Delete the ir_binop_bfm and ir_triop_bfi opcodes.

Looks good to me, FWIW I built radeonsi and llvmpipe with this change just in case and I saw no issues. Reviewed-by: Iago Toral Quiroga On Mon, 2016-01-11 at 14:48 -0800, Matt Turner wrote: > From: Kenneth Graunke > > TGSI doesn't use these - it just translates ir_quadop_bitfield_insert > dire

Re: [Mesa-dev] [PATCH] draw: fix key comparison with uninitialized value

On 12/01/16 02:11, srol...@vmware.com wrote: From: Roland Scheidegger Discovered by accident, valgrind was complaining (could have possibly caused us to create redundant geometry shader variants). Great fine. --- src/gallium/auxiliary/draw/draw_llvm.c | 3 +++ src/gallium/auxiliary/draw/

[Mesa-dev] [PATCH 3/4] glsl: apply align layout qualifier rules to block offsets

From Section 4.4.5 (Uniform and Shader Storage Block Layout Qualifiers) of the OpenGL 4.50 spec: "The align qualifier makes the start of each block member have a minimum byte alignment. It does not affect the internal layout within each member, which will still follow the std140 or std430

[Mesa-dev] [PATCH] gallium/aux: Turn TGSI_CHAN_* into enum

Signed-off-by: Edward O'Callaghan --- src/gallium/auxiliary/tgsi/tgsi_exec.h | 10 ++ src/gallium/auxiliary/tgsi/tgsi_util.c | 16 2 files changed, 14 insertions(+), 12 deletions(-) diff --git a/src/gallium/auxiliary/tgsi/tgsi_exec.h b/src/gallium/auxiliary/tgsi/tgsi_ex

Re: [Mesa-dev] [PATCH] glsl: Make read_from_write_only_variable_visitor ignore .length().

Makes sense, Reviewed-by: Iago Toral Quiroga On Mon, 2016-01-11 at 16:15 -0800, Kenneth Graunke wrote: > .length() on an unsized SSBO variable doesn't actually read any data > from the SSBO, and is allowed on variables marked 'writeonly'. > > Fixes compute shader compilation in Shadow of Mordor

Re: [Mesa-dev] [PATCH 08/18] meta/blit: Don't pollute the sampler object namespace in _mesa_meta_setup_sampler

On Sat, Jan 9, 2016 at 3:59 AM, Ian Romanick wrote: > From: Ian Romanick > > tl;dr: For many types of GL object, we can *NEVER* use the Gen function. > > In OpenGL ES (all versions!) and OpenGL compatibility profile, > applications don't have to call Gen functions. The GL spec is very > clear ab

Re: [Mesa-dev] [PATCH 2/2] i965/fs: Skip assertion on NaN.

On Mon, 2016-01-11 at 09:36 -0800, Matt Turner wrote: > A shader in Unreal4 uses the result of divide by zero in its color > output, producing NaN and triggering this assertion since NaN is not > equal to itself. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=93560 > --- > src/mesa/dr

[Mesa-dev] [PATCH 4/4] docs: mark align layout qualifier as DONE

--- docs/GL3.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/GL3.txt b/docs/GL3.txt index c64784c..1377eb8 100644 --- a/docs/GL3.txt +++ b/docs/GL3.txt @@ -181,7 +181,7 @@ GL 4.4, GLSL 4.40: GL_ARB_enhanced_layouts in progress (Timothy)

  1   2   >