Re: [Mesa-dev] [PATCH] st/mesa: add check for color logicop in blit_copy_pixels()

2016-01-14 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Thu, Jan 14, 2016 at 12:41 AM, Brian Paul wrote: > We check that a bunch of raster operations are disabled in > blit_copy_pixels(). We also need to check that color logicop is > disabled. > --- >

Re: [Mesa-dev] [PATCH 21/28] glsl: pack fragment shader outputs with component layout qualifiers

2016-01-14 Thread Anuj Phogat
On Mon, Dec 28, 2015 at 9:00 PM, Timothy Arceri wrote: > This actually tries to pack any output with an explicit location we > just let the optimisiation passes clean up the extra assignments if > there was no actual packing done. > --- > src/glsl/link_varyings.cpp

Re: [Mesa-dev] [PATCH 1/7] nir/builder: Add a nir_build_ivec4() convenience helper.

2016-01-14 Thread Matt Turner
Patches 1-4 are Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 20/28] glsl: pack vertex attributes with component layout qualifiers

2016-01-14 Thread Anuj Phogat
On Mon, Dec 28, 2015 at 9:00 PM, Timothy Arceri wrote: > This actually tries to pack any input with an explicit location we > just let the optimisiation passes clean up the extra assignments if > there was no actual packing done. > --- > src/glsl/ir_optimization.h

Re: [Mesa-dev] [PATCH] glsl: restrict consumer stage condition to modify interpolation type

2016-01-14 Thread Tapani Pälli
On 01/14/2016 09:38 AM, Samuel Iglesias Gonsálvez wrote: Only modify interpolation type for integer-based varyings or when the consumer is known and different than fragment shader. If we are linking separate shader programs and the consumer is unknown, the consumer could be added later and be

[Mesa-dev] [PATCH] glsl: mark explicit uniforms as explicit in other stages too

2016-01-14 Thread Tapani Pälli
If shader declares uniform explicit location in one stage but implicit in another, explicit location should be used. Patch marks implicit uniforms as explicit if they were explicit in another stage. This makes sure that we don't treat them implicit later when assigning locations. Fixes following

[Mesa-dev] [Bug 92137] [regression, bisected] piglit arb_separate_shader_objects.validateprogrampipeline fails

2016-01-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92137 Tapani Pälli changed: What|Removed |Added Status|ASSIGNED|RESOLVED

Re: [Mesa-dev] [PATCH] glsl: mark explicit uniforms as explicit in other stages too

2016-01-14 Thread Tapani Pälli
On 01/14/2016 01:49 PM, Timothy Arceri wrote: On Thu, 2016-01-14 at 13:02 +0200, Tapani Pälli wrote: If shader declares uniform explicit location in one stage but implicit in another, explicit location should be used. Patch marks implicit uniforms as explicit if they were explicit in another

Re: [Mesa-dev] [PATCH] glsl: mark explicit uniforms as explicit in other stages too

2016-01-14 Thread Timothy Arceri
On Thu, 2016-01-14 at 13:02 +0200, Tapani Pälli wrote: > If shader declares uniform explicit location in one stage but > implicit in > another, explicit location should be used. Patch marks implicit > uniforms > as explicit if they were explicit in another stage. This makes sure > that > we don't

[Mesa-dev] [Bug 92137] [regression, bisected] piglit arb_separate_shader_objects.validateprogrampipeline fails

2016-01-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92137 --- Comment #6 from Tapani Pälli --- Fixed by --- 8< commit c3ec12ec3c1ddbc72e50df1f5632fe0547a89f7e Author: Timothy Arceri Date: Thu Nov 26 21:32:48 2015 +1100 glsl: don't generate

[Mesa-dev] [PATCH v2] glsl: mark explicit uniforms as explicit in other stages too

2016-01-14 Thread Tapani Pälli
If shader declares uniform explicit location in one stage but implicit in another, explicit location should be used. Patch marks implicit uniforms as explicit if they were explicit in previous stage. This makes sure that we don't treat them implicit later when assigning locations. Fixes following

Re: [Mesa-dev] [PATCH v2] glsl: mark explicit uniforms as explicit in other stages too

2016-01-14 Thread Timothy Arceri
On Thu, 2016-01-14 at 14:15 +0200, Tapani Pälli wrote: > If shader declares uniform explicit location in one stage but > implicit in another, explicit location should be used. Patch marks > implicit uniforms as explicit if they were explicit in previous > stage. > This makes sure that we don't

[Mesa-dev] [Bug 93686] Performance improvement ?=:=?UTF-8?Q? Please consider hardware ɢᴘᴜ rendering in llvmpipe

2016-01-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=93686 --- Comment #3 from ytr...@sdf-eu.org --- (In reply to Roland Scheidegger from comment #2) > I'm not sure if this exact same proposal really came up already. We have > seen some though asking if we couldn't combine llvmpipe with less capable >

[Mesa-dev] [Bug 93686] Performance improvement ?=:=?UTF-8?Q? Please consider hardware ɢᴘᴜ rendering in llvmpipe

2016-01-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=93686 --- Comment #4 from Roland Scheidegger --- (In reply to ytrezq from comment #3) > I don’t think it’s necessary to combine 5 years old low end 90nm gpu with a > 14nm high end cpu. For example (comparing the hd 2500 integrated

[Mesa-dev] [Bug 93686] Performance improvement ?=:=?UTF-8?Q? Please consider hardware ɢᴘᴜ rendering in llvmpipe

2016-01-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=93686 --- Comment #5 from ytr...@sdf-eu.org --- (In reply to Roland Scheidegger from comment #4) > (In reply to ytrezq from comment #3) > I'm not sure what you exactly mean here: They do "load balancing" with > multiple gpus as part of SLI You don’t

[Mesa-dev] [Bug 93628] Exception: attempt to use unavailable module DRM when building MesaGL 11.1.0 on windows

2016-01-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=93628 Maurits changed: What|Removed |Added CC|

Re: [Mesa-dev] [PATCH] glsl: allow duplicate layout-qualifier-names

2016-01-14 Thread Matt Turner
On Wed, Jan 13, 2016 at 9:26 PM, Timothy Arceri wrote: > The special case from detecting stream duplicates is also > removed, as testing never trigged this error. > > From the ARB_shading_language_420pack spec: > >"More than one layout qualifier may appear in a

[Mesa-dev] [PATCH 1/2] llvmpipe: fix "leaking" textures

2016-01-14 Thread sroland
From: Roland Scheidegger This was not really a leak per se, but we were referencing the textures for longer than intended. If textures were set via llvmpipe_set_sampler_views() (for fs) and then picked up by lp_setup_set_fragment_sampler_views(), they were referenced in the

[Mesa-dev] [PATCH 1/5] glsl: add missing explicit_stream flag to has_layout()

2016-01-14 Thread Timothy Arceri
This will allow the ARB_shading_language_420pack rules in glsl_parser.yy for catching duplicate layout qualifiers to be triggered for the stream identifier rather than relying on the code meant to catch duplicates within a single layout(...) Cc: Samuel Iglesias Gonsálvez

[Mesa-dev] [PATCH 4/5] glsl: partially add missing support for duplicate layouts on globals

2016-01-14 Thread Timothy Arceri
From the ARB_shading_language_420pack spec: "More than one layout qualifier may appear in a single declaration. If the same layout-qualifier-name occurs in multiple layout qualifiers for the same declaration, the last one overrides the former ones." Full support will require merging

[Mesa-dev] [PATCH 5/5] glsl: allow multiple layout qualifiers for a single declaration

2016-01-14 Thread Timothy Arceri
From the ARB_shading_language_420pack spec: "More than one layout qualifier may appear in a single declaration. If the same layout-qualifier-name occurs in multiple layout qualifiers for the same declaration, the last one overrides the former ones." The parser was already failing

[Mesa-dev] [PATCH 3/5] glsl: allow duplicate layout-qualifier-names

2016-01-14 Thread Timothy Arceri
This is added by ARB_enhanced_layouts although it doesn't fit into any of the six main changes so enable it independently. From the ARB_enhanced_layouts spec: "More than one layout qualifier may appear in a single declaration. Additionally, the same layout-qualifier-name can occur

[Mesa-dev] [PATCH 2/5] glsl: remove special case for detecting stream duplicates

2016-01-14 Thread Timothy Arceri
Any duplicates in a single declaration will already fail the generic duplicates test due to the explicit_stream flag being set. Cc: Samuel Iglesias Gonsálvez --- src/glsl/ast_type.cpp | 5 - 1 file changed, 5 deletions(-) diff --git a/src/glsl/ast_type.cpp

Re: [Mesa-dev] radeonsi: "Warning: Compiler emitted unknown config register: 0x286d0"

2016-01-14 Thread Michel Dänzer
On 15.01.2016 05:53, Gustaw Smolarczyk wrote: > Hi, > > After playing CS: GO a bit I have found quite a few of these messages: > > Warning: Compiler emitted unknown config register: 0x286d0 > > The register in question seems to be R_0286D0_SPI_PS_INPUT_ADDR. If I > understand correctly, it is

Re: [Mesa-dev] [PATCH 27/28] mesa: add LOCATION_COMPONENT support to GetProgramResourceiv

2016-01-14 Thread Timothy Arceri
On Thu, 2016-01-14 at 12:24 -0800, Anuj Phogat wrote: > On Mon, Dec 28, 2015 at 9:00 PM, Timothy Arceri > wrote: > > From Section 7.3.1.1 (Naming Active Resources) of the OpenGL 4.5 > > spec: > > > >"For the property LOCATION_COMPONENT, a single integer > >

[Mesa-dev] [PATCH 2/2] llvmpipe: ditch ref counting for vertex/geometry shader sampler views

2016-01-14 Thread sroland
From: Roland Scheidegger The cleaning up was quite a performance hog (making pipe_resource_reference the number two in profilers on the vertex path, and 3rd overall, with its cousin pipe_reference_described not far behind) if there were lots of tiny draw calls (ipers). Now

[Mesa-dev] [PATCH 1/3] i965: Fix cache pollution race during L3 partitioning set-up.

2016-01-14 Thread Francisco Jerez
We need to split the stalling flush from the RO cache invalidation into a different PIPE_CONTROL command to make sure that the top of the pipe invalidation happens after any previous rendering is complete. Otherwise it's possible for previous rendering to pollute the L3 cache in the short window

[Mesa-dev] [PATCH 3/3] i965: Rename define for the PIPE_CONTROL DC flush bit.

2016-01-14 Thread Francisco Jerez
Its previous name was somewhat misleading, this really behaves like a RW cache flush rather than an invalidation. --- src/mesa/drivers/dri/i965/brw_pipe_control.c | 2 +- src/mesa/drivers/dri/i965/brw_program.c | 2 +- src/mesa/drivers/dri/i965/gen7_l3_state.c| 4 ++--

[Mesa-dev] [PATCH 2/3] i965: Invalidate state cache before L3 partitioning set-up.

2016-01-14 Thread Francisco Jerez
The state cache is also L3-backed so it seems sensible to make sure it's clean as we do for other RO caches before repartitioning the L3. This wasn't part of my original L3 partitioning code because I was able to reproduce hangs on Gen7 hardware when the state cache invalidation happened

[Mesa-dev] [PATCH 1/2] radeonsi: Print "LLVM emitted unknown config register" warning only once

2016-01-14 Thread Michel Dänzer
From: Michel Dänzer Say "LLVM" instead of "Compiler" for clarity. Signed-off-by: Michel Dänzer --- src/gallium/drivers/radeonsi/si_shader.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git

[Mesa-dev] [PATCH 2/2] radeonsi: Avoid warning about LLVM generating R_0286D0_SPI_PS_INPUT_ADDR

2016-01-14 Thread Michel Dänzer
From: Michel Dänzer Signed-off-by: Michel Dänzer --- src/gallium/drivers/radeonsi/si_shader.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index

Re: [Mesa-dev] [PATCH] android: enable building static version of libdrm

2016-01-14 Thread Chih-Wei Huang
Rob Herring 於 西元2016年01月14日 00:20 寫道: From: Sumit Semwal Android needs libdrm built statically for recovery; enable that as well. Signed-off-by: Sumit Semwal Signed-off-by: Rob Herring Cc: Chih-Wei Huang

[Mesa-dev] [Bug 92000] Requesting a New Account

2016-01-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92000 --- Comment #9 from Alejandro Piñeiro (freenode IRC: apinheiro) --- (In reply to Daniel Stone from comment #8) > sure, done now Just tested. Pushing to piglit working. Thank you very much! -- You are receiving this mail

[Mesa-dev] [PATCH] st/mesa: use surface format to generate mipmaps when available

2016-01-14 Thread Ilia Mirkin
This fixes the recently posted mipmap + texture views piglit test. Signed-off-by: Ilia Mirkin Cc: "11.0 11.1" --- src/mesa/state_tracker/st_gen_mipmap.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git

Re: [Mesa-dev] [PATCH] st/mesa: use surface format to generate mipmaps when available

2016-01-14 Thread Roland Scheidegger
Looks good to me. Reviewed-by: Roland Scheidegger Am 14.01.2016 um 19:46 schrieb Ilia Mirkin: > This fixes the recently posted mipmap + texture views piglit test. > > Signed-off-by: Ilia Mirkin > Cc: "11.0 11.1" >

[Mesa-dev] [Bug 92000] Requesting a New Account

2016-01-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92000 --- Comment #7 from Alejandro Piñeiro (freenode IRC: apinheiro) --- (In reply to Daniel Stone from comment #6) > done Hi, although I was able to push commits on mesa since September 2015, today I realized that I don't

Re: [Mesa-dev] [PATCH 7/7] i965/vec4: Drop support for ATTR as an instruction destination.

2016-01-14 Thread Kenneth Graunke
On Thursday, January 14, 2016 10:26:37 AM PST Matt Turner wrote: > On Wed, Jan 13, 2016 at 8:33 PM, Kenneth Graunke wrote: > > This is no longer necessary...and it doesn't make much sense to > > have inputs as destinations. > > > > Signed-off-by: Kenneth Graunke

Re: [Mesa-dev] [PATCH 6/7] i965/vec4/gs: Stop munging the ATTR containing gl_PointSize.

2016-01-14 Thread Matt Turner
On Wed, Jan 13, 2016 at 8:33 PM, Kenneth Graunke wrote: > gl_PointSize is delivered in the .w component of the VUE header, while > the language expects it to be a float (and thus in the .x component). > > Previously, we emitted MOVs to copy it over to the .x component. >

Re: [Mesa-dev] [PATCH 5/7] i965: Apply VS attribute workarounds in NIR.

2016-01-14 Thread Kenneth Graunke
On Thursday, January 14, 2016 10:23:45 AM PST Matt Turner wrote: > On Wed, Jan 13, 2016 at 8:33 PM, Kenneth Graunke wrote: > > This patch re-implements the pre-Haswell VS attribute workarounds. > > Instead of emitting shader code in the vec4 backend, we now simply > > call

Re: [Mesa-dev] [PATCH 2/2] i965/fs: Always set hannel 2 of texture headers in some stages

2016-01-14 Thread Jordan Justen
On 2016-01-14 20:43:17, Jason Ekstrand wrote: > --- > src/mesa/drivers/dri/i965/brw_fs_generator.cpp | 16 > 1 file changed, 16 insertions(+) > > diff --git a/src/mesa/drivers/dri/i965/brw_fs_generator.cpp > b/src/mesa/drivers/dri/i965/brw_fs_generator.cpp > index

[Mesa-dev] [PATCH 2/2] i965/fs: Always set hannel 2 of texture headers in some stages

2016-01-14 Thread Jason Ekstrand
--- src/mesa/drivers/dri/i965/brw_fs_generator.cpp | 16 1 file changed, 16 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_fs_generator.cpp b/src/mesa/drivers/dri/i965/brw_fs_generator.cpp index eebb485..70ca7cd 100644 ---

Re: [Mesa-dev] [PATCH v2] mesa: remove link validation that should be done elsewhere

2016-01-14 Thread Tapani Pälli
On 01/06/2016 03:40 AM, Timothy Arceri wrote: Even if re-linking fails rendering shouldn't fail as the previous succesfully linked program will still be available. It also shouldn't be possible to have an unlinked program as part of the current rendering state. This fixes a subtest in:

[Mesa-dev] [PATCH 1/2] i965/fs/generator: Take an actual shader stage rather than a string

2016-01-14 Thread Jason Ekstrand
--- src/mesa/drivers/dri/i965/brw_blorp_blit_eu.cpp | 2 +- src/mesa/drivers/dri/i965/brw_fs.cpp | 6 -- src/mesa/drivers/dri/i965/brw_fs.h| 4 ++-- src/mesa/drivers/dri/i965/brw_fs_generator.cpp| 7 --- src/mesa/drivers/dri/i965/brw_shader.cpp

Re: [Mesa-dev] [PATCH 2/2] i965/fs: Always set hannel 2 of texture headers in some stages

2016-01-14 Thread Jason Ekstrand
On Jan 14, 2016 9:30 PM, "Jordan Justen" wrote: > > On 2016-01-14 20:43:17, Jason Ekstrand wrote: > > --- > > src/mesa/drivers/dri/i965/brw_fs_generator.cpp | 16 > > 1 file changed, 16 insertions(+) > > > > diff --git

Re: [Mesa-dev] [PATCH 1/5] glsl: add missing explicit_stream flag to has_layout()

2016-01-14 Thread Samuel Iglesias Gonsálvez
Reviewed-by: Samuel Iglesias Gonsálvez On Fri, 2016-01-15 at 13:45 +1100, Timothy Arceri wrote: > This will allow the ARB_shading_language_420pack rules in > glsl_parser.yy for catching duplicate layout qualifiers to be > triggered for the stream identifier rather than

Re: [Mesa-dev] [PATCH 2/5] glsl: remove special case for detecting stream duplicates

2016-01-14 Thread Samuel Iglesias Gonsálvez
Reviewed-by: Samuel Iglesias Gonsálvez On Fri, 2016-01-15 at 13:45 +1100, Timothy Arceri wrote: > Any duplicates in a single declaration will already fail the > generic duplicates test due to the explicit_stream flag being set. > > Cc: Samuel Iglesias Gonsálvez

Re: [Mesa-dev] Mesa (master): glsl: restrict consumer stage condition to modify interpolation type

2016-01-14 Thread Michel Dänzer
On 15.01.2016 15:12, Samuel Iglesias =?UNKNOWN?Q?Gons=C3=A1lvez?= wrote: > Module: Mesa > Branch: master > Commit: 781d2787bc1cf975757a95d0d9324f734fa61c09 > URL: > http://cgit.freedesktop.org/mesa/mesa/commit/?id=781d2787bc1cf975757a95d0d9324f734fa61c09 > > Author: Samuel Iglesias Gonsálvez

Re: [Mesa-dev] [PATCH] glsl: Allow implicit int -> uint conversions for bitwise operators (&, ^, |).

2016-01-14 Thread Timothy Arceri
Reviewed-by: Timothy Arceri ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] gallium/radeon: Rename do_invalidate_resource to invalidate_buffer

2016-01-14 Thread Michel Dänzer
From: Michel Dänzer And only call it from r600_invalidate_resource for buffer resources. Signed-off-by: Michel Dänzer --- src/gallium/drivers/radeon/r600_buffer_common.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff

[Mesa-dev] [PATCH] st/dri: Don't call invalidate_resource for NULL depth/stencil buffers

2016-01-14 Thread Michel Dänzer
From: Michel Dänzer Fixes crash in 4 EGL piglit tests with radeonsi. Signed-off-by: Michel Dänzer --- src/gallium/state_trackers/dri/dri_drawable.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git

[Mesa-dev] [PATCH] glsl: Allow implicit int -> uint conversions for bitwise operators (&, ^, |).

2016-01-14 Thread Kenneth Graunke
The ARB has decided that implicit conversions should be performed for bitwise operators in future language revisions. Implementations of current language revisions may or may not perform them. This patch makes Mesa apply implicti conversions even on current language versions. Applications

Re: [Mesa-dev] [PATCH] glsl: Allow implicit int -> uint conversions for bitwise operators (&, ^, |).

2016-01-14 Thread Timothy Arceri
I guess some piglit tests also? ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] Mesa (master): glsl: restrict consumer stage condition to modify interpolation type

2016-01-14 Thread Samuel Iglesias Gonsálvez
On Fri, 2016-01-15 at 16:36 +0900, Michel Dänzer wrote: > On 15.01.2016 15:12, Samuel Iglesias =?UNKNOWN?Q?Gons=C3=A1lvez?= > wrote: > > Module: Mesa > > Branch: master > > Commit: 781d2787bc1cf975757a95d0d9324f734fa61c09 > > URL:http://cgit.freedesktop.org/mesa/mesa/commit/?id=781d2787bc > >

[Mesa-dev] [PATCH] i965/vec4: Use UW type for multiply into accumulator on GEN8+

2016-01-14 Thread Jason Ekstrand
BDW adds the following restriction: "When multiplying DW x DW, the dst cannot be accumulator." --- src/mesa/drivers/dri/i965/brw_vec4_nir.cpp | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_vec4_nir.cpp

Re: [Mesa-dev] [PATCH 25/28] glsl: move packed varying creation code to a helper

2016-01-14 Thread Anuj Phogat
On Mon, Dec 28, 2015 at 9:00 PM, Timothy Arceri wrote: > This will also be used by tessellation packing code > in a following patch. > --- > src/glsl/lower_packed_varyings.cpp | 45 > +- > 1 file changed, 30 insertions(+), 15

Re: [Mesa-dev] [PATCH 27/28] mesa: add LOCATION_COMPONENT support to GetProgramResourceiv

2016-01-14 Thread Anuj Phogat
On Mon, Dec 28, 2015 at 9:00 PM, Timothy Arceri wrote: > From Section 7.3.1.1 (Naming Active Resources) of the OpenGL 4.5 spec: > >"For the property LOCATION_COMPONENT, a single integer indicating the first >component of the location assigned to an active

[Mesa-dev] radeonsi: "Warning: Compiler emitted unknown config register: 0x286d0"

2016-01-14 Thread Gustaw Smolarczyk
Hi, After playing CS: GO a bit I have found quite a few of these messages: Warning: Compiler emitted unknown config register: 0x286d0 The register in question seems to be R_0286D0_SPI_PS_INPUT_ADDR. If I understand correctly, it is emitted by LLVM AMDGPU backend. Is it something I should worry

Re: [Mesa-dev] [PATCH 5/7] i965: Apply VS attribute workarounds in NIR.

2016-01-14 Thread Matt Turner
On Wed, Jan 13, 2016 at 8:33 PM, Kenneth Graunke wrote: > This patch re-implements the pre-Haswell VS attribute workarounds. > Instead of emitting shader code in the vec4 backend, we now simply > call a NIR pass to emit the necessary code. > > This simplifies the vec4

Re: [Mesa-dev] [PATCH 7/7] i965/vec4: Drop support for ATTR as an instruction destination.

2016-01-14 Thread Matt Turner
On Wed, Jan 13, 2016 at 8:33 PM, Kenneth Graunke wrote: > This is no longer necessary...and it doesn't make much sense to > have inputs as destinations. > > Signed-off-by: Kenneth Graunke > --- I don't think I realized they were ever destinations.

Re: [Mesa-dev] [PATCH 6/7] i965/vec4/gs: Stop munging the ATTR containing gl_PointSize.

2016-01-14 Thread Kenneth Graunke
On Thursday, January 14, 2016 10:24:32 AM PST Matt Turner wrote: > On Wed, Jan 13, 2016 at 8:33 PM, Kenneth Graunke wrote: > > gl_PointSize is delivered in the .w component of the VUE header, while > > the language expects it to be a float (and thus in the .x component). >

Re: [Mesa-dev] [PATCH 22/28] glsl: get geometry shader vertex count from type when packing

2016-01-14 Thread Anuj Phogat
On Mon, Dec 28, 2015 at 9:00 PM, Timothy Arceri wrote: > Rather than passing in the vertex count to the packing pass just use > the outermost array size to get the count. > --- > src/glsl/ir_optimization.h | 3 +- > src/glsl/link_varyings.cpp | 21

Re: [Mesa-dev] [PATCH 24/28] glsl: make needs_lowering() a shared packing helper function

2016-01-14 Thread Anuj Phogat
On Mon, Dec 28, 2015 at 9:00 PM, Timothy Arceri wrote: > --- > src/glsl/lower_packed_varyings.cpp | 58 > +++--- > 1 file changed, 29 insertions(+), 29 deletions(-) > > diff --git a/src/glsl/lower_packed_varyings.cpp >

[Mesa-dev] [Bug 92000] Requesting a New Account

2016-01-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=92000 --- Comment #8 from Daniel Stone --- sure, done now -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. ___ mesa-dev

Re: [Mesa-dev] [PATCH] i965/vec4: Use UW type for multiply into accumulator on GEN8+

2016-01-14 Thread Matt Turner
On Thu, Jan 14, 2016 at 12:08 PM, Jason Ekstrand wrote: > BDW adds the following restriction: "When multiplying DW x DW, the dst > cannot be accumulator." > --- > src/mesa/drivers/dri/i965/brw_vec4_nir.cpp | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) > >

Re: [Mesa-dev] [PATCH] st/mesa: use surface format to generate mipmaps when available

2016-01-14 Thread Marek Olšák
Hi Ilia, surface_based originally meant that the resource has been imported from a DMABUF or GEM FLINK handle. Such resources can't be reallocated ever, nor can they be mipmapped. Marek On Thu, Jan 14, 2016 at 7:46 PM, Ilia Mirkin wrote: > This fixes the recently posted

Re: [Mesa-dev] [PATCH] st/mesa: use surface format to generate mipmaps when available

2016-01-14 Thread Ilia Mirkin
H well I set ->surface_based = TRUE on texture views. It seemed to correspond to the restrictions of surface-based elsewhere, but I probably wasn't 100% sure what the deal was back when I added the logic. On Thu, Jan 14, 2016 at 2:38 PM, Marek Olšák wrote: > Hi Ilia, >