[Mesa-dev] [PATCH] Better explain why we are lowering the num_tile_pipes value for TAHITI (v2)

v2: Clarify the relation between num_tiles_pipes and GB_TILE_MODE and the fix needed for Tahiti as suggested by Marek. Signed-off-by: Alexandre Demers --- src/gallium/winsys/radeon/drm/radeon_drm_winsys.c | 6 -- 1 file changed, 4 insertions(+), 2

Re: [Mesa-dev] [PATCH 11/23] i965/gen8: Remove dead assertion

On Tue, Feb 09, 2016 at 03:40:07PM -0800, Ben Widawsky wrote: > On Mon, Feb 08, 2016 at 06:51:31PM +0200, Topi Pohjolainen wrote: > > The assertion is inside a condition mandating num_samples > 1 and > > therefore the first half of the constraint is always met. The > > second half in turn would

Re: [Mesa-dev] [PATCH] radeonsi: put image, fmask, and sampler descriptors into one array

On 10.02.2016 09:16, Marek Olšák wrote: From: Marek Olšák The texture slot is expanded to 16 dwords containing 2 descriptors. Those can be: - Image and fmask, or - Image and sampler state By carefully choosing the locations, we can put all three into one slot, with the

[Mesa-dev] [Bug 92265] Black windows in weston after update mesa to 11.0.2-1

https://bugs.freedesktop.org/show_bug.cgi?id=92265 --- Comment #18 from Eduardo Lima Mitev --- I just submitted a patch to Mesa that fixes the issue with GL_BGRA that remained, and makes the piglit test "spec@ext_texture_format_bgra@api-errors" pass:

Re: [Mesa-dev] [PATCH] Better explain why we are lowering the num_tile_pipes value for TAHITI

On 2016-02-10 05:14, Marek Olšák wrote: On Wed, Feb 10, 2016 at 2:11 AM, Alexandre Demers wrote: Signed-off-by: Alexandre Demers --- src/gallium/winsys/radeon/drm/radeon_drm_winsys.c | 5 +++-- 1 file changed, 3 insertions(+), 2

Re: [Mesa-dev] building with -Wshadow

Hi Dave, On 10 February 2016 at 04:43, Dave Airlie wrote: > I was just messing with warning flags on virglrenderer and noticed > -Wshadow generated a fair few warnings with gallium, so I did a mesa > build with -Wshadow enabled and it was fairly messy, > > do we care? there

Re: [Mesa-dev] [PATCH 06/23] i965/gen9: Add buffer layout representing lossless compression

On Tue, Feb 09, 2016 at 03:13:40PM -0800, Ben Widawsky wrote: > On Mon, Feb 08, 2016 at 06:51:26PM +0200, Topi Pohjolainen wrote: > > Skylake introduces compression support also for the single-sampled > > color buffers. Similarly to the multi-sampled case the color buffer > > will be associated

[Mesa-dev] [PATCH] mesa/glformats: Bypass resolving effective internal format for GL_BGRA

Currently, when validating format and type on ES3, we treat GL_BGRA as a special case when obtaining the effective internal format from the format and type. This is because _mesa_base_tex_format() returns GL_RGBA as base format for GL_BGRA (and quite a few code paths depend on this behavior).

[Mesa-dev] [PATCH] radeonsi: put image, fmask, and sampler descriptors into one array

From: Marek Olšák The texture slot is expanded to 16 dwords containing 2 descriptors. Those can be: - Image and fmask, or - Image and sampler state By carefully choosing the locations, we can put all three into one slot, with the fmask and sampler state being mutually

[Mesa-dev] [Bug 94078] swrast-on-vgem not supported in dri3

https://bugs.freedesktop.org/show_bug.cgi?id=94078 Bug ID: 94078 Summary: swrast-on-vgem not supported in dri3 Product: Mesa Version: git Hardware: Other OS: All Status: NEW Severity: normal

Re: [Mesa-dev] [PATCH 4/4] i965: Make brw_clear_cache flag all the bits on both pipelines.

On Tue, Feb 9, 2016 at 7:49 PM, Kenneth Graunke wrote: > Setting brw->ctx.NewDriverState and brw->ctx.NewGLState affects > the dirty bits for the current pipeline. But, we need to flag > everything dirty on *both* pipelines, so that when we switch > back, we'll realize our

Re: [Mesa-dev] building with -Wshadow

Am 10.02.2016 um 05:43 schrieb Dave Airlie: > I was just messing with warning flags on virglrenderer and noticed > -Wshadow generated a fair few warnings with gallium, so I did a mesa > build with -Wshadow enabled and it was fairly messy, > > do we care? there could be bugs hiding in -Wshadow

Re: [Mesa-dev] [PATCH v3] workarounds: Update workaround names and platforms

> -Original Message- > From: Widawsky, Benjamin > Sent: Tuesday, February 09, 2016 10:04 PM > To: Matt Turner > Cc: Kibey, Sameer; mesa-dev@lists.freedesktop.org; Kenneth Graunke > Subject: Re: [Mesa-dev] [PATCH v3] workarounds: Update workaround > names and platforms > > On Tue, Feb 09,

Re: [Mesa-dev] [PATCH] Better explain why we are lowering the num_tile_pipes value for TAHITI (v2)

Thanks, I will push this shortly. Marek On Wed, Feb 10, 2016 at 3:45 PM, Alexandre Demers wrote: > v2: Clarify the relation between num_tiles_pipes and GB_TILE_MODE and the fix > needed for Tahiti as suggested by Marek. > > Signed-off-by: Alexandre Demers

[Mesa-dev] [PATCH v3 12/19] st/mesa: add conversion for compute shaders

According to the spec, there are no predefined inputs nor any fixed-function outputs. Signed-off-by: Samuel Pitoiset Reviewed-by: Ilia Mirkin --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 8 src/mesa/state_tracker/st_program.c

[Mesa-dev] [PATCH v3 08/19] gallium: add PIPE_SHADER_CAP_SUPPORTED_IRS

This cap indicates the supported representations of programs. It should be a mask of pipe_shader_ir bits. It will allow to enable ARB_compute_shader if the underlying driver supports TGSI. Changes from v2: - improve description of PIPE_SHADER_CAP_SUPPORTED_IRS Signed-off-by: Samuel Pitoiset

[Mesa-dev] [PATCH v3 06/19] gallium: add a new interface for pipe_context::launch_grid()

This introduces pipe_grid_info which contains all information to describe a launch_grid call. This will be used to implement indirect compute in the same fashion as indirect draw. Changes from v2: - correctly initialize pipe_grid_info for nv50/nvc0 Signed-off-by: Samuel Pitoiset

[Mesa-dev] [PATCH v3 00/19] add compute shaders support

Hi, This series adds the core support for ARB_compute_shader which is required for OpenGL 4.3. This series is now based on mesa master since Ilia has pushed his work related to ssbo+atomics. In piglit, this passes all compute related tests except two of them which are related to

[Mesa-dev] [PATCH v3 04/19] mesa: add PROGRAM_MEMORY

This will be used for shared, global and local memory areas. Signed-off-by: Samuel Pitoiset Reviewed-by: Ilia Mirkin --- src/mesa/main/mtypes.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h

[Mesa-dev] [PATCH v3 10/19] st/mesa: add a second pipeline for compute

Compute needs a new and different validation path. Changes from v2: - make use of unreachable() instead of assert() when the pipeline is invalid - move the st_pipeline enumeration to st_context.h instead of st_api.h Signed-off-by: Samuel Pitoiset Reviewed-by:

[Mesa-dev] [PATCH v3 13/19] st/mesa: add intrinsics for shared variables

This adds GLSL intrinsics for load/store and atomic operations. Changes from v2: - use PROGRAM_MEMORY instead of PROGRAM_BUFFER Signed-off-by: Samuel Pitoiset Reviewed-by: Ilia Mirkin (v1) --- src/mesa/state_tracker/st_extensions.c | 3 +

[Mesa-dev] [PATCH v3 11/19] st/mesa: add compute shader states

Signed-off-by: Samuel Pitoiset Reviewed-by: Marek Olšák Reviewed-by: Ilia Mirkin --- src/mesa/state_tracker/st_atom.c| 2 +- src/mesa/state_tracker/st_atom.h| 1 + src/mesa/state_tracker/st_atom_shader.c

[Mesa-dev] [PATCH v3 03/19] mesa: store shared size in gl_compute_program

The size of shared variables needs to be stored in gl_compute_program in order to set up pipe_compute_state::req_local_mem. Signed-off-by: Samuel Pitoiset Reviewed-by: Ilia Mirkin --- src/mesa/main/mtypes.h| 5 +

[Mesa-dev] [PATCH v3 05/19] gallium/cso: add support for compute shaders

Changes from v2: - removed cso_{save,restore}_compute_shader() functions and the compute_shader_saved variable because disabling compute shaders for meta ops is not currently needed Signed-off-by: Samuel Pitoiset Reviewed-by: Ilia Mirkin

[Mesa-dev] [PATCH v3 07/19] gallium: add indirect compute parameters to pipe_grid_info

Like indirect draw, we need to store a resource and an offset that needs to be 4 byte aligned. When indirect is used, the size of the grid (in blocks) is stored with three 32-bit integers. Changes from v2: - s/most values/block sizes/ Signed-off-by: Samuel Pitoiset

Re: [Mesa-dev] building with -Wshadow

On 02/09/2016 08:43 PM, Dave Airlie wrote: > I was just messing with warning flags on virglrenderer and noticed > -Wshadow generated a fair few warnings with gallium, so I did a mesa > build with -Wshadow enabled and it was fairly messy, > > do we care? there could be bugs hiding in -Wshadow

Re: [Mesa-dev] [PATCH 1/2] mesa: call build_program_resource_list inside Driver.LinkShader

On Fri, Feb 5, 2016 at 8:57 PM, Ian Romanick wrote: > On 01/30/2016 06:48 AM, Marek Olšák wrote: >> From: Marek Olšák >> >> to allow LinkShader to free the GLSL IR. >> --- >> src/compiler/glsl/program.h| 5 - >>

Re: [Mesa-dev] [v2 1/2] i965: Validate textures before altering driver state

On 01/28/2016 02:29 PM, Topi Pohjolainen wrote: > Validation may kick off copies and subsequently color resolves. > Color resolves (and the copies themselves if ending up in meta path) > will overwrite the internal driver state but are not prepared to > restore it. Instead of adding that

Re: [Mesa-dev] building with -Wshadow

On 02/10/2016 10:48 AM, Ian Romanick wrote: > On 02/09/2016 08:43 PM, Dave Airlie wrote: >> I was just messing with warning flags on virglrenderer and noticed >> -Wshadow generated a fair few warnings with gallium, so I did a mesa >> build with -Wshadow enabled and it was fairly messy, >> >> do we

Re: [Mesa-dev] [PATCH v3] workarounds: Update workaround names and platforms

On Tue, Feb 9, 2016 at 10:04 PM, Ben Widawsky wrote: > On Tue, Feb 09, 2016 at 10:35:45AM -0800, Matt Turner wrote: >> On Tue, Feb 9, 2016 at 9:44 AM, Sameer Kibey wrote: >> > Update the format in which workarounds are documented >> > in the

Re: [Mesa-dev] [PATCH v3] workarounds: Update workaround names and platforms

On 02/10/2016 12:35 PM, Matt Turner wrote: > On Tue, Feb 9, 2016 at 10:04 PM, Ben Widawsky > wrote: >> On Tue, Feb 09, 2016 at 10:35:45AM -0800, Matt Turner wrote: >>> On Tue, Feb 9, 2016 at 9:44 AM, Sameer Kibey wrote: Update the format

[Mesa-dev] [PATCH] nir/lower_vec_to_movs: Better report channels handled by insert_mov

This fixes two issues. First, we had a use-after-free in the case where the instruction got deleted and we tried to return mov->dest.write_mask. Second, in the case where we are doing a self-mov of a register, we delete those channels that are moved to themselves from the write-mask. This means

[Mesa-dev] [PATCH v4] i965: Update workaround names and platforms

Update the format in which workarounds are documented in the source code. This allows mesa to be parsed by the list-workarounds utility in intel-gpu-tools. Signed-off-by: Sameer Kibey --- src/mesa/drivers/dri/i965/brw_binding_tables.c | 3 ++-

[Mesa-dev] [PATCH 3/3] gallium/radeon: drop support for LLVM 3.5

From: Marek Olšák --- configure.ac | 2 +- src/gallium/drivers/r600/evergreen_compute.c | 75 -- .../drivers/r600/evergreen_compute_internal.h | 19 -- src/gallium/drivers/r600/r600_pipe.c

[Mesa-dev] [PATCH 2/3] radeonsi: obtain commonly used LLVM types only once

From: Marek Olšák --- src/gallium/drivers/radeonsi/si_shader.c | 400 +++ 1 file changed, 187 insertions(+), 213 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index

[Mesa-dev] [PATCH 1/3] radeonsi: cleanup shader codegen

From: Marek Olšák si_shader_ctx -> ctx type * ptr -> type *ptr si_shader_context *shader -> si_shader_context *ctx --- src/gallium/drivers/radeonsi/si_shader.c | 850 +++ 1 file changed, 425 insertions(+), 425 deletions(-) diff --git

Re: [Mesa-dev] [PATCH 3/4] i965: Make L3 partitioning code only use the current pipeline's shaders.

Kenneth Graunke writes: > When uploading state for the compute pipeline, we don't want to > look at VS/TCS/TES/GS/FS programs, as they might be stale, and > aren't relevant anyway. Likewise, the render pipeline shouldn't > look at CS. The intended behaviour of this

Re: [Mesa-dev] [PATCH 1/2] mesa: call build_program_resource_list inside Driver.LinkShader

This patch is Reviewed-by: Ian Romanick On 02/10/2016 11:28 AM, Marek Olšák wrote: > On Fri, Feb 5, 2016 at 8:57 PM, Ian Romanick wrote: >> On 01/30/2016 06:48 AM, Marek Olšák wrote: >>> From: Marek Olšák >>> >>> to allow

[Mesa-dev] [PATCH] i965/gen7: Require kernel cmd_parser 5 for ARB_compute_shader

The indirect dispatch registers were whitelisted in command parser version 5. (Version 5 is available as of Linux 4.4) Signed-off-by: Jordan Justen --- src/mesa/drivers/dri/i965/intel_extensions.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

Re: [Mesa-dev] [PATCH v3] workarounds: Update workaround names and platforms

On Wed, Feb 10, 2016 at 12:57 PM, Ian Romanick wrote: > On 02/10/2016 12:35 PM, Matt Turner wrote: >> On Tue, Feb 9, 2016 at 10:04 PM, Ben Widawsky >> wrote: >>> On Tue, Feb 09, 2016 at 10:35:45AM -0800, Matt Turner wrote: On Tue, Feb 9,

[Mesa-dev] [PATCH] Android: fix build break from nir/glsl move to compiler/

Commits a39a8fbbaa12 ("nir: move to compiler/") and eb63640c1d38 ("glsl: move to compiler/") broke Android builds. Fix them. There is also a missing dependency between generated NIR headers and several libraries. This isn't a new issue, but seems to have been exposed by the NIR move. Built with

[Mesa-dev] [PATCH] Android: fix build break in libmesa_program

Commit 5fd848f6c9ee ("program: Use _mesa_geometric_samples to calculate gl_NumSamples") broken Android builds. Add the missing include path to fix it. Cc: Neil Roberts Signed-off-by: Rob Herring --- Another rebase to master, another build break. This has a

Re: [Mesa-dev] [PATCH] nir/lower_vec_to_movs: Better report channels handled by insert_mov

On Wed, Feb 10, 2016 at 1:47 PM, Matt Turner wrote: > On Wed, Feb 10, 2016 at 1:27 PM, Jason Ekstrand > wrote: > > This fixes two issues. First, we had a use-after-free in the case where > > the instruction got deleted and we tried to return

Re: [Mesa-dev] i965/gen9: Compression support for single-sampled

On Wed, Feb 10, 2016 at 02:13:27PM +0200, Pohjolainen, Topi wrote: > On Tue, Feb 09, 2016 at 05:34:53PM -0800, Ben Widawsky wrote: > > On Mon, Feb 08, 2016 at 06:51:20PM +0200, Topi Pohjolainen wrote: > > > This series enables compression for single sampled color surfaces, > > > also referred to

Re: [Mesa-dev] [PATCH] i965/gen7: Require kernel cmd_parser 5 for ARB_compute_shader

On Wednesday, February 10, 2016 1:25:23 PM PST Jordan Justen wrote: > The indirect dispatch registers were whitelisted in command parser > version 5. (Version 5 is available as of Linux 4.4) > > Signed-off-by: Jordan Justen > --- >

Re: [Mesa-dev] [PATCH] nir/lower_vec_to_movs: Better report channels handled by insert_mov

On Wed, Feb 10, 2016 at 1:27 PM, Jason Ekstrand wrote: > This fixes two issues. First, we had a use-after-free in the case where > the instruction got deleted and we tried to return mov->dest.write_mask. > Second, in the case where we are doing a self-mov of a register, we

Re: [Mesa-dev] [PATCH 2/3] radeonsi: obtain commonly used LLVM types only once

Also, I'm adding this in order to initialize the types for GS properly. (I've just run piglit) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index fa4e26a..baa1090 100644 --- a/src/gallium/drivers/radeonsi/si_shader.c +++

[Mesa-dev] [PATCH] gallium: introduce load_pipe_screen()

Introduce load_pipe_screen() public entry point for other code which dlopen()'s gralloc_dri.so for purposes of loading a pipe_screen. This way drm_gralloc can avoid static linking of each gallium winsys and driver, and avoid duplicated logic to figure out which pipe driver to load. This is based

Re: [Mesa-dev] [PATCH 01/23] i965: Let caller of intel_miptree_create_layout() decide msaa layout

On Wed, Feb 10, 2016 at 10:27:46AM +0200, Pohjolainen, Topi wrote: > On Tue, Feb 09, 2016 at 12:05:52PM -0800, Ben Widawsky wrote: > > On Mon, Feb 08, 2016 at 06:51:21PM +0200, Topi Pohjolainen wrote: > > > Signed-off-by: Topi Pohjolainen > > > --- > > >

Re: [Mesa-dev] [PATCH] Android: fix build break in libmesa_program

On Wed, Feb 10, 2016 at 4:33 PM, Ilia Mirkin wrote: > I think prog_statevars.c needs to be fixed instead to include > "main/framebuffer.h". I wonder why that worked in the regular build =/ I was assuming it did work which is why I didn't do that. Rob > > On Wed, Feb 10,

[Mesa-dev] [Bug 89330] piglit glsl-1.50 invariant-qualifier-in-out-block-01 regression

https://bugs.freedesktop.org/show_bug.cgi?id=89330 --- Comment #3 from Ian Romanick --- Feedback from Khronos is that invariant should be allowed on block members. In this case "global scope" meant "not in a function and not in a structure." Future spec versions will

Re: [Mesa-dev] [PATCH] Android: fix build break in libmesa_program

I think prog_statevars.c needs to be fixed instead to include "main/framebuffer.h". I wonder why that worked in the regular build =/ On Wed, Feb 10, 2016 at 5:10 PM, Rob Herring wrote: > Commit 5fd848f6c9ee ("program: Use _mesa_geometric_samples to calculate > gl_NumSamples")

Re: [Mesa-dev] [PATCH] Android: fix build break in libmesa_program

On Wed, Feb 10, 2016 at 5:48 PM, Rob Herring wrote: > On Wed, Feb 10, 2016 at 4:33 PM, Ilia Mirkin wrote: >> I think prog_statevars.c needs to be fixed instead to include >> "main/framebuffer.h". I wonder why that worked in the regular build =/ > > I was

[Mesa-dev] [PATCH v3 09/19] tgsi/ureg: add shared variables support for compute shaders

This introduces TGSI_FILE_MEMORY for shared, global and local memory. Only shared memory is currently supported. Changes from v2: - introduce TGSI_FILE_MEMORY Signed-off-by: Samuel Pitoiset --- src/gallium/auxiliary/tgsi/tgsi_build.c| 1 +

[Mesa-dev] [PATCH v3 14/19] st/mesa: keep track of shared memory declarations

Signed-off-by: Samuel Pitoiset Reviewed-by: Ilia Mirkin --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 19 --- 1 file changed, 16 insertions(+), 3 deletions(-) diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp

[Mesa-dev] [PATCH v3 17/19] st/mesa: add compute program dispatch callbacks

This state tracker implements DispatchCompute() and DispatchComputeIndirect(). Signed-off-by: Samuel Pitoiset Reviewed-by: Marek Olšák Reviewed-by: Ilia Mirkin --- src/mesa/Makefile.sources | 2 +

[Mesa-dev] [PATCH v3 16/19] st/mesa: add state validation for compute shaders

This binds atomics, constants, samplers, ssbos, textures and ubos. Signed-off-by: Samuel Pitoiset Reviewed-by: Marek Olšák Reviewed-by: Ilia Mirkin --- src/mesa/state_tracker/st_atom.c| 6

[Mesa-dev] [PATCH v3 18/19] st/mesa: implement limits for ARB_compute_shader

According to the spec, this also increases the following minimum values: - MAX_COMBINED_TEXTURE_IMAGE_UNITS 96 (6*16), was 80 - MAX_UNIFORM_BUFFER_BINDINGS 72 (6*12), was 60 ARB_compute_shader is not enabled by default because images support is still not implemented yet. If you

[Mesa-dev] [PATCH v3 19/19] trace: add all compute related functions

Changes from v3: - dump the TGSI compute program Changes from v2: - remove use of MALLOC() Signed-off-by: Samuel Pitoiset Reviewed-by: Ilia Mirkin (v1) --- src/gallium/drivers/trace/tr_context.c| 75 +++

[Mesa-dev] [PATCH v3 02/19] mesa: do not use a constant for MAX_COMPUTE_SHARED_SIZE

This will allow to query the underlying drivers for the maximum total storage size of all variables declared as with PIPE_COMPUTE_CAP_MAX_LOCAL_SIZE. Signed-off-by: Samuel Pitoiset Reviewed-by: Marek Olšák Reviewed-by: Ilia Mirkin

[Mesa-dev] [PATCH v3 01/19] mesa: make compute maximums reflect driver-provided values

From: Ilia Mirkin Looks like the various max's were never plumbed through. Signed-off-by: Ilia Mirkin Signed-off-by: Samuel Pitoiset Reviewed-by: Marek Olšák ---

[Mesa-dev] [PATCH v3 15/19] st/mesa: add mappings for compute shader sysvals

LOCAL_INVOCATION_ID, WORK_GROUP_ID and NUM_WORK_GROUPS are respectively mapped to THREAD_ID, BLOCK_ID and GRID_SIZE. Changes from v2: - add assertions in st_translate_program() Signed-off-by: Samuel Pitoiset Reviewed-by: Ilia Mirkin (v1) ---

[Mesa-dev] [PATCH] llvmpipe: Do not use barriers if not using threads.

Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=94088 Signed-off-by: Vinson Lee --- src/gallium/drivers/llvmpipe/lp_rast.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/llvmpipe/lp_rast.c

[Mesa-dev] [Bug 94088] [llvmpipe] SIGFPE pthread_barrier_destroy.c:40

https://bugs.freedesktop.org/show_bug.cgi?id=94088 Bug ID: 94088 Summary: [llvmpipe] SIGFPE pthread_barrier_destroy.c:40 Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW

[Mesa-dev] [PATCH] i965: ir: dump floats as %-g rather than %f, so we can see denormals

Signed-off-by: Chris Forbes --- src/mesa/drivers/dri/i965/brw_fs.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp b/src/mesa/drivers/dri/i965/brw_fs.cpp index 41a3f81..8734560 100644 ---

Re: [Mesa-dev] [PATCH] i965: ir: dump floats as %-g rather than %f, so we can see denormals

On Thu, Feb 11, 2016 at 07:03:56PM +1300, Chris Forbes wrote: > Signed-off-by: Chris Forbes After offline discussion with Chris: Reviewed-by: Ben Widawsky Though in fairness, I don't use this as much as others, so it might be nice to have someone

Re: [Mesa-dev] [PATCH 02/23] i965: Use miptree non-aligned dimensions directly for x-tiled

On Tue, Feb 09, 2016 at 12:31:11PM -0800, Ben Widawsky wrote: > On Mon, Feb 08, 2016 at 06:51:22PM +0200, Topi Pohjolainen wrote: > > The logic in intel_miptree_create() uses the local copies > > for 64-byte aligned equivalent but only for stencil buffers which > > in turn are never x-tiled. This

[Mesa-dev] issues with split llvm libraries and llvmpipe and failing to load library

Hey, So in Fedora rawhide we are now building llvm 3.7.1 into the lots of little shared libraries format. However I'm running into a major problem with the fact that sometimes dlclose isn't dropping all the LLVM libraries from the address space of the process. We have a sequence like this: a)

[Mesa-dev] [PATCH 13/13] i965/meta: Don't pollute the framebuffer namespace

From: Ian Romanick tl;dr: For many types of GL object, we can *NEVER* use the Gen function. In OpenGL ES (all versions!) and OpenGL compatibility profile, applications don't have to call Gen functions. The GL spec is very clear about how you can mix-and-match

[Mesa-dev] [PATCH 10/13] meta/decompress: Track framebuffer using gl_framebuffer instead of GL API object handle

From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/drivers/common/meta.c | 17 +++-- src/mesa/drivers/common/meta.h | 2 +- 2 files changed, 12 insertions(+), 7 deletions(-) diff --git a/src/mesa/drivers/common/meta.c

[Mesa-dev] [PATCH 02/13] meta: Obvious refactor of _mesa_meta_framebuffer_texture_image

From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/drivers/common/meta.c | 26 +- 1 file changed, 5 insertions(+), 21 deletions(-) diff --git a/src/mesa/drivers/common/meta.c b/src/mesa/drivers/common/meta.c

[Mesa-dev] [PATCH 11/13] meta: Don't pollute the framebuffer namespace

From: Ian Romanick tl;dr: For many types of GL object, we can *NEVER* use the Gen function. In OpenGL ES (all versions!) and OpenGL compatibility profile, applications don't have to call Gen functions. The GL spec is very clear about how you can mix-and-match

[Mesa-dev] [PATCH 05/13] meta: Save and restore the framebuffer using gl_framebuffer instead of GL API object handle

From: Ian Romanick Some meta operations can be called recursively. Future changes (the "Don't pollute the ... namespace" changes) will cause objects with invalid names to be used. If a nested meta operation tries to restore an object named 0xDEADBEEF, it will fail.

[Mesa-dev] [PATCH 12/13] i965/meta: Use _mesa_bind_framebuffers instead of _mesa_BindFramebuffer

From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/drivers/dri/i965/brw_meta_fast_clear.c | 7 ++- src/mesa/drivers/dri/i965/brw_meta_stencil_blit.c | 12 ++-- src/mesa/drivers/dri/i965/brw_meta_updownsample.c | 14

[Mesa-dev] [PATCH 04/13] mesa: Refactor bind_framebuffer to make _mesa_bind_framebuffers

From: Ian Romanick Fixing dd_function_table::BindFramebuffer will come later because that change is probably not suitable for stable. Signed-off-by: Ian Romanick --- src/mesa/main/fbobject.c | 33 +

[Mesa-dev] [PATCH 09/13] meta/generate_mipmap: Track framebuffer using gl_framebuffer instead of GL API object handle

From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/drivers/common/meta.h | 2 +- src/mesa/drivers/common/meta_generate_mipmap.c | 38 ++ 2 files changed, 16 insertions(+), 24 deletions(-)

[Mesa-dev] [PATCH 08/13] meta: Use _mesa_bind_framebuffers instead of _mesa_BindFramebuffer

From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/drivers/common/meta.c | 13 +++-- src/mesa/drivers/common/meta_copy_image.c | 11 +-- src/mesa/drivers/common/meta_tex_subimage.c | 24

[Mesa-dev] [PATCH 06/13] i965/meta: Use _mesa_CreateFramebuffers instead of _mesa_GenFramebuffers

From: Ian Romanick This enables later patches that will stop calling _mesa_GenFramebuffers or _mesa_CreateFramebuffers which pollute the framebuffer namespace. For framebuffers, the Bind call is still necessary. sed -i -e

[Mesa-dev] [PATCH 01/13] meta: Convert _mesa_meta_bind_fbo_image to take a gl_framebuffer instead of a GL API handle

From: Ian Romanick Also change the name of the function to _mesa_meta_framebuffer_texture_image. The function is basically a wrapper around _mesa_framebuffer_texture (which is used to implement glFramebufferTexture1D and friends), so it makes sense for it's name to be

[Mesa-dev] [PATCH 03/13] meta: Use _mesa_check_framebuffer_status instead of _mesa_CheckFramebufferStatus

From: Ian Romanick sed -i -e 's/_mesa_CheckFramebufferStatus(GL_DRAW_FRAMEBUFFER/_mesa_check_framebuffer_status(ctx, ctx->DrawBuffer/' \ -e 's/_mesa_CheckFramebufferStatus(GL_FRAMEBUFFER[^)]*/_mesa_check_framebuffer_status(ctx, ctx->DrawBuffer/' \ -e

[Mesa-dev] [PATCH 07/13] meta: Use _mesa_CreateFramebuffers instead of _mesa_GenFramebuffers

From: Ian Romanick This enables later patches that will stop calling _mesa_GenFramebuffers or _mesa_CreateFramebuffers which pollute the framebuffer namespace. For framebuffers, the Bind call is still necessary. sed -i -e

[Mesa-dev] [PATCH] glsl: Allow invariant qualifer in block members in desktop OpenGL.

Feedback from Khronos is that 'invariant' should be allowed on block members for desktop OpenGL. Fix piglit regression added by fe1e89a0: invariant-qualifier-in-out-block-01.vert Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=89330 Signed-off-by: Samuel Iglesias Gonsálvez

[Mesa-dev] [Bug 89330] piglit glsl-1.50 invariant-qualifier-in-out-block-01 regression

https://bugs.freedesktop.org/show_bug.cgi?id=89330 --- Comment #4 from Samuel Iglesias --- (In reply to Ian Romanick from comment #3) > Feedback from Khronos is that invariant should be allowed on block members. > In this case "global scope" meant "not in a function and

[Mesa-dev] [PATCH 3/3] glsl: remove out of date comments from file header

The bison/flex generated code hasn't been keeped in version control for a long time, and I doubt anyone is going to argue for putting all this validation in the parser. --- src/compiler/glsl/ast_to_hir.cpp | 18 +- 1 file changed, 1 insertion(+), 17 deletions(-) diff --git

[Mesa-dev] [PATCH 2/3] glsl: don't validate interface blocks twice

We already check for opaque types so don't recheck for atomics and images. --- src/compiler/glsl/ast_to_hir.cpp | 46 1 file changed, 23 insertions(+), 23 deletions(-) diff --git a/src/compiler/glsl/ast_to_hir.cpp b/src/compiler/glsl/ast_to_hir.cpp index

[Mesa-dev] [PATCH 1/3] glsl: remove duplicate embedded struct validation

Commit c98deb18d5836f in 2010 disallowed embedded struct definitions in ES. Then in 2013 d9bb8b7b56ce65b disallowed it for everything but GLSL 1.10. Commit c98deb18d5836f seemed the cleanest way to do the check so its been extended to cover GL and the other version has been removed. Cc: Ian

Re: [Mesa-dev] [PATCH 03/23] i965: Separate miptree creation from auxiliary buffer setup

On Tue, Feb 09, 2016 at 03:05:05PM -0800, Ben Widawsky wrote: > On Mon, Feb 08, 2016 at 06:51:23PM +0200, Topi Pohjolainen wrote: > > Currently the logic allocating and setting up miptrees is closely > > combined with decision making when to re-allocate buffers in > > X-tiled layout and when to

Re: [Mesa-dev] [PATCH v3] i965/blorp: Fix hiz ops on MSAA surfaces

On 09/02/16 02:29, Jordan Justen wrote: > On 2016-02-06 10:25:59, Ben Widawsky wrote: >> On Sat, Feb 06, 2016 at 12:01:50PM +0100, Alejandro Piñeiro wrote: >>> From: Chris Forbes >>> >>> Two things were broken here: >>> - The depth/stencil surface dimensions were broken for

Re: [Mesa-dev] [PATCH] Better explain why we are lowering the num_tile_pipes value for TAHITI

On Wed, Feb 10, 2016 at 2:11 AM, Alexandre Demers wrote: > Signed-off-by: Alexandre Demers > --- > src/gallium/winsys/radeon/drm/radeon_drm_winsys.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git

Re: [Mesa-dev] [PATCH 0/2] Simple Klocwork patches

Hi Juha, On Sun, 2016-02-07 at 23:37 +0200, Juha-Pekka Heikkilä wrote: > Hi Iago, > > I know there are lot of places where there is malloc unchecked still > -- and then there is ralloc which is a story of its own. Reason why I > think checking these would be remotely useful in windows only (or >

Re: [Mesa-dev] [PATCH 03/23] i965: Separate miptree creation from auxiliary buffer setup

On Tue, Feb 09, 2016 at 03:05:05PM -0800, Ben Widawsky wrote: > On Mon, Feb 08, 2016 at 06:51:23PM +0200, Topi Pohjolainen wrote: > > Currently the logic allocating and setting up miptrees is closely > > combined with decision making when to re-allocate buffers in > > X-tiled layout and when to

Re: [Mesa-dev] [PATCH 01/23] i965: Let caller of intel_miptree_create_layout() decide msaa layout

On Tue, Feb 09, 2016 at 12:05:52PM -0800, Ben Widawsky wrote: > On Mon, Feb 08, 2016 at 06:51:21PM +0200, Topi Pohjolainen wrote: > > Signed-off-by: Topi Pohjolainen > > --- > > src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 15 +++ > > 1 file changed, 11

[Mesa-dev] [PATCH 3/3] egl: remove remnants of MESA_drm_display

Last set in st/egl, unused in mesa-demos and superseded by EGL_KHR_platform_gbm. Signed-off-by: Emil Velikov --- include/EGL/eglmesaext.h | 11 --- src/egl/main/eglapi.c | 9 - src/egl/main/egldisplay.h | 1 - 3 files changed, 21 deletions(-)

[Mesa-dev] [PATCH 0/3] Cleanup unused EGL extensions plumbing

Hi all, The title says most of it with the remainder - ... the extensions (KHR_reusable_sync, KHR_vg_parent_image and MESA_drm_display) have been unimplemented since the removal of st/egl. Silly me forgot those in a local branch for 2 months :-) Please review Emil

[Mesa-dev] [PATCH 2/3] egl: remove final pieces of KHR_vg_parent_image

Similar to previous commit - unused/unset for a long time. Signed-off-by: Emil Velikov --- src/egl/main/eglapi.c | 1 - src/egl/main/egldisplay.h | 1 - 2 files changed, 2 deletions(-) diff --git a/src/egl/main/eglapi.c b/src/egl/main/eglapi.c index

[Mesa-dev] [PATCH 1/3] egl: remove KHR_reusable_sync left-overs

Not available since the removal of st/egl. Signed-off-by: Emil Velikov --- src/egl/main/eglapi.c | 31 +++ src/egl/main/eglapi.h | 2 -- src/egl/main/egldisplay.h | 1 - src/egl/main/eglfallbacks.c | 1 - 4 files changed, 3

Re: [Mesa-dev] i965/gen9: Compression support for single-sampled

On Tue, Feb 09, 2016 at 05:34:53PM -0800, Ben Widawsky wrote: > On Mon, Feb 08, 2016 at 06:51:20PM +0200, Topi Pohjolainen wrote: > > This series enables compression for single sampled color surfaces, > > also referred to as "lossless compression". This is yet only for > > driver internal use

[Mesa-dev] [Bug 94086] Multiple conflicting libGL libraries installed

https://bugs.freedesktop.org/show_bug.cgi?id=94086 Bug ID: 94086 Summary: Multiple conflicting libGL libraries installed Product: Mesa Version: git Hardware: All OS: All Status: NEW Severity: minor

[Mesa-dev] [PATCH] nir: Fix out-of-tree build for spirv2nir

From: Kristian Høgsberg Kristensen This needs to be able to find the generated nir_opcodes.h header. --- src/compiler/Makefile.am | 5 + 1 file changed, 5 insertions(+) diff --git a/src/compiler/Makefile.am b/src/compiler/Makefile.am index fe96cb3..8f37448

Re: [Mesa-dev] [PATCH 1/7] glsl: enable offset layout qualifier for ARB_enhanced_layouts

Hi, There is just one patch in the component layout series remaining to be reviewed (I think Edward looked at it but its rather coplicated so wouldn't mind another pair of eyes going over it).  Wanted to check if anyone else was planning to take a look at this series also, otherwise I'll push

  1   2   >