[Mesa-dev] [PATCH] glsl/parser: handle multiple layout sections with AST nodes.

2016-05-22 Thread Dave Airlie
From: Dave Airlie For geometry/compute inputs and tess control outputs, we create an AST node to keep track of some things. However if we have multiple layout sections, we don't ever link the node into the AST. This is because we create the node on the rightmost layout

Re: [Mesa-dev] [PATCH] glsl: allow layout qualifier overrides with ARB_shading_language_420pack

2016-05-22 Thread Timothy Arceri
On Mon, 2016-05-23 at 14:29 +1000, Dave Airlie wrote: > From: Dave Airlie > > GLSL 4.20 allows overriding the layout qualifiers. > > This helps fix: > GL45-CTS.shading_language_420pack.qualifier_override_layout > > Signed-off-by: Dave Airlie

[Mesa-dev] [PATCH] glsl: allow layout qualifier overrides with ARB_shading_language_420pack

2016-05-22 Thread Dave Airlie
From: Dave Airlie GLSL 4.20 allows overriding the layout qualifiers. This helps fix: GL45-CTS.shading_language_420pack.qualifier_override_layout Signed-off-by: Dave Airlie --- src/compiler/glsl/ast_type.cpp | 7 ++- 1 file changed, 6 insertions(+),

[Mesa-dev] [PATCH] [rfc] glsl: allow invariant on fragment shader outputs.

2016-05-22 Thread Dave Airlie
From: Dave Airlie A CTS test manages to generate this: GL45-CTS.shading_language_420pack.qualifier_order I cannot find definitive evidence in the spec that it isn't allowed. The specs mentions some things can't be used on fragment shader outputs, but never specifies

[Mesa-dev] [PATCH] glsl: fix explicit location validation for doubles

2016-05-22 Thread Timothy Arceri
Previously we would fail to find a match for the second half of a dvec4 as 'i' would get incremented to 1 before we added the var to the array at component 0. --- src/compiler/glsl/link_varyings.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

Re: [Mesa-dev] [PATCH] glsl/ast: subroutineTypes can't be returned from functions.

2016-05-22 Thread Chris Forbes
Reviewed-by: Chris Forbes On Mon, May 23, 2016 at 2:15 PM, Dave Airlie wrote: > From: Dave Airlie > > These types can't be returned. > > This fixes: > >

Re: [Mesa-dev] [PATCH] glsl/images: bounds check image unit assignment

2016-05-22 Thread Ilia Mirkin
On Sun, May 22, 2016 at 10:51 PM, Dave Airlie wrote: > From: Dave Airlie > > The CTS test: > GL45-CTS.multi_bind.dispatch_bind_image_textures > binds 192 image uniforms, we reject this later, > but not until after we trash the contents of the > struct

[Mesa-dev] [PATCH] glsl/images: bounds check image unit assignment

2016-05-22 Thread Dave Airlie
From: Dave Airlie The CTS test: GL45-CTS.multi_bind.dispatch_bind_image_textures binds 192 image uniforms, we reject this later, but not until after we trash the contents of the struct gl_shader. Error now reads: Too many compute shader image uniforms (192 > 16) instead of

Re: [Mesa-dev] arb_shader_subroutine CTS fixes

2016-05-22 Thread Chris Forbes
1, 3-11 inclusive are: Reviewed-by: Chris Forbes On Mon, May 23, 2016 at 12:52 PM, Dave Airlie wrote: > Since I wrote ARB_shader_subroutine as mostly a hack to enable GL4.0, > I felt a bit guilty and looked at CTS issues with it. > > There are a

[Mesa-dev] [PATCH] glsl: add support for doubles in GL 4.4+

2016-05-22 Thread Timothy Arceri
We disable varying packing in GL 4.4+ as we can no longer assume varying have the same interpolation qualifiers. However doubles used as fs inputs must always be qualified as "flat" and backends expect doubles to have been packed as floats so we enable packing for them. ---

Re: [Mesa-dev] [PATCH 2/4] anv/apply_dynamic_offsets: Use rewrite_src instead of a regular assignment

2016-05-22 Thread Michael Schellenberger Costa
Hi Jason, Am 19.05.2016 um 06:42 schrieb Jason Ekstrand: > Originally we removed the instruction, changed the source, and then > re-inserted it. This works, but nir_instr_rewrite_src is a bit more > obviously correct. > --- > src/intel/vulkan/anv_nir_apply_dynamic_offsets.c | 6 +++--- > 1 file

Re: [Mesa-dev] [PATCH v3] glsl/linker: dvec3/dvec4 consume twice input vertex attributes

2016-05-22 Thread Michael Schellenberger Costa
Hi Juan, Am 18.05.2016 um 13:19 schrieb Juan A. Suarez Romero: > From the GL 4.5 core spec, section 11.1.1 (Vertex Attributes): > > "A program with more than the value of MAX_VERTEX_ATTRIBS > active attribute variables may fail to link, unless > device-dependent optimizations are able to make

Re: [Mesa-dev] [PATCH v2 3/3] gallium: push offset down to driver

2016-05-22 Thread Emil Velikov
Hi Stan, First, thanks for re-spinning these according to my suggestions. On 20 May 2016 at 12:17, Stanimir Varbanov wrote: > Push offset down to drivers when importing dmabuf. This is needed > to more fully support EGL_EXT_image_dma_buf_import when a non-zero >

Re: [Mesa-dev] [PATCH 01/13] vbo: Declare the index range invalid for DrawIndirect

2016-05-22 Thread Michael Schellenberger Costa
Hi Jason, Am 19.05.2016 um 09:20 schrieb Jason Ekstrand: > Right now, we're just setting the range to [0, MAX_UINT32] which, while > correct isn't helpful. With DrawIndirect, you can't really know what the > actual range is so we may as well flag it as being an invalid range. This > is what we

Re: [Mesa-dev] Mesa 11.2.2 problems with Intel i965 graphics on Arch Linux

2016-05-22 Thread Vanja
Thank you very much for this helpful advice Kenneth. Using the verbose output I can see that the problem was caused by a mismatch in the C library used by the program and by my system. The problem arose because the newer mesa package was built with a newer version of gcc. Thanks again, Vanja >

Re: [Mesa-dev] [PATCH 07/12] nir: Don't use ffma in nir_lower_wpos_ytransform().

2016-05-22 Thread Michael Schellenberger Costa
Hi Kenneth, Am 19.05.2016 um 00:00 schrieb Kenneth Graunke: > ffma is an explicitly fused multiply add with higher precision. > The optimizer will take care of promoting mul/add to fma when > it's beneficial to do so. > > This fixes failures on Gen4-5 when using this pass, as those platforms >

Re: [Mesa-dev] [PATCH v2 4/4] anv/pipeline: Bounds-check resource indices when robuts_buffer_access is enabled

2016-05-22 Thread Michael Schellenberger Costa
Hi Jason, Am 19.05.2016 um 09:22 schrieb Jason Ekstrand: > --- > src/intel/vulkan/anv_nir_apply_pipeline_layout.c | 52 > > 1 file changed, 35 insertions(+), 17 deletions(-) > > diff --git a/src/intel/vulkan/anv_nir_apply_pipeline_layout.c >

Re: [Mesa-dev] [PATCH v2 0/3] st: dri2: handle dmabuf plane offsets != 0

2016-05-22 Thread Stanimir Varbanov
For those who received this patchset twice sorry for the noise, it was not on purpose. It was by mistake :( On 05/20/2016 02:17 PM, Stanimir Varbanov wrote: > Changes since v1: > - in 2/3 make possible to pass NULL pointer for error > argument to cover cases when exact error code is not >

Re: [Mesa-dev] [PATCH 06/12] glsl: fix subroutine uniform .length().

2016-05-22 Thread Dave Airlie
On 23 May 2016 at 12:19, Chris Forbes wrote: > > > On Mon, May 23, 2016 at 12:52 PM, Dave Airlie wrote: >> >> From: Dave Airlie >> >> This fixes .length() on subroutine uniform arrays, if >> we don't find the identifier normally, we look

Re: [Mesa-dev] [PATCH 2/2] mesa: dri: Add shared glapi to LIBADD on Android

2016-05-22 Thread Nicolas Boichat
On Thu, Apr 28, 2016 at 10:41 PM, Emil Velikov wrote: > On 28 April 2016 at 11:41, Nicolas Boichat wrote: >> /system/vendor/lib/dri/*_dri.so actually depend on libglapi: without >> this, loading the so file fails with: >> cannot locate symbol

Re: [Mesa-dev] [PATCH 06/12] glsl: fix subroutine uniform .length().

2016-05-22 Thread Chris Forbes
On Mon, May 23, 2016 at 12:52 PM, Dave Airlie wrote: > From: Dave Airlie > > This fixes .length() on subroutine uniform arrays, if > we don't find the identifier normally, we look up the corresponding > subroutine identifier instead. > > Fixes: >

Re: [Mesa-dev] [PATCH 1/2] configure.ac: Add support for Android builds

2016-05-22 Thread Nicolas Boichat
Hi Emil, Apologies for the delay, it's easier to answer your questions now that the project has launched (https://chrome.googleblog.com/2016/05/the-google-play-store-coming-to.html). Basically we are running Android in a Linux container, on top of existing Chrome OS. On Thu, Apr 28, 2016 at

[Mesa-dev] [PATCH] glsl/ast: subroutineTypes can't be returned from functions.

2016-05-22 Thread Dave Airlie
From: Dave Airlie These types can't be returned. This fixes: GL43-CTS.shader_subroutine.subroutines_not_allowed_as_variables_constructors_and_argument_or_return_types for the return type case. Signed-off-by: Dave Airlie ---

Re: [Mesa-dev] [RFC 6/7] nir/validate: fix null deref coverity warning

2016-05-22 Thread Jason Ekstrand
R-B On Wed, May 18, 2016 at 8:54 AM, Rob Clark wrote: > From: Rob Clark > > CID 1265536 (#1 of 2): Explicit null dereferenced (FORWARD_NULL)6. > var_deref_op: Dereferencing null pointer parent. > --- > src/compiler/nir/nir_validate.c | 1 + > 1

Re: [Mesa-dev] [PATCH v3] glsl/linker: dvec3/dvec4 consume twice input vertex attributes

2016-05-22 Thread Dave Airlie
On 19 May 2016 at 02:41, Kenneth Graunke wrote: > On Wednesday, May 18, 2016 1:19:39 PM PDT Juan A. Suarez Romero wrote: >> From the GL 4.5 core spec, section 11.1.1 (Vertex Attributes): >> >> "A program with more than the value of MAX_VERTEX_ATTRIBS >> active attribute

[Mesa-dev] [PATCH 04/12] glsl: produce a linker error for a subroutine uniform with no functions.

2016-05-22 Thread Dave Airlie
From: Dave Airlie If a subroutine uniform is declared with no functions backing it, that isn't legal, so we should fail to link. Fixes: GL43-CTS.shader_subroutine.subroutine_uniform_wo_matching_subroutines Signed-off-by: Dave Airlie ---

[Mesa-dev] [PATCH 11/12] mesa/subroutines: fix reset on bindpipeline

2016-05-22 Thread Dave Airlie
From: Dave Airlie Fixes: GL45-CTS.shader_subroutine.subroutine_uniform_reset Signed-off-by: Dave Airlie --- src/mesa/main/pipelineobj.c | 4 src/mesa/main/shaderapi.c | 4 +++- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git

[Mesa-dev] [PATCH 01/12] arb_shader_subroutine: check active subroutine limit

2016-05-22 Thread Dave Airlie
From: Dave Airlie _mesa_GetActiveSubroutineUniformiv needs to check against the number of types here. Noticed while playing with ogl conform. Signed-off-by: Dave Airlie --- src/mesa/main/shaderapi.c | 5 + 1 file changed, 5 insertions(+) diff

[Mesa-dev] [PATCH 03/12] glsl: validate subroutine types match function signature.

2016-05-22 Thread Dave Airlie
From: Dave Airlie This fixes: GL43-CTS.shader_subroutine.subroutines_incompatible_with_subroutine_type It just makes sure the signatures match as well as the return types. Signed-off-by: Dave Airlie --- src/compiler/glsl/ast_to_hir.cpp | 18

[Mesa-dev] [PATCH 02/12] glsl/ast: don't accept function calls as constructors.

2016-05-22 Thread Dave Airlie
From: Dave Airlie This fixes a crash in GL43-CTS.shader_subroutine.subroutines_not_allowed_as_variables_constructors_and_argument_or_return_types Signed-off-by: Dave Airlie --- src/compiler/glsl/ast_function.cpp | 5 - 1 file changed, 4

[Mesa-dev] [PATCH 12/12] subroutines: handle explicit indexes properly

2016-05-22 Thread Dave Airlie
From: Dave Airlie The code didn't deal with explicit function indexes properly. It also handed out the indexes at link time, when we really need them in the lowering pass to create the correct if ladder. So this patch moves assigning the non-explicit indexes earlier, fixes

[Mesa-dev] [PATCH 08/12] glsl/ast: for geom shaders allow stream flags in input flags.

2016-05-22 Thread Dave Airlie
From: Dave Airlie This fixes: GL45-CTS.shader_subroutine.subroutines_with_separate_shader_objects Since we set the stream flags earlier on all geom shaders, we shouldn't fall over later if we find one. Signed-off-by: Dave Airlie ---

[Mesa-dev] [PATCH 05/12] glsl/linker: link error on too many subroutine functions.

2016-05-22 Thread Dave Airlie
From: Dave Airlie This fixes: GL45-CTS.explicit_uniform_location.subroutine-index-negative-link-max-num-of-indices Signed-off-by: Dave Airlie --- src/compiler/glsl/linker.cpp | 4 1 file changed, 4 insertions(+) diff --git

[Mesa-dev] [PATCH 06/12] glsl: fix subroutine uniform .length().

2016-05-22 Thread Dave Airlie
From: Dave Airlie This fixes .length() on subroutine uniform arrays, if we don't find the identifier normally, we look up the corresponding subroutine identifier instead. Fixes: GL45-CTS.shader_subroutine.arrays_of_arrays_of_uniforms

[Mesa-dev] [PATCH 07/12] glsl/linker: skip inactive explicit locations.

2016-05-22 Thread Dave Airlie
From: Dave Airlie This fixes a crash in: GL45-CTS.explicit_uniform_location.subroutine-loc-negative-link-max-num-of-locations Signed-off-by: Dave Airlie --- src/compiler/glsl/linker.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git

[Mesa-dev] [PATCH 10/12] mesa/subroutines: count number subroutines properly.

2016-05-22 Thread Dave Airlie
From: Dave Airlie The code was implementing the ACTIVE_SUBROUTINE_UNIFORMS incorrectly, using the number of types not the number of uniforms. This is different than the locations as the locations may be sparsly allocated. This fixes:

[Mesa-dev] [PATCH 09/12] mesa/subroutines: don't generate error in GetSubroutineIndex.

2016-05-22 Thread Dave Airlie
From: Dave Airlie GLSL spec says this doesn't generate an error. Fixes: GL45-CTS.explicit_uniform_location.subroutine-loc Signed-off-by: Dave Airlie --- src/mesa/main/shaderapi.c | 1 - 1 file changed, 1 deletion(-) diff --git

[Mesa-dev] arb_shader_subroutine CTS fixes

2016-05-22 Thread Dave Airlie
Since I wrote ARB_shader_subroutine as mostly a hack to enable GL4.0, I felt a bit guilty and looked at CTS issues with it. There are a bunch of CTS tests that do explicit location/index with subroutines that were broken, along with a fair few of the subroutine tests. This is my first pass set

[Mesa-dev] [Bug 95529] [regression, bisected] Image corruption in Chrome

2016-05-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=95529 --- Comment #1 from vegorov...@gmail.com --- Created attachment 123973 --> https://bugs.freedesktop.org/attachment.cgi?id=123973=edit glitches on llvmpipe -- You are receiving this mail because: You are the assignee for the bug. You are the

[Mesa-dev] [Bug 95529] [regression, bisected] Image corruption in Chrome

2016-05-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=95529 Bug ID: 95529 Summary: [regression, bisected] Image corruption in Chrome Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: Linux (All) Status: NEW

Re: [Mesa-dev] [PATCH] glsl: Use correct mode for split components.

2016-05-22 Thread Dave Airlie
On 19 May 2016 at 13:18, Jordan Justen wrote: > On 2016-04-25 16:39:21, Kenneth Graunke wrote: >> On Wednesday, April 20, 2016 3:42:01 PM PDT Bas Nieuwenhuizen wrote: >> > The mode should stay the same as the original struct. In >> > particular, shared should not be

Re: [Mesa-dev] [PATCH] mesa: Build EGL without X11 headers after interop patchset

2016-05-22 Thread Dieter Nützel
Am 22.05.2016 21:28, schrieb Mark Janes: Tom Stellard writes: On Fri, May 20, 2016 at 04:29:07PM -0700, Mark Janes wrote: Tom Stellard writes: > On Wed, Apr 27, 2016 at 10:33:14PM +, Youry Metlitsky wrote: >> --- >> include/GL/mesa_glinterop.h |

Re: [Mesa-dev] [PATCH] mesa/queryobject: return INVALID_VALUE if offset < 0 (v2)

2016-05-22 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin On Sun, May 22, 2016 at 5:21 PM, Dave Airlie wrote: > From: Dave Airlie > > This fixes: > GL45-CTS.direct_state_access.queries_errors > > The ARB_direct_state_access spec agrees. > > v2: move check down

[Mesa-dev] [PATCH] mesa/queryobject: return INVALID_VALUE if offset < 0 (v2)

2016-05-22 Thread Dave Airlie
From: Dave Airlie This fixes: GL45-CTS.direct_state_access.queries_errors The ARB_direct_state_access spec agrees. v2: move check down further (Ilia) Signed-off-by: Dave Airlie --- src/mesa/main/queryobj.c | 5 + 1 file changed, 5 insertions(+)

Re: [Mesa-dev] [PATCH v3] nvc0/ir: fix indirect access for images

2016-05-22 Thread Ilia Mirkin
Reviewed-by: Ilia Mirkin On Sun, May 22, 2016 at 5:01 PM, Samuel Pitoiset wrote: > When the array doesn't start at 0 we need to account for su->tex.r. > While we are at it, make sure to avoid out of bounds access by masking > the index. > > This

[Mesa-dev] [PATCH v3] nvc0/ir: fix indirect access for images

2016-05-22 Thread Samuel Pitoiset
When the array doesn't start at 0 we need to account for su->tex.r. While we are at it, make sure to avoid out of bounds access by masking the index. This fixes GL45-CTS.shading_language_420pack.binding_image_array. Signed-off-by: Samuel Pitoiset Reported-by: Dave

Re: [Mesa-dev] [PATCH v2] nvc0/ir: fix indirect access for images

2016-05-22 Thread Samuel Pitoiset
On 05/22/2016 10:56 PM, Ilia Mirkin wrote: On Sun, May 22, 2016 at 4:55 PM, Samuel Pitoiset wrote: When the array doesn't start at 0 we need to account for su->tex.r. While we are at it, make sure to avoid out of bounds access by masking the index. This fixes

Re: [Mesa-dev] [PATCH v2] nvc0/ir: fix indirect access for images

2016-05-22 Thread Ilia Mirkin
On Sun, May 22, 2016 at 4:55 PM, Samuel Pitoiset wrote: > When the array doesn't start at 0 we need to account for su->tex.r. > While we are at it, make sure to avoid out of bounds access by masking > the index. > > This fixes

[Mesa-dev] [PATCH v2] nvc0/ir: fix indirect access for images

2016-05-22 Thread Samuel Pitoiset
When the array doesn't start at 0 we need to account for su->tex.r. While we are at it, make sure to avoid out of bounds access by masking the index. This fixes GL45-CTS.shading_language_420pack.binding_image_array. Signed-off-by: Samuel Pitoiset Reported-by: Dave

[Mesa-dev] [PATCH] st/mesa: update inst->info along with inst->op

2016-05-22 Thread Ilia Mirkin
Otherwise we still have TGSI_OPCODE_CMP's info, which causes a number of later logic to go wrong. This fixes dEQP-GLES2.functional.shaders.functions.control_flow.return_in_if_vertex on nv30. Signed-off-by: Ilia Mirkin --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 1 +

Re: [Mesa-dev] [PATCH] nvc0/ir: fix indirect access for images

2016-05-22 Thread Ilia Mirkin
On Sun, May 22, 2016 at 4:43 PM, Samuel Pitoiset wrote: > When the array doesn't start at 0 we need to account for su->tex.r. > While we are at it, make sure to avoid out of bounds access by masking > the index. > > This fixes

[Mesa-dev] [PATCH] nvc0/ir: fix indirect access for images

2016-05-22 Thread Samuel Pitoiset
When the array doesn't start at 0 we need to account for su->tex.r. While we are at it, make sure to avoid out of bounds access by masking the index. This fixes GL45-CTS.shading_language_420pack.binding_image_array. Signed-off-by: Samuel Pitoiset Reported-by: Dave

Re: [Mesa-dev] [RFC PATCH] clover: add LLVM version to device and platform version

2016-05-22 Thread Vedran Miletic
On 05/22/2016 10:13 PM, Giuseppe Bilotta wrote: On Sun, May 22, 2016 at 1:08 PM, Serge Martin wrote: Mesa or MESA spelling shouldn't be an issue. And that would be coherent with CL_PLATFORM_VENDOR that is returning "Mesa" Excellent. I'll unify the version string suffix

Re: [Mesa-dev] [PATCH] mesa/queryobject: return INVALID_VALUE if offset is < 0

2016-05-22 Thread Ilia Mirkin
On Sun, May 22, 2016 at 4:15 PM, Dave Airlie wrote: > This fixes: > GL45-CTS.direct_state_access.queries_errors > > The ARB_direct_state_access spec agrees. > > Signed-off-by: Dave Airlie > --- > src/mesa/main/queryobj.c | 6 ++ > 1 file changed, 6

[Mesa-dev] [PATCH] mesa/queryobject: return INVALID_VALUE if offset is < 0

2016-05-22 Thread Dave Airlie
This fixes: GL45-CTS.direct_state_access.queries_errors The ARB_direct_state_access spec agrees. Signed-off-by: Dave Airlie --- src/mesa/main/queryobj.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/mesa/main/queryobj.c b/src/mesa/main/queryobj.c index

Re: [Mesa-dev] [RFC PATCH] clover: add LLVM version to device and platform version

2016-05-22 Thread Giuseppe Bilotta
On Sun, May 22, 2016 at 1:08 PM, Serge Martin wrote: > > Mesa or MESA spelling shouldn't be an issue. And that would be coherent with > CL_PLATFORM_VENDOR that is returning "Mesa" Excellent. I'll unify the version string suffix to the title-cased version. >> Second

[Mesa-dev] [PATCH] main: check driver float texture support before upgrading to 16F/32F

2016-05-22 Thread Ilia Mirkin
When passing in GL_RGBA or other base formats, we will try to upgrade the format to whatever the passed in type was. However not all drivers (notably nv30) support 32F textures, and so this would lead to crashes down the line. Only upgrade when the relevant extensions are available.

Re: [Mesa-dev] [PATCH] glsl: fix arrays of anonymous structs matching.

2016-05-22 Thread Ilia Mirkin
Won't this try to match struct { vec4 foo; } bar[6]; with struct { vec4 foo; } bar[6][6]; Or is that taken care of elsewhere? Also, it might be nice to not do output->type->without_array() twice. On Sun, May 22, 2016 at 3:30 PM, Dave Airlie wrote: > From: Dave Airlie

[Mesa-dev] [PATCH] glsl: fix arrays of anonymous structs matching.

2016-05-22 Thread Dave Airlie
From: Dave Airlie "glsl/linker: attempt to match anonymous structures at link" introduced a fix for matching anon structs, however it didn't handle arrays of anon structs. This adds the appropriate without_array() calls, and fixes some crashes in the CTS tessellation tests.

Re: [Mesa-dev] [PATCH] mesa: Build EGL without X11 headers after interop patchset

2016-05-22 Thread Mark Janes
Tom Stellard writes: > On Fri, May 20, 2016 at 04:29:07PM -0700, Mark Janes wrote: >> Tom Stellard writes: >> >> > On Wed, Apr 27, 2016 at 10:33:14PM +, Youry Metlitsky wrote: >> >> --- >> >> include/GL/mesa_glinterop.h | 15 ++- >> >> 1

Re: [Mesa-dev] [PATCH] nvc0: do not invalidate compute constbufs on Kepler

2016-05-22 Thread Samuel Pitoiset
On 05/22/2016 08:39 PM, Ilia Mirkin wrote: Seems reasonable. I assume you tested some draw/compute interop deqp tests on kepler to make sure it didn't start failing? Nope, totally untested. I can't test right now (don't have access to a Kepler card). Reviewed-by: Ilia Mirkin

Re: [Mesa-dev] [PATCH] nvc0: do not invalidate compute constbufs on Kepler

2016-05-22 Thread Ilia Mirkin
Seems reasonable. I assume you tested some draw/compute interop deqp tests on kepler to make sure it didn't start failing? Reviewed-by: Ilia Mirkin On Sun, May 22, 2016 at 2:27 PM, Samuel Pitoiset wrote: > Constbufs are only aliased on Fermi and

[Mesa-dev] [PATCH] nvc0: do not invalidate compute constbufs on Kepler

2016-05-22 Thread Samuel Pitoiset
Constbufs are only aliased on Fermi and this will reduce the number of flushes when we switch between 3d and compute. Signed-off-by: Samuel Pitoiset --- src/gallium/drivers/nouveau/nvc0/nvc0_state_validate.c | 10 ++ 1 file changed, 6 insertions(+), 4

Re: [Mesa-dev] [PATCH 04/10] radeonsi: move code for setting one shader image into separate function

2016-05-22 Thread Marek Olšák
v1->v2 diff fixing a crash. Found by Christoph Haag: diff --git a/src/gallium/drivers/radeonsi/si_descriptors.c b/src/gallium/drivers/radeonsi/si_descriptors.c index d264ae7..13a3413 100644 --- a/src/gallium/drivers/radeonsi/si_descriptors.c +++ b/src/gallium/drivers/radeonsi/si_descriptors.c @@

[Mesa-dev] [Bug 93551] Divinity: Original Sin Enhanced Edition(Native) crash on start

2016-05-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=93551 Vedran Miletić changed: What|Removed |Added CC||ved...@miletic.net

[Mesa-dev] [Bug 93551] Divinity: Original Sin Enhanced Edition(Native) crash on start

2016-05-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=93551 --- Comment #27 from Karol Herbst --- as it turns out, divinity also needs allow_glsl_extension_directive_midshader -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee

[Mesa-dev] [Bug 95159] Cannot build EGL without x11 headers after interop patchset

2016-05-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=95159 --- Comment #5 from Dieter Nützel --- Created attachment 123964 --> https://bugs.freedesktop.org/attachment.cgi?id=123964=edit glx: Fix build broken by 4e2c9a04354b6b133845b8b93c0c5d34261a91d0 Attached patch from Tom

[Mesa-dev] [Bug 95159] Cannot build EGL without x11 headers after interop patchset

2016-05-22 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=95159 Dieter Nützel changed: What|Removed |Added Status|RESOLVED|REOPENED

Re: [Mesa-dev] [PATCH 1/2] nv50/ir: fix prog info init

2016-05-22 Thread Samuel Pitoiset
Reviewed-by: Samuel Pitoiset On 05/21/2016 10:18 PM, Ilia Mirkin wrote: Left over from the pre-mainline tess support. Adapt to use the new defines. Signed-off-by: Ilia Mirkin Cc: "11.1 11.2" ---

Re: [Mesa-dev] [PATCH] nvc0/ir: return 0 for gl_TessCoord.z for non-triangles modes

2016-05-22 Thread Samuel Pitoiset
Reviewed-by: Samuel Pitoiset On 05/21/2016 09:41 PM, Ilia Mirkin wrote: Signed-off-by: Ilia Mirkin Cc: "11.1 11.2" --- src/gallium/drivers/nouveau/codegen/nv50_ir_lowering_nvc0.cpp | 4 1 file changed,

Re: [Mesa-dev] [RFC PATCH] clover: add LLVM version to device and platform version

2016-05-22 Thread Serge Martin
On Tuesday 17 May 2016 22:54:01 Giuseppe Bilotta wrote: > On Sun, May 15, 2016 at 10:54 PM, Giuseppe Bilotta > > wrote: > > On Sun, May 15, 2016 at 9:35 AM, Vedran Miletić wrote: > >> How about also adding Mesa git version, like "OpenGL core