Re: [Mesa-dev] [Mesa-stable] [PATCH 4/5] glsl: Optionally lower TCS gl_PatchVerticesIn to a uniform.

2016-06-02 Thread Kenneth Graunke
On Thursday, June 2, 2016 5:00:51 PM PDT Ian Romanick wrote: > On 06/02/2016 02:09 PM, Kenneth Graunke wrote: > > i965 has no special hardware for this, so the best way to implement > > this is to pass it in via a uniform. > > > > Signed-off-by: Kenneth Graunke > > Cc:

Re: [Mesa-dev] [PATCH] mesa/readpix: clamp SNORM properly

2016-06-02 Thread Dave Airlie
ping? On 10 May 2016 at 13:59, Dave Airlie wrote: > From: Dave Airlie > > The clamping code always clamps to 0..1, which for SNORM is > incorrect. This adds a bit to say that clamping is for > an snorm and to use the correct range. > > This fixes a number

Re: [Mesa-dev] [PATCH] mesa/get: return correct value for layer provoking vertex.

2016-06-02 Thread Roland Scheidegger
Reviewed-by: Roland Scheidegger I actually had fixed that at some point. But it looks like it came back... Roland Am 03.06.2016 um 04:27 schrieb Dave Airlie: > From: Dave Airlie > > This fixes: >

Re: [Mesa-dev] [PATCH] st/mesa: fix dirty flags for atoms that can depend on mutable objects

2016-06-02 Thread Ilia Mirkin
ChrisF suggested I do the buffer stuff like intel does - based on usage hints. This prevents a lot of unnecessary revalidation. I tend to agree - I'll resend this with updates. (Of course there's a missing USAGE flag for vertex arrays, but I'll fix that.) On Thu, Jun 2, 2016 at 8:31 PM, Ilia

[Mesa-dev] [PATCH] i965: don't use NumLayers for 3D textures.

2016-06-02 Thread Dave Airlie
From: Dave Airlie For 3D textures we shouldn't be using NumLayers, we need to get it from the depth. This fixes: GL45-CTS.geometry_shader.layered_framebuffer.clear_call_support Signed-off-by: Dave Airlie --- src/mesa/drivers/dri/i965/intel_fbo.c | 2 +-

Re: [Mesa-dev] [PATCH] mesa/get: return correct value for layer provoking vertex.

2016-06-02 Thread Chris Forbes
Reviewed-by: Chris Forbes On Fri, Jun 3, 2016 at 2:27 PM, Dave Airlie wrote: > From: Dave Airlie > > This fixes: > GL45-CTS.geometry_shader.layered_rendering.layered_rendering > > on Skylake. > > Signed-off-by: Dave Airlie

[Mesa-dev] [PATCH] mesa/get: return correct value for layer provoking vertex.

2016-06-02 Thread Dave Airlie
From: Dave Airlie This fixes: GL45-CTS.geometry_shader.layered_rendering.layered_rendering on Skylake. Signed-off-by: Dave Airlie --- src/mesa/main/get_hash_params.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Mesa-dev] [Mesa-stable] [PATCH] anv/blit: Use CLAMP_TO_EDGE for scaled blits

2016-06-02 Thread Jason Ekstrand
On Thu, Jun 2, 2016 at 5:01 PM, Ian Romanick wrote: > I believe this is what GL meta blits do also. This patch is > > Reviewed-by: Ian Romanick > Thanks! > On 06/02/2016 04:36 PM, Jason Ekstrand wrote: > > When upscaling you can end up

[Mesa-dev] [PATCH] glsl: geom shader max_vertices layout must match.

2016-06-02 Thread Dave Airlie
From: Dave Airlie "all geometry shader output vertex count declarations in a program must declare the same count." Fixes: GL45-CTS.geometry_shader.output.conflicted_output_vertices_max Cc: "11.2 12.0" Signed-off-by: Dave Airlie

[Mesa-dev] [PATCH] st/mesa: fix dirty flags for atoms that can depend on mutable objects

2016-06-02 Thread Ilia Mirkin
Both textures and buffers can have their underlying resources reallocated with a glTexImage*() or glBufferData(). Atoms that reference these need to be notified that a change to the underlying resource has occurred in order to be recreated. This means textures (which can reference a buffer

Re: [Mesa-dev] [PATCH] anv/copy: Account for the anv_surface.offset when creating a blit2d_surf

2016-06-02 Thread Nanley Chery
On Thu, Jun 02, 2016 at 04:27:26PM -0700, Jason Ekstrand wrote: > This was causing problems if the user tried to copy to/from the stencil > portion of a combined depth/stencil image. > > Signed-off-by: Jason Ekstrand > Cc: Nanley Chery > --- >

Re: [Mesa-dev] [Mesa-stable] [PATCH] anv/blit: Use CLAMP_TO_EDGE for scaled blits

2016-06-02 Thread Ian Romanick
I believe this is what GL meta blits do also. This patch is Reviewed-by: Ian Romanick On 06/02/2016 04:36 PM, Jason Ekstrand wrote: > When upscaling you can end up interpolating between the edge pixel and one > past the edge. Using CLAMP_TO_EDGE seems like the most

Re: [Mesa-dev] [Mesa-stable] [PATCH 4/5] glsl: Optionally lower TCS gl_PatchVerticesIn to a uniform.

2016-06-02 Thread Ian Romanick
On 06/02/2016 02:09 PM, Kenneth Graunke wrote: > i965 has no special hardware for this, so the best way to implement > this is to pass it in via a uniform. > > Signed-off-by: Kenneth Graunke > Cc: mesa-sta...@lists.freedesktop.org > --- >

Re: [Mesa-dev] [PATCH V2] meta: Fix indentation in shader code

2016-06-02 Thread Erik Faye-Lund
On Thu, Jun 2, 2016 at 8:25 PM, Anuj Phogat wrote: > Signed-off-by: Anuj Phogat > --- > src/mesa/drivers/common/meta_blit.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/mesa/drivers/common/meta_blit.c >

[Mesa-dev] [PATCH] anv/blit: Use CLAMP_TO_EDGE for scaled blits

2016-06-02 Thread Jason Ekstrand
When upscaling you can end up interpolating between the edge pixel and one past the edge. Using CLAMP_TO_EDGE seems like the most reasonable thing to do in this case. This fixes two of the new Vulkan CTS tests in dEQP-VK.api.copy_and_blit.blit_image.* Jason Ekstrand Cc:

[Mesa-dev] [PATCH] anv/copy: Account for the anv_surface.offset when creating a blit2d_surf

2016-06-02 Thread Jason Ekstrand
This was causing problems if the user tried to copy to/from the stencil portion of a combined depth/stencil image. Signed-off-by: Jason Ekstrand Cc: Nanley Chery --- src/intel/vulkan/anv_meta_copy.c | 34 +- 1 file

Re: [Mesa-dev] [PATCH] egl: Account for default values of texture target and format

2016-06-02 Thread Anuj Phogat
On Wed, Jun 1, 2016 at 11:59 AM, Anuj Phogat wrote: > > On Wed, Jun 1, 2016 at 9:31 AM, Plamena Manolova > wrote: > > > > When validating attributes during surface creation we should account > > for the default values of texture target and

Re: [Mesa-dev] [PATCH 16.1/24] i965/vec4: Fix cmod propagation not to propagate non-identity cmod into CMP(N).

2016-06-02 Thread Jason Ekstrand
R-B On Wed, Jun 1, 2016 at 5:17 PM, Francisco Jerez wrote: > The conditional mod of these instructions determines the semantics of > the comparison itself (rather than being evaluated based on the result > of the instruction as is usually the case for most other

Re: [Mesa-dev] [PATCH] [rfc] mesa/program_resource: return -1 for index if no location.

2016-06-02 Thread Dave Airlie
ping? On 24 May 2016 at 06:43, Dave Airlie wrote: > From: Dave Airlie > > The GL4.5 spec quote seems clear on this: > "The value -1 will be returned by either command if an error occurs, > if name does not identify an active variable on programInterface,

Re: [Mesa-dev] [android-x86-devel] [PATCH 2/3] android: libmesa_glsl: add a dependency on libmesa_nir static

2016-06-02 Thread Rob Herring
On Tue, May 31, 2016 at 9:20 AM, Emil Velikov wrote: > On 30 May 2016 at 23:20, Mauro Rossi wrote: >> Fixes the following building error: >> >> target C++: libmesa_glsl <= external/mesa/src/compiler/glsl/glsl_to_nir.cpp >> In file included from

Re: [Mesa-dev] [PATCH 2/2] isl: add support for Android libmesa_isl static library

2016-06-02 Thread Rob Herring
On Thu, Jun 2, 2016 at 2:15 PM, Mauro Rossi wrote: > isl library is needed to build i965, libmesa_isl static library is added > to fix related Android building errors. > > Any attempt to build libmesa_genxml as phony package module failed to deliver > gen{7,75,8,9}_pack.h

Re: [Mesa-dev] [PATCH 1/2] isl: remove unneeded isl_format_layout.c in Makefile.sources

2016-06-02 Thread Rob Herring
On Thu, Jun 2, 2016 at 2:15 PM, Mauro Rossi wrote: > Source files should be defined only once in Makefile.source > As a side note isl_surface.c is not an unneeded duplicate > and must stay defined in ISL_GEN{7,75,8,9}_FILES I built against AOSP master. Tested-by: Rob

Re: [Mesa-dev] [PATCH] egl: fix build after introduction of new member in _egl_thread_info

2016-06-02 Thread Tobias Klausmann
On 02.06.2016 23:54, Rob Herring wrote: On Thu, Jun 2, 2016 at 4:45 PM, Tobias Klausmann wrote: Starting with commit e8b38ca202fbe8c281aeb81a4b64256983f185e0 the dummy_thread misses the proper intialization for the new member, leading to the error stated

Re: [Mesa-dev] [PATCH] egl: fix build after introduction of new member in _egl_thread_info

2016-06-02 Thread Rob Herring
On Thu, Jun 2, 2016 at 4:45 PM, Tobias Klausmann wrote: > Starting with commit e8b38ca202fbe8c281aeb81a4b64256983f185e0 the dummy_thread > misses the proper intialization for the new member, leading to the error > stated > at the bottom. This patch

Re: [Mesa-dev] GBM YUV planar support

2016-06-02 Thread Stéphane Marchesin
On Thu, Jun 2, 2016 at 2:41 PM, Kristian Høgsberg wrote: > On Thu, Jun 2, 2016 at 11:52 AM, Rob Herring wrote: >> On Thu, Jun 2, 2016 at 1:31 PM, Rob Clark wrote: >>> On Thu, Jun 2, 2016 at 1:51 PM, Rob Herring wrote:

[Mesa-dev] [PATCH] egl: fix build after introduction of new member in _egl_thread_info

2016-06-02 Thread Tobias Klausmann
Starting with commit e8b38ca202fbe8c281aeb81a4b64256983f185e0 the dummy_thread misses the proper intialization for the new member, leading to the error stated at the bottom. This patch initializes the new member. Signed-off-by: Tobias Klausmann CC

Re: [Mesa-dev] GBM YUV planar support

2016-06-02 Thread Kristian Høgsberg
On Thu, Jun 2, 2016 at 11:52 AM, Rob Herring wrote: > On Thu, Jun 2, 2016 at 1:31 PM, Rob Clark wrote: >> On Thu, Jun 2, 2016 at 1:51 PM, Rob Herring wrote: >>> As discussed on irc yesterday, I've been looking at adding YUV planar >>>

[Mesa-dev] [PATCH 3/5] nir/spirv: Add a way to print non-fatal warnings

2016-06-02 Thread Jason Ekstrand
Signed-off-by: Jason Ekstrand Cc: "12.0" --- src/compiler/spirv/spirv_to_nir.c | 16 src/compiler/spirv/vtn_private.h | 3 +++ 2 files changed, 19 insertions(+) diff --git a/src/compiler/spirv/spirv_to_nir.c

[Mesa-dev] [PATCH 4/5] nir/spirv: Make unhandled decorations and capabilities non-fatal

2016-06-02 Thread Jason Ekstrand
glslang frequently throw bogus decorations into shaders. While we are free to assert-fail, it's a bit nicer to the application to just warn. Signed-off-by: Jason Ekstrand Cc: "12.0" --- src/compiler/spirv/spirv_to_nir.c | 38

[Mesa-dev] [PATCH 1/5] nir/spirv: Complete the list of capabilities

2016-06-02 Thread Jason Ekstrand
Previously we supported a subset of capabilities and just left a default case for the others. It's time to stop being lazy and actually audit the capabilities. This should bring them up-to-date with reality. Signed-off-by: Jason Ekstrand Cc: "12.0"

[Mesa-dev] [PATCH 5/5] nir/spirv: Make a decoration switch complete

2016-06-02 Thread Jason Ekstrand
Getting rid of the default case makes the compiler warn if we are missing cases. While we're here, we also add the one missing case. Signed-off-by: Jason Ekstrand Cc: "12.0" --- src/compiler/spirv/spirv_to_nir.c | 4 +--- 1 file

[Mesa-dev] [PATCH 2/5] nir/spirv: Add string lookup tables for a couple of SPIR-V enums

2016-06-02 Thread Jason Ekstrand
Signed-off-by: Jason Ekstrand Cc: "12.0" --- src/compiler/Makefile.sources | 2 + src/compiler/spirv/spirv_info.c | 150 src/compiler/spirv/spirv_info.h | 27 3 files changed, 179

Re: [Mesa-dev] [PATCH 1/5] mesa: Pass gl_constant_value union into _mesa_fetch_state().

2016-06-02 Thread Dave Airlie
On 3 June 2016 at 07:09, Kenneth Graunke wrote: > We've had some trouble in the past with copying integers around via > float pointers, as the C compiler sometimes uses x87 floating point > registers to load values on 32-bit systems. Passing the > gl_constant_value union

[Mesa-dev] [PATCH 5/5] i965: Use a uniform for gl_PatchVerticesIn in the TCS on Gen8+.

2016-06-02 Thread Kenneth Graunke
We still need to recompile the passthrough shader when this value changes, as it also affects the output vertex count. But otherwise, we can eliminate recompiles on Gen8+. We probably want to do this for Gen7 as well, but that requires rewriting the input release code to use a loop, which is a

[Mesa-dev] [PATCH 1/5] mesa: Pass gl_constant_value union into _mesa_fetch_state().

2016-06-02 Thread Kenneth Graunke
We've had some trouble in the past with copying integers around via float pointers, as the C compiler sometimes uses x87 floating point registers to load values on 32-bit systems. Passing the gl_constant_value union should be safer. To avoid churn, this patch creates a "GLfloat *value" variable

[Mesa-dev] [PATCH 3/5] i965: Use a uniform for gl_PatchVerticesIn in the TES.

2016-06-02 Thread Kenneth Graunke
Fixes GL44-CTS.tessellation_shader.single.max_patch_vertices, which uses gl_PatchVerticesIn in the TES, but doesn't link against a TCS (which would allow the linker to lower it to a constant). Signed-off-by: Kenneth Graunke Cc: mesa-sta...@lists.freedesktop.org ---

[Mesa-dev] [PATCH 4/5] glsl: Optionally lower TCS gl_PatchVerticesIn to a uniform.

2016-06-02 Thread Kenneth Graunke
i965 has no special hardware for this, so the best way to implement this is to pass it in via a uniform. Signed-off-by: Kenneth Graunke Cc: mesa-sta...@lists.freedesktop.org --- src/compiler/glsl/builtin_variables.cpp | 13 - src/mesa/main/mtypes.h

[Mesa-dev] [PATCH 2/5] glsl: Optionally lower TES gl_PatchVerticesIn to a uniform.

2016-06-02 Thread Kenneth Graunke
i965 has no special hardware for this, so we need to pass this value in as a uniform (unless the TES is linked against a TCS, in which case the linker can just replace this with a constant). Signed-off-by: Kenneth Graunke Cc: mesa-sta...@lists.freedesktop.org ---

Re: [Mesa-dev] [PATCH] radeonsi: mark buffer texture range valid for shader images

2016-06-02 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Thu, Jun 2, 2016 at 10:23 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > When a shader image view into a buffer texture can be written to, the buffer's > valid range must be updated, or

Re: [Mesa-dev] [PATCH] st/mesa: fix resource leak in try_pbo_readpixels

2016-06-02 Thread Nicolai Hähnle
On 02.06.2016 22:53, Ilia Mirkin wrote: On Thu, Jun 2, 2016 at 4:50 PM, Nicolai Hähnle wrote: From: Nicolai Hähnle Found by inspection after seeing https://bugs.freedesktop.org/show_bug.cgi?id=96343 --- src/mesa/state_tracker/st_cb_readpixels.c

Re: [Mesa-dev] [PATCH] st/mesa: fix resource leak in try_pbo_readpixels

2016-06-02 Thread Ilia Mirkin
On Thu, Jun 2, 2016 at 4:50 PM, Nicolai Hähnle wrote: > From: Nicolai Hähnle > > Found by inspection after seeing > https://bugs.freedesktop.org/show_bug.cgi?id=96343 > --- > src/mesa/state_tracker/st_cb_readpixels.c | 2 ++ > 1 file changed, 2

[Mesa-dev] [PATCH] st/mesa: fix resource leak in try_pbo_readpixels

2016-06-02 Thread Nicolai Hähnle
From: Nicolai Hähnle Found by inspection after seeing https://bugs.freedesktop.org/show_bug.cgi?id=96343 --- src/mesa/state_tracker/st_cb_readpixels.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mesa/state_tracker/st_cb_readpixels.c

Re: [Mesa-dev] GBM YUV planar support

2016-06-02 Thread Rob Clark
On Thu, Jun 2, 2016 at 2:52 PM, Rob Herring wrote: > On Thu, Jun 2, 2016 at 1:31 PM, Rob Clark wrote: >> On Thu, Jun 2, 2016 at 1:51 PM, Rob Herring wrote: >>> As discussed on irc yesterday, I've been looking at adding YUV planar >>> (YV12)

[Mesa-dev] [PATCH] radeonsi: mark buffer texture range valid for shader images

2016-06-02 Thread Nicolai Hähnle
From: Nicolai Hähnle When a shader image view into a buffer texture can be written to, the buffer's valid range must be updated, or subsequent transfers may incorrectly skip synchronization. This fixes a bug that was exposed in Xephyr by PBO acceleration for

Re: [Mesa-dev] [PATCH v2] mesa/formatquery: expand NUM_SAMPLE_COUNTS OpenGL ES comment

2016-06-02 Thread Ian Romanick
This patch is Reviewed-by: Ian Romanick On 06/01/2016 11:38 PM, Alejandro Piñeiro wrote: > For ES 3.0 NUM_SAMPLE_COUNTS spec points that some formats will be > always zero. But on ES 3.1 can be different to zero. > > The current code is correctly checking exactly

[Mesa-dev] [PATCH v2] platform_android: prevent deadlock in droid_swap_buffers

2016-06-02 Thread Haixia Shi
To avoid blocking other EGL calls, release the display mutex before we enqueue buffer to android frameworks and re-acquire the mutex upon return. v2: moved lock/unlock inside droid_window_enqueue_buffer(). TEST=verify pinch zoom in Photos app no longer causes hangs Signed-off-by: Haixia Shi

[Mesa-dev] [PATCH 2/2] isl: add support for Android libmesa_isl static library

2016-06-02 Thread Mauro Rossi
isl library is needed to build i965, libmesa_isl static library is added to fix related Android building errors. Any attempt to build libmesa_genxml as phony package module failed to deliver gen{7,75,8,9}_pack.h generated headers, needed for libmesa_isl_gen{7,75,8,9} Due to constraints in

[Mesa-dev] isl support for Android (final version)

2016-06-02 Thread Mauro Rossi
As agreed with Emil, I'm sending a respin of isl for Android, without python3 macro definition in main Android.mk, since not needed anymore, and with a few optimizations in makefiles. In order to backport to mesa-stable the patches, which is recommended, the patches that remove python3 features

[Mesa-dev] [PATCH 1/2] isl: remove unneeded isl_format_layout.c in Makefile.sources

2016-06-02 Thread Mauro Rossi
Source files should be defined only once in Makefile.source As a side note isl_surface.c is not an unneeded duplicate and must stay defined in ISL_GEN{7,75,8,9}_FILES --- src/intel/isl/Makefile.sources | 1 - 1 file changed, 1 deletion(-) diff --git a/src/intel/isl/Makefile.sources

Re: [Mesa-dev] [PATCH] blorp: Fix 16x multisample scaled blits

2016-06-02 Thread Jason Ekstrand
On Thu, Jun 2, 2016 at 11:34 AM, Anuj Phogat wrote: > Piglit test ext_framebuffer_multisample_blit_scaled-blit-scaled > (with added 16x sample support) now passes with this patch. > > Signed-off-by: Anuj Phogat > Cc: Jason Ekstrand

Re: [Mesa-dev] GBM YUV planar support

2016-06-02 Thread Rob Herring
On Thu, Jun 2, 2016 at 1:31 PM, Rob Clark wrote: > On Thu, Jun 2, 2016 at 1:51 PM, Rob Herring wrote: >> As discussed on irc yesterday, I've been looking at adding YUV planar >> (YV12) to GBM as it is a requirement for Android gralloc. It is >> possible to

Re: [Mesa-dev] [PATCH V2] meta: Fix indentation in shader code

2016-06-02 Thread Matt Turner
Acked-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] blorp: Fix 16x multisample scaled blits

2016-06-02 Thread Anuj Phogat
Piglit test ext_framebuffer_multisample_blit_scaled-blit-scaled (with added 16x sample support) now passes with this patch. Signed-off-by: Anuj Phogat Cc: Jason Ekstrand Cc: "12.0" ---

Re: [Mesa-dev] GBM YUV planar support

2016-06-02 Thread Rob Clark
On Thu, Jun 2, 2016 at 1:51 PM, Rob Herring wrote: > As discussed on irc yesterday, I've been looking at adding YUV planar > (YV12) to GBM as it is a requirement for Android gralloc. It is > possible to disable the requirement as that is what the Android > emulator and

[Mesa-dev] [PATCH V2] meta: Fix indentation in shader code

2016-06-02 Thread Anuj Phogat
Signed-off-by: Anuj Phogat --- src/mesa/drivers/common/meta_blit.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/common/meta_blit.c b/src/mesa/drivers/common/meta_blit.c index 20d3215..d6d3a42 100644 ---

[Mesa-dev] [PATCH] meta: Fix indentation in shader code

2016-06-02 Thread Anuj Phogat
Signed-off-by: Anuj Phogat --- src/mesa/drivers/common/meta_blit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/common/meta_blit.c b/src/mesa/drivers/common/meta_blit.c index 20d3215..01abaf4 100644 ---

Re: [Mesa-dev] [PATCH] mesa: Enable LTO compilation

2016-06-02 Thread
Hello. The patch has moved to http://lists.freedesktop.org/archives/mesa-dev/2016-June/119257.html ( http://patchwork.freedesktop.org/series/8176/) ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

[Mesa-dev] GBM YUV planar support

2016-06-02 Thread Rob Herring
As discussed on irc yesterday, I've been looking at adding YUV planar (YV12) to GBM as it is a requirement for Android gralloc. It is possible to disable the requirement as that is what the Android emulator and android-x86 do. But that results in un-optimized s/w CSC. Given most/all Android

[Mesa-dev] [PATCH] mapi: fix LTO compilation

2016-06-02 Thread
LTO compilation can sometimes fail with GCC 4.9 and GCC 5.3 because src/mapi uses unusual mixing of C code and assembly code. The issue may be present in case of GCC 6.1 as well. This is a Mesa bug rather than a compiler bug (although in an ideal world the compilation with -flto should fail if

Re: [Mesa-dev] [PATCH] mesa/copyimage: fix num samples check to handle renderbuffers.

2016-06-02 Thread Nicolai Hähnle
Reviewed-by: Nicolai Hähnle On 02.06.2016 05:42, Dave Airlie wrote: From: Dave Airlie This test was only happening for textures, but there is nothing in the spec to say this, so test it for all cases. This fixes:

Re: [Mesa-dev] [PATCH] mesa/copyimage: report INVALID_VALUE for missing cube array

2016-06-02 Thread Antía Puentes
On jue, 2016-06-02 at 14:25 +1000, Dave Airlie wrote: > From: Dave Airlie > > The specs says INVALID_VALUE for exceeding dimensions, > which is really what is happening here. > > This fixes: > GL45-CTS.copy_image.non_existent_mipmap > > Signed-off-by: Dave Airlie

Re: [Mesa-dev] Mesa (master): st/mesa: implement PBO downloads for ReadPixels

2016-06-02 Thread Nicolai Hähnle
Hi Michel, thanks for letting me know. I can reproduce this on my Tonga, will look into it soon. Cheers, Nicolai On 02.06.2016 15:12, Michel Dänzer wrote: On 02.06.2016 05:44, Nicolai =?UNKNOWN?Q?H=C3=A4hnle?= wrote: Module: Mesa Branch: master Commit:

Re: [Mesa-dev] [PATCH 10/10] gallium/radeon: don't use the DMA ring for pipelined buffer uploads

2016-06-02 Thread
Some R9 390 results: Tomb Raider (normal settings): 80 -> 88 FPS Talos Principle (custom settings): 23 -> 56 FPS Metro Last Light Redux (default benchmark settings): 39 -> 40 FPS ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org

Re: [Mesa-dev] [PATCH] gallium/util: remove u_staging

2016-06-02 Thread Marek Olšák
Acked-by: Marek Olšák Marek On Thu, Jun 2, 2016 at 4:15 PM, Rob Clark wrote: > From: Rob Clark > > Unused, and fixes a couple of coverity warnings: CID 1362171, 1362170 > > Signed-off-by: Rob Clark

[Mesa-dev] [PATCH] gallium/util: remove u_staging

2016-06-02 Thread Rob Clark
From: Rob Clark Unused, and fixes a couple of coverity warnings: CID 1362171, 1362170 Signed-off-by: Rob Clark --- src/gallium/auxiliary/Makefile.sources | 2 - src/gallium/auxiliary/util/u_staging.c | 136 -

[Mesa-dev] [PATCH] st/va: use proper temp pipe_video_buffer template

2016-06-02 Thread Julien Isorce
Instead of changing the format on the existing template which makes error handling not nice and confuses coverity. CoverityID: 1337953 Signed-off-by: Julien Isorce --- src/gallium/state_trackers/va/image.c | 8 1 file changed, 4 insertions(+), 4 deletions(-)

[Mesa-dev] [PATCH] st/va: it is valid to release the VABuffer of an exported resource

2016-06-02 Thread Julien Isorce
Signed-off-by: Julien Isorce --- src/gallium/state_trackers/va/buffer.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/src/gallium/state_trackers/va/buffer.c b/src/gallium/state_trackers/va/buffer.c index 2fd8661..7d3167b 100644 ---

[Mesa-dev] [PATCH v2] st/va: ensure linear memory for dmabuf

2016-06-02 Thread Julien Isorce
In order to do zero-copy between two different devices the memory should not be tiled. This is currently no way to set pipe_resource template's flag from pipe_video_buffer template. So disabled_tiling is added. Choosed "disable" prefix so that CALLOC keeps tiling enabled by default. Tested with

Re: [Mesa-dev] [PATCH 1/2] i965: Add _NEW_POINT to a couple of comments.

2016-06-02 Thread Iago Toral
Reviewed-by: Iago Toral Quiroga On Wed, 2016-06-01 at 21:25 -0700, Kenneth Graunke wrote: > Signed-off-by: Kenneth Graunke > Cc: "12.0" > --- > src/mesa/drivers/dri/i965/gen6_sf_state.c | 2 +- >

Re: [Mesa-dev] [PATCH 2/2] i965: Fix point size with tessellation/geometry shaders.

2016-06-02 Thread Ilia Mirkin
I don't think that's right. Have a look at my st/Mesa patch which fixed the same thing. The issue is that es2 always enables point size from shader, so you need to apply that sort of logic. However on desktop, you still have to respect the GL program point size setting. On Jun 2, 2016 12:26 AM,

Re: [Mesa-dev] Mesa (master): st/mesa: implement PBO downloads for ReadPixels

2016-06-02 Thread Michel Dänzer
On 02.06.2016 05:44, Nicolai =?UNKNOWN?Q?H=C3=A4hnle?= wrote: > Module: Mesa > Branch: master > Commit: ed0e9862c56d13381f0414b5a835fd31960edfe6 > URL: > http://cgit.freedesktop.org/mesa/mesa/commit/?id=ed0e9862c56d13381f0414b5a835fd31960edfe6 > > Author: Nicolai Hähnle

Re: [Mesa-dev] Mesa (master): gallium/radeon: degrade tiled textures mapped often to linear

2016-06-02 Thread Michel Dänzer
On 02.06.2016 00:35, Marek =?UNKNOWN?B?T2zFocOhaw==?= wrote: > Module: Mesa > Branch: master > Commit: fc1479a95432f291623fa5bafe524701e77af3ca > URL: > http://cgit.freedesktop.org/mesa/mesa/commit/?id=fc1479a95432f291623fa5bafe524701e77af3ca > > Author: Marek Olšák >

Re: [Mesa-dev] Mesa (master): radeonsi: set some image descriptor fields at bind time

2016-06-02 Thread Michel Dänzer
On 02.06.2016 00:35, Marek =?UNKNOWN?B?T2zFocOhaw==?= wrote: > Module: Mesa > Branch: master > Commit: 95c5bbae66af3ca1f805d94f6fe8d8e4ba2c9c43 > URL: > http://cgit.freedesktop.org/mesa/mesa/commit/?id=95c5bbae66af3ca1f805d94f6fe8d8e4ba2c9c43 > > Author: Marek Olšák >

Re: [Mesa-dev] [PATCH] st/va: restore old buffer format on error

2016-06-02 Thread Julien Isorce
no problem, it was actually good, I think that even if current code is correct, I'll still submit the new diff for review because it looks better. On 2 June 2016 at 10:34, Eric Engestrom wrote: > On Tue, May 31, 2016 at 02:54:06PM +0200, Christian König wrote: > > On

Re: [Mesa-dev] [PATCH 7/9] anv/pipeline: Silently pass tests if depth or stencil is missing

2016-06-02 Thread Grazvydas Ignotas
On Thu, Jun 2, 2016 at 12:44 AM, Jason Ekstrand wrote: > Signed-off-by: Jason Ekstrand > Cc: "12.0" > Cc: Ian Romanick > --- > src/intel/vulkan/gen7_pipeline.c | 12 ++-- >

Re: [Mesa-dev] [PATCH] st/va: restore old buffer format on error

2016-06-02 Thread Eric Engestrom
On Tue, May 31, 2016 at 02:54:06PM +0200, Christian König wrote: > On the other hand the original code was correct in the first place. > > And as Julien noted Coverity tries to restore the template buffer format > from a local variable which doesn't exists any more where you wanted to add > the

Re: [Mesa-dev] [PATCH] st/osmesa: remove double-write (overwriting)

2016-06-02 Thread Eric Engestrom
On Tue, May 31, 2016 at 06:33:53AM -0600, Brian Paul wrote: > On 05/30/2016 07:26 PM, Eric Engestrom wrote: > > These two lines have been here since the file was created. > > I'm guessing the second one was just for testing during dev, so it's the > > one that's going away. > > > > CoverityID:

Re: [Mesa-dev] [PATCH] st/vdpau: check for null pointer in get/put bits.

2016-06-02 Thread Christian König
Am 02.06.2016 um 08:41 schrieb Nayan Deshmukh: Check for null pointer before accessing arrays in get/put bits native/YCbCr/Indexed in VdpOutputSurface and VdpVideoSurface. Signed-off-by: Nayan Deshmukh Reviewed and pushed. Thanks for the help, Christian. ---

[Mesa-dev] [PATCH v1.1 2/2] clover: fix getting scalar args api size

2016-06-02 Thread Serge Martin
This fix getting the size of a struct arg. vec3 types still work ok. Only buit-in args need to have power of two alignment, getTypeAllocSize reports the correct size. Cc: 12.0 --- src/gallium/state_trackers/clover/llvm/invocation.cpp | 7 +++ 1 file

Re: [Mesa-dev] [PATCH 0/5] ARB_internalformat_query2 support for OpenGL ES and other fixes

2016-06-02 Thread Alejandro Piñeiro
On 01/06/16 20:57, Ian Romanick wrote: > On 06/01/2016 11:35 AM, Alejandro Piñeiro wrote: >> On 13/05/16 23:20, Alejandro Piñeiro wrote: >>> On 13/05/16 17:06, Ilia Mirkin wrote: On Fri, May 13, 2016 at 10:57 AM, Alejandro Piñeiro wrote: > Earlier this year the

Re: [Mesa-dev] [PATCH 4/5] mesa/glformats: add desktop gl checks on _mesa_base_tex_format

2016-06-02 Thread Alejandro Piñeiro
On 01/06/16 22:07, Ian Romanick wrote: > On 05/13/2016 07:57 AM, Alejandro Piñeiro wrote: >> There are several internalformat that are not supported on gl es, so >> it should return -1 if that is the case. This is needed in order to >> get ARB_internalformat_query2 implementation deciding

Re: [Mesa-dev] [PATCH 11/29] mesa: Use bitmask/ffs to iterate enabled lights for building ff shader keys.

2016-06-02 Thread Mathias Fröhlich
Hi Erik, On Tuesday, May 31, 2016 16:41:46 Erik Faye-Lund wrote: > On Sat, May 28, 2016 at 12:31 PM, Mathias Fröhlich > wrote: > > So the xor mask handing is non local to the place where we do the > > computation of i. > > > > Brian pointed me to the u_bit_scan

[Mesa-dev] [PATCH] st/vdpau: check for null pointer in get/put bits.

2016-06-02 Thread Nayan Deshmukh
Check for null pointer before accessing arrays in get/put bits native/YCbCr/Indexed in VdpOutputSurface and VdpVideoSurface. Signed-off-by: Nayan Deshmukh --- src/gallium/state_trackers/vdpau/output.c | 6 ++ src/gallium/state_trackers/vdpau/surface.c | 6 ++

[Mesa-dev] [PATCH v2] mesa/formatquery: expand NUM_SAMPLE_COUNTS OpenGL ES comment

2016-06-02 Thread Alejandro Piñeiro
For ES 3.0 NUM_SAMPLE_COUNTS spec points that some formats will be always zero. But on ES 3.1 can be different to zero. The current code is correctly checking exactly against version 3.0, but the comment only mentions 3.0 spec. It is clearer mentioning both. v2: better wording on the comment

Re: [Mesa-dev] V2 On disk shader cache for i965

2016-06-02 Thread Timothy Arceri
On Wed, 2016-06-01 at 16:22 +1000, Timothy Arceri wrote: > V2:  > - rebased on master > - add support for encoding doubles > - create shaders correctly (call  >  _mesa_HashFindFreeKeyBlock(ctx->Shared->ShaderObjects, 1) to get a > name) stops >  a crash when delete shader is called. The above

[Mesa-dev] [PATCH 69/68] glsl: don't try to load/store SSBOs values in the cache

2016-06-02 Thread Timothy Arceri
Also add an assert to catch buffer overflows. --- src/compiler/glsl/shader_cache.cpp | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/src/compiler/glsl/shader_cache.cpp b/src/compiler/glsl/shader_cache.cpp index 52982cf..d37d5b0 100644 ---